Gitiles
Code Review Sign In
gerrit.lfbroadband.org / voltha-openonu-adapter-go / f405e961faeba5349b39d3d64a757b10766af75a
commitf405e961faeba5349b39d3d64a757b10766af75a[log] [tgz]
authorpraneeth nalmas <praneeth.nalmas@radisys.com>Mon Aug 07 15:02:03 2023 +0530
committerPraneeth Kumar Nalmas <praneeth.nalmas@radisys.com>Fri Dec 29 12:16:16 2023 +0530
tree75a2dd754b1c3abaf0a77c8c7b0b542593ab093d
parentc7c0bceccf4868873ce1b757495d7c801e82c533 [diff]
VOL-5113:OnuAdapter crashes Intermittently while processing onu indication during scale tests

RCA:1) The ONU discovery is successfully completed.
2) As part of the ONU Indication processing , during creating the interface an OMCI test is performed before we start MIB upload process.
3) OMCI requests are sent and while we wait for the response we maintain a timeout.
4) Simultaneously , a delete request for this device has triggered clean
 up of the device objects , the ONU indication goroutine wakes up after timeout in a case when the OLT is unable to process the OMCI requests
and acccess an invalid object causing a segmentation fault.

Change-Id: Ifcb64d86854ddb4e2d4857897cc9789128410015
4 files changed
tree: 75a2dd754b1c3abaf0a77c8c7b0b542593ab093d
  1. .gitignore
  2. .gitreview
  3. .golangci.yml
  4. Makefile
  5. README.md
  6. VERSION
  7. cmd/
  8. docker/
  9. docs/
  10. go.mod
  11. go.sum
  12. internal/
  13. makefiles/
  14. pkg/
  15. templates/
  16. vendor/
README.md

OpenONU adapter

The OpenONU adapter provides communication capabilities via OMCI to the ONU devices to be managed by the voltha system.

Additional documentation can be found in docs

Development make targets

The Makefile contains many commands that are useful in development:

build                     : Alias for 'docker build'
clean                     : Removes any local filesystem artifacts generated by a build
distclean                 : Removes any local filesystem artifacts generated by a build or test run
docker-build              : Build openonu adapter docker image (set BUILD_PROFILED=true to also build the profiled image)
docker-kind-load          : Load docker images into a KinD cluster
docker-push               : Push the docker images to an external repository
help                      : Print help for each Makefile target
lint-dockerfile           : Perform static analysis on Dockerfile
lint                      : Run all lint targets
lint-mod                  : Verify the Go dependencies
lint-sanity               : Perform basic code checks on source
lint-style                : Perform lint style checks on source code
local-lib-go              : Copies a local version of the voltha-lib-go dependency into the vendor directory
local-protos              : Copies a local version of the voltha-protos dependency into the vendor directory
mod-update                : Update go mod files
sca                       : Runs static code analysis with the golangci-lint tool
test                      : Run unit tests

Some highlights:

  • It's recommended that you run the lint, sca, and test targets before submitting code changes.

  • The docker-* targets for building and pushing Docker images depend on the variables DOCKER_REGISTRY, DOCKER_REPOSITORY, and DOCKER_TAG as described in the CORD documentation

  • If you make changes the dependencies in the go.mod file, you will need to run make mod-update to update the go.sum and vendor directory.

Building with a Local Copy of voltha-protos or voltha-lib-go

If you want to build/test using a local copy of the voltha-protos or voltha-lib-go libraries this can be accomplished by using the environment variables LOCAL_PROTOS and LOCAL_LIB_GO. These environment variables should be set to the filesystem path where the local source is located, e.g.:

export LOCAL_PROTOS=/path/to/voltha-protos
export LOCAL_LIB_GO=/path/to/voltha-lib-go

Then run make local-protos and/or make local-lib-go as is appropriate to copy them into the vendor directory.

NOTE: That the files in the vendor directory are no longer what is in the most recent commit, and it will take manual git intervention to put the original files back.