)]}'
{
  "commit": "433a31a7ee7834d8c53f5c820081c24a81d85928",
  "tree": "7c78f5b42996f906aa16bd0324906f636f7c5c1a",
  "parents": [
    "0db4c81889d8231e4b89832378815e0e7a5f2291"
  ],
  "author": {
    "name": "Kent Hagerman",
    "email": "khagerma@ciena.com",
    "time": "Wed May 20 19:04:48 2020 -0400"
  },
  "committer": {
    "name": "Kent Hagerman",
    "email": "khagerma@ciena.com",
    "time": "Mon Jun 01 16:32:34 2020 -0400"
  },
  "message": "VOL-3121 - Separated out LogicalDevices\u0027 low-level flow/meter/group handling into separate packages.\n\nThe new implementation hides the compexity of locking, caching, and interacting with the db.\nAn attempt was made to ensure that locks are held while updates are made, by returning a \"handle\" object from each flow/group/meter lock() call, and only allowing access through this call.\n\nAn attempt was also made to remove proto.Clone-ing.  flows/groups/meters which are returned are NOT cloned, and MUST NOT be modified by users of the flow/group/meter loaders.  In addition, flows/groups/meters which are given to the loaders MUST NOT be modified afterward.\n\nThere remain many cases where errors during particular kv updates may cause inconsistent state.  TODOs have been added for many of these cases.  Resolving this may require exposing (through voltha-lib-go) the transaction mechanism from etcd.\n\nThere is also the issue that locking a flow/meter/group while another flow/meter/group is held could cause deadlocks.  This can be avoided by acquiring locks in a consistent order.  Something to keep in mind while fixing the previous issue.\nChange-Id: I146eb319c3564635fdc461ec17be13e6f3968cf7\n",
  "tree_diff": [
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "ca8bb6a1604fdd74a3e704726b07ebfd8ae221d4",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/flow/common.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "741a45ffd81fb548269be7326792c3c0ab87650f",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/flow/loader.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b73927211823a807c777febb55cd2e3fa9a6288b",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/flow/loader_test.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "016dfffb826f8485109450494bb9c6dc92cb11b7",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/group/common.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "0e3f078fdec56c9e73d07a1554d7ca3868b75667",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/group/loader.go"
    },
    {
      "type": "modify",
      "old_id": "7723b74531ab9d540fa21eb6a032765465c2af67",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent.go",
      "new_id": "dbb2da5c4a74cb0efc0f7af1cdbd8e208056c0eb",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/logical_agent.go"
    },
    {
      "type": "modify",
      "old_id": "0e811e761571488bbd6be45fa8eab42e2834afae",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent_flow.go",
      "new_id": "b06b0f78e2287ebac2d264a627b1855db7a87eb2",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/logical_agent_flow.go"
    },
    {
      "type": "delete",
      "old_id": "84d1a47bc199737ab37eb4aff7fb7efd61213926",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent_flow_loader.go",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "73caa071115e5b5ecd8bbf7282a4e2f54465239f",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent_group.go",
      "new_id": "e126fdc2280d9024da3774152c42453d238fe357",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/logical_agent_group.go"
    },
    {
      "type": "delete",
      "old_id": "53e4076a58e2a6db069b280ab2bd9262e32f5b2e",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent_group_loader.go",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "c211f1e99fa7b2b972e0816d18661f0f8344869e",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent_meter.go",
      "new_id": "dc44fda153584f51b8cfadee97f038d49b3ee26c",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/logical_agent_meter.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "fc0956838e11c479ee4a8b5e671a87a48997a4dd",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/logical_agent_meter_helpers.go"
    },
    {
      "type": "delete",
      "old_id": "4408bf17520f08cc703a5652c2850ee9d782d8cf",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent_meter_loader.go",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "8ec54546c3c0d2888c5f0f5cc62a6f5865ec6c08",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_agent_test.go",
      "new_id": "f5d404e0ab426b8f7db1daee04098a731d7bdd36",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/logical_agent_test.go"
    },
    {
      "type": "modify",
      "old_id": "d9b6731ba086a8d28e39c4965d28f37189256f7b",
      "old_mode": 33188,
      "old_path": "rw_core/core/device/logical_manager.go",
      "new_id": "cd7bce12f9a6f4f5337e1a7e81a70d8306a4b134",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/logical_manager.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "81f7b1497f7ca937e8ec015178965b143f7e98e3",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/meter/common.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "ae6c9579eb39ae40f750aa3e11800d521154524b",
      "new_mode": 33188,
      "new_path": "rw_core/core/device/meter/loader.go"
    },
    {
      "type": "modify",
      "old_id": "f16477fef84c5bc24c282e534a2d8097572959fb",
      "old_mode": 33188,
      "old_path": "rw_core/flowdecomposition/flow_decomposer.go",
      "new_id": "eb338dbf9400f9e9a34406961f4a7cbdeaac2a2f",
      "new_mode": 33188,
      "new_path": "rw_core/flowdecomposition/flow_decomposer.go"
    },
    {
      "type": "modify",
      "old_id": "eb7ad754e589d4d8d05b1fe738eb882519cd5fd9",
      "old_mode": 33188,
      "old_path": "rw_core/flowdecomposition/flow_decomposer_test.go",
      "new_id": "4c6ca8ce96d62c780a957fd48f7f34532222cbaa",
      "new_mode": 33188,
      "new_path": "rw_core/flowdecomposition/flow_decomposer_test.go"
    }
  ]
}