)]}' { "log": [ { "commit": "5bc62ca9561fa01a989e386cbf6e71cbdef77a3c", "tree": "280eb7047661122253bfbcce62cac8445eba4acd", "parents": [ "40fc3dda2b7a345e447d2ef355108c987e59ed13" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Mon Jul 11 16:21:23 2016 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jan 23 18:51:58 2017 +0000" }, "message": "isisd,ospf6d,bgpd: Fix GCC 6 warnings on indentation not matching control flow\n\nGCC 6 can now give warnings when the indentation of code does not\nalign with the scope of prior control flow statement(s). I.e., where\nthe code visually suggests one kind of control flow, but in actuality\nfollows another.\n\nFix warnings found. They all seem to be simple cases of the indentation being\ndeceptive, but the existing flow being correct.\n" }, { "commit": "7ae2b609875756663e0a7d677609d04baa04b613", "tree": "a8ca729e499968e33344208f5a52ece09a6af091", "parents": [ "ddc160cce1767ef006a812f5213cabfb24e3cd4d" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Sat Oct 01 06:41:40 2016 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jan 23 18:51:56 2017 +0000" }, "message": "ospf6d: add support for route tags\n\n[ported by Paul Jakma, paul@jakma.org]\n" }, { "commit": "8db38639cc4cf796484b352c57f2709151f0e2e4", "tree": "0b31fc87a19b7ac8adbaaef7ef70bbb16f500bcf", "parents": [ "5a7a23b09fed1cb26b901e3160c2f6e560cfd679" ], "author": { "name": "Christian Franke", "email": "nobody@nowhere.ws", "time": "Mon Jun 06 21:49:59 2016 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jan 23 18:51:53 2017 +0000" }, "message": "ospf6d: remove unused broken function\n\nospf6_interface_if_del has not been in use since for quite some\nyears and is broken. (Will crash ospf6d if oi-\u003earea \u003d\u003d NULL)\n\nSince it is not used, just remove it.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nTested-by: NetDEF CI System \u003ccisystem@netdef.org\u003e\nAcked-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "5477ee7b9d8d24d2bb61335c62f3d6c5e99fc901", "tree": "e594369217510323b34f6d8bfe6cd0fda4bc7674", "parents": [ "258f3dad6471a680c2c583a300cfd396efe9a037" ], "author": { "name": "Paul Jakma", "email": "paul@jakma.org", "time": "Wed Jan 11 11:18:22 2017 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jan 19 13:22:50 2017 +0000" }, "message": "Revert \"opsf6d: Update router-LSA when nbr\u0027s interface-ID changes\"\n\nThis reverts commit e509af86e3579944b7cde942ca3ee3427db1936a.\n\nSee Bug #885\n" }, { "commit": "8548973ace90a78035893c3663c18b485425e291", "tree": "e13fa59edf39c65057b728fb81e8866fb5cb33ed", "parents": [ "7fca43f7184f6eb9fbe952f1eecaafcf079502f2" ], "author": { "name": "Christian Franke", "email": "nobody@nowhere.ws", "time": "Tue Jun 14 20:07:04 2016 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Mon Oct 17 17:41:36 2016 +0100" }, "message": "ospf6d: fix off-by-one on display of spf reasons\n\nThe loop should only iterate to array_size - 1.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nAcked-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "7fca43f7184f6eb9fbe952f1eecaafcf079502f2", "tree": "6b6fee2ba5c0877a4032eaaffee6c241ba84dca4", "parents": [ "0d8b32a5ee43ccc4a67dd87ab21a4ab553e3bf44" ], "author": { "name": "Christian Franke", "email": "nobody@nowhere.ws", "time": "Tue Jun 14 20:07:03 2016 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Mon Oct 17 17:41:36 2016 +0100" }, "message": "ospf6d: don\u0027t access nexthops out of bounds\n\nGiven that the \u0026\u0026 is evaluated lazily from left to right,\ni \u003c OSPF6_MULTI_PATH_LIMIT should be checked prior to calling\nospf6_nexthop_is_set on the array element, not the other way around.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nAcked-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "cb9ed1d867f6ac9e0bad85c47aabeb10b94be2e5", "tree": "de6801469dbcb226b5373957638a80bc09e4e0d7", "parents": [ "4f84737dee1e84b7219f66e983812abd8a6ca1d3" ], "author": { "name": "Donald Sharp", "email": "sharpd@cumulusnetworks.com", "time": "Thu Jan 14 09:19:29 2016 -0500" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Oct 04 13:07:52 2016 +0100" }, "message": "ospf6d: Fix double increment of Sequence Number\n\nWhen OSPF6 is creating the header for the ROUTER LSA type\nif the packet being sent has interface information to add\nto the data, the Sequence Number is at least double incremented.\n\nThis commit may cause issues with ANVL 16.10.\n\n[note: folded in:\n \"ospf6d: Fix Some ANVL test cases 16.6 and partial 16.10\"\n -- Paul Jakma]\n\nSigned-off-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "cb37de4c6863c772b654a851c9fe3eeb1f677692", "tree": "602898c0435b1c4ad57afaa15b72d9c1b029d15b", "parents": [ "2153090340f059eb787d72ba973ea55e150e9dec" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue May 19 18:03:40 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Oct 04 13:07:51 2016 +0100" }, "message": "ospf6d: Fix loss of hello\u0027s on interface\n\nSYMPTOM:\n\nWith quagga running on Linux, \u0027ifdown \u003cif-name\u003e\u0027 followed by \u0027ifup \u003cifname\u003e\ncan cause OSPFv3 to not receive Hello packets on the interface.\n\nISSUE:\n\nOperating System\u0027s interface IPv6 readiness may not be guaranteed at the\ntime of interface-up event. Thats because the ipv6 components in an OS may\nalso be listening to the same interface-up event that (in this case) is\nrelayed to OSPFv3.\n\nIn this failure case, setsockopt with option IPV6_JOIN_GROUP on the interface\nreturned EINVAL.\n\nError logs -\nOSPF6: Zebra Interface state change: swp1 index 3 flags 11043 metric 1 mtu 1500\nOSPF6: Interface Event swp1: [InterfaceUp]\nOSPF6: Network: setsockopt (20) on ifindex 3 failed: Invalid argument\n\nFIX:\n\nTo take care of this possible race condition, any address-family related\nsetting should be retried. Given it\u0027s a rare condition and window of this\nrace should be short, the patch adds a limited retry mechanism for the\nIPV6 membership setting on the socket.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nReviewed-by: Dinesh Dutt \u003cddutt@cumulusnetworks.com\u003e\n Satish Ashok \u003csashok@cumulusnetworks.com\u003e\n" }, { "commit": "c7f25b90902d4be39132b1174440746b571220ce", "tree": "b66ca69885ba36884b09473700f08cc3909cfea3", "parents": [ "f2eb9caac6425473af8d6d15534439fe715f7426" ], "author": { "name": "Daniel Walton", "email": "dwalton@cumulusnetworks.com", "time": "Tue May 19 17:47:22 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Oct 04 13:07:50 2016 +0100" }, "message": "bgpd, ospfd, ospf6d, ripd, ripngd, zebra: \u0027set metric -12\u0027 is broken in the parser\n\nSigned-off-by: Daniel Walton \u003cdwalton@cumulusnetworks.com\u003e\n" }, { "commit": "7d39125ea4d54624a4865dd272df5041ccac655e", "tree": "5948b8421015af9e47885179d87ef727d79196b8", "parents": [ "8c075ef01d64cba7dd52bdc642ccee22a8538b62" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue May 19 18:03:53 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Oct 04 13:07:48 2016 +0100" }, "message": "ospf6d: Adding the initialization check in ospfv3_clean()\n\nThis is to avoid a crash triggered by process termination\nwhen ospf6d daemon is running and \u0027router ospf6\u0027 config has not been done yet.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nReviewed-by: Daniel Walton \u003cdwalton@cumulusnetworks.com\u003e\n" }, { "commit": "8c075ef01d64cba7dd52bdc642ccee22a8538b62", "tree": "fb49387b6d69cf5ccc7550ae3c93f982f2916a71", "parents": [ "f1b9611821bb73b6bc664afa263cdaa851e09d34" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue May 19 18:03:53 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Oct 04 13:07:48 2016 +0100" }, "message": "ospf6d: Fixing a couple of issues with ospf6_route_remove () routine.\n\nWhen a route_node has multiple ospf6_routes under it (common subnet case),\nthen the current implementation has an issue in adjusting the route_node-\u003einfo\non a ospf6_route_remove() call.\n\nThe main reason is that it ends up using exact match to determine if the next\nospf6_route belongs to the same route_node or not. Fixing that part to use\nrnode (the existing back-pointer to the route_node) from the ospf6_route to\ndetermine that.\n\nAlso fixing some of the walks to turn them safe so that the route deletion is\nfine.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nReviewed-by: Vivek Venkatraman \u003cvivek@cumulusnetworks.com\u003e\n" }, { "commit": "f1b9611821bb73b6bc664afa263cdaa851e09d34", "tree": "e848a1f724143670b5e09531e74c85e364a99466", "parents": [ "f687b62b14dd4e79528e9ba607da1ebdc44cf28d" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue May 19 18:03:51 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Oct 04 13:07:47 2016 +0100" }, "message": "ospf6d: LA (local-address) bit related inter-op fix.\n\nAs per the RFC, when the NU bit is set, prefix should be ignored.\nHowever, the code is currently ignoring prefix with LA bit too.\n\nFixing that part.\n\nIn future, we should also set LA bit for the loopback addresses. Not doing this\npart right away, as quagga wont be backward compatible with its own previous\nreleases. Maybe after a release or so, we should start setting LA bit too.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nReviewed-by: Daniel Walton \u003cdwalton@cumulusnetworks.com\u003e\n" }, { "commit": "69424be09ccf7233b184b89bb7bd6e98f72d252b", "tree": "51d6c07ce0e9e3a6ba2ad12f87c0417d3e8d5c8f", "parents": [ "f972dec83308986082b04711c8915e13c0a5e1c1" ], "author": { "name": "Daniel Walton", "email": "dwalton@cumulusnetworks.com", "time": "Tue May 19 18:03:41 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Sep 13 10:36:47 2016 +0100" }, "message": "ospf6d: We should accept long form of \"no redistribute\"\n\nWhen turning off redistribution in ospf6, allow the\nuser to specify the full form of the command entered.\n\nSigned-off-by: Daniel Walton \u003cdwalton@cumulusnetworks.com\u003e\n" }, { "commit": "f972dec83308986082b04711c8915e13c0a5e1c1", "tree": "beac1b5a2aa6553bc4fc51b421d6d984d8c00283", "parents": [ "e87f8083ff677b569048ce7560169b64daee0c57" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue May 19 18:03:41 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Sep 13 10:36:47 2016 +0100" }, "message": "ospf6d: Add the missing ospf6 running check in show cmds\n\nSYMPTOM:\n\nIf some of the ospfv3 commands like \u0027show ipv6 ospf6 route\u0027 are executed\nwith ospf6d daemon running but before having any ospfv3 configuration, then\nospf6d crash is seen.\n\nISSUE:\n\nThere are a few show commands, which are (unlike others) not checking if\nospf6 instance is initialized already.\n\nFIX:\n\nAdd the missing checks, by using OSPF6_CMD_CHECK_RUNNING() in the commands\nwhere its needed and not yet used.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat@cumulusnetworks.com\u003e\n Dinesh Dutt \u003cddutt@cumulusnetworks.com\u003e\n" }, { "commit": "e87f8083ff677b569048ce7560169b64daee0c57", "tree": "f55fbeeb8ef6f66f0feb55cab9ce1cc5dc28196b", "parents": [ "e509af86e3579944b7cde942ca3ee3427db1936a" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue May 19 18:03:40 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Sep 13 10:36:47 2016 +0100" }, "message": "ospf6d: Support for \u0027clear ipv6 ospf6 interface [ifname]\n\nClear interface commands for ospfv3. Allow the user\nto clear all peers out the specified interface.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\n" }, { "commit": "e509af86e3579944b7cde942ca3ee3427db1936a", "tree": "d707edff140eeae0371e89d912a295bb8978d978", "parents": [ "a90dc8752723ef6bad6fc5a7d5180ab313b0317c" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue May 19 18:03:40 2015 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Sep 13 10:36:47 2016 +0100" }, "message": "opsf6d: Update router-LSA when nbr\u0027s interface-ID changes\n\nThis is a fix to make sure router-LSA is updated when neighbor\u0027s interface\nID change is received in hello packet.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\n" }, { "commit": "62f936e7960a7c08f4ae42ad43726d8d6e8e949d", "tree": "53dbbf703d51c38e0bf41cc979434b32c3b5d430", "parents": [ "92992c69afd0095b183a3b905598d194115b27a7" ], "author": { "name": "Daniel Walton", "email": "dwalton@cumulusnetworks.com", "time": "Mon Nov 09 20:21:59 2015 -0500" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Sep 13 10:36:45 2016 +0100" }, "message": "ospf6d, ripd, vtysh: Fix \"no set metric\" for ospf6 and RIP\n\nAllow the user to actually turn off the set metric command\nin ospf6d and rip.\n\nSigned-off-by: Daniel Walton \u003cdwalton@cumulusnetworks.com\u003e\n" }, { "commit": "0f2f7a3fa5d55e682d0739d586da021cbd43bc3c", "tree": "a8bdff569d71a784e2ba4ab154ce6ab70103638a", "parents": [ "94627e670d661f95217521ef0bfba141e5e37e68" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Thu Jun 16 15:40:02 2016 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Sep 13 10:36:44 2016 +0100" }, "message": "*: Fix duplicate commands from view/enable node consolidation\n" }, { "commit": "68b45cc592d5d61e748e8d99ec9f84e63aa73213", "tree": "eb1008834813757b86e5f4bc439e7b2b3188adbf", "parents": [ "b9ac2f320922542e0320ceeced4aa7264564e98a" ], "author": { "name": "Donald Sharp", "email": "sharpd@cumulusnetworks.com", "time": "Fri Mar 11 14:27:13 2016 -0500" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jul 20 12:58:33 2016 +0100" }, "message": "*: Consolidate all double VIEW_NODE and ENABLE_NODE\u0027s\n\nIf a command is put into the VIEW_NODE, it is going into the\nENABLE_NODE as well. This is especially true for show commands.\nAs such if a command is in both consolidate it down to VIEW_NODE.\n\nSigned-off-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "d8f7f86a64842fcc6200c2fa4f560b9aa7a279bb", "tree": "90da2b249a53228d99fed940373e3aa6b5039416", "parents": [ "a0a661f982c4a9726573faf28817d77d3e7cdad5" ], "author": { "name": "Roman Hoog Antink", "email": "rha@open.ch", "time": "Wed Mar 05 09:13:43 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jul 20 12:58:30 2016 +0100" }, "message": "ospf6d: implement admin distance\n\nUntil today the admin distance cannot be configured for any IPv6\nrouting protocol. This patch implements it for ospf6.\n\nSigned-off-by: Maitane Zotes \u003cmaz@open.ch\u003e\n" }, { "commit": "5e57b5fc621300427d3818f0723b8cd8d5e5ca6a", "tree": "738345e0c3121f329266e8b8faaa88661e7cdb2e", "parents": [ "e3f623be8b6556db9d70c2fc5d3c2b152f36dc1d" ], "author": { "name": "Donald Sharp", "email": "sharpd@cumulusnetworks.com", "time": "Fri Mar 11 16:28:34 2016 -0500" }, "committer": { "name": "Donald Sharp", "email": "sharpd@cumulusnetworks.com", "time": "Fri Mar 11 18:29:14 2016 -0500" }, "message": "quagga: Remove double read of stream\n\nThe addition of a MIN(X,Y) with a stream_getc in the Y\ncauses a double read of the stream due to the way that\nMIN is defined.\n\nThis fix removes a crash in all protocols.\n\nSigned-off-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "bf83fa25f1bddec6f09ad879cba5e975a3ae5495", "tree": "a01a0137a4193d2d33d61bb43c113afef3e421a6", "parents": [ "2db962760426ddb9e266f9a4bc0b274584c819cc" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Feb 09 15:23:03 2016 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Mar 08 17:53:22 2016 +0000" }, "message": "lib: Check prefix length from zebra is sensible\n\n* zclient.c: prefix length on router-id and interface address add\n messages not sanity checked. fix.\n\n* */*_zebra.c: Prefix length on zebra route read was not checked, and\n clients use it to write to storage. An evil zebra could overflow\n client structures by sending overly long prefixlen.\n\nPrompted by discussions with:\n\nDonald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "9099f9b2a66e86f8a90d7fe18f61bd2bb1bc6744", "tree": "1ce5d2e4ecff6b57eb00d40b1a91b3f363ff35fe", "parents": [ "954c7d6bcd04c2cf037965adda0f9d11afdcd165" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Mon Jan 18 10:12:10 2016 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Fri Feb 26 14:11:46 2016 +0000" }, "message": "*: use an ifindex_t type, defined in lib/if.h, for ifindex values\n" }, { "commit": "283596fd6d49a5b2861a6923db9a88628ef0eca4", "tree": "1b461a1fea8840efaafd1250f729831be91fea9f", "parents": [ "be62b17c736ea06181f2788e3011066830555610", "fc1c114aab24fe47bc6a1976c1c602d507fa4e69" ], "author": { "name": "Paul Jakma", "email": "paul@jakma.org", "time": "Wed Oct 28 14:25:06 2015 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Oct 28 14:25:06 2015 +0000" }, "message": "Merge \u0027patch-tracking/4/proposed/netdef-solaris\u0027 into accepted\n" }, { "commit": "7125293d65d73a451ec203c8c1630c236171f5a3", "tree": "f9d118c9a8f8374d69fb9c75c87531a2ca478fb2", "parents": [ "fd1c1a133af47ae5533a5ed41b73ff62e7aa1058" ], "author": { "name": "Donald Sharp", "email": "sharpd@cumulusnetworks.com", "time": "Thu Sep 24 09:25:19 2015 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Oct 27 10:53:21 2015 +0000" }, "message": "lib: zclient.c remove extern struct thread_master *\n\nzclient.c depended upon link time inclusion of a\nextern struct thread_master *master. This is a violation of the\nnamespace of the calling daemon. If a library needs the pointer\npass it in and save it for future use.\n\nThis code change also makes the zclient code consistent with\nthe other lib functions that need to schedule work on your behalf\n\nSigned-off-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "a4065069e6bdd0bc7475312530b0e9457f818e0d", "tree": "b983314c1b7152fe7d351c99e79a7190d44ef363", "parents": [ "ce93c34d51ea30d1ba4f699af5601502bbbbcdf8" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Sep 15 02:12:23 2015 -0700" }, "committer": { "name": "Martin Winter", "email": "mwinter@opensourcerouting.org", "time": "Fri Oct 16 23:50:46 2015 -0700" }, "message": "ospf6d: fix uninitialized warning in SNMP\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "ca8ec20b017393dbe91ff9e5ae2b7ff12872f869", "tree": "50e8e04092234deb5d7c3534f4b7cb16d5308f99", "parents": [ "d3ac733b41b69826ac4b5a86b881f33f3d383941" ], "author": { "name": "Michael Rossberg", "email": "michael.rossberg@tu-ilmenau.de", "time": "Tue Sep 29 14:32:14 2015 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Sep 30 16:51:25 2015 +0100" }, "message": "ospf6d: Fix for fast OSPF convergence\n\nFixed use of OSPF_MIN_LS_ARRIVAL, which changed its unit from\nseconds to milliseconds\n" }, { "commit": "0bc874b88cf86fca4b18f3672a441ed142fc499d", "tree": "35781fe9f0d71c7df85fe07c3461553eb4901215", "parents": [ "fbc3e97d747862fd47f711c9f15b8166bdf94b18" ], "author": { "name": "Donald Sharp", "email": "sharpd@cumulusnetworks.com", "time": "Wed Jul 29 19:16:13 2015 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Sep 24 15:26:44 2015 +0100" }, "message": "build/arm: Arm compilation warning fix\n\nThe arm cross compiler is issuing warnings for signed/unsigned\ncomparisons for ntohs. ntohs returns a unsigned int, while\nthe counting variables are signed. Fixed to allow -Werror\nto work properly\n\nSigned-off-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "52c0bc739b1184621525e64720b944268d6b0eeb", "tree": "a556a51ef56f6ccaa63c942c9880c684fc4b3bae", "parents": [ "c8ee940cc695cbcf9c0156ee6f72730f1fff9814" ], "author": { "name": "Paul Jakma", "email": "paul@jakma.org", "time": "Thu Aug 20 21:30:17 2015 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Sep 03 16:44:48 2015 +0100" }, "message": "build: Remove the old PIC/PIE patch, let libtool sort it out\n\n* Remove the old change from \u002708 to add in PIE arguments at automake level.\n Versions of libtool since then know how to deal with -fpie and do the right\n thing according to whether its building shared or executable objects.\n So just pass \u0027-fpie\u0027 as CFLAG and let libtool do its thing.\n" }, { "commit": "c99f3481a598e9cadd1de96714f6b5df9ad85c4a", "tree": "aac6df566f28c13fce5c9f02275f159fab73a24d", "parents": [ "758fb8f99a7bfac3d31c419fd1a5694fc5f33f6a" ], "author": { "name": "Feng Lu", "email": "lu.feng@6wind.com", "time": "Thu Oct 16 09:52:36 2014 +0800" }, "committer": { "name": "Nicolas Dichtel", "email": "nicolas.dichtel@6wind.com", "time": "Wed Jun 03 10:24:12 2015 +0200" }, "message": "*: add VRF ID in the API message header\n\nThe API messages are used by zebra to exchange the interfaces, addresses,\nroutes and router-id information with its clients. To distinguish which\nVRF the information belongs to, a new field \"VRF ID\" is added in the\nmessage header. And hence the message version is increased to 3.\n\n* The new field \"VRF ID\" in the message header:\n\n Length (2 bytes)\n Marker (1 byte)\n Version (1 byte)\n VRF ID (2 bytes, newly added)\n Command (2 bytes)\n\n - Client side:\n\n - zclient_create_header() adds the VRF ID in the message header.\n - zclient_read() extracts and validates the VRF ID from the header,\n and passes the VRF ID to the callback functions registered to\n the API messages.\n - All relative functions are appended with a new parameter \"vrf_id\",\n including all the callback functions.\n - \"vrf_id\" is also added to \"struct zapi_ipv4\" and \"struct zapi_ipv6\".\n Clients need to correctly set the VRF ID when using the API\n functions zapi_ipv4_route() and zapi_ipv6_route().\n - Till now all messages sent from a client have the default VRF ID\n \"0\" in the header.\n - The HELLO message is special, which is used as the heart-beat of\n a client, and has no relation with VRF. The VRF ID in the HELLO\n message header will always be 0 and ignored by zebra.\n\n - Zebra side:\n\n - zserv_create_header() adds the VRF ID in the message header.\n - zebra_client_read() extracts and validates the VRF ID from the\n header, and passes the VRF ID to the functions which process\n the received messages.\n - All relative functions are appended with a new parameter \"vrf_id\".\n\n* Suppress the messages in a VRF which a client does not care:\n\n Some clients may not care about the information in the VRF X, and\n zebra should not send the messages in the VRF X to those clients.\n\n Extra flags are used to indicate which VRF is registered by a client,\n and a new message ZEBRA_VRF_UNREGISTER is introduced to let a client\n can unregister a VRF when it does not need any information in that\n VRF.\n\n A client sends any message other than ZEBRA_VRF_UNREGISTER in a VRF\n will automatically register to that VRF.\n\n - lib/vrf:\n\n A new utility \"VRF bit-map\" is provided to manage the flags for\n VRFs, one bit per VRF ID.\n\n - Use vrf_bitmap_init()/vrf_bitmap_free() to initialize/free a\n bit-map;\n - Use vrf_bitmap_set()/vrf_bitmap_unset() to set/unset a flag\n in the given bit-map, corresponding to the given VRF ID;\n - Use vrf_bitmap_check() to test whether the flag, in the given\n bit-map and for the given VRF ID, is set.\n\n - Client side:\n\n - In \"struct zclient\", the following flags are changed from\n \"u_char\" to \"vrf_bitmap_t\":\n redist[ZEBRA_ROUTE_MAX]\n default_information\n These flags are extended for each VRF, and controlled by the\n clients themselves (or with the help of zclient_redistribute()\n and zclient_redistribute_default()).\n\n - Zebra side:\n\n - In \"struct zserv\", the following flags are changed from\n \"u_char\" to \"vrf_bitmap_t\":\n redist[ZEBRA_ROUTE_MAX]\n redist_default\n ifinfo\n ridinfo\n\n These flags are extended for each VRF, as the VRF registration\n flags. They are maintained on receiving a ZEBRA_XXX_ADD or\n ZEBRA_XXX_DELETE message.\n\n When sending an interface/address/route/router-id message in\n a VRF to a client, if the corresponding VRF registration flag\n is not set, this message will not be dropped by zebra.\n\n - A new function zread_vrf_unregister() is introduced to process\n the new command ZEBRA_VRF_UNREGISTER. All the VRF registration\n flags are cleared for the requested VRF.\n\n Those clients, who support only the default VRF, will never receive\n a message in a non-default VRF, thanks to the filter in zebra.\n\n* New callback for the event of successful connection to zebra:\n\n - zclient_start() is splitted, keeping only the code of connecting\n to zebra.\n\n - Now zclient_init()\u003d\u003ezclient_connect()\u003d\u003ezclient_start() operations\n are purely dealing with the connection to zbera.\n\n - Once zebra is successfully connected, at the end of zclient_start(),\n a new callback is used to inform the client about connection.\n\n - Till now, in the callback of connect-to-zebra event, all clients\n send messages to zebra to request the router-id/interface/routes\n information in the default VRF.\n\n Of corse in future the client can do anything it wants in this\n callback. For example, it may send requests for both default VRF\n and some non-default VRFs.\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: Nicolas Dichtel \u003cnicolas.dichtel@6wind.com\u003e\nAcked-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n" }, { "commit": "126215c1238eb42cc92d23aefbe1fac3b204438f", "tree": "22910b50f39003e297efc6236711581cbf3b2ada", "parents": [ "2fc97f6335dd5d7df2c285b363c6ef56bb98dcf8" ], "author": { "name": "Feng Lu", "email": "lu.feng@6wind.com", "time": "Fri May 22 11:39:58 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jun 02 06:58:12 2015 +0200" }, "message": "*: call if_init()/if_terminate() from vrf_init()/vrf_terminate()\n\nLater, an interface will belong to a specific VRF, and the interface\ninitialization will be a part of the VRF initialization. So now call\nif_init() from vrf_init(), and if_terminate() from vrf_terminate().\n\nDaemons have the according changes:\n- if if_init() was called or \"iflist\" was initialized, now call\n vrf_init() instead;\n- if if_terminate() was called or \"iflist\" was destroyed, now call\n vrf_terminate() instead.\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: Nicolas Dichtel \u003cnicolas.dichtel@6wind.com\u003e\nAcked-by: Vincent JARDIN \u003cvincent.jardin@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "395828eea809e8b2b8c5824d3639cefedd7aa9f0", "tree": "61341d0667a67d8645455fad7029cc916eb9a3e2", "parents": [ "be6335d682c5ee1b6930345193eda875705fbab2" ], "author": { "name": "Feng Lu", "email": "lu.feng@6wind.com", "time": "Fri May 22 11:39:55 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jun 02 06:58:12 2015 +0200" }, "message": "ospf6d, bgpd: avoid calling if_nametoindex\n\nAs the comments in if.h, it is better to call ifname2ifindex()\ninstead of if_nametoindex().\n\nAnd ifname2ifindex() can work for VRF by appending a parameter\nwhile if_nametoindex() can not.\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: Nicolas Dichtel \u003cnicolas.dichtel@6wind.com\u003e\nAcked-by: Vincent JARDIN \u003cvincent.jardin@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e691c3bb972c0baf610d9e210ce20ea6546e1de0", "tree": "a3e83b01ecd4fe9e739a24dc77c61a46fd0531a2", "parents": [ "193e78f2460a537695e34368a29fc5cd02e4e1f5" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:46:13 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:46:19 2015 +0200" }, "message": "*: assorted warning fixes\n\nA few warnings slipped through the cracks...\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c0bedebfe9ca1a1ded02f1f481762dd41defa63e", "tree": "9c040f71733fb7509c03457bc146373e65e95536", "parents": [ "3a7e83c2387885075c9ecf1912dd6c9399c6947a" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 10:00:43 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:19:33 2015 +0200" }, "message": "build: add --enable-werror\n\nThis allows enabling -Werror in a consistent way. Note that this is\ndifferent from just specifiying it in CFLAGS, since that would either\nbreak configure tests (if done on ./configure), or would override\nconfigure\u0027s CFLAGS (if done on make).\n\nUsing --enable-werror instead provides a new WERROR variable that is\nadditionally used during make with a consistent set of warning flags.\n\nThe tests/ directory is exempt. (Rationale being, better to have more\ntests than pedantically complain about them.)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "dfee58f1d41a2e36c7f5f38a3ef5712224131824", "tree": "10e588443180a85a6ac019db1ded6b1144f32a7c", "parents": [ "6769f43de9d595b935f2ebf1cae1428e1d1a3a5f" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Mar 04 06:44:57 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:19:10 2015 +0200" }, "message": "snmp: fix warnings\n\nbatch-fix all warnings that come up when enabling AgentX SNMP support.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "3cf4053a9e832408fad33a8246ecbd189f23a956", "tree": "c55451f64ca56d5df10cbedb66b3aa1e3928ba8a", "parents": [ "72c69d434840598a158747ba9f69dad536f96cea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Apr 19 14:54:03 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:19:01 2015 +0200" }, "message": "ospf6d: fix pointer arithmetic warning\n\ncaddr_t was signed; this buffer size comparison is better done in\nunsigned.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "72c69d434840598a158747ba9f69dad536f96cea", "tree": "e03e73f818cc2497bc991ae133a990e67358d136", "parents": [ "0de0138a9146074f268245193e45c9376d998722" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 09:08:20 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:18:58 2015 +0200" }, "message": "ospf6d: oi-\u003ecost is uint32, not short\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "0de0138a9146074f268245193e45c9376d998722", "tree": "fbf4305e4c7ebdb7ee05b69a71c443b0f5865e4f", "parents": [ "33b9663a89b5ec319986de0673764d2a18ec8725" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 10:30:27 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:18:55 2015 +0200" }, "message": "ospf6d: use existing union, avoid strict-aliasing\n\nThere are preexisting fields u.lp.id and u.lp.adv_router in struct\nprefix that do the same thing as these type-punning pointer derefs.\nUse these and shut up the strict-aliasing warnings.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "388f8857eb81ef75014060976776523a58a99389", "tree": "d425f43437cc937f4cd415d3170c8d6c8f6bf33c", "parents": [ "21401f3215be26dcb0f787105f5907745498e966" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 08:55:54 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:18:01 2015 +0200" }, "message": "*: add missing includes\n\nSome places, particularly headers, were spewing warnings since they\ndon\u0027t include neccessary other headers to get struct/enum definitions.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "eed3c48d3a7d2dae2cae2f2f250deffb843754a6", "tree": "07b2252438225065024d4a534eddf0e86c9b87a4", "parents": [ "ef008d2f8dc8f7160d8a3d24a15f2fad79ef3242" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 08:51:53 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:17:31 2015 +0200" }, "message": "*: use void * for printing pointers\n\nOn higher warning levels, compilers expect %p printf arguments to be\nvoid *. Since format string / argument warnings can be useful\notherwise, let\u0027s get rid of this noise by sprinkling casts to void *\nover printf calls.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "ef008d2f8dc8f7160d8a3d24a15f2fad79ef3242", "tree": "036d3b4c7bc0071f045bc1cb3a54c422dffc1806", "parents": [ "ec62e1438ece9af0546f9028aa1403f2c84bf177" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 08:48:11 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Apr 19 20:40:19 2015 +0200" }, "message": "*: use long long to print time_t\n\nSince we can\u0027t assume time_t to be long, int, or even long long, this\nconsistently uses %lld/long long (or %llu/unsigned long long in a few\ncases) to print time_t/susecond_t values. This should fix a bunch of\nwarnings, on NetBSD in particular.\n\n(Unfortunately, there seems to be no \"PRId64\" style printing macro for\ntime_t...)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "237aac56960575f6ad2451ba2796d94bd5ae4b33", "tree": "f23c49fa32bc6b706bd5f37a9a3a45ce27adf15d", "parents": [ "b6fa76098d127f5641a7dda0dee21f06ca167edb" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Jun 28 22:23:10 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Feb 14 19:19:14 2015 +0100" }, "message": "build: get rid of INCLUDES, use AM_CPPFLAGS\n\nINCLUDES in configure.ac was not used at all, and INCLUDES in\nMakefile.am is supposed to be AM_CPPFLAGS these days.\n\nReduces warnings spewed during bootstrap/autoreconf.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\nAcked-by: Greg Troxel \u003cgdt@ir.bbn.com\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\nAcked-by: Paul Jakma \u003cpaul@jakma.org\u003e\n" }, { "commit": "6d6df30386423518b5daef93c2f047b4140f85f4", "tree": "7da3226d3276e019c49a4b4a673911a85297ecc7", "parents": [ "0f048b90b5d6e4bd185913945b68dd254126eb9f" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Jun 28 21:12:37 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Feb 14 19:18:49 2015 +0100" }, "message": "build: remove INRIA, NRL and MUSICA IPv6 quirks\n\nValar dohaeris.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\nAcked-by: Greg Troxel \u003cgdt@ir.bbn.com\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\nAcked-by: Paul Jakma \u003cpaul@jakma.org\u003e\n" }, { "commit": "bdd8cd70a042473477f9144c9cedb8dde11ba2c1", "tree": "edcdbc4b096f4c5b1dc1d72d32d2db81c9fa3c7c", "parents": [ "ea2a598411cc7bd20456849e56bbc9e93c9916e7" ], "author": { "name": "Yasuhiro Ohara", "email": "yasu@jaist.ac.jp", "time": "Thu Dec 17 05:41:17 2009 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 16:01:08 2014 +0100" }, "message": "Bug in ospf6_lsa_compare()\n\nThis fix is probably correct on 32bit systems,\nbut i think it will not work on 64bit systems.\nsizeof(signed long) would be 8 and therefore the\ncast from u_int32_t will map all the values to\nnon-negative part of long int.\n\nYou would like to use int (like in ospfd) and\nchange the type of seqnuma, seqnumb to that.\n\nThe type int32_t would be even more proper, but\nsizeof(int) is 4 on relevant platforms.\n\nSigned-off: Ondrej Zajicek \u003csantiago@crfreenet.org\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\nAcked-by: Yasuhiro Ohara \u003cyasu@jaist.ac.jp\u003e\n" }, { "commit": "7bef33cbf5027189bd55e4890a07a6bef8277f93", "tree": "744283cc2493348e042a278062743d3ecf00abf0", "parents": [ "b2dd59ee0e74926278e128846624f5c93288223b" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 15:35:15 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:33:21 2014 +0100" }, "message": "ospf6_lsdb: trivial, make it clear that showfunc is set before deref.\n" }, { "commit": "7aa9dcef80b2ce50ecaa77653d87c8b84e009c49", "tree": "bd4a8d881336a1551146725d7ae06b3e68553e4d", "parents": [ "010ebbbca6396f272cc2d50d147dd922dda68213" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 14:42:23 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:32:34 2014 +0100" }, "message": "Fix most compiler warnings in default GCC build.\n\nFix lots of warnings. Some const and type-pun breaks strict-aliasing\nwarnings left but much reduced.\n\n* bgp_advertise.h: (struct bgp_advertise_fifo) is functionally identical to\n (struct fifo), so just use that. Makes it clearer the beginning of\n (struct bgp_advertise) is compatible with with (struct fifo), which seems\n to be enough for gcc.\n Add a BGP_ADV_FIFO_HEAD macro to contain the right cast to try shut up\n type-punning breaks strict aliasing warnings.\n* bgp_packet.c: Use BGP_ADV_FIFO_HEAD.\n (bgp_route_refresh_receive) fix an interesting logic error in\n (!ok || (ret !\u003d BLAH)) where ret is only well-defined if ok.\n* bgp_vty.c: Peer commands should use bgp_vty_return to set their return.\n* jhash.{c,h}: Can take const on * args without adding issues \u0026 fix warnings.\n* libospf.h: LSA sequence numbers use the unsigned range of values, and\n constants need to be set to unsigned, or it causes warnings in ospf6d.\n* md5.h: signedness of caddr_t is implementation specific, change to an\n explicit (uint_8 *), fix sign/unsigned comparison warnings.\n* vty.c: (vty_log_fixed) const on level is well-intentioned, but not going\n to fly given iov_base.\n* workqueue.c: ALL_LIST_ELEMENTS_RO tests for null pointer, which is always\n true for address of static variable. Correct but pointless warning in\n this case, but use a 2nd pointer to shut it up.\n* ospf6_route.h: Add a comment about the use of (struct prefix) to stuff 2\n different 32 bit IDs into in (struct ospf6_route), and the resulting\n type-pun strict-alias breakage warnings this causes. Need to use 2\n different fields to fix that warning?\n\ngeneral:\n\n* remove unused variables, other than a few cases where they serve a\n sufficiently useful documentary purpose (e.g. for code that needs\n fixing), or they\u0027re required dummies. In those cases, try mark them as\n unused.\n* Remove dead code that can\u0027t be reached.\n* Quite a few \u0027no ...\u0027 forms of vty commands take arguments, but do not\n check the argument matches the command being negated. E.g., should\n \u0027distance X \u003cprefix\u003e\u0027 succeed if previously \u0027distance Y \u003cprefix\u003e\u0027 was set?\n Or should it be required that the distance match the previously configured\n distance for the prefix?\n Ultimately, probably better to be strict about this. However, changing\n from slack to strict might expose problems in command aliases and tools.\n* Fix uninitialised use of variables.\n* Fix sign/unsigned comparison warnings by making signedness of types consistent.\n* Mark functions as static where their use is restricted to the same compilation\n unit.\n* Add required headers\n* Move constants defined in headers into code.\n* remove dead, unused functions that have no debug purpose.\n" }, { "commit": "6b0655a25194c7c0331154edaa6124cf783e5e5e", "tree": "c0c7d479f2684531249668210da27a60322ba395", "parents": [ "fdb913aedb5a9807ad60715e8badb4f25d57acea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:53:35 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:58:02 2014 +0200" }, "message": "*: nuke ^L (page feed)\n\nQuagga sources have inherited a slew of Page Feed (^L, \\xC) characters\nfrom ancient history. Among other things, these break patchwork\u0027s\nXML-RPC API because \\xC is not a valid character in XML documents.\n\nNuke them from high orbit.\n\nPatches can be adapted simply by:\n\tsed -e \u0027s%^L%%\u0027 -i filename.patch\n(you can type page feeds in some environments with Ctrl-V Ctrl-L)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "cd40b329a2e4da882bcad0431c048c876bbeafbd", "tree": "cfbdec5a7559c6d3e56766797896a18809aa1746", "parents": [ "e712d0e3667ffad8109ef8bce3ce01927ee95bb7" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Mon Sep 30 12:27:51 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 01 20:21:41 2014 +0200" }, "message": "lib/command.c: rewrite command matching/parsing\n\nAdd support for keyword commands.\n\nIncludes new documentation for DEFUN() in lib/command.h, for preexisting\nfeatures as well as new keyword specification.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c78a46c27f6dfdd42fe0800cebabc1e49cb0a4bf", "tree": "5d88a885415f3b5e63f7dac5c72dcbcc647a7dfb", "parents": [ "fd5006896fce2816244c1ef4cabc736279548538" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Wed Mar 20 10:50:09 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Mar 21 06:28:48 2014 +0100" }, "message": "ospf6d: fix refcounting in ospf6_asbr_lsa_remove\n\nWhen iterating over a list, also the last node should be unlocked again.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "fd5006896fce2816244c1ef4cabc736279548538", "tree": "c9fb889019186c6aa7c800643f3ff1d9171a96a7", "parents": [ "c19543b223d3b8463c048f346b8044589e0cce39" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Wed Oct 24 14:45:54 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Mar 21 06:28:48 2014 +0100" }, "message": "ospf6d: add \"auto-cost reference-bandwidth\" command\n\nThis command allows the user to change to default reference bandwidth\nfor cost calculations. The default value is 100 Mbps. With a default\nbandwidth of 10 MBps, the default cost becomes 10. Those values are\nconsistent with OSPFv2.\n\n[DL: resolved conflicts in vty command additions \u0026 docs]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c19543b223d3b8463c048f346b8044589e0cce39", "tree": "7da71baef36e7c7b4e628c645580f8cc18c1aabe", "parents": [ "1db65fadf627637621c342b789b9a3604ca5fab5" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Wed Oct 24 14:45:53 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Mar 21 06:28:47 2014 +0100" }, "message": "ospf6d: compute interface cost from its bandwidth\n\nPreviously, the interface cost was a fixed default value that a user\nwas allowed to change with \"ipv6 ospf6 cost XX\". As what is done with\nOSPFv2, we change this behaviour to compute the default interface cost\nfrom the interface bandwidth.\n\nThe user can still force a cost with \"ipv6 ospf6 cost XX\". He can get\nthe default value with \"no ipv6 ospf6 cost\". Moreover, the default\ncost value was 1. The cost is now computed from the bandwidth and a\ndefault reference bandwidth of 100 MBps (as for OSPFv2). Since the\ndefault bandwidth for an interface is 10 MBps, the \"default\" cost\nbecomes 10 instead of 1.\n\n[DL: resolved conflict in ospf6d/ospf6_interface.c]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "1db65fadf627637621c342b789b9a3604ca5fab5", "tree": "546c769ca03e71e6c7bb55a52b4f7ea525542864", "parents": [ "e708ed69aa0b993527f48b1f31b645c00750927f" ], "author": { "name": "Ingo Flaschberger", "email": "if@xip.at", "time": "Sun Apr 17 18:28:20 2011 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Mar 21 06:28:23 2014 +0100" }, "message": "ospf6d: solve segfaults with ospf6d on FreeBSD\n\nDo not send ospf6d hellos on fresh created interfaces without\nconfiguration (ie. no vlan configured). Ospf6d use ip6_mtu, if it\u0027s not\ninitalised, Ospf6d tries to alloc indefinite size of memory.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e708ed69aa0b993527f48b1f31b645c00750927f", "tree": "8f33d73b2a85b51c042318d58a1750eeb8019616", "parents": [ "a11e012e8661629d665e992e765741a5eaa7d017", "424cc3bd48da0f417c9056c5c2ade697a3386cd4" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 18 17:04:25 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 18 17:04:25 2014 +0100" }, "message": "Merge volatile/cumulus_ospf6d\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "424cc3bd48da0f417c9056c5c2ade697a3386cd4", "tree": "1d0e9a71f6c27b64d435c276a100f046c30e2a8b", "parents": [ "11b4f01355703d34099d4da145c7d92e32d98636" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Nov 23 16:55:36 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 18 08:45:29 2014 +0100" }, "message": "ospf6d: fix interface_down() stopping hellos\n\ninterface_down() - which also handles some nonobvious cases like the\nlast linklocal address disappearing - was previously not cancelling the\nhello timer. This had the effect of multiple such threads ending up\nscheduled after a quick down-up cycle.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "11b4f01355703d34099d4da145c7d92e32d98636", "tree": "e895a3794edbfe60c481954ed4ad79fcc2b661c3", "parents": [ "b13c1d9299d6426f48f074545f3e403e5a9b8a61" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Dec 09 16:48:55 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 18 08:45:29 2014 +0100" }, "message": "ospf6d: clear lsa-\u003erefresh before clearing LSAs\n\nThis fixes a SEGV when we receive a higher-SeqNum copy of a LSA that we\noriginated ourselves, before a reboot of ospf6d. We create a new\ncopy of the LSA to resync the SeqNum, but then half an hour later\nthe old refresh thread ends up trying to refresh the free()\u0027d old LSA.\n\nThe SEGV is triggered by this chain:\n ospf6_lsdb_maxage_remover\n -\u003e thread_execute(ospf6_lsa_refresh)\n -\u003e old-\u003erefresh \u003d NULL\nWhich assumes that old-\u003erefresh is no longer scheduled to run, as it is\nbeing run right there. But the thread_execute() doesn\u0027t know about\nold-\u003erefresh and therefore didn\u0027t remove it.\n\n(Found by ANVL OSPFV3-16.17)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "b13c1d9299d6426f48f074545f3e403e5a9b8a61", "tree": "b313288f60c8d76a16e4f9f1796e934c0c8fefc0", "parents": [ "d9628728e0924ae13ef6e8f8a67a2c9802745184" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Thu Dec 13 16:11:16 2012 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 18 08:45:20 2014 +0100" }, "message": "ospf6d: handle missing link local address more gracefully\n\nospf6 can\u0027t run on an interface without a link local address.\nDon\u0027t start the state machine when an interface comes up without\nsuch an ip and bring it up later, when a usable link local\naddress is added.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "d9628728e0924ae13ef6e8f8a67a2c9802745184", "tree": "af4cee6c7018580655cb53a0900471128cc0a8bb", "parents": [ "37531a7ec380554b18c004bcae9f5a070385d132" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Fri Mar 08 21:47:35 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 18 08:44:05 2014 +0100" }, "message": "ospf6d: improve ordered shutdown\n\nImprove the _disable/_enable infrastructure so it gets into\na more usable shape and make \u0027no router ospf6\u0027 actually work.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a11e012e8661629d665e992e765741a5eaa7d017", "tree": "d6967d9c5044f8c924aa2f4b62bac8e3bda358e2", "parents": [ "b52aef18a9f3acc8b24ab5c2631dc574b8e2ec70" ], "author": { "name": "Remi Gacogne", "email": "rgacogne-github@coredump.fr", "time": "Sun Sep 08 13:48:34 2013 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Tue Feb 11 10:28:03 2014 +0100" }, "message": "security: Fix some typos and potential NULL-deref\n\nThis patch against the git tree fixes minor typos, some of them possibily\nleading to NULL-pointer dereference in rare conditions.\n\nSigned-off-by: Remi Gacogne \u003crgacogne-github@coredump.fr\u003e\nSigned-off-by: Joachim Nilsson \u003ctroglobit@gmail.com\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\n" }, { "commit": "37531a7ec380554b18c004bcae9f5a070385d132", "tree": "fb1893fcf7be8f613a3cd0a82f0150af4a3974f7", "parents": [ "1579a67f130ca34df9acefac14ebcdfdd8f6600a" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Thu Dec 13 13:50:28 2012 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Nov 20 10:35:59 2013 +0100" }, "message": "ospf6d: clear DR info on interface_down\n\nThis fixes an issue where ospf6d would send incorrect hellos and\nperform wrong DR election when an interface went down and up\nagain.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\n" }, { "commit": "1579a67f130ca34df9acefac14ebcdfdd8f6600a", "tree": "8c12770a8628fc786e08c08a125114f7d56b66d4", "parents": [ "7d4aa1d57d54a57aae78e6b12cf4524e2c43a514" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Fri Mar 08 02:35:38 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Nov 20 10:35:59 2013 +0100" }, "message": "ospf6d: set cmsg size correctly\n\nOn both Linux and FreeBSD, msg_controllen should be set to\nCMSG_LEN, not CMSG_SPACE. This avoids sending 4 bytes of\ntrailing garbage to the kernel.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\n" }, { "commit": "7d4aa1d57d54a57aae78e6b12cf4524e2c43a514", "tree": "f6c80b75e1f258a9bc3fa7a452807a5762ca7465", "parents": [ "ba960d5ae43e49991ed70fbe9ffa2e4567437a31" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Thu Dec 13 16:10:05 2012 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Nov 20 10:35:59 2013 +0100" }, "message": "ospf6d: don\u0027t run DR election early on \"ipv6 ospf6 priority\"\n\nOn changing the router priority, DR election should only be run when it\nwas completed at least once before.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\n" }, { "commit": "ba960d5ae43e49991ed70fbe9ffa2e4567437a31", "tree": "8ffe0291edf209d936ce874c7a7104369f611e7e", "parents": [ "a0edf6740e8203abec1ee3efa344a417c16fec7b" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Mon Aug 26 03:40:37 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Nov 20 10:35:59 2013 +0100" }, "message": "ospf6d: fix integrated config\n\nWith integrated config, the line defining an interface to be p2p is defined\nbefore assigning the interface to an area. When during the interface\ntransition, there is an attempt to generate a router LSA, the process\ncrashes. This fix addresses that.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a0edf6740e8203abec1ee3efa344a417c16fec7b", "tree": "501efcc33069c129987ac1ec98dd0656ad67e278", "parents": [ "3d35ca482babab4267570143b8327fc894df0ff8" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Mon Aug 26 03:40:23 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: add SPF logs, statistics, and display of SPF parameters\n\nSigned-off-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\n[DL: adapted to rebase / readded randomly lost line]\n[DL: killed timeval_subtract]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "3d35ca482babab4267570143b8327fc894df0ff8", "tree": "594c2040b3746a16780d748f24f395688751dd4f", "parents": [ "7cf997226e86d98839f1e7872ca98b023ffea98e" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Mon Aug 26 03:40:16 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: add \u0027log-adjacency-changes [detail]\u0027\n\nSimilar to OSPFv2, add support for \u0027log-adjacency-changes [detail]\u0027 to log\nchanges in adjacency state of ospfv3 neighbors.\n\nSigned-off-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nReviewed-by: Shrijeet Mukherjee \u003cshm at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "7cf997226e86d98839f1e7872ca98b023ffea98e", "tree": "4407f125907aa5ac7a524d7bf71b9e0028f4c6cb", "parents": [ "01879114f73adaf1cd4c9f5e7ae1550b72ff9ca9" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sun Aug 25 03:03:39 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: don\u0027t send LSAck on an interface if we\u0027ve flooded the LSU out that i/f\n\nIf we flood an LSA back out the same interface we received it from, don\u0027t send\nan LSAck out that interface for that LSA. This is as per RFC 2328, section 13.5\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "01879114f73adaf1cd4c9f5e7ae1550b72ff9ca9", "tree": "95f60a636ad4e2ebb0c55f31301a897fb6559b24", "parents": [ "e68a67672ccfabefadac36c66e88af997fb572b2" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sun Aug 25 03:03:31 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: handle Prefix and Router Options bits correctly\n\nEnsure that prefixes with the NU/LA bit set do not get added to the routing\ntable. Ensure that routers with the V6/R bit set do not get added as transit\nroutes.\n\nSigned-off-by: Dinesh Dutt \u003cddutt at cumulusnetworks.com\u003e\n[DL: adjust to rebase]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e68a67672ccfabefadac36c66e88af997fb572b2", "tree": "7f5b3c1386121457cc5052fc2530018093d947ae", "parents": [ "931b1b8c9a612665391ed43653c970fcb38bbbf0" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sun Aug 25 03:03:23 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: add LSA payload to show summary output\n\nUnlike OSPFv2, the LSID of an LSA isn\u0027t sufficient to know what the contents\nof the LSA are. Its useful for debugging and basic eyeball tests to see the\ncontents of the LSA in the simple tabular format of \"show ipv6 ospf6 database\".\nThis patch adds that output to the command. It replaces the existing fields of\n\"duration, Chksum and Length\" with a single field called Payload which is\ndependent on the LSA type. For Inter-Area Prefix, Intra-Area Prefix and\nAS-External LSAs, this will be the advertised prefix/prefix length, for Router\nLSAs, it is RtrID/IfID etc.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\n[DL: rebase fix, line disappeared in ospf6_abr_originate_summary_to_area]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "931b1b8c9a612665391ed43653c970fcb38bbbf0", "tree": "570f2aca4df8ef6a394925c5a1b7c9e772d3d1a1", "parents": [ "7a10a359e9740710c1e39c8be0f761f506795480" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sun Aug 25 03:03:15 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: increment dbdesc seqnum on SeqNumberMismatch/BadLsReq event\n\nAs per RFC 2328, section 10.3, if the neighbor state machine reaches\nSeqNumberMismatch state when the NSM is in state Exchange or greater,\n\"router increments the DD sequence number in the neighbor data structure,\ndeclares itself master (sets the master/slave bit to master), and starts\nsending Database Description Packets, with the initialize (I), more (M)\nand master (MS) bits set.\".\n\nThe existing code doesn\u0027t increment the DD SeqNum. This patch fixes that.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "7a10a359e9740710c1e39c8be0f761f506795480", "tree": "acf3db650a76ef97da33b0703d97920ea3d8e53a", "parents": [ "3b220289a4d0da4539d965ca71e9479d68c87b11" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sun Aug 25 03:03:07 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: don\u0027t change SeqNum on initial DbDesc message\n\nThe code was setting the DbDesc seqnum to the current seconds value of time if\nthis was the initial DbDesc. However, the same code was getting invoked if the\ninitial DbDesc was retransmitted. Caused ANVL test XX.XX to fail.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "3b220289a4d0da4539d965ca71e9479d68c87b11", "tree": "232f6c56c5c12cf292937f7b21b002ef63b8c7e3", "parents": [ "f41b4a021659dd48d62b1a7aac4b28e3663dbdaa" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 08:00:44 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: handle seqnum wrapping\n\nSigned-off-by: Shrijeet Mukherjee \u003cshm at cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\n[DL: mechanical adjust to rebase]\n[DL: adjust to removal of timerwheel code]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f41b4a021659dd48d62b1a7aac4b28e3663dbdaa", "tree": "ec4595f0d79279eef4da07145a30d104604b0035", "parents": [ "e7ad6b20d7a7c63ed7c640ab9f61c853e77508c5" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 08:00:37 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: add overload support\n\nOSPFv3: Support setting/clearing overload bit on router\n\nIt is sometimes necessary for a router to gracefully remove itself from\nthe SPF tree i.e. it cannot act as a transit router. It does this by\nsetting the overload bit in the router LSA. This patch adds support for\nenabling/disabling the overload bit.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\n[DL: patch applied with fuzz]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e7ad6b20d7a7c63ed7c640ab9f61c853e77508c5", "tree": "92454d3f9eca7c5f579c0c463f976e3e3b5873cc", "parents": [ "b81e97a8a7f85ecc7489dc8a7c7b9d403d9c4bc6" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:55:57 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: fix linkdown handling\n\nEnsure OSPFv3 handles link down even correctly.\n\nOSPFv3 checks only the administrative status of a link instead of its\noperative status. This prevents it up from detecting a real link down\nevent and reacting appropriately. Only protocol timer timeouts make it\ndetect a link down eventually. This patch makes it look for the operative\nstatus of a link instead of admin status.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: James Li \u003cjli at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "b81e97a8a7f85ecc7489dc8a7c7b9d403d9c4bc6", "tree": "48e2c8492f01cc177a6691878cf4e5a329fe4d2d", "parents": [ "17d003da963d6294e5ab95c690de285eccf0bac0" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:55:50 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: correct nexthop through directly connected networks\n\nThis is implementing this part of RFC 2328:\n\nThis is the \"first case\", see below,\n\n16.1.1. The next hop calculation\n\n...\nIf there is at least one intervening router in the current\nshortest path between the destination and the root, the\ndestination simply inherits the set of next hops from the\nparent. Otherwise, there are two cases. In the first case,\nthe parent vertex is the root (the calculating router\nitself). This means that the destination is either a\ndirectly connected network or directly connected router.\nThe outgoing interface in this case is simply the OSPF\ninterface connecting to the destination network/router.\n...\n\nThe current Quagga code always tries to inherit the nexthop from\na parent vertex, but does not cover the case that the destination\nis directly connected to the root vertex. This patch adds support\nfor that case.\n\nSigned-off-by: James Li \u003cjli at cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "17d003da963d6294e5ab95c690de285eccf0bac0", "tree": "3972c371b676459408d560f4a18dc16295b70c54", "parents": [ "e39d05384d4563f04edf339bbd67a117dd18e533" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:55:43 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:43 2013 -0800" }, "message": "ospf6d: don\u0027t suppress empty router LSA\n\nCurrently in OSPFv3 implementation, if all the interfaces are down/loopback\nor are without any full adjacencies, the router LSA is suppressed. So for\na router with only stub networks, no router LSA is generated. However,\nintra-prefix LSAs are generated for the stub networks and these intra-prefix\nLSAs will reference the router LSA. So the router LSA really should not be\nsuppressed. It needs to be generated to be the starting vertex for SPF\nw.r.t the stub networks.\n\nSigned-off-by: James Li \u003cjli at cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e39d05384d4563f04edf339bbd67a117dd18e533", "tree": "5c1ea95d4fcd993014974c862c4b97c8064e7a5f", "parents": [ "a765eb9383c53c68523a67b36cea92eadf6f3439" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:55:36 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: turn off expensive debugging\n\nOSPF6 has very expensive LSDB and route debug on by default. This needs to be\nturned off for scaled performance.\n\nSigned-off-by: James Li \u003cjli at cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003eSummary:\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a765eb9383c53c68523a67b36cea92eadf6f3439", "tree": "16fa0d6d9bb3ddda5b01d01f31c1eeffd02ded8a", "parents": [ "eb82e9ee81792f86548d4937486b5dcbbd411a98" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:55:14 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: convert LSDB to use route_node, improve performance\n\nthe performance in the presence of a large number of LSAs. I also verified\nthat the performance improvements stayed in the presence of a large number\nof peers (I tested upto 128).\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003eSummary:\nReviewed-by: James Li \u003cjli at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "eb82e9ee81792f86548d4937486b5dcbbd411a98", "tree": "9c1f216017923cc40af71755506dc35c5c2c0fbc", "parents": [ "c5926a92235874574b20e426a3752c1451a90ec7" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:55:07 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: fix neighbor state machine (faster lsdb sync, RFC compliance)\n\nThe OSPFv3 code doesn\u0027t do the following things right as part of an adjacency\nbringup:\n - Transmit DbDesc frames appropriately to ensure faster state transition to\n Loading state\n - Transmit LsReq frames when switching to exchange state and on receipt of\n an LS update in Loading state\n - Requesting LSAs multiple times in LsReq.\n\nIt currently uses retransmit timer expiry to send the LsReq and DbDesc frames\nwhich significantly slows down large lsdb syncs.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c5926a92235874574b20e426a3752c1451a90ec7", "tree": "c8b8b66eee832e3db5e5d315e966b168918ef57e", "parents": [ "bf986da797e7d2a0aaae313fea626ba433581f03" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:55:00 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: add p2p interface support\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nSigned-off-by: Ayan Banerjee \u003cayabaner at gmail.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nReviewed-by: James Li \u003cjli at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "bf986da797e7d2a0aaae313fea626ba433581f03", "tree": "79e852020d1f9eb2be774d3050dcc1ea3a88e73b", "parents": [ "8ae454e779d5620576990f4bf5da3a35f913cc4d" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:54:50 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: fix various bugs in installing and flooding LSAs\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8ae454e779d5620576990f4bf5da3a35f913cc4d", "tree": "cbfb907e0aeef1d5b3076629c8e8d510bb326068", "parents": [ "09df4574b95dbb5880eb2d3c3c3c900687a9a3ef" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:54:41 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: add more details to show ipv6 ospf6 data\n\nSpecifically, it displays the flags, lock and retransmission count fields.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: JR Rivers \u003cjrrivers at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "09df4574b95dbb5880eb2d3c3c3c900687a9a3ef", "tree": "b332c0a50379a5efea3ecb9e29931dcd03e0a0ab", "parents": [ "ac58e143f7278d5faaad7a8672e48328b03cffa5" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:54:31 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: enable the commands to support detailed debugging of LSAs.\n\nThe code for the commands exists, but it hasn\u0027t been defined in the\ndefinition of the command itself. This patch fixes that.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "ac58e143f7278d5faaad7a8672e48328b03cffa5", "tree": "52ea2eeb0cf614f9fcdf72badfc705d88f623ee3", "parents": [ "2449fcd64ae95d5fbfd95d93468fc57003def57d" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:54:24 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: remove older version of LSA from neigbor retx list before prematurely aging it.\n\nSee comment in code for very detailed issue and fix.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "2449fcd64ae95d5fbfd95d93468fc57003def57d", "tree": "8c152a482f2080ee425cd06381861d2bf69769d4", "parents": [ "3810e06eebe14f75c66fb17a88574384573e95fa" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:54:17 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:42 2013 -0800" }, "message": "ospf6d: reinvoke MaxAge remover thread if not all MaxAge LSAs were flushed.\n\nMaxAge LSAs are being flushed out only on an event, unlike OSPFv2 where they\u0027re flushed out\nperiodically. This causes certain LSAs to hang around forever, never getting flushed out.\nThis patch makes flushing out MaxAge LSAs periodic, retriggered after a certain period if\nnot all MaxAge LSAs were flushed out.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "3810e06eebe14f75c66fb17a88574384573e95fa", "tree": "0e7ba30d0b24d1ea874eb257b78fdeed2eaebf4c", "parents": [ "8551e6dadce41fb87a61767af723cb25ae611a04" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Sat Aug 24 07:54:09 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 07 18:15:30 2013 -0800" }, "message": "ospf6d: schedule SPF to run on events rather than directly on each event.\n\nOSPV3 SPF triggers on every SPF-able event instead of using timers the way\nOSPFv2 does. This patch makes SPF be triggered/throttled similar to OSPFv2.\nIt adds a command to quagga identical to the OSPFv2 equivalent to configure\nthese timers.\nSummary:\n\nSigned-off-by: Dinesh Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\n[DL: removed reference to oa-\u003ets_spf for rebase]\n[DL: killed timeval_subtract]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8551e6dadce41fb87a61767af723cb25ae611a04", "tree": "cb0854c2e216989a0fa211d56d2bf6fd6948b2d6", "parents": [ "a83a1e9c2f035d3152451dcfc97ab13b4ac427b9" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Oct 22 17:42:18 2013 -0700" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Oct 22 18:01:31 2013 -0700" }, "message": "ospf6d/ospfd: refactor some common defines\n\nRearranging common defs and structures for use betweeen OSPFv2 and\nOSPFv3. Created a new file called libospf.h under lib directory to\nhold defines that are common between OSPFv2 and OSPFv3 code bases.\n\n[DL: split of defines refactor from timer refactor]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "4ff3bcad8e81b643f3247317a3949d7867b36f75", "tree": "4348c8b1db5f0c2af4a99eb560c269542223a8ff", "parents": [ "a52070899afed55ae44ed6a140ac090cdf07d141" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Wed Mar 20 10:50:07 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jul 31 17:58:05 2013 +0200" }, "message": "isisd, ospf6d: use bug-report information from autoconf\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "837d16ccbe0fca413f8927da6a34b1e97ccada8a", "tree": "7aed5a517b619c03d11bf567f6a14cda6f8f5efe", "parents": [ "655071f44aab42e89bcece3a93da456fdd0d913a" ], "author": { "name": "Balaji.G", "email": "balajig81@gmail.com", "time": "Wed Sep 26 14:09:10 2012 +0530" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 25 10:15:59 2012 -0700" }, "message": "*: use array_size() helper macro\n\nUse the array_size() helper macro. Replaces several instances of local\nmacros with the same definition.\n\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "d8a4e42b7d19a87eacc00c825e913907a58f39ee", "tree": "2d0777bfbef0e77ca1722fe0e7b2591ef89d4102", "parents": [ "b0145ddb4bf75d2c8853aa3d0bc7c522f4f17531" ], "author": { "name": "JR Rivers", "email": "jrrivers@cumulusnetworks.com", "time": "Thu Sep 13 17:17:36 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 25 10:15:58 2012 -0700" }, "message": "lib: improve fletcher checksum validation\n\nOVERVIEW\n\nThe checksum used in OSPF (rfc2328) is specified in rc905 annex B. There is an\nsample implementation in rfc1008 which forms the basis of the quagga\nimplementation. This algorithm works perfectly when generating a checksum;\nhowever, validation is a bit problematic.\n\nThe following LSA (generated by a non-quagga implementation) is received by\nquagga and marked with an invalid checksum; however, it passes both the rfc905\nand rfc1008 validation checks.\n\nstatic uint8_t lsa_10_121_233_29[] \u003d {\n 0x0e, 0x10, 0x02, 0x03,\n 0x09, 0x00, 0x35, 0x40,\n 0x0a, 0x79, 0xe9, 0x1d,\n 0x80, 0x00, 0x00, 0x03,\n 0x00, 0x8a, 0x00, 0x1c,\n 0xff, 0xff, 0xff, 0xe0,\n 0x00, 0x00, 0x36, 0xb0\n};\n\nLS Type: Summary-LSA (IP network)\n LS Age: 3600 seconds\n Do Not Age: False\n Options: 0x02 (E)\n Link-State Advertisement Type: Summary-LSA (IP network) (3)\n Link State ID: 9.0.53.64\n Advertising Router: 10.121.233.29 (10.121.233.29)\n LS Sequence Number: 0x80000003\n LS Checksum: 0x008a\n Length: 28\n Netmask: 255.255.255.224\n Metric: 14000\n\nYou\u0027ll note that one byte of the checksum is 0x00; quagga would calculate the\nchecksum as 0xff8a.\n\nIt can be argued that the sourcing implementation generates an incorrect\nchecksum; however, rfc905 indicates that, for 1\u0027s complement arithmetic, the\nvalue 255 shall be regarded as 0, thus either values are valid.\n\nEXPLANATION\n\nThe quagga ospfd and ospf6d implementations operate by copying the PDU\u0027s\nexisting checksum in a holding variable, calculating the checksum, and comparing\nthe resulting checksum to the original. As a note, this implementation has the\nside effect of modifying the contents of the PDU.\n\nEvaluation of both rfc905 and rfc1008 shows that checksum validation should\ninvolve calculating the sum over the PDU and checking that both resulting C0 and\nC1 values are zero. This behavior is enacted in the rfc1008 implementation by\ncalling encodecc with k \u003d 0 (checksum offset); however, this functionality had\nbeen omitted from the quagga implementation.\n\nPATCH\n\nThis patch adds the ability to call the quagga\u0027s fletcher_checksum() with a\nchecksum offset value of 0xffff (aka FLETCHER_CHECKSUM_VALIDATE) which returns\nthe sum over the buffer (a value of 0 indicates a valid checksum). This is\nsimilar to the mechanism in rfc1008 when called with k \u003d 0. The patch also\nintroduces ospf_lsa_checksum_valid().\n\nospf6d had it\u0027s own implementation of the fletcher checksum in\nospf6_lsa_checksum(); it\u0027s the same algorithm as in fletcher_checksum(). This\npatch removes the local implementation in favor of the library\u0027s as well as creates\nand uses ospf6_lsa_checksum_valid().\n\nquagga\u0027s ISIS implementation suffers from the same problem; however, I do not\nhave the facilities to validate a fix to ISIS, thus this change has been left to\nthe ISIS maintainers. The function iso_csum_verify() should be reduced to\nrunning the fletcher checksum over the buffer using an offset of 0.\n\nSigned-off-by: JR Rivers \u003cjrrivers@cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nReviewed-by: Nolan Leake \u003cnolan@cumulusnetworks.com\u003e\nReviewed-by: Ayan Banerjee \u003cayan@cumulusnetworks.com\u003e\nReviewed-by: Shrijeet Mukherjee \u003cshm@cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "0402ca4e92fa0904d5ee0926482ebca08ffd5c81", "tree": "be0dd0aaec834c52372b6914f4f87260acb2b219", "parents": [ "bf836661ef8ef880350bc41f0a82566ed5075066" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Tue Jul 10 09:27:57 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Tue Jul 10 09:27:57 2012 +0200" }, "message": "ospf6d: fix segfault when requesting inexistant interfaces or areas\n" }, { "commit": "bf836661ef8ef880350bc41f0a82566ed5075066", "tree": "09fe0cfd070a3984860b1ffc89020caba892eff4", "parents": [ "c349bb86927d1f5fc8aa8ebc6f553786f8e70634" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 04 14:36:12 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:05:17 2012 +0200" }, "message": "ospf6d: add SNMP notifications/traps support\n\nOnly implement ospfv3NbrStateChange and ospfv3IfStateChange.\n" }, { "commit": "c349bb86927d1f5fc8aa8ebc6f553786f8e70634", "tree": "5560db37b8512a550dd33a7217577b54bf1cad15", "parents": [ "3bc4f84efe147ebc65fccbe898b81d78341c542b" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 04 12:59:20 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:05:17 2012 +0200" }, "message": "ospf6d: add SNMP support for ospfv3*LsdbTable\n\nThis includes:\n - ospfv3AsLsdbTable\n - ospfv3AreaLsdbTable\n - ospfv3LinkLsdbTable\n" }, { "commit": "3bc4f84efe147ebc65fccbe898b81d78341c542b", "tree": "cfe0f904c134fdb7659f6a47897aff88208d2ddd", "parents": [ "ea86e4042b7459fbf5d96835c509cb743bf013c0" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 04 11:40:04 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:05:17 2012 +0200" }, "message": "ospf6d: add SNMP implementation of ospfv3IfTable\n" }, { "commit": "ea86e4042b7459fbf5d96835c509cb743bf013c0", "tree": "7cf527b8084fd7ede72503d6aad273eaf73261e6", "parents": [ "2c5f148065c074d51ff10808a2b6ac2b3296a828" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 04 10:29:49 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:05:17 2012 +0200" }, "message": "ospf6d: complete SNMP implementation of ospfv3AreaTable\n" }, { "commit": "2c5f148065c074d51ff10808a2b6ac2b3296a828", "tree": "ef554e9c520765f8f38bea807753aef77c88f541", "parents": [ "061bc735b4fb3b8768fa5f52295d85838ed55770" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Fri Jun 01 11:38:34 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:05:16 2012 +0200" }, "message": "ospf6d: complete SNMP implementation for scalar objects\n" }, { "commit": "061bc735b4fb3b8768fa5f52295d85838ed55770", "tree": "80f74a55bfbd93d9111d5b49676bcea11a91285e", "parents": [ "0f0ab5180877559e92b71daacb8a106a815a5ade" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Thu May 31 20:21:15 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:05:16 2012 +0200" }, "message": "ospf6d: add SNMP support for ospfv3NbrTable\n" }, { "commit": "0f0ab5180877559e92b71daacb8a106a815a5ade", "tree": "2553d47180fceebc1e3180f33645410d21173233", "parents": [ "8046ba6ec4d6e87bf8da6563c0f3e5e66c4652b3" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Tue May 22 13:34:24 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:05:16 2012 +0200" }, "message": "snmp: fix OSPFV3-MIB implementation\n\nUse the real MIB from RFC 5643. Fix used ASN1 types. Indexes are not\nexported any more (they are \"no access\"). Fix some endian\nissues. Also, ID are just integers, not IPv4 addresses.\n\nNo additional OID are supported in this commit.\n" }, { "commit": "8046ba6ec4d6e87bf8da6563c0f3e5e66c4652b3", "tree": "1b38b2eae4e1cee042f96a42217b14647159bf0f", "parents": [ "0ff4b9c96793898429052de576d8da368e48997e" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Thu May 31 13:30:28 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:03:23 2012 +0200" }, "message": "snmp: let handlers accept OID from a lesser prefix\n\nMost table handlers do not expect to be given an OID whose prefix is\noutside what they can handle. This is not a problem with the SMUX\nimplementation since it always correct the OID such that the prefix\nmatches. However, this is not the case for the AgentX\nimplementation. A new function, smux_header_table() is used to do this\nnormalization.\n" }, { "commit": "08d7f6533ecc0f935a76918c462982004534864d", "tree": "0e67590a8a2aba551439c46bfa8b33d7fba4feb7", "parents": [ "6b1e37f8537fa2a4560de32e83ca5089763e2d39" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Tue May 22 22:29:17 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:03:23 2012 +0200" }, "message": "build: use net-snmp-config to configure NetSNMP\n\nThe correct method to link to NetSNMP is to use net-snmp-config (which\nis like pkg-config). Explicit link to libcrypto is also dropped\n(NetSNMP libs are linked to libcrypto, no need to link Quagga to\nit). Moreover, @SNMP_INCLUDES@ is dropped because useless. Due to a\nbug in configure.ac, it was properly populated.\n" }, { "commit": "6b1e37f8537fa2a4560de32e83ca5089763e2d39", "tree": "941dfbfbe62981ec214ac1e5a3f607368f4bf1d4", "parents": [ "9e7a548ce421660b0d22bfeb90c2b2b53742aac7" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Tue May 22 22:15:20 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:03:23 2012 +0200" }, "message": "build: only define HAVE_SNMP\n\nNetSNMP is the only SNMP implementation for Quagga. We don\u0027t need two\ndifferent symbols.\n" }, { "commit": "9e7a548ce421660b0d22bfeb90c2b2b53742aac7", "tree": "4c962403808f98806781fb4ad15594152bc1effa", "parents": [ "a47c5838e9f445ab887ad927706b11ccbb181364" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Tue May 22 14:32:22 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:03:23 2012 +0200" }, "message": "build: allow configure and build in a separate directory\n\nSome .h files in lib/ are autogenerated. The search path should\ninclude the build directory and the source directory. They usually\nmatch but sometimes, they may be different. For example:\n\n $ mkdir build\n $ cd build\n $ ../configure\n $ make\n" } ], "next": "b51a3a31500133e3e26f12e7639f297c655bc735" }