)]}' { "log": [ { "commit": "6b0655a25194c7c0331154edaa6124cf783e5e5e", "tree": "c0c7d479f2684531249668210da27a60322ba395", "parents": [ "fdb913aedb5a9807ad60715e8badb4f25d57acea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:53:35 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:58:02 2014 +0200" }, "message": "*: nuke ^L (page feed)\n\nQuagga sources have inherited a slew of Page Feed (^L, \\xC) characters\nfrom ancient history. Among other things, these break patchwork\u0027s\nXML-RPC API because \\xC is not a valid character in XML documents.\n\nNuke them from high orbit.\n\nPatches can be adapted simply by:\n\tsed -e \u0027s%^L%%\u0027 -i filename.patch\n(you can type page feeds in some environments with Ctrl-V Ctrl-L)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "0798cee34f5c436cd2a4b6e1d9a1ca90eee94292", "tree": "1b2293b711a12d743a0cd814235589bc4ce8d84f", "parents": [ "de54b26caca7442af29656282e753b02aac6f093" ], "author": { "name": "Andrew Certain", "email": "certain@amazon.com", "time": "Tue Dec 04 13:43:42 2012 -0800" }, "committer": { "name": "Scott Feldman", "email": "sfeldma@cumulusnetworks.com", "time": "Mon Jan 07 09:59:59 2013 -0800" }, "message": "ospfd: compile warning cleanups\n\nA set of patches to clarify some comments as well as cleanup code that was\ncausing warnings. After these patches, the code can be compiled with\n\n-Wall -Wsign-compare -Wpointer-arith -Wbad-function-cast -Wwrite-strings\n-Wmissing-prototypes -Wmissing-declarations -Wchar-subscripts -Wcast-qual\n-Wextra -Wno-unused-parameter -Wno-missing-field-initializers\n\n(what is current in trunk plus -Wextra -Wno-unused-parameter\n-Wno-missing-field-initializers).\n\nSigned-off-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\n" }, { "commit": "c363d3861b5384a31465a72ddc3b0f6ff007a95a", "tree": "3fcbfc071dc2a376979ca6a80d06599a5b574047", "parents": [ "7eb5b47e54169ac0da40ed1a6760db5d5f915a4d" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 24 22:42:13 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Dec 08 17:13:19 2010 +0000" }, "message": "ospfd: Unify router and network LSA refresh logic with general refresher\n\n* (general) Get rid of the router and network LSA specific refresh timers\n and make the general refresher do this instead. Get rid of the twiddling\n of timers for router/network LSA that was spread across the code.\n\n This lays the foundations for future, general LSA refresh improvements,\n such as making sequence rollover work, and having generic LSA delays.\n\n* ospfd.h: (struct ospf) Bye bye to the router-lsa update timer thread\n pointer.\n (struct ospf_area) and to the router-lsa refresh timer.\n* ospf_interface.h: Remove the network_lsa_self timer thread pointer\n* ospf_lsa.h: (struct ospf_lsa) oi field should always be there, for benefit\n of type-2/network LSA processing.\n (ospf_{router,network}_lsa_{update_timer,timer_add}) no timers for these\n more\n (ospf_{router,network}_lsa_update) more generic functions to indicate that some\n router/network LSAs need updating\n (ospf_router_lsa_update_area) update router lsa in a particular area alone.\n (ospf_{summary,summary_asbr,network}_lsa_refresh) replaced by the general\n ospf_lsa_refresh function.\n (ospf_lsa_refresh) general LSA refresh function\n" }, { "commit": "ec70497bc5eac732139c3d94987ecb6691557795", "tree": "717509c323b8a44a1ac48a38b2f4a6faaa6fc022", "parents": [ "f8416810aad4cba6f622c6b3f9352abdd54cd01e" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Dec 06 12:21:52 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Dec 08 17:11:17 2010 +0000" }, "message": "ospfd: Lower level of some common messages from info to debug\n\n* ospf_{ism,network}.c: Certain oft-repeated but trivial messages should be\n debug log level, not info, to avoid spamming \u0027terminal monitor\u0027\n" }, { "commit": "27f5dc8120e1c6902e29d86cf0d77b82cf3848c0", "tree": "a9058ac54bf22840409d52aa761fa215cc7abb31", "parents": [ "5d8de93a84b2afc4202d3284eb9e57672e2551b3" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Sat Aug 22 14:57:54 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 13:03:49 2009 +0100" }, "message": "ospfd: Make sure priority is respected.\n\n* ospf_ism.c (ospf_dr_eligible_routers) should test for priority \u003e 0 instead\n of !\u003d 0 as ospf_nbr_new () initially sets prio to -1\n" }, { "commit": "30a2231a4881f53deca61ef7a62b225a43dab4c5", "tree": "f26dff922a4f85d302fa67bbd9a120108db41c44", "parents": [ "f5612dd382d9c0f4089b08ec164c25a8082d9f89" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Aug 15 14:05:22 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:59 2008 +0100" }, "message": "[warnings] Fix various SOS warnings\n\n2008-08-15 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* */*: Fix various problems flagged by Sun Studio compiler.\n\t - \u0027\u003cqualifier\u003e \u003cstorage\u003e\u0027 obsolescent in declarations\n\t - empty statements (\u0027;\u0027 after ALIAS definitions)\n\t - implicit declarations (e.g printstack in lib/log.c)\n\t - \"\\%\" in printf string instead of \"%%\"\n\t - loops that return on the first iteration (legitimately, but\n \t compiler can\u0027t really know), e.g. bgp_routemap.c\n \t - internal declarations which mask prototypes.\n" }, { "commit": "1fe6ed38cd0136c514aabae01389653beab27fb9", "tree": "21f10bc3f9c5afffe9f28e5dbf4e6198cfafba5b", "parents": [ "3fed4160cd23f1767d8980e8cba10bc3933947d5" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 26 09:37:26 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 26 09:37:26 2006 +0000" }, "message": "[ospfd] Allow ospf_lsa_unlock to NULL out callers\u0027 LSA pointers upon free\n\n2006-07-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer\n\t to the LSA to be \u0027unlocked\u0027, so that, if the LSA is freed, the\n\t callers pointer to the LSA can be NULLed out, allowing any further\n\t use of that pointer to provoke a crash sooner rather than later.\n\t* ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match\n\t previous. Try annotate \u0027locking\u0027 somewhat to show which \u0027locks\u0027\n\t are protecting what LSA reference, if not obvious.\n\t* ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless\n\t goto, replace with return.\n\t* ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,\n\t the dual-loop predated the delete-safe list-loop macro.\n" }, { "commit": "deb1561c1824d0a5215c8fcd0084393090a6567e", "tree": "5c5cd51abefa9c9bd648d041ace9c6836a2f2980", "parents": [ "bfd7c7dc067f5a181a992fa0b8af31cfe5cdc9eb" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:07:27 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:07:27 2006 +0000" }, "message": "[ospfd] CID #15, remove redundant NULL check in ism_change_state\n\n2006-05-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* ospf_ism.c: (ism_change_state) NULL check on oi-\u003earea is\n\t useless, it\u0027s always valid. Only possibility where it\n \t couldn\u0027t be is if there is a race between abr_task and\n\t cleaning up oi\u0027s, in which case a NULL check here isn\u0027t going\n\t to do anything. Fixes CID #15.\n" }, { "commit": "f9ad937f537df92bf3119686eee97db7b7176674", "tree": "8c203f4bffabbb2fd27ffeafd2e87e5fd704a0e2", "parents": [ "24065a3d4a61a136a17996a48df02b0b180bc6f0" ], "author": { "name": "paul", "email": "paul", "time": "Fri Oct 21 00:45:17 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Oct 21 00:45:17 2005 +0000" }, "message": "2005-10-21 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) OSPF fast, sub-second hello and 1s dead-interval\n\t support. A warning fix. Millisec support for ospf_timer_dump.\n\t Change auto-cost ref-bandwidth to add a comment to write out\n\t of config, rather than printing annoying messages to vty on\n\t startup.\n\t* ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.\n\t Callers typically specify a length of 9, so most see\n\t millisecs unless they specify the additional length.\n\t* ospf_interface.h: (struct ospf_interface) new interface param,\n\t fast_hello.\n\t* ospf_interface.c: (ospf_if_table_lookup) add brackets,\n\t gcc warning fix.\n\t (ospf_new_if_params) Initialise fast_hello param.\n\t (ospf_free_if_params) Check whether fast_hello is configured.\n\t (ospf_if_new_hook) set fast_hello to default.\n\t* ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to\n\t prevent funny side-effects from its if statement when this\n\t macro is used conditionally by other macros.\n\t (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.\n\t (OSPF_HELLO_TIMER_ON) new macro to set hello timer according\n\t to whether fast_hello is set.\n\t* ospf_ism.c: Update all setting of the hello timer to use\n\t either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The\n\t former is used when hello is to be sent immediately.\n\t* ospf_nsm.c: ditto\n\t* ospf_packet.c: (ospf_hello) hello-interval is not checked\n\t for mismatch if fast_hello is set.\n\t (ospf_read) Annoying nit, fix \"no ospf_interface\" to be debug\n\t rather than a warning, as it can be perfectly normal to\n\t receive packets when logical subnets are used.\n\t (ospf_make_hello) Set hello-interval to 0 if fast-hellos are\n\t configured.\n\t* ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying\n\t nit, don\u0027t vty_out if this command is given, it gets tired\n\t quick.\n\t (show_ip_ospf_interface_sub) Print the hello-interval\n\t according to whether fast-hello is set or not.\n\t Print the extra 5 millisec characters from (ospf_timer_dump)\n\t if fast-hello is configured.\n\t (ospf_vty_dead_interval_set) new function, common to all\n\t forms of dead-interval command, to set dead-interval and\n\t fast-hello correctly. If a dead-interval is given, unset\n\t fast-hello, else if a hello-multiplier is set, set\n dead-interval to 1 and fast-hello to given multiplier.\n\t (ip_ospf_dead_interval_addr_cmd) use\n\t ospf_vty_dead_interval_set().\n\t (ip_ospf_dead_interval_minimal_addr_cmd) ditto.\n\t (no_ip_ospf_dead_interval) Unset fast-hello.\n\t (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval\n\t should set it to OSPF_HELLO_INTERVAL_DEFAULT, not\n\t OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.\n\t (config_write_interface) Write out fast-hello.\n\t (ospf_config_write) Write a comment about\n\t \"auto-cost reference-bandwidth\" having to be equal on all\n\t routers. Hopefully just as noticeable as old practice of\n\t writing to vty, but less annoying.\n\t (ospf_vty_if_init) install the two new dead-interval\n\t commands.\n\t* ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL\n\t and OSPF_FAST_HELLO_DEFAULT.\n" }, { "commit": "5e4914c31ead7b99eeed73067451367336b21422", "tree": "f2c49d5c8182d4ee1b8ad8ca5005fe1223da18c8", "parents": [ "ceacedba227e77156f92f7676b274c48a2817e8f" ], "author": { "name": "vincent", "email": "vincent", "time": "Thu Sep 29 16:34:30 2005 +0000" }, "committer": { "name": "vincent", "email": "vincent", "time": "Thu Sep 29 16:34:30 2005 +0000" }, "message": "2005-09-29 Alain Ritoux \u003calain.ritoux@6wind.com\u003e\n\n * lib/smux.[ch]: allow to retreive global OID (identified by \u003c0\n namelen).\n * ospf_ism.c: generate SNMP traps on Interface state change\n * ospf_nsm.c: generate SNMP traps on Neighbour state change\n * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.\n" }, { "commit": "7e440869b51dde1da44f6ffc26643838a1e2b36d", "tree": "7d6f74f4b4be26f7bedc02faed6b410d16599a58", "parents": [ "200df115ea0ba6f54151d60fe5e9a7f6948de7c3" ], "author": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:20:51 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:20:51 2005 +0000" }, "message": "2005-06-01 Akihiro Mizutani \u003cmizutani@net-chef.net\u003e\n\n\t* ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.\n" }, { "commit": "4dadc291e56195886fd047690ded9686f4e013fa", "tree": "ea7c0690912d2b7d0c487f6855960e768fff1b6e", "parents": [ "69e10adaf28d4e116c38db2648786557fe131828" ], "author": { "name": "paul", "email": "paul", "time": "Fri May 06 21:37:42 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri May 06 21:37:42 2005 +0000" }, "message": "2005-05-06 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n * (general) extern and static qualifiers added.\n unspecified arguments in definitions fixed, typically they should\n be \u0027void\u0027.\n function casts added for callbacks.\n Guards added to headers which lacked them.\n Proper headers included rather than relying on incomplete\n definitions.\n gcc noreturn function attribute where appropriate.\n * ospf_opaque.c: remove the private definition of ospf_lsa\u0027s\n ospf_lsa_refresh_delay.\n * ospf_lsa.h: export ospf_lsa_refresh_delay\n * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,\n correct thing to do - removes need for the casts later.\n * ospf_vty.c: Use vty.h\u0027s VTY_GET_INTEGER rather than ospf_vty\u0027s\n home-brewed versions, shuts up several warnings.\n * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and\n VTY_GET_IPV4_PREFIX moved to lib/vty.h.\n * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky\n overloading of the THREAD_ARG pointer should at least use\n uintptr_t.\n" }, { "commit": "1eb8ef2584833f18fb674e127d59cb5a7f771482", "tree": "f5b09d4781de9a9b08839fefb6530e64d2d2ec31", "parents": [ "5920990fecba7e2430af3cfaa8bcbaed40d0ba1a" ], "author": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "message": "2005-04-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global): Fix up list loops to match changes in lib/linklist,\n\t and some basic auditing of usage.\n\t* configure.ac: define QUAGGA_NO_DEPRECATED_INTERFACES\n\t* HACKING: Add notes about deprecating interfaces and commands.\n\t* lib/linklist.h: Add usage comments.\n\t Rename getdata macro to listgetdata.\n\t Rename nextnode to listnextnode and fix its odd behaviour to be\n\t less dangerous.\n\t Make listgetdata macro assert node is not null, NULL list entries\n should be bug condition.\n ALL_LIST_ELEMENTS, new macro, forward-referencing macro for use\n with for loop, Suggested by Jim Carlson of Sun.\n Add ALL_LIST_ELEMENTS_RO for cases which obviously do not need the\n \"safety\" of previous macro.\n\t LISTNODE_ADD and DELETE macros renamed to ATTACH, DETACH, to\n\t distinguish from the similarly named functions, and reflect their\n\t effect better.\n\t Add a QUAGGA_NO_DEPRECATED_INTERFACES define guarded section\n\t with the old defines which were modified above,\n\t for backwards compatibility - guarded to prevent Quagga using it..\n\t* lib/linklist.c: fix up for linklist.h changes.\n\t* ospf6d/ospf6_abr.c: (ospf6_abr_examin_brouter) change to a single\n\t scan of the area list, rather than scanning all areas first for\n\t INTER_ROUTER and then again for INTER_NETWORK. According to\n\t 16.2, the scan should be area specific anyway, and further\n\t ospf6d does not seem to implement 16.3 anyway.\n" }, { "commit": "ba6454ec1fd1ca7266b10eba07d016becb22db74", "tree": "1ee3f882924db44883e1023e5081741e10d86b3a", "parents": [ "3a9eb091494f7afb8ce6bf82b8e1a20bb2a8f10f" ], "author": { "name": "ajs", "email": "ajs", "time": "Tue Feb 08 15:37:30 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Tue Feb 08 15:37:30 2005 +0000" }, "message": "2005-02-08 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* ospf_interface.h: Improve passive_interface comment. Add new\n\t multicast_memberships bitmask to struct ospf_interface to track\n\t active multicast subscriptions. Declare new function\n\t ospf_if_set_multicast.\n\t* ospf_interface.c: (ospf_if_set_multicast) New function to configure\n\t multicast memberships properly based on the current\n\t multicast_memberships status and the current values of the\n\t ospf_interface state, type, and passive_interface status.\n\t (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is\n\t now handled by ism_change_state\u0027s call to ospf_if_set_multicast).\n\t (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now\n\t handled by ism_change_state).\n\t* ospf_ism.c: (ospf_dr_election) Remove logic to join or leave\n\t the DRouters multicast group (now handled by ism_change_state\u0027s call\n\t to ospf_if_set_multicast).\n\t (ism_change_state) Add call to ospf_if_set_multicast to change\n\t multicast memberships as necessary to reflect the new interface state.\n\t* ospf_packet.c: (ospf_hello) When a Hello packet is received on a\n\t passive interface: 1. Increase the severity of the error message\n\t from LOG_INFO to LOG_WARNING; 2. Add more information to the error\n\t message (packet destination address and interface address);\n\t and 3. If the packet was sent to ospf-all-routers, then try\n\t to fix the multicast group memberships.\n\t (ospf_read) When a packet is received on an interface whose state\n\t is ISM_Down, enhance the warning message to show the packet\n\t destination address, and try to update/fix the multicast group\n\t memberships if the packet was sent to a multicast address.\n\t When a packet is received for ospf-designated-routers, but the\n\t current interface state is not DR or BDR, then increase the\n\t severity level of the error message from LOG_INFO to LOG_WARNING,\n\t and try to fix the multicast group memberships.\n\t* ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for\n\t any ospf interface that may have changed from active to passive.\n\t (no_ospf_passive_interface) Call ospf_if_set_multicast for\n\t any ospf interface that may have changed from passive to active.\n\t (show_ip_ospf_interface_sub) Show multicast group memberships.\n" }, { "commit": "60925303c585735b7d52252c00fa4a7340690f31", "tree": "8061894f032b57db05656d03f0eb836e5417c765", "parents": [ "e84cc647f194593ebd1805422376f2a30e3e06e3" ], "author": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 17:45:02 2004 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 17:45:02 2004 +0000" }, "message": "2004-12-08 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* *.c: Change level of debug messages to LOG_DEBUG.\n" }, { "commit": "eb1ce6059a00f3f0dd92c965aa5982907b54c00d", "tree": "ebd6583ba2f2f9909c25653d0349662e08c26ecf", "parents": [ "2e864cfa12724ec20e82f0a24e1be5929e3a0cef" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri Oct 08 08:17:22 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri Oct 08 08:17:22 2004 +0000" }, "message": "Compiler warnings fixes round 1.\n" }, { "commit": "52dc7ee65f8d887b0730abc0a5d44d27fc6ecafd", "tree": "a557339540c56dd3953c29a50ca0e48c1911efc8", "parents": [ "44983cf8a9c587dfbcad294b9dfe4dccbb68ba98" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu Sep 23 19:18:23 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu Sep 23 19:18:23 2004 +0000" }, "message": "Remove usage of evil list and listnode typedefs.\n" }, { "commit": "6898008484a562ff5bae178a6fb0bd885fe8b1e5", "tree": "27797ca6532ca0ef85f538ac8f3070639e579229", "parents": [ "1ef74ef70bdab672458c4d1e4cea24197066c0af" ], "author": { "name": "paul", "email": "paul", "time": "Tue Mar 25 05:07:42 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Mar 25 05:07:42 2003 +0000" }, "message": "2003-03-25 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* sync to latest zebra CVS\n\t* spec file: updated and added define for ospf-api/client\n\nNB: OSPF-API has been broken by the zebra.org changes, which\nhas added struct ospf * as a new arg to many functions\n" }, { "commit": "2d59836a4fb16e2471560a47da7e5f75779c5807", "tree": "619901a67086c8eca741eee4e8b6b9810a3d86b9", "parents": [ "e04ab74d17b4f3456bd3eeefe2043584431b4ea2" ], "author": { "name": "paul", "email": "paul", "time": "Fri Jan 17 23:48:42 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Jan 17 23:48:42 2003 +0000" }, "message": "From endo@suri.co.jp Fri Jan 17 23:36:30 2003\nDate: Fri, 20 Dec 2002 17:58:43 +0900\nFrom: Masahiko Endo \u003cendo@suri.co.jp\u003e\nReply-To: zebra@zebra.org\nTo: zebra@zebra.org\nCc: kunihiro@zebra.org\nSubject: [zebra 16824] [PATCH] nsm_kill_neighbor\n\n [ The following text is in the \"ISO-2022-JP\" character set. ]\r\n [ Your display is set for the \"ISO-8859-1\" character set. ]\r\n [ Some characters may be displayed incorrectly. ]\n\nHi Ishiguro-san,\n\nHere is my problem analysis against the case that the ospfd crashes\nwhen an interface is brought down.\n\nWhen the ospfd receives a ZEBRA message \"ZEBRA_INTERFACE_DOWN\" from\nzebra daemon, the ospfd performs bunch of ospf-interface cleanup for\nthe notified zebra-interface.\nThere are cases that neighbor instance \"nbr\", which will be removed\nafterward, may scheduled in the NSM thread event queue. And when the\nNSM event thread is fired, dereference for this already freed \"nbr\"\npointer causes SIGSEGV.\nPlease take a look at following timeline of processing sequences.\n" } ] }