)]}' { "log": [ { "commit": "d79668fb440ae2689b54f52c076dbd79a8689135", "tree": "d93c62249206b3199aeeaba766ce64a4bc6753e6", "parents": [ "db93eec18d8f1e840b32ba2cdf8baf2510f6e1a5" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu May 14 14:47:05 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed May 27 23:37:48 2015 +0200" }, "message": "tests: add testcli reference in/out \u0026 do DejaGNU\n\nThis adds reference in \u0026 output for the previously added testcli tool,\nto check basic CLI parsing/help functions. Unlike \"testcommands\", this\none doesn\u0027t depend on compile-time system details.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "db93eec18d8f1e840b32ba2cdf8baf2510f6e1a5", "tree": "1118c5e17cb6e4104f84e7fda909428686a7bb3e", "parents": [ "05a69d2f3833c285b399558ba7ab4a57f194a88d" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 05 11:04:59 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed May 27 23:37:47 2015 +0200" }, "message": "tests: add CLI dummy command-exec tool\n\nThis adds some common CLI testtool code as well as a tool that has a\nbunch of commands to be poked for their correct processing.\n\nThe tool doesn\u0027t work correctly from a script at stdin at this point\nbecause the vty code will throw away all buffered when it sees EOF, so\nthe tail end of the input file is lost.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c313895dec3c176584d99f7b8684ddc3f9141d88", "tree": "88c4715a57bfec3b9f0411ae30fc2fd69bc7c1ba", "parents": [ "4b6c33282973c9e1545a519f2a51bda3cf42ae21" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:02:23 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:44:52 2015 +0200" }, "message": "tests: fix warnings\n\nWhile I don\u0027t see -Werror being used on tests anytime soon, there\u0027s no\nreason to keep the warnings in tests unfixed.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "85c63b844df4a295a64f37573e0ba08a7cc63659", "tree": "a1fe7c27edaf8a04c5fb0eeaa6ca442bab39aac0", "parents": [ "7fe17e6975f4c4dd359364177a1d73ed770d6cd4" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Nov 22 10:31:44 2014 -0800" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Feb 14 19:19:41 2015 +0100" }, "message": "tests: remove --disable-ipv6\n\nWith --disable-ipv6 gone, the IPv6 detection logic in the tests is not\nneeded anymore either.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\nAcked-by: Paul Jakma \u003cpaul@jakma.org\u003e\n" }, { "commit": "237aac56960575f6ad2451ba2796d94bd5ae4b33", "tree": "f23c49fa32bc6b706bd5f37a9a3a45ce27adf15d", "parents": [ "b6fa76098d127f5641a7dda0dee21f06ca167edb" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Jun 28 22:23:10 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Feb 14 19:19:14 2015 +0100" }, "message": "build: get rid of INCLUDES, use AM_CPPFLAGS\n\nINCLUDES in configure.ac was not used at all, and INCLUDES in\nMakefile.am is supposed to be AM_CPPFLAGS these days.\n\nReduces warnings spewed during bootstrap/autoreconf.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\nAcked-by: Greg Troxel \u003cgdt@ir.bbn.com\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\nAcked-by: Paul Jakma \u003cpaul@jakma.org\u003e\n" }, { "commit": "143637198e333f0c822766b38f9d8cfe75c04e21", "tree": "64857d1421dfca50d35532782baecbd98b9033ac", "parents": [ "149210656045c363d8f59b97ad9251b0c06a15df" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 07:26:03 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Feb 06 21:52:06 2015 +0100" }, "message": "tests: fix tests for 1a211cb (missing well-known)\n\nFix tests/aspathtest.c again, this time by including a NEXT_HOP\nattribute (which is out of correct order with AS_PATH, but that doesn\u0027t\nmatter here.) This satisfies bgp_attr_check(), which after 1a211cb\nrefuses updates without nexthop attribute.\n\nFixes: 1a211cb (\"one more fix for tightening of check for missing well-known attributes\")\nCc: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c68f6d9dbb9f910d3ee82e099655fff7c12ef856", "tree": "b21eac804634d638e25e83beffc2cb45715759da", "parents": [ "59135bde25441cd39cea0389467eb206fc9030c9" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 30 06:42:00 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 30 07:06:01 2014 +0100" }, "message": "tests: fix tests for 055086f (well-known attr check)\n\nFix tests/aspathtest.c by including an ORIGIN attribute in the\ntestcases. After 055086f \"bgpd: well-known attr check only run for\nv4/uni, which could cause a crash,\" we\u0027re now checking for it and tests\nare failing due to that.\n\nNote that test #11 (\"4b AS4_PATH w/o AS_PATH\") is no longer accepted as\nOK since the function now checks for the existence of an AS_PATH attr.\n\nFixes: 055086f (\"bgpd: well-known attr check only run for v4/uni\"...)\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "010ebbbca6396f272cc2d50d147dd922dda68213", "tree": "99e92b1795d61adfa554e1cc00e998697962fcc9", "parents": [ "ea55500409651b0f8fd2c8a02fdbf245acc96dd8" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 16 11:53:49 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Sep 19 22:14:55 2014 +0100" }, "message": "Add missing GPL headers, and copyright claims that certainly apply.\n\n* Fix (a subset of)? files with non-trivial code that are missing GPL headers.\n\n* A few copyright claims added which I am certain apply, but which I had\n missed out on the original commits.\n\nNB: Copyright claims are not exclusive and the addition of any copyright\nclaim should not be read as implying a lack of any further claims, or\ndenying the validity of any other claims. All those with claims of\ncopyright over any portion of Quagga are welcome to submit them, ideally as\npatches to update copyright strings in files.\n" }, { "commit": "8b16ed74fa61523c3348d2584b66a56a8ad4e350", "tree": "fe7232f0df942ca8f8bbc386f5089c13d1ec452a", "parents": [ "f57000c0dbdd0e30e71b6651022392f284201e19" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jul 06 22:33:48 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 01:49:17 2014 +0200" }, "message": "tests/bgpd: don\u0027t hardcode error number (fix f57000c)\n\nf57000c (\"bgpd: don\u0027t send NOTIFY twice for malformed attrs\") introduces\nBGP_ATTR_PARSE_ERROR_NOTIFYPLS as additional error code that implies the\ncaller should sent a NOTIFY and convert it to BGP_ATTR_PARSE_ERROR.\nSadly, the latter was hardcoded in bgp_mp_attr_test.c, which now didn\u0027t\nconsider the new value to be an error.\n\nMake the testcase treat all nonzero values as error without discern.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6b0655a25194c7c0331154edaa6124cf783e5e5e", "tree": "c0c7d479f2684531249668210da27a60322ba395", "parents": [ "fdb913aedb5a9807ad60715e8badb4f25d57acea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:53:35 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:58:02 2014 +0200" }, "message": "*: nuke ^L (page feed)\n\nQuagga sources have inherited a slew of Page Feed (^L, \\xC) characters\nfrom ancient history. Among other things, these break patchwork\u0027s\nXML-RPC API because \\xC is not a valid character in XML documents.\n\nNuke them from high orbit.\n\nPatches can be adapted simply by:\n\tsed -e \u0027s%^L%%\u0027 -i filename.patch\n(you can type page feeds in some environments with Ctrl-V Ctrl-L)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "ba32db1e854ff2b26861a2d4e4193a9f1b3816cd", "tree": "ac1e4d87ad17a4ae653576009800b4077c4db00f", "parents": [ "6f2a67031cfb21362fc7ecd3251761799c8ffe27" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Tue Nov 19 14:11:40 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 22 21:15:11 2014 +0200" }, "message": "tests: Add tests for timers\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6f2a67031cfb21362fc7ecd3251761799c8ffe27", "tree": "514ba2ef904d56131bffaa5fbc40443826529641", "parents": [ "cd40b329a2e4da882bcad0431c048c876bbeafbd" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Mon Sep 30 12:27:52 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 01 20:21:42 2014 +0200" }, "message": "ospfd/ospf_vty.c: use keyword cmd style\n\nUse the new keyword command style for:\n\n - default-information originate\n - distance ospf\n - redistribute\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "cd40b329a2e4da882bcad0431c048c876bbeafbd", "tree": "cfbdec5a7559c6d3e56766797896a18809aa1746", "parents": [ "e712d0e3667ffad8109ef8bce3ce01927ee95bb7" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Mon Sep 30 12:27:51 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 01 20:21:41 2014 +0200" }, "message": "lib/command.c: rewrite command matching/parsing\n\nAdd support for keyword commands.\n\nIncludes new documentation for DEFUN() in lib/command.h, for preexisting\nfeatures as well as new keyword specification.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e712d0e3667ffad8109ef8bce3ce01927ee95bb7", "tree": "7d3fd696c771e742c20135a12b4a8f1e382944ac", "parents": [ "8f399b0e4fff2344d75ebf709e1ce55f15269db2" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 01 19:34:55 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 01 20:21:19 2014 +0200" }, "message": "tests: fix build \u0026 disable testcommands\n\nThe perils of having tests, the test wasn\u0027t tested thoroughly enough...\nFixup various automake problems, and then disable it since it depends on\nconfigure parameters in its current version.\n\nFor 0.99.24 we can ship a static copy of vtysh_cmd.c and have it\nreenabled.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8f399b0e4fff2344d75ebf709e1ce55f15269db2", "tree": "e9a2384156a90267a846b03c51435618b2427b1c", "parents": [ "2b00515a9b639fd1e057f3ebf10ded2dde920764" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Mon Sep 30 12:27:50 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 01 17:38:29 2014 +0200" }, "message": "tests: add a test program for lib/command.c\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "4d474fa3297c0d5d632e2c0bff6ccb0edbedaa5d", "tree": "61ca2f19e552df821eb2dc06cd9e06c81993aacf", "parents": [ "c78a46c27f6dfdd42fe0800cebabc1e49cb0a4bf" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Nov 19 15:00:06 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Mar 21 06:28:48 2014 +0100" }, "message": "lib: fix backtraces broken by 837d16c...\n\n837d16c (\"*: use array_size() helper macro\") accidentally changed one of\nthe expressions in the backtrace code, which afterwards read:\n\nzlog_backtrace_sigsafe():\n if (((size \u003d backtrace(array,array_size(array)) \u003c\u003d 0) ||\n\nwhich boils down to: (size \u003d backtrace(...) \u003c\u003d 0). The braces were\nintended to go: (size \u003d backtrace(...)) \u003c\u003d 0.\n\nAll in all, this makes a nice textbook example of the original author\nbeing too clever (trying to save a single line by pulling the assignment\ninto the condition) and the next person touching the code tripping over\nit...\n\nThis code occurs another time in zlog_backtrace() where it is actually\ncorrect. Pulling out the assignment nonetheless. Also, new test\nprogram.\n\nCc: Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\nCc: Balaji.G \u003cbalajig81@gmail.com\u003e\nCc: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a83a1e9c2f035d3152451dcfc97ab13b4ac427b9", "tree": "fa8652ff314e4e6ac5a45192742140f2d4157d85", "parents": [ "fed643f4093abc0ed5e796aab9047768f7036ed6" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Oct 22 11:35:48 2013 -0700" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Oct 22 11:35:48 2013 -0700" }, "message": "build: fix tests/prng.h missing from dist\n\nbroken by fa713d9... \"zebra: rework recursive route resolution\", and I\nforgot to squash the fix into that.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "fa713d9ee5ed30dedd0a290be9aaff780a2896be", "tree": "1d263cce70c341f3f2a73a47d4b1cd5a38b09129", "parents": [ "bfac8dcd2fe7ed099a679b5c8245599c6d0312ed" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Fri Jul 05 15:35:37 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Sep 19 18:04:40 2013 +0200" }, "message": "zebra: rework recursive route resolution\n\nChange the datastructure for recursive routes. This brings the following\nbenefits:\n\nBy using struct nexthop also to store nexthops obtained by recursive\nresolution, we can get rid of quite a bit of code duplication in the fib\nmanagement. (rt_netlink, rt_socket, ...)\n\nWith the new datastructure we can make use of all available paths when\nrecursive routes are resolved with multipath routes.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "d77102025a30eef274e8d343bfec75f87899a417", "tree": "183d4001ebbee78399876e85ba2e6bc0d8ce6be3", "parents": [ "1bf0ca9a07358ff13b1390f4462669e9ea4915dc" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Fri Jul 05 18:30:57 2013 +0200" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Mon Jul 15 08:50:38 2013 -0400" }, "message": "tests: don\u0027t build tests unless make check is run\n\nUse check_PROGRAMS instead of noinst_PROGRAMS in tests/Makefile.am\nto build the tests only when make check is actually run.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\n" }, { "commit": "1bf0ca9a07358ff13b1390f4462669e9ea4915dc", "tree": "686046d5c7170274aaca7b34faa7a9315a670a2a", "parents": [ "4c14b7f684510592f2eb46fd84859d8bca57def9" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Fri Jul 05 18:30:56 2013 +0200" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Tue Jul 09 12:26:46 2013 -0400" }, "message": "tests: fix Makefile.am so it works with BSD make\n\nThe export statement is specific to GNU make and breaks the build\nwith BSD make. I couldn\u0027t observe any difference in behaviour\nbetween having the export present and absent, therefore, just remove it.\n\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\n" }, { "commit": "c69905b673812ce6ec2a12960727a27b9b8d6426", "tree": "2b7608b8d16bedfafbf734d5a0e8ff26646107f1", "parents": [ "5bb7e4d12b3a3015208fad5ee0f3c055b704c8c4" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 24 01:39:14 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Sun Apr 14 16:01:19 2013 +0200" }, "message": "tests: DejaGNU libzebra\n\nWrap the few libzebra test programs we have up for DejaGNU.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "5bb7e4d12b3a3015208fad5ee0f3c055b704c8c4", "tree": "715ef4c4c267687d86e0c8fb7a494c31038c32bd", "parents": [ "f281ab9752393fcc7cbb54c50edb66f25c2a31fb" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Feb 26 17:53:30 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Sun Apr 14 16:01:11 2013 +0200" }, "message": "tests: DejaGNU bgpd\n\nthis just wraps the existing test programs in expect wrappers that make\ntheir results usable to DejaGNU.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f281ab9752393fcc7cbb54c50edb66f25c2a31fb", "tree": "53be958c127d21c6bc0e2e2abd02f33a3fde16c2", "parents": [ "f2b53dac4c72811c06779c596c6162b994eb427a" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Feb 26 16:21:20 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Sun Apr 14 16:01:05 2013 +0200" }, "message": "tests: add DejaGNU framework\n\nDejaGNU seems to be the \u0027standard\u0027 GNU test framework (which by itself\ndoesn\u0027t say much), but it seems relatively usable and the \"remote\nsystem\" capabilities might come in handy for virtualisation-based tests\nfor kernel interactions or something.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c095185c26f72bff14238ca1209ef6b2d7a8b935", "tree": "b6d9fa2ef2a225ff2c85d3d74dc1c94e327eeaab", "parents": [ "4a014580ff85428aa41b28503554b2ce982805be" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Feb 23 22:17:21 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 09 17:05:37 2013 +0200" }, "message": "tests: make --disable-bgpd kill bgpd tests too\n\nbgpd tests don\u0027t compile or run with --disable-bgpd, let\u0027s catch this in\nthe Makefile.\n\nReported-by: Joachim Nilsson \u003ctroglobit@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "aeef13b0d5b50a90f293c93eb5a34c2a099d140b", "tree": "b2463778c9b28b78af6ef722d2ac6b32df7ade6b", "parents": [ "1cb9cf062ec3ed7a3f13fb5465eb5fb917ce3329" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jan 23 04:20:37 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Feb 01 17:55:04 2013 +0100" }, "message": "tests: fix missing init in bgp_mp_attr_test.c\n\nturns out, bgp_mp_reach_parse really doesn\u0027t like getting garbage\nattribute input. In particular, attr-\u003eextra better be NULL or we\nmerrily go trample random places (like our stack).\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "1cb9cf062ec3ed7a3f13fb5465eb5fb917ce3329", "tree": "4ca551c562d14cdd116155dba6aed6d9087c7f7d", "parents": [ "5e728e929942d39ce5a4ab3d01c33f7b688c4e3f" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jan 22 23:39:17 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Feb 01 17:55:04 2013 +0100" }, "message": "tests: update \u0026 extend AS_PATH tests\n\nNB: these tests test for current implementation state, not for RFC\nconformance. In particular, behaviour with confederations in AS4_PATH\nas well as reconcilation of short AS_PATH + AS4_PATH is currently NOT\nconforming to RFC 4893/6793.\n\n* tests/aspath_test.c: add capability to put both AS4_PATH \u0026 AS_PATH,\n add test for AS4_PATH w/o AS_PATH, update confederation test\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8d083b9ec5bb0375ebb6d8b2b05c848febd92cb5", "tree": "42786e058df85f087e48022c33e85f2a9464b1aa", "parents": [ "f6295c29070631b24a391f79d4d37ab9c0807ecc" ], "author": { "name": "Leonid Rosenboim", "email": "lrosenbo@wrs.com", "time": "Tue Nov 06 11:44:04 2012 -0800" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jan 16 01:10:24 2013 +0100" }, "message": "build: update .gitignore for all test programs\n" }, { "commit": "326fe3df2c659d62fc76f8579a414ba271e7f3e9", "tree": "aa493a2e7b7d487749e2109de47b1b88b16ce3fb", "parents": [ "fe9bb6459afe0d55e56619cdc5061d8407cd1f15" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Nov 03 09:13:23 2012 -0700" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Nov 03 09:13:23 2012 -0700" }, "message": "tests: fix missing array_size() include\n\n * tests/test-sig.c: add #include \"lib/memory.h\" to get array_size()\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "d1d3ac9bad0caf7a9c465bb382b924009f0d9168", "tree": "ee76b87f2b3b18ac109bf8b4268bfa5251ac3b34", "parents": [ "b07458a055493dd37cb955ae90f11ae8bc334d3a" ], "author": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Thu Oct 04 16:21:34 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Nov 01 23:03:24 2012 -0700" }, "message": "build: reorder libraries to address linker error\n\nThe linker on some systems (for example, Ubuntu 12.04 LTS x86_64)\nappears to be sensitive to the order in which libraries are\nspecified. On these systems, if a library \u0027A\u0027 depends on a library\n\u0027B\u0027, it has to be specified before \u0027B\u0027 when linking an executable.\n\n * zebra/Makefile.am: Make sure LIBCAP comes after libzebra.\n\n * tests/Makefile.am: Ensure libm comes after libbgp.\n\nSigned-off-by: Avneesh Sachdev \u003cavneesh@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "837d16ccbe0fca413f8927da6a34b1e97ccada8a", "tree": "7aed5a517b619c03d11bf567f6a14cda6f8f5efe", "parents": [ "655071f44aab42e89bcece3a93da456fdd0d913a" ], "author": { "name": "Balaji.G", "email": "balajig81@gmail.com", "time": "Wed Sep 26 14:09:10 2012 +0530" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 25 10:15:59 2012 -0700" }, "message": "*: use array_size() helper macro\n\nUse the array_size() helper macro. Replaces several instances of local\nmacros with the same definition.\n\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "28971c8cb1138700e87dc7da673e59b5596bb51b", "tree": "0e55c3f830681449cd96bb36eb04a6a1293d8b44", "parents": [ "67174041d2d9d8908f8b2c915bc0d186d8442c68" ], "author": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Fri Aug 17 08:19:50 2012 -0700" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Sep 26 21:50:48 2012 +0200" }, "message": "lib/table: add route_table_get_next() and iterator\n\n * lib/table.[ch]\n\n - Add a function (route_table_get_next()) to get the route_node in\n a tree that succeeds a given prefix in iteration order.\n\n This allows one to reliably walk nodes in a tree while allowing\n modifications, and is useful for achieving scale and\n performance. Other approaches are also possible -- the main plus\n point of this one is that it does not require any state about\n the walk to be maintained in the table data structures.\n\n - Add an iterator for walking the nodes in a tree. This introduces\n a new structure (route_table_iter_t) and the following main\n functions.\n\n route_table_iter_init()\n route_table_iter_pause()\n route_table_iter_next()\n route_table_iter_cleanup()\n\n The iterator normally uses node pointers and the existing\n route_next() function to walk nodes efficiently. When an\n iteration is \u0027paused\u0027 with route_table_iter_pause(), it stores\n the last prefix processed. The next call to\n route_table_iter_next() transparently invokes\n route_table_get_next() with the prefix to resume iteration.\n\n * bgpd/bgp_table.[ch]\n\n Add wrappers for the new table features described above.\n\n * tests/table_test.c\n\n Add tests for the new table code.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "9e7a548ce421660b0d22bfeb90c2b2b53742aac7", "tree": "4c962403808f98806781fb4ad15594152bc1effa", "parents": [ "a47c5838e9f445ab887ad927706b11ccbb181364" ], "author": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Tue May 22 14:32:22 2012 +0200" }, "committer": { "name": "Vincent Bernat", "email": "bernat@luffy.cx", "time": "Mon Jun 25 19:03:23 2012 +0200" }, "message": "build: allow configure and build in a separate directory\n\nSome .h files in lib/ are autogenerated. The search path should\ninclude the build directory and the source directory. They usually\nmatch but sometimes, they may be different. For example:\n\n $ mkdir build\n $ cd build\n $ ../configure\n $ make\n" }, { "commit": "c9e4f8623642fc005c97830256000bef5680aa26", "tree": "00a40a75d31cf30727c6dabf8066054e72092647", "parents": [ "cccbc0151883cfb4f43d6fa0a4a3caedc27e6cf5" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 14 10:42:39 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 19 13:40:22 2012 +0100" }, "message": "tests: BGP unit tests to set BGP_OPT_NO_LISTEN so they can run\n\nBGP tests had been broken by auto-creation of listen socket. This allows\nthem to run at least, though at least 1 test seems to have other breakage,\naspath_test.\n" }, { "commit": "1dba254e107dd0c4254d58e9304fc6293b46fd4d", "tree": "963153a04b71da32dd5906b80aaf24a1bb6c93e9", "parents": [ "6ebeebb50610cc86d16e56bc1a33d63340094215" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue May 01 16:20:33 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed May 02 11:02:10 2012 +0100" }, "message": "tests: Fix some compile errors and warnings\n\n* aspath_test.c: match changes in aspath_unintern. Fix printf size_t warning.\n* bgp_capability_test.c: compile warnings.\n* bgp_mp_attr_test.c: update for attr parser context struct\n* ecommunity_test.c: ecommunity_free/ecommunity\n* test-checksum.c: some unused vars and funcs without need of prototypes.\n" }, { "commit": "6ebeebb50610cc86d16e56bc1a33d63340094215", "tree": "77c1f0d9d199a96c6d7ccba19922e5170682e87c", "parents": [ "828f235df4b6a322aac58e1b7d5089c7f9d6cc0a" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed May 02 11:01:01 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed May 02 11:02:10 2012 +0100" }, "message": "Revert \"tests: disable broken tests/bgp_mp_attr_test.c\"\n\nThis reverts commit d78e2b8b562f8496aaf2977f7371415b71e82433. Next 2\ncommits fix it.\n" }, { "commit": "d78e2b8b562f8496aaf2977f7371415b71e82433", "tree": "b2cadec93dcb3871fd1814b036613b7771805698", "parents": [ "4b5a2103b7d03b9209cfa3668d9cebead697bc82" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Tue May 01 18:08:43 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Tue May 01 18:53:16 2012 +0200" }, "message": "tests: disable broken tests/bgp_mp_attr_test.c\n\nit doesn\u0027t compile currently; it\u0027ll be fixed after the 0.99.21 release.\n\n * tests/bgp_mp_attr_test.c: wrap in #if 0 for now\n\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "3cf6c2b4e43f44a977d218c96c26250654ae333e", "tree": "e017cde2015fbf3ef6c250327428d7c6152aa8f7", "parents": [ "01d7ff0a2166a422c56bd26f04fc22832a9e690b", "e96b312150d8e376c1ef463793d1929eca3618d5" ], "author": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Mon Apr 09 00:25:15 2012 -0700" }, "committer": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Mon Apr 09 00:25:15 2012 -0700" }, "message": "Merge branch \u0027quagga\u0027 into google-bgp-multipath\n\nConflicts:\n\tbgpd/bgp_route.c\n" }, { "commit": "05e54ee3df973194f2a00e3ea0b1da7bebc71fd6", "tree": "c07e2bbad0c55fe03eb2975b98f121de6ae55707", "parents": [ "ad8d4802a3078de694539fa9bae12322fc82042f" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Dec 03 17:45:17 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 14:27:01 2011 +0400" }, "message": "build: delete .cvsignore files\n" }, { "commit": "565b828dc00cafd477dd69ce15f0f551ece67710", "tree": "e1d5c6c38f89b6d022339df14c9b5224de7c0ca9", "parents": [ "f8627ff1ef7642c8ee4758b1f046ef0d166dfbec" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 21:08:33 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:07:02 2011 +0400" }, "message": "bgpd: add flag checks for MP_(UN)REACH_NLRI\n\n* bgp_attr.[ch]\n * bgp_mp_reach_parse(): add extra arguments and a uniform flag\n check block\n * bgp_mp_unreach_parse(): idem\n * bgp_attr_parse(): provide extra arguments\n* bgp_mp_attr_test.c\n * parse_test(): justify respective calls\n" }, { "commit": "42e6d745d105018a9469dabad65bd4cf942dcf3c", "tree": "9e653fe2e44d2e3f8510fcb8451931e3b6153ebc", "parents": [ "beb1ca03bfe707d6d1fcad21fcbaa63af49c82f8" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 29 22:14:11 2011 +0400" }, "message": "bgpd: more SAFI fixes\n\n(with resolved conflict in bgpd/bgp_packet.c)\n\nTwo macros resolving to the same integer constant broke a case block and\na more thorough merge of BGP_SAFI_VPNV4 and BGP_SAFI_VPNV6 was\nperformed.\n\n* bgpd.h: MPLS-labeled VPN SAFI is AFI-independent, switch to single\n* macro\n* bgp_capability_test.c: update test data\n* bgp_mp_attr_test.c: idem\n* bgp_route.c: (bgp_maximum_prefix_overflow, bgp_table_stats_vty) update\n macro and check conditions (where appropriate)\n* bgp_packet.c: (bgp_route_refresh_send, bgp_capability_send,\n bgp_update_receive, bgp_route_refresh_receive): idem\n* bgp_open.c: (bgp_capability_vty_out, bgp_afi_safi_valid_indices,\n bgp_open_capability_orf, bgp_open_capability): idem\n* bgp_attr.c: (bgp_mp_reach_parse, bgp_packet_attribute,\n bgp_packet_withdraw): idem\n" }, { "commit": "b82cdeb18f8e68feb797f0b4780ded672635b545", "tree": "474532dc205c0b648c5690dc5c2efba6aa8f12ef", "parents": [ "6159928d28285938356a3d48d2477fbdb7890e61" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 01 16:52:03 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:34:26 2011 +0400" }, "message": "delete CVS keywords\n" }, { "commit": "de8d5dff1523bb9fe47d54f31c9e5322bd805b44", "tree": "95d71dffb32d9e67a2f892ac5689a884117dcbcd", "parents": [ "96450faf3385a6ed9f4dd5c2c58776c4a664a8da" ], "author": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:46:01 2011 -0700" }, "committer": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:46:01 2011 -0700" }, "message": "bgpd: Adds support to mark up the BGP rib table entry with multipath\ninformation based on the multipath list (mp_list) generated during\nthe best path calculation. Display \"multipath\" for paths that are\nmultipath and also on bestpath if the route is multipath. Flag a\nbest path with the BGP_INFO_MULTIPATH_CHG if the multipath\nset has changed since the last update. This can be used to trigger\nupdates to zebra and peers.\n\nThe multipath markup is a lazily allocated bgp_info_mpath structure\nthat is added to the best path and any multipaths. The mpath structures\nare linked together with the best path element at the head and the\nother elements ordered by nexthop and then by peer address. This\nmarkup scheme is updated by calling bgp_info_mpath_update() and passing\nin a new mp_list the the current multipath set. There are additional\nAPI\u0027s for walking the multipath set, querying the count of multipaths,\nand for cleaning up the multipath markup information when freeing path\ninformation.\n\n* bgpd/bgp_mpath.c\n * bgp_info_mpath_new(): Allocation of new mpath element\n * bgp_info_mpath_free(): Release memory for mpath element\n * bgp_info_mpath_get(): Access mpath element of path. Allocate memory\n on-demand\n * bgp_info_mpath_enqueue(): Enqueue a path onto the multipath list\n * bgp_info_mpath_dequeue(): Remove a path from the multipath list\n * bgp_info_mpath_first(): Return first path on the multipath list\n * bgp_info_mpath_next(): Return next path on the multipath list\n * bgp_info_mpath_count(): Return the number of paths on the multipath list\n * bgp_info_mpath_count_set(): Set the number of paths on the multipath list\n * bgp_info_mpath_update(): Update multipath markup on bgp route table entry\n and flag any changes. Emit \u0027debug bgp event\u0027 output on any multipath\n change.\n* bgpd/bgp_mpath.h\n * struct bgp_info_mpath: Information added to a bgp_info path to record\n multipath information\n * External declarations for new functions in bgp_mpath.c\n* bgpd/bgp_route.c\n * bgp_info_free(): Free mpath memory when freeing path information\n * bgp_info_reap(): Dequeue path from multipath queue before deleting it\n * bgp_best_selection(): Calls bgp_info_mpath_update() with latest\n mp_list to mark-up rib table entry\n * bgp_vty_out_detail(): Add display of multipath flag for a path. Also\n display \u0027multipath\u0027 for bestpath if it is a multipath route\n* bgpd/bgp_route.h\n * struct bgp_info: Add pointer to bgp_info_mpath information\n * Add flags to mark a path as multipath (BGP_INFO_MULTIPATH) and\n to mark bestpath if multipath information has changed\n (BGP_INFO_MULTIPATH_CHG)\n* lib/memtypes.c\n * Add MTYPE_BGP_MPATH_INFO for allocating memory for bgp_info_mpath\n* tests/bgp_mpath_test.c\n * Add test case for bgp_info_mpath_update() and supporting functions\n" }, { "commit": "96450faf3385a6ed9f4dd5c2c58776c4a664a8da", "tree": "26c56a71548686a7d6797b79377ccc5e25730186", "parents": [ "42ea68512fc4d04b500def45e8f899321f4081e7" ], "author": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:45:12 2011 -0700" }, "committer": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:45:12 2011 -0700" }, "message": "bgpd: Adds equal-paths check to path comparison. Paths that are\nequal to the best path are accumulated onto an ordered list (mp_list)\nif maximum-paths is configured. A future commit will add the\nmultipath markup to the BGP rib table based on the mp_list. Add\nunit test for the added mp_list functions.\n\nDeterministic MED is not supported in this commit, it will be\nadded later.\n\n* bgpd/bgp_aspath.c\n * Make aspath_cmp() an external symbol so it can be used in\n equivalent paths check\n* bgpd/bgp_aspath.h\n * Add extern declaration of aspath_cmp()\n* bgpd/bgp_mpath.c\n * bgp_info_nexthop_cmp(): Compares nexthops of two paths\n * bgp_info_mpath_cmp(): Compare function to order multipaths by\n nexthop and then by peer address\n * bgp_mp_list_init(): Initialize a list with the multipath order function\n * bgp_mp_list_clear(): Clear out the mp_list\n * bgp_mp_list_add(): Add a multipath to mp_list\n* bgpd/bgp_mpath.h\n * External declarations for above added functions in bgp_mpath.c\n* bgpd/bgp_route.c\n * bgp_info_cmp(): Add equivalent paths result (paths_eq). If eBGP\n paths are equal down to IGP metric check, flag as equal if peer AS\n matches. Similarly for iBGP paths but compare full AS_PATH.\n * bgp_best_selection(): If multipath is enabled, accumulate equivalent paths\n in mp_list. Add debug bgp event output to see result (will be filtered\n later to display only when change occurs)\n * bgp_process_rsclient(): Pass multipath config to bgp_best_selection()\n * bgp_process_main(): Pass multipath config to bgp_best_selection()\n* tests/bgp_mpath_test.c\n * Add unit test case for bgp_mp_list functions\n" }, { "commit": "42ea68512fc4d04b500def45e8f899321f4081e7", "tree": "8a993e42cd5f1e74369936df7c6f92b378ede5ba", "parents": [ "165b5fff9dde5536d9cb1f850b36c17bf5654f0f" ], "author": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:44:23 2011 -0700" }, "committer": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:44:23 2011 -0700" }, "message": "bgpd: add bgp_mpath_test.c\n\n* tests/bgp_mpath_test.c\n * New file with test framework for testing BGP multipath\n * Add test for CLI support functions\n* tests/Makefile.am\n * Add new testbgpmpath target\n" }, { "commit": "b881c7074bb698aeb1b099175b325734fc6e44d2", "tree": "70b4816a083166bbf00c1f85f19a67df0c0a5948", "parents": [ "c112af27ed8f158ecece0d73ce2016c166076c00" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 23 16:35:42 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Implement revised error handling for partial optional/trans. attributes\n\n* BGP error handling generally boils down to \"reset session\". This was fine\n when all BGP speakers pretty much understood all BGP messages. However\n the increasing deployment of new attribute types has shown this approach\n to cause problems, in particular where a new attribute type is \"tunneled\"\n over some speakers which do not understand it, and then arrives at a speaker\n which does but considers it malformed (e.g. corruption along the way, or\n because of early implementation bugs/interop issues).\n\n To mitigate this drafts before the IDR (likely to be adopted) propose to\n treat errors in partial (i.e. not understood by neighbour), optional\n transitive attributes, when received from eBGP peers, as withdrawing only\n the NLRIs in the affected UPDATE, rather than causing the entire session\n to be reset. See:\n\n http://tools.ietf.org/html/draft-scudder-idr-optional-transitive\n\n* bgp_aspath.c: (assegments_parse) Replace the \"NULL means valid, 0-length\n OR an error\" return value with an error code - instead taking\n pointer to result structure as arg.\n (aspath_parse) adjust to suit previous change, but here NULL really\n does mean error in the external interface.\n* bgp_attr.h (bgp_attr_parse) use an explictly typed and enumerated\n value to indicate return result.\n (bgp_attr_unintern_sub) cleans up just the members of an attr, but not the\n attr itself, for benefit of those who use a stack-local attr.\n* bgp_attr.c: (bgp_attr_unintern_sub) split out from bgp_attr_unintern\n (bgp_attr_unintern) as previous.\n (bgp_attr_malformed) helper function to centralise decisions on how to\n handle errors in attributes.\n (bgp_attr_{aspathlimit,origin,etc..}) Use bgp_attr_malformed.\n (bgp_attr_aspathlimit) Subcode for error specifc to this attr should be\n BGP_NOTIFY_UPDATE_OPT_ATTR_ERR.\n (bgp_attr_as4_path) be more rigorous about checks, ala bgp_attr_as_path.\n (bgp_attr_parse) Adjust to deal with the additional error level that\n bgp_attr_ parsers can raise, and also similarly return appropriate\n error back up to (bgp_update_receive). Try to avoid leaking as4_path.\n* bgp_packet.c: (bgp_update_receive) Adjust to deal with BGP_ATTR_PARSE_WITHDRAW\n error level from bgp_attr_parse, which should lead to a withdraw, by\n making the attribute parameter in call to (bgp_nlri_parse) conditional\n on the error, so the update case morphs also into a withdraw.\n Use bgp_attr_unintern_sub from above, instead of doing this itself.\n Fix error case returns which were not calling bgp_attr_unintern_sub\n and probably leaking memory.\n* tests/aspath_test.c: Fix to work for null return with bad segments\n" }, { "commit": "50ef565e4e689ba653b9709be4d28a01f6cca885", "tree": "c9655b58de02931d9c314f9f3325a42f1079ef89", "parents": [ "ab005298526f4b14126cae1a6461ad3d700af29c" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sat Nov 27 23:14:02 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "tests: Extend aspath_test.c with cases for invalid segments \u0026 attributes\n\n* aspath_test.c: Add more test cases. In particular ones to cover the\n last invalid-segment problem. Also add ability to specify aspath attribute\n headers and test them somewhat.\n\n NB: It\u0027s obvious this test has not been run for a year by anyone, despite\n 2 non-trivial commits to bgpd aspath code.\n" }, { "commit": "cddb8112b80fa9867156c637d63e6e79eeac67bb", "tree": "c8d8b4cb9d0ba1c2a7681c6da580874cf5a2b48e", "parents": [ "d64379e8f3c0636df53ed08d5b2f1946cfedd0e3" ], "author": { "name": "Chris Hall", "email": "chris.hall@highwayman.com", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "message": "bgpd: fix handling of AS path data\n\n* bgpd/bgp_aspath.c\n * assegments_parse(): add handling of AS4_PATH input, update bounds\n checks, add check for AS segment type\n * aspath_parse(): add handling of AS4_PATH input, expect\n assegments_parse() to do length checking\n * aspath_empty(): update for the new function prototype\n* bgpd/bgp_aspath.h: ditto\n* tests/aspath_test.c: ditto\n* bgpd/bgp_attr.c\n * bgp_attr_aspath(): add handling of AS4_PATH input, update flags\n checks, change returned type\n * bgp_attr_as4_path(): discard, superseded by bgp_attr_aspath()\n * bgp_attr_parse(): update respectively\n" }, { "commit": "065de90380c88d9fcc116627f714bed9984c2723", "tree": "79061a2699e0dc3e87c218b3b57c2f0577d5a69a", "parents": [ "5bd5881838c22e075c3d0c245a8952a55e9dca38" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Fri Aug 07 11:13:49 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 13 10:21:13 2009 +0100" }, "message": "all: check return value from daemon() call\n\n* */*main.c: (main) Current versions of Gcc warn if the return value for\n daemon() is not checked. So add a simple test and exit on failure.\n\n" }, { "commit": "439c52f19007badffc6707673121f5a76784e728", "tree": "2e16cabd2f63de4bfd5eddc24c08b1e1a593f95b", "parents": [ "77a1c4e05ca5a7d7bf07456758f7c934ee867884" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Dec 01 16:25:06 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 25 15:36:39 2009 +0100" }, "message": "Add test for Internet checksum.\n\nAdd 2 impl. of the Internet Checksum. One new optimized nad\none form RFC 1071. Turns out that the current Quagga in_cksum()\nis buggy. On Big Endian routers it miscalculates odd sized buffers.\n" }, { "commit": "5d4b8cf2faba9f5386810a7c70837e5b7fae3572", "tree": "ec89383f7bfd4684a0cde15648e5f00e8d2d8f7b", "parents": [ "41dc3488cf127a1e23333459a0c316ded67f7ff3" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Nov 16 18:34:19 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Nov 16 18:47:02 2008 +0000" }, "message": "[lib] Switch Fletcher checksum back to old ospfd version\n\n* lib/checksum.c: (fletcher_checksum) Switch the second phase of the checksum\n back to the old ospfd logic.\n\n The isisd-derived version:\n\n a) is very hard to follow\n b) had some kind of subtle bug that caused it be wrong when c0\u003d0 and c1\u003d254\n (potentially fixable by doing the mods before adjusting x and y)\n\n Additionally:\n\n - explicitely cast expressions using non-internal variables to int, to ensure\n the result is signed.\n - defensively change the length argument to \u0027size_t\u0027, to ensure the code\n works with that argument being unsigned..\n\n Thanks to Joakim Tjernlund for the investigative work into this bug.\n\n* tests/test-checksum.c: new file to exercise the checksum code.\n" }, { "commit": "d68cbf9261869e532dfdd14dbb4122b3f3feb0d4", "tree": "5cc873e6a38a3db9ad5fb4dfe579624ff7693c13", "parents": [ "3998bfd76620a676fbd77f19c5c6ea80a4cc88d2" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Oct 21 18:35:27 2006 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 20:00:46 2008 +0100" }, "message": "[administrivia] Git should ignore backup files and .loT files\n" }, { "commit": "3998bfd76620a676fbd77f19c5c6ea80a4cc88d2", "tree": "66bf93340e55bb06b25544ef04afec3749269391", "parents": [ "e5248434c0d287668be956a2bd52399d67b16c39" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Aug 19 14:13:43 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:57:22 2008 +0100" }, "message": "[trivia] Remove ChangeLog files, as this data is now maintained in SCM\n" }, { "commit": "46bc0e432e756fcb8fc4f703b47cd25b9fc7139c", "tree": "60100ca1e11c3c3600441d366b236f4a2de519ca", "parents": [ "d664ae1182c29b74b409bc8594b7bd0575e91ce9" ], "author": { "name": "Paul P Komkoff Jr", "email": "i@stingr.net", "time": "Wed Aug 13 16:17:04 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:12 2008 +0100" }, "message": "[build] Test for GNU-style PIE support in toolchain and enable\n\n2008-08-13 Paul P Komkoff Jr \u003ci@stingr.net\u003e\n\n\t* configure.ac: add a configure flag and autoconf macro, which will\n\t determine if your toolchain supports PIE.\n\t* */Makefile.am: add corresponding CFLAGS and LDFLAGS into\n\t appropriate places.\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "3c5a0a4f8fe3811affff6d5e123379eedb083571", "tree": "79e285e0bd04c6ef0dfcde9cf0ce8fda8abecbe1", "parents": [ "750e814693050bc97391eec618aad9db798ee5e8" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Feb 19 17:30:10 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:49:33 2008 +0100" }, "message": "[administrivia] Add .gitignore files, based on .cvsignores.\n" }, { "commit": "1eab26bbc67b1dd36ac44f7fdd427871b3c6b59b", "tree": "0b11e75b1c7cb267f311f2b918765a3a9f1c3a8b", "parents": [ "3d52bb8085c32b54fa21d88588310716245291d4" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:44:30 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:44:30 2008 +0000" }, "message": "[tests] BGP MP_(UN)REACH_NLRI unit tests (actual file..)\n\n2008-06-07 Paul Jakma \u003cpaul@jakma.org\n\n\t* bgp_mp_attr_test.c: MP_(UN)REACH_NLRI unit tests\n" }, { "commit": "343f720b345dd377bdf4f53e3b02e0c2898f3f0b", "tree": "b6f4d9053d79074a7dc2799d5d8fc07fe93c062b", "parents": [ "13e896ba2a449848791dd7d020c59fe75cbd562b" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:32:38 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:32:38 2008 +0000" }, "message": "[tests] BGP MP_(UN)REACH_NLRI unit tests\n\n2008-06-07 Paul Jakma \u003cpaul@jakma.org\n\n\t* bgp_mp_attr_test.c: MP_(UN)REACH_NLRI unit tests\n" }, { "commit": "d38e8d63fdfc0aefb78d0a51ffdf06d8b47993fd", "tree": "314cffb6ac8013547e35a3fe223ed98f8d5a411d", "parents": [ "c7350c48462e305f18f6fb02eceac170f892e450" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Feb 23 16:57:03 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Feb 23 16:57:03 2008 +0000" }, "message": "[tests:bgp] Further tests for 0 sized as_path segments\n\n2008-02-23 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* aspath_test.c: Test for 0-ASN sequences that still have data.\n" }, { "commit": "370b64a2ad38e43b4bed028960481bbf4192becd", "tree": "ebecb7f934a7058d582e52b5c64a21eb676ec994", "parents": [ "a7f93f3e060fdb2dc7bf5ff4ed4563d4b689bc6c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "message": "[bgpd] Fix number of DoS security issues, restricted to configured peers.\n\n2007-12-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Fix series of vulnerabilities reported by \"Mu Security\n\t Research Team\", where bgpd can be made to crash by sending\n\t malformed packets - requires that bgpd be configured with a\n\t session to the peer.\n\t* bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only\n\t set the attribute flag indicating AS4_PATH if we actually managed\n\t to parse one.\n\t (bgp_attr_munge_as4_attrs) Assert was too general, it is possible\n\t to receive AS4_AGGREGATOR before AGGREGATOR.\n\t (bgp_attr_parse) Check that we have actually received the extra\n\t byte of header for Extended-Length attributes.\n\t* bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.\n\t* bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,\n\t incorrect -2 left in place from a development version of as4-path\n\t patch.\n\t* bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter\n\t needs to be properly sanity checked.\n\t* tests/bgp_capability_test.c: Test for empty capabilities.\n" }, { "commit": "5b5bfb8c06d0dc444e2c3da8cc5c893519981834", "tree": "c807af986ab3a3d3d2962f3339217461c72e3dfe", "parents": [ "0b2aa3a0a8b095bdef1eddda117d173af75dede2" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Oct 18 16:33:08 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Oct 18 16:33:08 2007 +0000" }, "message": "[tests] Forgot to commit ecommunity_tests.c\n" }, { "commit": "0b2aa3a0a8b095bdef1eddda117d173af75dede2", "tree": "29201cb2beec187409e842b4078ed8a8047d3f11", "parents": [ "7593fddfa1558d086e3142ad96cf2790007f5d84" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "message": "[bgpd] Merge AS4 support\n\n2007-10-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* NEWS: Note that MRT dumps are now version 2\n\t* (general) Merge in Juergen Kammer\u0027s AS4 patch.\n\n2007-09-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_aspath.c: (assegment_normalise) remove duplicates from\n\t from sets.\n\t (aspath_reconcile_as4) disregard a broken part of the RFC around\n\t error handling in path reconciliation.\n\t* aspath_test.c: Test dupe-weeding from sets.\n\t Test that reconciliation merges AS_PATH and AS4_PATH where\n\t former is shorter than latter.\n\n2007-09-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* aspath_test.c: Test AS4_PATH reconcilation where length\n\t of AS_PATH and AS4_PATH is same.\n\n2007-09-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (peek_for_as4_capability) Fix to work.\n\t* bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.\n\t* tests/bgp_capability_test.c: (general) Extend tests to validate\n\t peek_for_as4_capability.\n\t Add test of full OPEN Option block, with multiple capabilities,\n\t both as a series of Option, and a single option.\n\t Add some crap to beginning of stream, to prevent code depending\n\t on getp \u003d\u003d 0.\n\n2007-09-18 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (bgp_capability_as4) debug printf inline with others.\n\t (peek_for_as4_capability) There\u0027s no need to signal failure, as\n\t failure is better dealt with through full capability parser -\n\t just return the AS4, simpler.\n\t* bgp_packet.c: (bgp_open_receive) Update to match\n\t peek_for_as4_capability change.\n\t Allow use of BGP_AS_TRANS by 2b speakers.\n\t Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.\n\t (bgp_capability_msg_parse) missing argument to debug print\n\t (bgp_capability_receive) missing return values.\n\t* tests/bgp_capability_test.c: (parse_test) update for changes to\n\t peek_for_as4_capability\n\n2007-07-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Remove 2-byte size macros, just make existing macros take\n\t argument to indicate which size to use.\n\t Adjust all users - typically they want \u00271\u0027.\n\t* bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any\n\t as4\u0027s in a path.\n\t (aspath_put) Return the number of bytes actually written, to\n\t fix the bug Juergen noted: Splitting of segments will change\n\t the number of bytes written from that already written to the\n\t AS_PATH header.\n\t (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP\n\t is still defined as 2b.\n\t (aspath_aggregate) fix latent bug.\n\t (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation\n\t function.\n\t (aspath_key_make) Hash the AS_PATH string, rather than\n\t just taking the addition of assegment ASes as the hash value,\n\t hopefully sligthly more collision resistant.\n\t (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes\n\t together with the OLD 2-byte forms, code Juergen\n\t had in bgp_attr_parse but re-organised a bit.\n\t (bgp_attr_parse) Bunch of code from Juergen moves\n\t to previous function.\n\t (bgp_packet_attribute) Compact significantly by\n\t just /always/ using extended-length attr header.\n\t Fix bug Juergen noted, by using aspath_put\u0027s\n\t (new) returned size value for the attr header rather\n\t than the (guesstimate) of aspath_size() - the two could\n\t differ when aspath_put had to split large segments, unlikely\n\t this bug was ever hit in the \u0027wild\u0027.\n\t (bgp_dump_routes_attr) Always use extended-len and\n\t use aspath_put return for header length. Output 4b ASN\n\t for AS_PATH and AGGREGATOR.\n\t* bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix\n\t hash callback declarations to match prototypes.\n\t (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,\n\t complete rewrite of Juergen\u0027s changes (no asdot support)\n\t* bgp_open.c: (bgp_capability_as4) New, does what it says\n\t on the tin.\n\t (peek_for_as4_capability) Rewritten to use streams and\n\t bgp_capability_as4.\n\t* bgp_packet.c: (bgp_open_send) minor edit\n\t checked (in the abstract at least) with Juergen.\n\t Changes are to be more accepting, e.g, allow AS_TRANS on\n\t a 2-byte session.\n\t* (general) Update all commands to use CMD_AS_RANGE.\n\t* bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..\n\t Remove stuff replicated by VTY_GET_LONG\n\t (bgp_clear_vty) Return bgp_clear directly to vty.\n\t* tests/aspath_test.c: Exercise 32bit parsing. Test reconcile\n\t function.\n\t* tests/ecommunity_test.c: New, test AS4 ecommunity changes,\n\t positive test only at this time, error cases not tested yet.\n\n2007-07-25 Juergen Kammer \u003cj.kammer@eurodata.de\u003e\n\n\t* (general) AS4 support.\n\t* bgpd.h: as_t changes to 4-bytes.\n\t* bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.\n\t* bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE\n\t added for 2-byte.\n\t Add AS16 versions of length calc macros.\n\t (aspath_count_numas) New, count number of ASes.\n\t (aspath_has_as4) New, return 1 if there are any as4\u0027s in a\n\t path.\n\t (assegments_parse) Interpret assegment as 4 or 2 byte,\n\t according to how the caller instructs us, with a new\n\t argument.\n\t (aspath_parse) Add use32bit argument to pass to\n\t assegments_parse. Adjust all its callers to pass 1, unless\n\t otherwise noted.\n\t (assegment_data_put) Adjust to be able to write 2 or 4 byte\n\t AS, according to new use32bit argument.\n\t (aspath_put) Adjust to write 2 or 4.\n\t (aspath_gettoken) Use a long for passed in asno.\n\t* bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and\n\t BGP_ATTR_AS4_AGGREGATOR.\n\t (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as\n\t determined by received-capability flag.\n\t (bgp_attr_aspath_check) New, code previously in attr_aspath\n\t but moved to new func so it can be run after NEW_AS_PATH\n\t reconciliation.\n\t (bgp_attr_as4_path) New, handle NEW_AS_PATH.\n\t (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.\n\t (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.\n\t (bgp_attr_parse) Add handoffs to previous parsers for the two\n\t new AS4 NEW_ attributes.\n\t Various checks added for NEW/OLD reconciliation.\n\t (bgp_packet_attribute) Support 2/4 for AS_PATH and\n\t AGGREGATOR, detect when NEW_ attrs need to be sent.\n\t* bgp_debug.{c,h}: Add \u0027debug bgp as4\u0027.\n\t* bgp_dump.c: MRTv2 support, unconditionally enabled, which\n\t supports AS4. Based on patches from Erik (RIPE?).\n\t* bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4\n\t support.\n\t* bgp_open.c: (peek_for_as4_capability) New, peek for AS4\n\t capability prior to full capability parsing, so we know which\n\t ASN to use for struct peer lookup.\n\t (bgp_open_capability) Always send AS4 capability.\n\t* bgp_packet.c: (bgp_open_send) AS4 handling for AS field\n\t (bgp_open_receive) Peek for AS4 capability first, and figure\n\t out which AS to believe.\n\t* bgp_vty.c: (bgp_show_peer) Print AS4 cap\n\t* tests/aspath_test.c: Support asn32 changes, call aspath_parse\n\t with 16 bit.\n\t* vtysh/extract.pl: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/extract.pl.in: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/vtysh.c: AS4 compatibility for router bgp ASNUMBER\n" }, { "commit": "e08286bcf8a73d1922b0464bef52c1b27eda7c43", "tree": "8b590fbc547455b133deab93b1e43cd532ee2a71", "parents": [ "fb31c0fea38c863ddcda56f46c36f065340b9e32" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Sep 18 12:11:26 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Sep 18 12:11:26 2007 +0000" }, "message": "[bgpd] Fix typo, which prevented advertisement of MP (non-IPv4) prefixes\n\n2007-09-17 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (bgp_capability_mp) We were setting\n\t afc_nego[safi][safi] rather than afc_nego[afi][safi], thus\n\t failling to announce any non-IPv4 prefixes. Remove the extra,\n\t typo-ed character.\n\t* bgp_capability_test.c: Test that peer\u0027s adv_recv and adv_nego get\n\t set correctly for MP capability and given AFI/SAFI.\n\t Colour OK/failed result so it\u0027s easier to find them.\n" }, { "commit": "ed6ef902df72cc8267e274ed515a47af52c9fed7", "tree": "0416ad08fe181227b10f6e1c0e331b7a01a205db", "parents": [ "8bc9805929d4b3af2e77ef04db278884d82d71fd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Aug 08 14:13:03 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Aug 08 14:13:03 2007 +0000" }, "message": "[tests] Add bgp_capability_test.c, should have been part of earlier commit\n" }, { "commit": "6d58272b4cf96f0daa846210dd2104877900f921", "tree": "a97f2c9c797bd96b298aa64f03ed69115d63e78b", "parents": [ "dfdb8f18c008e7ad306588c86b12fbef337427ca" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:21:45 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:21:45 2007 +0000" }, "message": "[bgpd] cleanup, compact and consolidate capability parsing code\n\n2007-07-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Clean up and compact capability parsing slightly.\n\t Consolidate validation of length and logging of generic TLV, and\n\t memcpy of capability data, thus removing such from cap specifc\n\t code (not always present or correct).\n\t* bgp_open.h: Add structures for the generic capability TLV header\n\t and for the data formats of the various specific capabilities we\n\t support. Hence remove the badly named, or else misdefined, struct\n\t capability.\n\t* bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.\n\t Do the length checks *before* memcpy()\u0027ing based on that length\n\t (stored capability - should have been validated anyway on input,\n\t but..).\n\t (bgp_afi_safi_valid_indices) new function to validate (afi,safi)\n\t which is about to be used as index into arrays, consolidates\n\t several instances of same, at least one of which appeared to be\n\t incomplete..\n\t (bgp_capability_mp) Much condensed.\n\t (bgp_capability_orf_entry) New, process one ORF entry\n\t (bgp_capability_orf) Condensed. Fixed to process all ORF entries.\n\t (bgp_capability_restart) Condensed, and fixed to use a\n\t cap-specific type, rather than abusing capability_mp.\n\t (struct message capcode_str) added to aid generic logging.\n\t (size_t cap_minsizes[]) added to aid generic validation of\n\t capability length field.\n\t (bgp_capability_parse) Generic logging and validation of TLV\n\t consolidated here. Code compacted as much as possible.\n\t* bgp_packet.c: (bgp_open_receive) Capability parsers now use\n\t streams, so no more need here to manually fudge the input stream\n\t getp.\n\t (bgp_capability_msg_parse) use struct capability_mp_data. Validate\n\t lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.\n\t (bgp_capability_receive) Exported for use by test harness.\n\t* bgp_vty.c: (bgp_show_summary) fix conversion warning\n\t (bgp_show_peer) ditto\n\t* bgp_debug.h: Fix storage \u0027extern\u0027 after type \u0027const\u0027.\n * lib/log.c: (mes_lookup) warning about code not being in\n same-number array slot should be debug, not warning. E.g. BGP\n has several discontigious number spaces, allocating from\n different parts of a space is not uncommon (e.g. IANA\n assigned versus vendor-assigned code points in some number\n space).\n" }, { "commit": "3414bf250a385496fa6c11dbaa9a5f79100d7a48", "tree": "d020e1f392ea753060be9ddc2a0da525d4a00ddf", "parents": [ "2518efd15b75687d4791a5eb4b0d7febc36cffbc" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 27 06:53:24 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 27 06:53:24 2006 +0000" }, "message": "[tests] update heavywq for workqueue api changes\n\n2006-08-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* heavy-wq.c: (slow_func_del,slow_func) update to match workqueue\n\t changes\n" }, { "commit": "1f742f21a98f756cea03856849fa2f82f467baf7", "tree": "fe295616ed2036e691cf85f7fd73083ad4ddc2fd", "parents": [ "36943749147bef10df8ffc0e2ad79f4dd06cd9ac" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 06 15:52:11 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 06 15:52:11 2006 +0000" }, "message": "[bgpd] aspath_loop_check was broken, fix it and the aspath unit test code.\n\n2006-08-06 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which\n\t essentially had disabled this check. Problem reported by\n\t Bartek Kania \u003cmrbk@gnarf.org\u003e in [quagga-users 7388].\n\t* aspath_test.c: (validate) Fix the sense of the aspath_loop_check,\n\t which was the wrong way around and had actually been testing for\n\t aspath_loop_check to be buggy.\n" }, { "commit": "1602a71d7a64395254e175c5c417fa593647b995", "tree": "75b7b7bbf9a0c9e83b3e6786ae48cb80dd163c09", "parents": [ "f783c1d7bcf0674920cbae066de954fe926fd3ac" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun May 28 08:32:44 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun May 28 08:32:44 2006 +0000" }, "message": "[tests] Fix stray character in previous commit\n" }, { "commit": "f783c1d7bcf0674920cbae066de954fe926fd3ac", "tree": "03c87b6ede5786f2e456b7a75c1c8ee86f80e626", "parents": [ "fb66b29c6701129f0222275eaa206f7ac8ab30cc" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun May 28 08:31:17 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun May 28 08:31:17 2006 +0000" }, "message": "[tests] test-sig.c: configure logging\n\n2006-05-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* test-sig.c: (main) configure logging, there\u0027s no terminal\n\t to write to for one thing, but we do want stdout, and we\n\t don\u0027t want a test to spam syslog.\n" }, { "commit": "5d932f61972fb5e3109c6aa3caa4b960b675f941", "tree": "dbec3a34dab3d6ae3af9069ed20966e10c4614c9", "parents": [ "75db03ebb169da26102275c70eff0a0ebaae04cb" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:42:50 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:42:50 2006 +0000" }, "message": "[tests] fix heavy-wq, add redundant AS_SET test and statics to aspath_test\n\n2006-03-16 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* heavy-wq.c: (heavy_wq_init) delay is gone from workqueue\n\t spec.\n\t* aspath_test.c: (test_segments) Add an AS_SET with redundant\n\t ASNs.\n\t ({empty_prepend,prepend,parse}_test) add static qualifiers\n" }, { "commit": "590188b67db4021b9d1552238ef49482dd5f0123", "tree": "0e8a17b1fbb1359e55fcfcaaa058d45e61bf1f33", "parents": [ "53f953a500569b12bb3c60b094c52f1b4184c0fb" ], "author": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:33:47 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:33:47 2006 +0000" }, "message": "[cvs] update cvsignore file.\n" }, { "commit": "6726f950ad25daa532e75dc7a6875b340ae0447d", "tree": "c58764ee0b640a72d433da936434f5768a685d31", "parents": [ "8fdc32ab9a81cb80296d322346867c8c3d2b2b37" ], "author": { "name": "paul", "email": "paul", "time": "Mon Jan 16 12:06:00 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Jan 16 12:06:00 2006 +0000" }, "message": "2006-01-16 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* aspath_test.c: (validate) free the temporary aspaths.\n\t (empty_get_test) ditto.\n" }, { "commit": "067fca86323b189fabf4c64c0b9ccb98a458b981", "tree": "2a8b28a2cad3d1a956748204b7b20eecb63b1496", "parents": [ "4b201d46348b81bd9d59aa626c81f7457ea6ef38" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jan 10 14:49:04 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jan 10 14:49:04 2006 +0000" }, "message": "[tests] Add small unit test for the new stream functions\n\n2006-01-10 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* test-stream.c: new file, small unit test for new\n\t resize and {put,get}-quad stream functions.\n\t* Makefile.am: build teststream unit test.\n" }, { "commit": "5906476bea21153f5d757e364b8e4c604b72cef1", "tree": "09fb18f3bc10b6b5e3adf01bfef49cfd3115254e", "parents": [ "ad72740e884f16c1f30a99168428fdd15fadaa68" ], "author": { "name": "paul", "email": "paul", "time": "Wed Nov 23 02:48:14 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Nov 23 02:48:14 2005 +0000" }, "message": "[tests] Add empty-path and sequence+1ASN test data to aspath_test.c\n\n2005-11-23 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* aspath_test.c: Add an empty aspath to test segments, and to\n\t compare tests.\n\t Add a segment identical to seq1, but with one extra asn.\n\t Fix bogus free of stream in make_aspath for case where\n\t no stream was allocated (empty path data).\n" }, { "commit": "84771ee0deadae6d83b939a2d3f8f83cc420a829", "tree": "68b3e5c5cc6e84dd7d57a4bda2e61616d518a1a2", "parents": [ "77df1f78597af79209777d264ec9986f33a2fd17" ], "author": { "name": "paul", "email": "paul", "time": "Tue Oct 11 03:48:28 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Oct 11 03:48:28 2005 +0000" }, "message": "2005-10-11 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* test-privs.c: Privileges unit test.\n\t* Makefile.am: build testprivs\n\t* aspath_test.c: fix a few sign warnings\n" }, { "commit": "1f377b0202dfc4653f7717de964b628a369a9526", "tree": "ff8718a3d40adbec8adeab994a32873bbbd4bacf", "parents": [ "fe69a505f7be4357bf8523e3bbdced9c95590f3a" ], "author": { "name": "paul", "email": "paul", "time": "Sat Sep 10 18:00:11 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Sep 10 18:00:11 2005 +0000" }, "message": "2005-09-06 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* aspath_test.c: Test bgp_aspath functionality.\n\t* Makefile.am: build aspathtest\n\t* ChangeLog: Fix date of previous commit\n" }, { "commit": "dff4f5272f7c3289b0c7eebe441cf7c223bcb044", "tree": "113b16e046e029b52220a4c7bc96eb8102af7612", "parents": [ "6379b96117a50803236fe698e4e27d9849f3a3bc" ], "author": { "name": "paul", "email": "paul", "time": "Tue Sep 06 23:08:01 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Sep 06 23:08:01 2005 +0000" }, "message": "2004-09-06 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* test-buffer.c: include memory.h\n (main) call memory_init().\n" }, { "commit": "6379b96117a50803236fe698e4e27d9849f3a3bc", "tree": "2b01eef69470adb3ea4b10c309b553bf44357403", "parents": [ "eb820afe3b53321624317cfa6b426ecae1392f24" ], "author": { "name": "paul", "email": "paul", "time": "Mon Sep 05 14:00:09 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Sep 05 14:00:09 2005 +0000" }, "message": "2004-09-05 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* heavy-wq.c: (slow_func_del,slow_func_err) make them take\n\t void * argument to shut up silly gcc warning.\n" }, { "commit": "9f3f7a1145a42942b28bae6b68163d805bb91b56", "tree": "439b8f849496aebd1bd5fa72523790fa0bf49c0a", "parents": [ "147aff0fa4c3c1f54270881851b6c2c23418b031" ], "author": { "name": "paul", "email": "paul", "time": "Mon Apr 25 16:42:24 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Apr 25 16:42:24 2005 +0000" }, "message": "2004-05-25 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* main.c: new file, common \u0027main\u0027 portion which then calls\n\t test_init.\n\t* heavy.c: remove common portions now in \u0027main.\n\t* heavy-wq.c: ditto\n\t* heavy-thread.c: ditto\n\t* heavy*.c: Set the slow_function iteration number lower, to 300, it\n\t was several orders of magnitude too \u0027slow\u0027 to be useful. :)\n\t* Makefile.am: main is a source of the tests. heavy should link\n\t to the math library.\n" }, { "commit": "1d2c893b61211761a17bb2e51345a2eaed12cf1f", "tree": "e45d47b36df1293c4a0402646f3bb478c2154ec8", "parents": [ "864c364df9eb7d119ce81db834eff6a726e2fa78" ], "author": { "name": "paul", "email": "paul", "time": "Fri Apr 22 00:54:44 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Apr 22 00:54:44 2005 +0000" }, "message": "2004-05-22 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* Makefile.am: Build heavythread\n" }, { "commit": "864c364df9eb7d119ce81db834eff6a726e2fa78", "tree": "0e17cf1c611f406aec6af94ae90887104811fb6c", "parents": [ "a48b4e6d074a4e61ce9e8bf78fdb8ea9c57c6e64" ], "author": { "name": "paul", "email": "paul", "time": "Fri Apr 22 00:50:08 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Apr 22 00:50:08 2005 +0000" }, "message": "2004-05-22 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* heavy-thread.c: Andrew Schorr\u0027s adaptation of heavy.c to use a\n\t background thread to avoid responsivity problems.\n" }, { "commit": "cb0663c41a5c61c6261f6d5607526e56be0ed2d4", "tree": "8f99e78deb4c3dc92257deb33ab02b3d6c32cd46", "parents": [ "f4d062f87298d8098436704eb15d079d2cfe7efd" ], "author": { "name": "paul", "email": "paul", "time": "Thu Apr 21 17:23:48 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Apr 21 17:23:48 2005 +0000" }, "message": "- bah, commit changelog\n" }, { "commit": "f4d062f87298d8098436704eb15d079d2cfe7efd", "tree": "c6babfbd9f6c260ac32958af193bcce398a10437", "parents": [ "f3ff15541592bab1435775f7b79c1cd267bd57f3" ], "author": { "name": "paul", "email": "paul", "time": "Thu Apr 21 16:58:44 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Apr 21 16:58:44 2005 +0000" }, "message": "2004-05-21 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* heavy.c: Add a timer thread to demonstrate thread interactivity,\n\t Add a daemon_exit command to assist with debugging (eg for memory\n\t tracers, etc..)\n" }, { "commit": "43313d05bce956b65711516f7aadf99ee2fed192", "tree": "7a9e42a7600b1c4e87a0be7d206b9605847d1b2e", "parents": [ "924b9229717b749e303f3fb161616bebf53b5cdc" ], "author": { "name": "paul", "email": "paul", "time": "Tue Apr 19 21:28:36 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Apr 19 21:28:36 2005 +0000" }, "message": "2004-05-19 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* heavy.c: test programme to show how long-running functions\n\t kill responsiveness. Demonstrating the most niggly problem\n\t left in bgpd.\n" }, { "commit": "662a1f25bb6c142c0ff5ff571095356df49c0557", "tree": "3fe999c2731936118ffa9b91f313bc7ff209d762", "parents": [ "4dcadf7efd58e9d91a52c5f06c02cb40bbf21823" ], "author": { "name": "paul", "email": "paul", "time": "Wed Apr 13 03:32:23 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Apr 13 03:32:23 2005 +0000" }, "message": "- add changelog\n" }, { "commit": "4dcadf7efd58e9d91a52c5f06c02cb40bbf21823", "tree": "5968d1e9773c79cfe0db364ce91314087cb57f6e", "parents": [ "5d6e26910b6790e7ea759893c16e9f0e380fcc1e" ], "author": { "name": "paul", "email": "paul", "time": "Wed Apr 13 03:31:35 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Apr 13 03:31:35 2005 +0000" }, "message": "2004-05-13 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* test-buffer.c: Andrew\u0027s buffer tester\n\t* test-memory.c: basic memory tester\n\t* Makefile.am: Add new tests\n" }, { "commit": "3c035aa8716efa6f677e43435c5eb9bac6825518", "tree": "ea28fd6b6beadd72d3619315dc66ee0d03a3f7d3", "parents": [ "e064d6d9c3c3319c62fe4fac3e4e5f7a1941a98c" ], "author": { "name": "paul", "email": "paul", "time": "Tue Nov 02 18:59:49 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Nov 02 18:59:49 2004 +0000" }, "message": "- Add .arch-ids and .arch-inventory to cvsignore, to allow one to use arch\n with CVS trees.\n" }, { "commit": "41c14a1fc3c97f8cfcb4ef8f8bce12a2d9ad29df", "tree": "d9b53eadf8cf0043c1c35bae2f58dd7ba853b858", "parents": [ "1203e1c07c444df615605168c72852389e20340c" ], "author": { "name": "paul", "email": "paul", "time": "Mon Jul 26 19:27:51 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Jul 26 19:27:51 2004 +0000" }, "message": "2004-07-26 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* configure.ac: reenable tests/Makefile\n\t* tests/Makefile.am: automake file for tests dir\n\t* tests/.cvsignore: update\n" }, { "commit": "d26ca6a976421b09ee6c4e5ac699075b6f549584", "tree": "447ea71cea6be30ec26194069e7d61acd211ba8a", "parents": [ "074a917aeb16061440d932c1f3ffccd7afc475a1" ], "author": { "name": "paul", "email": "paul", "time": "Sun Jun 06 15:25:35 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sun Jun 06 15:25:35 2004 +0000" }, "message": "CVS ignore Linux NFS silly-delete .nfs* files\n" }, { "commit": "c15cfa832940dbdf49d1c1f03cfbab9078708e1e", "tree": "573b23ecef4d14c4c351a28dd7d9fce1b72b67bc", "parents": [ "2d75d05218b76230bbd608cab8d08a5f47d77056" ], "author": { "name": "paul", "email": "paul", "time": "Mon Jan 19 21:33:17 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Jan 19 21:33:17 2004 +0000" }, "message": "add appropriate cvsignore\n" }, { "commit": "9a76e2ddb6c4dc303ce7ed937c0cfa9430c3ed27", "tree": "1dff2778c9b6a397213fa4bf4ad2f7dab607396b", "parents": [ "c49b30692d7a2379264dfd2d45c2d2ab16e8822c" ], "author": { "name": "paul", "email": "paul", "time": "Mon Jan 19 21:25:17 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Jan 19 21:25:17 2004 +0000" }, "message": "2004-01-19 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * tests/test-sig.c: New file, regression test for sigevents.\n" } ] }