)]}' { "log": [ { "commit": "ccc5d2bb9b7a395375a34cb6a6b703d78e885b1d", "tree": "6763bac236bd0125c68d5f414a082a3d30007a20", "parents": [ "31894370d26de0b91b5c003ca6c592f0a487d60f" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Fri Oct 02 14:50:08 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:51 2015 +0100" }, "message": "[pim] Ref. on LW-MLDv2\n" }, { "commit": "31894370d26de0b91b5c003ca6c592f0a487d60f", "tree": "97fda3fb256ca456e981907e1df76f0ed2df0865", "parents": [ "40765fe45f39767ad545ca693fb5985fa90ce4ca" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Thu Oct 01 10:04:02 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:51 2015 +0100" }, "message": "[pim] Hint for test_igmpv3_join command-line utility\n" }, { "commit": "40765fe45f39767ad545ca693fb5985fa90ce4ca", "tree": "8a21efb5483af7531c396e1cd26c8983d4170e34", "parents": [ "465185300b26042e1813d53f179616a17154d37a" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Wed Sep 30 17:10:11 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:51 2015 +0100" }, "message": "[pim] Command line tool to test IGMPv3 join.\n" }, { "commit": "465185300b26042e1813d53f179616a17154d37a", "tree": "d2efc8fd4184340bd8b74226f4a941e37d54d82d", "parents": [ "b471196e812d98b3ce42bcc186d3a381080d423a" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Fri Sep 11 15:05:40 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:51 2015 +0100" }, "message": "[pim] clean-up\n" }, { "commit": "b471196e812d98b3ce42bcc186d3a381080d423a", "tree": "d7f81339dfb5e75c6c1107db7d2b257331b7877a", "parents": [ "47afa6e19b69b433c0c0d0b73837118e0a1284cc" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Fri Sep 11 11:15:42 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] ip mroute show: can display the MFC\n" }, { "commit": "47afa6e19b69b433c0c0d0b73837118e0a1284cc", "tree": "14f4d21483ba0f85a2d308265ace55021788c36e", "parents": [ "54d6c57db53a626e21766ce608e69f30396a95f0" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Thu Aug 27 18:23:02 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] Version up to 0.158\n" }, { "commit": "54d6c57db53a626e21766ce608e69f30396a95f0", "tree": "62f8ca8ee7d87953d29777a9f07c623343d84e13", "parents": [ "5f35a5236435522f49f9a95d3b59009f947b9130" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Thu Aug 20 18:31:03 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] Fixed doc on CAVEAT C7\n" }, { "commit": "5f35a5236435522f49f9a95d3b59009f947b9130", "tree": "7d8174ad8dd7edab12bc7dac51237cd6924852a3", "parents": [ "bcc4abe09d3faa9b392be2d46e3f6a29b75e46d9" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Thu Aug 20 11:57:41 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] show ip pim lan-prune-delay: fix cosmetic alignment\n" }, { "commit": "bcc4abe09d3faa9b392be2d46e3f6a29b75e46d9", "tree": "b17cb8398321cf9affcc79ddd970a359e993015e", "parents": [ "942b0fdcc18c3841c6781f6a3f36aa47a604ba1f" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Mon Aug 17 18:18:59 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] More RPF cache refresh statistics\n" }, { "commit": "942b0fdcc18c3841c6781f6a3f36aa47a604ba1f", "tree": "70c0188f2a71027736b5b9b3f867dc33e965ddd3", "parents": [ "df4044b2cbe0015d06d25de25e640fca231243dd" ], "author": { "name": "Leonard Herve", "email": "leonardherve@yahoo.fr", "time": "Fri Aug 14 15:49:06 2009 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] Correction for cross-compilation error with this syntax\n" }, { "commit": "df4044b2cbe0015d06d25de25e640fca231243dd", "tree": "a4dd57c802866bc4ffb5b50e98989916fce79a5f", "parents": [ "613938d48abb863660691641a5761f10402cf3f3" ], "author": { "name": "Leonard Herve", "email": "leonardherve@yahoo.fr", "time": "Fri Aug 14 10:38:52 2009 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "Router Alert option for IGMP packets but not for PIM packets\n" }, { "commit": "613938d48abb863660691641a5761f10402cf3f3", "tree": "0efe84a9b6949b52abfa692660629a72f8bb9d76", "parents": [ "d12beab1b9ce09c50672adb3c980e64ccd11edb4" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Thu Aug 13 15:39:31 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] RPF cache refresh statistics\n" }, { "commit": "d12beab1b9ce09c50672adb3c980e64ccd11edb4", "tree": "b22f8a83ea98c416efc5b6d76d013d21a1d706d5", "parents": [ "236b01556122fba479118797163c44849073ff46" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Wed Aug 12 10:52:22 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:50 2015 +0100" }, "message": "[pim] Move encoded source address length check to pim_parse_addr_source\n" }, { "commit": "236b01556122fba479118797163c44849073ff46", "tree": "88f56db5ff7e57c657fc43bd53be5f0fb0845e1a", "parents": [ "e96f0af2679e3c91518f62b3a86d811cafba1adc" ], "author": { "name": "Leonard Herve", "email": "leonard.herve@yahoo.fr", "time": "Tue Aug 11 15:51:52 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:49 2015 +0100" }, "message": "[pim] igmpv3: specific query interval set to 1 second (RFC 3376 8.8.)\n[pim] pim messages: encoded source address format with Sparse bit\u003d1 (RFC 4601 4.9.1.)\n[pim] and Mask Len MUST be equal to 32\n[pim] dr election: new traces\n[pim] fix triggered_hello_delay_msec randomization\n" }, { "commit": "e96f0af2679e3c91518f62b3a86d811cafba1adc", "tree": "dc6d563472991c383e1437475d29d487de8d2974", "parents": [ "596470f2a410fb58109fd880f04362984ffd7c69" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Tue Aug 11 15:48:02 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:49 2015 +0100" }, "message": "[pim] Log physical interface up/down\n[pim] Replace strerror with safe_strerror\n[pim] Fix PIM socket removal from non-PIM interfaces\n[pim] show ip igmp querier: left-align Querier string\n[pim] Version up to 0.157\n[pim] Recipe to re-sync with Quagga repository\n[pim] Build vtysh in development script\n" }, { "commit": "596470f2a410fb58109fd880f04362984ffd7c69", "tree": "d5eac65e626b688e44451efbf32f4a9518fa5a27", "parents": [ "871dbcfede60a8d2d286728bcbd88f27c2035b87" ], "author": { "name": "Leonard Herve", "email": "leonard.herve@yahoo.fr", "time": "Tue Aug 11 15:45:26 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:49 2015 +0100" }, "message": "[pim] pim commands added to vtysh\n" }, { "commit": "871dbcfede60a8d2d286728bcbd88f27c2035b87", "tree": "f3188f3ab1c4856febf70647a32f6d854668aa50", "parents": [ "b162ab753e70328cb6815e58b4bc5b03e9dd4f42" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Tue Aug 11 15:43:05 2009 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Feb 04 06:07:49 2015 +0100" }, "message": "[pim] Initial pim 0.155\n" }, { "commit": "b162ab753e70328cb6815e58b4bc5b03e9dd4f42", "tree": "2457d5c0002d89a6df20fa47db4856a75ee23717", "parents": [ "a4e830c7cc0e10a851047aebe008ce7a3f8ef29b" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Feb 02 03:00:22 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Feb 02 03:00:22 2015 +0100" }, "message": "doc: explain rpf lookup default mode\n\nReported-by: Alexis Rosen \u003cquagga-users@alexis.users.panix.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a4e830c7cc0e10a851047aebe008ce7a3f8ef29b", "tree": "08c6cd5e17eab334c16bfc426d8ff6e305f402d5", "parents": [ "e832c34fd19aa6b2df7c28e78f07617095cf136e" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Jan 30 01:44:25 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Jan 30 01:44:25 2015 +0100" }, "message": "doc: zebra multicast RIB commands\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e832c34fd19aa6b2df7c28e78f07617095cf136e", "tree": "493f820738828b863d4c90bad01c4c1026d45133", "parents": [ "ca2b105f3bdd8859117756dc8d8c2406e28af28b" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jan 27 20:24:15 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Jan 30 01:12:54 2015 +0100" }, "message": "zebra: mark multicast commands experimental\n\ndepending on feedback from actually having these commands in a released\nversion, we may want to adjust them. Thus, mark them as experimental so\nusers are aware of this.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "ca2b105f3bdd8859117756dc8d8c2406e28af28b", "tree": "b1b7b1030a224413bf632baffe3058f16fd67e8d", "parents": [ "240c56f3a41cb7018460ba6e36c9b559c897e3d0" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:12:35 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Jan 30 01:12:45 2015 +0100" }, "message": "zebra: add \"show ip rpf\" to get result of RPF lookup\n\nChecking what route exactly a RPF lookup for a given source uses is\nessential for an administrator to debug multicast routing issues. This\ncommand provides exactly that, using the multicst RPF lookup function\nand printing out its result to the CLI.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "240c56f3a41cb7018460ba6e36c9b559c897e3d0", "tree": "76e7bd769f19a7544b05e0070cdf058a5739eedb", "parents": [ "29ce93ebf6427d1d64eae8b385e36873e3ddcb88" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jan 06 19:53:24 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Jan 30 01:12:38 2015 +0100" }, "message": "zebra: make MRIB lookup behaviour switchable\n\ndepending on the usage scenario (and availability of multitopology IGP\nprotocols, which is currently zero in Quagga), different approaches of\nMulticast RPF lookups are useful.\n\nReference behaviours from commercial vendors are urib-only/mrib-only\n(Juniper, depending on inet.2 availability) and lowest-distance (Cisco).\nAs we are currently without MT IGP support, mrib-first seems the most\nuseful default for Quagga.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "29ce93ebf6427d1d64eae8b385e36873e3ddcb88", "tree": "35c1db9ecf10ac368fe6d46faa9573c3d9f74a94", "parents": [ "c048dccaf537508019ccda658d75bbb0cfd7ad18" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:09:36 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Jan 30 01:12:20 2015 +0100" }, "message": "zebra: return route_node from rib_match_ipv4_safi\n\nThe multicast code needs to know the route_node in addition to the rib\nentry in order to perform distance or prefix-length comparisons. Add it\nas optional \"out\" pointer parameter.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c048dccaf537508019ccda658d75bbb0cfd7ad18", "tree": "410decc7d5b639f09e99c1f97037335fd32c6ee4", "parents": [ "9e6366d73675a5b65220641b71d7710cde8c1143" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Jan 12 07:05:06 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Jan 30 01:11:17 2015 +0100" }, "message": "zebra: dummy kernel \"install\" multicast routes\n\nThis is a followup to 9511633 (\"zebra: MBGP routes should not be\ninstalled in the kernel\"), which was correct in disabling MRIB routes\nbeing installed in the kernel, yet broke the MRIB since now routes were\nnever marked as active.\n\nHence, push down the check into the kernel install functions, so that\nthe routes are still marked active. At the same time, the FPM calls get\na check each since otherwise we\u0027d bump the FPM interface on MRIB\nupdates.\n\nFixes: 9511633 (\"zebra: MBGP routes should not be installed in the kernel\")\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "9e6366d73675a5b65220641b71d7710cde8c1143", "tree": "ad48d81146ca5800f81f6a3a2e704e65c49688fe", "parents": [ "96bb266e0fde451f36c5463e789714eacc1ae63c" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:53 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:53 2015 +0100" }, "message": "zebra: fix optional distance on static mrib route\n\nUnfortunately, the quagga CLI parser doesn\u0027t support [\u003c1-255\u003e]. Fix by\nworking around with an alias.\n\nReplaces the following commits:\n- zebra: mrib: [no] ip mroute - require distance.\n- zebra: mrib: [no] ip mroute - make distance optional.\n(Rewritten as alias)\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "96bb266e0fde451f36c5463e789714eacc1ae63c", "tree": "53100e721420b4453ecd65da7a713a1db661a862", "parents": [ "c409791083892f6c95baca1c79c80290dc595be4" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Mon Jul 14 11:19:00 2014 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:45 2015 +0100" }, "message": "zebra: mrib: static route support\n\nWith the MRIB being independent from the Unicast RIB, there\u0027s currently\nnow way to add static routes to the MRIB. Address that by adding a\nseparate set of commands for MRIB static routes.\n\nCombines these original patches:\n- zebra: mrib: ip mroute command to add unicast route to MRIB for multicast RPF.\n- zebra: mrib: no ip mroute: Fix removal of static multicast RPF route.\n- zebra: mrib: remove unused static_add/delete_ipv4\n- zebra: Cleanups to zebra_rib.\n- pimd: Merge pim-only branch.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c409791083892f6c95baca1c79c80290dc595be4", "tree": "4770504c8091a0865b061679ae1234989c55073e", "parents": [ "12150f08b76c91225dcd877308fecb13026041ef" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sat Nov 22 14:44:20 2014 -0800" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:45 2015 +0100" }, "message": "zebra: kill rib_match_ipv4()\n\nSince this function is internal to zebra, there is no reason to keep\nthis one-line indirect wrapper to rib_match_ipv4_safi() around.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "12150f08b76c91225dcd877308fecb13026041ef", "tree": "37b7b2d52b1a430fcdf45556d11a734e22edad3b", "parents": [ "be4fb4312531cdae986a83b0375dbd1e0606067e" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Fri Sep 19 16:39:34 2014 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:45 2015 +0100" }, "message": "zebra: mrib: Include BGP routes in RPF lookups\n\nThe rib_match_ipv4() function was previously used only for iBGP\nrecursive nexthop lookups, which ignore eBGP routes. This is not\ndesirable for PIM RPF lookups, which may well use an eBGP route.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "be4fb4312531cdae986a83b0375dbd1e0606067e", "tree": "10c8f9e149ac3eafc89385badf5674c5f0eeb3e7", "parents": [ "a59b6152bbcd2ff6734872ecbffbc9c43701e1a8" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Tue Jul 01 15:15:52 2014 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:45 2015 +0100" }, "message": "zebra: add ZEBRA_IPV4_NEXTHOP_LOOKUP_MRIB\n\nThis adds a new zapi call \"ZEBRA_IPV4_NEXTHOP_LOOKUP_MRIB\" performing a\nMulticast RPF lookup for a given source. Details of the lookup\nbehaviour are left to the zebra side of things.\n\nNote: this is non-reactive, as in, only delivers a snapshot of the state\nat a particular point in time. There\u0027s no push notification of changes\nhappening to the RIB.\n\nThis combines the following 3 original patches:\n- zebra: add zsend_ipv4_nexthop_lookup_mrib()\n- zserv: Query mrib (SAFI_MULTICAST).\n- zebra: Cleanups to zebra_rib.\n\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a59b6152bbcd2ff6734872ecbffbc9c43701e1a8", "tree": "e31607e1089f05b78fbb84e2e24ec4f4b1f45d01", "parents": [ "346a8b50334ac837e6a6af0dbe472e9a87dacd1e" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Fri Nov 21 15:57:45 2014 -0800" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:45 2015 +0100" }, "message": "zebra: point rib_match_ipv4() to ._safi()\n\nSince rib_match_ipv4() is just rib_match_ipv4_safi() for SAFI_UNICAST,\nthe former can be removed and pointed to the latter instead.\n\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "346a8b50334ac837e6a6af0dbe472e9a87dacd1e", "tree": "60fbfd01c1fac71f4c63686fdf4ead296ee214f9", "parents": [ "f7b3d1e067ac8088a61136c53d24078b675e0197" ], "author": { "name": "Everton Marques", "email": "everton.marques@gmail.com", "time": "Mon Sep 22 19:35:51 2014 -0300" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:03:45 2015 +0100" }, "message": "zebra: add rib_match_ipv4_safi()\n\nThis is the same as rib_lookup_ipv4(), without the SAFI hardcoded.\n\nCc: Balaji G \u003cbalajig81@gmail.com\u003e\nCc: Everton Marques \u003ceverton.marques@gmail.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f7b3d1e067ac8088a61136c53d24078b675e0197", "tree": "5d93d50f4d002a6638263b39f913ba357a8f9eb5", "parents": [ "e0b0ac8c97d9b8885785ed0461f87a34e70f368e" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:02:13 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 19:02:13 2015 +0100" }, "message": "zebra: identify MRIB on debug messages\n\nsince the same code handles both URIB and MRIB, the debug messages can\nget rather confusing if the RIB isn\u0027t identified. Mark the MRIB in\ndebug messages so we can distinguish that.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e0b0ac8c97d9b8885785ed0461f87a34e70f368e", "tree": "c14b932430f1d8ff25a00b48cc2e38fd4b604ea5", "parents": [ "1c6db0d2da34044ddfb42665fda8a3387ecc451d" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Apr 24 20:22:53 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Jan 22 18:46:22 2015 +0100" }, "message": "zebra: factor out rib debug logs\n\nIntroduces a logging function that takes a struct route_node * argument,\nand prefixes log output with that node\u0027s prefix. While this removes\nsome duplication, it will also later be useful for srcdest route nodes.\n\nBehaviour before and after the patch should be exactly identical.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "1c6db0d2da34044ddfb42665fda8a3387ecc451d", "tree": "db97535c0d8c97bbecde8f2141b12cc53fb8e556", "parents": [ "daefeb8755e194dd19a5f1910bc78d13c8147efb" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Dec 12 21:35:28 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jan 06 19:53:30 2015 +0100" }, "message": "lib: don\u0027t create circular lists (fixes 6d83113)\n\nLISTNODE_DETACH doesn\u0027t clear out the node, and LISTNODE_ATTACH doesn\u0027t\nset -\u003enext (since it assumes a fresh/zeroed listnode). As a result, the\nnew listnode_move_to_tail() created a nice circular list, in turn\ncrashing ospfd in ospf_write() later.\n\nReported-by: Martin Winter \u003cmwinter@netdef.org\u003e\nFixes: 6d83113 (\"ospfd: Tweak previous iface RR write patch to avoid free/malloc \u0026 redundant log\")\nCc: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\nAcked-by: Greg Troxel \u003cgdt@ir.bbn.com\u003e\nAcked-by: Dinesh Dutt \u003cddutt@cumulusnetworks.com\u003e\nAcked-by: Vincent JARDIN \u003cvincent.jardin@6wind.com\u003e\n" }, { "commit": "daefeb8755e194dd19a5f1910bc78d13c8147efb", "tree": "5e00bccf96a80388e7160aca7a9623c40f874b07", "parents": [ "cffe7807c03b7edea005869086720e2f1fb070c6" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Dec 08 17:42:12 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Dec 08 17:46:07 2014 +0100" }, "message": "bgpd: set BGP_ATTR_MP_[UN]REACH_NLRI (fixes 1a211cb)\n\nUnfortunately, the attribute present bits for MP_REACH and MP_UNREACH\nwhich 1a211cb (\"bgpd: one more fix\"...) tests for are never set in their\ncorresponding attribute parsing functions.\n\nReported-by: Martin Winter \u003cmwinter@netdef.org\u003e\nFixes: 1a211cb \"bgpd: one more fix for tightening of check for missing well-known attributes\"\nCc: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "cffe7807c03b7edea005869086720e2f1fb070c6", "tree": "ba2106f3124a31e5cc3107ac75dc6aa16eab6970", "parents": [ "273b1bd341afff86ba571e0be296d88dba627136" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Dec 07 03:27:13 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Dec 07 22:53:20 2014 +0100" }, "message": "bgpd: stop startup timer on stopping BGP (fixes dd49eb1)\n\nbgp_delete() really needs to kill t_startup, otherwise after creating\nand quickly destroying a BGP instance it may fire on a deallocated\nstruct bgp, overwriting memory.\n\nReported-by: Martin Winter \u003cmwinter@netdef.org\u003e\nFixes: dd49eb1 (\"Fix BGP\u0027s use of restart bit.\")\nCc: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\nAcked-by: Vincent JARDIN \u003cvincent.jardin@6wind.com\u003e\n" }, { "commit": "273b1bd341afff86ba571e0be296d88dba627136", "tree": "b82720f4c6d11bb9c33c75e4eb5612e789f6da60", "parents": [ "5e4ba81dc212b172e715afa7b6ea668cddd8485d" ], "author": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Tue Dec 02 14:51:49 2014 -0500" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Tue Dec 02 20:24:23 2014 -0500" }, "message": "zebra/kernel_socket.c: Use platform alignment\n\nUse the platform-provided RT_ROUNDUP macro to align sockaddrs on the\nrouting socket, rather than using hard-coded assumptions about\nalignment. Emit a warning if the OS doesn\u0027t define alignment macros.\n\nResolves failure of ripngd on NetBSD 6 i386, which changed alignment\nto uint64_t from long.\n" }, { "commit": "5e4ba81dc212b172e715afa7b6ea668cddd8485d", "tree": "ff1b40293b610a0d10523b3b7fcc0b047dd4d7e9", "parents": [ "85c854aa720c02a56b1ecbbf12a763a326d11a63" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Mon Oct 20 17:49:44 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 25 15:57:12 2014 +0000" }, "message": "doc: Document \u0027set as-path prepend\u0027 and \u0027set as-path prepend last-as\u0027\n" }, { "commit": "85c854aa720c02a56b1ecbbf12a763a326d11a63", "tree": "23928a702774512c806782e98f9c1aab3eb2f5c5", "parents": [ "1a211cb369dc865a4e7e9f58a100c041af457262" ], "author": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Tue Sep 30 11:31:53 2014 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 25 15:57:12 2014 +0000" }, "message": "bgpd: implement route-map set as-path prepend last-as\n\nIt picks up the AS to add from the aspath, or uses the peers\nAS number. Useful mostly in iBGP setups.\n\nSigned-off-by: Timo Teräs \u003ctimo.teras@iki.fi\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "1a211cb369dc865a4e7e9f58a100c041af457262", "tree": "2f9bc481464ea27c46a0389134ee2e31df7e9c7a", "parents": [ "ec98d90767b341877fb7f1547f025b946955899a" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Sat Nov 01 17:21:47 2014 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 25 15:57:12 2014 +0000" }, "message": "bgpd: one more fix for tightening of check for missing well-known attributes\n\n* bgp_attr.c: (bgp_attr_check) The check for missing NEXT_HOP has the right\n spirit, but wrong where it counts, on the logic. It wouldn\u0027t catch a\n missing NEXT_HOP on a v4-only UPDATE. It would though have incorrectly\n flagged next-hop as missing on multi-protocol-only UPDATEs.\n\n Caught by Martin Winter with a test-suite.\n" }, { "commit": "ec98d90767b341877fb7f1547f025b946955899a", "tree": "3a467ac8a7457c55d8c77ea2549d4eb721d8cc61", "parents": [ "dd49eb1f0232cd0600a3565b44b5c066a8d7872d" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Tue Oct 14 11:14:06 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:26:16 2014 +0000" }, "message": "bgpd: trivial, remove unneeded extra variable in bgp_capability_restart\n" }, { "commit": "dd49eb1f0232cd0600a3565b44b5c066a8d7872d", "tree": "58598aae7dfc1c0ec2686314bf58b7e30d5e31a1", "parents": [ "443010383e2c8e5dc1bc722d9e22a97c513b4647" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue Sep 30 14:36:38 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:26:10 2014 +0000" }, "message": "Fix BGP\u0027s use of restart bit.\n\nbgpd-restart-bit-fix.patch\n\nISSUE:\n\nQuagga BGP doesn\u0027t send or use the restart-bit via the Graceful-Restart(GR)\ncapability. GR capability implementation isn\u0027t complete as per the RFC.\n\nPATCH:\n\nPatch uses BGP instance creation as the beginning of the startup period,\nand \u0027restart_time\u0027 is taken as the startup period. As a result, BGP will\nset the restart bit in the GR capability of the OPEN messages during the\nstartup period.\n\nAs an indication of quagga implementation\u0027s capability of sending End-Of-RIB,\nhelping a restarting neighbor, quagga BGP will now send global GR capability\nirrespective of the graceful-restart config in BGP and the address-family\nspecific GR capability will be sent only if the GR config is present.\nForwarding bit is not set assuming its not preserved.\n\nIncorporated feedback from David Lamparter via the quagga-dev mailing list.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "443010383e2c8e5dc1bc722d9e22a97c513b4647", "tree": "567e65b01392dcc8183ee92648d2d56709035c43", "parents": [ "4bab6806914dbb4b43f376ebf966a034a0ea72cd" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Thu Oct 09 18:14:54 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:26:10 2014 +0000" }, "message": "bgpd: remove unused variables\n" }, { "commit": "4bab6806914dbb4b43f376ebf966a034a0ea72cd", "tree": "3b5e1cc5217bef269184e30795314de6ba8fafe5", "parents": [ "ad5233a1bcdd7124992300673ad9c1035336eadd" ], "author": { "name": "Vipin Kumar", "email": "vipin@cumulusnetworks.com", "time": "Tue Sep 30 14:32:22 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:26:04 2014 +0000" }, "message": "Fix to take care of ordering between interface and router ospf command.\n\nSYMPTOM:\n\nInterface mode OSPF area configuration is not retained after restarting quagga.\n\nExample -\n\nquagga(config)# interface swp49\nquagga(config-if)# ip ospf area 0.0.0.0\n\nquagga# sh run\n\u003csnip\u003e\ninterface swp49\n ip ospf area 0.0.0.0\n ipv6 nd suppress-ra\n link-detect\n!\n\nquagga# write memory\n\n* Restart quagga at this point*\n\nquagga# sh run\n\u003csnip\u003e\ninterface swp49\n ipv6 nd suppress-ra\n link-detect\n!\n\nISSUE:\n\nThe issue is that the interface mode commands can reach the OSPF process even\nbefore \u0027router ospf\u0027 command that initializes the default OSPF instance, this\nis not getting handled properly in OSPF process.\n\nFIX:\n\nInitialize the default OSPF instance during OSPF process initializations, which\nis before \u0027router ospf\u0027 command is received in OSPF process. So, when interface\nmode command is received, it is guaranteed to have ospf instance to work with.\n\nOther way could be to call ospf_get() instead of ospf_lookup() while processing\nthe config command callbacks, although OSPF needs to have at least one instance\nstructure anyways, therefore calling it unconditionally in OSPF initializations\nshould be fine too.\n\nThere could be more elaborate fix(es) possible to handle this, like adding some\nordering mechanism for commands as they are read by a process, or storing the\nreceived command and applying it after the commands its dependent upon are\nprocessed. For the issue at hand, initializing the default instance in main()\nserves the purpose well.\n\nSigned-off-by: Vipin Kumar \u003cvipin@cumulusnetworks.com\u003e\nReviewed-by: Dinesh Dutt \u003cddutt@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "ad5233a1bcdd7124992300673ad9c1035336eadd", "tree": "bde5fc3a4e11d7b66cada6edbcd0c4c04ef988b0", "parents": [ "8306be211f1bcd5a19e74d08cde399e1b518ed25" ], "author": { "name": "Dinesh G Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Sep 30 14:19:57 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:51 2014 +0000" }, "message": "Add set ipv6 next-hop peer-address command.\n\nIPv4 has the ability to specify the peer address with the keyword peer-address.\nIPv6 mandates the use of a specific global or local address only in setting the\nnext-hop in routemaps. This makes it cumbersome to configure some large networks\nwith BGP and IPv6. This patch fixes that deficiency.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "8306be211f1bcd5a19e74d08cde399e1b518ed25", "tree": "6423afa35f2cebf24888c2a4b089399b05a9c895", "parents": [ "6d831139569dbee69acc631361db917e2c47feeb" ], "author": { "name": "Dinesh G Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Sep 30 14:11:17 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:47 2014 +0000" }, "message": "OSPFd: Update timestamps when we MaxAge LSAs.\n\nWhen an LSA is flushed we need to update the timestamps for them. This\nallows for the node to give the neighbor sufficient time to send back\nan acknowledgement before retransmission kicks in.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt@cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nReviewed-by: James Li \u003cjli@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "6d831139569dbee69acc631361db917e2c47feeb", "tree": "ba38e9354ffcc98245b03a5f50ef0e3cedb48d47", "parents": [ "1c06334f51c00471b0731227384ef42dc463db54" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Thu Oct 09 16:05:15 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:47 2014 +0000" }, "message": "ospfd: Tweak previous iface RR write patch to avoid free/malloc \u0026 redundant log\n\n* linklist.{c,h}: (listnode_move_to_tail) new unction to move a\n listnode to tail of list.\n* ospf_packet.c: (ospf_write) remove debug that seemed to be mostly covered\n by existing debug.\n Use listnode_move_to_tail to just move the list node to the end of the\n tail, rather than freeing the one to hand and allocing a new one.\n" }, { "commit": "1c06334f51c00471b0731227384ef42dc463db54", "tree": "3a33a5515485c44fec45060c3c0a5e4b4d5f826d", "parents": [ "56a5f7752d9bf7297ea022544112909cf2ccba97" ], "author": { "name": "Dinesh G Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Sep 30 13:04:45 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:42 2014 +0000" }, "message": "Avoid timing out of adjacencies by serving all interfaces in round-robin.\n\nEnsure that all interfaces are served in a round robin fashion during\nwrite. This prevents adjacencies from timing out when you have a lot of LSAs\nto be sent out each adjacency. This is essentially a scalability improvement.\n\nSigned-off-by: Ayan Banerjee \u003cayan@cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt@cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "56a5f7752d9bf7297ea022544112909cf2ccba97", "tree": "557d29293e55e78f9f0cbb0c90a6acd1a111734c", "parents": [ "d1b0991ad8404366811a7ccc86e76f70a1ba399e" ], "author": { "name": "Dinesh G Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Sep 30 12:58:04 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:30 2014 +0000" }, "message": "Added show command to display only the routes in the RIB that does not count ECMPs\n\nSigned-off-by: Ayan Banerjee \u003cayan@cumulusnetworks.com\u003e\nReviewed-by: JR Rivers \u003cjrrivers@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "d1b0991ad8404366811a7ccc86e76f70a1ba399e", "tree": "08365369f345a4bbd1d3a3ff6c4abb32b13a97a1", "parents": [ "b6eef003e1a79471addea0b01853b08aed812cc8" ], "author": { "name": "Dinesh G Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Sep 30 12:54:13 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:23 2014 +0000" }, "message": "Make static IPv6 routes respect non-default routing tables.\n\nSigned-off-by: Nolan Leake \u003cnolan@cumulusnetworks.com\u003e\nReviewed-by: Shrijeet Mukherjee \u003cshm@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "b6eef003e1a79471addea0b01853b08aed812cc8", "tree": "f17d70ed70ae856650e342b62010f31537d8dd75", "parents": [ "50f38b3500a6af6e1b0d1389d65c62d70c41e8c2" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Thu Oct 09 14:19:51 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:16 2014 +0000" }, "message": "ospfd: Some small tweaks to the SPF execution reason patch\n\n* ospf_spf.h: use an enum for the reason, and have it as a new argument to\n ospf_spf_calculate_schedule, no need for additional call, and let compiler\n do the checking.\n* ospf_spf.c: format changes - Quagga coding style places function names\n at the start of a new line, for easy grepping for definition.\n (ospf_spf_calculate_timer) Change the log format of SPF execution time to\n avoid ginormous line, and make logging conditional, as is the norm.\n" }, { "commit": "50f38b3500a6af6e1b0d1389d65c62d70c41e8c2", "tree": "0525b14ce3c53f891cd7f5a00fcf954f4893a99f", "parents": [ "88d37b902bc8127379d3293b9671aa6a11479c23" ], "author": { "name": "Dinesh G Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Sep 30 12:53:28 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 11 17:25:09 2014 +0000" }, "message": "Compute and display SPF execution statistics\n\nDetailed SPF statistics, all around time spent executing various pieces of SPF\nsuch as the SPF algorithm itself, installing routes, pruning unreachable networks\netc.\n\nReason codes for firing up SPF are:\nR - Router LSA, N - Network LSA, S - Summary LSA, ABR - ABR status change,\nASBR - ASBR Status Change, AS - ASBR Summary, M - MaxAge\n\nSigned-off-by: Dinesh G Dutt \u003cddutt@cumulusnetworks.com\u003e\nReviewed-by: JR Rivers \u003cjrrivers@cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nReviewed-by: Ayan Banerjee \u003cayan@cumulusnetworks.com\u003e\nReviewed-by: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\n" }, { "commit": "88d37b902bc8127379d3293b9671aa6a11479c23", "tree": "33ff1c38d47bfb7f940d56c53727aa9db31ddb40", "parents": [ "9511633e08ff15c23608983fdc1bc735d427332e" ], "author": { "name": "Stephen Hemminger", "email": "stephen@networkplumber.org", "time": "Mon Nov 03 01:20:09 2014 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Nov 03 06:51:10 2014 +0100" }, "message": "make some structures constant.\n\nThese pre-initialized arrays are not modified.\n\nSigned-off-by: Stephen Hemminger \u003cstephen@networkplumber.org\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\n" }, { "commit": "9511633e08ff15c23608983fdc1bc735d427332e", "tree": "afdafaae1cfcac87ac0934fdc32928e5aa8dc565", "parents": [ "c68f6d9dbb9f910d3ee82e099655fff7c12ef856" ], "author": { "name": "Balaji", "email": "balajig81@gmail.com", "time": "Thu Oct 23 15:25:25 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 30 07:06:13 2014 +0100" }, "message": "zebra: MBGP routes should not be installed in the kernel\n\nMBGP routes are used only for PIM RPF checks and hence should\nnot be installed in the kernel\u0027s FIB. Ignore route node set to Multicast\nSAFI.\n\nSigned-off-by: Balaji.G \u003cbalajig81@gmail.com\u003e\nAcked-by: Everton Marques \u003ceverton.marques@gmail.com\u003e\n[pushed down rn-\u003etable-\u003einfo assignment below assert]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c68f6d9dbb9f910d3ee82e099655fff7c12ef856", "tree": "b21eac804634d638e25e83beffc2cb45715759da", "parents": [ "59135bde25441cd39cea0389467eb206fc9030c9" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 30 06:42:00 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 30 07:06:01 2014 +0100" }, "message": "tests: fix tests for 055086f (well-known attr check)\n\nFix tests/aspathtest.c by including an ORIGIN attribute in the\ntestcases. After 055086f \"bgpd: well-known attr check only run for\nv4/uni, which could cause a crash,\" we\u0027re now checking for it and tests\nare failing due to that.\n\nNote that test #11 (\"4b AS4_PATH w/o AS_PATH\") is no longer accepted as\nOK since the function now checks for the existence of an AS_PATH attr.\n\nFixes: 055086f (\"bgpd: well-known attr check only run for v4/uni\"...)\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "59135bde25441cd39cea0389467eb206fc9030c9", "tree": "6ddfde8fb46f0c3a92b60c1c3de93b82a93c1356", "parents": [ "93b344f3b14390e3952ea9025ac5996ae9131148" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 30 06:19:15 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 30 06:47:06 2014 +0100" }, "message": "build: fix 9562a77... (mrlg removal)\n\nmrlg.cgi was removed in 9562a77 \"mrlg: Remove obsolete version.\" but the\nfile was still listed in Makefile.am.\n\nFixes: 9562a77 (\"mrlg: Remove obsolete version.\")\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "93b344f3b14390e3952ea9025ac5996ae9131148", "tree": "26f9f14848768bd7bc77fc28c1469b970c41e84a", "parents": [ "773224404cb33b2dbd3d8d8d2572013603995ce4" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Tue Oct 28 14:52:49 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Tue Oct 28 14:55:09 2014 +0100" }, "message": "Revert \"zebra: Set link-detect on by default\"\n\nThis reverts commit 773224404cb33b2dbd3d8d8d2572013603995ce4.\n\nThis patch is nontrivial but wasn\u0027t passed along on the mailing list;\nthis is a revert purely on procedural reasons.\n\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "773224404cb33b2dbd3d8d8d2572013603995ce4", "tree": "43a4c9582fd6b8befbebbc35d3980458ac0309cf", "parents": [ "aed1b556cf2f55680ae09d7ad1a1f22729dea8c5" ], "author": { "name": "Dinesh G Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Sep 30 12:39:24 2014 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Oct 28 11:06:00 2014 +0000" }, "message": "zebra: Set link-detect on by default\n\nSigned-off-by: Roopa Prabhu \u003croopa@cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\n" }, { "commit": "aed1b556cf2f55680ae09d7ad1a1f22729dea8c5", "tree": "26f9f14848768bd7bc77fc28c1469b970c41e84a", "parents": [ "9562a7774b76df050d3e01632c6203796dc72c87" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Tue Oct 21 16:59:01 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Oct 28 10:46:24 2014 +0000" }, "message": "bgpd: Fixes for recent well-known-attr check patch.\n\n* bgp_attr.c: Recent patch to tighten well-known attr checks and apply that\n to all AFIs has some breakage with MP-extensions and GR, which needs to be\n fixed.\n (bgp_attr_check) Graceful Restart EoR can be an empty UPDATE for IPv4/uni.\n MP-Ext allow UPDATE with just MP_UNREACH_NLRI. Check for these and return\n proceed.\n NEXT_HOP becomes optional, if MP_REACH_NLRI is present and there\u0027s no\n v4 NLTI, update NEXT_HOP check accordingly.\n Print the missing attr in string form in the log message.\n (bgp_attr_parse) AS_PATH need not be there, so\n bgp_attr_munge_as4_attrs call needs to be conditional on that.\n" }, { "commit": "9562a7774b76df050d3e01632c6203796dc72c87", "tree": "0451dbb3d26323860d02894fa8b71dd8ac0977b4", "parents": [ "f80ba04074f1211d857d08d6deddc41d029be1c7" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Tue Oct 21 10:59:45 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Oct 28 10:46:24 2014 +0000" }, "message": "mrlg: Remove obsolete version.\n\n* mrlg.cgi: The version we shipped was very much out of date, remove it.\n* mrlg.txt: Add file pointing to the official MRLG site.\n" }, { "commit": "f80ba04074f1211d857d08d6deddc41d029be1c7", "tree": "9ce24dbe25f76eb2dab1083cc93e0ed5cb56d4bd", "parents": [ "6b274d90fa9b0c9f43e3ca9494cd78df1ccad14e" ], "author": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 13:03:14 2014 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 16:59:57 2014 +0100" }, "message": "Handy guidelines to contribute\n\nExplain how to be a nice contributor in a handy way.\n\nSigned-off-by: Vincent JARDIN \u003cvincent.jardin@6wind.com\u003e\nAcked-by: Paul Jakma \u003cpaul@jakma.org\u003e\n" }, { "commit": "6b274d90fa9b0c9f43e3ca9494cd78df1ccad14e", "tree": "7a2ca655111570d40615bb2fedaef56d7859e655", "parents": [ "3790eb0d3f0bbb24b9c6be97f547cec144ee05d1" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Tue Mar 09 06:42:30 2010 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 16:24:08 2014 +0100" }, "message": "ospfd: Don\u0027t leave stale RouterLSA\u0027s when changing areaID\n\nSigned-off-by: Joakim Tjernlund \u003cJoakim.Tjernlund@transmode.se\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\n" }, { "commit": "3790eb0d3f0bbb24b9c6be97f547cec144ee05d1", "tree": "08ccf694b43a92568a1278aa28374dcd09d4b0fe", "parents": [ "bdd8cd70a042473477f9144c9cedb8dde11ba2c1" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Jan 13 00:32:43 2010 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 16:08:22 2014 +0100" }, "message": "stream: remove unused stream_read_unblock\n\nThe one place this was being used in BGP is now gone,\ncan remove deprecated interface.\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\n" }, { "commit": "bdd8cd70a042473477f9144c9cedb8dde11ba2c1", "tree": "edcdbc4b096f4c5b1dc1d72d32d2db81c9fa3c7c", "parents": [ "ea2a598411cc7bd20456849e56bbc9e93c9916e7" ], "author": { "name": "Yasuhiro Ohara", "email": "yasu@jaist.ac.jp", "time": "Thu Dec 17 05:41:17 2009 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 16:01:08 2014 +0100" }, "message": "Bug in ospf6_lsa_compare()\n\nThis fix is probably correct on 32bit systems,\nbut i think it will not work on 64bit systems.\nsizeof(signed long) would be 8 and therefore the\ncast from u_int32_t will map all the values to\nnon-negative part of long int.\n\nYou would like to use int (like in ospfd) and\nchange the type of seqnuma, seqnumb to that.\n\nThe type int32_t would be even more proper, but\nsizeof(int) is 4 on relevant platforms.\n\nSigned-off: Ondrej Zajicek \u003csantiago@crfreenet.org\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\nAcked-by: Yasuhiro Ohara \u003cyasu@jaist.ac.jp\u003e\n" }, { "commit": "ea2a598411cc7bd20456849e56bbc9e93c9916e7", "tree": "e1825968b9d0f7208b93944980331179456b7625", "parents": [ "969d3550a8cbb07f8b4d5ebe8dde5064f8260140" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Thu Nov 26 12:23:07 2009 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 15:57:59 2014 +0100" }, "message": "ospfd: invalid MD5 auth_key?\n\nThis looks fishy in ospf_make_md5_digest()\nif (list_isempty (OSPF_IF_PARAM (oi, auth_crypt)))\n auth_key \u003d (const u_int8_t *) \"\";\n...\nMD5Update(\u0026ctx, auth_key, OSPF_AUTH_MD5_SIZE);\nauth_key points to a \"\" string of len 1 which is a lot\nsmaller that OSPF_AUTH_MD5_SIZE. Is this intentional to\nget some random data or just a plain bug?\n\nAnyone using MD5 should have a closer look and decide\nwhat to do.\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\n" }, { "commit": "969d3550a8cbb07f8b4d5ebe8dde5064f8260140", "tree": "f43d5c74ed758af6b1181ce03163ebf2504a1271", "parents": [ "384d7ad98c109e92eaf65bf10a3256e5657639c3" ], "author": { "name": "Lu Feng", "email": "lu.feng@6wind.com", "time": "Tue Oct 21 06:24:07 2014 +0000" }, "committer": { "name": "Vincent JARDIN", "email": "vincent.jardin@6wind.com", "time": "Mon Oct 27 14:37:55 2014 +0100" }, "message": "zebra: route_unlock_node is missing in \"show ip[v6] route \u003cprefix\u003e\" commands\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nAcked-by: Vincent Jardin \u003cvincent.jardin@6wind.com\u003e\n" }, { "commit": "384d7ad98c109e92eaf65bf10a3256e5657639c3", "tree": "b279059f854eed239d7b8834270adecd49d9108d", "parents": [ "7a6eec54eaffa82f4f03363314bb81c400eb2a66" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Thu Oct 09 16:09:10 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 17 14:10:21 2014 +0100" }, "message": "docs: defines.texi include seems to want to be after setfilename\n\n* quagga.texi: I\u0027m getting warnings about stuff in defines.texi not being\n defined when building quagga.info. Seems to be fixed by moving the include\n of defines.texi to the end of the header. Also, the Texinfo docs suggest\n setfilename must go first.\n" }, { "commit": "7a6eec54eaffa82f4f03363314bb81c400eb2a66", "tree": "b2dcf76eb7a2c769bdd0f173c31bbe207a609fd4", "parents": [ "f6444e4f6e1664f49f7552f894c8c94e45dd3c35" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Thu Oct 09 10:51:41 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 17 14:09:02 2014 +0100" }, "message": "zebra: Build the test client, can be useful, and add IPv6 to testrib.conf\n" }, { "commit": "f6444e4f6e1664f49f7552f894c8c94e45dd3c35", "tree": "fd7c0c86bf0ab3525056a37d3fce9d70e2a0d6f9", "parents": [ "055086f70febc30fdfd94bb4406e9075d6934cd8" ], "author": { "name": "Olivier Cochard-Labbé", "email": "olivier@cochard.me", "time": "Thu Oct 09 10:28:21 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 17 14:09:02 2014 +0100" }, "message": "FreeBSD has changed its SOCK_RAW for being truly raw.\n" }, { "commit": "055086f70febc30fdfd94bb4406e9075d6934cd8", "tree": "2f511a8b1aca7b3e67e895321bbfef7d02f074b1", "parents": [ "b166ea2dda9f04a8b75e0bf5adb7064580695f22" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Tue Sep 23 15:23:01 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 17 14:09:02 2014 +0100" }, "message": "bgpd: well-known attr check only run for v4/uni, which could cause a crash.\n\n* ANVL testing by Martin Winter threw up a crash in bgpd in aspath_dup\n called from bgp_packet_attribute, if attr-\u003easpath was NULL, on an IPv6\n UPDATE.\n\n This root cause is that the checks for well-known, mandatory attributes\n were being applied only if an UPDATE contained the IPv4 NLRI and the\n peer was configured for v4/unicast (i.e. not deconfigured). This is\n something inherited from GNU Zebra, and never noticed before.\n\n* bgp_attr.c: (bgp_attr_parse) Move the well-known mandatory attribute\n check to here, so that it can be run immediately after all attributes\n are parsed, and before any further processing of attributes that might\n assume the existence of WK/M attributes (e.g. AS4-Path).\n (bgp_attr_munge_as4_attrs) Missing AS_PATH shouldn\u0027t happen here anymore,\n but retain a check anyway for robustness - it\u0027s definitely a hard error\n though.\n* bgp_attr.h: (bgp_attr_check) No longer needs to be exported, make static.\n* bgp_packet.c: (bgp_update_receive) Responsibility for well-known check\n now in bgp_attr_parse.\n" }, { "commit": "b166ea2dda9f04a8b75e0bf5adb7064580695f22", "tree": "40b9468412819c0eab55798f816f6a8e1c58a4c0", "parents": [ "18f420e9f99e7f6557cf5877673cd6e71ac32192" ], "author": { "name": "Joakim Tjernlund", "email": "joakim.tjernlund@transmode.se", "time": "Thu Jun 25 16:40:06 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 17 14:09:02 2014 +0100" }, "message": "[lib] Add support for backtrace on more platforms\n\n* lib/sigevent.c: (program_counter) extend to support more platforms. Joint\n effort with Paul Jakma.\n" }, { "commit": "18f420e9f99e7f6557cf5877673cd6e71ac32192", "tree": "1e43af3642283cb3660332624d2c58e558fe48ad", "parents": [ "16f1606382b77ac6b951ea0de15384fcbc1df73f" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 16:55:46 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 17 14:09:01 2014 +0100" }, "message": "lib/plist: Add some required parentheses, according to clang-analyzer\n" }, { "commit": "16f1606382b77ac6b951ea0de15384fcbc1df73f", "tree": "59382d4a4893c7cc69b55f1e9e9a27c59832765c", "parents": [ "7bef33cbf5027189bd55e4890a07a6bef8277f93" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 15:35:54 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:33:21 2014 +0100" }, "message": "ripng_nexthop: remove unused store to variable\n" }, { "commit": "7bef33cbf5027189bd55e4890a07a6bef8277f93", "tree": "744283cc2493348e042a278062743d3ecf00abf0", "parents": [ "b2dd59ee0e74926278e128846624f5c93288223b" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 15:35:15 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:33:21 2014 +0100" }, "message": "ospf6_lsdb: trivial, make it clear that showfunc is set before deref.\n" }, { "commit": "b2dd59ee0e74926278e128846624f5c93288223b", "tree": "d54b3798315a2b0b46f8730747584eff75b5e370", "parents": [ "7aa9dcef80b2ce50ecaa77653d87c8b84e009c49" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 15:34:48 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:33:20 2014 +0100" }, "message": "bgpd.c: Remove unused store to variable\n" }, { "commit": "7aa9dcef80b2ce50ecaa77653d87c8b84e009c49", "tree": "bd4a8d881336a1551146725d7ae06b3e68553e4d", "parents": [ "010ebbbca6396f272cc2d50d147dd922dda68213" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 14:42:23 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:32:34 2014 +0100" }, "message": "Fix most compiler warnings in default GCC build.\n\nFix lots of warnings. Some const and type-pun breaks strict-aliasing\nwarnings left but much reduced.\n\n* bgp_advertise.h: (struct bgp_advertise_fifo) is functionally identical to\n (struct fifo), so just use that. Makes it clearer the beginning of\n (struct bgp_advertise) is compatible with with (struct fifo), which seems\n to be enough for gcc.\n Add a BGP_ADV_FIFO_HEAD macro to contain the right cast to try shut up\n type-punning breaks strict aliasing warnings.\n* bgp_packet.c: Use BGP_ADV_FIFO_HEAD.\n (bgp_route_refresh_receive) fix an interesting logic error in\n (!ok || (ret !\u003d BLAH)) where ret is only well-defined if ok.\n* bgp_vty.c: Peer commands should use bgp_vty_return to set their return.\n* jhash.{c,h}: Can take const on * args without adding issues \u0026 fix warnings.\n* libospf.h: LSA sequence numbers use the unsigned range of values, and\n constants need to be set to unsigned, or it causes warnings in ospf6d.\n* md5.h: signedness of caddr_t is implementation specific, change to an\n explicit (uint_8 *), fix sign/unsigned comparison warnings.\n* vty.c: (vty_log_fixed) const on level is well-intentioned, but not going\n to fly given iov_base.\n* workqueue.c: ALL_LIST_ELEMENTS_RO tests for null pointer, which is always\n true for address of static variable. Correct but pointless warning in\n this case, but use a 2nd pointer to shut it up.\n* ospf6_route.h: Add a comment about the use of (struct prefix) to stuff 2\n different 32 bit IDs into in (struct ospf6_route), and the resulting\n type-pun strict-alias breakage warnings this causes. Need to use 2\n different fields to fix that warning?\n\ngeneral:\n\n* remove unused variables, other than a few cases where they serve a\n sufficiently useful documentary purpose (e.g. for code that needs\n fixing), or they\u0027re required dummies. In those cases, try mark them as\n unused.\n* Remove dead code that can\u0027t be reached.\n* Quite a few \u0027no ...\u0027 forms of vty commands take arguments, but do not\n check the argument matches the command being negated. E.g., should\n \u0027distance X \u003cprefix\u003e\u0027 succeed if previously \u0027distance Y \u003cprefix\u003e\u0027 was set?\n Or should it be required that the distance match the previously configured\n distance for the prefix?\n Ultimately, probably better to be strict about this. However, changing\n from slack to strict might expose problems in command aliases and tools.\n* Fix uninitialised use of variables.\n* Fix sign/unsigned comparison warnings by making signedness of types consistent.\n* Mark functions as static where their use is restricted to the same compilation\n unit.\n* Add required headers\n* Move constants defined in headers into code.\n* remove dead, unused functions that have no debug purpose.\n" }, { "commit": "010ebbbca6396f272cc2d50d147dd922dda68213", "tree": "99e92b1795d61adfa554e1cc00e998697962fcc9", "parents": [ "ea55500409651b0f8fd2c8a02fdbf245acc96dd8" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 16 11:53:49 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Sep 19 22:14:55 2014 +0100" }, "message": "Add missing GPL headers, and copyright claims that certainly apply.\n\n* Fix (a subset of)? files with non-trivial code that are missing GPL headers.\n\n* A few copyright claims added which I am certain apply, but which I had\n missed out on the original commits.\n\nNB: Copyright claims are not exclusive and the addition of any copyright\nclaim should not be read as implying a lack of any further claims, or\ndenying the validity of any other claims. All those with claims of\ncopyright over any portion of Quagga are welcome to submit them, ideally as\npatches to update copyright strings in files.\n" }, { "commit": "ea55500409651b0f8fd2c8a02fdbf245acc96dd8", "tree": "74f195200f595ae96363e007103e77654ace3f4d", "parents": [ "d4a8607d12e1d3f655055647f1633ec154685545" ], "author": { "name": "Steve Hill", "email": "quagga@cheesy.sackheads.org", "time": "Tue Jul 28 16:36:14 2009 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Sep 19 22:14:54 2014 +0100" }, "message": "lib: Improve error reporting from broken config files\n\n* command.h: (config_from_file) Add variable to interface for line\n number reporting.\n * command.c: (config_from_file) Set \u0026 increment \u0027line_num\u0027 while parsing.\n * vty.c: (vty_read_file) Report parse errors in the correct order to\n stderr, with added line numbers.\n" }, { "commit": "d4a8607d12e1d3f655055647f1633ec154685545", "tree": "17e6c34b6d00a823715dbd89c3e120f2bba2c505", "parents": [ "615f9f18fc025757a255f936748fc1e86e922783" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 19 12:02:42 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Sep 19 22:14:54 2014 +0100" }, "message": "HACKING: remove an unneeded escape\n" }, { "commit": "615f9f18fc025757a255f936748fc1e86e922783", "tree": "b9cd79ef71984932f4eb5f73437f9593ad2a2604", "parents": [ "3493b7731b750cbc62f00be94b624a08ccccf0b2" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Nov 18 23:52:02 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Sep 15 18:38:56 2014 +0200" }, "message": "lib: include thread information in backtraces\n\nnow that we know what thread we\u0027re currently executing, let\u0027s add that\ninformation to SEGV / assert backtraces.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "3493b7731b750cbc62f00be94b624a08ccccf0b2", "tree": "4ea2444ddc197001b26f0b9b6e7cc2adb2bb29d2", "parents": [ "621e2aaf33d8ab73bf44b0eea3f3900135d34996" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Nov 18 23:04:27 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Sep 15 18:38:48 2014 +0200" }, "message": "lib: unstupidify thread debug information\n\nthe library\u0027s thread scheduling functions keep track of the thread\nfunction\u0027s name, so far so good. However, copying the compiler-provided\nconstant into a buffer inside the thread structure is plain useless.\nAlso, strip_funcname() was trying to support something that never\nhappens.\n\nInstead, let\u0027s use some bytes here to track where threads are scheduled\nfrom. Another commit will print that information on crashes.\n\nRipping out useless stuff: -64 bytes in the thread structure\nRe-add as const ptr: +8 bytes\nExtra debug info: +12 bytes\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "621e2aaf33d8ab73bf44b0eea3f3900135d34996", "tree": "a97a9b0c33a6591ade083afbe7ed8eb46100a651", "parents": [ "0b74a0a5db7bcf65bf68c44b547b02b1310b5cdb" ], "author": { "name": "Lu Feng", "email": "lu.feng@6wind.com", "time": "Fri Jul 11 07:52:15 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Sep 15 18:37:14 2014 +0200" }, "message": "zebra: fix rtnh_len in the rt_netlink messages for multipath case\n\nIn _netlink_route_build_multipath():\n- Each time when appending a IPv4 gateway in the message, rtnh_len\n is increased by sizeof (struct rtattr) + 4, where we should use\n \"bytelen\" instead of the hard coding \"4\".\n- As what done for IPv4, we should increase rtnh_len accordingly\n along with adding a IPv6 gateway, or else the IPv6 gateways will\n be lost.\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "0b74a0a5db7bcf65bf68c44b547b02b1310b5cdb", "tree": "d767a50f61d6dddaf145e8273e859fb29d74687f", "parents": [ "b397cf4f0fc484c5ebfc8a680090055c8e6cbe32" ], "author": { "name": "Lu Feng", "email": "lu.feng@6wind.com", "time": "Fri Jul 18 06:13:19 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Sep 15 18:37:08 2014 +0200" }, "message": "ripd: allow to enable/disable the ECMP feature\n\nIntroduce a new command \"[no] allow-ecmp\" to enable/disable the\nECMP feature in RIP. By default, ECMP is not allowed.\n\nOnce ECMP is disabled, only one route entry can exist in the list.\n\n* rip_zebra.c: adjust a debugging information, which shows the number\n of nexthops according to whether ECMP is enabled.\n* ripd.c: rip_ecmp_add() will reject the new route if ECMP is not\n allowed and some entry already exists.\n A new configurable command \"allow-ecmp\" is added to control\n whether ECMP is allowed.\n When ECMP is disabled, rip_ecmp_disable() is called to\n remove the multiple nexthops.\n* ripd.h: Add a new member \"ecmp\" to \"struct rip\", indicating whether\n ECMP is allowed or not.\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "b397cf4f0fc484c5ebfc8a680090055c8e6cbe32", "tree": "b1fe14811932e92ac87f7ddcad8660061b15cd51", "parents": [ "1520e4748129c4eb97ac3090bcc97149a1900611" ], "author": { "name": "Lu Feng", "email": "lu.feng@6wind.com", "time": "Fri Jul 18 06:13:18 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Sep 15 18:36:54 2014 +0200" }, "message": "ripd: add ECMP support\n\n* Each node in the routing table is changed into a list, holding\n the multiple equal-cost paths.\n\n* If one of the multiple entries gets less-preferred (greater\n metric or greater distance), it will be directly deleted instead\n of starting a garbage-collection timer for it.\n The garbage-collection timer is started only when the last entry\n in the list gets INFINITY.\n\n* Some new functions are used to maintain the ECMP list. And hence\n rip_rte_process(), rip_redistribute_add() and rip_timeout() are\n significantly simplified.\n\n* rip_zebra_ipv4_add() and rip_zebra_ipv4_delete() now can share\n the common code. The common part is moved to rip_zebra_ipv4_send().\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "1520e4748129c4eb97ac3090bcc97149a1900611", "tree": "f4501a77bcb9e3ecabfd9dd5f80ee3e71cb35119", "parents": [ "342a31bfda21616209366679ac522471e5772a2f", "90444ca35e3037ed43ec695428f0ef6d82f9a320" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Aug 19 18:15:40 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Aug 19 18:15:40 2014 +0200" }, "message": "*: merge branch stable/0.99.23\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "90444ca35e3037ed43ec695428f0ef6d82f9a320", "tree": "441582b4f1ee1118f6b9b696fed65a2c38064503", "parents": [ "ad2f92b6b07883f6a2a26499eab1776933185960" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jul 01 16:14:05 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 18:16:28 2014 +0200" }, "message": "lib: unset ZEBRA_IFA_PEER if no dst addr present (BZ#801)\n\nOn OpenBSD, carp interfaces claim to be PtP interfaces with a 0.0.0.0/0\npeer address. We process those in zebra and try to send them to\nclients, at which point they get encoded as all-0. The client code,\nhowever, decodes that to a NULL pointer instead of 0.0.0.0. This later\nturns into a SEGV when CONNECTED_PREFIX sees that ZEBRA_IFA_PEER is set\nand tries to access the peer prefix.\n\nThis is a band-aid fix for stable/0.99.23, a long-term solution needs\nsome conceptual improvements on the entire thing.\n\n(The usefulness of a PtP-to-0.0.0.0/0 is a separate question; at this\npoint dropping the peer prefix seems the least intrusive solution.)\n\nReported-by: Laurent Lavaud \u003claurent.lavaud@ladtech.fr\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "ad2f92b6b07883f6a2a26499eab1776933185960", "tree": "8bc8790cf92b37ff2cd02e5000a3332e053feae5", "parents": [ "4c005e3f65a1f5b4592b1ebbac392cbb1a710998" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 18:05:25 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 18:16:28 2014 +0200" }, "message": "isisd: type mix-up in 28a8cfc \"don\u0027t require IPv4\"\n\nWhoops, these are in6_addrs, not prefix_ipv6... funnily enough, it does the\nright thing either way, if it compiles, which it only does on Linux because\nIN6_IS_ADDR_LINKLOCAL contains a cast to the right type. On BSD there is no\nsuch cast, hence it explodes on trying to compile, trying to access struct\nmembers of in6_addrs while operating on prefix_ipv6...\n\nFixes: 28a8cfc (\"isisd: don\u0027t require IPv4 for adjacency\")\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "4c005e3f65a1f5b4592b1ebbac392cbb1a710998", "tree": "ec2feadf6fe20841a179d31714a053863919ae1e", "parents": [ "3ef0b877f08344aa52367794aa4ec32b12becd6d" ], "author": { "name": "John Glotzer", "email": "glotzer@amazon.com", "time": "Mon Aug 04 19:39:23 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 01:52:26 2014 +0200" }, "message": "bgpd: memmove needed in community_del_val\n\nIn bgpd/bgp_community_del_val memcpy is used for potentially overlapping\nregions which is *not* safe. It may \"work\" in some cases but is not\nguaranteed to work in all cases. The case that I saw fail was on an\nx86_64 architecture with the number of bytes being moved/copied equal to\n8.\n\nThe way the code is written the uint32_t pointers will always differ by\n1, which is equivalent to a memcpy/memmove of regions that are 4 bytes\naway from one another. So the code failed while copying an 8 byte region\nto an address that is 4 bytes lower i.e. overlapping regions.\n\nInterestingly, the same architecture had no problems with a 12 byte\ncopy.\n\nWhen the code failed the communities were [200,300,400] and a call was\nmade to delete the 200 community. The result of this was an array that\nlooked like [400,400] which was uniquified to [400]. Of course the\nexpected result should have been [300, 400].\n\nOne additional point - in our production environment memmove would not\n*link* without including \u003cstring.h\u003e but in an isolated quagga git repo\nthis #include does not seem to be required and I see memmove is used in\nvtysh.c without this #include either.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "3ef0b877f08344aa52367794aa4ec32b12becd6d", "tree": "3a8f27bf01700918ecb4c2fec4fa0ecfaff65744", "parents": [ "c299ed717eea4dbf7ca3581bcba05ff09f79276c" ], "author": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Tue Jul 29 09:41:56 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 01:50:26 2014 +0200" }, "message": "build: do not assume glibc on linux\n\nThe whole IPv6 stack detection could need refactoring. But this\nfixes the linux check to not assume glibc. Fixes build against\nmusl c-library.\n\nSigned-off-by: Timo Teräs \u003ctimo.teras@iki.fi\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c299ed717eea4dbf7ca3581bcba05ff09f79276c", "tree": "1c5bcdf75892ef9958edc8f38dd7f01922f0e57d", "parents": [ "16ffb26fbbf8b3d1fee7a14eb401ecb02eed5058" ], "author": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Tue Jul 29 09:41:55 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 01:50:23 2014 +0200" }, "message": "zebra: fix struct msghdr initializers\n\nstruct msghdr field orders are not strictly specified in POSIX.\nImprove portability by using designated initializer. This fixes\nbuild against musl c-library where struct msghdr is POSIX\ncompliant (Linux kernel and glibc definitions are non-conforming).\n\nAs the result is also more readable, struct iovec initilizers\nwere also converted.\n\nSigned-off-by: Timo Teräs \u003ctimo.teras@iki.fi\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "16ffb26fbbf8b3d1fee7a14eb401ecb02eed5058", "tree": "f1abb4a88c2677f1e405a855be200056c5c2bc4e", "parents": [ "28a8cfcbc3a5cc74bb3b87981b878f8b4edc2dd6" ], "author": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Tue Jul 29 09:41:54 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 01:50:19 2014 +0200" }, "message": "*: fix detection and usage of sys/cdefs.h\n\nThis header is non-standard (though present on many systems) and\nthere is no standard for what it should or should not define.\n\nRemove it where it is not really needed. But add also a configure\ncheck, so it can be used if available but otherwise fallback to\ndefining the needed macroes.\n\nSigned-off-by: Timo Teräs \u003ctimo.teras@iki.fi\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "28a8cfcbc3a5cc74bb3b87981b878f8b4edc2dd6", "tree": "55316289799b819a7170f908d4cf8c2f24350c99", "parents": [ "8b16ed74fa61523c3348d2584b66a56a8ad4e350" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 13:48:18 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 01:49:32 2014 +0200" }, "message": "isisd: don\u0027t require IPv4 for adjacency\n\nThis was precluding isisd from IPv6-only operation; no adjacency would\ncome up unless there was IPv4 in parallel.\n\nReported-by: Martin Winter \u003cmwinter@netdef.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8b16ed74fa61523c3348d2584b66a56a8ad4e350", "tree": "fe7232f0df942ca8f8bbc386f5089c13d1ec452a", "parents": [ "f57000c0dbdd0e30e71b6651022392f284201e19" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jul 06 22:33:48 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Aug 18 01:49:17 2014 +0200" }, "message": "tests/bgpd: don\u0027t hardcode error number (fix f57000c)\n\nf57000c (\"bgpd: don\u0027t send NOTIFY twice for malformed attrs\") introduces\nBGP_ATTR_PARSE_ERROR_NOTIFYPLS as additional error code that implies the\ncaller should sent a NOTIFY and convert it to BGP_ATTR_PARSE_ERROR.\nSadly, the latter was hardcoded in bgp_mp_attr_test.c, which now didn\u0027t\nconsider the new value to be an error.\n\nMake the testcase treat all nonzero values as error without discern.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "342a31bfda21616209366679ac522471e5772a2f", "tree": "359be93388f4efe5283b291f322c78c9e2389f0f", "parents": [ "052573ee2319b21657a79e1b76a5c801701fa38c" ], "author": { "name": "Lu Feng", "email": "lu.feng@6wind.com", "time": "Wed Jun 25 07:43:15 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jul 02 19:30:20 2014 +0200" }, "message": "ripd: use only one constant for derivation\n\nRIP_MAX_RTE is defined in ripd.h as 25 but is in fact the\nresult of a formula. More over it is not used in the code:\nthe code itself includes the fomula. This makes it un-clear\nfor maintenance.\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "052573ee2319b21657a79e1b76a5c801701fa38c", "tree": "32a731414c3b0a70516461befd9c22baf77b0587", "parents": [ "0ff692ed59696c534e6bfd0f9d6e83706fbbec4a", "f57000c0dbdd0e30e71b6651022392f284201e19" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:52:52 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:52:52 2014 +0200" }, "message": "*: merge branch stable/0.99.23\n\nbgp extcommunity fixes from stable branch\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f57000c0dbdd0e30e71b6651022392f284201e19", "tree": "9a00b90323fa93de9ecb10c65f9f82824fda99b8", "parents": [ "bb02b82354a80f74706efc5e4c914b3f89fb033e" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 01:01:10 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:47:21 2014 +0200" }, "message": "bgpd: don\u0027t send NOTIFY twice for malformed attrs\n\nMost of the attribute parsing functions were already sending a notify,\nlet\u0027s clean up the code to make it happen only once.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "bb02b82354a80f74706efc5e4c914b3f89fb033e", "tree": "d7662f309686113478121b54859e048f44ee6ac2", "parents": [ "f80f838b2f54738937ef1281b237710132195c44" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 01:01:00 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:47:21 2014 +0200" }, "message": "bgpd: fix IP endianness in debug message\n\ninet_ntop expects network byte order.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f80f838b2f54738937ef1281b237710132195c44", "tree": "e5dbb9062560ac02ad2e5baf62c8d820560c75d2", "parents": [ "27bf90a14670283a899b96c56dd23f8413e0973e" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 01:00:51 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:47:21 2014 +0200" }, "message": "bgpd: fix memory leak on malformed attribute\n\nWhen bgp_attr_parse returns BGP_ATTR_PARSE_ERROR, it may already have\nparsed and allocated some attributes before hitting that error. Free\nthe attr\u0027s data before returning.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "27bf90a14670283a899b96c56dd23f8413e0973e", "tree": "e52498c5d70f6efef4d9a827b6974a2f597b2e30", "parents": [ "73d78ea0153fd36a300be5fec2ef0fca34a67477" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 00:59:01 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:47:21 2014 +0200" }, "message": "bgpd: fix double free after extcommunity set (BZ#799)\n\nThe route-map extcommunity set code was incorrectly assuming that it\nowns the intern\u0027d struct ecommunity reference. In reality, the intern\u0027d\nreference belongs to bgp_update_receive() and we\u0027re not supposed to\ntouch it in the route-map code.\n\nInstead, like all the other set commands, we use a on-heap but\nnon-intern\u0027d ecommunity to set the new value. This is then either\nintern\u0027d in bgp_update_main/_rsclient() through bgp_attr_intern(), or\nfree\u0027d through bgp_attr_flush().\n\nThis fixes Bugzilla #799, which is that bgpd otherwise crashes with a\ndouble free. The ecommunity got unintern\u0027d first in the route-map set\ncommand, then in bgp_update_receive().\n\nDebugged-by: Milan Kocian \u003cmilon@wq.cz\u003e\nReported-by: Florian S \u003cflorian@herrenlohe.de\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "73d78ea0153fd36a300be5fec2ef0fca34a67477", "tree": "a56383725b587c60c584db85cb1757588d3ea2ed", "parents": [ "c460e5720c1101a6da53e5b753b736ac2c7981af" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 00:58:47 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:47:21 2014 +0200" }, "message": "bgpd: remove duplicate route-map extcommunity code\n\nroute_set_ecommunity_rt and _soo share almost all of their code.\nLet\u0027s remove one of the redundant copies.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" } ], "next": "c460e5720c1101a6da53e5b753b736ac2c7981af" }