)]}' { "log": [ { "commit": "eed3c48d3a7d2dae2cae2f2f250deffb843754a6", "tree": "07b2252438225065024d4a534eddf0e86c9b87a4", "parents": [ "ef008d2f8dc8f7160d8a3d24a15f2fad79ef3242" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 08:51:53 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:17:31 2015 +0200" }, "message": "*: use void * for printing pointers\n\nOn higher warning levels, compilers expect %p printf arguments to be\nvoid *. Since format string / argument warnings can be useful\notherwise, let\u0027s get rid of this noise by sprinkling casts to void *\nover printf calls.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6b0655a25194c7c0331154edaa6124cf783e5e5e", "tree": "c0c7d479f2684531249668210da27a60322ba395", "parents": [ "fdb913aedb5a9807ad60715e8badb4f25d57acea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:53:35 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:58:02 2014 +0200" }, "message": "*: nuke ^L (page feed)\n\nQuagga sources have inherited a slew of Page Feed (^L, \\xC) characters\nfrom ancient history. Among other things, these break patchwork\u0027s\nXML-RPC API because \\xC is not a valid character in XML documents.\n\nNuke them from high orbit.\n\nPatches can be adapted simply by:\n\tsed -e \u0027s%^L%%\u0027 -i filename.patch\n(you can type page feeds in some environments with Ctrl-V Ctrl-L)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "91e6a0e5ca973c7183f638987b67aa370e9b484c", "tree": "734c8c74baaaa6d3c303928b4f6d1d35d3394115", "parents": [ "4ba4fc857685bfe31c7127826652012a750367c5" ], "author": { "name": "Dinesh Dutt", "email": "ddutt@cumulusnetworks.com", "time": "Tue Dec 04 10:46:37 2012 -0800" }, "committer": { "name": "Scott Feldman", "email": "sfeldma@cumulusnetworks.com", "time": "Mon Jan 07 09:59:43 2013 -0800" }, "message": "ospf: Convert MAX_AGE LSA list to tree\n\nStore the MaxAge LSA list in a tree instead of a linked list for efficient access.\nWalking the list can be quite inefficient in some large systems and under certain tests.\n\nospfd maintains the list of LSA\u0027s that have been MaxAge\u0027d out in a separate\nlinked list for removal by a remover/walker thread. When a new LSA is to be\ninstalled, the old LSA is ejected and when it is ejected, the MaxAge LSA list\nis traversed to ensure that the old LSA is also removed from this list if it\nexists on this list.\n\nWhen a large number (\u003e 5K) MaxAge LSAs are bombarding the system, walking this\nlist takes a significant time causing timers to fire and actions to be taken\nsuch as expiring neighbors due to expiry of DeadInterval (especially when timer\nis really low, \u003c\u003d 12s), creating a spiral of instability.\n\nBy making this MaxAge LSA list be a tree, this problem is mitigated.\n\nSigned-off-by: Dinesh Dutt \u003cddutt@cumulusnetworks.com\u003e\nReviewed-by: Ayan Banerjee \u003cayan@cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nReviewed-by: Shrijeet Mukherjee \u003cshm@cumulusnetworks.com\u003e\nSigned-off-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\n" }, { "commit": "e8f2226195e86f90f2409549ad8a8e5c8d64d23b", "tree": "e06409c762058421671fa7eacedeeccd364d871d", "parents": [ "6634974d68b8cc78cdde1104636fe97d7e310845" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Apr 13 22:43:34 2010 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Dec 08 17:11:18 2010 +0000" }, "message": "ospfd: Fix various route_unlock discrepencies\n\n* ospf_ase.c: (ospf_ase_calculate_route) Fix compiler warning about eval\n needing brackets.\n (various) add defensive asserts.\n* ospf_lsdb.c: (ospf_lsdb_add) add missing node unlock if same lsa already\n was indexed.\n (ospf_lsdb_delete) check it\u0027s actually the same as specified lsa before\n deleting\n (ospf_lsdb_lookup_by_id_next) fix another corner case - no result \u003d\u003e\n don\u0027t go on.\n" }, { "commit": "efbbcaf1aea686d118019514dcde92b13c92b0fc", "tree": "97965a22204c265ac061f40ea9e461e88c3cd2ea", "parents": [ "0917f7e7c5920b70295c44bd8aad537bc3ee8581" ], "author": { "name": "Paul Jakma", "email": "paul@jakma.org", "time": "Thu Jan 14 16:19:40 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jan 14 16:19:40 2010 +0300" }, "message": "ospfd: remove unneeded memset from a very hot function\n\n* ospf_lsdb.c: (lsdb_prefix_set) memset is unneeded, as all fields are\ninitialised explicitly, and this function can be in the top-3 of a\nprofile when there are a lot of LSAs.\n" }, { "commit": "3fc1eca92a7022f1c5b567505a7d86aab0d3cbd4", "tree": "38e59f306aab80e67321b600a17c6a9bf7d71931", "parents": [ "2a71e9ce89c6f76c099dea67dddbe8da454d9de7" ], "author": { "name": "Tomasz Pala", "email": "gotar@pld-linux.org", "time": "Wed Jun 24 21:48:22 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jun 24 21:49:53 2009 +0100" }, "message": "[cleanup] Add log.h includes\n" }, { "commit": "ba122e779ddd1ef09e61ac2003ca20cf7ee8c611", "tree": "ecc8363ac3b757c987827853c9125fdbfa15d64a", "parents": [ "66c454f2a57a1a0053ea308edfc8c8024b3b7a48" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 27 06:24:34 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 27 06:24:34 2006 +0000" }, "message": "[ospfd] trivial: consolidate LSDB delete code into single function\n\n2006-08-04 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate\n\t exact same functionality replicated in other functions.\n\t (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.\n\t (ospf_lsdb_delete) ditto.\n\t (ospf_lsdb_delete_all) ditto.\n" }, { "commit": "1fe6ed38cd0136c514aabae01389653beab27fb9", "tree": "21f10bc3f9c5afffe9f28e5dbf4e6198cfafba5b", "parents": [ "3fed4160cd23f1767d8980e8cba10bc3933947d5" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 26 09:37:26 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 26 09:37:26 2006 +0000" }, "message": "[ospfd] Allow ospf_lsa_unlock to NULL out callers\u0027 LSA pointers upon free\n\n2006-07-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer\n\t to the LSA to be \u0027unlocked\u0027, so that, if the LSA is freed, the\n\t callers pointer to the LSA can be NULLed out, allowing any further\n\t use of that pointer to provoke a crash sooner rather than later.\n\t* ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match\n\t previous. Try annotate \u0027locking\u0027 somewhat to show which \u0027locks\u0027\n\t are protecting what LSA reference, if not obvious.\n\t* ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless\n\t goto, replace with return.\n\t* ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,\n\t the dual-loop predated the delete-safe list-loop macro.\n" }, { "commit": "ac904dec03ce6b1bbd1bab1718085a366d485bd8", "tree": "ffc6d51c14446bac13a7d3a945449bf1c2d8561f", "parents": [ "88871b1d1ea8150ddf3d8f66fe77323770ba0f9f" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Jun 15 12:04:57 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Jun 15 12:04:57 2006 +0000" }, "message": "[ospfd] lsdb_delete/discard_from_db should be more robust to bad args\n\n2006-05-31 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,\n\t print warning.\n\t* ospf_lsa.c: (ospf_discard_from_db) ditto.\n\t (ospf_maxage_lsa_remover) Check lsa-\u003elsdb for validity, possible\n\t mitigation (but not solution) for bug #269.\n" }, { "commit": "4dadc291e56195886fd047690ded9686f4e013fa", "tree": "ea7c0690912d2b7d0c487f6855960e768fff1b6e", "parents": [ "69e10adaf28d4e116c38db2648786557fe131828" ], "author": { "name": "paul", "email": "paul", "time": "Fri May 06 21:37:42 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri May 06 21:37:42 2005 +0000" }, "message": "2005-05-06 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n * (general) extern and static qualifiers added.\n unspecified arguments in definitions fixed, typically they should\n be \u0027void\u0027.\n function casts added for callbacks.\n Guards added to headers which lacked them.\n Proper headers included rather than relying on incomplete\n definitions.\n gcc noreturn function attribute where appropriate.\n * ospf_opaque.c: remove the private definition of ospf_lsa\u0027s\n ospf_lsa_refresh_delay.\n * ospf_lsa.h: export ospf_lsa_refresh_delay\n * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,\n correct thing to do - removes need for the casts later.\n * ospf_vty.c: Use vty.h\u0027s VTY_GET_INTEGER rather than ospf_vty\u0027s\n home-brewed versions, shuts up several warnings.\n * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and\n VTY_GET_IPV4_PREFIX moved to lib/vty.h.\n * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky\n overloading of the THREAD_ARG pointer should at least use\n uintptr_t.\n" }, { "commit": "462f20d50c8f86c26904f1c7316d910c2b83ae41", "tree": "3edbff28c76bdb8e1c66ea5153b1cb58d40f15aa", "parents": [ "c3c07f28dcd226975b5ed0c1f8842f51968a3288" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 23 11:29:02 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 23 11:29:02 2005 +0000" }, "message": "\t* ospf_lsa.h: New flag to the LSA structure for the SPF calculation.\n\t* ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.\n\t* ospf_spf.h: Add link to the LSA stat structure into vertex.\n\t* ospf_spf.c: New functions cmp() and update_stat() to manage\n\t candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),\n\t ospf_install_candidate() and ospf_spf_register() functions not needed\n\t any more. Update ospf_vertex_new(), ospf_spf_next() and\n\t ospf_spf_calculate() functions to use pqueue instead of linked list.\n" }, { "commit": "082253f5d08577e2c7b61ed2302be88295b459eb", "tree": "4a359027a29c673844f89bd36e706baaa5326db4", "parents": [ "5d6191ee84cc4b292f19f287a5c4fc45f7dd9b84" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri Feb 11 08:31:54 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri Feb 11 08:31:54 2005 +0000" }, "message": "\t* ospf_lsdb.c: Fix sum of checksums calculation.\n\n\t[backport candidate]\n" }, { "commit": "fe71a97da23e2282bc92f647227d5c97c73e3bc8", "tree": "d812d9a1b98b0a1e9c1621194bf58dba097d6e3b", "parents": [ "16f6511e94c3765725b196aacaf6053385bca8a3" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Dec 22 16:16:02 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Dec 22 16:16:02 2004 +0000" }, "message": "Show sums of checksums in \"show ip ospf\" output. Okayed by Paul and James\nR. Leu (author of original idea).\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }