)]}' { "log": [ { "commit": "ad12dde6f9596997337ebc210dd2d4593438556b", "tree": "661e013c488b2f7003b8b817d680fa9d03f4eb30", "parents": [ "22714f99c4ffeb4d1bade7ad6374adeba0e06e4c" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jun 13 22:50:07 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jun 13 22:50:07 2012 +0100" }, "message": "Revert \"bgpd: Make socket init separate, so unit tests work again.\"\n\nThis reverts commit 7621f336e2f346edee43227f0b1ef93fe769720b. See bug #727\n" }, { "commit": "47d3b6078a6c885e03d28bae3397b71a827473f5", "tree": "b3a6a1de537c9be50c839cf088be89ee91c6b38e", "parents": [ "f018db83a0746f9336d04e50dd06f3bbf6565f1c" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:11 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:35:51 2012 +0200" }, "message": "micro-op bgp_node_[get|lookup]() and route_node_[get|lookup]()\n\n Reduce indirection for values that doesn\u0027t change in the loop.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\n[adjusted after dropping previous patch]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f018db83a0746f9336d04e50dd06f3bbf6565f1c", "tree": "4c2ba0e661abd2651ee6fa1bd7be9157c8859411", "parents": [ "343aa82219c0cab0315e29267eb303127215caea" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:10 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:35:50 2012 +0200" }, "message": "bgpd: optimize bgp_aggregate_[increment|decrement]()\n\n If there were no aggregates configured this functions were allocating\nand freeing a struct bgp_node for every call, and it\u0027s called for every\nprefix received.\n\n* bgp_route.c: Bail out early if the there are no aggregates configured.\n Change from bgp_node_get() to bgp_node_lookup() that does not allocate\n a new struct bgp_node if not found.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "343aa82219c0cab0315e29267eb303127215caea", "tree": "17e6b77072657a1a8ae04aeacb715652de1c4ddb", "parents": [ "6a4677b723b6f79997ca15ee202c36d528d3dfcf" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:08 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:35:50 2012 +0200" }, "message": "bgpd: optimize bgp_update_main() in the soft_reconfig case\n\nAvoids 3 checks per call.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6a4677b723b6f79997ca15ee202c36d528d3dfcf", "tree": "d1928cd0835791b91870bfb9e4fb9eea3c75b07b", "parents": [ "577ac57b78e0ee3cbc5afdb5f54a660bd0126136" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:07 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:35:47 2012 +0200" }, "message": "bgpd: optimize holdtime timer cancelling\n\n* bgp_packet.c: (bgp_update_receive) for every update received we queue\n an event just to cancel the holdtime timer, done in bgp_fsm_update().\n Instead cancel the timer directly an avoid a scheduling pass.\n\n This incidently fixes another problem found on a slow box, where thousands\nof events threads were queued, and run, but never freed, because they are\nmoved to the unused list that grows without bounds.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "577ac57b78e0ee3cbc5afdb5f54a660bd0126136", "tree": "ec891bb869f46e7a4cd30c1163dfbc768587002b", "parents": [ "558d1fec11749d3257e32561d45b5c1ec0622cf4" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:06 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:50 2012 +0200" }, "message": "bgpd: Remove useless initialization\n\nIt\u0027s initialized below\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "558d1fec11749d3257e32561d45b5c1ec0622cf4", "tree": "4570b1643db6446dc9f14f9c0bf7fd64a3325117", "parents": [ "489d005a9ad94675f40dc7bceff6176cfad36d45" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:05 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:50 2012 +0200" }, "message": "bgpd: reduce struct attr_extra allocations/freeing\n\nTry to use on stack structs for temporary uses.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "489d005a9ad94675f40dc7bceff6176cfad36d45", "tree": "c11edc9588fc1fd4ccef33f168a7367d0a34db65", "parents": [ "6182d65b23fc0362b173e2a9314fa4551523a1c2" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:03 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: use on stack struct attr_extra in bgp_update_receive()\n\nReduce memory heap fragmentation and pressure on the memory allocator.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6182d65b23fc0362b173e2a9314fa4551523a1c2", "tree": "fb99eb9565f5ea8aa6a8b88eb9c4c05dc7cf364a", "parents": [ "b9f1dca10f9a9bf853a9999a117c8cdeec5b7b69" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:02 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: fix struct attr_extra leak in bgp_default_originate()\n\n The call to bgp_attr_default_set() above creates the attr_extra struct,\nbut the attr.extra \u003d NULL initialization was leaking it.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "b9f1dca10f9a9bf853a9999a117c8cdeec5b7b69", "tree": "b6382403ba177cb56f0ca6054db1ce32428fd7f2", "parents": [ "1a2fd7078f943e2207ee0f1b0dafdcd2d9c81925" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:01 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: use on stack struct attr_extra in bgp_attr_unintern()\n\n Reduce memory heap fragmentation and pressure on the memory allocator.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "1a2fd7078f943e2207ee0f1b0dafdcd2d9c81925", "tree": "da0852c5c4019c6c1893dec384e9f20df26cea29", "parents": [ "938ef3a22535292dd36c250e5329f97d977e51df" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:00 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: cleanup bgp_attr_unintern()\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "938ef3a22535292dd36c250e5329f97d977e51df", "tree": "a854c21dd840e7558a482bf4812b857583da3591", "parents": [ "7fb0cd82c26492004a106bec7ca4afdf4684fabb" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:59 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: use on stack struct attr_extra on bgp_attr_aggregate_intern()\n\nReduce memory heap fragmentation and pressure on the memory allocator.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "7fb0cd82c26492004a106bec7ca4afdf4684fabb", "tree": "1f901bbc121337b9c421eb48d7bcc413ad140753", "parents": [ "e16a413313cf985ae2b8d2f1a9e8fd0ab6f5b9fc" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:58 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: reduce attrhash_make_key() indirections\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e16a413313cf985ae2b8d2f1a9e8fd0ab6f5b9fc", "tree": "e6810289e60312da431a8f992903275d952d0e6b", "parents": [ "8ff56318a8bd188cfcc1cdab689c46c326b50d38" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:57 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: remove some useless initializations\n\n* bgp_attr.c: (bgp_attr_default_intern) bgp_attr_default_set() already\n initializes the memory. Fixes a struct attr_extra leak.\n* bgp_route.c: Remove useless on stack struct initializations.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8ff56318a8bd188cfcc1cdab689c46c326b50d38", "tree": "6b7b718166aa6fe3b7264d3efba9c39750f5917b", "parents": [ "c76275ee960c708408646d8a680b201b27cb9c1a" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:56 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: optimize bgp_info_cmp()\n\n* bgp_route.c: (bgp_info_cmp) Reduce indirections, precalculate some\n values that are used several times, reduce conditionals.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c76275ee960c708408646d8a680b201b27cb9c1a", "tree": "59daf9a650950d35aa5350270118cd94e4a1fde3", "parents": [ "6d85b15bbb2fd3c263d5d4b402c88ff348af877b" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:55 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:44 2012 +0200" }, "message": "bgpd: optimize loops on [e]community_hash_make()\n\n This change reduces loop count. Less jumps.\n\n* bgp_community.c: One loop per community.\n* bgp_ecommunity.c: One loop per ecommunity.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6d85b15bbb2fd3c263d5d4b402c88ff348af877b", "tree": "c8be5e782f4425840ee93e167eb8d7c1ed3f4e4c", "parents": [ "14542f3edaa43113880e8bb69612c553f02bdf22" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:54 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:10 2012 +0200" }, "message": "bgpd: remove calls to peer_sort() from fast-path\n\n peer_sort() it\u0027s called so much as to be annoying. In the assumption\nthat the \u0027sort\u0027 of the peer doesn\u0027t change during an established session,\nI have changed all calls to peer_sort() in the \u0027fast-path\u0027 to only check\nthe \u0027sort\u0027. All the calls from the vty and such still recalculate the sort\nand store it in the peer.\n\n There\u0027s a lot of other calls to peer_sort() that could be changed but some\nmaube tricky, someone more knowledgeable may try to reduce them.\n\n This hits peer_sort() from 5th out of the stadium^H^H list on a full\ninternet table loading profiling session.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "14542f3edaa43113880e8bb69612c553f02bdf22", "tree": "247dd2b8ef6e1cea2d91d39989a943fddfb481ca", "parents": [ "10f9bf3f2021f874e574e4ebae9413bee982ed2b" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:53 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:10 2012 +0200" }, "message": "bgpd: debug buffers cleanup and optimization\n\nJust the first change pushes bgp_update_receive() from 6th to ~14th on a\nfull internet table load profiling session.\n\n* bgp_debug.c: (bgp_update_receive) The attrstr initialization is expensive,\n moved under the debug conditional where it is used and just initialize the\n first char to NULL.\n (bgp_update_default_send) Initialize attrstr needed for bgp_dump_attr().\n Moved some buffers used for printing IP[4|6] addresses under the debug\n conditionals that use them and reduced its size.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "10f9bf3f2021f874e574e4ebae9413bee982ed2b", "tree": "5102a98c91d7d60380c07c08d0aaa32aa19cdbdf", "parents": [ "f669f7d25f0f491d5e487897227ff434aef20406" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:52 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:07 2012 +0200" }, "message": "bgpd: optimize bgp_nexthop_self()\n\n This function scores 2nd, profiling a full internet table load. It\u0027s called\nfor every prefix received.\n Instead of looping in the interface lists comparing addresses use a hash\nto mantain them.\n\n* bgpd.c: Init the own address hash.\n* bgp_nexthop.c: Introduce methods to maintain an own address hash.\n (bgp_connected_add) add addresses to the hash.\n (bgp_connected_delete) delete addresses from the hash.\n (bgp_nexthop_self) lookup addresses in the hash. Removed the unused afi_t\n parameter.\n* bgp_route.c: (bgp_update_main) Micro-optimization, rearranged condition to\n not lookup the hash for bogus nexthops (0.0.0.0 or a class D/E address)\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f669f7d25f0f491d5e487897227ff434aef20406", "tree": "4b040b835be1d47b7eca7240b7d7aa4b9e6f177b", "parents": [ "8692c506520f6b268525b80890702432c95f13c4" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:51 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:02 2012 +0200" }, "message": "bgpd: optimize aspath string representation and assegments handling\n\n* bgp_aspath.h: Add str_len to struct aspath.\n* bgp_aspath.c: Save the aspath string representation length and use it\n instead of strlen().\n (aspath_make_str_count) assign the string buffer directly for\n consistency with the string length and change the return type to void.\n (aspath_dup) use str_len and copy the string instead of calling\n aspath_make_str_count().\n (assegment_data_new) change from XCALLOC to XMALLOC. All users initialize\n the memory before use.\n (assegment_data_free) unused, removed.\n (aspath_intern) check that there\u0027s always a -\u003estr pointer.\n (aspath_hash_alloc) reuse assegments and string representation instead of\n copying them.\n (aspath_parse) now aspath_hash_alloc does not dupes memory, free the\n temporary structures only if the aspath it is in the hash.\n (aspath_cmp_left) remove useless NULL initialization.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8692c506520f6b268525b80890702432c95f13c4", "tree": "0446939f0c84705bc0da3f23b45e97fd21886269", "parents": [ "1b79fcb646f66682a62cf34f3cc343b1a9706699" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 15:17:34 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon May 21 15:48:30 2012 +0200" }, "message": "bgpd: fix crash with vpnv4 soft-reconfiguration\n\nbgp_afi_node_get() expects a non-NULL prd for a SAFI_MPLS_VPN prefix.\n\n* bgp_route.c: pass down the struct prefix_rd from bgp_soft_reconfig_in()\n and bgp_soft_reconfig_rsclient().\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "682ca04c4032bfbf31e51df2472345fda1ff7b2c", "tree": "ec75a530cd72d30b41f90c2ddbd2878791e3f95f", "parents": [ "37beff6feb7c1715a19b59b8a87edcb6b50d5ac2" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Tue Apr 10 16:57:27 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:34 2012 +0200" }, "message": "bgpd: cleanup, use correct buffer sizes for sockunion2str()\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "c63b83fe8d1addecc949258479b8d54180c4da60", "tree": "fbc58da3014db1cf74a2f8a91a33fe941968815d", "parents": [ "d227617a972bb20a974be68bea5032e692a0970f" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Tue Apr 10 16:57:24 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:27 2012 +0200" }, "message": "bgpd: Fix memory leak of some \"show ip bgp neighbor\" commands\n\nsockunion_str2su() use is prone to memory leaks. Remove it\u0027s use all over\nthe code.\n\nAt least these commands leaked a sockunion union:\n - show ip bgp vpnv4 ... routes\n - show ip bgp ... received prefix-filter\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "0c5ed3ed00f630ae95dc2dfd4b5a938683e2a99e", "tree": "9e478062fed566ce245113a166a6c8d1eec9fbe2", "parents": [ "4fe080d7ee4c924a962d14423d94b4b8d8aba110" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Tue Apr 10 16:57:22 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:27 2012 +0200" }, "message": "bgpd: Fix memory leak with \u0027set ip next-hop peer-address\u0027\n\nA route-map with the mentioned statement causes a memory leak for every\nprefix that matches.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "4fe080d7ee4c924a962d14423d94b4b8d8aba110", "tree": "d1dab521b8d05a95dccf26628fcf5ed629b738e7", "parents": [ "ddc943dec3c017583f81cce388c7d453293156c7" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Fri Apr 13 13:46:08 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:27 2012 +0200" }, "message": "bgpd: fix for route-maps with \"match peer local\" statements\n\nA route-map with a \u0027match peer local\u0027 statement it\u0027s shown like\n\u0027match peer (null)\u0027 on config output...\n\n... and it\u0027s unparsable on daemon startup.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "ddc943dec3c017583f81cce388c7d453293156c7", "tree": "a36d2bca91b1f3a7545a135b3bafccc40d0ca47b", "parents": [ "8794e8d229dc9fe29ea31424883433d4880ef408" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Fri Apr 13 13:46:07 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:21 2012 +0200" }, "message": "bgpd, zebra: Fix format for some metric outputs\n\nMetrics are unsigned values.\n\n * bgpd/bgp_{debug,route,vty}.c,\n * zebra/zebra_vty.c: replace %d with %u for metrics \u0026 distances\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\n[reworded commit message]\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "8794e8d229dc9fe29ea31424883433d4880ef408", "tree": "6ecfaad3044ad522eb1fc1e7aba989552eeec816", "parents": [ "7621f336e2f346edee43227f0b1ef93fe769720b" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Feb 13 13:53:07 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed May 02 11:16:11 2012 +0100" }, "message": "bgpd: Fix regression in args consolidation, total should be inited from args\n\n* bgp_attr.c: (bgp_attr_unknown) total should be initialised from the args.\n" }, { "commit": "7621f336e2f346edee43227f0b1ef93fe769720b", "tree": "2bda36681214336bf55345cd47efb2c25fc460c2", "parents": [ "1dba254e107dd0c4254d58e9304fc6293b46fd4d" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue May 01 16:24:35 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed May 02 11:02:11 2012 +0100" }, "message": "bgpd: Make socket init separate, so unit tests work again.\n\n* Separate out BGP socket initialisation from bgp_get, and make it an\n explicit function. Allows unit tests to work again and probably also\n benefits dry-run.\n* bgpd.c: (bgp_get) move socket init out...\n (bgp_socket_init) to here\n* bgp_main.c: and call it after dry-run.\n* bgpd.h: (bgp_socket_init) add prototype\n" }, { "commit": "fac3c2453a06bce773a3f4ae6834f5f9a317b88c", "tree": "00b1e95d9fc2d148d1731967ccd104af3f7615c6", "parents": [ "27f689793a25a66cf62561ac1d1302e01983a805" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Sat Apr 28 22:37:20 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Sat Apr 28 22:37:20 2012 +0200" }, "message": "bgpd: fix up multipath merge breakage\n\nthe BGP multipath code was developed against a pre-f6f434b Quagga where\nbgp_attr_unintern and ecommunity_free took single-star pointers. They\nnow take double-star pointers.\n\n * bgpd/bgp_mpath.c: fix up bgp_attr_unintern \u0026 ecommunity_free calls.\n\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "fa4094ac49b4cc23589f5c5b7e608c4b4ee6ca04", "tree": "6ee1470a3db1d3e09e455a34a41b6b5db4296847", "parents": [ "7939e016b3d4ecd2f5b8ad708b69607e05a084a6" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Fri Apr 13 13:46:09 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Mon Apr 16 18:37:17 2012 +0200" }, "message": "bgpd: Fix crash when disabling dampening (BZ#687)\n\n Vladimir Podobaev reported that the following commands crashed the\ndaemon.\n\nrouter bgp 123\n bgp dampening\n no bgp dampening 1 2 3 4\n no bgp dampening\n\n The problem was that bgp_damp_info_clean() tried to dereference the\nalready freed reuse_list array in the second call to \"no bgp dampening\".\n\n Fixed by checking in bgp_damp_disable() that the dampening it\u0027s\nenabled before doing the cleanup.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\n" }, { "commit": "6e493a44836d3b034ed3421e866878de3fbfcc5b", "tree": "4edabbbca2126db9aa29b9901ada950c635c17e2", "parents": [ "9bb5870e26a4089f599b24adf822c4d1a9870a44", "3b381c32fc2c325cc4ffb9f9f30a7e96e9bd87c6" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Mon Apr 16 16:46:13 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Mon Apr 16 16:46:17 2012 +0200" }, "message": "bgpd: merge osr/quagga-osr-patches (BZ#700)\n\nthis merges a bgp capability negotiation fix where bgpd would fail if no\nmultiprotocol capability was present, but other capabilities were.\n" }, { "commit": "3cf6c2b4e43f44a977d218c96c26250654ae333e", "tree": "e017cde2015fbf3ef6c250327428d7c6152aa8f7", "parents": [ "01d7ff0a2166a422c56bd26f04fc22832a9e690b", "e96b312150d8e376c1ef463793d1929eca3618d5" ], "author": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Mon Apr 09 00:25:15 2012 -0700" }, "committer": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Mon Apr 09 00:25:15 2012 -0700" }, "message": "Merge branch \u0027quagga\u0027 into google-bgp-multipath\n\nConflicts:\n\tbgpd/bgp_route.c\n" }, { "commit": "3b381c32fc2c325cc4ffb9f9f30a7e96e9bd87c6", "tree": "b4eb46f5fe28b4734723c9ff4227a94a5bd32b4e", "parents": [ "e96b312150d8e376c1ef463793d1929eca3618d5" ], "author": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Sun Feb 19 10:19:52 2012 -0800" }, "committer": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Sun Apr 08 13:46:29 2012 -0700" }, "message": "bgpd: fix issue in capability negotiation (BZ#700)\n\nAddress problem where bgpd would reject a session if a peer sent some\ncapabilities in its Open message, but did not include a Multiprotocol\nextensions capability. Note that the session would come up if there\nwere no capabilities at all in the Open message.\n\n * Add the \u0027mp_capability\u0027 out parameter to\n bgp_capability_parse(). Set it to \u00271\u0027 if a Multiprotocol\n extensions capability is encountered.\n\n * Switch on \u0027mp_capability\u0027 instead of \u0027capability\u0027 in the calling\n functions to determine if the peer indicated the set of AFI/SAFIs\n it supports.\n\n The net result is that when a peer does not send an MP capability,\n it is assumed to support the AFI/SAFIs configured for it locally.\n" }, { "commit": "fa5831e85ae9ba7008fb4b4e2d4c7561ae5cb697", "tree": "5653d8127ad212e6d251fb078afef50fc262353b", "parents": [ "fa61e16ddebe10a71d98bcd2eba0f630071ea4a7" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:54:04 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:54:04 2012 +0100" }, "message": "bgpd: bgp_attr_flags_diagnose shouldn\u0027t assert\n\n* bgpd/bgp_attr.c: (bgp_attr_flags_diagnose) debug code for error-handling\n paths probably shouldn\u0027t assert, instead it should just log that there\n was no problem.\n" }, { "commit": "fa61e16ddebe10a71d98bcd2eba0f630071ea4a7", "tree": "bc301257fdb4dbac4aedf1e17ffa3e6c00a77612", "parents": [ "683f2b86d89fa356d3d1f7a54b0c269baa38b836" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Mar 25 21:31:47 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:48:38 2012 +0100" }, "message": "bgpd: attr_parse call to attr_malformed should deal with PROCEED error case\n\n* bgpd/bgp_attr.c: (bgp_attr_parse) the invalid flag check call to\n bgp_attr_malformed is pretty useless if it doesn\u0027t actually allow\n for the PROCEED non-error case.\n" }, { "commit": "683f2b86d89fa356d3d1f7a54b0c269baa38b836", "tree": "0788f6ea3f9079d3c1d775c49cd4cd881e44d204", "parents": [ "bd471fea4ec965c71d6c2201745995092fbc36f6" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Mar 23 14:58:45 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:48:35 2012 +0100" }, "message": "bgpd: Fix silly mistake in bgp_attr_flag_invalid\n\n* bgp_attr.c: (bgp_attr_flag_invalid) flags is meant to be masked\n off with the mask variable...\n" }, { "commit": "bd471fea4ec965c71d6c2201745995092fbc36f6", "tree": "1d07d21b35101724d98107d47f4cd214800b4489", "parents": [ "81c3e5006e5d29e305cbc0ab482617d7e570e8c0" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Mar 15 11:30:00 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Mar 25 21:33:51 2012 +0100" }, "message": "bgpd: malformed attribute error that can still proceed should fixup getp\n\n* bgp_attr.c: (bgp_attr_malformed) When a malformed attribute error can be\n ignored, and BGP message processing may still proceed, the stream getp\n should be adjusted to the end of the attribute - the caller may not have\n consumed all the attribute. Problem noted by Martin Winter in bug 678.\n\n Also, rename the \u0027startp\u0027 local to \u0027notify_datap\u0027, for clarity.\n" }, { "commit": "9fc75742397cf942ca9d684815ce63058b2576ff", "tree": "3655b28f06ac2bdf9639b86e2df7c3abc525cd73", "parents": [ "543fb49c316df9af2d25f08ba7e0da0305c36b5e", "5861739f8c38bc36ea9955e5cb2be2bf2f482d70" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 05 11:55:53 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 05 11:55:53 2012 +0000" }, "message": "Merge remote-tracking branch \u0027quagga-gnu.org/master\u0027\n" }, { "commit": "5861739f8c38bc36ea9955e5cb2be2bf2f482d70", "tree": "9675845a0b3be97362f3426430c6c2e499e8525c", "parents": [ "50e7a3885da44f8f6c5c639e111109deb055cdf3" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jan 09 20:59:26 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Mar 04 23:55:02 2012 +0000" }, "message": "bgpd: Open option parse errors don\u0027t NOTIFY, resulting in abort \u0026 DoS\n\n* bgp_packet.c: (bgp_open_receive) Errors from bgp_open_option_parse are\n detected, and the code will stop processing the OPEN and return. However\n it does so without calling bgp_notify_send to send a NOTIFY - which means\n the peer FSM doesn\u0027t get stopped, and bgp_read will be called again later.\n Because it returns, it doesn\u0027t go through the code near the end of the\n function that removes the current message from the peer input streaam.\n Thus the next call to bgp_read will try to parse a half-parsed stream as\n if it were a new BGP message, leading to an assert later in the code when\n it tries to read stuff that isn\u0027t there. Add the required call to\n bgp_notify_send before returning.\n* bgp_open.c: (bgp_capability_as4) Be a bit stricter, check the length field\n corresponds to the only value it can be, which is the amount we\u0027re going to\n read off the stream. And make sure the capability flag gets set, so\n callers can know this capability was read, regardless.\n (peek_for_as4_capability) Let bgp_capability_as4 do the length check.\n" }, { "commit": "835315bfb49bff2b2fb354f2075c6d6693c2a151", "tree": "b9cc49ef796bcb1e3836ff670da930765815acfa", "parents": [ "3ecab4c8549574d09f8d8366098939a8ad3da6c4" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jan 18 12:28:30 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Feb 28 18:35:45 2012 +0000" }, "message": "bgpd: Move up flag-check calls, parcel up attr-parser args, and other cleanups\n\n* bgp_attr.h: (struct bgp_attr_parser_args) Attribute parsing context,\n containing common arguments.\n* bgp_attr.c: (general) Move the bgp_attr_flag_invalid flag-check calls up,\n out of each individual attr parser function, to be done once in attr_parse.\n\n Similarly move the calculation of the \u0027total\u0027 attribute length field up\n to attr_parse.\n\n Bundle together common arguments to attr-parsing functions and helpers\n into (struct bgp_attr_parser_args), so it can be passed by reference down\n the stack \u0026 also de-clutter the argument lists \u0026 make it easier to\n add/modify the context for attr-parsing - add local const aliases to avoid\n modifying body of code too much. This also should help avoid cut \u0026 paste\n errors, where calls to helpers with hard-coded attribute types are pasted\n to other functions but the code isn\u0027t changed.\n\n (bgp_attr_flags_diagnose) as above.\n (bgp_attr_flag_invalid) as above.\n (bgp_attr_{origin,aspath,as4_path,nexthop,med,local_pref,atomic}) as above.\n (bgp_attr_{aggregator,as4_aggregator,community,originator_id}) as above\n (bgp_attr_{cluster_list,ext_communities},bgp_mp_{un,}reach_parse) as above\n (bgp_attr_unknown) as above.\n\n (bgp_attr_malformed) as above. Also, startp and length have to be\n special-cased, because whether or not to send attribute data depends\n on the particular error - a separate length argument, distinct from\n args-\u003elength, indicates whether or not the attribute data should be sent\n in the NOTIFY.\n (bgp_attr_aspath_check) Call to bgp_attr_malformed is wrong here, there is\n no attribute parsing context - e.g. the \u0027flag\u0027 argument is unlikely to be\n right, remove it. Explicitly handle the error instead.\n (bgp_attr_munge_as4_attrs) Flag argument is pointless.\n\n As the comment notes, the check here is pointless as AS_PATH presence\n already checked elsewhere.\n\n (bgp_attr_parse) Do bgp_attr_flag_invalid call here.\n Use (struct bgp_attr_parser_args) for args to attr parser functions.\n Remove out-of-context \u0027flag\u0027 argument to as4 checking functions.\n" }, { "commit": "3ecab4c8549574d09f8d8366098939a8ad3da6c4", "tree": "7b8281980887ef0c57485be0ca6f382c054762cd", "parents": [ "b5043aabb03567b46a16463d88a8afce2acda35e" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jan 17 13:31:33 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Feb 28 18:35:45 2012 +0000" }, "message": "bgpd: consolidate attribute flag checks\n\n* bgpd/bgp_attr.c: (attr_flags_values []) array of required flags for\n attributes, EXTLEN \u0026 PARTIAL masked off as \"dont care\" as appropriate.\n (bgp_attr_flag_invalid) check if flags may be invalid, according to\n the above table \u0026 RFC rules.\n (bgp_attr_*) Use bgp_attr_flag_invalid.\n (bgp_attr_as4_aggregator) ditto, also take startp argument for the\n NOTIFY data.\n (bgp_attr_parse) pass startp to bgp_attr_as4_aggregator\n" }, { "commit": "73bfe0bd9adb8e4dfcee7239e56a425c6d58f4e9", "tree": "e2f5dd3fc170a28d9aff622a8c5af77f3ebf7e45", "parents": [ "f768f367bcd1f37a53c563495176a5a134caf234" ], "author": { "name": "G.Balaji", "email": "balajig81@gmail.com", "time": "Fri Sep 23 22:36:20 2011 +0530" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jan 23 14:31:05 2012 +0400" }, "message": "bgpd: Addition of ipv6 network command in Multicast address family mode.\n\n The patch adds the ipv6 network command in the BGP multicast address\n family mode.\n" }, { "commit": "c7ec179a95c1ed4fcd3d3be3f981c8c20dce534a", "tree": "add6824e168ab26a28390a1d1b9a2c7be1484435", "parents": [ "cddf391bf6839e9f093cef15508669c1f3f92122" ], "author": { "name": "G.Balaji", "email": "balajig81@gmail.com", "time": "Sat Nov 26 22:04:05 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jan 23 14:30:50 2012 +0400" }, "message": "bgpd: IPv6 MP-BGP Routes addition and deletion\n\nThis patch contains the following:\n1. Addition of IPv6 SAFI_MULTICAST BGP routes into the BGP Multicast RIB.\n2. Deletion of IPv6 SAFI_MULTICAST BGP routes from the BGP Multicast RIB.\n" }, { "commit": "5a616c08ce089e25dc0e8da920727af4d11279bf", "tree": "4b5650d6602d06d0188102469e3b402abe81f16a", "parents": [ "6ae93c058725991df5a9ae35cefec368919b5fea" ], "author": { "name": "G.Balaji", "email": "balajig81@gmail.com", "time": "Sat Nov 26 21:58:42 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jan 23 14:30:33 2012 +0400" }, "message": "bgpd: IPv4 MP-BGP Routes addition and deletion\n\nThis patch contains the following:\n1. Addition of IPv4 SAFI_MULTICAST BGP routes into the BGP Multicast RIB.\n2. Deletion of IPv4 SAFI_MULTICAST BGP routes from the BGP Multicast RIB.\n" }, { "commit": "fc98d16ea77372f4ab4231e8904f8467e8d1ef71", "tree": "ad69423081bd300c5a60262f947760ac7189744f", "parents": [ "dc00d2bb56aa6a84dd2328133f69db3c3e6d9dc7" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jan 09 11:36:23 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jan 09 11:36:23 2012 +0000" }, "message": "bgpd: reinstate zlookup checks, required for BGP without zebra\n\n* bgp_nexthop.c: The nexthop lookup cache has to return success for queried\n nexthops if bgpd isn\u0027t connected to zebra, or else BGP without zebra doesn\u0027t\n work.\n" }, { "commit": "f31d6927b2df4340bf9ff1cc9f20d52e168a3766", "tree": "638f95d929b07067f5cac70f21d40a4b94e1f8f9", "parents": [ "83a9a2213a73aeb9796b69327c87e89e2d3327ed" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:17:42 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:21:55 2012 +0000" }, "message": "bgpd: Fix incorrect attribute type code in call to bgp_attr_malformed\n" }, { "commit": "83a9a2213a73aeb9796b69327c87e89e2d3327ed", "tree": "ed0ef43739f593a3163309a128b179d66ceec4d8", "parents": [ "9ed79b53eb89b8a663eb368ef5f7d47701f231df" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:15:03 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:15:03 2012 +0000" }, "message": "bgpd: Improve flag error messages in bgp_attr_aspath\n\n* bgpd/bgp_attr.c: (bgp_attr_aspath) error message could be misleading,\n clearly log what flag was incorrect.\n\n (Problem noted in \"bgpd: fix error message in bgp_attr_aspath()\" in\n Quagga-RE)\n" }, { "commit": "afcb767922509c4d998f1c567e350b9809c148ab", "tree": "ce9f742f0471377337e36235dee73a39e17cb7b0", "parents": [ "d8bcd9e9c6a1801b52b166fa3873eb468ac3c5cb" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Oct 23 22:32:44 2011 +0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 12:57:35 2012 +0000" }, "message": "bgpd: rewrite attr flag error logging\n\n* bgp_attr.c\n * attr_flag_str: new message list\n * bgp_attr_flags_diagnose(): new function, implements previously added\n error logging in a generic way\n * bgp_attr_origin(): use bgp_attr_flags_diagnose()\n * bgp_attr_nexthop(): ditto\n * bgp_attr_med(): ditto\n * bgp_attr_local_pref(): ditto\n * bgp_attr_atomic(): ditto\n * bgp_attr_originator_id(): ditto\n * bgp_attr_cluster_list(): ditto\n * bgp_mp_reach_parse(): ditto\n * bgp_mp_unreach_parse(): ditto\n" }, { "commit": "0e8032d69961ae196c11ba6ead856084c7acf7c2", "tree": "f9adf1934b0b34fd3e4db4896bc83c05e471d234", "parents": [ "b64bfc1c4a552fc0b4dd024d5f77171ec848a5df" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Aug 09 14:42:58 2011 +0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 11:31:50 2012 +0000" }, "message": "bgpd: improve \"show ip bgp scan detail\"\n\n* bgp_nexthop.c (show_ip_bgp_scan_tables): access proper structure field\n in AF_INET6 case, handle ifindex NH type properly\n" }, { "commit": "b64bfc1c4a552fc0b4dd024d5f77171ec848a5df", "tree": "f03661d27a79ae5810c861c643d85d810e885b87", "parents": [ "318f0d8a7f5e8e87086bbf2a9e7c4b35638951ac" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 08 19:36:44 2011 +0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 11:31:35 2012 +0000" }, "message": "bgpd: dismiss some zlookup checks\n\nbgp_nexthop_onlink(): zlookup is not used here at all\nbgp_nexthop_lookup_ipv6(): rely on the detection performed by \"query\"\n function (this also changes the fallback value to 0), reorder if-block\nbgp_nexthop_lookup(): idem\n" }, { "commit": "318f0d8a7f5e8e87086bbf2a9e7c4b35638951ac", "tree": "deab95315df2b315ba5b03162c43b61cb6c9ff2b", "parents": [ "8e80bdf20f493a71bcf74262ed3aa3a2437f4df6" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 21:47:08 2011 +0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 11:31:17 2012 +0000" }, "message": "bgpd: add \"show ip bgp scan detail\" command\n\n* bgp_nexthop.c: (show_ip_bgp_scan) transform into\n show_ip_bgp_scan_tables(), which uses inet_ntop() and can dump\n nexthops on request; (show_ip_bgp_scan_detail_cmd) new function\n" }, { "commit": "8e80bdf20f493a71bcf74262ed3aa3a2437f4df6", "tree": "b1ebddbda4b8f12a28c3ce6299ebe931105a25b6", "parents": [ "23be94ea00fadace0007b6ffa6c9107124249e91" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 18:52:52 2011 +0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 11:30:55 2012 +0000" }, "message": "bgpd: touch nexthop handling code\n\nbgp_nexthop_lookup_ipv6(): declare variables where they are actually\nused, drop no-op initialization (the field is already 0)\nbgp_nexthop_lookup(): ditto\nbgp_nexthop_check_ebgp(): rename to bgp_nexthop_onlink()\nbgp_nexthop_cache_changed(): rename to bgp_nexthop_cache_different()\n" }, { "commit": "f63f06da2e7be6b17c72dd6110aae179f42f3700", "tree": "a36b625a9ea06d0720a240276ed1b8af33193ed7", "parents": [ "651e70d7f419ee7af75113f80e688c0100e9cff5" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Apr 08 12:44:43 2011 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jan 06 16:18:18 2012 +0000" }, "message": "general: remove inline qualifiers and move in-header functions to objects\n\n* (general) Move functions in headers into files, to be compiled into\n shared object files. Remove inline qualifier from functions. Let the\n compiler do the work.\n" }, { "commit": "664711c1f4cc218073783ff6ce362093debd7b53", "tree": "5566b0c8b9d22de55772717ad6c701ea85b6241e", "parents": [ "6fd16207fee6d4d09f29ed7ecf26303a7220e473" ], "author": { "name": "Ulrich Weber", "email": "ulrich.weber@sophos.com", "time": "Wed Dec 21 02:24:11 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jan 02 19:13:28 2012 +0400" }, "message": "lib: fix some strtoul() use cases\n\n...otherwise 4294967295 is not a valid value on 32bit systems\n" }, { "commit": "733cd9e5792648de50da3c00805aacb51cb27048", "tree": "606ec20aa51f16b7a49fd9f5ede27893bee9ace9", "parents": [ "de5ccb96023181765c9904ab40e645c397f536d6" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Dec 17 19:39:30 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jan 02 18:37:42 2012 +0400" }, "message": "bgpd: justify checks for IPv4 class D/E\n\n* lib/prefix.h\n * IPV4_CLASS_DE(): make consistent with counterpart macros\n* bgp_packet.c\n * bgp_open_receive(): test using macro instead of \"\u003e\u003d\"\n* bgp_route.c\n * bgp_update_rsclient(): idem\n * bgp_update_main(): idem\n" }, { "commit": "9206f9ecd5526778bf449bbb12f056d681d3b040", "tree": "cd11853fe47a30bb2a28838f6ad8f8d49300b4fa", "parents": [ "b48cebbba0dc01ad7d1fbd7cbcc39a11e1ae972d" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Sun Dec 18 19:43:40 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Dec 18 20:21:21 2011 +0400" }, "message": "fix set never used warnings\n\n(This patch was modified to leave calls to stream_getl() in place, they\nare necessary for the stream\u0027s internal pointer to advance to the\ncorrect position. -- Denis)\n\nSigned-off-by: Denis Ovsienko \u003cinfrastation@yandex.ru\u003e\n\nFix gcc warnings about varables that are set but never used.\n\n* bgpd/bgp_attr.c\n * cluster_unintern(): ret\n * transit_unintern(): ret\n * bgp_attr_default_intern(): attre\n * bgp_mp_reach_parse(): rd_high, rd_low\n* bgpd/bgp_route.c\n * bgp_announce_check_rsclient(): bgp\n* bgpd/bgp_zebra.c\n * zebra_read_ipv4(): ifindex\n * zebra_read_ipv6(): ifindex\n* bgpd/bgpd.c\n * bgp_config_write_peer(): filter\n* lib/distribute.c\n * distribute_list_all(): dist\n * distribute_list(): dist\n * distribute_list_prefix_all(): dist\n * distribute_list_prefix(): dist\n* lib/if_rmap.c\n * if_rmap(): if_rmap\n* lib/vty.c\n * vty_accept(): vty\n* lib/zclient.c\n * zclient_read(): ret\n* zebra/irdp_interface.c\n * if_group(): zi\n* zebra/rt_netlink.c\n * kernel_read(): ret, sock\n" }, { "commit": "bb915f5fa60de1a5b7e6089fcfc680281a590463", "tree": "e5ee800f9a18c1b8ebbe390e1762ad93fc778d9e", "parents": [ "32ca97392057d279eeddd1aef36c1836880e8b89" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 21:11:39 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 21:11:39 2011 +0400" }, "message": "bgpd: fix regression in ORF procesing (BZ#688)\n\nThis issue has been pointed out by Lou Berger and Tim Browski.\n\n* bgp_packet.c\n * bgp_route_refresh_receive(): restore if() condition, which was\n broken by commit fdbc8e77c88f751924299d0bc752371d5cc31116\n" }, { "commit": "ca0512692156d5bbb902523d2f123fc89dbec1ab", "tree": "6dd0206cb175c3e790023f9e5d5d755b57181b0d", "parents": [ "e0ca5fde7be5b5ce90dae78c2477e8245aecb8e9" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Sun Oct 04 16:21:49 2009 +0200" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 19:23:38 2011 +0400" }, "message": "lib: add sockopt helper for setting IPV6_V6ONLY and use it\n\ngetaddrinfo returns a list of socket parameters for listening. it\nwill contain both IPv4 and IPv6 listening sockets. unless we use\nIPV6_V6ONLY on the IPv6 ones, only the socket listed first will\nwork. if the IPv4 one came first, the IPv6 one would get an\n\"Address in use\" error.\n\nthis functionality was already present for bgpd and its listening\nsockets. as it is needed for vtys as well, make it a common helper.\n\nConflicts:\n\n\tlib/sockunion.c\n" }, { "commit": "e0ca5fde7be5b5ce90dae78c2477e8245aecb8e9", "tree": "0e0b32ddbed4a84a3b2de9dd7217165cb81f52fa", "parents": [ "ebf08631cad8a420fc6bfb7c45af5496dc11023e" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed Sep 16 01:52:42 2009 +0200" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 19:13:17 2011 +0400" }, "message": "lib: put route_types.txt to real use\n\nthis replaces most occurences of routing protocol lists by preprocessor\ndefines from route_types.h. the latter is autogenerated from\nroute_types.txt by a perl script (previously awk). adding a routing\nprotocol now is mostly a matter of changing route_types.txt and log.c.\n\nConflicts:\n\n\tlib/route_types.awk\n" }, { "commit": "05e54ee3df973194f2a00e3ea0b1da7bebc71fd6", "tree": "c07e2bbad0c55fe03eb2975b98f121de6ae55707", "parents": [ "ad8d4802a3078de694539fa9bae12322fc82042f" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Dec 03 17:45:17 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 14:27:01 2011 +0400" }, "message": "build: delete .cvsignore files\n" }, { "commit": "b51146856e660bcec723f535c17dc1c38b2f6efc", "tree": "8f501c98b3714e1d5ed381bd4d82fece4106aa8c", "parents": [ "2f658673fa477b58ed38caf94c156c95948de382" ], "author": { "name": "Vyacheslav Trushkin", "email": "me@dogonthesun.net", "time": "Fri Nov 25 18:51:48 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 14:26:28 2011 +0400" }, "message": "quagga: option \"-z\" (\"--socket \u003cpath\u003e\") added\n\nAll daemons modified to support custom path to zserv\nsocket.\n\nlib: generalize a zclient connection\n\nzclient_socket_connect added. zclient_socket and\nzclient_socket_un were hidden under static expression.\n\"zclient_serv_path_set\" modified.\n" }, { "commit": "1add115a9cfd3a2ee33a61731008b6ece90ec61d", "tree": "934e618a134821e75266fef036153498c8017c9e", "parents": [ "9a9446eabb8f153251d6d93d225a68ca44b436ac" ], "author": { "name": "Vyacheslav Trushkin", "email": "me@dogonthesun.net", "time": "Tue Nov 22 20:15:10 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 14:25:54 2011 +0400" }, "message": "bgpd: implement \u0027match probability\u0027 in route-maps\n\nNew clause \u0027match probability \u003cpercentage value\u003e\u0027\nwas added in route-maps (bgpd/bgp_routemap.c modified).\n" }, { "commit": "bde12e3fd5e498a266e813a5751c1b2d21e46ca5", "tree": "3a3a77cc2321925f3d00d192b994a4440da129a0", "parents": [ "42a7debf3c76b8001ce820e104a29d2f693c7cb7" ], "author": { "name": "Ulrich Weber", "email": "ulrich.weber@sophos.com", "time": "Wed Nov 16 19:32:12 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 14:25:25 2011 +0400" }, "message": "bgp: use VTY_GET_INTEGER_RANGE() in bgp_clear()\n\nSecond patch replaces \"VTY_GET_LONG (\"AS\", as_ul, arg);\"\nby \"VTY_GET_INTEGER_RANGE (\"AS\", as, arg, 1, BGP_AS4_MAX);\"\nas done in all other code, which parses AS numbers.\n" }, { "commit": "04d5e24d7425a52f13abcb6d2a30aa6246d837e7", "tree": "a90bcdbe8f51f30c94dc5f10f4b5749e6dd6094e", "parents": [ "46901400a3401a4a6caa40435241b4546bb2a5c5" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Dec 07 00:04:46 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 07 01:23:58 2011 +0400" }, "message": "bgpd: cleanup privs on termination\n\nWhen doing valgrind testing, the privledges from zprivs_init() need\nto be cleaned up on exit.\n" }, { "commit": "f04a80a5d209dbb54f6fec5d0149b7c0e489d29e", "tree": "aaf8378930b524b1bfc9c5326d738a172c255b4b", "parents": [ "fb01f87f4f50744206222343a780721af19fe56c" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Dec 06 14:51:10 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 06 15:03:00 2011 +0400" }, "message": "bgpd: store nexthop info for redistributed IPV6 routes\n\nBGP was ignoring nexthop info for static and other redistributed\nroutes for IPv6. Build extra attribute info to store the nexthop.\nSee also:\n https://bugzilla.vyatta.com/show_bug.cgi?id\u003d6073\n" }, { "commit": "ce0af6ff5a4f200035ed4134da72a67f49a21dd6", "tree": "1f085a210596f3f5875030c92ba3252933102149", "parents": [ "1ffe5e794c3cd4a2ef84cac937d377de89b721f8" ], "author": { "name": "Oleg A. Arkhangelsky", "email": "sysoleg@yandex.ru", "time": "Sat Dec 03 15:18:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Dec 03 15:18:19 2011 +0400" }, "message": "bgpd: fix memory leak for extra attributes\n\nthis fixes commit b881c7074bb698aeb1b099175b325734fc6e44d2\n" }, { "commit": "2fbd6f5a62f654c59aec5e1707c859d6ed79c6b0", "tree": "cc70afc89da575cdb739d7e1723632e7b75b654c", "parents": [ "1727d2e2b939c8670d0f0e0d1a0e5eb0a8be2135" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Tue Feb 02 20:20:35 2010 +0100" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Nov 21 19:42:05 2011 +0400" }, "message": "bgpd: remove unused function bgp_bind_address\n\nbgp_bind_address is replaced with sockunion_bind.\n" }, { "commit": "1727d2e2b939c8670d0f0e0d1a0e5eb0a8be2135", "tree": "3bdfda661f96113d61eae25059608d468a8ea4cc", "parents": [ "17e52061bacec93e84324b23382e5ec61e1f16d0" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Tue Feb 02 20:18:23 2010 +0100" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Nov 21 19:41:59 2011 +0400" }, "message": "bgpd: fix update-source for IPv6 (BZ#548)\n\nif update-source was given as interface name, bgpd was unconditionally\ntrying to bind to an IPv4 address from that interface.\n\nchange function to find the best-matching (number of address bits)\nsame-family address on the interface.\n" }, { "commit": "3cf1288bfd855e339fe2283c79a3ef3746e61737", "tree": "bbc6600328c20861512c4e26928ffce4cf9c5878", "parents": [ "5c88f19d5b166c6afa8a9b8501badb785afa553b" ], "author": { "name": "Dylan Hall", "email": "dylan@deedums.com", "time": "Thu Oct 27 15:28:17 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Nov 15 21:35:11 2011 +0400" }, "message": "bgpd: fix \"nexthop-local unchanged\" (BZ#350)\n" }, { "commit": "5c88f19d5b166c6afa8a9b8501badb785afa553b", "tree": "98261a13d284bb6b3fe0028a3d17e50c763fc324", "parents": [ "4de148e5d6f6f7885b2c0952a236a3bc3ec36250" ], "author": { "name": "Chris Luke", "email": "chrisy@flirble.org", "time": "Tue Oct 18 17:26:51 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Nov 15 20:57:02 2011 +0400" }, "message": "bgpd: justify capabilities for TOS setting\n\nTo set the TOS bits on TCP connections, platforms that restrict\ncapabilities need the priv level to be raised before the sockopt\nis set, and this requires the ZCAP_NET_ADMIN priv.\n\n* bgp_main.c: update _caps_p to include ZCAP_NET_ADMIN\n* bgp_network.c\n * bgp_connect(): request ZPRIVS_RAISE/ZPRIVS_LOWER\n * bgp_listener(): request ZPRIVS_RAISE earlier\n" }, { "commit": "1758dbaa3b69bd6e95fb501c40f044f751557e76", "tree": "7021223a0aea1c052e831f1bc044bc3c49ad09ab", "parents": [ "267551879e57a5c590f9e12b3a7d6985b28b3dac" ], "author": { "name": "Sergey Y. Afonin", "email": "asy@altlinux.ru", "time": "Thu Oct 27 17:01:11 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Nov 15 20:45:17 2011 +0400" }, "message": "bgpd: revised fix to --dryrun (BZ#622)\n" }, { "commit": "267551879e57a5c590f9e12b3a7d6985b28b3dac", "tree": "aeb0f826f3ea541de99d0988794f1454ab3b9e35", "parents": [ "b4cd2421518be7e18046e974e25b9bf4cf769bd2" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 26 19:34:30 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 26 19:38:49 2011 +0400" }, "message": "bgpd: fix 2 more cases of length error reporting\n\n* bgp_attr.c (bgp_attr_originator_id, bgp_attr_cluster_list): provide\n required arguments to bgp_attr_malformed()\n" }, { "commit": "b4cd2421518be7e18046e974e25b9bf4cf769bd2", "tree": "43a94afcebc8b878040f771de5f0e542bb6bc440", "parents": [ "bbb04bf3bb03be27fbf17b6b3ee903b168201cf0" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 22 22:32:26 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 22 22:32:26 2011 +0400" }, "message": "bgpd: check AGGREGATOR attr flags (BZ#678)\n\n* bgp_attr.c\n * bgp_attr_aggregator(): check Optional/Transitive flag bits\n" }, { "commit": "bbb04bf3bb03be27fbf17b6b3ee903b168201cf0", "tree": "8db00c5a6db16254146e064bfb350f536cc90e02", "parents": [ "abc384f85b622471ef5ba6c86acc540856da05cf" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Oct 18 14:20:04 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 19 17:28:01 2011 +0400" }, "message": "bgpd: fix more regressions in attr flag checks\n\nCommit 05a4936b713b9882171d0f7fb20b8439df23939e fixed some of the\nattributes involved, but not all. This commit should do it.\n\n* bgp_attr.c\n * bgp_attr_originator_id()\n * bgp_attr_cluster_list()\n * bgp_mp_reach_parse()\n * bgp_mp_unreach_parse()\n" }, { "commit": "abc384f85b622471ef5ba6c86acc540856da05cf", "tree": "5bb225c251c3667b12e7b5cb08dd1455dde5b072", "parents": [ "565b828dc00cafd477dd69ce15f0f551ece67710" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Oct 18 13:55:07 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Oct 18 13:55:07 2011 +0400" }, "message": "bgpd: use bgp_attr_malformed()\n\nSome of the recent attribute flags/length checks copied from QRE use\nbgp_notify_send_with_data() directly, but master branch assumes\nusing bgp_attr_malformed().\n\n* bgp_attr.c\n * bgp_attr_med()\n * bgp_attr_local_pref()\n * bgp_attr_atomic()\n * bgp_attr_originator_id()\n * bgp_attr_cluster_list()\n * bgp_mp_reach_parse()\n * bgp_mp_unreach_parse()\n" }, { "commit": "565b828dc00cafd477dd69ce15f0f551ece67710", "tree": "e1d5c6c38f89b6d022339df14c9b5224de7c0ca9", "parents": [ "f8627ff1ef7642c8ee4758b1f046ef0d166dfbec" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 21:08:33 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:07:02 2011 +0400" }, "message": "bgpd: add flag checks for MP_(UN)REACH_NLRI\n\n* bgp_attr.[ch]\n * bgp_mp_reach_parse(): add extra arguments and a uniform flag\n check block\n * bgp_mp_unreach_parse(): idem\n * bgp_attr_parse(): provide extra arguments\n* bgp_mp_attr_test.c\n * parse_test(): justify respective calls\n" }, { "commit": "f8627ff1ef7642c8ee4758b1f046ef0d166dfbec", "tree": "60fa75de6532991858f718aebfcabc19a745f081", "parents": [ "0b83044b91d7ea50824cfd803d77213b9ff38ed9" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 16:52:20 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:03:56 2011 +0400" }, "message": "bgpd: fix spelling of CLUSTER_LIST\n" }, { "commit": "0b83044b91d7ea50824cfd803d77213b9ff38ed9", "tree": "a18f7841fa039c1236ef5ea4770c0f0a5b81d3b1", "parents": [ "d595b566bca1de8b026c469a31ae50f2aee11781" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 15:12:17 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:03:31 2011 +0400" }, "message": "bgpd: check CLUSTER_LIST attribute flags\n\n* bgp_attr.c\n * bgp_attr_cluster_list(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra arguments\n" }, { "commit": "d595b566bca1de8b026c469a31ae50f2aee11781", "tree": "1572e36687c8666c8f0c8519addc94f9d2c886af", "parents": [ "566b36ebf903fd873c974ba34c19097d8fb48ce4" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 15:08:54 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:02:55 2011 +0400" }, "message": "bgpd: check ORIGINATOR_ID attribute flags\n\n* bgp_attr.c\n * bgp_attr_originator_id(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra arguments\n" }, { "commit": "6d0732c8abad7ace509d033a41814ea03a3a1b16", "tree": "d20c537d0e16cb5245047d8ecd9990201a4fb3b6", "parents": [ "a5b228b3792937c93b589938a2545b9311b7938e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Sep 28 14:23:35 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:59:19 2011 +0400" }, "message": "IPv6 transport class suppport\n\nIPv6 supports the same concept of differentiated service for routing\nprotocols as IPv4, but like too many things, the standards committee\ndecided that having two names for the same thing wasn\u0027t good enough and\nintroduced a third more generic term transport class.\n\nThe socket option to set transport class works the same as IPv4, but the\narguments are different.\n\n* lib/sockopt.[ch]\n * setsockopt_ipv6_tclass(): new function\n* bgpd/bgp_network.c\n * bgp_connect(): set socket option\n * bgp_listener(): set socket option\n* ospf6d/ospf6_network.c\n * ospf6_set_transport_class(): new function\n * ospf6_serv_sock(): set socket option\n* ripngd/ripngd.c\n * ripng_make_socket(): set socket option\n" }, { "commit": "a5b228b3792937c93b589938a2545b9311b7938e", "tree": "59c22c60531b0fe2a4ceeb0d8cc1070af1312a9d", "parents": [ "21cc76941abc60b5b5ece0a71ace0b69d6f4572c" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 12 13:54:21 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 12 13:59:09 2011 +0400" }, "message": "bgpd: fix regression in improved attr flag checks\n\nCommit 2febf323411c1aed9d7694898f852ce2ef36a7e5 assumed every flag\nbit except optional/transitive/partial unset, which at times could\nnot be true for \"extended length\" bit.\n\n* bgp_attr.c\n * bgp_attr_origin(): exclude BGP_ATTR_FLAG_EXTLEN from comparison\n * bgp_attr_nexthop(): idem\n * bgp_attr_med(): idem\n * bgp_attr_local_pref(): idem\n * bgp_attr_atomic(): idem\n" }, { "commit": "21cc76941abc60b5b5ece0a71ace0b69d6f4572c", "tree": "a81b361e0771c7a3bcddebad35158edad00f219f", "parents": [ "a624cae2b210a0e81c80c473f86b73e2be169962" ], "author": { "name": "Peter Pentchev", "email": "roam@ringlet.net", "time": "Mon Sep 12 16:30:31 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 08 20:17:21 2011 +0400" }, "message": "bgpd: fix parsing of graceful restart cap. (#663)\n\n\"While setting up a testbed, I ran across a little problem in the\nparsing of the \"graceful restart\" BGP capability that resulted in\nQuagga not actually activating it for the peer in question - when\nthe peer sent a single AFI/SAFI block.\"\n\n* bgp_open.c\n * bgp_capability_restart(): actually process the last AFI/SAFI block\n" }, { "commit": "a624cae2b210a0e81c80c473f86b73e2be169962", "tree": "b229e5943b651405d5b2277ecb5fbcdc1a747354", "parents": [ "b84b62dfb6ee9daf46c9e4c2c372b179f33be44c" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 08 13:54:48 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 08 14:18:00 2011 +0400" }, "message": "bgpd: improve attr length error handling (BZ#679)\n\n* bgp_attr.c\n * bgp_attr_parse(): provide extra argument to bgp_attr_aggregator()\n * bgp_attr_local_pref(): use bgp_notify_send_with_data()\n * bgp_attr_atomic(): idem\n * bgp_attr_aggregator(): idem\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "b84b62dfb6ee9daf46c9e4c2c372b179f33be44c", "tree": "052307acd804e98d224bc4d3246f16c9d02fbad9", "parents": [ "2d42e68aa032ed2f11471aee444935918d35c8bb" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 15:47:25 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 14:11:13 2011 +0400" }, "message": "bgpd: improve attr flags checks\n\nDo not check each of the Optional/Transitive/Partial attribute\nflag bits, when their only valid combination is known in advance,\nbut still perform bit-deep error message logging. This change\nassumes unused (low-order) 4 bits of the flag octet cleared.\n\n* bgp_attr.c\n * bgp_attr_origin(): rewrite check\n * bgp_attr_nexthop(): idem\n * bgp_attr_med(): idem\n * bgp_attr_local_pref(): idem\n * bgp_attr_atomic(): idem\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "2d42e68aa032ed2f11471aee444935918d35c8bb", "tree": "a58e0b96bdb43fb6ed66a94afc0d44b737ca4c89", "parents": [ "214bcaa13e092d9fff8f233e62ba28ca7eefbc43" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 15:35:39 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 10:32:02 2011 +0400" }, "message": "bgpd: ignore 4 bits of attribute flags byte\n" }, { "commit": "214bcaa13e092d9fff8f233e62ba28ca7eefbc43", "tree": "eb429544fd7d6727f35cd3fc24b6426a6d577eb3", "parents": [ "bc3443ebf032b5fcc9e0ccb94641e4e899cd17d8" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 24 13:20:43 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 10:30:36 2011 +0400" }, "message": "bgpd: add missing \"partial\" flag checks (BZ#676)\n\nORIGIN handling function used to have \"partial\" bit check and recent\ncommits added it for NEXT_HOP, MULTI_EXIT_DISC and ATOMIC_AGGREGATE\ncases. This commit adds \"partial\" check for AS_PATH and LOCAL_PREF\ncases, which should leave attributes 1 through 6 inclusive completely\ncovered with attribute flags checks.\n\n* bgp_attr.c\n * bgp_attr_origin(): use bit-by-bit checks for better diagnostics\n * bgp_attr_aspath(): add flag check\n * bgp_attr_local_pref(): idem\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "bc3443ebf032b5fcc9e0ccb94641e4e899cd17d8", "tree": "06d6c8b912958c989ba59e45349e17a3f8d973ac", "parents": [ "0a28130d35bbba47faf47bf9451ba0eb195fcbb7" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 22 12:48:14 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 01:24:35 2011 +0400" }, "message": "bgpd: improve NEXT_HOP attribute checks (BZ#680)\n\n* lib/prefix.h\n * IPV4_CLASS_DE(): new helper macro\n* bgp_attr.c\n * bgp_attr_nexthop(): add check for \"partial\" bit, refresh flag error\n reporting, explain meaning of RFC4271 section 6.3 and implement it\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "0a28130d35bbba47faf47bf9451ba0eb195fcbb7", "tree": "94bcda95ba12a50a81aa7ea893d809ba237b2262", "parents": [ "42e6d745d105018a9469dabad65bd4cf942dcf3c" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Jul 17 19:33:21 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 29 22:19:08 2011 +0400" }, "message": "bgpd: rename SAFI 3 according to RFC4760\n\n- SAFI value 3 is reserved. It was assigned by RFC 2858 for a use\n that was never fully implemented, so it is deprecated by this\n document.\n\n* zebra.h: rename macro\n* bgp_fsm.c: (bgp_graceful_restart_timer_expire,\n bgp_graceful_stale_timer_expire, bgp_stop, bgp_establish): update\n* bgpd.c: (peer_nsf_stop): update\n* bgp_open.c: (bgp_capability_vty_out): SAFI 3 isn\u0027t a recognized case\n any more\n" }, { "commit": "42e6d745d105018a9469dabad65bd4cf942dcf3c", "tree": "9e653fe2e44d2e3f8510fcb8451931e3b6153ebc", "parents": [ "beb1ca03bfe707d6d1fcad21fcbaa63af49c82f8" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 29 22:14:11 2011 +0400" }, "message": "bgpd: more SAFI fixes\n\n(with resolved conflict in bgpd/bgp_packet.c)\n\nTwo macros resolving to the same integer constant broke a case block and\na more thorough merge of BGP_SAFI_VPNV4 and BGP_SAFI_VPNV6 was\nperformed.\n\n* bgpd.h: MPLS-labeled VPN SAFI is AFI-independent, switch to single\n* macro\n* bgp_capability_test.c: update test data\n* bgp_mp_attr_test.c: idem\n* bgp_route.c: (bgp_maximum_prefix_overflow, bgp_table_stats_vty) update\n macro and check conditions (where appropriate)\n* bgp_packet.c: (bgp_route_refresh_send, bgp_capability_send,\n bgp_update_receive, bgp_route_refresh_receive): idem\n* bgp_open.c: (bgp_capability_vty_out, bgp_afi_safi_valid_indices,\n bgp_open_capability_orf, bgp_open_capability): idem\n* bgp_attr.c: (bgp_mp_reach_parse, bgp_packet_attribute,\n bgp_packet_withdraw): idem\n" }, { "commit": "beb1ca03bfe707d6d1fcad21fcbaa63af49c82f8", "tree": "78ffcd5ec7e9bb80e92c108f5ca0268ec6cff262", "parents": [ "48f99b0c2bfed8d3880732d188e1d5964f575ee4" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jul 13 16:53:13 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 29 22:07:54 2011 +0400" }, "message": "bgpd: fix SAFI for for MPLS labeled VPN-IPv6\n\n* bgpd.h: change value of BGP_SAFI_VPNV6 to 128 (RFC4659, BZ#659)\n* bgp_route.c: (bgp_table_stats_vty) fix length argument to strncmp()\n" }, { "commit": "4b4e07d2d83bdbe46ccf4b4a2fd2aa3842370098", "tree": "dde2abd7124f6d89e7d4695482f1abb8f4a0a447", "parents": [ "51abba509a0997f05427a8acbe74dd07d8d6026e" ], "author": { "name": "Dmitrij Tejblum", "email": "tejblum@yandex-team.ru", "time": "Wed Sep 21 23:13:22 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:46:04 2011 +0400" }, "message": "bgpd: don\u0027t be confused by \"unspecific\" subcode in the NOTIFY message.\n\n* bgp_debug.c (bgp_notify_open_msg, bgp_notify_update_msg,\n bgp_notify_cease_msg, bgp_notify_capability_msg): add messages for\n \"unspecific\" subcode.\n" }, { "commit": "e6ec1c3648cf3304c1a36341487659aadb9dce95", "tree": "de881144ddce2cdf272a36b0c8e94030b4379b90", "parents": [ "7ccf5e59c13773097dd551b8a7384b99b7f46927" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 10 21:50:53 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:43:15 2011 +0400" }, "message": "bgpd: spelling\n" }, { "commit": "7ccf5e59c13773097dd551b8a7384b99b7f46927", "tree": "205ee10231ebf765cf3097c5578c78c0d302a268", "parents": [ "171c9a996dd75a8b9aa596288c974f9ac0fbc5d6" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 10 16:53:30 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:43:03 2011 +0400" }, "message": "bgpd: spelling\n" }, { "commit": "9eba2ada189597fcb39c806bbbed414fecf20623", "tree": "59a59ae323a245579c24880d90332070538304aa", "parents": [ "2cfadf09a810e3b660a47a1eb898d0d7c8813c08" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 20 14:43:50 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:21:27 2011 +0400" }, "message": "bgpd: check ATOMIC_AGGREGATE attr flags (BZ#678)\n\n* bgp_attr.c\n * bgp_attr_atomic(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra argument\n" }, { "commit": "2cfadf09a810e3b660a47a1eb898d0d7c8813c08", "tree": "135d9df7af95fed3ffaaa380a22c4a93897f5263", "parents": [ "0ea968d21f194b3960a73aa47a5b06f160632907" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 20 10:54:25 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:19:44 2011 +0400" }, "message": "bgpd: check MULTI_EXIT_DISC attr flags (BZ#677)\n\n* bgp_attr.c\n * bgp_attr_med(): add checks for \"optional\", \"transitive\" and\n \"partial\" bits, log each error condition independently\n" }, { "commit": "0ea968d21f194b3960a73aa47a5b06f160632907", "tree": "61f7a046e2a1124f55d8ce9134984371cfd64ab1", "parents": [ "1212dc1961e81d5ef6e576b854e979ea29284f51" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Sep 19 16:30:47 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:15:56 2011 +0400" }, "message": "bgpd: check LOCAL_PREF attribute flags (BZ#674)\n\n* bgp_attr.c\n * bgp_attr_local_pref(): accept extra argument, add checks for\n \"optional\" and \"transitive\" bits, log each error condition\n independently\n * bgp_attr_parse(): provide extra argument\n" }, { "commit": "1212dc1961e81d5ef6e576b854e979ea29284f51", "tree": "bc27c64ae0463c1787d641f2946b3e64f24126d3", "parents": [ "d68ab1009f42c5ed62f7c6b0b5700f5f0469a35b" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Mon Sep 12 13:27:52 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:07:07 2011 +0400" }, "message": "bgpd: add useful notification logs (BZ#616)\n\n* bgp_packet.c\n * bgp_notify_send_with_data(): add calls to zlog_info()\n" }, { "commit": "d68ab1009f42c5ed62f7c6b0b5700f5f0469a35b", "tree": "155fac87e799841406a0785115a0e0fa4c5a0709", "parents": [ "5fdaa04e635fdef7deca9bdfe1be4b60ec90add6" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Tue Jul 12 20:09:18 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:05:30 2011 +0400" }, "message": "bgpd: consistent log msg format (BZ#565)\n" }, { "commit": "94431dbc753171b48b5c6806af97fd690813b00a", "tree": "463b917f9f80236be01e4502863b34ae2d52b53d", "parents": [ "a0bf59bcac8b40c3f83e7f2e7f65087ece6acfc7" ], "author": { "name": "CROSS", "email": "info@codenomicon.com", "time": "Mon Sep 26 13:17:05 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Sep 26 18:46:16 2011 +0400" }, "message": "bgpd: CVE-2011-3327 (ext. comm. buffer overflow)\n\nThis vulnerability (CERT-FI #513254) was reported by CROSS project.\nThey have also suggested a fix to the problem, which was found\nacceptable.\n\nThe problem occurs when bgpd receives an UPDATE message containing\n255 unknown AS_PATH attributes in Path Attribute Extended Communities.\nThis causes a buffer overlow in bgpd.\n\n* bgp_ecommunity.c\n * ecommunity_ecom2str(): perform size check earlier\n" }, { "commit": "036a6e6cf63a1046ab260d090719b305069288eb", "tree": "638b920464ce82b188e32013f768d6f5d7b1a6dd", "parents": [ "8dd1a8daae0b15065d54c46f82d44d21aa7a2320", "b881c7074bb698aeb1b099175b325734fc6e44d2" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jul 29 18:16:25 2011 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jul 29 18:16:25 2011 +0100" }, "message": "Merge branch \u0027attr-errors\u0027\n\nContains BGP fixes:\n\n- set extcommunity crash: tihs patch tries to make the refcounting more robust\n but does not fully solve the problem, sadly.\n- BGP attribute error handling: Little testing.\n" } ], "next": "01d7ff0a2166a422c56bd26f04fc22832a9e690b" }