)]}' { "log": [ { "commit": "d8a4e42b7d19a87eacc00c825e913907a58f39ee", "tree": "2d0777bfbef0e77ca1722fe0e7b2591ef89d4102", "parents": [ "b0145ddb4bf75d2c8853aa3d0bc7c522f4f17531" ], "author": { "name": "JR Rivers", "email": "jrrivers@cumulusnetworks.com", "time": "Thu Sep 13 17:17:36 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 25 10:15:58 2012 -0700" }, "message": "lib: improve fletcher checksum validation\n\nOVERVIEW\n\nThe checksum used in OSPF (rfc2328) is specified in rc905 annex B. There is an\nsample implementation in rfc1008 which forms the basis of the quagga\nimplementation. This algorithm works perfectly when generating a checksum;\nhowever, validation is a bit problematic.\n\nThe following LSA (generated by a non-quagga implementation) is received by\nquagga and marked with an invalid checksum; however, it passes both the rfc905\nand rfc1008 validation checks.\n\nstatic uint8_t lsa_10_121_233_29[] \u003d {\n 0x0e, 0x10, 0x02, 0x03,\n 0x09, 0x00, 0x35, 0x40,\n 0x0a, 0x79, 0xe9, 0x1d,\n 0x80, 0x00, 0x00, 0x03,\n 0x00, 0x8a, 0x00, 0x1c,\n 0xff, 0xff, 0xff, 0xe0,\n 0x00, 0x00, 0x36, 0xb0\n};\n\nLS Type: Summary-LSA (IP network)\n LS Age: 3600 seconds\n Do Not Age: False\n Options: 0x02 (E)\n Link-State Advertisement Type: Summary-LSA (IP network) (3)\n Link State ID: 9.0.53.64\n Advertising Router: 10.121.233.29 (10.121.233.29)\n LS Sequence Number: 0x80000003\n LS Checksum: 0x008a\n Length: 28\n Netmask: 255.255.255.224\n Metric: 14000\n\nYou\u0027ll note that one byte of the checksum is 0x00; quagga would calculate the\nchecksum as 0xff8a.\n\nIt can be argued that the sourcing implementation generates an incorrect\nchecksum; however, rfc905 indicates that, for 1\u0027s complement arithmetic, the\nvalue 255 shall be regarded as 0, thus either values are valid.\n\nEXPLANATION\n\nThe quagga ospfd and ospf6d implementations operate by copying the PDU\u0027s\nexisting checksum in a holding variable, calculating the checksum, and comparing\nthe resulting checksum to the original. As a note, this implementation has the\nside effect of modifying the contents of the PDU.\n\nEvaluation of both rfc905 and rfc1008 shows that checksum validation should\ninvolve calculating the sum over the PDU and checking that both resulting C0 and\nC1 values are zero. This behavior is enacted in the rfc1008 implementation by\ncalling encodecc with k \u003d 0 (checksum offset); however, this functionality had\nbeen omitted from the quagga implementation.\n\nPATCH\n\nThis patch adds the ability to call the quagga\u0027s fletcher_checksum() with a\nchecksum offset value of 0xffff (aka FLETCHER_CHECKSUM_VALIDATE) which returns\nthe sum over the buffer (a value of 0 indicates a valid checksum). This is\nsimilar to the mechanism in rfc1008 when called with k \u003d 0. The patch also\nintroduces ospf_lsa_checksum_valid().\n\nospf6d had it\u0027s own implementation of the fletcher checksum in\nospf6_lsa_checksum(); it\u0027s the same algorithm as in fletcher_checksum(). This\npatch removes the local implementation in favor of the library\u0027s as well as creates\nand uses ospf6_lsa_checksum_valid().\n\nquagga\u0027s ISIS implementation suffers from the same problem; however, I do not\nhave the facilities to validate a fix to ISIS, thus this change has been left to\nthe ISIS maintainers. The function iso_csum_verify() should be reduced to\nrunning the fletcher checksum over the buffer using an offset of 0.\n\nSigned-off-by: JR Rivers \u003cjrrivers@cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nReviewed-by: Nolan Leake \u003cnolan@cumulusnetworks.com\u003e\nReviewed-by: Ayan Banerjee \u003cayan@cumulusnetworks.com\u003e\nReviewed-by: Shrijeet Mukherjee \u003cshm@cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "86f72dcba35f055b5344deeb5f057c2f1d9a291f", "tree": "b128af27119cf27a709423814709a5a0bde98bae", "parents": [ "f7e0db80693aea7f5fd3d8d4f00e97347c8d0ba5" ], "author": { "name": "Takashi Sogabe", "email": "sogabe@iij.ad.jp", "time": "Mon Jun 22 13:07:02 2009 +0900" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jun 22 12:21:22 2009 +0100" }, "message": "Convert ospf6d over to quagga_gettime() wrappers.\n" }, { "commit": "6ac29a51075def99217a4ab1015635db3b3e83ed", "tree": "1152b55eb3a2099c67a0ba8e62d7e41f07e00135", "parents": [ "1423c809cc4ddc2e013ba6264c49a11e5719c6f2" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Aug 15 13:45:30 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:58 2008 +0100" }, "message": "[trivia] finish off static\u0027ification of ospf6d and ripngd\n\n2008-08-15 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* {ospf6d,ripngd}/*: Finish job of marking functions as static, or\n\t exporting declarations for them, to quell warning noise with\n\t Quagga\u0027s GCC default high-level of warning flags. Thus allowing\n\t remaining, more useful warnings to be more easily seen.\n" }, { "commit": "1eb8ef2584833f18fb674e127d59cb5a7f771482", "tree": "f5b09d4781de9a9b08839fefb6530e64d2d2ec31", "parents": [ "5920990fecba7e2430af3cfaa8bcbaed40d0ba1a" ], "author": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "message": "2005-04-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global): Fix up list loops to match changes in lib/linklist,\n\t and some basic auditing of usage.\n\t* configure.ac: define QUAGGA_NO_DEPRECATED_INTERFACES\n\t* HACKING: Add notes about deprecating interfaces and commands.\n\t* lib/linklist.h: Add usage comments.\n\t Rename getdata macro to listgetdata.\n\t Rename nextnode to listnextnode and fix its odd behaviour to be\n\t less dangerous.\n\t Make listgetdata macro assert node is not null, NULL list entries\n should be bug condition.\n ALL_LIST_ELEMENTS, new macro, forward-referencing macro for use\n with for loop, Suggested by Jim Carlson of Sun.\n Add ALL_LIST_ELEMENTS_RO for cases which obviously do not need the\n \"safety\" of previous macro.\n\t LISTNODE_ADD and DELETE macros renamed to ATTACH, DETACH, to\n\t distinguish from the similarly named functions, and reflect their\n\t effect better.\n\t Add a QUAGGA_NO_DEPRECATED_INTERFACES define guarded section\n\t with the old defines which were modified above,\n\t for backwards compatibility - guarded to prevent Quagga using it..\n\t* lib/linklist.c: fix up for linklist.h changes.\n\t* ospf6d/ospf6_abr.c: (ospf6_abr_examin_brouter) change to a single\n\t scan of the area list, rather than scanning all areas first for\n\t INTER_ROUTER and then again for INTER_NETWORK. According to\n\t 16.2, the scan should be area specific anyway, and further\n\t ospf6d does not seem to implement 16.3 anyway.\n" }, { "commit": "c6487d61a9b7766f69718edbc484a6ad989bdef4", "tree": "2a896a8ebdd6e41edcd1b5917ce9dddefbb335fe", "parents": [ "529d65b3db6a2a79cbdf9ca3a1aa915ce5776286" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri Dec 24 06:00:11 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri Dec 24 06:00:11 2004 +0000" }, "message": "*.c: Change level of debug messages to LOG_DEBUG.\n" }, { "commit": "6639a04da2c5ac6bfa0d5eff006637fb6f1372ee", "tree": "8841c4f47f61c6a67703cefc265164f5666c3a79", "parents": [ "95e74e54bfd2fac8f6787b7c3670f7e057daa3e9" ], "author": { "name": "gdt", "email": "gdt", "time": "Fri Nov 05 18:42:27 2004 +0000" }, "committer": { "name": "gdt", "email": "gdt", "time": "Fri Nov 05 18:42:27 2004 +0000" }, "message": "2004-11-05 Phil Spagnolo \u003cphillip.a.spagnolo@boeing.com\u003e\n * ospf6_flood.c: When adding a thread to retransmit an lsa after\n rxmt_interval, the ospf6d used thread_add_event(). However,\n thread_add_event() executes immediately and ignores the delay parameter.\n This was causing unnecesary unicast LSU sends. Adding the thread has\n been changed to use thread_add_timer() which will expire after delay.\n After the fix results appear consistent with expectation.\n" }, { "commit": "52dc7ee65f8d887b0730abc0a5d44d27fc6ecafd", "tree": "a557339540c56dd3953c29a50ca0e48c1911efc8", "parents": [ "44983cf8a9c587dfbcad294b9dfe4dccbb68ba98" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu Sep 23 19:18:23 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu Sep 23 19:18:23 2004 +0000" }, "message": "Remove usage of evil list and listnode typedefs.\n" }, { "commit": "1e05838a4db178f25eef560d774cf63d7af6d3c4", "tree": "f87bdb34ec1337e390b885d5344f1a40c7dbb383", "parents": [ "863076db0f6ef0f9090abdfd9e2388db0bf02770" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Sep 01 21:36:14 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Sep 01 21:36:14 2004 +0000" }, "message": "Merge svn revision 975 from Zebra repository.\n" }, { "commit": "6861b307d6fd6d936d699b23ca4fb4c47180e068", "tree": "5f0550c15c4f4a25fb9bea4628cf12dbb67090eb", "parents": [ "69b4a810cd06a623d10678adbfd2d4342ef86547" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu Aug 26 18:19:59 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu Aug 26 18:19:59 2004 +0000" }, "message": "Merge svn revision 954 from Zebra cvs.\n" }, { "commit": "ccb59b11047c71430eb55ed58eda94865bab20c8", "tree": "c135d58534331ff4fd04223f512d317dbd4c8ed8", "parents": [ "3e0b3a56217dab13b26e7f7fd634e7450dde55e2" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Aug 25 09:10:37 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Aug 25 09:10:37 2004 +0000" }, "message": "SVN revisions 935-940 merge from Zebra CVS.\n" }, { "commit": "3b68735fc38871bdcc9fc19f38fab244f86e710b", "tree": "3a98be6997b0fc0e0bd211a877ab477cb7e3d328", "parents": [ "0de1cde6e602e7496628967aeb219cd28d4869a9" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu Aug 19 06:56:53 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu Aug 19 06:56:53 2004 +0000" }, "message": "Merge svn revisions 924 and 925 from Zebra CVS. Also remove useless\nospf6_lsdb prototype declaration from ospf6_lsa.h. Report sent to Yasuhiro\nOhara as well.\n" }, { "commit": "6452df092bf6b694ea62a0423ac242f10ab997f9", "tree": "087490eb5e58209ca207f28b626c4a4a84ad4c9c", "parents": [ "f841e02e16869481f4ac4cdfd2e8c941df815720" ], "author": { "name": "hasso", "email": "hasso", "time": "Sun Aug 15 05:52:07 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sun Aug 15 05:52:07 2004 +0000" }, "message": "SVN revisions 916-920 from Zebra. ABR support is almost done.\n" }, { "commit": "3b4cd3a9e89a5aace04a6a756bd0d23b7108fd83", "tree": "a15fe3959155a6ca5bd5a2f8e967f9fd39736975", "parents": [ "4845437528f395c75c1945dd80b140b7162e4667" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue May 18 19:28:32 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue May 18 19:28:32 2004 +0000" }, "message": "Update to latest (really :) ospf6d from Zebra repository and some tiny\nfixes.\n" }, { "commit": "4845437528f395c75c1945dd80b140b7162e4667", "tree": "a736220e69d96e0bb86b8c8b56e446241b04e093", "parents": [ "508e53e2eef3eefba4c1aa771529027fd4486ea8" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue May 18 19:14:52 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue May 18 19:14:52 2004 +0000" }, "message": "Forgot these.\n" } ] }