)]}' { "log": [ { "commit": "d227617a972bb20a974be68bea5032e692a0970f", "tree": "550ab426e690a34ffe8955eeccf2c93a616adef2", "parents": [ "0c5ed3ed00f630ae95dc2dfd4b5a938683e2a99e" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Tue Apr 10 16:57:23 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:27 2012 +0200" }, "message": "lib: remove last uses of sockunion_su2str()\n\nUse of this function is prone to memory leaks.\n\nThis fixes a memory accounting bug for vty denied connections.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "664711c1f4cc218073783ff6ce362093debd7b53", "tree": "5566b0c8b9d22de55772717ad6c701ea85b6241e", "parents": [ "6fd16207fee6d4d09f29ed7ecf26303a7220e473" ], "author": { "name": "Ulrich Weber", "email": "ulrich.weber@sophos.com", "time": "Wed Dec 21 02:24:11 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jan 02 19:13:28 2012 +0400" }, "message": "lib: fix some strtoul() use cases\n\n...otherwise 4294967295 is not a valid value on 32bit systems\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "1ed72e0b3a643fa1be6f1efa904965798a575cd1", "tree": "052341ede20e44b6aa23b1cd799d08f9b762c1c2", "parents": [ "eda9ba743c1eb7c32b2ae9b8989d3555f1890758" ], "author": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Sat Apr 28 22:14:10 2007 +0000" }, "committer": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Sat Apr 28 22:14:10 2007 +0000" }, "message": "[logging] Add new \"log timestamp precision\" command for subsecond timestamps\n\n2007-04-28 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* command.c: (config_write_host) Save \"log timestamp precision\"\n\t if not default value.\n\t (show_logging) Show configured timestamp precision.\n\t (config_log_timestamp_precision) Enable configuration of timestamp\n\t precision.\n\t (no_config_log_timestamp_precision) Restore default timestamp\n\t precision.\n\t (cmd_init) Install new timestamp precision commands.\n\t* log.h: (struct zlog) New timestamp_precision field.\n\t (quagga_timestamp) New function to generate a timestamp with the\n\t desired precision.\n\t (struct timestamp_control) Declare a structure for use in avoiding\n\t repeated duplicate calls to quagga_timestamp.\n\t* log.c: (quagga_timestamp) New function to generate a timestamp\n\t of the desired precision.\n\t (time_print) Call quagga_timestamp if the time hasn\u0027t already been\n\t calculated.\n\t (vzlog) Initialize a timestamp_control structure and pass it to\n\t time_print and vty_log.\n\t (zlog_backtrace) Fix 64-bit problem: cannot print size_t with %u.\n\t* vty.h: Must now include \"log.h\".\n\t (vty_log) Takes an additional struct timestamp_control argument.\n\t* vty.c: (vty_log_out) Use new struct timestamp_control and new\n\t quagga_timestamp function to print timestamps of the desired\n\t precision.\n\t (vty_time_print) Use new quagga_timestamp function.\n\t (vty_log) Accept new struct timestamp_control argument and pass it\n\t down to vty_log_out.\n" }, { "commit": "d4f0960cb23abc7528d7282fa08c68131eae5f93", "tree": "8a1bc8eac474c49ca76f27971c65f74fd5a74c89", "parents": [ "d5c925396629ef93cb38c2a63c3ac63911a341a6" ], "author": { "name": "paul", "email": "paul", "time": "Mon May 23 12:43:34 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon May 23 12:43:34 2005 +0000" }, "message": "2005-05-23 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* routemap.c: (rmap_onmatch_goto) fix crash if \u0027continue\u0027 command\n\t is used, which does not supply an argv[0].\n\t this is a backport candidate /iff/ the trailing ; is removed\n\t from VTY_GET_INTEGER_RANGE\n\t* vty.h: fix the VTY_GET macros, do {..} while(0) so they have\n\t correct function like syntax in usage.\n" }, { "commit": "8cc4198f9fabe5f10f5a773de1503d82f33a01fb", "tree": "77045da709ff66629bd12029b9ee17700360909b", "parents": [ "e7fe8c88c3d552400e1ae3ae9243319ab95d6f2d" ], "author": { "name": "paul", "email": "paul", "time": "Fri May 06 21:25:49 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri May 06 21:25:49 2005 +0000" }, "message": "2005-05-06 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* (general) extern and static\u0027ification of functions in code and\n\t header.\n\t Cleanup any definitions with unspecified arguments.\n\t Add casts for callback assignments where the callback is defined,\n\t typically, as passing void *, but the function being assigned has\n\t some other pointer type defined as its argument, as gcc complains\n\t about casts from void * to X* via function arguments.\n\t Fix some old K\u0026R style function argument definitions.\n\t Add noreturn gcc attribute to some functions, as appropriate.\n\t Add unused gcc attribute to some functions (eg ones meant to help\n\t while debugging)\n\t Add guard defines to headers which were missing them.\n\t* command.c: (install_node) add const qualifier, still doesnt shut\n\t up the warning though, because of the double pointer.\n\t (cmp_node) ditto\n\t* keychain.c: (key_str2time) Add GET_LONG_RANGE() macro, derived\n\t fromn vty.h ones to fix some of the (long) \u003c 0 warnings.\n\t* thread.c: (various) use thread_empty\n\t (cpu_record_hash_key) should cast to uintptr_t, a stdint.h type\n\t* vty.h: Add VTY_GET_IPV4_ADDRESS and VTY_GET_IPV4_PREFIX so they\n\t removed from ospfd/ospf_vty.h\n\t* zebra.h: Move definition of ZEBRA_PORT to here, to remove\n\t dependence of lib on zebra/zserv.h\n" }, { "commit": "cdb6ee94bc2b9d1b66cfa1adcc5acaccbd648e0f", "tree": "e2ddd54488f20a3402ce94fcc4fb337fb883f61c", "parents": [ "5c33349b3efff36a6acd36c6600b61e7cc2dbffc" ], "author": { "name": "ajs", "email": "ajs", "time": "Wed Feb 23 15:48:32 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Wed Feb 23 15:48:32 2005 +0000" }, "message": "2005-02-23 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* {vty.h,vty.c}: Remove vty_finish (duplicate of vty_reset).\n\t* isis_main.c: (reload) Call vty_reset instead of vty_finish (both\n\t functions were exactly the same).\n" }, { "commit": "9fc7ebf10b7bb638ddf6d1b4b2d562dd417866fc", "tree": "e2e49aa4ea2530be5b86df581ed1adcd37822f3a", "parents": [ "338b3424154af85b0762713796397d3f2345d54f" ], "author": { "name": "ajs", "email": "ajs", "time": "Wed Feb 23 15:12:34 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Wed Feb 23 15:12:34 2005 +0000" }, "message": "2005-02-23 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* buffer.h: Make the struct buffer and struct buffer_data structures\n\t private by moving them inside buffer.c. Add comments for all\n\t functions. Rename buffer_write as buffer_put (to be more consistent\n\t with the buffer_putc and buffer_putstr functions). Declare a new\n\t buffer_write function that is used to write data to a file descriptor\n\t and/or add it to the buffer queue. Remove unused function\n\t buffer_flush_vty_all. Create a new enum typedef buffer_status_t\n\t to be used as the return code for all buffer_flush* functions\n\t and buffer_write.\n\t* buffer.c: The struct buffer and struct buffer_data declarations\n\t are now private to this file. In conjunction with that, remove\n\t some unnecessary fields: struct buffer (alloc, unused_head,\n\t unused_tail, length), struct buffer_data (prev).\n\t (buffer_data_new) Removed: functionality incorporated into buffer_add.\n\t (buffer_data_free) Removed: use a macro BUFFER_DATA_FREE instead.\n\t (buffer_new) Use calloc instead of malloc + memset(zero).\n\t Supply an appropriate default size if the specified size is 0.\n\t (buffer_free) Eliminate code duplication by calling buffer_reset to\n\t free the contents of the buffer (and remove unused code related\n\t to unused_head).\n\t (buffer_empty,buffer_putc,buffer_putstr) Aesthetic change (make more\n\t compact).\n\t (buffer_reset) Use macro BUFFER_DATA_FREE. No need to set\n\t alloc and length to 0 (these fields have been removed).\n\t (buffer_add) Fix scope to be static. Call XMALLOC directly instead\n\t of calling removed buffer_data_new function. Simplify the logic\n\t (since it\u0027s now a singly-linked list instead of doubly-linked).\n\t (buffer_write) Renamed to buffer_put. Change to void, since return\n\t code of 1 was meaningless. No need to adjust length field, since\n\t it has been removed.\n\t (buffer_putw,buffer_flush,buffer_flush_vty_all,buffer_flush_vty)\n\t Remove unused functions.\n\t (buffer_flush_all) Rewrite using buffer_flush_available to eliminate\n\t a possible failure mode if IOV_MAX is less than the number of buffers\n\t on the queue.\n\t (buffer_flush_window) Incorporate logic from buffer_flush_vty.\n\t Log an error message if there is a writev error.\n\t (buffer_flush_available) Be more paranoid: check for case where\n\t buffer is already empty. Use new ERRNO_IO_RETRY macro, and use\n\t new enum for return codes. Simplify deletion logic (since it\u0027s\n\t now a singly-linked list).\n\t (buffer_write) New function for use with non-blocking I/O.\n\t* vty.h: Replace the struct vty sb_buffer field with a fixed-size\n\t (5-character) sb_buf field and an sb_len field, since using\n\t a struct buffer was inappropriate for this task. Add some useful\n\t comments about telnet window size negotiation.\n\t* vty.c: Include \u003carpa/telnet.h\u003e (no longer included by zebra.h).\n\t Remove VTY_OBUF_SIZE (instead use buffer_new default size).\n\t Make telnet_backward_char and telnet_space_char static const.\n\t (vty_out) Replace buffer_write with buffer_put.\n\t (vty_log_out) Check for I/O errors. If fatal, close the vty session.\n\t Consolidate 3 separate writes into a single write call.\n\t (vty_will_echo,vty_command,vty_next_line,vty_previous_line,\n\t vty_end_config,vty_describe_fold,vty_clear_buf,vty_serv_sock_addrinfo,\n\t vty_serv_sock_family,vty_serv_un,vty_use_backup_config,exec_timeout,\n\t vty_config_write,vty_save_cwd) Fix scope to static.\n\t (vty_new) Let buffer_new use its default buffer size.\n\t (vty_write) Fix signature: 2nd arg should be const char *.\n\t Replaced buffer_write with buffer_put.\n\t (vty_telnet_option) Fix minor bug (window height or width greater than\n\t 255 was broken). Use sb_buf and sb_len instead of removed sb_buffer\n\t (which was being used improperly).\n\t (vty_read) On error, use ERRNO_IO_RETRY to decide whether it\u0027s fatal.\n\t If the error is fatal, call buffer_reset so vty_close does not attempt\n\t to flush the data. Use new sb_buf and sb_len instead of sb_buffer\n\t to store the SB negotiation string.\n\t (vty_flush) When vty-\u003elines is 0, call buffer_flush_available instead\n\t of buffer_flush_window. Look at the return code from buffer_flush\n\t to detect I/O errors (and in that case, log an error message and\n\t close the vty).\n\t (vty_create) Fix scope to static. Initialize sb_len to 0 instead\n\t of creating sb_buffer.\n\t (vty_accept) Set socket nonblocking.\n\t (vtysh_accept) Use new set_nonblocking function instead of calling\n\t fcntl directly.\n\t (vtysh_flush) New function called from vtysh_read (after command\n\t execution) and from vtysh_write. This flushes the buffer\n\t and reacts appropriately to the return code (by closing the vty\n\t or scheduling further flushes).\n\t (vtysh_read) Check whether error is fatal using ERRNO_IO_RETRY.\n\t If not, just try again later. Otherwise, call buffer_reset before\n\t calling vty_close (to avoid trying to flush the buffer in vty_close).\n\t Fix logic to allow case where a command does not arrive atomically\n\t in a single read call by checking for the terminating NUL char.\n\t (vtysh_write) Use new vtysh_flush helper function.\n\t (vty_close) No need to call buffer_empty, just call buffer_flush_all\n\t in any case (it will check whether the buffer is empty).\n\t Do not free sb_buffer (since it has been removed).\n\t (vty_log_fixed) Use writev instead of write.\n\t* zebra.h: Do not include \u003carpa/telnet.h\u003e, since this is used only\n\t by lib/vty.c.\n" }, { "commit": "274a4a4447b13f89f8237156a887d05a24a73cc6", "tree": "d5c2c6ee94bb77ef4346bcc07834808a75210bfd", "parents": [ "5e76477456ce8bc4a1eeaccb5c5e1d3d99ab1300" ], "author": { "name": "ajs", "email": "ajs", "time": "Tue Dec 07 15:39:31 2004 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Tue Dec 07 15:39:31 2004 +0000" }, "message": "2004-12-07 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* bgp_main.c: (main) The 2nd argument to openzlog has been removed.\n\t* isis_main.c: (main) The 2nd argument to openzlog has been removed.\n\t* ospf6_main.c: (main) The 2nd argument to openzlog has been removed.\n\t Note that stdout logging will no longer be enabled by default when\n\t not running as a daemon.\n\t* ospf_main.c: (main) The 2nd argument to openzlog has been removed.\n\t* rip_main.c: (main) The 2nd argument to openzlog has been removed.\n\t* ripng_main.c: (main) The 2nd argument to openzlog has been removed.\n\t* main.c: (main) The 2nd argument to openzlog has been removed.\n\t So stdout logging will no longer be enabled by default.\n\t* irdp_main.c: (irdp_finish) Reduce severity of shutdown message\n\t from LOG_WARNING to LOG_INFO.\n\t* vtysh.c: Make several functions static instead of global.\n\t Added several commands to support destination-specific logging levels.\n\t (vtysh_completion) This function is unused, so comment it out.\n\t* basic.texi: Document new logging features. Separate basic config\n\t commands from basic VTY commands.\n\t* log.h: Replace struct zlog flags and maskpri fields with maxlvl\n\t array to support individual logging levels for each destination.\n\t Remove the 2nd argument to openzlog since the default logging config\n\t should be standardized inside the library. Replaced the\n\t zlog_set_flag and zlog_reset_flag functions with zlog_set_level.\n\t And zlog_set_file now requires an additional log_level argument.\n\t Declare zlog_proto_names for use inside command.c in the\n\t \"show logging\" command. Added defines useful for command\n\t construction.\n\t* log.c: (vzlog) Decide where to send the message based on the\n\t individual logging levels configured for each destination.\n\t Remove support for ZLOG_STDERR since it was never actually used.\n\t Support record-priority for terminal monitors.\n\t (zlog_signal,zlog_backtrace_sigsafe) Support destination-specific\n\t logging levels. Remove stderr support (was never used). Added\n\t support for terminal monitor logging.\n\t (_zlog_assert_failed) Increase message severity to LOG_EMERG.\n\t (openzlog) Remove 2nd argument since default config should be\n\t standardized in library. By default, terminal monitoring\n\t is set to debug, and all other logging is disabled.\n\t (zlog_set_flag,zlog_reset_flag) Removed.\n\t (zlog_set_level) New function to replace zlog_set_flag and\n\t zlog_reset_flag. Supports destination-specific logging levels.\n\t (zlog_set_file,zlog_reset_file) Support file-specific logging level.\n\t (zlog_rotate) Log an error message if fopen fails, and support\n\t new file-specific logging level.\n\t* command.h: Change DEFUN_CMD_FUNC_DECL and DEFUN_CMD_FUNC_TEXT so that\n\t command functions will be static instead of global. Remove\n\t declarations for config_exit and config_help. Define new macros\n\t DEFUNSH_ATTR, DEFUNSH_HIDDEN, and DEFUNSH_DEPRECATED so we can\n\t have deprecated commands in vtysh. Similarly, for completeness,\n\t define macros ALIAS_SH, ALIAS_SH_HIDDEN, and ALIAS_SH_DEPRECATED.\n\t Also, fix bug in ALIAS_ATTR macro (didn\u0027t matter because it\n\t was never used).\n\t* command.c: Make many functions static instead of global.\n\t (facility_name,facility_match,level_match) New functions\n\t to support enhanced destination-specific logging levels.\n\t (config_write_host) Support new destination-specific logging levels.\n\t (config_logmsg) Added new \"logmsg\" command to help test logging\n\t system.\n\t (show_logging) Added \"show logging\" command to show the current\n\t configuration of the logging system.\n\t (config_log_stdout_level) Support explicit stdout logging level.\n\t (no_config_log_stdout) Now takes optional LEVEL arg.\n\t (config_log_monitor,config_log_monitor_level,no_config_log_monitor)\n\t New commands creating new \"log monitor\" commands to set terminal\n\t monitoring log level.\n\t (config_log_file_level) Support explicit file logging level.\n\t (config_log_syslog_level) Support explicit syslog logging level.\n\t (config_log_facility,no_config_log_facility) Implement new\n\t \"log facility\" command.\n\t (cmd_init) Add hooks for new commands: \"show logging\", \"logmsg\",\n\t \"log stdout \u003clevel\u003e\", \"log monitor\", \"log monitor \u003clevel\u003e\",\n\t \"no log monitor\", \"log file \u003cfilename\u003e \u003clevel\u003e\",\n\t \"no log file \u003cfilename\u003e \u003clevel\u003e\", \"log syslog \u003clevel\u003e\",\n\t \"log facility\", and \"no log facility\".\n\t* vty.h: Added a \"level\" argument to vty_log so it can support\n\t \"log record-priority\". Declare new function vty_log_fixed for\n\t use in signal handlers.\n\t* vty.c: (vty_log,vty_log_out) Added a \"level\" argument to support\n\t \"log record-priority\" for vty terminal monitors.\n\t (vty_down_level) Use config_exit_cmd.func instead of calling\n\t config_exit directly (since command functions will now be static\n\t instead of global).\n\t (vty_log_fixed) New function to send terminal monitor messages\n\t from inside a signal handler.\n" }, { "commit": "5a64665039dc98c341fd8d50458ec2a72c5ebbf5", "tree": "e89689f085b7b8eed09a0558e2a80dadb4826033", "parents": [ "f3ae74cdf0768d0bd35f26f728f72439f2d8bd6f" ], "author": { "name": "ajs", "email": "ajs", "time": "Fri Nov 05 01:25:55 2004 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Fri Nov 05 01:25:55 2004 +0000" }, "message": "2004-11-04 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* vty.h: Remove fields in struct vty that were related to VTY_CONTINUE\n\t capabilities (that were used only in bgpd/bgp_route.c and are now\n\t removed). Also remove some other fields that were not being\n\t used at all.\n\t* vty.c: (vty_execute) Do not test for obsolete status values VTY_START\n\t and VTY_CONTINUE.\n\t (vty_read) Remove calls to vty-\u003eoutput_func since that was part\n\t of the VTY_CONTINUE infrastructure that has been removed.\n\t (vty_flush) Remove code to support VTY_START and VTY_CONTINUE.\n\t (vty_close) Remove code to cancel vty-\u003et_output thread, since that\n\t thread was never actually used.\n\t* bgp_route.c: Remove all code related to VTY_CONTINUE; this feature\n\t is deprecated because the output did not represent a single point\n\t in time. All output needs to be generated inline and buffered\n\t by the library code.\n\t (route_vty_out,route_vty_out_tag,damp_route_vty_out,\n\t flap_route_vty_out) Remove code to count number of lines of output,\n\t since this was only useful for VTY_CONTINUE behavior.\n\t (bgp_show_callback) Removed.\n\t (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.\n\t As a result, there\u0027s a new output_arg argument to this function.\n\t Make function static.\n\t (bgp_show) Make function static and add a new output_arg argument.\n\t Change all functions that call bgp_show or bgp_show_table to\n\t pass the new output_arg argument (that used to be passed inside\n\t vty-\u003eoutput_arg).\n\t* bgp_mplsvpn.c: Remove declarations of functions defined in\n\t bgp_route.c; these declarations belong in bgp_route.h.\n\t* bgp_route.h: Declare 3 global functions used in both bgp_route.c\n\t and in bgp_mplsvpn.c.\n" }, { "commit": "42d498658d85e36a7e5910955e7425b1fa2afa69", "tree": "4745462eb34a84e32ef5d3e1586a3cb5a983626e", "parents": [ "fd79ac918b8feaacebe9719adaac97dffb69137a" ], "author": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:22:18 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:22:18 2004 +0000" }, "message": "2004-10-13 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* (global) more const\u0027ification.\n\t* sockunion.c: (sockunion_su2str) buffer should be sized\n SU_ADDRSTRLEN.\n (sockunion_log) do not return stack variables, strdup buf before\n return.\n * vty.h: Fix up the VTY_GET_INTEGER macros. Testing caller supplied\n values against ULONG_MAX is daft, when caller probably has passed\n a type that can not hold ULONG_MAX. use a temporary long instead.\n Add VTY_GET_LONG, make VTY_GET_INTEGER_RANGE use it, make\n\t VTY_GET_INTEGER a define for VTY_GET_INTEGER_RANGE.\n" }, { "commit": "6ad96ea16ee54578391bb4ca88d047ac9d3654fc", "tree": "7a09427aaafcc48fe644ed4c2e6804005732b88f", "parents": [ "015253c3f14cacad85a761fae0259ad32f083d4a" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu Oct 07 19:33:46 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu Oct 07 19:33:46 2004 +0000" }, "message": "Make more strings const.\n" }, { "commit": "320ec10a24d8dd81d0aa011dc92e07877e4e02f8", "tree": "867cc29d5981b58bad9392cb7eb471daeb8250a1", "parents": [ "6c0f9a782a7be49de53b5ae00980990d96edbf03" ], "author": { "name": "hasso", "email": "hasso", "time": "Sun Jun 20 19:54:37 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sun Jun 20 19:54:37 2004 +0000" }, "message": "Removing code which looked at current dir for config file before attempting\nto read system one.\n" }, { "commit": "e8f2984c00d406781eff42db7afcdae5d5a6a366", "tree": "f8b4da099e7f06c25a6b27c873c9897b935b91a2", "parents": [ "5f5eab7833eef6aa0c95ee991bbdb65cfcc90011" ], "author": { "name": "paul", "email": "paul", "time": "Tue Aug 12 13:08:31 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Aug 12 13:08:31 2003 +0000" }, "message": "2003-08-12 Paul Jakma \u003cpaul@dishone.st\u003e\n\n2003-08-12 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * Makefile.am: redhat/zebra.* -\u003e redhat/quagga.*\n * configure.ac: Bump autoconf prerequisite to 2.53.\n dist name zebra -\u003e quagga.\n general Zebra -\u003e Quagga where appropriate (ie not zebra daemon).\n User and group zebra-\u003equagga.\n s/ZEBRA\\(_VERSION\\)/QUAGGA\\1/.\n * bgpd/bgp_main.c: s/ZEBRA\\(_VERSION\\)/QUAGGA\\1/\n * lib/command.c: Update banners and s/ZEBRA\\(_VERSION\\)/QUAGGA\\1/\n * lib/print_version.c: ditto\n * lib/version.h: s/ZEBRA\\(_VERSION\\)/QUAGGA\\1/ and bump version.\n Change ZEBRA_URL.\n * lib/smux.c: s/ZEBRA\\(_VERSION\\)/QUAGGA\\1/\n * lib/vty.h: Change Zebra.conf to Quagga.conf (integrated file)\n * ospf6d/ospf6{,_main}.c: s/ZEBRA\\(_VERSION\\)/QUAGGA\\1/\n * ospfd/ospf_main.c: s/ZEBRA\\(_VERSION\\)/QUAGGA\\1/\n" }, { "commit": "b21b19c5785487f2ff4a6ce38f45c2e6c35f4363", "tree": "c79f90ce7bd798b3f1391010153d9fdf7c7418f0", "parents": [ "0e4f190ebf5a26e4b66fb49cd74ae0ff0c7e0863" ], "author": { "name": "paul", "email": "paul", "time": "Sun Jun 15 01:28:29 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sun Jun 15 01:28:29 2003 +0000" }, "message": "2003-06-15 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* lib/vty.{c,h}: Remove vty layer depending on a \u0027master\u0027 global,\n\t pass the thread master in explicitly to vty_init. Sort out some\n\t header dependency problems with lib/command.h\n\t* zebra/: Move globals to struct zebrad. Update vty_init().\n\t* (.*)/\\1_main.c: update call to vty_init().\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }