)]}' { "log": [ { "commit": "0ddff5764f736c0a6d0d07b28bf98970624f263b", "tree": "b8bf91a9d3de885cf8da7f2fdafe356ff3e56c54", "parents": [ "aad356a49d6b00590b21751ea560c54f321c73c9" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Aug 05 10:26:30 2010 -0700" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Aug 03 16:56:42 2011 +0400" }, "message": "bgpd: use XCALLOC to allocate bgpd damp array\n\n* bgpd: (bgp_damp_parameter_set) The BGP reuse_index is not initialized\n properly. This would cause sporadic crash when disabling dampening. Use\n XCALLOC correctly and the right size array is initialized and no memset is\n needed.\n" }, { "commit": "65957886bfd0dd9d95360d8b015781fc82cc09be", "tree": "71352e214bd59277a50a43779bb2cbafbace6cc3", "parents": [ "2cd754de60210748e61069fed2c9d4086d24c21e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "message": "bgp: use monotonic clock for time of day\n\nBGP uses time() to get system time of day; but that value\nfluctuates with time adjustments from NTP. This can cause premature\nflapping of peer sessions and other failures.\n\nUse the system monotonic clock supported by Quagga thread library\nto avoid issue.\n\nSee: http://bugzilla.vyatta.com/show_bug.cgi?id\u003d4467\n\n* bgpd/bgp_fsm.c\n * bgp_uptime_reset(): dismiss function\n* bgpd/bgpd.c\n * bgp_clock(): new function\n* bgpd/bgp_damp.c\n * bgp_reuse_timer(): employ bgp_clock() instead of time(NULL)\n * bgp_damp_withdraw(): idem\n * bgp_damp_update(): idem\n * bgp_damp_scan(): idem\n * bgp_damp_info_vty(): idem\n * bgp_damp_reuse_time_vty(): idem\n* bgpd/bgp_fsm.c\n * bgp_routeadv_timer(): idem\n * bgp_stop(): idem\n * bgp_establish(): idem\n* bgpd/bgp_packet.c\n * bgp_update_receive(): idem\n* bgpd/bgp_route.c\n * bgp_update_rsclient(): idem\n * bgp_update_main(): idem\n * bgp_static_update_rsclient(): idem\n * bgp_static_update_main(): idem\n * bgp_static_update_vpnv4(): idem\n * bgp_aggregate_route(): idem\n * bgp_aggregate_add(): idem\n * bgp_redistribute_add(): idem\n* bgpd/bgp_snmp.c\n * bgpPeerTable(): idem\n * bgpTrapEstablished(): idem\n * bgpTrapBackwardTransition(): idem\n* bgpd/bgpd.c\n * peer_create(): idem\n * peer_uptime(): idem\n * bgp_master_init(): idem\n" }, { "commit": "50aef6f3b0e36b56cfa9f3d374be0c1d25c30c45", "tree": "5dce97de6229713c6c209cbb72abc1093fa1be58", "parents": [ "6e79f8bba438823d84b7464a9acc1e6fc9126a27" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Tue Jun 23 06:06:49 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 23 14:25:20 2009 +0100" }, "message": "Fix \"show ip bgp dampened-paths\" garbage output.\n\n* bgpd/bgp_damp.c: Make bgp_damp_reuse_time_vty() accept a buffer and\n length, rather than returning a local var buffer whose contents can get\n trounced. Remove duplicate BGP_UPTIME_LEN define.\n* bgpd/bgp_damp.h: bgp_damp_reuse_time_vty() prototype change.\n* bgpd/bgp_route.c: Provide bgp_damp_reuse_time_vty() with a buffer and\n length. Remove duplicate BGP_UPTIME_LEN define.\n\nThis problem was noticed in 2005...\n\n http://hibernia.jakma.org/~paul/patches/quagga-test.diff\n\n...but the fix didn\u0027t make it into the code.\n\nSigned-off-by: Chris Caputo \u003cccaputo@alt.net\u003e\n" }, { "commit": "e9dc9f247a668ece1b983cc964fec852c737bedd", "tree": "e8b865d140f9942655cd6d1190a87f3bade807ca", "parents": [ "ffa4e2c4712ddcb5085971aaf001f030723ee307" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:19:31 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:30 2009 +0100" }, "message": "[BGP/cleanup] make some damp function static\n" }, { "commit": "f3019aff2421d9c3d16498f22cd245e3f8948d4c", "tree": "e5630448e6bf0697cbdb35e42054ef84763bda21", "parents": [ "ef9b113e2d4c0d49bd7d61458fa9acc113658d2c" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Sun Aug 17 17:51:47 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:56:26 2008 +0100" }, "message": "[bgpd] remove useless check and return in bgp_config_write_damp\n\n2008-08-17 Stephen Hemminger \u003cstephen.hemminger@vyatta.com\u003e\n\n\t* bgp_damp.?: (bgp_config_write_damp) remove useless check\n\t of statically allocated config storage, and useless return\n\t value\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "fb982c25aa771b7c7425a3c3cce0a2cda0a715de", "tree": "74aa4dc86b04365d90a1030682796421b0eff011", "parents": [ "5921ef9aae3b5d6ff8663298f649fb9d76594acd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "message": "[bgpd] Trim memory usage of BGP routes\n\n2007-05-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: (struct info) Move less frequently used\n\t fields to a lazily allocated struct info_extra.\n\t Export bgp_info_extra_get\n\t* bgp_route.c: (bgp_info_extra_new) allocate extra\n\t (bgp_info_extra_free) Free damp info and the info_extra.\n\t (bgp_info_extra_get) Retrieve the info_extra of a struct\n\t info, allocating as required.\n\t (generally) adjust to use info-\u003eextra\n\t* bgp_damp.c: (generally) use bgp_info_extra_get to access\n\t dampinfo\n\t* bgp_attr.h: Move rarely allocated attributes from struct attr\n\t to a struct attr_extra, for a substantial saving in size of\n\t struct attr.\n\t* bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.\n\t (bgp_attr_extra_get) Get the attr_extra for a given struct\n\t attr, allocating it if needs be.\n\t (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.\n\t (generally) adjust to know about attr-\u003eextra.\n\t* bgp_debug.c: (bgp_dump_attr) ditto\n\t* bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.\n\t* bgp_nexthop.c: (generally) adjust to know about attr-\u003eextra\n\t and info-\u003eextra.\n\t* bgp_{packet,routemap,snmp,zebra}.c: ditto\n\t* lib/memtypes.c: Add MTYPE_ATTR_EXTRA and MTYPE_BGP_ROUTE_EXTRA\n" }, { "commit": "1a392d46db1917dfca2ddd06d7f0021396f8ecfa", "tree": "8dec4a2e583c9a1890fd62d647dcd5a27d14bde1", "parents": [ "ff7924f6c0437e2f3cc3710570414ae87a828724" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 07 00:24:49 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 07 00:24:49 2006 +0000" }, "message": "[bgpd] Handle pcount as flags are changed, fixing pcount issues\n\n2006-09-06 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Squash any and all prefix-count issues by\n\t abstracting route flag changes, and maintaining count as and\n\t when flags are modified (rather than relying on explicit\n\t modifications of count being sprinkled in just the right\n\t places throughout the code).\n\t* bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.\n\t (bgp_pcount_adjust) new, update prefix count as\n\t needed for a given route.\n\t (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status\n\t flag, calling previous function when appropriate.\n\t (general) Update all set/unsets of flags to use previous.\n\t Remove pcount_{dec,inc}rement calls.\n\t No need to unset BGP_INFO_VALID in places where\n\t bgp_info_delete is called, it does that anyway.\n\t* bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.\n\t* bgp_route.h: Export bgp_info_{un,}set_flag.\n\t Add a \u0027meta\u0027 BGP_INFO flag, BGP_INFO_UNUSEABLE.\n\t Move BGP_INFO_HOLDDOWN macro to here from bgpd.h\n" }, { "commit": "412008568bddbc9475eafba224d1a1703d6cca97", "tree": "8f9fc89b99f657af060904ae353ba07b9375321f", "parents": [ "0752ef0b2e9bbf6c7ab20ed0fe87840b3bd1b7f4" ], "author": { "name": "paul", "email": "paul", "time": "Thu Nov 03 12:52:18 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Nov 03 12:52:18 2005 +0000" }, "message": "2005-11-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via\n\t the struct bgp_damp_info, no need to guess by using\n\t bgp_get_default().\n" }, { "commit": "94f2b3923e9663d0355a829f22e4e31cf68ee7b8", "tree": "59c0291a76b1c97fbb089abb479307f19cdfd4c1", "parents": [ "7cad40007b9714dba65065916ea68577f9d3d6dd" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) The great bgpd extern and static\u0027ification.\n\t* bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code\n\t (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison\n\t warnings.\n\t* bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these\n\t used by various files which had their own private declarations,\n\t in the case of mplsvpn - incorrect.\n" }, { "commit": "200df115ea0ba6f54151d60fe5e9a7f6948de7c3", "tree": "2aedc0af80d2e805cdf2cefd50432423d2871216", "parents": [ "b31b813671d96ea9e96801508442a90f0ef503fa" ], "author": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "message": "2005-06-01 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd/(general) refcount struct peer and bgp_info, hence allowing us\n\t add work_queues for bgp_process.\n\t* bgpd/bgp_route.h: (struct bgp_info) Add \u0027lock\u0027 field for refcount.\n\t Add bgp_info_{lock,unlock} helper functions.\n\t Add bgp_info_{add,delete} helpers, to remove need for\n\t users managing locking/freeing of bgp_info and bgp_node\u0027s.\n\t* bgpd/bgp_table.h: (struct bgp_node) Add a flags field, and\n\t BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of\n\t nodes.\n\t* bgpd/bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock\n\t peer reference as appropriate.\n\t* bgpd/bgp_damp.c: Remove its internal prototypes for\n\t bgp_info_delete/free. Just use bgp_info_delete.\n\t* bgpd/bgpd.h: (struct bgp_master) Add work_queue pointers.\n\t (struct peer) Add reference count \u0027lock\u0027\n\t (peer_lock,peer_unlock) New helpers to take/release reference\n\t on struct peer.\n\t* bgpd/bgp_advertise.c: (general) Add peer and bgp_info refcounting\n\t and balance how references are taken and released.\n\t (bgp_advertise_free) release bgp_info reference, if appropriate\n\t (bgp_adj_out_free) unlock peer\n\t (bgp_advertise_clean) leave the adv references alone, or else\n\t call bgp_advertise_free cant unlock them.\n\t (bgp_adj_out_set) lock the peer on new adj\u0027s, leave the reference\n\t alone otherwise. lock the new bgp_info reference.\n\t (bgp_adj_in_set) lock the peer reference\n\t (bgp_adj_in_remove) and unlock it here\n\t (bgp_sync_delete) make hash_free on peer conditional, just in\n\t case.\n\t* bgpd/bgp_fsm.c: (general) document that the timers depend on\n\t bgp_event to release a peer reference.\n\t (bgp_fsm_change_status) moved up the file, unchanged.\n\t (bgp_stop) Decrement peer lock as many times as cancel_event\n\t canceled - shouldnt be needed but just in case.\n\t stream_fifo_clean of obuf made conditional, just in case.\n\t (bgp_event) always unlock the peer, regardless of return value\n\t of bgp_fsm_change_status.\n\t* bgpd/bgp_packet.c: (general) change several bgp_stop\u0027s to BGP_EVENT\u0027s.\n\t (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs\n\t along with a comment on it.\n\t* bgpd/bgp_route.c: (general) Add refcounting of bgp_info, cleanup\n\t some of the resource management around bgp_info. Refcount peer.\n\t Add workqueues for bgp_process and clear_table.\n\t (bgp_info_new) make static\n\t (bgp_info_free) Ditto, and unlock the peer reference.\n\t (bgp_info_lock,bgp_info_unlock) new exported functions\n\t (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,\n\t taking care of reference counts.\n\t (bgp_info_delete) do the opposite of bgp_info_add.\n\t (bgp_process_rsclient) Converted into a work_queue work function.\n\t (bgp_process_main) ditto.\n\t (bgp_processq_del) process work queue item deconstructor\n\t (bgp_process_queue_init) process work queue init\n\t (bgp_process) call init function if required, set up queue item\n\t and add to queue, rather than calling process functions directly.\n\t (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts\n\t (bgp_rib_withdraw) ditto\n\t (bgp_update_rsclient) let bgp_info_add manage refcounts\n\t (bgp_update_main) ditto\n\t (bgp_clear_route_node) clear_node_queue work function, does\n\t per-node aspects of what bgp_clear_route_table did previously\n\t (bgp_clear_node_queue_del) clear_node_queue item delete function\n\t (bgp_clear_node_complete) clear_node_queue completion function,\n\t it unplugs the process queues, which have to be blocked while\n\t clear_node_queue is being processed to prevent a race.\n\t (bgp_clear_node_queue_init) init function for clear_node_queue\n\t work queues\n\t (bgp_clear_route_table) Sets up items onto a workqueue now, rather\n\t than clearing each node directly. Plugs both process queues to\n\t avoid potential race.\n\t (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage\n\t bgp_info refcounts.\n\t (bgp_static_update_rsclient) ditto\n\t (bgp_static_update_main) ditto\n\t (bgp_static_update_vpnv4) ditto, remove unneeded cast.\n\t (bgp_static_withdraw) see bgp_static_withdraw_rsclient\n\t (bgp_static_withdraw_vpnv4) ditto\n\t (bgp_aggregate_{route,add,delete}) ditto\n\t (bgp_redistribute_{add,delete,withdraw}) ditto\n\t* bgpd/bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer\n\t reference\n\t (peer_rsclient_unset_vty) ditto, but unlock same reference\n\t* bgpd/bgpd.c: (peer_free) handle frees of info to be kept for lifetime\n\t of struct peer.\n\t (peer_lock,peer_unlock) peer refcount helpers\n\t (peer_new) add initial refcounts\n\t (peer_create,peer_create_accept) lock peer as appropriate\n\t (peer_delete) unlock as appropriate, move out some free\u0027s to\n\t peer_free.\n\t (peer_group_bind,peer_group_unbind) peer refcounting as\n\t appropriate.\n\t (bgp_create) check CALLOC return value.\n\t (bgp_terminate) free workqueues too.\n\t* lib/memtypes.c: Add MTYPE_BGP_PROCESS_QUEUE and\n\t MTYPE_BGP_CLEAR_NODE_QUEUE\n" }, { "commit": "fd79ac918b8feaacebe9719adaac97dffb69137a", "tree": "d0665eb68e60da9d6e364414cdb61830f19f33d3", "parents": [ "39db97e4e02eae08a1e18528367b6e9b07eb6a93" ], "author": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:06:08 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:06:08 2004 +0000" }, "message": "2004-10-13 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* (global) more const\u0027ification and fixups of types to clean up code.\n\t* bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,\n should use something like the VTY_GET_INTEGER macro, but without\n the vty_out bits..\n * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE\n (no_set_aggregator_as) ditto.\n * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is\n returned, add comments about troublesome return value.\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }