)]}' { "log": [ { "commit": "efb2c331e70eb3b913aeba3b62dfb54e68bd6de0", "tree": "4a43dfaa6d88dd8ab24673ff0fc1cf8200676220", "parents": [ "047d6a601f7842d445d478d51d90b006829df945" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 21:08:33 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:31:12 2011 +0400" }, "message": "bgpd: add flag checks for MP_(UN)REACH_NLRI\n\n* bgp_attr.[ch]\n * bgp_mp_reach_parse(): add extra arguments and a uniform flag\n check block\n * bgp_mp_unreach_parse(): idem\n * bgp_attr_parse(): provide extra arguments\n* bgp_mp_attr_test.c\n * parse_test(): justify respective calls\n" }, { "commit": "047d6a601f7842d445d478d51d90b006829df945", "tree": "efdae356c3f543c1e91449516f19910e468182a7", "parents": [ "452db84a79df073d30ecc0b3f7bdad4143020681" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 08 13:54:48 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:31:01 2011 +0400" }, "message": "bgpd: improve attr length error handling (BZ#679)\n\n* bgp_attr.c\n * bgp_attr_parse(): provide extra argument to bgp_attr_aggregator()\n * bgp_attr_local_pref(): use bgp_notify_send_with_data()\n * bgp_attr_atomic(): idem\n * bgp_attr_aggregator(): idem\n" }, { "commit": "452db84a79df073d30ecc0b3f7bdad4143020681", "tree": "9d98c4a6f049bf4c762425b52839aea893deb781", "parents": [ "cadc4cf05da46c44a2fb596260d4ef70d7ed6011" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 16:52:20 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:30:52 2011 +0400" }, "message": "bgpd: fix spelling of CLUSTER_LIST\n" }, { "commit": "cadc4cf05da46c44a2fb596260d4ef70d7ed6011", "tree": "c54fc4607821b6d24b272dc98de26a689c227710", "parents": [ "5de1719994fd3677b361ad71ac8bd16cf9c31706" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 15:12:17 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:28:36 2011 +0400" }, "message": "bgpd: check CLUSTER_LIST attribute flags\n\n* bgp_attr.c\n * bgp_attr_cluster_list(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra arguments\n" }, { "commit": "5de1719994fd3677b361ad71ac8bd16cf9c31706", "tree": "acc1d34f71ff6548c1d2b6be54cdd5ab1c6d09b5", "parents": [ "566941f953b025598134109c5f9547dc4fea287e" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 15:08:54 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:28:24 2011 +0400" }, "message": "bgpd: check ORIGINATOR_ID attribute flags\n\n* bgp_attr.c\n * bgp_attr_originator_id(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra arguments\n" }, { "commit": "566941f953b025598134109c5f9547dc4fea287e", "tree": "fceba1b20891876911422a2957339928cb585cd8", "parents": [ "395ec7f5ab794eb5205a7386b890ccb9b1313580" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 12 13:54:21 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:28:10 2011 +0400" }, "message": "bgpd: fix regression in improved attr flag checks\n\nCommit 2febf323411c1aed9d7694898f852ce2ef36a7e5 assumed every flag\nbit except optional/transitive/partial unset, which at times could\nnot be true for \"extended length\" bit.\n\n* bgp_attr.c\n * bgp_attr_origin(): exclude BGP_ATTR_FLAG_EXTLEN from comparison\n * bgp_attr_nexthop(): idem\n * bgp_attr_med(): idem\n * bgp_attr_local_pref(): idem\n * bgp_attr_atomic(): idem\n" }, { "commit": "395ec7f5ab794eb5205a7386b890ccb9b1313580", "tree": "300b6a9a988317a3f3853717d940915693931ee0", "parents": [ "e531d4a662749fdd2a2f83f16e0b1cd252b23ea1" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 15:47:25 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:27:55 2011 +0400" }, "message": "bgpd: improve attr flags checks\n\nDo not check each of the Optional/Transitive/Partial attribute\nflag bits, when their only valid combination is known in advance,\nbut still perform bit-deep error message logging. This change\nassumes unused (low-order) 4 bits of the flag octet cleared.\n\n* bgp_attr.c\n * bgp_attr_origin(): rewrite check\n * bgp_attr_nexthop(): idem\n * bgp_attr_med(): idem\n * bgp_attr_local_pref(): idem\n * bgp_attr_atomic(): idem\n" }, { "commit": "e531d4a662749fdd2a2f83f16e0b1cd252b23ea1", "tree": "7c67d7fa031219777feb9caf85821eca27006e4f", "parents": [ "19e7654a293cd76854eb5cf98707826efb639326" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 24 13:20:43 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:27:44 2011 +0400" }, "message": "bgpd: add missing \"partial\" flag checks (BZ#676)\n\nORIGIN handling function used to have \"partial\" bit check and recent\ncommits added it for NEXT_HOP, MULTI_EXIT_DISC and ATOMIC_AGGREGATE\ncases. This commit adds \"partial\" check for AS_PATH and LOCAL_PREF\ncases, which should leave attributes 1 through 6 inclusive completely\ncovered with attribute flags checks.\n\n* bgp_attr.c\n * bgp_attr_origin(): use bit-by-bit checks for better diagnostics\n * bgp_attr_aspath(): add flag check\n * bgp_attr_local_pref(): idem\n" }, { "commit": "19e7654a293cd76854eb5cf98707826efb639326", "tree": "b2ebdd87ace0f5721ac0075da4eee2181af63051", "parents": [ "17801d1e8bf377ec8e4962dda0293de935629903" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 15:35:39 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:27:32 2011 +0400" }, "message": "bgpd: ignore 4 bits of attribute flags byte\n" }, { "commit": "d1e2faa40e17fe8f3db591021994d2f5e8b11335", "tree": "4ca879fbf8ba3b7932c7b180f22d477dd9e3536a", "parents": [ "792b6fa2c40f820df07caa80fbc6ed9c4191ef9b" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Sep 28 14:23:35 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:13:28 2011 +0400" }, "message": "IPv6 transport class suppport\n\nIPv6 supports the same concept of differentiated service for routing\nprotocols as IPv4, but like too many things, the standards committee\ndecided that having two names for the same thing wasn\u0027t good enough and\nintroduced a third more generic term transport class.\n\nThe socket option to set transport class works the same as IPv4, but the\narguments are different.\n\n* lib/sockopt.[ch]\n * setsockopt_ipv6_tclass(): new function\n* bgpd/bgp_network.c\n * bgp_connect(): set socket option\n * bgp_listener(): set socket option\n* ospf6d/ospf6_network.c\n * ospf6_set_transport_class(): new function\n * ospf6_serv_sock(): set socket option\n* ripngd/ripngd.c\n * ripng_make_socket(): set socket option\n" }, { "commit": "a1afbc6e1d56b06409de5e8d7d984d565817fd96", "tree": "a45dfa998baab938e8373950b7bf4c7af60f6dc1", "parents": [ "3eca6f099d5a3aac0b66dfbf98fd8be84ea426b7" ], "author": { "name": "CROSS", "email": "info@codenomicon.com", "time": "Mon Sep 26 13:17:05 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Sep 26 18:39:37 2011 +0400" }, "message": "bgpd: CVE-2011-3327 (ext. comm. buffer overflow)\n\nThis vulnerability (CERT-FI #513254) was reported by CROSS project.\nThey have also suggested a fix to the problem, which was found\nacceptable.\n\nThe problem occurs when bgpd receives an UPDATE message containing\n255 unknown AS_PATH attributes in Path Attribute Extended Communities.\nThis causes a buffer overlow in bgpd.\n\n* bgp_ecommunity.c\n * ecommunity_ecom2str(): perform size check earlier\n" }, { "commit": "3eca6f099d5a3aac0b66dfbf98fd8be84ea426b7", "tree": "40bf575b7d85ba8869f022a07e3313708a8093bf", "parents": [ "c347846e4f917339fd7b4c122a343f93ef621c40" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 22 12:48:14 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Sep 25 18:18:25 2011 +0400" }, "message": "bgpd: improve NEXT_HOP attribute checks (BZ#680)\n\n* lib/prefix.h\n * IPV4_CLASS_DE(): new helper macro\n* bgp_attr.c\n * bgp_attr_nexthop(): add check for \"partial\" bit, refresh flag error\n reporting, explain meaning of RFC4271 section 6.3 and implement it\n" }, { "commit": "c347846e4f917339fd7b4c122a343f93ef621c40", "tree": "eb04d7554766c2609a0492d64bb8f01173d8bebc", "parents": [ "614da2bf57d7df965d41869d1aa8321210d6560e" ], "author": { "name": "Dmitrij Tejblum", "email": "tejblum@yandex-team.ru", "time": "Wed Sep 21 23:13:22 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Sep 25 18:17:50 2011 +0400" }, "message": "bgpd: don\u0027t be confused by \"unspecific\" subcode in the NOTIFY message.\n\n* bgp_debug.c (bgp_notify_open_msg, bgp_notify_update_msg,\n bgp_notify_cease_msg, bgp_notify_capability_msg): add messages for\n \"unspecific\" subcode.\n" }, { "commit": "ca22cc4cc397dac8f3bf57eca516360085d44214", "tree": "a3b604beff5f6bedfc128e49c8f48f6d713aeb11", "parents": [ "7d25f1883f9a391ad16ec57c06ae71df616b00d8" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 20 14:43:50 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Sep 25 18:17:24 2011 +0400" }, "message": "bgpd: check ATOMIC_AGGREGATE attr flags (BZ#678)\n\n* bgp_attr.c\n * bgp_attr_atomic(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra argument\n" }, { "commit": "7d25f1883f9a391ad16ec57c06ae71df616b00d8", "tree": "52e431c8280265b93d404f8693c59509e8a5f401", "parents": [ "d0511bd9b09a6952f18bf3a926de759638a5cda7" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 20 10:54:25 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Sep 25 18:17:03 2011 +0400" }, "message": "bgpd: check MULTI_EXIT_DISC attr flags (BZ#677)\n\n* bgp_attr.c\n * bgp_attr_med(): add checks for \"optional\", \"transitive\" and\n \"partial\" bits, log each error condition independently\n" }, { "commit": "d0511bd9b09a6952f18bf3a926de759638a5cda7", "tree": "6c6cd56ce610dad94c17e71b89780c5c914385b0", "parents": [ "dda8187956966b2cc977855603a5beeeada3cc76" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Sep 19 16:30:47 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Sep 25 18:16:51 2011 +0400" }, "message": "bgpd: check LOCAL_PREF attribute flags (BZ#674)\n\n* bgp_attr.c\n * bgp_attr_local_pref(): accept extra argument, add checks for\n \"optional\" and \"transitive\" bits, log each error condition\n independently\n * bgp_attr_parse(): provide extra argument\n" }, { "commit": "74ffab30c360e2a603247f574577b3a8a74db4b2", "tree": "0eb1be441937b698ef210ba7e57ca07822d1a0e0", "parents": [ "c8049c165cdab08cb8024881376080b58ebc9eae" ], "author": { "name": "Peter Pentchev", "email": "roam@ringlet.net", "time": "Mon Sep 12 16:30:31 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Sep 25 18:13:40 2011 +0400" }, "message": "bgpd: fix parsing of graceful restart cap. (#663)\n\n\"While setting up a testbed, I ran across a little problem in the\nparsing of the \"graceful restart\" BGP capability that resulted in\nQuagga not actually activating it for the peer in question - when\nthe peer sent a single AFI/SAFI block.\"\n\n* bgp_open.c\n * bgp_capability_restart(): actually process the last AFI/SAFI block\n" }, { "commit": "2e35e96a11ac7bdf82ad68056f94135dc41a0995", "tree": "772b8bd77b742ea01094f9a214775907dca5f1d7", "parents": [ "99dc8691caa8bd1eaf4d5784bdb72a10966f2007" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Mon Sep 12 13:27:52 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Sep 25 18:13:14 2011 +0400" }, "message": "bgpd: add useful notification logs (BZ#616)\n\n* bgp_packet.c\n * bgp_notify_send_with_data(): add calls to zlog_info()\n" }, { "commit": "6787978cc8c15b16fff3e6d6e09e02518dc045f2", "tree": "27a061e7e12e669bdfc3bd01fece5428ebf2a313", "parents": [ "71008de7c8d47e5163d103b0b509d4a899044014" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 10 21:50:53 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 10 21:50:53 2011 +0400" }, "message": "bgpd: spelling\n" }, { "commit": "71008de7c8d47e5163d103b0b509d4a899044014", "tree": "7bf914ae1f286fe86a00087e4b4cea2645b4aa89", "parents": [ "4f151e5cc6ac6cfb1042dc3e5a1139a9f3138d91" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 10 16:53:30 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 10 16:53:30 2011 +0400" }, "message": "bgpd: spelling\n" }, { "commit": "22aefb2270a0cd3b1ba0f309e136e0250bd0332e", "tree": "df302899aeccb76680ec98de2f466c37dc607455", "parents": [ "15b1d9d0b0f54b9afbfdb784d535b3761d5efde7" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Aug 09 14:42:58 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Aug 09 14:42:58 2011 +0400" }, "message": "bgpd: improve \"show ip bgp scan detail\"\n\n* bgp_nexthop.c (show_ip_bgp_scan_tables): access proper structure field\n in AF_INET6 case, handle ifindex NH type properly\n" }, { "commit": "15b1d9d0b0f54b9afbfdb784d535b3761d5efde7", "tree": "c01058a48d917cf5ccd523580f9e5285d4c6519b", "parents": [ "5990281d4e91e40e0e3cc9149e73c887a7119415" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 08 19:36:44 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 08 19:36:44 2011 +0400" }, "message": "bgpd: dismiss some zlookup checks\n\nbgp_nexthop_onlink(): zlookup is not used here at all\nbgp_nexthop_lookup_ipv6(): rely on the detection performed by \"query\"\n function (this also changes the fallback value to 0), reorder if-block\nbgp_nexthop_lookup(): idem\n" }, { "commit": "5990281d4e91e40e0e3cc9149e73c887a7119415", "tree": "05dc2cc5ac4adabe86174ab9efb9ea9e852f1722", "parents": [ "5c98c5a7b1d3d71ff40b477b246b859cd22ddeed" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 21:47:08 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 21:47:08 2011 +0400" }, "message": "bgpd: add \"show ip bgp scan detail\" command\n\n* bgp_nexthop.c: (show_ip_bgp_scan) transform into\n show_ip_bgp_scan_tables(), which uses inet_ntop() and can dump\n nexthops on request; (show_ip_bgp_scan_detail_cmd) new function\n" }, { "commit": "5c98c5a7b1d3d71ff40b477b246b859cd22ddeed", "tree": "957b31b1c50f75a08f157630803e1f26c27222c7", "parents": [ "0ddff5764f736c0a6d0d07b28bf98970624f263b" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 18:52:52 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 18:52:52 2011 +0400" }, "message": "bgpd: touch nexthop handling code\n\nbgp_nexthop_lookup_ipv6(): declare variables where they are actually\nused, drop no-op initialization (the field is already 0)\nbgp_nexthop_lookup(): ditto\nbgp_nexthop_check_ebgp(): rename to bgp_nexthop_onlink()\nbgp_nexthop_cache_changed(): rename to bgp_nexthop_cache_different()\n" }, { "commit": "0ddff5764f736c0a6d0d07b28bf98970624f263b", "tree": "b8bf91a9d3de885cf8da7f2fdafe356ff3e56c54", "parents": [ "aad356a49d6b00590b21751ea560c54f321c73c9" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Aug 05 10:26:30 2010 -0700" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Aug 03 16:56:42 2011 +0400" }, "message": "bgpd: use XCALLOC to allocate bgpd damp array\n\n* bgpd: (bgp_damp_parameter_set) The BGP reuse_index is not initialized\n properly. This would cause sporadic crash when disabling dampening. Use\n XCALLOC correctly and the right size array is initialized and no memset is\n needed.\n" }, { "commit": "f4ac0fee73100c6268365df31096a64443bfb93b", "tree": "81388aa90d1394d67ee5ffe61daeab19b2c3407c", "parents": [ "999a305c89b12b8d059f118bf01556b9a6fd62b3" ], "author": { "name": "Wataru Tanitsu", "email": "wataru@ate-mahoroba.jp", "time": "Fri Sep 10 09:47:56 2010 -0700" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 01 15:36:36 2011 +0400" }, "message": "bgpd: Fix display of unsigned attributes\n\n* bgp_route.c: (route_vty_out*) The local prefix, metric and weight values\n are all stored as uint32_t. Change the format to %u so that large values\n are not displayed as negative integers.\n" }, { "commit": "a8b79422aadf5dc821af6699e468379002cc61f9", "tree": "0ee82fbd4e2b90686f2cf49b1bca59678e58eb18", "parents": [ "fdc38db248a220dcb80ec0ba1f1981087213651d" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Mar 23 10:30:30 2011 +0000" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jul 18 10:39:02 2011 +0400" }, "message": "bgpd: Fix compile failure if IPv6 build was disabled.\n\n* bgp_route.c: ({no_,}ipv6_bgp_network_ttl_cmd) depends on ipv6_bgp_network\n which is HAVE_IPV6, so these should be too.\n (bgp_route_init) and the installs should be similarly ifdefed\n" }, { "commit": "fdc38db248a220dcb80ec0ba1f1981087213651d", "tree": "8b75aacb6638bdef8c18a75de85904056194d8fd", "parents": [ "4a1342a56c6fdb90d9af3109afa9442ff0b850d6" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Jul 17 19:33:21 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Jul 17 19:33:21 2011 +0400" }, "message": "bgpd: rename SAFI 3 according to RFC4760\n\n- SAFI value 3 is reserved. It was assigned by RFC 2858 for a use\n that was never fully implemented, so it is deprecated by this\n document.\n\n* zebra.h: rename macro\n* bgp_fsm.c: (bgp_graceful_restart_timer_expire,\n bgp_graceful_stale_timer_expire, bgp_stop, bgp_establish): update\n* bgpd.c: (peer_nsf_stop): update\n* bgp_open.c: (bgp_capability_vty_out): SAFI 3 isn\u0027t a recognized case\n any more\n" }, { "commit": "e81537d3be9f95d333d658329e5d69e6188b53c0", "tree": "5f91b0f1d2a0dae1671c788c7d7804b16adcd4cd", "parents": [ "87f011e5297ab9d3c599916800aab1198613071e" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "message": "bgpd: more SAFI fixes\n\nTwo macros resolving to the same integer constant broke a case block and\na more thorough merge of BGP_SAFI_VPNV4 and BGP_SAFI_VPNV6 was\nperformed.\n\n* bgpd.h: MPLS-labeled VPN SAFI is AFI-independent, switch to single\n* macro\n* bgp_capability_test.c: update test data\n* bgp_mp_attr_test.c: idem\n* bgp_route.c: (bgp_maximum_prefix_overflow, bgp_table_stats_vty) update\n macro and check conditions (where appropriate)\n* bgp_packet.c: (bgp_route_refresh_send, bgp_capability_send,\n bgp_update_receive, bgp_route_refresh_receive): idem\n* bgp_open.c: (bgp_capability_vty_out, bgp_afi_safi_valid_indices,\n bgp_open_capability_orf, bgp_open_capability): idem\n* bgp_attr.c: (bgp_mp_reach_parse, bgp_packet_attribute,\n bgp_packet_withdraw): idem\n" }, { "commit": "87f011e5297ab9d3c599916800aab1198613071e", "tree": "3d165036dd68dcf3eea1dd66f5d373fc15a86bf3", "parents": [ "ea15b20a7cb8e41e61c48e36a554c576ed6f2f91" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jul 13 16:53:13 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jul 13 16:53:13 2011 +0400" }, "message": "bgpd: fix SAFI for for MPLS labeled VPN-IPv6\n\n* bgpd.h: change value of BGP_SAFI_VPNV6 to 128 (RFC4659, BZ#659)\n* bgp_route.c: (bgp_table_stats_vty) fix length argument to strncmp()\n" }, { "commit": "ea15b20a7cb8e41e61c48e36a554c576ed6f2f91", "tree": "311dd5818509e860ef1917c550859f5503bfc1d8", "parents": [ "82a963a1b8d9066f5e3e24e98b65398d32a73876" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Tue Jul 12 20:09:18 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Jul 12 20:09:18 2011 +0400" }, "message": "bgpd: consistent log msg format (BZ#565)\n" }, { "commit": "e70e575a8cb1edcab2eedade04bb4ac31938bddf", "tree": "5a72f6c9d4f7a50ea2b40229b8b04adece6f67b0", "parents": [ "fc09716b81e67f2d06dc92ff7bcb1efdf18c4eec" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 05 00:41:59 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Jul 05 00:41:59 2011 +0400" }, "message": "bgpd: Remove AS Path limit/TTL functionality\n\n* draft-ietf-idr-as-pathlimit doesn\u0027t seem to have gone anywhere, and its\n author does not think it will make progress in IDR. Remove all support\n introduced for it, but leave stubs for the commands to avoid breaking\n any configurations.\n\n Basically reverts cecab5e9725792e60a5e4b473e238a14cd85815d.\n(cherry picked from commit c8f3fe3063cb9ff193b13011cfbda3e605395340)\n\nConflicts:\n\n\tbgpd/bgp_attr.c (caused by c8e7b895, resolved)\n" }, { "commit": "fc09716b81e67f2d06dc92ff7bcb1efdf18c4eec", "tree": "0685e19912029d28e8a0731091419e836423f24c", "parents": [ "f668053f1453d64296db6807101450ad749ba730" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Dec 05 17:17:26 2010 +0000" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jul 04 21:02:00 2011 +0400" }, "message": "bgpd/security: CVE-2010-1674 Fix crash due to extended-community parser error\n\n* bgp_attr.c: (bgp_attr_ext_communities) Certain extended-community attrs\n can leave attr-\u003eflag indicating ext-community is present, even though no\n extended-community object has been attached to the attr structure. Thus a\n null-pointer dereference can occur later.\n (bgp_attr_community) No bug fixed here, but tidy up flow so it has same\n form as previous.\n\n Problem and fix thanks to anonymous reporter.\n(cherry picked from commit 0c46638122f10019a12ae9668aec91691cf2e017)\n" }, { "commit": "16ac59798e0bafc5083ae4b3be2c3edd89a62e5f", "tree": "9a0288714317c886de2588d2c3a03b10b1cca8a1", "parents": [ "bbccf41f8e5fb83831da81a339a578a3d5fc5f4a" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Mon Jan 17 10:58:52 2011 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jul 04 21:02:00 2011 +0400" }, "message": "bgpd: VTY string fixes for debug commands\n\n* bgpd/bgp_debug.c: fix VTY strings for BGP debug commands to match\n correct syntax\n(cherry picked from commit 6e22b9017e1ae2ce61c383b1b2b63973207704ac)\n" }, { "commit": "bbccf41f8e5fb83831da81a339a578a3d5fc5f4a", "tree": "01495f12e5a9fa0cff3b1ddecb24bccb4975de35", "parents": [ "a1239bc50d26ce963352f8ddaa6c1382e437d286" ], "author": { "name": "Dmitrij Tejblum", "email": "tejblum@yandex-team.ru", "time": "Fri Jan 14 18:27:05 2011 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jul 04 21:02:00 2011 +0400" }, "message": "bgpd: fix handling of \"Unsupported Capability\"\n\n* bgp_packet.c: (bgp_notify_receive) justify the difference between\nBGP_NOTIFY_OPEN_UNSUP_PARAM and BGP_NOTIFY_OPEN_UNSUP_CAPBL cases, as\nit is explained in RFC5492, page 3, paragraph 1.\n\n\"Unsupported Capability\" error does not mean, that the peer doesn\u0027t\nsupport capabilities advertisement -- quite the opposite (if the peer\nwould not support capabilities advertisement, the code would be\n\"Unsupported Optional Parameter\"). Thus there is no reason to mark\nthe peer as one non-supporting capabilities advertisement.\n\nExample: suppose the peer is in fact IPv6-only, but we didn\u0027t configure\nanything address-family specific for it. Then, the peer would refuse\nthe session with \"Unsupported Capability\" code. If we internally set\nthe peer as non-supporting capabilities advertisement after that, we\nwill not be able to establish the session with it ever, even with a\nfixed configuration -- IPv6-only BGP session cannot be established\nwithout capabilities.\n\nIn practice an edge case would be seen as the same IPv6 peer working\nwith its \"neighbor\" block read from bgpd.conf, but not working, when\nslowly input in \"conf t\" mode.\n(cherry picked from commit c7aa8abd8788c3607ad0131f02e892cf92221e40)\n" }, { "commit": "dfc1d5caacfe0346499f2eceff18d56af0b85e2f", "tree": "a259da6db36b4174f35a638a9db10b2508d2b62c", "parents": [ "5195e17f8b49dc720252526a21afd7840240137b" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 08 18:51:37 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jul 04 21:02:00 2011 +0400" }, "message": "bgpd: fix community-list error message spelling\n\n* bgp_vty.c: (community_list_perror, show_ip_community_list_arg,\n show_ip_extcommunity_list_arg) fix spelling\n(cherry picked from commit b729294c8c5c6f2af8ddf6cfbea2374b6faabe9d)\n" }, { "commit": "213b6cd9fb24381563d6d44c7ddc4700abfae676", "tree": "9ea3fcf3e773144f136c47db3236ecdd5d9a5e12", "parents": [ "08a7a91646a1ee317c402b421e3a7036a640bcf4" ], "author": { "name": "Vladimir L Ivanov", "email": "wawa@yandex-team.ru", "time": "Thu Oct 21 14:59:54 2010 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Oct 21 14:59:54 2010 +0400" }, "message": "bgpd: fix printed value of last-update timestamp\n\n* bgp_route.c: (route_vty_out_detail) calculate time value\n in a way, which works regardless of monotonic clock\n being used or not\n" }, { "commit": "4c9641ba4df276080c670e03f65b1d442660a50f", "tree": "15085df8068d8a3864224937eaa407c0484ff57f", "parents": [ "11d3fe9b9a327b3218a76b2b9001ace50c08de8c" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Thu Jul 22 13:20:55 2010 -0400" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Wed Oct 06 12:33:05 2010 -0400" }, "message": "bgpd, lib: adopt afi_t and safi_t in several places\n\n* bgpd/bgp_attr.c, bgpd/bgp_open.h, bgpd/bgp_route.c, lib/prefix.c,\n lib/prefix.h: Various integer types were being used where, if we\n had strict type checking, afi_t and safi_t would be required.\n\nSigned-off-by: G.Balaji \u003cbalajig81@gmail.com\u003e\n(cherry picked from commit c8af35ffa2dc79ff7d7ff00b1b61f1f50a100ab6)\n" }, { "commit": "d3ddb22e902bc4dc175ed6974515f6e14d9be931", "tree": "e0f0fa91e7814c4814dbbd60352cc073496d71f7", "parents": [ "cf8a831bcb53b60a7b5c4b26dda7646ebc7506d8" ], "author": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Fri Sep 17 10:47:49 2010 -0400" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Fri Sep 17 10:47:49 2010 -0400" }, "message": "Set from even if binfo-\u003eextra is NULL.\n\nbgpd/bgp_packet.c:bgp_update_packet(): When extracting the peer, don\u0027t\n fail to extract it because \"binfo-\u003eextra\" is NULL. While one should\n certainly avoid dereferencing binfo-\u003eextra, that\u0027s not a good reason\n not to use binfo-\u003epeer.\n\nFixes https://bugzilla.quagga.net/show_bug.cgi?id\u003d497.\nPatch by Eric Sobocinksi.\n" }, { "commit": "cddb8112b80fa9867156c637d63e6e79eeac67bb", "tree": "c8d8b4cb9d0ba1c2a7681c6da580874cf5a2b48e", "parents": [ "d64379e8f3c0636df53ed08d5b2f1946cfedd0e3" ], "author": { "name": "Chris Hall", "email": "chris.hall@highwayman.com", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "message": "bgpd: fix handling of AS path data\n\n* bgpd/bgp_aspath.c\n * assegments_parse(): add handling of AS4_PATH input, update bounds\n checks, add check for AS segment type\n * aspath_parse(): add handling of AS4_PATH input, expect\n assegments_parse() to do length checking\n * aspath_empty(): update for the new function prototype\n* bgpd/bgp_aspath.h: ditto\n* tests/aspath_test.c: ditto\n* bgpd/bgp_attr.c\n * bgp_attr_aspath(): add handling of AS4_PATH input, update flags\n checks, change returned type\n * bgp_attr_as4_path(): discard, superseded by bgp_attr_aspath()\n * bgp_attr_parse(): update respectively\n" }, { "commit": "d64379e8f3c0636df53ed08d5b2f1946cfedd0e3", "tree": "c34d8f271fe3be61cdfd23327ef73f2ede966924", "parents": [ "e26873fd8f0c4306eff65de94a45b4114fc81b98" ], "author": { "name": "Chris Hall", "email": "chris.hall@highwayman.com", "time": "Fri May 14 16:38:39 2010 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri May 14 16:38:39 2010 +0400" }, "message": "bgpd: tighten bounds checking in RR ORF msg reader\n\n* bgp_packet.c: (bgp_route_refresh_receive) add validation of\n \"Length\" (RFC5292) field value, check input stream bounds\n each time bytes are pulled from it\n" }, { "commit": "65957886bfd0dd9d95360d8b015781fc82cc09be", "tree": "71352e214bd59277a50a43779bb2cbafbace6cc3", "parents": [ "2cd754de60210748e61069fed2c9d4086d24c21e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "message": "bgp: use monotonic clock for time of day\n\nBGP uses time() to get system time of day; but that value\nfluctuates with time adjustments from NTP. This can cause premature\nflapping of peer sessions and other failures.\n\nUse the system monotonic clock supported by Quagga thread library\nto avoid issue.\n\nSee: http://bugzilla.vyatta.com/show_bug.cgi?id\u003d4467\n\n* bgpd/bgp_fsm.c\n * bgp_uptime_reset(): dismiss function\n* bgpd/bgpd.c\n * bgp_clock(): new function\n* bgpd/bgp_damp.c\n * bgp_reuse_timer(): employ bgp_clock() instead of time(NULL)\n * bgp_damp_withdraw(): idem\n * bgp_damp_update(): idem\n * bgp_damp_scan(): idem\n * bgp_damp_info_vty(): idem\n * bgp_damp_reuse_time_vty(): idem\n* bgpd/bgp_fsm.c\n * bgp_routeadv_timer(): idem\n * bgp_stop(): idem\n * bgp_establish(): idem\n* bgpd/bgp_packet.c\n * bgp_update_receive(): idem\n* bgpd/bgp_route.c\n * bgp_update_rsclient(): idem\n * bgp_update_main(): idem\n * bgp_static_update_rsclient(): idem\n * bgp_static_update_main(): idem\n * bgp_static_update_vpnv4(): idem\n * bgp_aggregate_route(): idem\n * bgp_aggregate_add(): idem\n * bgp_redistribute_add(): idem\n* bgpd/bgp_snmp.c\n * bgpPeerTable(): idem\n * bgpTrapEstablished(): idem\n * bgpTrapBackwardTransition(): idem\n* bgpd/bgpd.c\n * peer_create(): idem\n * peer_uptime(): idem\n * bgp_master_init(): idem\n" }, { "commit": "da88ea82acd70adf3bab641b2300ee24319da422", "tree": "81151de47e55067c4b7d9cd718c0e6c8ab07aa50", "parents": [ "2c2397059d4d4177ed4636c08aa476a138425dc8" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 17 13:14:28 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 17 13:14:28 2009 +0300" }, "message": "bgpd: code cleanup\n\n* bgpd/bgp_aspath.c\n * ashash: only used in one file, make static\n * aspath_count_numas(): dead code, sayonara\n* bgpd/bgpd.c\n * peer_nsf_stop(): only used in one file, make static\n* bgpd/bgp_packet.h\n * bgp_capability_receive(): add missing prototype for a\n global function\n" }, { "commit": "9e4ca89c3678431560a8259c75f8b5874d83d351", "tree": "178ca0de4c6fe5ecba90b51c5fb29c3e0b720cdb", "parents": [ "cc2dd9280c4456586080d1cf4537d26c02fa9a36" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 11:57:05 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 11:57:05 2009 +0300" }, "message": "bgpd: compile warnings cleanup\n\n* bgpd/bgp_fsm.c\n * bgp_clearing_completed(): only used in one file, can be static\n* bgpd/bgp_packet.c\n * afi2str(): sayonara\n * safi2str(): sayonara\n* bgpd/bgp_route.c\n * bgp_distance_reset(): sayonara\n* bgpd/bgp_zebra.c\n * bgp_ifindex_by_nexthop(): sayonara\n" }, { "commit": "1352ef32d70dcc102074814de63b5d08e591dd2d", "tree": "a0a4a40bf9a7726914f76cfa3a108529c7cc59df", "parents": [ "3949a60c350fea947d2701e2fe709b174ae7af16" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Dec 09 14:43:17 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 09 14:43:17 2009 +0300" }, "message": "lib: move check_bit into prefix common code\n\nMake one version of check prefix bit, and put it inline\nwith proper prototype. This gets rid of some macro\u0027s and also some\nassert() that can never happen on a non-broken compiler.\n\n* bgpd/bgp_table.c\n * CHECK_BIT(): sayonara\n * check_bit(): sayonara\n * SET_LINK(): sayonara\n * set_link(): make use of prefix_bit() instead of check_bit()\n * bgp_node_match(): idem\n * bgp_node_lookup(): idem\n * bgp_node_get(): idem\n* lib/prefix.h\n * prefix_bit(): new inline version of check_bit()\n* lib/table.c\n * CHECK_BIT(): sayonara\n * check_bit(): sayonara\n * SET_LINK(): sayonara\n * set_link(): make use of prefix_bit() instead of check_bit()\n * route_node_match(): idem\n * route_node_lookup(): idem\n * route_node_get(): idem\n* ospf6d/ospf6_lsdb.c\n * CHECK_BIT(): sayonara\n * ospf6_lsdb_lookup_next(): make use of prefix_bit() instead of\n CHECK_BIT()\n * ospf6_lsdb_type_router_head(): idem\n * ospf6_lsdb_type_head(): idem\n* ospf6d/ospf6_route.c\n * CHECK_BIT(): sayonara\n * ospf6_route_match_head() make use of prefix_bit() instead of\n * CHECK_BIT()\n" }, { "commit": "2eb445e1c22e36d07e2dbfd302ff438c4190b9fe", "tree": "82372e9d6fc630758fcf265cbdfdf3b826699cbd", "parents": [ "e6f148e6e06a37a65afb322eca6a3298b8ade8d2" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Dec 04 17:32:54 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Dec 04 17:32:54 2009 +0300" }, "message": "bgpd: work around warning in assegments_parse()\n" }, { "commit": "d1c21cabdbeeb4d12049f39579c602686eb94927", "tree": "aaaee477b15999c34175c80f6b3b1e99d2887150", "parents": [ "c4cf095e95ae66c1a7b87bca95e61e50fec746ee" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Aug 25 10:18:15 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 14:53:42 2009 +0100" }, "message": "bgpd: fix md5 set on listen sockets\n\n* bgp_network.c: (bgp_md5_set) Missing piece from earlier listener change\n did not get ported from Vyatta code into upstream. The list\n listener_sockets changed from (int *) to (struct bgp_listener *).\n" }, { "commit": "5bd5881838c22e075c3d0c245a8952a55e9dca38", "tree": "b0f011eef51409e492ef107aace3fefca4530f77", "parents": [ "62bed38d2f2c7317b5c97285d9fb935c5fe681e1" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Aug 06 21:05:47 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 13 10:19:24 2009 +0100" }, "message": "bgp: missing pieces from listener patch\n\n* bgp_network.c: (bgp_accept) The code in current git will crash as part of\n the revised listener code is missing. The new listener thread code passes\n a pointer to a bgp_listener structure, not the bgp pointer. The old code\n always got a NULL for bgp pointer, so that is now hard coded.\n" }, { "commit": "62bed38d2f2c7317b5c97285d9fb935c5fe681e1", "tree": "8fd4189ed9927b258cfc2fdbb20fcd48cbd08e9b", "parents": [ "3106a03215f5f09c2c0d427fa706fff52ef3cb37" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Aug 06 21:07:23 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 13 09:59:58 2009 +0100" }, "message": "bgp: compiler warning fix\n\n* bgp_filter.h: Gcc complains the function prototype is not correct because\n the function argument is using old K\u0026R style.\n" }, { "commit": "9d878775ff5c05afea522b60f014b88822d19e1b", "tree": "f1c7c45de602e2ac7ccd2c3c309e6568beff3af7", "parents": [ "5372510d109d87b94d6094d095dd4e0e02eaf32a" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Aug 05 16:25:16 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Aug 05 16:25:16 2009 +0100" }, "message": "bgpd: Fix mistakes in applying \u0027allow inbound connections to non-default view\u0027\n\n* bgpd.c: (peer_lookup_with_open) Bodged application of previous patch\n meant the second loop around bgp-\u003epeer wasn\u0027t included in the loop\n around bm-\u003ebgp as it was supposed to be. Fix..\n" }, { "commit": "4a5f432fa07f33da5ad05d18e4ba81d57b44af8e", "tree": "d8728f36ff64a1ba39d83de6aabfd3d4dc661447", "parents": [ "66bed4f4f0235c1eb6edb0a2f6bd4aaf47e5a7f8" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:24 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:24 2009 +0100" }, "message": "[bgpd] delete erroneous extra brace..\n" }, { "commit": "66bed4f4f0235c1eb6edb0a2f6bd4aaf47e5a7f8", "tree": "17488e5dc6eb4cc575f2aa006bfd87ec9c815222", "parents": [ "3de4277ba9b25ff03710d7c004bf708accffd5c7" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Tue Jul 28 11:26:14 2009 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:14 2009 +0100" }, "message": "bgpd: Workaround for invalid MBGP next hop\n\n* bgp_attr.c: (bgp_mp_reach_parse) There are some interoperability issues\n for MBGP (particularly IPv4 multicast NLRI) between different\n implementations. In order to get some next hops to install correctly in\n the BGP tables, it appears to be necessary to copy the multiprotocol next\n hop into the base next hop field. This is related to differences in RFC\n 2283 and RFC 2858.\n" }, { "commit": "2158ad2359a370dd349f4543a2d5d535bb5a8770", "tree": "afaf6922eecc2f155016e229d516b4e2487c7dbe", "parents": [ "fc4dc59d08589a887ac33a70d946eb7905541f5f" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:10:55 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:10:55 2009 +0100" }, "message": "bgpd/trivial: Fix indentation in previous\n" }, { "commit": "fc4dc59d08589a887ac33a70d946eb7905541f5f", "tree": "b142a18a28ebf915757aafe6bf5a139ec0f112bb", "parents": [ "3117b5c47df044f8b2197fff60641075394fdce5" ], "author": { "name": "Steve Hill", "email": "quagga@cheesy.sackheads.org", "time": "Tue Jul 28 17:54:35 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:06:39 2009 +0100" }, "message": "bgpd: Allow inbound connections to non-default view\n\n* bgpd.c: (peer_lookup) Search through all BGP instances for matches, not just\n the default instance, if no specific instance is given.\n (peer_lookup_with_open) same.\n" }, { "commit": "3117b5c47df044f8b2197fff60641075394fdce5", "tree": "0a25f9376ab96e21d9e161f9c9e156fbd5641d53", "parents": [ "cb9e0ceec988a059dd2269ebc54722c01afb7cca" ], "author": { "name": "Steve Hill", "email": "quagga@cheesy.sackheads.org", "time": "Tue Jul 28 17:50:00 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 17:50:00 2009 +0100" }, "message": "bgpd: fd leak in bgpd\n\n* bgp_fsm.c: I have found an fd leak in bgpd that is caused by the \u0027new\u0027\n Clearing state. I\u0027ve been seeing it from hold timer failures, but it can\n also be triggered by other things.\n\n When Hold_Timer_expired fires in Established state, a notify is sent and\n BGP_Stop event queued. The fsm then transitions into Clearing state.\n That is the problem; When the BGP_Stop event is serviced, the state table\n says to ignore it while in Clearing. Thus bgp_stop is not called and the\n fd leaks. Previously the peer would be in Idle state, which correctly\n handles the BGP_Stop event.\n\n Fix by making bgp_stop safe to call from Clearing state, without losing\n ClearingCompleted events, and then ensuring it is called prior to\n transition from Clearing-\u003eIdle.\n" }, { "commit": "736d440845c8c0cfdb56b86254887bab5fc7f3f5", "tree": "e1b7f27c18b03494509e9b9ef0a694b726630418", "parents": [ "ca87e1d37b3c30648e9bacb476a3c89729512f6d" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:59:10 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 15:02:07 2009 +0100" }, "message": "bgpd: Delete AS_CONFED_SEQUENCE when prepending an AS_SEQUENCE type segment\n\nAS_CONFED_SEQUENCE segment should always be deleted when prepending\n(e.g. with a route-map) an AS_SEQUENCE segment to an AS path. Otherwise,\nAS_CONFED_SEQUENCE will not be deleted later when updating EBGP peers (since\nit is not the leftmost segment) and will leak outside the confederation.\n" }, { "commit": "ca87e1d37b3c30648e9bacb476a3c89729512f6d", "tree": "d0911b72e7d4c3c94c88a65233ee8a7fa8a4c950", "parents": [ "30d205909c5a81cc306b161c16abff0fd7f566a7" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:28:35 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 14:49:33 2009 +0100" }, "message": "bgpd: Implement BGP confederation error handling (RFC5065, Par. 5)\n\nThis patch implements BGP confederation error handling in Quagga as described\nin RFC5065, paragraph 5.\n\n* bgp_aspath.c: (aspath_confed_check, aspath_left_confed_check) new functions\n* bgp_attr.c: (bgp_attr_aspath_check) apply previous and NOTIFY if there\u0027s\n a problem.\n" }, { "commit": "d023aec49f70156d2ed894a8fba65bcfa221ff02", "tree": "00ab5d69481c212b6ed2f350c5a5c7f430ef9208", "parents": [ "03621955d8ab0ea30024bd8fc83afda8e48db712" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Jul 21 16:27:21 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 10:04:38 2009 +0100" }, "message": "bgpd: start listener on first instance\n\nStart BGP listener only after first instance is started. This helps the\nsecurity if BGP is not used but daemon is started. It also addresses some\nissues like MD5 not working on listener unless IPV6 configured (because\nlistener was not in list); as well as compiler warnings.\n\n* bgp_network.c: (bgp_listener) listen socket creation consolidated here\n (bgp_socket) Use bgp_listener\n* bgpd.c: (bgp_get) call bgp_socket on creation of first struct bgp.\n (bgp_init) remove bgp_socket call.\n* memtypes.c: Add MTYPE_BGP_LISTENER\n" }, { "commit": "03621955d8ab0ea30024bd8fc83afda8e48db712", "tree": "0df6f032806430fdd7d70b5317779d146e9d6f58", "parents": [ "78b31d5cf511c400d7f09158a3d8863f1bf63c2a" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Jul 21 16:27:20 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 10:04:38 2009 +0100" }, "message": "bgpd: peer action table static/const\n\nbgpd.c: (various tables) only used in one place and are immutable.\n" }, { "commit": "9a1a331d63ae9db1912a1edb48c5c176454562f8", "tree": "d6da5f9ce7e6760f59a7fda7ceeb89877a3148c5", "parents": [ "5b40b1b57e1fad1caf579e032adf4e111128e486" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jul 27 12:27:55 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jul 27 12:27:55 2009 +0100" }, "message": "[bgpd] Restore ability of \u0027neighbor ... update-source\u0027 to take interface name\n\n* bgp_vty.c: (BGP_UPDATE_SOURCE_STR) Restore ability to accept arbitrary\n interface names for the \u0027neighbor ... update-source\u0027 command - shouldn\u0027t\n have been deleted.\n (BGP_UPDATE_SOURCE_STR) Add help for same.\n" }, { "commit": "638b70ba9893705bb3268aa00c25b8cb0e060b32", "tree": "51eaabdcfba4bfd4b5aa54c7a1b20298c9e2fc2a", "parents": [ "a294365797da8b72e51507cbf92dbc6940e5103b" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:25:16 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:44:41 2009 +0100" }, "message": "[bgp] Fix nexthop reachability check on confederations\n\n* bgp_route.c: (bgp_update_main) Nexthop reachability should be checked for\n confederations too in case a prefix is received from more than one\n confederation peers.\n" }, { "commit": "a294365797da8b72e51507cbf92dbc6940e5103b", "tree": "618569bcf8a1a5d4f7a0a8192692c5d3e27bbb02", "parents": [ "e8eb000e15e2bbe63467d7c056f2b21b72ba7bd6" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:02:04 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:02:04 2009 +0100" }, "message": "[bgpd] fix typo made by paul in previous commit\n" }, { "commit": "e8eb000e15e2bbe63467d7c056f2b21b72ba7bd6", "tree": "3e21cb6d66b0e1b8caaacc687ad30b83607d33a3", "parents": [ "e7cc3b383e5e9190aa7784554c605a3a661ebe2b" ], "author": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Tue Feb 17 12:14:23 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 13:15:32 2009 +0100" }, "message": "[bgpd] Avoid zombie accepted peer entries\n\nCurrently, when accepting the connection, it can be left as zombie, when the\npeer just initiates a connection, but never sends data (and the TCP\nconnection end packets are lost). This happens because for accepted\nconnections a temporary new peer entry is created until OPEN message is\nexchanged, and this temporary peer entry does not get the hold time\nparameter set at all.\n\n* bgp_network.c: (bgp_accept) Set hold time and keepalive values for ACCEPT\n peers.\n" }, { "commit": "e7cc3b383e5e9190aa7784554c605a3a661ebe2b", "tree": "3f7b254d2e47805d4a39c43bd0c6f459e512732a", "parents": [ "67b9467f6cad5097a3e4c6e49348be4d6c17a5bb" ], "author": { "name": "Nick Hilliard", "email": "nick@inex.ie", "time": "Tue Mar 17 22:14:25 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 11:34:27 2009 +0100" }, "message": "[bgpd] Small buffer overrun in bgp_clear_node_queue_init\n\n* bgp_route.c: (bgp_clear_node_queue_init) fix buffer\n overrun.\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "54a15182e05ca757db3bb90a4135e9f8fd3c84f2", "tree": "1d29ccce46cb362ae3b2b28b2a46a3dc017d5bf1", "parents": [ "62c9f504bdd4b09df6cf677e96367f3b31ef9dea" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:42:34 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 17:36:59 2009 +0100" }, "message": "[bgpd] Fix compiler warnings related to MD5\n\nThis patch fixes:\n\nbgp_network.c: In function \u0027bgp_md5_set\u0027:\nbgp_network.c:107: warning: cast from pointer to integer of different size\nbgp_network.c: In function \u0027bgp_socket\u0027:\nbgp_network.c:447: warning: cast to pointer from integer of different size\n" }, { "commit": "fd35b948dbb35674cd9ded431f94b59aeced40cc", "tree": "c236a99b492b19943916e0c117b0a2461333b422", "parents": [ "3fa3f957e70f594cc2c1cac03644ddf48554c178" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 16 19:27:32 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jul 17 11:19:46 2009 +0100" }, "message": "[bgpd] Bug #533: Fix crash with copy/pasted commands, inc \u0027no bgp ...\u0027\n\n* bgpd.c: Removal of (struct bgp *) from the master list was being left to\n bgp_free time. This meant there was a window of time between bgp_delete\n and refcounts hitting 0 (e.g. routes to be processed) where bgp_lookup\u0027s\n could return a deleted (struct bgp *).\n\n (bgp_delete) This is the logical place where a (struct bgp *) should lose\n its visibility, so move the deletion from the bgp-master list to here,\n from bgp_free.\n\n Many thanks to Fritz Reichmann for his thorough debugging of the problem\n and testing of fixes and Chris Caputo for his further analysis.\n" }, { "commit": "650f76c2e1b0b12e1c46fdd3be22c5f505245d83", "tree": "43322ab134a9e79ee65ca0300f2106f690b5c925", "parents": [ "439c52f19007badffc6707673121f5a76784e728" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 25 18:06:31 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 26 16:12:19 2009 +0100" }, "message": "[bgpd] Log a debug/update warning if filters are configured but don\u0027t exist\n\n* bgp_route.c: (bgp_{input,output}_filter) Log a debug warning if a route is\n received or sent and a filter name is configured for a prefix, as or\n distribute list but none is found - guaranteed configuration mistake.\n" }, { "commit": "2a71e9ce89c6f76c099dea67dddbe8da454d9de7", "tree": "8c53b6694e72751330fab48c02a793d67f2df24c", "parents": [ "014b670e02cc1f38e8e4e786269fc1787412f9b7" ], "author": { "name": "Tomasz Pala", "email": "gotar@pld-linux.org", "time": "Wed Jun 24 21:36:50 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jun 24 21:36:50 2009 +0100" }, "message": "[bgpd] Add \u0027show ip bgp view WORD neighbors IP (advertised|received)-routes\u0027\n\n* bgp_route.c: Was missing these commands.\n" }, { "commit": "014b670e02cc1f38e8e4e786269fc1787412f9b7", "tree": "f0fa74e181d556d2d83d8db480fab097da72bafa", "parents": [ "d13c3b4fcf802f904ef47ad82fdc9763fc704fdf" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Tue Jun 23 21:10:45 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Tue Jun 23 21:10:45 2009 +0400" }, "message": "[bgpd] review 32-bit AS-path hotfix for 0.99.12\n\nThe patch by Chris Caputo, which was used to prepare 0.99.12\nrelease, consists of three parts:\n\n1. memory allocation fix itself\n2. fix for warnings about constant variables\n3. fix for printf format specs (%d was used instead of %u)\n\nIt was confirmed later, that:\na. a much simpler bugfix was available for memory allocation\nb. committed version of the bugfix wasn\u0027t optimal CPU-wise\n\nAt this point I consider reasonable to revert the allocation\nportion of that patch and to replace it with the shorter\nversion, which is:\n\n-#define ASN_STR_LEN (5 + 1)\n+#define ASN_STR_LEN (10 + 1)\n\nOther two parts of Mr. Caputo\u0027s patch remain intact.\n" }, { "commit": "50aef6f3b0e36b56cfa9f3d374be0c1d25c30c45", "tree": "5dce97de6229713c6c209cbb72abc1093fa1be58", "parents": [ "6e79f8bba438823d84b7464a9acc1e6fc9126a27" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Tue Jun 23 06:06:49 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 23 14:25:20 2009 +0100" }, "message": "Fix \"show ip bgp dampened-paths\" garbage output.\n\n* bgpd/bgp_damp.c: Make bgp_damp_reuse_time_vty() accept a buffer and\n length, rather than returning a local var buffer whose contents can get\n trounced. Remove duplicate BGP_UPTIME_LEN define.\n* bgpd/bgp_damp.h: bgp_damp_reuse_time_vty() prototype change.\n* bgpd/bgp_route.c: Provide bgp_damp_reuse_time_vty() with a buffer and\n length. Remove duplicate BGP_UPTIME_LEN define.\n\nThis problem was noticed in 2005...\n\n http://hibernia.jakma.org/~paul/patches/quagga-test.diff\n\n...but the fix didn\u0027t make it into the code.\n\nSigned-off-by: Chris Caputo \u003cccaputo@alt.net\u003e\n" }, { "commit": "2b35ae41c2c5d39801c943fa740c72fc15613141", "tree": "b72600ce7970f5a62a344fd7fed3f5e53779b7a2", "parents": [ "b60668d092f1778395b6c10b406059b8cbf235b8" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Tue Jun 23 05:34:29 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 23 14:21:40 2009 +0100" }, "message": "Fixes to RFC2385/MD5 BGP\n\n* bgpd/bgp_network.c: Fix MD5 listen in IPv4 version of bgp_socket() by\n adding listen socket to listen_sockets list so that MD5 passwords can\n get set.\n* lib/sockopt.c: (sockopt_tcp_signature) Fix bogus \"% Error while applying\n TCP-Sig to session(s)\" / \"can\u0027t set TCP_MD5SIG option\" startup error\n messages by not returning error when there isn\u0027t one.\n" }, { "commit": "f7e0db80693aea7f5fd3d8d4f00e97347c8d0ba5", "tree": "b920d5309513724158ea477ae2c8b33190287e53", "parents": [ "c514adc61d56c3fb6fe5119a7b4b55c79a9c065d" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jun 22 11:30:47 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jun 22 11:30:47 2009 +0100" }, "message": "[bgpd] Fix \u0027update-source\u0027 command: It doesn\u0027t accept interface names\n\n* bgp_vty.c: BGP_UPDATE_SOURCE_STR define should only specify IP addresses,\n the underlying mechanisms won\u0027t do anything useful with interface names.\n Fix bug #527.\n" }, { "commit": "25f45887abf320401745dd433c4e82bfd6db5d4d", "tree": "a52835a9976899d1bef9ec7bff9eaa4972a6fa45", "parents": [ "c77cffdd69bf08ed54e390a3485cbd5024836a9a" ], "author": { "name": "Jeremy Jackson", "email": "jerj@coplanar.net", "time": "Mon Jan 12 16:06:12 2009 -0500" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 19 15:01:16 2009 +0100" }, "message": "[configure] add configure support for PCRE Posix library\n\nDebian tried unsuccessfully to build with libpcreposix. This adds proper\nsupport to autoconf/configure.ac for it.\n\nBased on the patch by C.J. Adams-Collier in bug #483.\n\nbgpd/bgp_{regex,routemap}.h: Pull in PCRE POSIX header if available.\n" }, { "commit": "8f5abac1c3f5ad18561cad560bd42b50d2419d94", "tree": "5d126bdeed0e115b53c4cd23a992a5355797d663", "parents": [ "730394d9a33dceb0699c5268afd1049aa225c5c7" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:16:34 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:31 2009 +0100" }, "message": "[BGP/cleanup] make message list in bgp_open const\n" }, { "commit": "730394d9a33dceb0699c5268afd1049aa225c5c7", "tree": "e4dae4fb06d63bf3008154303d32e70eb8c0a88c", "parents": [ "e9dc9f247a668ece1b983cc964fec852c737bedd" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:17:09 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:31 2009 +0100" }, "message": "[BGP/cleanup] make community hash table static\n" }, { "commit": "e9dc9f247a668ece1b983cc964fec852c737bedd", "tree": "e8b865d140f9942655cd6d1190a87f3bade807ca", "parents": [ "ffa4e2c4712ddcb5085971aaf001f030723ee307" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:19:31 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:30 2009 +0100" }, "message": "[BGP/cleanup] make some damp function static\n" }, { "commit": "ffa4e2c4712ddcb5085971aaf001f030723ee307", "tree": "c678f391c427079ec667413f63bc26d5b422c4d7", "parents": [ "372b3c70a090359fe401dbb5e7c34ff8ae09f757" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:28:11 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:30 2009 +0100" }, "message": "[BGP/cleanup] make ecommunity variables/functions local\n" }, { "commit": "372b3c70a090359fe401dbb5e7c34ff8ae09f757", "tree": "ca77aa42206f79326327fe061af90370e9811180", "parents": [ "ce0db9cb11c0bc2e7f89a7d042e50afa495556b4" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:29:41 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:30 2009 +0100" }, "message": "[BGP/cleanup] main program cleanup\n\nCheck result of daemon() call to fix warning\nMake local variables static\n" }, { "commit": "b2d933f8280a4d9eee8a9330282e705514a96a03", "tree": "c3ffbd21046c1ca3ba19f1535c39c6707847745d", "parents": [ "01b7ce2db345429d7abc0446840f1d5c303c80af" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:48:03 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:29 2009 +0100" }, "message": "[bgpd/cleanup] make message lists read only\n" }, { "commit": "01b7ce2db345429d7abc0446840f1d5c303c80af", "tree": "2f20f0bc1f2fa5c7fdf7bc8e4b7993a6b80000c4", "parents": [ "8e4c09307d9eafbbbf7fbffb3d3483287cea169b" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 12:34:43 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:29 2009 +0100" }, "message": "[bgpd] add comment that bgp_capability_receive is exported for unit-tests\n" }, { "commit": "fc52f95373b1dc0bec5f5a474bafa362b02a63ae", "tree": "da4d569501ac14f2712b89052b01e1a138094570", "parents": [ "65d3fbb4835e268b1683b88b12e101c6592b1948" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 09:48:55 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:29 2009 +0100" }, "message": "[cleanup] Fix compile warnings\n\nFix printf format warning and make capability table \u0027const static\u0027\n" }, { "commit": "9bddac4bd50034c713940ad77cebfbb7f3cd123a", "tree": "2d41a091918fd6d4ca433493a7c9ec9d50eaf343", "parents": [ "fda1d3e033f98c7e34ccdaead27e8df39af12a85" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 09:59:51 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd/cleanup] BGP make attribute variables local\n\nMessage lists can be read-only, and hash tables are local to this\ncode.\n" }, { "commit": "fda1d3e033f98c7e34ccdaead27e8df39af12a85", "tree": "636aef72183a2f9dc34305d02545a74fb48907ca", "parents": [ "0088b5dc55a91d27e572484e61df71b8ca2eddf4" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 10:02:27 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd/cleanup] Make BGP FSM table read-only static\n\nThe finite state machine table is immutable.\n" }, { "commit": "0088b5dc55a91d27e572484e61df71b8ca2eddf4", "tree": "f93714f98d12890f961794cd026b6bf2de75105e", "parents": [ "dde7258666fd73878b4cc10b4b5b7c07e9be049e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu May 21 08:51:03 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd] reference count the BGP instance\n\nWhen a BGP instance is deleted with lots of routes and neighbors\nit is possible for the peer rsclient queue to run after\nbgp_delete has been called. This would lead to bgpd crashing,\nsee https://bugzilla.vyatta.com/show_bug.cgi?id\u003d3436\n\nThe fix is to add reference counting to the BGP instance and defer\nactual freeing until all references are gone.\n\nThis patch also fixes a memory leak where the self-reference\npeer instance was being created but never freed.\n\nThe check in bgp_clear_route is no longer valid because it is possible\nfor it to be called when peer is in Deleted state during cleanup.\n" }, { "commit": "dde7258666fd73878b4cc10b4b5b7c07e9be049e", "tree": "9275ed492957279eaf8bfa0c02fc141247309c09", "parents": [ "9607d98cb04e5dff34cb2f6fb6434455c6841ab8" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 08 15:19:07 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd] Make declarations match\n\nThese variables are const.\n" }, { "commit": "7fc626de5f618133ad2a478d13defa3a110b89ea", "tree": "432ff0e4672eabc2ec6b0dcffc22dcc0aee532c8", "parents": [ "66e5cd87194ae6fdd51061a91b4698bc0a652f6b" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Dec 01 11:10:34 2008 -0800" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:10:29 2009 +0100" }, "message": "[cleanup] Make command nodes static\n\nThe cmd_nodes used to configure vty, can mostly be static so\n(basic data hiding 101).\n" }, { "commit": "66e5cd87194ae6fdd51061a91b4698bc0a652f6b", "tree": "659d31f9a7dfb8d9ad9a51f37ff0853054a45399", "parents": [ "cedd7f2fa6823bca9ddcfb062f97ed83b11a80dd" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Feb 09 10:14:16 2009 -0800" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:09:03 2009 +0100" }, "message": "[cleanup] functions taking no args should be declared with void args\n\nUse Ansi-C prototypes rather than old K\u0026R method of declaring\nfunction without arguments\n" }, { "commit": "393deb9bd663361e6b110d579a8b1d4c22667068", "tree": "e93ebf2f57bf92ff7a9cd045764b3cdbb99a07e5", "parents": [ "3453a7122c1d585ad789ed0f63deb90cc5e89fae" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Aug 18 14:13:29 2008 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:07:49 2009 +0100" }, "message": "[cleanup] Convert XMALLOC/memset to XCALLOC\n\nSimple conversion of XMALLOC/memset to XCALLOC\n" }, { "commit": "10819ecee3ced786162b68310cf172aacda18857", "tree": "0680aa68e15af0c5bb1080e5d30fc446fac3d119", "parents": [ "6e0989e113d9e2268e58cfe29922e971793c1d06" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Tue Jun 09 15:15:33 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Tue Jun 09 15:15:33 2009 +0400" }, "message": "[bgpd] Fixed as-path prepend/exclude ASN handling\n\n - aspath_gettoken(): use as_t to fix 4-byte ASN scanning (bug #484)\n - set_aspath_prepend_cmd(): use CMD_AS_RANGE in message to match\n actual range\n - no_set_aspath_prepend_val_cmd(): idem\n - set_aspath_exclude_cmd(): idem\n - no_set_aspath_exclude_val_cmd(): idem\n" }, { "commit": "6e0989e113d9e2268e58cfe29922e971793c1d06", "tree": "624de12c4ba2a53c92a38ac6ee0170d108137c37", "parents": [ "0be8dfb2a95f41f100982085595b7c7505127018", "e6b6a56419ed5a2e8cf2cb11eab340d7b0d28055" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 02 19:43:51 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 02 19:43:51 2009 +0100" }, "message": "Merge remote branch \u0027origin/master\u0027\n" }, { "commit": "0be8dfb2a95f41f100982085595b7c7505127018", "tree": "add7218b0c518ac0cd276c74fe700b5ed1f26762", "parents": [ "42176e6b01c9ca2b2725952684b2d7792468e861" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Tue Jun 02 18:40:07 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 02 18:45:10 2009 +0100" }, "message": "[snmp] Compiler warning fixes for when \"--enable-snmp\" is configured.\n\nCompiled on 32-bit and 64-bit linux gcc 4.1.2 platforms.\nNo run-time testing on 32-bit and limited run-time testing on 64-bit.\n" }, { "commit": "acde4b861333d799b50d6e8a53214abc0d17ede3", "tree": "e6fa104c7bfb45043aec82c9cab3941cb09459bd", "parents": [ "5012bc3d217f4fff5759745ee689869fb5224b41" ], "author": { "name": "Steve Hill", "email": "quagga@cheesy.sackheads.org", "time": "Tue Jun 02 14:28:16 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 02 14:28:16 2009 +0100" }, "message": "[bgp] Fix crash on SIGHUP, deref of freed workqueues\n\n* lib/workqueue.c: free-ing workqueues had never been tested obviously,\n queue\u0027s thread was not being stopped\n* bgpd/bgpd.c: null out freed workqueues, to prevent acting on freed\n workqueues\n" }, { "commit": "e6b6a56419ed5a2e8cf2cb11eab340d7b0d28055", "tree": "4d514a0b67f7a94a1213c74cb9a865593a072791", "parents": [ "2bbd71aace61a70a631c1d0c0bce75fbc76ee1d1" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Mon Jun 01 20:20:36 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Mon Jun 01 20:20:36 2009 +0400" }, "message": "[trivia] Fixed typos in communities text (#334)\n" }, { "commit": "8178b2e156d2263015d7d981590a0899f2cb4c05", "tree": "3dcf31e5c9a3f094c0f2b24a9a3f552ca51d1d2c", "parents": [ "5012bc3d217f4fff5759745ee689869fb5224b41" ], "author": { "name": "Andrew J. Schorr", "email": "schorr@ti82.(none)", "time": "Fri May 29 09:15:20 2009 -0400" }, "committer": { "name": "Andrew J. Schorr", "email": "schorr@ti82.(none)", "time": "Fri May 29 09:15:20 2009 -0400" }, "message": "[bgpd] 64-bit bugfix in community_del_val by Jeremy Jackson \u003cjerj@coplanar.net\u003e\n\n* bgpd/bgp_community.c: (community_del_val) Fix bug in memcpy that was\n using the wrong size on architectures where a pointer is not 32 bits.\n" }, { "commit": "e9a3670706edf37c5a863c93e5ef0c269e484eb9", "tree": "312ef6b631d3408837f21d9b37d7c47c4693ac2d", "parents": [ "21b86436a8c826da84b47cd773fdffbf3d05141e" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Sun Aug 24 20:36:51 2008 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri May 08 22:59:42 2009 +0100" }, "message": "Fix bgp ipv4/ipv6 accept handling\n\nWhen bgp calls getaddrinfo, it gets both ipv6 and ipv4 addresses.\nUnless IPV6_ONLY is set on Linux, only the ipv6 bind will succeed,\nand the IPV4 connections will come in as mapped connections on the\nIPV6 socket.\n" }, { "commit": "aea339f72807c34a7916d8614e030069815e144c", "tree": "7b0ab93dcfec82736f05ac39106096360e4ceeb5", "parents": [ "c540835eaf0cb59921969537d8e94cc83bb717f5" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "message": "[bgpd] AS4 bugfix by Chris Caputo \u003cccaputo@alt.net\u003e\n\n* bgpd/bgp_aspath.c: (aspath_make_str_count) \"assert (len \u003c str_size)\" was\n getting hit under certain 4-byte ASN conditions. New realloc strategy.\n* bgpd/bgp_aspath.c: (aspath_key_make) const warning fix.\n\n\"%d\" -\u003e \"%u\" 4-byte ASN corrections. Prevent negative number when ASN is\nabove 2^31.\n" }, { "commit": "e0081f70ede76bc7a3db53eaab3e45ba657cc4d3", "tree": "27e143772053a699d10671832e3c7d989ee85392", "parents": [ "5d4b8cf2faba9f5386810a7c70837e5b7fae3572" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Sun Nov 16 20:12:04 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Nov 16 20:12:04 2008 +0000" }, "message": "[bgpd] Add \u0027show bgp views\u0027 command\n\n* bgp_vty.c: (show_bgp_views_cmd) new command to list all defined\n views.\n (with small edits by Paul Jakma)\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "8c1bbc7205c5e2a0266e0bf9af42862cf730fbcf", "tree": "0c433d2128c492302df16b9a20501be4cfd66c66", "parents": [ "5635b778afcb3b6b3560871a292dc789f8dca5e9", "6e1992638864c3847d35bf9442989bce4c81de13" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Oct 02 16:27:16 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Oct 02 16:27:16 2008 +0100" }, "message": "Merge branch \u0027bgpd/fsm\u0027\n" }, { "commit": "a8bf6f526ee578a894c72eabae733f0b60abca63", "tree": "855f05041c4ef5a4f201ef2d3fe869b68b95542d", "parents": [ "6e687d74f74f36bc9d503e29377e7d42f3427221" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Wed Sep 24 17:23:11 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Sep 24 17:23:11 2008 +0100" }, "message": "[bgpd] Fix definition of an rsclient command\n\n* bgp_route.c: (show_ip_bgp_view_rsclient_route_cmd) Add the missing \"ip\"\n to the command string.\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" } ], "next": "6e1992638864c3847d35bf9442989bce4c81de13" }