)]}' { "log": [ { "commit": "6b0655a25194c7c0331154edaa6124cf783e5e5e", "tree": "c0c7d479f2684531249668210da27a60322ba395", "parents": [ "fdb913aedb5a9807ad60715e8badb4f25d57acea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:53:35 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:58:02 2014 +0200" }, "message": "*: nuke ^L (page feed)\n\nQuagga sources have inherited a slew of Page Feed (^L, \\xC) characters\nfrom ancient history. Among other things, these break patchwork\u0027s\nXML-RPC API because \\xC is not a valid character in XML documents.\n\nNuke them from high orbit.\n\nPatches can be adapted simply by:\n\tsed -e \u0027s%^L%%\u0027 -i filename.patch\n(you can type page feeds in some environments with Ctrl-V Ctrl-L)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f6f434b2822c453f898552537180a812538bd19e", "tree": "81f5de3c1eeb6679635e7363396c08b807b04ad9", "parents": [ "50ef565e4e689ba653b9709be4d28a01f6cca885" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 23 21:28:03 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Try fix extcommunity resource allocation probs, particularly with \u0027set extcom..\u0027\n\n* Extended communities has some kind of resource allocation problem which\n causes a double-free if the \u0027set extcommunity ...\u0027 command is used.\n Try fix by properly interning extcommunities.\n\n Also, more generally, make unintern functions take a double pointer\n so they can NULL out callers references - a usefully defensive programming\n pattern for functions which make refs invalid.\n\n Sadly, this patch doesn\u0027t fix the problem entirely - crashes still\n occur on session clear.\n\n* bgp_ecommunity.h: (ecommunity_{free,unintern}) take double pointer\n args.\n* bgp_community.h: (community_unintern) ditto\n* bgp_attr.h: (bgp_attr_intern) ditto\n* bgp_aspath.h: (bgp_aspath.h) ditto\n* (general) update all callers of above\n* bgp_routemap.c: (route_set_ecommunity_{rt,soo}) intern the new extcom added\n to the attr, and unintern any old one.\n (route_set_ecommunity_{rt,soo}_compile) intern the extcom to be used\n for the route-map set.\n (route_set_ecommunity_*_free) unintern to match, instead of free\n (route_set_ecommunity_soo) Do as _rt does and don\u0027t just leak\n any pre-existing community, add to it (is additive right though?)\n" }, { "commit": "66e5cd87194ae6fdd51061a91b4698bc0a652f6b", "tree": "659d31f9a7dfb8d9ad9a51f37ff0853054a45399", "parents": [ "cedd7f2fa6823bca9ddcfb062f97ed83b11a80dd" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Feb 09 10:14:16 2009 -0800" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:09:03 2009 +0100" }, "message": "[cleanup] functions taking no args should be declared with void args\n\nUse Ansi-C prototypes rather than old K\u0026R method of declaring\nfunction without arguments\n" }, { "commit": "ffe11cfb0a808ae514193438616dfabc512b4cf6", "tree": "94452dba2c1a49d6e6a0782c6513acb36823cefc", "parents": [ "9fd4958a4eef88c536e4a5aeefce302e10ee8ee6" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Thu Aug 14 16:25:25 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:58 2008 +0100" }, "message": "[lib] hash compare function arguments ought to be const qualified\n\n2008-08-14 Stephen Hemminger \u003cstephen.hemminger@vyatta.com\u003e\n\n\t* lib/hash.h: (struct hash) Hash comparator callback really\n\t ought to treat storage behind arguments as constant - a compare\n\t function with side-effects would be evil.\n\t* */*.c: Adjust comparator functions similarly, thus fixing at least\n\t a few compiler warnings about const qualifier being dropped.\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "750e814693050bc97391eec618aad9db798ee5e8", "tree": "03d3e27a68b0593002d8f73609235919c030e426", "parents": [ "851a1a5c146b346d8b8f58fe3924baa5c208f865" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 21:11:48 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 21:11:48 2008 +0000" }, "message": "[bgpd] Fix triggerable crash when compiled with --disable-bgp-announce\n\n2008-07-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* HACKING: Document preference for compiler conditional code, over\n\t cpp conditional.\n\t* configure.ac: DISABLE_BGP_ANNOUNCE always should be defined.\n\t* bgp_{packet,route,advertise}.c: change to compiler testing of\n\t DISABLE_BGP_ANNOUNCE, rather than cpp.\n\n2008-07-22 MIYAJIMA Mitsuharu \u003cmiyajima.mitsuharu@anchor.jp\u003e\n\n\t* bgp_packet.c: (bgp_update_packet_eor) Fix crash triggerable\n\t if a bgpd was compiled with --disable-bgp-announce and if GR is\n\t advertised by peer.\n" }, { "commit": "923de654c8d251d6714a6f9da2e93c236e935042", "tree": "473cc25308810340efb82724101bd428af352958", "parents": [ "e8eb8340c14f53194786b766992f61cc0abf7a8e" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "message": "[bgpd] Fix warnings: hash callbacks should match hash API declarations\n\n2007-04-22 Sebastien Tandel \u003csebastien@tandel.be\u003e\n\n\t* bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)\n\t conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with\n\t void * arguments as defined by the API.\n\t* bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.\n\t Defines _hash_[alloc|key|cmp] with void * arguments as defined by\n\t the API.\n\t* bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,\n\t cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,\n\t transit_hash_cmp, attrhash_key_make, attrhash_cmp,\n\t bgp_attr_hash_alloc) conforms to quagga hash API. Defines\n\t _hash_[alloc|key|cmp] with void * arguments as defined by the API.\n" }, { "commit": "9f906c7c562bd62043c77a79d84967deea9fe45e", "tree": "84fc5f54c9effcb75ec8ea139228b5f0384075f1", "parents": [ "3414bf250a385496fa6c11dbaa9a5f79100d7a48" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 27 06:57:47 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Aug 27 06:57:47 2006 +0000" }, "message": "[bgpd] fix mtype in XFREE and NULL out freed pointer\n\n2006-08-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.\n\t NULL out peer-\u003ehash after free, to be sure.\n" }, { "commit": "b51f126edee1c170e69951f92033e3e5aec2862d", "tree": "ff637d3f5909fd777aa8e8fe0740349258485e6f", "parents": [ "4bf6a3621c828ea9f2c62298b525a2c1a191a45e" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 14:09:38 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 14:09:38 2006 +0000" }, "message": "[bgpd] trivial: use a distinct memtype for struct bgp_synchronize\n\n2006-03-19 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* memtypes.c: Add MTYPE_BGP_SYNCHRONISE.\n\t* bgp_advertise.c: Use a distinct memory type for struct\n\t bgp_synchronize.\n" }, { "commit": "94f2b3923e9663d0355a829f22e4e31cf68ee7b8", "tree": "59c0291a76b1c97fbb089abb479307f19cdfd4c1", "parents": [ "7cad40007b9714dba65065916ea68577f9d3d6dd" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) The great bgpd extern and static\u0027ification.\n\t* bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code\n\t (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison\n\t warnings.\n\t* bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these\n\t used by various files which had their own private declarations,\n\t in the case of mplsvpn - incorrect.\n" }, { "commit": "200df115ea0ba6f54151d60fe5e9a7f6948de7c3", "tree": "2aedc0af80d2e805cdf2cefd50432423d2871216", "parents": [ "b31b813671d96ea9e96801508442a90f0ef503fa" ], "author": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "message": "2005-06-01 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd/(general) refcount struct peer and bgp_info, hence allowing us\n\t add work_queues for bgp_process.\n\t* bgpd/bgp_route.h: (struct bgp_info) Add \u0027lock\u0027 field for refcount.\n\t Add bgp_info_{lock,unlock} helper functions.\n\t Add bgp_info_{add,delete} helpers, to remove need for\n\t users managing locking/freeing of bgp_info and bgp_node\u0027s.\n\t* bgpd/bgp_table.h: (struct bgp_node) Add a flags field, and\n\t BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of\n\t nodes.\n\t* bgpd/bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock\n\t peer reference as appropriate.\n\t* bgpd/bgp_damp.c: Remove its internal prototypes for\n\t bgp_info_delete/free. Just use bgp_info_delete.\n\t* bgpd/bgpd.h: (struct bgp_master) Add work_queue pointers.\n\t (struct peer) Add reference count \u0027lock\u0027\n\t (peer_lock,peer_unlock) New helpers to take/release reference\n\t on struct peer.\n\t* bgpd/bgp_advertise.c: (general) Add peer and bgp_info refcounting\n\t and balance how references are taken and released.\n\t (bgp_advertise_free) release bgp_info reference, if appropriate\n\t (bgp_adj_out_free) unlock peer\n\t (bgp_advertise_clean) leave the adv references alone, or else\n\t call bgp_advertise_free cant unlock them.\n\t (bgp_adj_out_set) lock the peer on new adj\u0027s, leave the reference\n\t alone otherwise. lock the new bgp_info reference.\n\t (bgp_adj_in_set) lock the peer reference\n\t (bgp_adj_in_remove) and unlock it here\n\t (bgp_sync_delete) make hash_free on peer conditional, just in\n\t case.\n\t* bgpd/bgp_fsm.c: (general) document that the timers depend on\n\t bgp_event to release a peer reference.\n\t (bgp_fsm_change_status) moved up the file, unchanged.\n\t (bgp_stop) Decrement peer lock as many times as cancel_event\n\t canceled - shouldnt be needed but just in case.\n\t stream_fifo_clean of obuf made conditional, just in case.\n\t (bgp_event) always unlock the peer, regardless of return value\n\t of bgp_fsm_change_status.\n\t* bgpd/bgp_packet.c: (general) change several bgp_stop\u0027s to BGP_EVENT\u0027s.\n\t (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs\n\t along with a comment on it.\n\t* bgpd/bgp_route.c: (general) Add refcounting of bgp_info, cleanup\n\t some of the resource management around bgp_info. Refcount peer.\n\t Add workqueues for bgp_process and clear_table.\n\t (bgp_info_new) make static\n\t (bgp_info_free) Ditto, and unlock the peer reference.\n\t (bgp_info_lock,bgp_info_unlock) new exported functions\n\t (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,\n\t taking care of reference counts.\n\t (bgp_info_delete) do the opposite of bgp_info_add.\n\t (bgp_process_rsclient) Converted into a work_queue work function.\n\t (bgp_process_main) ditto.\n\t (bgp_processq_del) process work queue item deconstructor\n\t (bgp_process_queue_init) process work queue init\n\t (bgp_process) call init function if required, set up queue item\n\t and add to queue, rather than calling process functions directly.\n\t (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts\n\t (bgp_rib_withdraw) ditto\n\t (bgp_update_rsclient) let bgp_info_add manage refcounts\n\t (bgp_update_main) ditto\n\t (bgp_clear_route_node) clear_node_queue work function, does\n\t per-node aspects of what bgp_clear_route_table did previously\n\t (bgp_clear_node_queue_del) clear_node_queue item delete function\n\t (bgp_clear_node_complete) clear_node_queue completion function,\n\t it unplugs the process queues, which have to be blocked while\n\t clear_node_queue is being processed to prevent a race.\n\t (bgp_clear_node_queue_init) init function for clear_node_queue\n\t work queues\n\t (bgp_clear_route_table) Sets up items onto a workqueue now, rather\n\t than clearing each node directly. Plugs both process queues to\n\t avoid potential race.\n\t (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage\n\t bgp_info refcounts.\n\t (bgp_static_update_rsclient) ditto\n\t (bgp_static_update_main) ditto\n\t (bgp_static_update_vpnv4) ditto, remove unneeded cast.\n\t (bgp_static_withdraw) see bgp_static_withdraw_rsclient\n\t (bgp_static_withdraw_vpnv4) ditto\n\t (bgp_aggregate_{route,add,delete}) ditto\n\t (bgp_redistribute_{add,delete,withdraw}) ditto\n\t* bgpd/bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer\n\t reference\n\t (peer_rsclient_unset_vty) ditto, but unlock same reference\n\t* bgpd/bgpd.c: (peer_free) handle frees of info to be kept for lifetime\n\t of struct peer.\n\t (peer_lock,peer_unlock) peer refcount helpers\n\t (peer_new) add initial refcounts\n\t (peer_create,peer_create_accept) lock peer as appropriate\n\t (peer_delete) unlock as appropriate, move out some free\u0027s to\n\t peer_free.\n\t (peer_group_bind,peer_group_unbind) peer refcounting as\n\t appropriate.\n\t (bgp_create) check CALLOC return value.\n\t (bgp_terminate) free workqueues too.\n\t* lib/memtypes.c: Add MTYPE_BGP_PROCESS_QUEUE and\n\t MTYPE_BGP_CLEAR_NODE_QUEUE\n" }, { "commit": "eb821189d2778a93069fc1fc2f104db529ec5a1e", "tree": "a623d680931ee722fb946f56476f23efd1f13685", "parents": [ "eb3f463aab7f09e6c1041bf779fd5752b038f847" ], "author": { "name": "paul", "email": "paul", "time": "Sat May 01 08:44:08 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat May 01 08:44:08 2004 +0000" }, "message": "2004-05-01 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * Revert the attempted clean-up of the dummy peer hack, reverts\n patchsets 435 (see 2004-02-17 below) and 456.\n" }, { "commit": "158cdad448eee409025b91ee152c505a62840cc3", "tree": "df099e1cc540f52e00bcf58906c74b6b943053ba", "parents": [ "0d85b9958d6db05fb9d81afbee96332f142654bd" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri Mar 19 17:12:14 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri Mar 19 17:12:14 2004 +0000" }, "message": "Fix warning.\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }