)]}' { "log": [ { "commit": "60cc95921ae663de325ca3e76e8c05d8224986ab", "tree": "7d78102aa9650da4bba1355b2a6601135d687b37", "parents": [ "4feb0d02c029e2e4f229f6283f579b8673b0ac11" ], "author": { "name": "Pradosh Mohapatra", "email": "pmohapat@cumulusnetworks.com", "time": "Mon Nov 09 20:21:41 2015 -0500" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@hpe.com", "time": "Tue Sep 13 10:36:44 2016 +0100" }, "message": "bgpd, doc, lib, zebra: nexthop-tracking in zebra\n\n0. Introduction\n\nThis is the design specification for next hop tracking feature in\nQuagga.\n\n1. Background\n\nRecursive routes are of the form:\n\n p/m --\u003e n\n [Ex: 1.1.0.0/16 --\u003e 2.2.2.2]\n\nwhere \u0027n\u0027 itself is resolved through another route as follows:\n\n p2/m --\u003e h, interface\n [Ex: 2.2.2.0/24 --\u003e 3.3.3.3, eth0]\n\nUsually, BGP routes are recursive in nature and BGP nexthops get\nresolved through an IGP route. IGP usually adds its routes pointing to\nan interface (these are called non-recursive routes).\n\nWhen BGP receives a recursive route from a peer, it needs to validate\nthe nexthop. The path is marked valid or invalid based on the\nreachability status of the nexthop. Nexthop validation is also\nimportant for BGP decision process as the metric to reach the nexthop\nis a parameter to best path selection process.\n\nAs it goes with routing, this is a dynamic process. Route to the\nnexthop can change. The nexthop can become unreachable or\nreachable. In the current BGP implementation, the nexthop validation\nis done periodically in the scanner run. The default scanner run\ninterval is one minute. Every minute, the scanner task walks the\nentire BGP table. It checks the validity of each nexthop with Zebra\n(the routing table manager) through a request and response message\nexchange between BGP and Zebra process. BGP process is blocked for\nthat duration. The mechanism has two major drawbacks:\n\n(1) The scanner task runs to completion. That can potentially starve\n the other tasks for long periods of time, based on the BGP table\n size and number of nexthops.\n\n(2) Convergence around routing changes that affect the nexthops can be\n long (around a minute with the default intervals). The interval\n can be shortened to achieve faster reaction time, but it makes the\n first problem worse, with the scanner task consuming most of the\n CPU resources.\n\n\"Next hop tracking\" feature makes this process event-driven. It\neliminates periodic nexthop validation and introduces an asynchronous\ncommunication path between BGP and Zebra for route change notifications\nthat can then be acted upon.\n\n2. Goal\n\nStating the obvious, the main goal is to remove the two limitations we\ndiscussed in the previous section. The goals, in a constructive tone,\nare the following:\n\n- fairness: the scanner run should not consume an unjustly high amount\n of CPU time. This should give an overall good performance and\n response time to other events (route changes, session events,\n IO/user interface).\n\n- convergence: BGP must react to nexthop changes instantly and provide\n sub-second convergence. This may involve diverting the routes from\n one nexthop to another.\n\n3. Overview of the changes\n\nThe changes are in both BGP and Zebra modules. The short summary is\nthe following:\n\n- Zebra implements a registration mechanism by which clients can\n register for next hop notification. Consequently, it maintains a\n separate table, per (VRF, AF) pair, of next hops and interested\n client-list per next hop.\n\n- When the main routing table changes in Zebra, it evaluates the next\n hop table: for each next hop, it checks if the route table\n modifications have changed its state. If so, it notifies the\n interested clients.\n\n- BGP is one such client. It registers the next hops corresponding to\n all of its received routes/paths. It also threads the paths against\n each nexthop structure.\n\n- When BGP receives a next hop notification from Zebra, it walks the\n corresponding path list. It makes them valid or invalid depending\n on the next hop notification. It then re-computes best path for the\n corresponding destination. This may result in re-announcing those\n destinations to peers.\n\n4. Design\n\n4.1. Modules\n\nThe core design introduces an \"nht\" (next hop tracking) module in BGP\nand \"rnh\" (recursive nexthop) module in Zebra. The \"nht\" module\nprovides the following APIs:\n\nbgp_find_or_add_nexthop() : find or add a nexthop in BGP nexthop table\nbgp_find_nexthop() : find a nexthop in BGP nexthop table\nbgp_parse_nexthop_update() : parse a nexthop update message coming\n from zebra\n\nThe \"rnh\" module provides the following APIs:\n\nzebra_add_rnh() : add a recursive nexthop\nzebra_delete_rnh() : delete a recursive nexthop\nzebra_lookup_rnh() : lookup a recursive nexthop\n\nzebra_add_rnh_client() : register a client for nexthop notifications\n against a recursive nexthop\n\nzebra_remove_rnh_client(): remove the client registration for a\n recursive nexthop\n\nzebra_evaluate_rnh_table(): (re)evaluate the recursive nexthop table\n (most probably because the main routing\n table has changed).\n\nzebra_cleanup_rnh_client(): Cleanup a client from the \"rnh\" module\n data structures (most probably because the\n client is going away).\n\n4.2. Control flow\n\nThe next hop registration control flow is the following:\n\n\u003c\u003d\u003d\u003d\u003d BGP Process \u003d\u003d\u003d\u003d\u003e|\u003c\u003d\u003d\u003d\u003d Zebra Process \u003d\u003d\u003d\u003d\u003e\n |\nreceive module nht module | zserv module rnh module\n----------------------------------------------------------------------\n | | |\nbgp_update_ | | |\n main() | bgp_find_or_add_ | |\n | nexthop() | |\n | | |\n | | zserv_nexthop_ |\n | | register() |\n | | | zebra_add_rnh()\n | | |\n\nThe next hop notification control flow is the following:\n\n\u003c\u003d\u003d\u003d\u003d Zebra Process \u003d\u003d\u003d\u003d\u003e|\u003c\u003d\u003d\u003d\u003d BGP Process \u003d\u003d\u003d\u003d\u003e\n |\nrib module rnh module | zebra module nht module\n----------------------------------------------------------------------\n | | |\nmeta_queue_ | | |\n process() | zebra_evaluate_ | |\n | rnh_table() | |\n | | |\n | | bgp_read_nexthop_ |\n | | update() |\n | | | bgp_parse_\n | | | nexthop_update()\n | | |\n\n4.3. zclient message format\n\nZEBRA_NEXTHOP_REGISTER and ZEBRA_NEXTHOP_UNREGISTER messages are\nencoded in the following way:\n\n/*\n * 0 1 2 3\n * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * | AF | prefix len |\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * . Nexthop prefix .\n * . .\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * . .\n * . .\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * | AF | prefix len |\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * . Nexthop prefix .\n * . .\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n */\n\nZEBRA_NEXTHOP_UPDATE message is encoded as follows:\n\n/*\n * 0 1 2 3\n * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * | AF | prefix len |\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * . Nexthop prefix getting resolved .\n * . .\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * | metric |\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * | #nexthops |\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * | nexthop type |\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * . resolving Nexthop details .\n * . .\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * . .\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * | nexthop type |\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n * . resolving Nexthop details .\n * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n */\n\n4.4. BGP data structure\n\nLegend:\n\n/\\ struct bgp_node: a BGP destination/route/prefix\n\\/\n\n[ ] struct bgp_info: a BGP path (e.g. route received from a peer)\n\n _\n(_) struct bgp_nexthop_cache: a BGP nexthop\n\n /\\ NULL\n \\/--+ ^\n | :\n +--[ ]--[ ]--[ ]--\u003e NULL\n /\\ :\n \\/--+ :\n | :\n +--[ ]--[ ]--\u003e NULL\n :\n _ :\n (_).............\n\n4.5. Zebra data structure\n\nrnh table:\n\n O\n / \\\n O O\n / \\\n O O\n\n struct rnh\n {\n u_char flags;\n struct rib *state;\n struct list *client_list;\n struct route_node *node;\n };\n\n5. User interface changes\n\nquagga# show ip nht\n3.3.3.3\n resolved via kernel\n via 11.0.0.6, swp1\n Client list: bgp(fd 12)\n11.0.0.10\n resolved via connected\n is directly connected, swp2\n Client list: bgp(fd 12)\n11.0.0.18\n resolved via connected\n is directly connected, swp4\n Client list: bgp(fd 12)\n11.11.11.11\n resolved via kernel\n via 10.0.1.2, eth0\n Client list: bgp(fd 12)\n\nquagga# show ip bgp nexthop\nCurrent BGP nexthop cache:\n 3.3.3.3 valid [IGP metric 0], #paths 3\n Last update: Wed Oct 16 04:43:49 2013\n\n 11.0.0.10 valid [IGP metric 1], #paths 1\n Last update: Wed Oct 16 04:43:51 2013\n\n 11.0.0.18 valid [IGP metric 1], #paths 2\n Last update: Wed Oct 16 04:43:47 2013\n\n 11.11.11.11 valid [IGP metric 0], #paths 1\n Last update: Wed Oct 16 04:43:47 2013\n\nquagga# show ipv6 nht\nquagga# show ip bgp nexthop detail\n\nquagga# debug bgp nht\nquagga# debug zebra nht\n\n6. Sample test cases\n\n r2----r3\n / \\ /\n r1----r4\n\n- Verify that a change in IGP cost triggers NHT\n + shutdown the r1-r4 and r2-r4 links\n + no shut the r1-r4 and r2-r4 links and wait for OSPF to come back\n up\n + We should be back to the original nexthop via r4 now\n- Verify that a NH becoming unreachable triggers NHT\n + Shutdown all links to r4\n- Verify that a NH becoming reachable triggers NHT\n + no shut all links to r4\n\n7. Future work\n\n- route-policy for next hop validation (e.g. ignore default route)\n- damping for rapid next hop changes\n- prioritized handling of nexthop changes ((un)reachability vs. metric\n changes)\n- handling recursion loop, e.g.\n 11.11.11.11/32 -\u003e 12.12.12.12\n 12.12.12.12/32 -\u003e 11.11.11.11\n 11.0.0.0/8 -\u003e \u003cinterface\u003e\n- better statistics\nAddresses upstream comments.\n\n\"show ip bgp nexthop detail\" couldn\u0027t display multiple NHs due to a bug.\nFix that.\n\nFix reference counts for the nexthop cache entries\n\nSigned-off-by: Pradosh Mohapatra \u003cpmohapat@cumulusnetworks.com\u003e\nSigned-off-by: Daniel Walton \u003cdwalton@cumulusnetworks.com\u003e\nSigned-off-by: Dinesh Dutt \u003cddutt@cumulusnetworks.com\u003e\nSigned-off-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\nSigned-off-by: Vivek Venkatraman \u003cvivek@cumulusnetworks.com\u003e\n\nFix reference counts for the nexthop cache entries.\n\nSigned-off-by: Vivek Venkatraman \u003cvivek@cumulusnetworks.com\u003e\n\nEdited-by: Paul Jakma \u003cpaul.jakma@hpe.com\u003e\n- Fix nexthop_ipv6_add defs in rib.h not having been modified with rib_ prefix.\n- Remove rib_lookup_and_pushup, appears not to be used except for\n !HAVE_NETLINK \u0026\u0026 HAVE_STRUCT_IFALIASREQ case of ioctl.c::if_set_prefix,\n so it\u0027s not being used at all on platform with most testing of RIB.\n" }, { "commit": "6ed810d986df5d843c89166fee6b73a71222b7bd", "tree": "86ac070fc69ae3e62fc6bf5d8750990bf0fa6c3e", "parents": [ "c313895dec3c176584d99f7b8684ddc3f9141d88" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:13:07 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:44:56 2015 +0200" }, "message": "*: fix more initialisers (for BSD)\n\nFreeBSD and NetBSD spew a few more warnings about variable initialisers.\nFound with OSR\u0027s/NetDEF\u0027s fancy new CI system.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a0f63a4c7d7a6404fd43d139809202a693ae42e9", "tree": "1af7685743107d08861f089de25df0196b10e441", "parents": [ "362573e5642b29ffeef5000351adc2d6ed6dfca3" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Thu Dec 03 21:14:16 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 21:14:16 2009 +0300" }, "message": "zebra: fix argument reference in strncpy() call for BSD\n" }, { "commit": "0b3f3d47b21ddf175bfdd549ba33fbcd34801244", "tree": "ec788e51c7dadeb5469313b6d3819690b468bbab", "parents": [ "ce9c3cc5d96ea417727347923a42f10d56e631fd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 01 18:24:58 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 01 18:24:58 2008 +0000" }, "message": "[zebra] Make BSD link-state deal more gracefully with GIFMEDIA ioctl error\n\n2008-07-01 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* ioctl.c: (if_get_flags) Deal more gracefully with failure\n\t of the BSD link-state SIOCGIFMEDIA ioctl, as some interfaces\n\t apparently don\u0027t implement it (e.g. tun).\n\t Also, make BSD link-state checking be conditional on the\n\t \u0027link-detect\u0027 interface configuration flag, as it should be.\n\t Fixes bug #465.\n" }, { "commit": "20e5ff0a8893ffad6d31739d68d224931c4a7992", "tree": "8ecd9184d2d7268e0fc51bcd612790301780efda", "parents": [ "dea04441fb51f74dc25f6ab4bd756b4159d961b6" ], "author": { "name": "Denis Ovsienko", "email": "linux@pilot.org.ua", "time": "Tue Feb 26 14:02:24 2008 +0000" }, "committer": { "name": "Denis Ovsienko", "email": "linux@pilot.org.ua", "time": "Tue Feb 26 14:02:24 2008 +0000" }, "message": "+ fix bug#326 by rib_lookup_and_pushup()\n" }, { "commit": "55edb0d446a272907715b0825ff008557174d34a", "tree": "17d46ab705b0b229b8795d0d809fddd18e1d9078", "parents": [ "c543a1737173fb438f1d8c06f650b2d0d479f45c" ], "author": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Fri Jan 11 15:57:13 2008 +0000" }, "committer": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Fri Jan 11 15:57:13 2008 +0000" }, "message": "[link-detect] Improve BSD support.\n2008-01-11 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* lib/zebra.h: Revert previous change, no need to include\n\t \u003cnet/if_media.h\u003e here.\n\t* zebra/ioctl.c: If HAVE_BSD_LINK_DETECT is defined, include\n\t \u003cnet/if_media.h\u003e\n\t (if_get_flags) Remove debug messages about BSD link state.\n\t* zebra/kernel_socket.c: (bsd_linkdetect_translate) If link state\n\t is unknown, we should set the IFF_RUNNING flag.\n" }, { "commit": "c543a1737173fb438f1d8c06f650b2d0d479f45c", "tree": "ba940242e22f7e6798e6fd24b19864b5702474db", "parents": [ "3f087670efa606021cde2f6a9615ac7e07aec2a5" ], "author": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Thu Jan 10 15:24:32 2008 +0000" }, "committer": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Thu Jan 10 15:24:32 2008 +0000" }, "message": "[link-detect] Try to get BSD link-detect to work properly.\n\n2008-01-10 Ingo Flaschberger \u003cif@xip.at\u003e\n\n\t* configure.ac: Define HAVE_BSD_LINK_DETECT if \u003cnet/if_media.h\u003e is\n\t present.\n\t* lib/zebra.h: If HAVE_BSD_LINK_DETECT is defined,\n\t include \u003cnet/if_media.h\u003e.\n\t* zebra/ioctl.c: (if_get_flags) If HAVE_BSD_LINK_DETECT, use the\n\t SIOCGIFMEDIA ioctl to ascertain link state.\n\t* zebra/kernel_socket.c: (bsd_linkdetect_translate) New function to\n\t map the ifm_data.ifi_link_state value into the IFF_RUNNING flag.\n\t (ifm_read) Call bsd_linkdetect_translate to fix the IFF_RUNNING\n\t flag before calling if_flags_update.\n" }, { "commit": "6f0e3f6e17687eb25b7b77c4fdc8324837d4700f", "tree": "8a94d9212060f0f2ee7cbd0079c2687eed7348dc", "parents": [ "08d3d5b398ae81de7659509f159e814d1bbd4375" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 10 02:38:51 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 10 02:38:51 2007 +0000" }, "message": "[autoconf] bugs 162,303,178: Fix \u0027present but can not be compiled\u0027 warnings\n\n2007-05-09 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* configure.ac: sys/conf.h depends on sys/param.h, at least on\n\t FBSD 6.2.\n\t (bug #363) Should check for in_pktinfo for IRDP\n\n2006-05-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* configure.ac: General cleanup of header and type checks, introducing\n\t an internal define, QUAGGA_INCLUDES, to build up a list of\n\t stuff to include so as to avoid \u0027present but cant be compiled\u0027\n\t warnings.\n\t Misc additional checks of things missing according to autoscan.\n\t Add LIBM, for bgpd\u0027s use of libm, so as to avoid burdening\n\t LIBS, and all the binaries, with libm linkage.\n\t Remove the bad practice of using m4 changequote(), just\n\t quote the []\u0027s in the case statements properly.\n\t This should fix bugs 162, 303 and 178.\n\t* */*.{c,h}: Update all HAVE_* to the standard autoconf namespaced\n\t HAVE_* defines. I.e. HAVE_SA_LEN -\u003e HAVE_STRUCT_SOCKADDR_SA_LEN,\n\t* bgpd/Makefile.am: Add LIBM to bgpd\u0027s LDADD, for pow().\n" }, { "commit": "f5e004f74fecaf84b50f8c1823432077ad7e15b7", "tree": "bffb42983f6b993c861ac67192646ed82db9fc1f", "parents": [ "6e4ab12f1504caa95edc7702a82f118d0de15a0a" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:43:43 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:43:43 2007 +0000" }, "message": "[zebra] MTU change should propogate to zserv client on BSD/Solaris\n\n2007-04-10 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* ioctl{_solaris,}.c: (if_get_mtu) Ping clients via\n zebra_interface_up_update if MTU is changed.\n" }, { "commit": "5c78b3d006e6926f938796cffa08e8e14fb8e7af", "tree": "19f8f80511cba84e0d70ac22667321a4a7df0d60", "parents": [ "590188b67db4021b9d1552238ef49482dd5f0123" ], "author": { "name": "paul", "email": "paul", "time": "Wed Jan 25 04:31:40 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Jan 25 04:31:40 2006 +0000" }, "message": "[zebra/solaris] Interface state fixups for Solaris.\n\n2006-01-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) More solaris PF_ROUTE hacks. The IFF_UP mangling\n\t for solaris was incomplete on the PF_ROUTE side. fix it.\n\t This changeset generally uglifies things. For some future\n\t work I\u0027d like to see the state changes seperated out from\n\t the details of the code. Differences between systems might\n\t then be slightly easier to implement without convoluted\n\t hacks.\n\t Changes should be specific to Solaris mostly, however\n\t also tested on FreeBSD 6.\n\t* if_ioctl_solaris.c: (interface_list_ioctl) ignore ~IFF_UP\n\t interfaces, we\u0027ll hear about them when/if interface goes up\n\t through NEWADDR.\n\t Update flags explicitely at end of it to kick mangling.\n\t* ioctl_solaris.c: (if_mangle_up) removed to interface.c, in\n\t kind.\n\t (lifreq_set_name) more convenient to take the string, than\n\t the ifp.\n\t (if_get_flags_direct) new convenience function, returns\n\t the actual flags. Used during bootstrap in if_ioctl_solaris.c\n\t to peek at flags of logical interfaces to see whether or\n\t not to ignore them.\n\t (if_get_flags) ENXIO means it\u0027s gone, poke out IFF_UP and\n\t kick flags update.\n\t (if_{un,}set_flags) flags argument should be 64bit.\n\t* ioctl.{c,h}: flags argument should be 64bit.\n\t* interface.h: Add a \u0027primary_state\u0027 flag to struct zebra_if on\n\t SUNOS_5.\n\t Export if_flags_update.\n\t* interface.c: (if_flags_mangle) moved over in kind from\n\t ioctl_solaris.c. Nasty kludge to try get IFF_UP right, as\n\t much as is possible. Also keep track of the actual IFF_UP\n\t value for the primary interface, so we can know when the ifp\n\t must be deleted.\n\t (if_flags_update) Take a new interface flags value, apply it\n\t to the interface, and take whatever actions are required due\n\t to flag transitions.\n\t (if_refresh) flag state change logic is moved out to\n\t previous. Just call if_get_flags, which will end up using\n\t previous to effect the update of flags.\n\t (if_flag_dump_vty) IFF_IPV{4,6} aren\u0027t interesting, VIRTUAL\n\t and NOXMIT are though.\n\t* kernel_socket.c: (ifm_read) Down-\u003eDown transitions shouldn\u0027t\n\t create ifp, for non-IFANNOUNCE systems.\n\t Use if_flags_update to update flags.\n\t flag transition logic is now handled automatically through\n\t if_flags_update.\n\t (ifam_read) Better to call if_refresh *after* adding\n \t connected addresses, as connected count affects IFF_UP on\n \t IFF_UP-mangled systems.\n \t On Solaris, Up-\u003eDown due to DELADDR means we need to delete\n\t the ifp - the IFINFO might already have been and gone.\n\t* rt.h: include other dependent headers.\n" }, { "commit": "a1ac18c4d5b4f8f4f279efb2ae12b46258f22282", "tree": "e37732ef4b00ae98d1be693e721b01cc2566ba39", "parents": [ "94f2b3923e9663d0355a829f22e4e31cf68ee7b8" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 17:17:12 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 17:17:12 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) Extern and static\u0027ification, with related fixups\n\t of declarations, ensuring files include their own headers, etc.\n\t if_ioctl.c: (interface_info_ioctl) fix obvious arg mis-order in\n\t list loop\n" }, { "commit": "6a52d0d155fc8b892e30cdb5e3fbe4c2779bd4cd", "tree": "d4bfab8286e497e30c5ebfed099c317a9397c623", "parents": [ "656b4eeec1fb30402ad2001976c05c6f44fafb34" ], "author": { "name": "ajs", "email": "ajs", "time": "Sun Jan 30 18:49:28 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Sun Jan 30 18:49:28 2005 +0000" }, "message": "2005-01-30 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* daemon.c: (daemon) Replace perror with zlog_err.\n\t* vty.c: (vty_serv_un) Replace perror with zlog_err.\n\t* ripd.c: (rip_create_socket) Replace perror with zlog_err.\n\t* ioctl.c: (if_ioctl,if_ioctl_ipv6,if_get_flags) Replace perror with\n\t zlog_err.\n\t* ioctl_solaris.c: (if_ioctl,if_ioctl_ipv6) Replace perror with\n\t zlog_err.\n" }, { "commit": "4460e7a4cf3dadcd9f06e4b519ba7be2cc936c0a", "tree": "5755c13aeffb151d56a886868e623d186ca9a0a0", "parents": [ "4be019d5530e21c9e54e41e46a57ab071b9b11ae" ], "author": { "name": "ajs", "email": "ajs", "time": "Sat Jan 29 17:07:40 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Sat Jan 29 17:07:40 2005 +0000" }, "message": "2005-01-29 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* if_ioctl_solaris.c: (interface_list_ioctl) Save errno before calling\n\t zserv_privs.change.\n\t* ioctl{,_solaris}.c: (if_ioctl,if_ioctl_ipv6) Save errno before calling\n\t zserv_privs.change.\n\t* ipforward_solaris.c: (solaris_nd) Save errno before calling\n\t zserv_privs.change.\n\t* irdp_main.c: (irdp_sock_init) Save errno before calling\n\t zserv_privs.change.\n\n\t[backport candidate]\n" }, { "commit": "44145db3ae79d54da58c967d96cf059421dbf9eb", "tree": "ac57bd081e8f93317676875aa73eaf2e7a45aa49", "parents": [ "b9df2d25fc8d06ca63fa792d162d97656361338b" ], "author": { "name": "paul", "email": "paul", "time": "Sun May 09 11:00:23 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sun May 09 11:00:23 2004 +0000" }, "message": "2004-05-09 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* ioctl.c: (if_get_mtu) set mtu6 to mtu\n\t* mtu_kvm.c: (if_kvm_get_mtu) set mtu6 to mtu\n\t* rt_netlink.c: (netlink_interface) set mtu6 to mtu\n\t (netlink_link_change) ditto\n\n2004-05-09 Sowmini Varadhan \u003csowmini.varadhan@sun.com\u003e\n\n\t* interface.c: (if_delete_update) only used with HAVE_NETLINK\n\t and RTM_IFANNOUNCE.\n\t (if_flag_dump_vty) Solaris IFF_IPV4 and IFF_IPV6 if flags\n\t (if_dump_vty) print mtu6 if not same as mtu\n" }, { "commit": "d1724b6555510c22d2df55a9245fe4e6f1b08922", "tree": "3c72ac425f323f94fe57f8310011fc1f8c9273b5", "parents": [ "dc7a2bf1c831f6bcea5945f7fe2eb2ba111e4224" ], "author": { "name": "paul", "email": "paul", "time": "Wed Oct 22 02:41:52 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Oct 22 02:41:52 2003 +0000" }, "message": "2003-10-22 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * lib/regex.c: bzero -\u003e memset\n * zebra/ioctl.c: ditto. bzero is not portable.\n" }, { "commit": "0e4f190ebf5a26e4b66fb49cd74ae0ff0c7e0863", "tree": "cb2d35c5a85e8dd5f70db46604e6dda55b9bc9f4", "parents": [ "9238b1e82efd5c6a7192491e2ccde2dfa32322c8" ], "author": { "name": "paul", "email": "paul", "time": "Thu Jun 12 02:13:45 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Jun 12 02:13:45 2003 +0000" }, "message": "2003-06-12 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* zebra/ioctl.c: Properly zero-out struct ifreq before passing it\n to the SIOCSIFFLAGS ioctl(2), so that it doesn\u0027t\n occasionally trigger promisc mode on interface.\n Reported/tested by:\tVladimir B. Grebenschikov \u003cvova@sw.ru\u003e\n\n (patch snarfed taken from FreeBSD ports)\n" }, { "commit": "edd7c245d3a77012abf801da00d5664ebaa5f749", "tree": "d4fada229d7980fb751f28c9a979aa88de1a0af0", "parents": [ "a159ed935b580ed99111a185734ddd9c973e7691" ], "author": { "name": "paul", "email": "paul", "time": "Wed Jun 04 13:59:38 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Jun 04 13:59:38 2003 +0000" }, "message": "2003-06-04 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* Merge of zebra privileges\n" }, { "commit": "726f9b2bbdd5a607f7b0a10a64547739b807e361", "tree": "9c46a6ce71cf4ea96553a85a231e38b462b3dee0", "parents": [ "71c0fb50fe75928f8fbe1bbff1995d9d91b3702b" ], "author": { "name": "hasso", "email": "hasso", "time": "Sun May 25 21:04:54 2003 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sun May 25 21:04:54 2003 +0000" }, "message": "Last fixes from 6Wind patch.\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }