)]}' { "log": [ { "commit": "cc0b6c122f2d01d886e1ebde15cd2e7c5442c598", "tree": "e6a65e182af6e028087538bec3056219e6471d10", "parents": [ "1809ec13def22bc6c2c30d9e8d37a74095bcfb64" ], "author": { "name": "John Kemp", "email": "kemp@network-services.uoregon.edu", "time": "Fri Mar 18 17:52:18 2011 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 18:42:19 2011 +0400" }, "message": "bgpd: improve \"monotonic\" uptime correction\n\nOlder versions of Quagga/Zebra would output a value in MRT table\ndump files for \"uptime\" aka \"ORIGINATED\" that was a WALL clock\nvalue. Given that uptime is now internally a bgp_clock MONOTONIC\nvalue, the output in the MRT files is showing up as monotonic.\n\nNote: time of MRT dump is still recorded correctly as a\ntime() based value, so we haven\u0027t lost that value.\n\nProposal is to correct the uptime output on the vty and in the\nMRT files to again display something more akin to WALL time.\n\n* bgp_dump.c: (bgp_dump_routes_func) add conditional correction\n* bgp_route.c: (route_vty_out_detail) make correction conditional, move\n variable declaration to beginning of the function\n" }, { "commit": "5c98c5a7b1d3d71ff40b477b246b859cd22ddeed", "tree": "957b31b1c50f75a08f157630803e1f26c27222c7", "parents": [ "0ddff5764f736c0a6d0d07b28bf98970624f263b" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 18:52:52 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Aug 05 18:52:52 2011 +0400" }, "message": "bgpd: touch nexthop handling code\n\nbgp_nexthop_lookup_ipv6(): declare variables where they are actually\nused, drop no-op initialization (the field is already 0)\nbgp_nexthop_lookup(): ditto\nbgp_nexthop_check_ebgp(): rename to bgp_nexthop_onlink()\nbgp_nexthop_cache_changed(): rename to bgp_nexthop_cache_different()\n" }, { "commit": "f4ac0fee73100c6268365df31096a64443bfb93b", "tree": "81388aa90d1394d67ee5ffe61daeab19b2c3407c", "parents": [ "999a305c89b12b8d059f118bf01556b9a6fd62b3" ], "author": { "name": "Wataru Tanitsu", "email": "wataru@ate-mahoroba.jp", "time": "Fri Sep 10 09:47:56 2010 -0700" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 01 15:36:36 2011 +0400" }, "message": "bgpd: Fix display of unsigned attributes\n\n* bgp_route.c: (route_vty_out*) The local prefix, metric and weight values\n are all stored as uint32_t. Change the format to %u so that large values\n are not displayed as negative integers.\n" }, { "commit": "a8b79422aadf5dc821af6699e468379002cc61f9", "tree": "0ee82fbd4e2b90686f2cf49b1bca59678e58eb18", "parents": [ "fdc38db248a220dcb80ec0ba1f1981087213651d" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Mar 23 10:30:30 2011 +0000" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jul 18 10:39:02 2011 +0400" }, "message": "bgpd: Fix compile failure if IPv6 build was disabled.\n\n* bgp_route.c: ({no_,}ipv6_bgp_network_ttl_cmd) depends on ipv6_bgp_network\n which is HAVE_IPV6, so these should be too.\n (bgp_route_init) and the installs should be similarly ifdefed\n" }, { "commit": "e81537d3be9f95d333d658329e5d69e6188b53c0", "tree": "5f91b0f1d2a0dae1671c788c7d7804b16adcd4cd", "parents": [ "87f011e5297ab9d3c599916800aab1198613071e" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "message": "bgpd: more SAFI fixes\n\nTwo macros resolving to the same integer constant broke a case block and\na more thorough merge of BGP_SAFI_VPNV4 and BGP_SAFI_VPNV6 was\nperformed.\n\n* bgpd.h: MPLS-labeled VPN SAFI is AFI-independent, switch to single\n* macro\n* bgp_capability_test.c: update test data\n* bgp_mp_attr_test.c: idem\n* bgp_route.c: (bgp_maximum_prefix_overflow, bgp_table_stats_vty) update\n macro and check conditions (where appropriate)\n* bgp_packet.c: (bgp_route_refresh_send, bgp_capability_send,\n bgp_update_receive, bgp_route_refresh_receive): idem\n* bgp_open.c: (bgp_capability_vty_out, bgp_afi_safi_valid_indices,\n bgp_open_capability_orf, bgp_open_capability): idem\n* bgp_attr.c: (bgp_mp_reach_parse, bgp_packet_attribute,\n bgp_packet_withdraw): idem\n" }, { "commit": "87f011e5297ab9d3c599916800aab1198613071e", "tree": "3d165036dd68dcf3eea1dd66f5d373fc15a86bf3", "parents": [ "ea15b20a7cb8e41e61c48e36a554c576ed6f2f91" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jul 13 16:53:13 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jul 13 16:53:13 2011 +0400" }, "message": "bgpd: fix SAFI for for MPLS labeled VPN-IPv6\n\n* bgpd.h: change value of BGP_SAFI_VPNV6 to 128 (RFC4659, BZ#659)\n* bgp_route.c: (bgp_table_stats_vty) fix length argument to strncmp()\n" }, { "commit": "e70e575a8cb1edcab2eedade04bb4ac31938bddf", "tree": "5a72f6c9d4f7a50ea2b40229b8b04adece6f67b0", "parents": [ "fc09716b81e67f2d06dc92ff7bcb1efdf18c4eec" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 05 00:41:59 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Jul 05 00:41:59 2011 +0400" }, "message": "bgpd: Remove AS Path limit/TTL functionality\n\n* draft-ietf-idr-as-pathlimit doesn\u0027t seem to have gone anywhere, and its\n author does not think it will make progress in IDR. Remove all support\n introduced for it, but leave stubs for the commands to avoid breaking\n any configurations.\n\n Basically reverts cecab5e9725792e60a5e4b473e238a14cd85815d.\n(cherry picked from commit c8f3fe3063cb9ff193b13011cfbda3e605395340)\n\nConflicts:\n\n\tbgpd/bgp_attr.c (caused by c8e7b895, resolved)\n" }, { "commit": "213b6cd9fb24381563d6d44c7ddc4700abfae676", "tree": "9ea3fcf3e773144f136c47db3236ecdd5d9a5e12", "parents": [ "08a7a91646a1ee317c402b421e3a7036a640bcf4" ], "author": { "name": "Vladimir L Ivanov", "email": "wawa@yandex-team.ru", "time": "Thu Oct 21 14:59:54 2010 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Oct 21 14:59:54 2010 +0400" }, "message": "bgpd: fix printed value of last-update timestamp\n\n* bgp_route.c: (route_vty_out_detail) calculate time value\n in a way, which works regardless of monotonic clock\n being used or not\n" }, { "commit": "4c9641ba4df276080c670e03f65b1d442660a50f", "tree": "15085df8068d8a3864224937eaa407c0484ff57f", "parents": [ "11d3fe9b9a327b3218a76b2b9001ace50c08de8c" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Thu Jul 22 13:20:55 2010 -0400" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Wed Oct 06 12:33:05 2010 -0400" }, "message": "bgpd, lib: adopt afi_t and safi_t in several places\n\n* bgpd/bgp_attr.c, bgpd/bgp_open.h, bgpd/bgp_route.c, lib/prefix.c,\n lib/prefix.h: Various integer types were being used where, if we\n had strict type checking, afi_t and safi_t would be required.\n\nSigned-off-by: G.Balaji \u003cbalajig81@gmail.com\u003e\n(cherry picked from commit c8af35ffa2dc79ff7d7ff00b1b61f1f50a100ab6)\n" }, { "commit": "65957886bfd0dd9d95360d8b015781fc82cc09be", "tree": "71352e214bd59277a50a43779bb2cbafbace6cc3", "parents": [ "2cd754de60210748e61069fed2c9d4086d24c21e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "message": "bgp: use monotonic clock for time of day\n\nBGP uses time() to get system time of day; but that value\nfluctuates with time adjustments from NTP. This can cause premature\nflapping of peer sessions and other failures.\n\nUse the system monotonic clock supported by Quagga thread library\nto avoid issue.\n\nSee: http://bugzilla.vyatta.com/show_bug.cgi?id\u003d4467\n\n* bgpd/bgp_fsm.c\n * bgp_uptime_reset(): dismiss function\n* bgpd/bgpd.c\n * bgp_clock(): new function\n* bgpd/bgp_damp.c\n * bgp_reuse_timer(): employ bgp_clock() instead of time(NULL)\n * bgp_damp_withdraw(): idem\n * bgp_damp_update(): idem\n * bgp_damp_scan(): idem\n * bgp_damp_info_vty(): idem\n * bgp_damp_reuse_time_vty(): idem\n* bgpd/bgp_fsm.c\n * bgp_routeadv_timer(): idem\n * bgp_stop(): idem\n * bgp_establish(): idem\n* bgpd/bgp_packet.c\n * bgp_update_receive(): idem\n* bgpd/bgp_route.c\n * bgp_update_rsclient(): idem\n * bgp_update_main(): idem\n * bgp_static_update_rsclient(): idem\n * bgp_static_update_main(): idem\n * bgp_static_update_vpnv4(): idem\n * bgp_aggregate_route(): idem\n * bgp_aggregate_add(): idem\n * bgp_redistribute_add(): idem\n* bgpd/bgp_snmp.c\n * bgpPeerTable(): idem\n * bgpTrapEstablished(): idem\n * bgpTrapBackwardTransition(): idem\n* bgpd/bgpd.c\n * peer_create(): idem\n * peer_uptime(): idem\n * bgp_master_init(): idem\n" }, { "commit": "9e4ca89c3678431560a8259c75f8b5874d83d351", "tree": "178ca0de4c6fe5ecba90b51c5fb29c3e0b720cdb", "parents": [ "cc2dd9280c4456586080d1cf4537d26c02fa9a36" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 11:57:05 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 11:57:05 2009 +0300" }, "message": "bgpd: compile warnings cleanup\n\n* bgpd/bgp_fsm.c\n * bgp_clearing_completed(): only used in one file, can be static\n* bgpd/bgp_packet.c\n * afi2str(): sayonara\n * safi2str(): sayonara\n* bgpd/bgp_route.c\n * bgp_distance_reset(): sayonara\n* bgpd/bgp_zebra.c\n * bgp_ifindex_by_nexthop(): sayonara\n" }, { "commit": "638b70ba9893705bb3268aa00c25b8cb0e060b32", "tree": "51eaabdcfba4bfd4b5aa54c7a1b20298c9e2fc2a", "parents": [ "a294365797da8b72e51507cbf92dbc6940e5103b" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:25:16 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:44:41 2009 +0100" }, "message": "[bgp] Fix nexthop reachability check on confederations\n\n* bgp_route.c: (bgp_update_main) Nexthop reachability should be checked for\n confederations too in case a prefix is received from more than one\n confederation peers.\n" }, { "commit": "a294365797da8b72e51507cbf92dbc6940e5103b", "tree": "618569bcf8a1a5d4f7a0a8192692c5d3e27bbb02", "parents": [ "e8eb000e15e2bbe63467d7c056f2b21b72ba7bd6" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:02:04 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:02:04 2009 +0100" }, "message": "[bgpd] fix typo made by paul in previous commit\n" }, { "commit": "e7cc3b383e5e9190aa7784554c605a3a661ebe2b", "tree": "3f7b254d2e47805d4a39c43bd0c6f459e512732a", "parents": [ "67b9467f6cad5097a3e4c6e49348be4d6c17a5bb" ], "author": { "name": "Nick Hilliard", "email": "nick@inex.ie", "time": "Tue Mar 17 22:14:25 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 11:34:27 2009 +0100" }, "message": "[bgpd] Small buffer overrun in bgp_clear_node_queue_init\n\n* bgp_route.c: (bgp_clear_node_queue_init) fix buffer\n overrun.\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "650f76c2e1b0b12e1c46fdd3be22c5f505245d83", "tree": "43322ab134a9e79ee65ca0300f2106f690b5c925", "parents": [ "439c52f19007badffc6707673121f5a76784e728" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 25 18:06:31 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 26 16:12:19 2009 +0100" }, "message": "[bgpd] Log a debug/update warning if filters are configured but don\u0027t exist\n\n* bgp_route.c: (bgp_{input,output}_filter) Log a debug warning if a route is\n received or sent and a filter name is configured for a prefix, as or\n distribute list but none is found - guaranteed configuration mistake.\n" }, { "commit": "2a71e9ce89c6f76c099dea67dddbe8da454d9de7", "tree": "8c53b6694e72751330fab48c02a793d67f2df24c", "parents": [ "014b670e02cc1f38e8e4e786269fc1787412f9b7" ], "author": { "name": "Tomasz Pala", "email": "gotar@pld-linux.org", "time": "Wed Jun 24 21:36:50 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jun 24 21:36:50 2009 +0100" }, "message": "[bgpd] Add \u0027show ip bgp view WORD neighbors IP (advertised|received)-routes\u0027\n\n* bgp_route.c: Was missing these commands.\n" }, { "commit": "50aef6f3b0e36b56cfa9f3d374be0c1d25c30c45", "tree": "5dce97de6229713c6c209cbb72abc1093fa1be58", "parents": [ "6e79f8bba438823d84b7464a9acc1e6fc9126a27" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Tue Jun 23 06:06:49 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 23 14:25:20 2009 +0100" }, "message": "Fix \"show ip bgp dampened-paths\" garbage output.\n\n* bgpd/bgp_damp.c: Make bgp_damp_reuse_time_vty() accept a buffer and\n length, rather than returning a local var buffer whose contents can get\n trounced. Remove duplicate BGP_UPTIME_LEN define.\n* bgpd/bgp_damp.h: bgp_damp_reuse_time_vty() prototype change.\n* bgpd/bgp_route.c: Provide bgp_damp_reuse_time_vty() with a buffer and\n length. Remove duplicate BGP_UPTIME_LEN define.\n\nThis problem was noticed in 2005...\n\n http://hibernia.jakma.org/~paul/patches/quagga-test.diff\n\n...but the fix didn\u0027t make it into the code.\n\nSigned-off-by: Chris Caputo \u003cccaputo@alt.net\u003e\n" }, { "commit": "0088b5dc55a91d27e572484e61df71b8ca2eddf4", "tree": "f93714f98d12890f961794cd026b6bf2de75105e", "parents": [ "dde7258666fd73878b4cc10b4b5b7c07e9be049e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu May 21 08:51:03 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd] reference count the BGP instance\n\nWhen a BGP instance is deleted with lots of routes and neighbors\nit is possible for the peer rsclient queue to run after\nbgp_delete has been called. This would lead to bgpd crashing,\nsee https://bugzilla.vyatta.com/show_bug.cgi?id\u003d3436\n\nThe fix is to add reference counting to the BGP instance and defer\nactual freeing until all references are gone.\n\nThis patch also fixes a memory leak where the self-reference\npeer instance was being created but never freed.\n\nThe check in bgp_clear_route is no longer valid because it is possible\nfor it to be called when peer is in Deleted state during cleanup.\n" }, { "commit": "dde7258666fd73878b4cc10b4b5b7c07e9be049e", "tree": "9275ed492957279eaf8bfa0c02fc141247309c09", "parents": [ "9607d98cb04e5dff34cb2f6fb6434455c6841ab8" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 08 15:19:07 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd] Make declarations match\n\nThese variables are const.\n" }, { "commit": "66e5cd87194ae6fdd51061a91b4698bc0a652f6b", "tree": "659d31f9a7dfb8d9ad9a51f37ff0853054a45399", "parents": [ "cedd7f2fa6823bca9ddcfb062f97ed83b11a80dd" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Feb 09 10:14:16 2009 -0800" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:09:03 2009 +0100" }, "message": "[cleanup] functions taking no args should be declared with void args\n\nUse Ansi-C prototypes rather than old K\u0026R method of declaring\nfunction without arguments\n" }, { "commit": "393deb9bd663361e6b110d579a8b1d4c22667068", "tree": "e93ebf2f57bf92ff7a9cd045764b3cdbb99a07e5", "parents": [ "3453a7122c1d585ad789ed0f63deb90cc5e89fae" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Aug 18 14:13:29 2008 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:07:49 2009 +0100" }, "message": "[cleanup] Convert XMALLOC/memset to XCALLOC\n\nSimple conversion of XMALLOC/memset to XCALLOC\n" }, { "commit": "aea339f72807c34a7916d8614e030069815e144c", "tree": "7b0ab93dcfec82736f05ac39106096360e4ceeb5", "parents": [ "c540835eaf0cb59921969537d8e94cc83bb717f5" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "message": "[bgpd] AS4 bugfix by Chris Caputo \u003cccaputo@alt.net\u003e\n\n* bgpd/bgp_aspath.c: (aspath_make_str_count) \"assert (len \u003c str_size)\" was\n getting hit under certain 4-byte ASN conditions. New realloc strategy.\n* bgpd/bgp_aspath.c: (aspath_key_make) const warning fix.\n\n\"%d\" -\u003e \"%u\" 4-byte ASN corrections. Prevent negative number when ASN is\nabove 2^31.\n" }, { "commit": "a8bf6f526ee578a894c72eabae733f0b60abca63", "tree": "855f05041c4ef5a4f201ef2d3fe869b68b95542d", "parents": [ "6e687d74f74f36bc9d503e29377e7d42f3427221" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Wed Sep 24 17:23:11 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Sep 24 17:23:11 2008 +0100" }, "message": "[bgpd] Fix definition of an rsclient command\n\n* bgp_route.c: (show_ip_bgp_view_rsclient_route_cmd) Add the missing \"ip\"\n to the command string.\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "62687ff1cd3d4460cdbd4b0fbf1e3298fe277ad2", "tree": "6bea5c1cf07d9d702c95fabe356fcec418b91398", "parents": [ "b38309a4ee831a440ef78f8a27db584f2f8e8276" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Aug 23 14:27:06 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sat Aug 23 14:27:06 2008 +0100" }, "message": "[vty] Add support for a \u0027restricted mode\u0027 with anonymous vty connections\n\n\t* lib/command.h: Add a RESTRICTED_NODE, intended for use with\n\t anonymous, \u0027no login\u0027 vtys, to provide a subset of \u0027view\u0027 mode\n\t commands.\n\t* lib/command.c: Add RESTRICTED_NODE bits, nothing special, just\n\t following VIEW_NODE.\n\t* lib/vty.c: (vty_auth) enable authentication should fall back to\n\t restricted/view node as appropriate.\n\t (vty_create) init vty\u0027s to restricted/view node as appropriate,\n\t for the \u0027no login\u0027 case.\n\t (vty_{no_,}restricted_mode_cmd) config commands to enable\n\t \u0027anonymous restricted\u0027 in vty configuration.\n\t (vty_config_write) \u0027anonymous restricted\u0027 config.\n\t (vty_init) Install some commands to restricted mode, and the\n\t \u0027anonymous restricted\u0027 config commands into VTY_NODE.\n\t* bgpd/*.c: Install some of the safe(r) BGP commands into\n\t \u0027restricted mode\u0027, i.e. lookup commands of non-sensitive data.\n\t Useful with looking-glass route-servers.\n" }, { "commit": "30a2231a4881f53deca61ef7a62b225a43dab4c5", "tree": "f26dff922a4f85d302fa67bbd9a120108db41c44", "parents": [ "f5612dd382d9c0f4089b08ec164c25a8082d9f89" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Aug 15 14:05:22 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:59 2008 +0100" }, "message": "[warnings] Fix various SOS warnings\n\n2008-08-15 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* */*: Fix various problems flagged by Sun Studio compiler.\n\t - \u0027\u003cqualifier\u003e \u003cstorage\u003e\u0027 obsolescent in declarations\n\t - empty statements (\u0027;\u0027 after ALIAS definitions)\n\t - implicit declarations (e.g printstack in lib/log.c)\n\t - \"\\%\" in printf string instead of \"%%\"\n\t - loops that return on the first iteration (legitimately, but\n \t compiler can\u0027t really know), e.g. bgp_routemap.c\n \t - internal declarations which mask prototypes.\n" }, { "commit": "750e814693050bc97391eec618aad9db798ee5e8", "tree": "03d3e27a68b0593002d8f73609235919c030e426", "parents": [ "851a1a5c146b346d8b8f58fe3924baa5c208f865" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 21:11:48 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 21:11:48 2008 +0000" }, "message": "[bgpd] Fix triggerable crash when compiled with --disable-bgp-announce\n\n2008-07-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* HACKING: Document preference for compiler conditional code, over\n\t cpp conditional.\n\t* configure.ac: DISABLE_BGP_ANNOUNCE always should be defined.\n\t* bgp_{packet,route,advertise}.c: change to compiler testing of\n\t DISABLE_BGP_ANNOUNCE, rather than cpp.\n\n2008-07-22 MIYAJIMA Mitsuharu \u003cmiyajima.mitsuharu@anchor.jp\u003e\n\n\t* bgp_packet.c: (bgp_update_packet_eor) Fix crash triggerable\n\t if a bgpd was compiled with --disable-bgp-announce and if GR is\n\t advertised by peer.\n" }, { "commit": "841f7a57b13b8cba4efd51db4e7ac13fd403b17b", "tree": "27179c9db7a6d8e7e3dc2d13eb82efda4d9c4eb1", "parents": [ "693b67b2b20510e0faee87a0950595832ce71054" ], "author": { "name": "Denis Ovsienko", "email": "linux@pilot.org.ua", "time": "Thu Apr 10 11:47:45 2008 +0000" }, "committer": { "name": "Denis Ovsienko", "email": "linux@pilot.org.ua", "time": "Thu Apr 10 11:47:45 2008 +0000" }, "message": "+ [bgpd] Added new route-map set statement: \"as-path ignore\"\n" }, { "commit": "9eda90ce8094683a5315007fbd0f9249a284f36f", "tree": "1d861050148c03dc4c37a1266c4567b24e9e6da1", "parents": [ "6d134fb4defecb16591adbf4acb020acd165a75a" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Aug 30 13:36:17 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Aug 30 13:36:17 2007 +0000" }, "message": "[bgpd] bug #398 Bogus free on out route-map, and assert() with rsclients\n\n2007-08-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_announce_check) Fix bug #398, slight\n\t modification of Vladimir Ivanov\u0027s suggested fix - to keep\n\t memory alloc conditional.\n\t (bgp_process_announce_selected) Don\u0027t take struct attr as\n\t argument, none of the callers need it and it needlessly\n\t distances allocation from use.\n\t Free the extended attr, the attr itself is on the stack.\n\t Fix bad indentation.\n\t* bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,\n\t and adjust conditional to test attr-\u003eextra, diagnosis by\n\t Vladimir Ivanov in bug #398.\n\n2007-08-27 Vladimir Ivanov \u003cwawa@yandex-team.ru\u003e\n\n\t* bgp_route.c: (bgp_announce_check_rsclient) copy of\n\t ri-\u003eattr is no longer deep enough, due to addition of\n\t attr-\u003eextra. It should use bgp_attr_dup, as\n\t bgp_announce_check() does.\n" }, { "commit": "41367172d812354c05b11818346f0d49c2245aef", "tree": "eb8f83ec0e93cb5a1d8470afd5c79ce55bc853da", "parents": [ "6d58272b4cf96f0daa846210dd2104877900f921" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "message": "[bgpd] Add support for AS_PATHLIMIT / draft-ietf-idr-as-pathlimit\n\n2007-07-31 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Support for draft-ietf-idr-as-pathlimit-03.\n\t* bgp_attr.h: (struct attr) Add pathlimit struct\n bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.\n (attrhash_key_make) tally pathlimit too\n (attrhash_cmp) cmp pathlimit attr\n (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.\n (bgp_attr_parse) ditto\n (bgp_packet_attribute) Write out AS_PATHLIMIT when set\n (bgp_dump_routes_attr) ditto\n * bgp_route.h: (struct bgp_static) Add TTL field\n * bgp_route.c: (bgp_announce_check) Drop paths that are over\n their hop-count TTL before sending via EBGP.\n Mangle ASN in pathlimit for confeds/private as best we can.\n (bgp_static_update_{rsclient,main}) Add any configure pathlimit\n information.\n (bgp_pathlimit_update_parents) New, update atomic-aggr setting for\n parents of an aspathlimit\u0027ed static.\n (bgp_static_set) Add TTL argument, for all the \u0027bgp network\u0027\n commands.\n Call previous for TTL changed statics.\n (bgp_static_unset) Call pathlimit_update_parents.\n (various bgp network commands) Add \u0027pathlimit \u003c0-255\u003e\u0027 qualifier\n to all the various forms, bar route-map - which can set ttl\n itself.\n * bgp_routemap.c: (general) Add support for \u0027set pathlimit ttl\u0027 and\n \u0027match pathlimit as\u0027.\n * doc/bgpd.texi: Document \u0027network ... pathlimit \u003cttl\u003e\u0027\n" }, { "commit": "b24970241aa19c780a00f0e9c865b98c239a27f2", "tree": "f04b9c6a50a944edd461d66da8f65d226437d964", "parents": [ "e733f949448e1cf9fa27e8b618c56a0e4badc1af" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Jun 14 11:17:58 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Jun 14 11:17:58 2007 +0000" }, "message": "[bgpd] bug #370, default-originate was broken by a silly thinko\n\n2007-05-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_default_originate) Sanity check added\n\t previously was broken and always failed, thus this function\n\t never could run, bug #370.\n" }, { "commit": "fb982c25aa771b7c7425a3c3cce0a2cda0a715de", "tree": "74aa4dc86b04365d90a1030682796421b0eff011", "parents": [ "5921ef9aae3b5d6ff8663298f649fb9d76594acd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "message": "[bgpd] Trim memory usage of BGP routes\n\n2007-05-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: (struct info) Move less frequently used\n\t fields to a lazily allocated struct info_extra.\n\t Export bgp_info_extra_get\n\t* bgp_route.c: (bgp_info_extra_new) allocate extra\n\t (bgp_info_extra_free) Free damp info and the info_extra.\n\t (bgp_info_extra_get) Retrieve the info_extra of a struct\n\t info, allocating as required.\n\t (generally) adjust to use info-\u003eextra\n\t* bgp_damp.c: (generally) use bgp_info_extra_get to access\n\t dampinfo\n\t* bgp_attr.h: Move rarely allocated attributes from struct attr\n\t to a struct attr_extra, for a substantial saving in size of\n\t struct attr.\n\t* bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.\n\t (bgp_attr_extra_get) Get the attr_extra for a given struct\n\t attr, allocating it if needs be.\n\t (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.\n\t (generally) adjust to know about attr-\u003eextra.\n\t* bgp_debug.c: (bgp_dump_attr) ditto\n\t* bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.\n\t* bgp_nexthop.c: (generally) adjust to know about attr-\u003eextra\n\t and info-\u003eextra.\n\t* bgp_{packet,routemap,snmp,zebra}.c: ditto\n\t* lib/memtypes.c: Add MTYPE_ATTR_EXTRA and MTYPE_BGP_ROUTE_EXTRA\n" }, { "commit": "16d2e2410d6e8cf53fac05b956f3e7ee53bc7234", "tree": "4679c5ed9d1ec64d41da13a44c1fcad76e4da9be", "parents": [ "d9a18f1113b915dd0d2a4883a9149f06dd61352e" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:32:10 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:32:10 2007 +0000" }, "message": "[bgpd] V. quick route flap gets mistaken for duplicate, route is then ignored\n\n2007-04-08 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for\n\t bgp static routes, but for main BGP RIB: Quick \u0027flap\u0027 of routes\n\t can cause bgpd to mistake a new route for a duplicate route,\n\t due to presence of removed, but not yet processed BGP RIB entry.\n\t (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,\n\t restore route instead.\n\t (bgp_update_main) Ditto.\n" }, { "commit": "f2c31acb6f97688af0f368211536829324145919", "tree": "6f9887992eeb0890fdf673f9c0794e7d1384edbb", "parents": [ "553bdfe376c49886cbdc2d306fea7b003bead31f" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Feb 22 17:48:42 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Feb 22 17:48:42 2007 +0000" }, "message": "[bgpd] Peer delete can race with reconfig leading to crash\n\n2007-02-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_fsm.c: (bgp_fsm_change_status) Handle state change into\n\t clearing or greater here. Simpler.\n\t (bgp_event) Clearing state change work moved to previous\n\t* bgp_route.c: (bgp_clear_route_node) Clearing adj-in here\n\t is too late, as it leaves a race between a peer being deleted\n\t and an identical peer being configured before clearing\n\t completes, leading to a crash.\n\t Simplest fix is to clean peers Adj-in up-front, rather than\n\t queueing such work.\n\t (bgp_clear_route_table) Clear peer\u0027s Adj-In and Adj-Out\n\t up-front here, rather than queueing such work.\n\t Extensive comment added on the various bits of indexed data\n\t that exist and how they need to be dealt with.\n\t (bgp_clear_route) Update comment.\n" }, { "commit": "8d45210e7c9e221b519d975825cb83aea5ebe47e", "tree": "62629c7693b24c3b4a8e37eed7abe51e5695417d", "parents": [ "435408866187f3bc3c49b26f11bc83c374e55dd5" ], "author": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Tue Nov 28 19:50:46 2006 +0000" }, "committer": { "name": "Andrew J. Schorr", "email": "ajschorr@alumni.princeton.edu", "time": "Tue Nov 28 19:50:46 2006 +0000" }, "message": "[bgpd] Fix bug where a deleted route that was quickly re-added was being lost\n\n2006-11-28 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* bgp_route.c: (bgp_info_restore) New function that undoes\n\t the effects of a previous call to bgp_info_delete. This is\n\t used when a route is deleted and quickly re-added before the\n\t deletion has been processed.\n\t (bgp_static_update_rsclient, bgp_static_update_main,\n\t bgp_redistribute_add) Check whether a pre-existing route\n\t has the BGP_INFO_REMOVED set, and, if so, we need to call\n\t bgp_info_restore to resurrect it.\n" }, { "commit": "56395af70588c8fda89bf5ef327df64b5efbeb67", "tree": "d3289e371b8296bc8e09d5e3464e331a040c31c6", "parents": [ "8fb8a504e2c7c216b34c58e5658d84cb7dbe79b0" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Oct 27 16:58:20 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Oct 27 16:58:20 2006 +0000" }, "message": "[bgpd] trivial: non C99 u_int.._t should be uint.._t\n\n2006-10-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be\n\t uintXX_t\n" }, { "commit": "6f58544db526b4dfb09d45f8507926b0ae5fe12b", "tree": "f73d22b4ff92eaef337a6d9af8a1923d730e9a21", "parents": [ "ed3ebfa36b45fe487015e1918e848f0ff4500bff" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 22 19:13:07 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 22 19:13:07 2006 +0000" }, "message": "[bgpd] struct peer must have bgp field valid (redistribute crash)\n\n2006-10-19 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd.c: (peer_new) bgp element of peer absolutely must be\n\t filled in, make peer_new() require it as argument and update\n\t all callers. Fixes a crash reported by Jan \u0027yanek\u0027 Bortl and\n\t Andrew Schorr where bgpd would crash in bgp_pcount_adjust\n\t trying to dereference the bgp member of bgp-\u003epeer_self,\n\t triggered through redistribution.\n\t* bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.\n" }, { "commit": "53d9f67a18dc59fd688fce999cb35653010a54fb", "tree": "8412f230b56f658361b99f773395157703bcad7d", "parents": [ "dcdf399fbc7420d3edc230c9646f720825fcecda" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 15 23:41:16 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 15 23:41:16 2006 +0000" }, "message": "[bgpd] CID#73, potential crash in bgp statistics if called for AFI/SAFI with emtpy table\n\n2006-10-15 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_table_stats_walker) NULL deref if table is\n\t empty, bgp_table_top may return NULL, Coverity CID#73.\n" }, { "commit": "09dd561eb444ab009103b2dde62db212eae7064a", "tree": "e7763c690dec621ca81370721f6c7b6cd38a5b10", "parents": [ "8383a9bd2721dbd8fb1b657269a2cdc40b4226e1" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 03:38:16 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 03:38:16 2006 +0000" }, "message": "[bgpd] reduce the process queue hold time to something more sensible\n\n2006-09-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_process_queue_init) process queue hold time\n\t too high, adds extra memory load. Change to be much lower,\n\t until such time as it\u0027s made configurable.\n" }, { "commit": "8383a9bd2721dbd8fb1b657269a2cdc40b4226e1", "tree": "573d50347b4b45eabebbcc30263c4bb45a61bb2f", "parents": [ "9fde6624fc480995449d8243fe85602d89927eb6" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 03:06:54 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 03:06:54 2006 +0000" }, "message": "[bgpd] RIB statistics address space size shouldnt double count space\n\n2006-09-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_table_stats_walker) Address space announced\n\t should only count top-level unaggregateable prefixes, to\n\t avoid falling afoul of anti-dodgy-accounting regulations\n\t in various jurisdictions.. ;)\n" }, { "commit": "ca058a30b1ea57f83871ab4cf1c9a91ea4064d52", "tree": "ab38ab59bad607c9b41a093cb8b35bec766f30b3", "parents": [ "2815e61ffbbf9c362896f3912d925cf78e125ee1" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 02:58:49 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 02:58:49 2006 +0000" }, "message": "[bgpd] Fix 0.99 shutdown regression, introduce Clearing and Deleted states\n\n2006-09-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Fix some niggly issues around \u0027shutdown\u0027 and clearing\n\t by adding a Clearing FSM wait-state and a hidden \u0027Deleted\u0027\n\t FSM state, to allow deleted peers to \u0027cool off\u0027 and hit 0\n\t references. This introduces a slow memory leak of struct peer,\n\t however that\u0027s more a testament to the fragility of the\n\t reference counting than a bug in this patch, cleanup of\n\t reference counting to fix this is to follow.\n\t* bgpd.h: Add Clearing, Deleted states and Clearing_Completed\n\t and event.\n\t* bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and\n\t Deleted.\n\t* bgp_fsm.h: Don\u0027t allow timer/event threads to set anything\n\t for Deleted peers.\n\t* bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted\n\t needs to stop everything.\n\t (bgp_stop) Remove explicit fsm_change_status call, the\n\t general framework handles the transition.\n\t (bgp_start) Log a warning if a start is attempted on a peer\n\t that should stay down, trying to start a peer.\n\t (struct .. FSM) Add Clearing_Completed\n\t events, has little influence except when in state\n\t Clearing to signal wait-state can end.\n\t Add Clearing and Deleted states, former is a wait-state,\n\t latter is a placeholder state to allow peers to disappear\n\t quietly once refcounts settle.\n\t (bgp_event) Try reduce verbosity of FSM state-change debug,\n\t changes to same state are not interesting (Established-\u003eEstablished)\n\t Allow NULL action functions in FSM.\n\t* bgp_packet.c: (bgp_write) Use FSM events, rather than trying\n\t to twiddle directly with FSM state behind the back of FSM.\n\t (bgp_write_notify) ditto.\n\t (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else\n\t this patch crashes, now it leaks instead.\n\t* bgp_route.c: (bgp_clear_node_complete) Clearing_Completed\n\t event, to end clearing.\n\t (bgp_clear_route) See extensive comments.\n\t* bgpd.c: (peer_free) should only be called while in Deleted,\n\t peer refcounting controls when peer_free is called.\n\t bgp_sync_delete should be here, not in peer_delete.\n\t (peer_delete) Initiate delete.\n\t Transition to Deleted state manually.\n\t When removing peer from indices that provide visibility of it,\n\t take great care to be idempotent wrt the reference counting\n\t of struct peer through those indices.\n\t Use bgp_timer_set, rather than replicating.\n\t Call to bgp_sync_delete isn\u0027t appropriate here, sync can be\n\t referenced while shutting down and finishing deletion.\n\t (peer_group_bind) Take care to be idempotent wrt list references\n\t indexing peers.\n" }, { "commit": "2815e61ffbbf9c362896f3912d925cf78e125ee1", "tree": "8cc9c2cc857f12e3c22813f756fb8fd674757e1b", "parents": [ "9458b8191563eb5569f341172484a234ef2f743e" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 02:56:07 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 02:56:07 2006 +0000" }, "message": "[bgpd] Add RIB reporting commands, show bgp ... statistics\n\n2006-09-13 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_aspath.c: (aspath_highest) new, return highest ASN in an\n\t aspath.\n\t* bgp_route.c: (bgp_peer_count_walker) new, do the walk done\n\t in bgp_peer_counts as a thread.\n\t (bgp_peer_counts) move walk to previous and call it via\n\t thread_execute so this RIB walk shows up in thread stats.\n\t (bgp_table_stats) New, gather some statistics for a given\n\t RIB.\n\t (bgp_table_stats_walker) New, RIB walker thread for former.\n\t (bgp_table_stats_vty) Parsing front-end for \u0027show bgp ...\u0027,\n\t useful model for future rationalisation of \u0027show ... bgp\u0027.\n\t (bgp_route_init) Add new RIB stats commands.\n" }, { "commit": "1a392d46db1917dfca2ddd06d7f0021396f8ecfa", "tree": "8dec4a2e583c9a1890fd62d647dcd5a27d14bde1", "parents": [ "ff7924f6c0437e2f3cc3710570414ae87a828724" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 07 00:24:49 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 07 00:24:49 2006 +0000" }, "message": "[bgpd] Handle pcount as flags are changed, fixing pcount issues\n\n2006-09-06 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Squash any and all prefix-count issues by\n\t abstracting route flag changes, and maintaining count as and\n\t when flags are modified (rather than relying on explicit\n\t modifications of count being sprinkled in just the right\n\t places throughout the code).\n\t* bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.\n\t (bgp_pcount_adjust) new, update prefix count as\n\t needed for a given route.\n\t (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status\n\t flag, calling previous function when appropriate.\n\t (general) Update all set/unsets of flags to use previous.\n\t Remove pcount_{dec,inc}rement calls.\n\t No need to unset BGP_INFO_VALID in places where\n\t bgp_info_delete is called, it does that anyway.\n\t* bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.\n\t* bgp_route.h: Export bgp_info_{un,}set_flag.\n\t Add a \u0027meta\u0027 BGP_INFO flag, BGP_INFO_UNUSEABLE.\n\t Move BGP_INFO_HOLDDOWN macro to here from bgpd.h\n" }, { "commit": "ff7924f6c0437e2f3cc3710570414ae87a828724", "tree": "e7e7e1910839845b37b4fa3f7ebc3d935ff9de99", "parents": [ "b5aeb4410ae3722a5f331850acbc84c39e3fcd9f" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Sep 04 01:10:36 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Sep 04 01:10:36 2006 +0000" }, "message": "[bgpd] Add \u0027show ... neighbor .... prefix-counts\u0027 command\n\n2006-09-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: Add \u0027show ... bgp ... \u003cneighbour\u003e prefix-count\u0027\n\t commands, to provide detailed counts of prefixes for a peer.\n\t Informative, and should help pin down to pfxcnt drift\n\t problems.\n" }, { "commit": "b2518c1e884cb8b4f4502f8b90b1c368e1a352ec", "tree": "7099a9dd8bf20d560ed9565b8ecc9eaaf50bd203", "parents": [ "06e110f9372f61bea23c2eaa25e7850b254bbd1a" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:48:40 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:48:40 2006 +0000" }, "message": "[bgpd] CID #4,#5,#9,#10, simplify aspath_print_vty usage\n\n2006-05-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_aspath.{c,h}: (aspath_print_vty) take a format string,\n\t so as to reduce burden on callers, all in bgp_route.c\n\t* bgp_route.c: (route_vty_out{,tmp}) Update to match\n\t aspath_print_vty, simplifying checks needed to get spacing\n\t right. CID #4,#5.\n\t ({damp,flap}_route_vty_out) Ditto, CID #9, #10\n" }, { "commit": "06e110f9372f61bea23c2eaa25e7850b254bbd1a", "tree": "a705c52302d9044f6ae7121ec7eadb62a072d5fe", "parents": [ "dd8103a917c356abfdd166879186df2e5d1ca95a" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:29:22 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:29:22 2006 +0000" }, "message": "[bgpd] CID #6, remove useless NULL check, bgp_static_update_rsclient\n\n2006-05-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_static_update_rsclient) Remove useless NULL\n\t check, code already assumes bgp_static can not be NULL,\n\t fixes CID #6.\n" }, { "commit": "dd8103a917c356abfdd166879186df2e5d1ca95a", "tree": "03319c6b4338b847ad244c3e88dbddb7e6c12f16", "parents": [ "34c3f81b542c7f91fa04a43f7d0a8a4482f22d4d" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:27:30 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:27:30 2006 +0000" }, "message": "[bgpd] CID #7, remove useless NULL check, bgp_static_update_main\n\n2006-05-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_static_update_main) Remove useless NULL\n\t check, code already assumes bgp_static can not be NULL,\n\t fixes CID #7.\n" }, { "commit": "da5b30f6fb9437f1dc3d05a48e5e17f78695f820", "tree": "baa0663a2aea52399162c3e8e69be7ef8f54a4c7", "parents": [ "7a559cbe8f794d298419a8ada80a9f12933eceda" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon May 08 14:37:17 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon May 08 14:37:17 2006 +0000" }, "message": "[bgpd] Bug #240, Fix route-server crash when static routes are configured\n\n2006-05-08 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_afi_node_get) given table should never be\n\t NULL, check/assert this.\n\t (bgp_static_update) Bug #240. Rsclients should only be passed\n\t the static update if they are configured for the afi,safi.\n" }, { "commit": "65ca75e0d1e7e440bf0d2a6a031d4148024c9d12", "tree": "71826429ce3985bf3900be4a965de238ac668e82", "parents": [ "a3b6ea56a0add7d0972a66d96e1fbcf5461eecdb" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 08:08:15 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 08:08:15 2006 +0000" }, "message": "[bgpd] Fix bug where FSM can stay hung forever in Idle/Clrng\n\n2006-05-04 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (general) Fix logical bug in clearing, noted\n\t by Chris Caputo in [quagga-users 6728] - clearing depended on\n\t at least one route being added to workqueue, in order for\n\t workqueue completion function to restart FSM. However, if no\n\t routes are cleared, then the completion function never is\n\t called, it needs to be called manually if the workqueue\n\t didn\u0027t get scheduled.\n\t Finally, clearing is per-peer-session, not per AFI/SAFI, so\n\t the FSM synchronisation should be in bgp_clear_route_table.\n\t (bgp_clear_route_table) Wrong place for FSM/clearing\n\t synchronisation, move to..\n\t (bgp_clear_route) FSM/clearing synchronisation should be\n\t here.\n\t If no routes were cleared, no workqueue scheduled, call\n\t the completion func to ensure FSM kicks off again.\n" }, { "commit": "3e0c78ef8a8fb80f52a36dab99d76a5913281e4c", "tree": "e09c41768a283796fd9def9c65d5500bbe712a69", "parents": [ "5a54df971e7da8aacddbf54afa33bd81b6c01f13" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Mar 06 18:06:53 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Mar 06 18:06:53 2006 +0000" }, "message": "[bgpd] Start off FSM again once clearing finishes.\n\n2006-03-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_clear_node_complete) Doh. When clearing\n\t is complete we need to kick off FSM again.\n" }, { "commit": "64e580a72deaa268e46559516663808503f347ec", "tree": "7b11b71858334f07a72d3885e00f63dd5c8efcf7", "parents": [ "e24f0638e6fc7256580c185a631cbe5549bf7db3" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Feb 21 01:09:01 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Feb 21 01:09:01 2006 +0000" }, "message": "[bgpd] Record afi/safi in bgp_table. Serialise peer clear with FSM.\n\n2006-02-21 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd.h: move the clear_node_queue to be peer specific.\n\t Add a new peer status flag, PEER_STATUS_CLEARING.\n\t* bgp_table.h: (struct bgp_table) Add fields to record afi,\n safi of the table.\n (bgp_table_init) Take afi and safi to create table for.\n * bgp_table.c: (bgp_table_init) record the afi and safi.\n * bgp_nexthop.c: Update all calls to bgp_table_init.\n * bgp_vty.c: ditto.\n * bgpd.c: ditto.\n * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is\n\t clearing.\n * bgp_route.c: (general) Update all bgp_table_init calls.\n (bgp_process_{rsclient,main}) clear_node is serialised\n via PEER_STATUS_CLEARING and fsm now.\n (struct bgp_clear_node_queue) can be removed. struct bgp_node\n can be the queue item data directly, as struct peer can be\n kept in the new wq global user data and afi/safi can be\n retrieved via bgp_node -\u003e bgp_table.\n (bgp_clear_route_node) fix to get peer via wq-\u003espec.data,\n afi/safi via bgp_node-\u003ebgp_table.\n (bgp_clear_node_queue_del) no more item data to delete, only\n unlock the bgp_node.\n (bgp_clear_node_complete) only need to unset CLEARING flag\n and unlock struct peer.\n (bgp_clear_node_queue_init) queue attaches to struct peer\n now. record peer name as queue name.\n (bgp_clear_route_table) If queue transitions to active,\n serialise clearing by setting PEER_STATUS_CLEARING rather\n than plugging process queue, and lock peer while queue\n active.\n Update to pass only bgp_node as per-queue-item specific data.\n" }, { "commit": "7c7fa1b43100b4358ec0217d950b4aa9a2ec4bfd", "tree": "b317ffff8d3c3b432d841698b5814e709082fb2f", "parents": [ "aa94ca86ba0323d61fc3bc9b881718567ee943b3" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Feb 18 10:52:09 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Feb 18 10:52:09 2006 +0000" }, "message": "[bgpd] trivial readability fix\n\n2006-02-18 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_announce_check) trivial, move declaration\n\t of two local variables into the only block where they are\n\t used, to aid the reader.\n" }, { "commit": "902212c3f3df5198a6cdf2c95e4686790e437f6f", "tree": "7587a283dd51a6d5a896111ec294683d077d4274", "parents": [ "306d8890439cdb9128d063ee2f77700a11e6843c" ], "author": { "name": "paul", "email": "paul", "time": "Sun Feb 05 17:51:19 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sun Feb 05 17:51:19 2006 +0000" }, "message": "[bgpd] Fix peer prefix counts and make it slightly more robust\n\n2006-02-05 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: Add BGP_INFO_COUNTED to track whether\n\t prefix has been counted or not.\n\t* bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to\n\t centralise inc/dec of prefix-count,\n\t (bgp_rib_remove) Remove pcount decrement, use helper.\n\t (bgp_rib_withdraw) ditto, additionally use previous function\n\t too.\n\t (bgp_update_main) Use pcount helpers.\n\t (bgp_clear_route_node) ditto, aslo REMOVED routes don\u0027t need\n\t clearing.\n" }, { "commit": "306d8890439cdb9128d063ee2f77700a11e6843c", "tree": "fa5c8e035891cc83e9f5cfa80343df4bcac40fb7", "parents": [ "3a570c8b7b56b5a3042fbc035a01c753440b927c" ], "author": { "name": "paul", "email": "paul", "time": "Thu Feb 02 17:50:19 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Feb 02 17:50:19 2006 +0000" }, "message": "[lib/workqueue] remove the useless \u0027delay\u0027 factor.\n\n2006-02-02 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* workqueue.h: (struct work_queue) Remove the delay field.\n\t It served no purpose and just introduced bad behaviour.\n\t Should be excised before its allowed to escape into 1.0.\n\t This removes need for the \u0027flood\u0027 and runs_since_clear\n\t fields.\n\t* workqueue.c: (general) excise delay factor between queue\n\t runs, hence the \u0027flood\u0027 crap too.. See above.\n\t* bgp_route.c: (bgp_{clear_node,process}_queue_init) delay\n\t field is removed from workqueue spec.\n" }, { "commit": "e8e1946edf6ba87ef53832cdceccc39d7f0c3f26", "tree": "fcdaf92bf4129a8a58825bd21ae841a6b3b2bda8", "parents": [ "779adb0147cfff1a831b08853976342ad2110fcd" ], "author": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "message": "[compiler] miscellaneous trivial compiler warning fixes\n\n2006-01-19 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n * (general) various miscellaneous compiler warning fixes.\n Remove redundant break statements from switch clauses\n which return.\n return from main, not exit, cause it annoys SOS.\n Remove stray semi-colons which cause empty-statement\n warnings.\n\t* zebra/main.c: (sighup) remove private declaration of external\n\t function.\n" }, { "commit": "0fb58d5d7993b638fc46085944d17d3a54d66046", "tree": "9b1195ad505d2c14fdf09036db4f324ff3ec7f18", "parents": [ "76367ea9753aa9cef7cf5d3c954f55b5725f31da" ], "author": { "name": "paul", "email": "paul", "time": "Mon Nov 14 14:31:49 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Nov 14 14:31:49 2005 +0000" }, "message": "2005-11-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* zebra_rib.c: (rib_process) convert to new workqueue specs and\n\t shut up gcc, which complains about cast from void via\n\t function parameters, for some dumb reason. Do the cast\n\t inside the function instead.\n\t (rib_queue_qnode_del) ditto.\n\t (rib_queue_init) no need for the casts anymore.\n" }, { "commit": "fe69a505f7be4357bf8523e3bbdced9c95590f3a", "tree": "6d2450016eb19f30b153b2439d06ade68d1b8f12", "parents": [ "1f8ae70b7b86d132b95a18f0c824deb248987afc" ], "author": { "name": "paul", "email": "paul", "time": "Sat Sep 10 16:55:02 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Sep 10 16:55:02 2005 +0000" }, "message": "2005-09-10 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Makefile.am: bgpd shouldn\u0027t list libgp\u0027s sources as its own.\n\t Use LDADD.\n\t* bgp_aspath.h:\n\t (struct assegment) New struct, abstract representation of a\n\t list of AS_PATH segments and the contained ASNs.\n\t (struct aspath) Remove the raw-data related\n\t fields, reference the abstract struct assegment instead.\n\t Remove several other computed fields, it\u0027s just a\n\t headache to maintain them and they\u0027re cheap to compute from\n\t struct assegment.\n\t (aspath_parse) parse a stream, not a pointer to raw data.\n\t (aspath_count_{hops,confeds,size}) helpers to access\n\t information formerly directly contained in struct aspath.\n\t (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants\n\t to be able to output hex representation of raw data.\n\t* bgp_aspath.c: (general) partial-rewrite. Store aspath data\n\t as an abstract singly-linked list of abstract segments,\n rather than storing the raw data, and parsing it each and\n\t every time. Remove several count/size fields which are cheap\n\t to compute from the abstract segment structure.\n\t (global) Include stream.h, needed for aspath_parse, and\n\t others. Couple of helper macros added.\n\t (struct assegment_header) Just the header, and only the\n\t header.\n\t (assegment_data_{new,free}) convenience functions for\n\t AS_SEG_DATA allocation, the dynamic, per-segment array of\n\t ASNs.\n\t (assegment_{new,free,free_all,dup,dup_all}) convenience\n\t functions for creating struct assegments. The _all forms will\n\t follow the entire chain of segments from the given segment.\n\t (assegment_prepend_asns) new function, prepend an ASN N times\n\t to segment.\n \t (assegment_append_asns) Append a list (array) of ASNs to\n\t segment.\n\t (int_cmp) convenience function for the aspath hash.\n\t (assegment_normalise) new function. Normalise the given\n\t segment chain to meet expectations of Quagga, and to\n\t eliminate differing raw representations of the same paths.\n\t Merge \u0027runs\u0027 of SEQUENCEs into one segment as our internal\n\t segment is not limited by the protocol AS_PATH segment\n\t length. Sort ASNs in SETs.\n\t (aspath_new) Take void argument to quell warnings. Use the\n\t assegment convenience functions.\n\t (assegment_count_{asns,confeds,hops}) new functions to\n\t compute at runtime values previously held in struct aspath.\n\t (aspath_size) ditto.\n\t (aspath_make_str_count) rewritten to stringify new\n\t representation, and to be slightly easier to understand\n\t hopefully.\n\t (aspath_str_update) convenience function, update the aspath\n\t str. Should investigate removing maintained string from\n\t struct aspath, just run-time compute it, as per other fields.\n\t It\u0027s just a maintenance headache, would save noticeable\n\t amount of RAM with possibly not much extra run-time cost.\n\t (aspath_dup) use the assegment dup functions.\n\t (aspath_hash_alloc) Take void * argument to satisfy gcc. Use\n\t the proper helper functions to dup data.\n\t (assegments_parse) new function. parse raw AS_PATH data into\n\t struct assegments. Normalise and return the head of the list.\n\t (aspath_parse) Parse a stream, not pointer to raw data and\n\t use assegments_parse to do it.\n\t (assegment_data_put) Write out a single segment data in protocol\n\t form to stream.\n\t (assegment_header_put) ditto but for segment header.\n\t (aspath_put) new function. As per previous but for an entire\n\t struct aspath.\n\t (aspath_snmp_pathseg) wrapper around aspath_put for\n\t bgp_snmp.c. Uses a static buffer sadly.\n\t (aspath_aggregate_as_set_add) rewritten to use assegments.\n\t (aspath_aggregate) ditto\n\t (aspath_{firstas,loop,private_as}_check) ditto\n\t (aspath_{merge,prepend,add_one_as}) ditto\n\t (aspath_cmp_left{_confed}) ditto\n\t (aspath_delete_confed_seq) ditto, plus fixed to properly\n\t delete all leading confed segments.\n\t (aspath_as_add) Just use assegment_append_asns.\n\t (aspath_segment_add) updated to use assegments.\n\t (enum as_token) Add values for confeds\n\t (aspath_gettoken) Add support for confeds\n\t (aspath_str2aspath) ditto\n\t (aspath_key_make) updated to use as_segments. Also, add\n\t segment type into the hash value as appropriate.\n\t (aspath_cmp) updated to use as_segments.\n\t (aspath_print) don\u0027t segfault on NULL argument.\n\t* bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream\n\t now. No need for manual forwarding of stream.\n\t (bgp_packet_attribute) empty aspath is now denoted by NULL\n\t segment field, length is gone.\n\t Use aspath_size() to determine size.\n\t (bgp_attr_init) Fix declaration, explicitely specify void\n\t arg.\n\t (bgp_dump_routes_attr) Use aspath_size() to determine size.\n\t* bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.\n\t (bgp_rib_withdraw) remove unused variable. Use\n\t aspath_count_hops.\n\t* bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use\n\t aspath_snmp_pathseg to get the representation.\n" }, { "commit": "b7395791a31f7b734094d032998ab632136f36f1", "tree": "8b8e5efb0c0082b882f8a5a9db9eabd3aa9841e7", "parents": [ "a969459c92d6b6cc557a0961aca14059e791bc08" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri Aug 26 12:58:38 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri Aug 26 12:58:38 2005 +0000" }, "message": "\t* bgp_route.c: Third (?) attempt to fix best selection breakage\n\t introduced long time ago with route server patch. Hopefully\n\t it\u0027s last case to fix - route-server client not in peer group.\n\n\t[backport candidate]\n" }, { "commit": "b40d939b477a08d79dbee947aea42ac652090f85", "tree": "fe160cd4514218baea57c2566e318fc66ea9a6ef", "parents": [ "bb5b7552cc4f067fbb25f7a8f0c4fe558a508f3f" ], "author": { "name": "paul", "email": "paul", "time": "Mon Aug 22 22:34:41 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Aug 22 22:34:41 2005 +0000" }, "message": "2005-08-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.\n\t BGP_INFO_VALID is already overloaded, don\u0027t care to do same thing\n\t to STALE or HISTORY.\n\t* bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a\n\t route which should generally be ignored.\n\t* bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather\n\t than doing actual work, so that bgp_process (called directly,\n\t or indirectly via the scanner) can catch withdrawn routes.\n\t (bgp_info_reap) Actually remove the route, what bgp_info_delete\n\t used to do, only for use by bgp_process.\n\t (bgp_best_selection) reap any REMOVED routes, other than the old\n\t selected route.\n\t (bgp_process_rsclient) reap the old-selected route, if appropriate\n\t (bgp_process_main) ditto\n\t (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with\n\t each other. Don\u0027t play games with the VALID flag, bgp_process\n\t is async now, so it didn\u0027t make a difference anyway.\n\t Remove the \u0027force\u0027 argument from bgp_rib_withdraw, withdraw+force\n\t is equivalent to bgp_rib_remove. Update all its callers.\n\t (bgp_update_rsclient) bgp_rib_withdraw and force set is same as\n\t bgp_rib_remove.\n\t (route_vty_short_status_out) new helper to print the leading\n\t route-status string used in many command outputs. Consolidate.\n\t (route_vty_out, route_vty_out_tag, damp_route_vty_out,\n\t flap_route_vty_out) use route_vty_short_status_out rather than\n\t duplicate.\n\t (route_vty_out_detail) print state of REMOVED flag.\n\t (BGP_SHOW_SCODE_HEADER) update for Removed flag.\n" }, { "commit": "94f2b3923e9663d0355a829f22e4e31cf68ee7b8", "tree": "59c0291a76b1c97fbb089abb479307f19cdfd4c1", "parents": [ "7cad40007b9714dba65065916ea68577f9d3d6dd" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) The great bgpd extern and static\u0027ification.\n\t* bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code\n\t (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison\n\t warnings.\n\t* bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these\n\t used by various files which had their own private declarations,\n\t in the case of mplsvpn - incorrect.\n" }, { "commit": "200df115ea0ba6f54151d60fe5e9a7f6948de7c3", "tree": "2aedc0af80d2e805cdf2cefd50432423d2871216", "parents": [ "b31b813671d96ea9e96801508442a90f0ef503fa" ], "author": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "message": "2005-06-01 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd/(general) refcount struct peer and bgp_info, hence allowing us\n\t add work_queues for bgp_process.\n\t* bgpd/bgp_route.h: (struct bgp_info) Add \u0027lock\u0027 field for refcount.\n\t Add bgp_info_{lock,unlock} helper functions.\n\t Add bgp_info_{add,delete} helpers, to remove need for\n\t users managing locking/freeing of bgp_info and bgp_node\u0027s.\n\t* bgpd/bgp_table.h: (struct bgp_node) Add a flags field, and\n\t BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of\n\t nodes.\n\t* bgpd/bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock\n\t peer reference as appropriate.\n\t* bgpd/bgp_damp.c: Remove its internal prototypes for\n\t bgp_info_delete/free. Just use bgp_info_delete.\n\t* bgpd/bgpd.h: (struct bgp_master) Add work_queue pointers.\n\t (struct peer) Add reference count \u0027lock\u0027\n\t (peer_lock,peer_unlock) New helpers to take/release reference\n\t on struct peer.\n\t* bgpd/bgp_advertise.c: (general) Add peer and bgp_info refcounting\n\t and balance how references are taken and released.\n\t (bgp_advertise_free) release bgp_info reference, if appropriate\n\t (bgp_adj_out_free) unlock peer\n\t (bgp_advertise_clean) leave the adv references alone, or else\n\t call bgp_advertise_free cant unlock them.\n\t (bgp_adj_out_set) lock the peer on new adj\u0027s, leave the reference\n\t alone otherwise. lock the new bgp_info reference.\n\t (bgp_adj_in_set) lock the peer reference\n\t (bgp_adj_in_remove) and unlock it here\n\t (bgp_sync_delete) make hash_free on peer conditional, just in\n\t case.\n\t* bgpd/bgp_fsm.c: (general) document that the timers depend on\n\t bgp_event to release a peer reference.\n\t (bgp_fsm_change_status) moved up the file, unchanged.\n\t (bgp_stop) Decrement peer lock as many times as cancel_event\n\t canceled - shouldnt be needed but just in case.\n\t stream_fifo_clean of obuf made conditional, just in case.\n\t (bgp_event) always unlock the peer, regardless of return value\n\t of bgp_fsm_change_status.\n\t* bgpd/bgp_packet.c: (general) change several bgp_stop\u0027s to BGP_EVENT\u0027s.\n\t (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs\n\t along with a comment on it.\n\t* bgpd/bgp_route.c: (general) Add refcounting of bgp_info, cleanup\n\t some of the resource management around bgp_info. Refcount peer.\n\t Add workqueues for bgp_process and clear_table.\n\t (bgp_info_new) make static\n\t (bgp_info_free) Ditto, and unlock the peer reference.\n\t (bgp_info_lock,bgp_info_unlock) new exported functions\n\t (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,\n\t taking care of reference counts.\n\t (bgp_info_delete) do the opposite of bgp_info_add.\n\t (bgp_process_rsclient) Converted into a work_queue work function.\n\t (bgp_process_main) ditto.\n\t (bgp_processq_del) process work queue item deconstructor\n\t (bgp_process_queue_init) process work queue init\n\t (bgp_process) call init function if required, set up queue item\n\t and add to queue, rather than calling process functions directly.\n\t (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts\n\t (bgp_rib_withdraw) ditto\n\t (bgp_update_rsclient) let bgp_info_add manage refcounts\n\t (bgp_update_main) ditto\n\t (bgp_clear_route_node) clear_node_queue work function, does\n\t per-node aspects of what bgp_clear_route_table did previously\n\t (bgp_clear_node_queue_del) clear_node_queue item delete function\n\t (bgp_clear_node_complete) clear_node_queue completion function,\n\t it unplugs the process queues, which have to be blocked while\n\t clear_node_queue is being processed to prevent a race.\n\t (bgp_clear_node_queue_init) init function for clear_node_queue\n\t work queues\n\t (bgp_clear_route_table) Sets up items onto a workqueue now, rather\n\t than clearing each node directly. Plugs both process queues to\n\t avoid potential race.\n\t (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage\n\t bgp_info refcounts.\n\t (bgp_static_update_rsclient) ditto\n\t (bgp_static_update_main) ditto\n\t (bgp_static_update_vpnv4) ditto, remove unneeded cast.\n\t (bgp_static_withdraw) see bgp_static_withdraw_rsclient\n\t (bgp_static_withdraw_vpnv4) ditto\n\t (bgp_aggregate_{route,add,delete}) ditto\n\t (bgp_redistribute_{add,delete,withdraw}) ditto\n\t* bgpd/bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer\n\t reference\n\t (peer_rsclient_unset_vty) ditto, but unlock same reference\n\t* bgpd/bgpd.c: (peer_free) handle frees of info to be kept for lifetime\n\t of struct peer.\n\t (peer_lock,peer_unlock) peer refcount helpers\n\t (peer_new) add initial refcounts\n\t (peer_create,peer_create_accept) lock peer as appropriate\n\t (peer_delete) unlock as appropriate, move out some free\u0027s to\n\t peer_free.\n\t (peer_group_bind,peer_group_unbind) peer refcounting as\n\t appropriate.\n\t (bgp_create) check CALLOC return value.\n\t (bgp_terminate) free workqueues too.\n\t* lib/memtypes.c: Add MTYPE_BGP_PROCESS_QUEUE and\n\t MTYPE_BGP_CLEAR_NODE_QUEUE\n" }, { "commit": "6811845b67999861388cf00d3ca0ee8471d29876", "tree": "1f7f08f171164b1a75b66a45093ccb44217dff12", "parents": [ "4a8164e5b310094315e2c50d73aeea489766a48a" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri Apr 08 15:40:36 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri Apr 08 15:40:36 2005 +0000" }, "message": "\t* bgpd.texi: Document new \"bgp bestpath as-path confed\" command.\n\t* bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable\n\t the length of confederation path segments to be included during the\n\t as-path length check in the best path decision.\n" }, { "commit": "1eb8ef2584833f18fb674e127d59cb5a7f771482", "tree": "f5b09d4781de9a9b08839fefb6530e64d2d2ec31", "parents": [ "5920990fecba7e2430af3cfaa8bcbaed40d0ba1a" ], "author": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "message": "2005-04-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global): Fix up list loops to match changes in lib/linklist,\n\t and some basic auditing of usage.\n\t* configure.ac: define QUAGGA_NO_DEPRECATED_INTERFACES\n\t* HACKING: Add notes about deprecating interfaces and commands.\n\t* lib/linklist.h: Add usage comments.\n\t Rename getdata macro to listgetdata.\n\t Rename nextnode to listnextnode and fix its odd behaviour to be\n\t less dangerous.\n\t Make listgetdata macro assert node is not null, NULL list entries\n should be bug condition.\n ALL_LIST_ELEMENTS, new macro, forward-referencing macro for use\n with for loop, Suggested by Jim Carlson of Sun.\n Add ALL_LIST_ELEMENTS_RO for cases which obviously do not need the\n \"safety\" of previous macro.\n\t LISTNODE_ADD and DELETE macros renamed to ATTACH, DETACH, to\n\t distinguish from the similarly named functions, and reflect their\n\t effect better.\n\t Add a QUAGGA_NO_DEPRECATED_INTERFACES define guarded section\n\t with the old defines which were modified above,\n\t for backwards compatibility - guarded to prevent Quagga using it..\n\t* lib/linklist.c: fix up for linklist.h changes.\n\t* ospf6d/ospf6_abr.c: (ospf6_abr_examin_brouter) change to a single\n\t scan of the area list, rather than scanning all areas first for\n\t INTER_ROUTER and then again for INTER_NETWORK. According to\n\t 16.2, the scan should be area specific anyway, and further\n\t ospf6d does not seem to implement 16.3 anyway.\n" }, { "commit": "6cf159b97848503ee9da0273eb97a6712369fd24", "tree": "c2c19bab97b455fceea49a763430cc709a61682a", "parents": [ "db8eaac6615dacf17eb3958b0f3b6ea58f8f1e1d" ], "author": { "name": "hasso", "email": "hasso", "time": "Mon Mar 21 10:28:14 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Mon Mar 21 10:28:14 2005 +0000" }, "message": " * bgp_route.c: Don\u0027t crash while clearing route tables if there is\n no particular afi/safi configured.\n\n\t[backport candidate]\n" }, { "commit": "338b3424154af85b0762713796397d3f2345d54f", "tree": "53e202ad7097edc2299179135265475bb48435ed", "parents": [ "e69b9e40c74d9d910934c94c63c08e36e9799e00" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 23 14:27:24 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 23 14:27:24 2005 +0000" }, "message": "\t* bgp_route.c: Make reannouncing prefixes with changed attributes\n\t work again.\n" }, { "commit": "fee6e4e4547783b915838f6868d6cd694f6cee21", "tree": "2fb39322113433ab2d5e42042c1b9e397779b6c1", "parents": [ "6ffd2079596c232856dda0d56fddd9610e8d61fe" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 16:29:31 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 16:29:31 2005 +0000" }, "message": "\t* bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:\n\t community-list cleanup.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "6ffd2079596c232856dda0d56fddd9610e8d61fe", "tree": "d5c4906cbfb4af98a8c73be667a9ab2369a6c64b", "parents": [ "93406d87e68a0e9cf5ce0240461395cd59c143b6" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:50:11 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:50:11 2005 +0000" }, "message": "\t* bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: \"enforce-multihop\"\n\t -\u003e \"disable-connected-check\".\n\n\t[merge from GNU Zebra]\n" }, { "commit": "93406d87e68a0e9cf5ce0240461395cd59c143b6", "tree": "b1cb2bae2eca7c5206565f73169cf43bf8cf892d", "parents": [ "c9502438e822199370fe87100c725e1092e943c1" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:40:33 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:40:33 2005 +0000" }, "message": "\t* bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,\n\t bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. \"bgp\n\t graceful-restart\" commands added. Show numbers of individual\n\t messages in \"show ip bgp neighbor\" command. Final pieces of graceful\n\t restart.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "0a486e5fcb1b8dac7d8b4cf6ed93e82b8b72fed6", "tree": "f63429ed7767e227457cb48196d82f12e4fcaad6", "parents": [ "f418446bb767d79438e2df689c5bf9563c54b317" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:57:17 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:57:17 2005 +0000" }, "message": "\t* bgpd.[ch], bgp_vty.c, bgp_route.c: \"Restart session after\n\t maximum-prefix limit\" feature support.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "3b8b1855038afde448993e5a56955e9b7a4d99c2", "tree": "5378ad7cc9d2fdb42558044833036e347ca1277e", "parents": [ "4460e7a4cf3dadcd9f06e4b519ba7be2cc936c0a" ], "author": { "name": "ajs", "email": "ajs", "time": "Sat Jan 29 18:19:13 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Sat Jan 29 18:19:13 2005 +0000" }, "message": "2005-01-29 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* buffer.h: Fix comment on buffer_getstr to reflect that it now\n\t uses XMALLOC.\n\t* buffer.c: (buffer_getstr) Use XMALLOC(MTYPE_TMP) instead of malloc.\n\t* filter.c: (access_list_remark,ipv6_access_list_remark) Use\n\t argv_concat instead of buffer_getstr.\n\t* if.c: (interface_desc) Use argv_concat instead of buffer_getstr.\n\t* plist.c: (ip_prefix_list_description,ipv6_prefix_list_description)\n\t Use argv_concat instead of buffer_getstr.\n\t* bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead\n\t of buffer_getstr.\n\t* bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string\n\t returned by buffer_getstr.\n\t (bgp_show_community) Must use XFREE instead of free on string\n\t returned by buffer_getstr.\n\t* bgp_routemap.c: (set_community) Must use XFREE instead of free\n\t on string returned by buffer_getstr.\n\t* bgp_vty.c: (neighbor_description) Use argv_concat instead of\n\t buffer_getstr.\n" }, { "commit": "6d69429c1bff7291bac52a05234c12434f152a94", "tree": "e37c98526a257a907e23986e6ada290bc39f09c9", "parents": [ "c15cb24241277db9fb4102ddc712dc3297f16d1f" ], "author": { "name": "hasso", "email": "hasso", "time": "Mon Jan 24 09:29:42 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Mon Jan 24 09:29:42 2005 +0000" }, "message": "\t* bgp_route.c: Fix showstopper bug. New route must be selected also\n\t if old one is flaged as BGP_INFO_ATTR_CHANGED.\n" }, { "commit": "f127165de02a66934082f23810fab37d7efbce8b", "tree": "aed5017ae77c2927b48bc5950c928782ef9c8d80", "parents": [ "583d800c11922018af02420a758f974be691065f" ], "author": { "name": "hasso", "email": "hasso", "time": "Mon Jan 17 11:04:32 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Mon Jan 17 11:04:32 2005 +0000" }, "message": "\t* bgp_route.c: Clear peer\u0027s routing table regardless whether it\u0027s\n\t configured or not. Being not configured is even better reason to\n\t do it.\n" }, { "commit": "d2c1f16be47a3d60555219a92dad8639f381d553", "tree": "662cd144ac4f838c65a5e6397363699768b3b76d", "parents": [ "6b51474d91024a4a0e82fccdd55580ce9b3f5561" ], "author": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 21:10:20 2004 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 21:10:20 2004 +0000" }, "message": "2004-12-08 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* *.c: Change level of debug messages to LOG_DEBUG.\n" }, { "commit": "5a64665039dc98c341fd8d50458ec2a72c5ebbf5", "tree": "e89689f085b7b8eed09a0558e2a80dadb4826033", "parents": [ "f3ae74cdf0768d0bd35f26f728f72439f2d8bd6f" ], "author": { "name": "ajs", "email": "ajs", "time": "Fri Nov 05 01:25:55 2004 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Fri Nov 05 01:25:55 2004 +0000" }, "message": "2004-11-04 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* vty.h: Remove fields in struct vty that were related to VTY_CONTINUE\n\t capabilities (that were used only in bgpd/bgp_route.c and are now\n\t removed). Also remove some other fields that were not being\n\t used at all.\n\t* vty.c: (vty_execute) Do not test for obsolete status values VTY_START\n\t and VTY_CONTINUE.\n\t (vty_read) Remove calls to vty-\u003eoutput_func since that was part\n\t of the VTY_CONTINUE infrastructure that has been removed.\n\t (vty_flush) Remove code to support VTY_START and VTY_CONTINUE.\n\t (vty_close) Remove code to cancel vty-\u003et_output thread, since that\n\t thread was never actually used.\n\t* bgp_route.c: Remove all code related to VTY_CONTINUE; this feature\n\t is deprecated because the output did not represent a single point\n\t in time. All output needs to be generated inline and buffered\n\t by the library code.\n\t (route_vty_out,route_vty_out_tag,damp_route_vty_out,\n\t flap_route_vty_out) Remove code to count number of lines of output,\n\t since this was only useful for VTY_CONTINUE behavior.\n\t (bgp_show_callback) Removed.\n\t (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.\n\t As a result, there\u0027s a new output_arg argument to this function.\n\t Make function static.\n\t (bgp_show) Make function static and add a new output_arg argument.\n\t Change all functions that call bgp_show or bgp_show_table to\n\t pass the new output_arg argument (that used to be passed inside\n\t vty-\u003eoutput_arg).\n\t* bgp_mplsvpn.c: Remove declarations of functions defined in\n\t bgp_route.c; these declarations belong in bgp_route.h.\n\t* bgp_route.h: Declare 3 global functions used in both bgp_route.c\n\t and in bgp_mplsvpn.c.\n" }, { "commit": "fd79ac918b8feaacebe9719adaac97dffb69137a", "tree": "d0665eb68e60da9d6e364414cdb61830f19f33d3", "parents": [ "39db97e4e02eae08a1e18528367b6e9b07eb6a93" ], "author": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:06:08 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:06:08 2004 +0000" }, "message": "2004-10-13 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* (global) more const\u0027ification and fixups of types to clean up code.\n\t* bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,\n should use something like the VTY_GET_INTEGER macro, but without\n the vty_out bits..\n * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE\n (no_set_aggregator_as) ditto.\n * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is\n returned, add comments about troublesome return value.\n" }, { "commit": "fee0f4c629412f422fc9a857e097ef335c2c576c", "tree": "14703e303ea2cecaee7728d9ee27075b0590a679", "parents": [ "0e82d0e1204e45ecce773a7e19f7d64140f7a66a" ], "author": { "name": "paul", "email": "paul", "time": "Mon Sep 13 05:12:46 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Sep 13 05:12:46 2004 +0000" }, "message": "2004-09-13 Jose Luis Rubio \u003cjrubio@dit.upm.es\u003e\n (at Technical University of Madrid as part of Euro6ix Project)\n\n Enhanced Route Server functionality and Route-Maps:\n\n * bgpd/bgpd.h: Modified \u0027struct peer\u0027 and \u0027struct bgp_filter\u0027 to\n support rs-clients. A \u0027struct bgp_table *rib\u0027 has been added to the\n first (to mantain a separated RIB for each rs-client) and two new\n route-maps have been added to the last (for import/export policies).\n Added the following #defines: RMAP_{IN|OUT|IMPORT|EXPORT|MAX},\n PEER_RMAP_TYPE_{IMPORT|EXPORT} and BGP_CLEAR_SOFT_RSCLIENT.\n\n * bgpd/bgpd.c: Modified the functions that create/delete/etc peers in\n order to consider the new fields included in \u0027struct peer\u0027 for\n supporting rs-clients, i.e. the import/export route-maps and the\n \u0027struct bgp_table\u0027.\n\n * bgpd/bgp_route.{ch}: Modified several functions related with\n receiving/sending announces in order to support the new Route Server\n capabilities.\n Function \u0027bgp_process\u0027 has been reorganized, creating an auxiliar\n function for best path selection (\u0027bgp_best_selection\u0027).\n Modified \u0027bgp_show\u0027 and \u0027bgp_show_route\u0027 for displaying information\n about any RIB (and not only the main bgp RIB).\n Added commands for displaying information about RS-clients RIBs:\n \u0027show bgp rsclient (A.B.C.D|X:X::X:X)\u0027, \u0027show bgp rsclient\n (A.B.C.D|X:X::X:X) X:X::X:X/M\u0027, etc\n\n * bgpd/bgp_table.{ch}: The structure \u0027struct bgp_table\u0027 now has two\n new fields: type (which can take the values BGP_TABLE_{MAIN|RSCLIENT})\n and \u0027void *owner\u0027 which points to \u0027struct bgp\u0027 or \u0027struct peer\u0027 which\n owns the table.\n When creating a new bgp_table by default \u0027type\u003dBGP_TABLE_MAIN\u0027 is set.\n\n * bgpd/bgp_vty.c: The commands \u0027neighbor ... route-server-client\u0027 and\n \u0027no neighbor ... route-server-client\u0027 now not only set/unset the flag\n PEER_FLAG_RSERVER_CLIENT, but they create/destroy the \u0027struct\n bgp_table\u0027 of the peer. Special actions are taken for peer_groups.\n Command \u0027neighbor ... route-map WORD (in|out)\u0027 now also supports two\n new kinds of route-map: \u0027import\u0027 and \u0027export\u0027.\n Added commands \u0027clear bgp * rsclient\u0027, etc. These commands allow a new\n kind of soft_reconfig which affects only the RIB of the specified\n RS-client.\n Added commands \u0027show bgp rsclient summary\u0027, etc which display a\n summary of the rs-clients configured for the corresponding address\n family.\n\n * bgpd/bgp_routemap.c: A new match statement is available,\n \u0027match peer (A.B.C.D|X:X::X:X)\u0027. This statement can only be used in\n import/export route-maps, and it matches when the peer who announces\n (when used in an import route-map) or is going to receive (when used\n in an export route-map) the route is the same than the one specified\n in the statement.\n For peer-groups the statement matches if the specified peer is member\n of the peer-group.\n A special version of the command, \u0027match peer local\u0027, matches with\n routes originated by the Route Server (defined with \u0027network ...\u0027,\n redistributed routes and default-originate).\n\n * lib/routemap.{ch}: Added a new clause \u0027call NAME\u0027 for use in\n route-maps. It jumps into the specified route-map and when it returns\n the first route-map ends if the called RM returns DENY_MATCH, or\n continues in other case.\n" }, { "commit": "f5ba387492ec163f1200d949a984f12ef88538ba", "tree": "c17eef0501ef903883aae2ec62fba0be1a244fa0", "parents": [ "4d4653afe362d6ea549c6e21b27afe01fb8b8aac" ], "author": { "name": "paul", "email": "paul", "time": "Fri Jul 09 12:11:31 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Jul 09 12:11:31 2004 +0000" }, "message": "2004-07-09 Sowmini Varadhan \u003csowmini.varadhan@sun.com\u003e\n\n * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket\n if that is connection we\u0027re closing.\n (bgp_read) invalid marker check applies to KEEPALIVE too.\n * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.\n" }, { "commit": "5228ad27e2f3abe0ebb69f66607aedc048b94a13", "tree": "a65817a03150dbfeb56a1eaceab526f31be1cc1d", "parents": [ "c2bfbcc38428b53e856617e1da8bbe9f8d2ee2fa" ], "author": { "name": "paul", "email": "paul", "time": "Fri Jun 04 17:58:18 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Jun 04 17:58:18 2004 +0000" }, "message": "2004-06-04 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * type mismatch fixes\n" }, { "commit": "e0701b7955b883c5437269a382e1afc76ee71e5c", "tree": "d00034c1b7f369fc8214d401b7a44ef586d73e15", "parents": [ "62843e433d8f85bce381edc6202c4af6c5cec31b" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu May 20 09:19:34 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu May 20 09:19:34 2004 +0000" }, "message": "Merge bgpd changeset 1176 from Zebra repository by Rivo Nurges.\n" }, { "commit": "35be31b6b2199e66e5d18420cece5e3bacb3371c", "tree": "744adc33a896d6b69b159a3432e391e2ff2b3a92", "parents": [ "eb821189d2778a93069fc1fc2f104db529ec5a1e" ], "author": { "name": "paul", "email": "paul", "time": "Sat May 01 18:17:04 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat May 01 18:17:04 2004 +0000" }, "message": "2004-05-01 rivo nurges \u003crix@estpak.ee\u003e\n\n * bgp_route.c: fix UNH IOL BGP-4.1.12f\n" }, { "commit": "eb821189d2778a93069fc1fc2f104db529ec5a1e", "tree": "a623d680931ee722fb946f56476f23efd1f13685", "parents": [ "eb3f463aab7f09e6c1041bf779fd5752b038f847" ], "author": { "name": "paul", "email": "paul", "time": "Sat May 01 08:44:08 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat May 01 08:44:08 2004 +0000" }, "message": "2004-05-01 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * Revert the attempted clean-up of the dummy peer hack, reverts\n patchsets 435 (see 2004-02-17 below) and 456.\n" }, { "commit": "545acafbf599b3d163813e6640a1f83703ebda2e", "tree": "dd2c4b6288cf4cd34a381c280c995d85c40c8ecc", "parents": [ "6b3fac0aab9ea72c927531df4c20a6e60df650fe" ], "author": { "name": "paul", "email": "paul", "time": "Tue Apr 20 15:13:15 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Apr 20 15:13:15 2004 +0000" }, "message": "2004-04-16 rivo nurges \u003crix@estpak.ee\u003e\n\n * bgpd.h: update cease subcodes to draft-ietf-idr-cease-subcode-05\n * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a\n" }, { "commit": "6ad23f05e36e743b89fc5a9a41e3db7eccb917fb", "tree": "522a8914b6aefe124c2e972481e89f408110ef3c", "parents": [ "5de5bbf107f9eacb8d8265f8c0b925b2aed21878" ], "author": { "name": "paul", "email": "paul", "time": "Tue Feb 17 19:45:10 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Feb 17 19:45:10 2004 +0000" }, "message": "2004-02-17 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * bgpd.h: (bgp_peer) add fd_local and fd_accept\n file descriptor\u0027s, fd becomes a pointer to one of these.\n * bgpd.c: (global) adjust for fact that fd is now a pointer.\n (peer_create_accept) removed.\n * bgp_route.c: (global) adjust for change of peer fd to pointer\n * bgp_packet.c: (bgp_collision_detect) adjust and remove the\n \"replace with other peer\" hack.\n * bgp_network.c: (bgp_accept) Remove the dummy peer hack.\n Update peer-\u003efd_accept instead.\n (global) Adjust fd references - now a pointer.\n * bgp_fsm.c: (global) adjust peer fd to pointer.\n (bgp_connection_stop) new function, to stop connection.\n (global) adjust everything which closed peer fd to use\n bgp_connection_stop().\n" }, { "commit": "c001ae62814db71a2557bf69a94618613c57d547", "tree": "1db10a79c8b3c90c1e92a21150c623b234fa9063", "parents": [ "1fc8a39b7497b2ab2048b2299cc454a2f7666756" ], "author": { "name": "paul", "email": "paul", "time": "Mon Nov 03 12:37:43 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Nov 03 12:37:43 2003 +0000" }, "message": "2003-11-03 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* bgpd/bgp_route.c: Delete some extraneous whitespace. Credit to\n\t a person on #quagga whose name I unfortunately can not recall.\n" }, { "commit": "bb46e94fcccd9ede513bef8d8e22fe5fafdfbd10", "tree": "be7cb5015905c9fac8be0a9e3ba786dbd5d43e94", "parents": [ "a652604cbfcc87884a00b12beb4e63b1eb10bcea" ], "author": { "name": "paul", "email": "paul", "time": "Fri Oct 24 19:02:03 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Oct 24 19:02:03 2003 +0000" }, "message": "2003-10-24 Jose Luis Rubio Guivernau \u003cjrubio@dit.upm.es\u003e\n\n * Better \u0027show bgp\u0027 support for views (eg ipv6), see [quagga-dev 238]\n * bgpd/bgp_route.c: (bgp_show) Take a struct bgp argument instead of\n view string.\n (bgp_show_neighbor_route) Take a struct peer argument instead of\n ip string.\n (peer_adj_routes) ditto\n (show_adj_routes) ditto\n (peer_lookup_in_view) new function to return appropriate struct\n peer for a given view string.\n (misc) Fixup all calls to above to reflect new calling arguments,\n and use peer_lookup_in_view as needed. Additional commands\n installed to use expanded functionality above, existing commands\n modified to suit as well.\n * bgpd/bgp_vty.c: 2 new aliases.\n" }, { "commit": "3b424979f54c6b128d1ee8a7c33d072d321f2f0c", "tree": "c3c684d2e1576610d3a0cedefa3bab23610c8d61", "parents": [ "7ddf1d6eaf5a339d13661469212ac33f77e808fc" ], "author": { "name": "paul", "email": "paul", "time": "Mon Oct 13 09:47:32 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Oct 13 09:47:32 2003 +0000" }, "message": "2003-10-13 Jay Fenlason \u003cfenlason@redhat.com\u003e\n\n\t* lib/zebra.h: define UINT32_MAX for those systems which do not\n\t provide it.\n\t* bgp_attr.h: define BGP_MED_MAX.\n\t* bgp_route.c: update defines/constants to BGP_MED_MAX.\n\t* bgp_routemap.c: ditto. clean up route_match_metric_compile\n\t slightly to avoid unneccesary XMALLOC.\n" }, { "commit": "50d649aaf920c27c8b6ee525d727436a24c14b4d", "tree": "5f3a1ff2d19eebbeafcc8d8400341f605ac864cc", "parents": [ "c22854b87884f86adf05c5e4eb7a82058c4847f7" ], "author": { "name": "paul", "email": "paul", "time": "Wed Aug 27 12:25:49 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Aug 27 12:25:49 2003 +0000" }, "message": "2003-08-27 Kunihiro Ishiguro \u003ckunihiro@zebra.org\u003e\n\n\t* bgpd/bgp_route.c: Unrevert the revert of the possible first fix\n\t for maximum-prefix.\n" }, { "commit": "c22854b87884f86adf05c5e4eb7a82058c4847f7", "tree": "35fd102b43c0a60c6f62ecc3738b60ca06184e40", "parents": [ "537d8ea92bbf96086e03a0da5a7d26ee4b92e0cc" ], "author": { "name": "paul", "email": "paul", "time": "Wed Aug 27 07:07:02 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Aug 27 07:07:02 2003 +0000" }, "message": "2003-08-27 Kunihiro Ishiguro \u003ckunihiro@zebra.org\u003e\n\n\t* bgpd/bgp_route.c: More work on bgp maximum prefix support\n" }, { "commit": "c2f3a4cc771da731f5aedc455e6f6a543acd6e38", "tree": "9988691c695127592da7789298bd9157600cec81", "parents": [ "d02d5a6b7bc25abc8cf16e4959f89e84116b7ea5" ], "author": { "name": "paul", "email": "paul", "time": "Tue Aug 26 04:11:35 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Aug 26 04:11:35 2003 +0000" }, "message": "2003-08-26 Kunihiro \u003ckunihiro@zebra.org\u003e\n\n\t* bgpd/bgp_route.c: fix maximum prefix comparison\n" }, { "commit": "ac41b2a2d40356468edc84becc6d5800d119aef6", "tree": "8496bdd89af283f76ccd25b5ff24febcdcd93e0e", "parents": [ "f1c61a0a5b5c4cfd0125f050568b8c1fb9953a96" ], "author": { "name": "paul", "email": "paul", "time": "Tue Aug 12 05:32:27 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Aug 12 05:32:27 2003 +0000" }, "message": "2003-08-11 kunihiro \u003ckunihiro@zebra.org\n\n * bgp_route{,map}.c: Extend \u0027set ip next-hop\u0027 in route-maps with\n ability to specify \u0027peer-address\u0027 rather than IP.\n" }, { "commit": "286e1e71538440ed0bef4576aded1745191490d3", "tree": "4e83f3463d554ff1cea819440c67630c9b3e6d93", "parents": [ "622149ad4d5b041ed7f5af36fb798d842e3d8025" ], "author": { "name": "paul", "email": "paul", "time": "Fri Aug 08 00:24:31 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Aug 08 00:24:31 2003 +0000" }, "message": "2003-08-07 kunihiro \u003ckunihiro@zebra.org\u003e\n\n\t* bgpd/bgp_route.c: route server passes routes which may have\n\t no-export community\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }