)]}' { "log": [ { "commit": "ac19a449261bf69e83827f4bb0c6e5526277b41b", "tree": "a93cc7cde55a9c0c65da4b09fc309b503807ffda", "parents": [ "7aaf4ea990398335bd40b56cc9586ab6a7178a4f" ], "author": { "name": "Feng Lu", "email": "lu.feng@6wind.com", "time": "Fri May 22 11:40:07 2015 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jun 02 07:48:34 2015 +0200" }, "message": "zebra: maintain the router-id per VRF\n\nA router may need different identifier among the VRFs. So move the\nmaintenance of router-id per VRF.\n\n* rib.h:\n\n Move the previous global variables in router-id.c into the\n \"struct zebra_vrf\":\n - struct list _rid_all_sorted_list/*rid_all_sorted_list\n - struct list _rid_lo_sorted_list/*rid_lo_sorted_list\n - struct prefix rid_user_assigned\n\n* router-id.c/router-id.h:\n\n A new parameter \"vrf_id\" is added to all the router-id APIs.\n Their operations are done only within the specified VRF.\n\n A new command \"router-id A.B.C.D vrf N\" is added to allow\n manual router-id for any VRF.\n\n The old router_id_init() function is splitted into two:\n - router_id_cmd_init(): it only installs the commands\n - router_id_init(): this new one initializes the variables for\n a specified VRF\n\n* zebra_rib.c: Add new functions zebra_vrf_get/lookup() called\n from router-id.c.\n\n* main.c: Replace router_id_init() with router_id_cmd_init() and\n call the new router_id_init() in zebra_vrf_new().\n\nSigned-off-by: Feng Lu \u003clu.feng@6wind.com\u003e\nReviewed-by: Alain Ritoux \u003calain.ritoux@6wind.com\u003e\nSigned-off-by: Nicolas Dichtel \u003cnicolas.dichtel@6wind.com\u003e\nAcked-by: Vincent JARDIN \u003cvincent.jardin@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "d43f8b39b075fe60e0c8fdb33b07b284d3fae503", "tree": "8c98dce915aaaabd0707a12c2c08199d0bfdec2e", "parents": [ "b1672ce858cc9c16fd7cc67b673aa241d9583a59" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 08:54:54 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:18:01 2015 +0200" }, "message": "bgpd, zebra: fix struct/pointer sizeof mixups\n\nTwo places were taking sizeof(pointer) instead of the sizeof(struct),\nwhile performing operations on the struct. Both are initialisation\nfunctions; I guess we haven\u0027t seen fallout since they weren\u0027t critical.\nFix anyway.\n\n[v2: fix mistake that actually broke bgpd RS workqueue init]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "7aa9dcef80b2ce50ecaa77653d87c8b84e009c49", "tree": "bd4a8d881336a1551146725d7ae06b3e68553e4d", "parents": [ "010ebbbca6396f272cc2d50d147dd922dda68213" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 14:42:23 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:32:34 2014 +0100" }, "message": "Fix most compiler warnings in default GCC build.\n\nFix lots of warnings. Some const and type-pun breaks strict-aliasing\nwarnings left but much reduced.\n\n* bgp_advertise.h: (struct bgp_advertise_fifo) is functionally identical to\n (struct fifo), so just use that. Makes it clearer the beginning of\n (struct bgp_advertise) is compatible with with (struct fifo), which seems\n to be enough for gcc.\n Add a BGP_ADV_FIFO_HEAD macro to contain the right cast to try shut up\n type-punning breaks strict aliasing warnings.\n* bgp_packet.c: Use BGP_ADV_FIFO_HEAD.\n (bgp_route_refresh_receive) fix an interesting logic error in\n (!ok || (ret !\u003d BLAH)) where ret is only well-defined if ok.\n* bgp_vty.c: Peer commands should use bgp_vty_return to set their return.\n* jhash.{c,h}: Can take const on * args without adding issues \u0026 fix warnings.\n* libospf.h: LSA sequence numbers use the unsigned range of values, and\n constants need to be set to unsigned, or it causes warnings in ospf6d.\n* md5.h: signedness of caddr_t is implementation specific, change to an\n explicit (uint_8 *), fix sign/unsigned comparison warnings.\n* vty.c: (vty_log_fixed) const on level is well-intentioned, but not going\n to fly given iov_base.\n* workqueue.c: ALL_LIST_ELEMENTS_RO tests for null pointer, which is always\n true for address of static variable. Correct but pointless warning in\n this case, but use a 2nd pointer to shut it up.\n* ospf6_route.h: Add a comment about the use of (struct prefix) to stuff 2\n different 32 bit IDs into in (struct ospf6_route), and the resulting\n type-pun strict-alias breakage warnings this causes. Need to use 2\n different fields to fix that warning?\n\ngeneral:\n\n* remove unused variables, other than a few cases where they serve a\n sufficiently useful documentary purpose (e.g. for code that needs\n fixing), or they\u0027re required dummies. In those cases, try mark them as\n unused.\n* Remove dead code that can\u0027t be reached.\n* Quite a few \u0027no ...\u0027 forms of vty commands take arguments, but do not\n check the argument matches the command being negated. E.g., should\n \u0027distance X \u003cprefix\u003e\u0027 succeed if previously \u0027distance Y \u003cprefix\u003e\u0027 was set?\n Or should it be required that the distance match the previously configured\n distance for the prefix?\n Ultimately, probably better to be strict about this. However, changing\n from slack to strict might expose problems in command aliases and tools.\n* Fix uninitialised use of variables.\n* Fix sign/unsigned comparison warnings by making signedness of types consistent.\n* Mark functions as static where their use is restricted to the same compilation\n unit.\n* Add required headers\n* Move constants defined in headers into code.\n* remove dead, unused functions that have no debug purpose.\n" }, { "commit": "24c84dbe806084552d7bb14b9f1d00514a048b9d", "tree": "cb53212866638b8aa559e573aa320f027d7ed8b7", "parents": [ "4becea724ccd87e88f8454622ae227308b5fa3ce" ], "author": { "name": "Ken Williams", "email": "kenneth.j.williams@intel.com", "time": "Tue Apr 15 02:23:11 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 22 21:17:26 2014 +0200" }, "message": "zebra: Change the mechanism for comparing route ID\u0027s.\n\nThe current format uses subtraction of two ints. Unfortunately, the\nsubtraction method does not work for all combinations of numbers.\nFor example, the with numbers represented by 10.x.x.x and 192.x.x.x,\n10.x.x.x - 192.x.x.x will yield a very large positive number indicating\nthat 10.x.x.x is larger.\n\nSigned-off-by: Ken Williams \u003ckenneth.j.williams@intel.com\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "b6516829595ed4fc47af955de8bda9ef5be14ffd", "tree": "842806138758343d41598fded61943de51c4c363", "parents": [ "2d362d1099f346202cb628665ff4ae563b2594f5" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Mon Dec 21 18:50:43 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Dec 21 18:50:43 2009 +0300" }, "message": "zebra: change router-id selection algo\n\nThe router-id table looks like is supposed to be sorted in current\nquagga code, but the nodes are not added with the sorting\nfunction.\n\nThe sorting function is host byte order dependent.\nThe values need to converted before comparison.\n\nFixing this causes Zebra to choose the largest IP address\nas router-id, rather than the last address. This probably will\nsurprise some users. The other option would be to just remove the\ncomparison function and keep the existing LIFO behavior.\n\nLastly, simple subtraction works well for comparing.\n\n* zebra/router-id.c\n * router_id_add_address(): employ listnode_add_sort()\n * router_id_cmp(): employ ntohl(), then compare integers\n" }, { "commit": "6dc686a29ecdfa8f8011eee17e4e6276ab175a0d", "tree": "bd4a1f7b1c32318584bec6b4f420089aadc81b07", "parents": [ "37a217a59bfd32381034a0ce0adbac1c34cbec37" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:24:45 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:24:45 2007 +0000" }, "message": "[zebra] Bug #351: Don\u0027t redistribute routes to ipv4 link-local prefixes\n\n2007-04-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* lib/prefix.h: Add define to match IPv4 Link-Local addresses\n\t* zebra/redistribute.c: (zebra_check_addr) Don\u0027t redistribute routes\n\t to IPv4 link-local prefixes, fixes bug #351.\n\t* zebra/redistribute.h: Export zebra_check_addr.\n\t* zebra/router-id.c: (router_id_bad_address) re-use zebra_check_addr\n\t rather than implementing similar logic.\n" }, { "commit": "a1ac18c4d5b4f8f4f279efb2ae12b46258f22282", "tree": "e37732ef4b00ae98d1be693e721b01cc2566ba39", "parents": [ "94f2b3923e9663d0355a829f22e4e31cf68ee7b8" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 17:17:12 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 17:17:12 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) Extern and static\u0027ification, with related fixups\n\t of declarations, ensuring files include their own headers, etc.\n\t if_ioctl.c: (interface_info_ioctl) fix obvious arg mis-order in\n\t list loop\n" }, { "commit": "1eb8ef2584833f18fb674e127d59cb5a7f771482", "tree": "f5b09d4781de9a9b08839fefb6530e64d2d2ec31", "parents": [ "5920990fecba7e2430af3cfaa8bcbaed40d0ba1a" ], "author": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "message": "2005-04-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global): Fix up list loops to match changes in lib/linklist,\n\t and some basic auditing of usage.\n\t* configure.ac: define QUAGGA_NO_DEPRECATED_INTERFACES\n\t* HACKING: Add notes about deprecating interfaces and commands.\n\t* lib/linklist.h: Add usage comments.\n\t Rename getdata macro to listgetdata.\n\t Rename nextnode to listnextnode and fix its odd behaviour to be\n\t less dangerous.\n\t Make listgetdata macro assert node is not null, NULL list entries\n should be bug condition.\n ALL_LIST_ELEMENTS, new macro, forward-referencing macro for use\n with for loop, Suggested by Jim Carlson of Sun.\n Add ALL_LIST_ELEMENTS_RO for cases which obviously do not need the\n \"safety\" of previous macro.\n\t LISTNODE_ADD and DELETE macros renamed to ATTACH, DETACH, to\n\t distinguish from the similarly named functions, and reflect their\n\t effect better.\n\t Add a QUAGGA_NO_DEPRECATED_INTERFACES define guarded section\n\t with the old defines which were modified above,\n\t for backwards compatibility - guarded to prevent Quagga using it..\n\t* lib/linklist.c: fix up for linklist.h changes.\n\t* ospf6d/ospf6_abr.c: (ospf6_abr_examin_brouter) change to a single\n\t scan of the area list, rather than scanning all areas first for\n\t INTER_ROUTER and then again for INTER_NETWORK. According to\n\t 16.2, the scan should be area specific anyway, and further\n\t ospf6d does not seem to implement 16.3 anyway.\n" }, { "commit": "18a6dce6f83dd20caf1f36c8e840868ff0bf6dbd", "tree": "ff832cbf6fe2b239bde06268820587bec671ae6d", "parents": [ "a49c0ff6771975eeb1bd7da923a9dc830200cf65" ], "author": { "name": "hasso", "email": "hasso", "time": "Sun Oct 03 18:18:34 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sun Oct 03 18:18:34 2004 +0000" }, "message": "Common router id.\n" } ] }