)]}' { "log": [ { "commit": "53780e30c90ae393467afaf3ccff9e3791df5133", "tree": "a02c36b3e1740c457bd3a5a6fd93847d8aaead9f", "parents": [ "d689d1a0c69726330d69b2dd412fdb8dcb23394b" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 09:07:09 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:19:19 2015 +0200" }, "message": "bgpd: drop unused static variable\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "daefeb8755e194dd19a5f1910bc78d13c8147efb", "tree": "5e00bccf96a80388e7160aca7a9623c40f874b07", "parents": [ "cffe7807c03b7edea005869086720e2f1fb070c6" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Dec 08 17:42:12 2014 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Dec 08 17:46:07 2014 +0100" }, "message": "bgpd: set BGP_ATTR_MP_[UN]REACH_NLRI (fixes 1a211cb)\n\nUnfortunately, the attribute present bits for MP_REACH and MP_UNREACH\nwhich 1a211cb (\"bgpd: one more fix\"...) tests for are never set in their\ncorresponding attribute parsing functions.\n\nReported-by: Martin Winter \u003cmwinter@netdef.org\u003e\nFixes: 1a211cb \"bgpd: one more fix for tightening of check for missing well-known attributes\"\nCc: Paul Jakma \u003cpaul@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "1a211cb369dc865a4e7e9f58a100c041af457262", "tree": "2f9bc481464ea27c46a0389134ee2e31df7e9c7a", "parents": [ "ec98d90767b341877fb7f1547f025b946955899a" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Sat Nov 01 17:21:47 2014 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 25 15:57:12 2014 +0000" }, "message": "bgpd: one more fix for tightening of check for missing well-known attributes\n\n* bgp_attr.c: (bgp_attr_check) The check for missing NEXT_HOP has the right\n spirit, but wrong where it counts, on the logic. It wouldn\u0027t catch a\n missing NEXT_HOP on a v4-only UPDATE. It would though have incorrectly\n flagged next-hop as missing on multi-protocol-only UPDATEs.\n\n Caught by Martin Winter with a test-suite.\n" }, { "commit": "aed1b556cf2f55680ae09d7ad1a1f22729dea8c5", "tree": "26f9f14848768bd7bc77fc28c1469b970c41e84a", "parents": [ "9562a7774b76df050d3e01632c6203796dc72c87" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Tue Oct 21 16:59:01 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Oct 28 10:46:24 2014 +0000" }, "message": "bgpd: Fixes for recent well-known-attr check patch.\n\n* bgp_attr.c: Recent patch to tighten well-known attr checks and apply that\n to all AFIs has some breakage with MP-extensions and GR, which needs to be\n fixed.\n (bgp_attr_check) Graceful Restart EoR can be an empty UPDATE for IPv4/uni.\n MP-Ext allow UPDATE with just MP_UNREACH_NLRI. Check for these and return\n proceed.\n NEXT_HOP becomes optional, if MP_REACH_NLRI is present and there\u0027s no\n v4 NLTI, update NEXT_HOP check accordingly.\n Print the missing attr in string form in the log message.\n (bgp_attr_parse) AS_PATH need not be there, so\n bgp_attr_munge_as4_attrs call needs to be conditional on that.\n" }, { "commit": "055086f70febc30fdfd94bb4406e9075d6934cd8", "tree": "2f511a8b1aca7b3e67e895321bbfef7d02f074b1", "parents": [ "b166ea2dda9f04a8b75e0bf5adb7064580695f22" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Tue Sep 23 15:23:01 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Oct 17 14:09:02 2014 +0100" }, "message": "bgpd: well-known attr check only run for v4/uni, which could cause a crash.\n\n* ANVL testing by Martin Winter threw up a crash in bgpd in aspath_dup\n called from bgp_packet_attribute, if attr-\u003easpath was NULL, on an IPv6\n UPDATE.\n\n This root cause is that the checks for well-known, mandatory attributes\n were being applied only if an UPDATE contained the IPv4 NLRI and the\n peer was configured for v4/unicast (i.e. not deconfigured). This is\n something inherited from GNU Zebra, and never noticed before.\n\n* bgp_attr.c: (bgp_attr_parse) Move the well-known mandatory attribute\n check to here, so that it can be run immediately after all attributes\n are parsed, and before any further processing of attributes that might\n assume the existence of WK/M attributes (e.g. AS4-Path).\n (bgp_attr_munge_as4_attrs) Missing AS_PATH shouldn\u0027t happen here anymore,\n but retain a check anyway for robustness - it\u0027s definitely a hard error\n though.\n* bgp_attr.h: (bgp_attr_check) No longer needs to be exported, make static.\n* bgp_packet.c: (bgp_update_receive) Responsibility for well-known check\n now in bgp_attr_parse.\n" }, { "commit": "7aa9dcef80b2ce50ecaa77653d87c8b84e009c49", "tree": "bd4a8d881336a1551146725d7ae06b3e68553e4d", "parents": [ "010ebbbca6396f272cc2d50d147dd922dda68213" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 14:42:23 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:32:34 2014 +0100" }, "message": "Fix most compiler warnings in default GCC build.\n\nFix lots of warnings. Some const and type-pun breaks strict-aliasing\nwarnings left but much reduced.\n\n* bgp_advertise.h: (struct bgp_advertise_fifo) is functionally identical to\n (struct fifo), so just use that. Makes it clearer the beginning of\n (struct bgp_advertise) is compatible with with (struct fifo), which seems\n to be enough for gcc.\n Add a BGP_ADV_FIFO_HEAD macro to contain the right cast to try shut up\n type-punning breaks strict aliasing warnings.\n* bgp_packet.c: Use BGP_ADV_FIFO_HEAD.\n (bgp_route_refresh_receive) fix an interesting logic error in\n (!ok || (ret !\u003d BLAH)) where ret is only well-defined if ok.\n* bgp_vty.c: Peer commands should use bgp_vty_return to set their return.\n* jhash.{c,h}: Can take const on * args without adding issues \u0026 fix warnings.\n* libospf.h: LSA sequence numbers use the unsigned range of values, and\n constants need to be set to unsigned, or it causes warnings in ospf6d.\n* md5.h: signedness of caddr_t is implementation specific, change to an\n explicit (uint_8 *), fix sign/unsigned comparison warnings.\n* vty.c: (vty_log_fixed) const on level is well-intentioned, but not going\n to fly given iov_base.\n* workqueue.c: ALL_LIST_ELEMENTS_RO tests for null pointer, which is always\n true for address of static variable. Correct but pointless warning in\n this case, but use a 2nd pointer to shut it up.\n* ospf6_route.h: Add a comment about the use of (struct prefix) to stuff 2\n different 32 bit IDs into in (struct ospf6_route), and the resulting\n type-pun strict-alias breakage warnings this causes. Need to use 2\n different fields to fix that warning?\n\ngeneral:\n\n* remove unused variables, other than a few cases where they serve a\n sufficiently useful documentary purpose (e.g. for code that needs\n fixing), or they\u0027re required dummies. In those cases, try mark them as\n unused.\n* Remove dead code that can\u0027t be reached.\n* Quite a few \u0027no ...\u0027 forms of vty commands take arguments, but do not\n check the argument matches the command being negated. E.g., should\n \u0027distance X \u003cprefix\u003e\u0027 succeed if previously \u0027distance Y \u003cprefix\u003e\u0027 was set?\n Or should it be required that the distance match the previously configured\n distance for the prefix?\n Ultimately, probably better to be strict about this. However, changing\n from slack to strict might expose problems in command aliases and tools.\n* Fix uninitialised use of variables.\n* Fix sign/unsigned comparison warnings by making signedness of types consistent.\n* Mark functions as static where their use is restricted to the same compilation\n unit.\n* Add required headers\n* Move constants defined in headers into code.\n* remove dead, unused functions that have no debug purpose.\n" }, { "commit": "f57000c0dbdd0e30e71b6651022392f284201e19", "tree": "9a00b90323fa93de9ecb10c65f9f82824fda99b8", "parents": [ "bb02b82354a80f74706efc5e4c914b3f89fb033e" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 01:01:10 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:47:21 2014 +0200" }, "message": "bgpd: don\u0027t send NOTIFY twice for malformed attrs\n\nMost of the attribute parsing functions were already sending a notify,\nlet\u0027s clean up the code to make it happen only once.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "bb02b82354a80f74706efc5e4c914b3f89fb033e", "tree": "d7662f309686113478121b54859e048f44ee6ac2", "parents": [ "f80f838b2f54738937ef1281b237710132195c44" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 01:01:00 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jun 29 12:47:21 2014 +0200" }, "message": "bgpd: fix IP endianness in debug message\n\ninet_ntop expects network byte order.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6b0655a25194c7c0331154edaa6124cf783e5e5e", "tree": "c0c7d479f2684531249668210da27a60322ba395", "parents": [ "fdb913aedb5a9807ad60715e8badb4f25d57acea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:53:35 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:58:02 2014 +0200" }, "message": "*: nuke ^L (page feed)\n\nQuagga sources have inherited a slew of Page Feed (^L, \\xC) characters\nfrom ancient history. Among other things, these break patchwork\u0027s\nXML-RPC API because \\xC is not a valid character in XML documents.\n\nNuke them from high orbit.\n\nPatches can be adapted simply by:\n\tsed -e \u0027s%^L%%\u0027 -i filename.patch\n(you can type page feeds in some environments with Ctrl-V Ctrl-L)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8c71e481dae11b7ae3f1ef561a989624b2ae84b6", "tree": "4c13b76e1b9aedc45ad9b086be972ba4999ada03", "parents": [ "2c13299a05e5544a5e79c2a970256a21f488a3fa" ], "author": { "name": "Pradosh Mohapatra", "email": "pmohapat@cumulusnetworks.com", "time": "Wed Jan 15 06:57:57 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Jun 03 15:08:32 2014 +0200" }, "message": "bgpd: efficient NLRI packing for AFs !\u003d ipv4-unicast\n\nISSUE:\n\n Currently, for non-ipv4-unicast address families where prefixes are\n encoded in MP_REACH/MP_UNREACH attributes, BGP ends up sending one\n prefix per UPDATE message. This is quite inefficient. The patch\n addresses the issue.\n\nPATCH:\n\n We introduce a scratch buffer in the peer structure that stores the\n MP_REACH/MP_UNREACH attributes for non-ipv4-unicast families. This\n enables us to encode multiple prefixes. In the end, the two buffers\n are merged to create the UPDATE packet.\n\nSigned-off-by: Pradosh Mohapatra \u003cpmohapat@cumulusnetworks.com\u003e\nReviewed-by: Daniel Walton \u003cdwalton@cumulusnetworks.com\u003e\n[DL: removed no longer existing bgp_packet_withdraw prototype]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "689bb66c6a92d238bed1a8b0920438c5a2271966", "tree": "4cf3ee1be6acdb4cf3b85d3da83e09cb64d29ba9", "parents": [ "2fdd455cfd1f758b7aa2e6c8e3d185098b93908c" ], "author": { "name": "Pradosh Mohapatra", "email": "pmohapat@cumulusnetworks.com", "time": "Sat Sep 07 07:13:37 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu May 15 19:15:45 2014 +0200" }, "message": "bgpd: track correct originator-id in reflected routes\n\nISSUE:\n\nSuppose route1 and route2 received from route-reflector-client1 and client2\nrespectively have identical attributes. The current logic of creating the\nadj-rib-out for a peer threads the \u0027adv\u0027 structures for both routes against\nthe same attribute. This results in \u0027bgp_update_packet()\u0027 to pack those\nroutes in the same UPDATE message with one attr structure formatted. The\noriginator-id is thus set according to the first route\u0027s received router id.\nThis is incorrect.\n\nPATCH:\n\nFix bgp_announce_check() function to set the originator-id in the\nadvertising attr structure. Also, fix the attribute hash function and\ncompare function to consider originator-id. Otherwise attributes where all\nfields except the originator-id are identical get merged into one memory\nlocation.\n\nSigned-off-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Scott Feldman \u003csfeldma at cumulusnetworks.com\u003e\nReviewed-by: Ken Yin \u003ckyin at cumulusnetworks.com\u003e\n[DL: whitespace changes dropped]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "d92a2f39b46f1990052d2db046b47edf7bb21ebb", "tree": "17d73b5e879e6ce15c28496d86166bd78ec3f3b0", "parents": [ "cbf435cb72b937c9e5bfe38905e05de3755b1021" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Wed Jul 31 16:36:08 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu May 15 19:02:21 2014 +0200" }, "message": "bgpd: use ATTR_FLAG_BIT() for BGP_ATTR_ values\n\n* bgp_attr.c: this UNSET_FLAG()s are bogus. I did a quick review and\n I think that they could not cause any bug anyway.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nAcked-by: Feng Lu \u003clu.feng@6wind.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "f47e5a18b5beb00d6b5b94965e305dadb5aa5bad", "tree": "c870b37cdba8e36effae527faf6c266847ad2621", "parents": [ "955be06f8a647d1149d5547e1265fb66f55a9161" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Sun Jan 20 18:29:28 2013 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Feb 01 17:55:04 2013 +0100" }, "message": "bgpd: don\u0027t try to reconcile AS4_PATH with NULL\n\nbgp_attr_munge_as4_attrs would previously try to reintegrate an AS4_PATH\nwith a NULL AS_PATH, leading to a rather nasty SEGV. Let\u0027s go by\nRFC6793 and treat missing AS_PATH as 0-length AS_PATH, which in turn\nmeans discarding the AS4_PATH.\n\n[NB: we don\u0027t actually stick to the actual rule, which is discarding\nAS4_PATH if it\u0027s longer than AS_PATH; indeed we should probably fix that\ntoo]\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "a0de1d16cd00694b07b266d4a5dae5985e9072ff", "tree": "93924a57c690d75454b3489df7f87021fbf4dcde", "parents": [ "b06b35f0754747f9f178be155a2903b360aa2b6c" ], "author": { "name": "Christian Franke", "email": "chris@opensourcerouting.org", "time": "Fri Dec 07 16:35:00 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon Jan 14 16:09:20 2013 +0100" }, "message": "bgpd: fix a bug in bgp_attr_dup\n\nCommit 558d1fec11749d3257e improved bgp_attr_dup so it would be possible\nfor the caller to provide attr_extra, allowing to use the stack instead\nof the heap for operations requiring only a short lived attr.\n\nHowever, this commit introduced a bug where bgp_attr_dup wouldn\u0027t copy\nattr_extra at all (but provide a reference to the original) if the\ncaller provided attr_extra.\n\nCc: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: Christian Franke \u003cchris@opensourcerouting.org\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8b366b9cfd1f3ec1a45e0f82db7fdb27e3bb3594", "tree": "855e826ba80328b0fa106bfd8e1f826357806406", "parents": [ "9d3f9705d8b386ccf006c106967c700141e5d049" ], "author": { "name": "Andrew Certain", "email": "certain@amazon.com", "time": "Wed Nov 07 23:50:08 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Nov 30 21:10:25 2012 +0100" }, "message": "bgpd: Fixed out-of-date comment\n\nWhen going through the code to write the documentation for local-as,\nI discovered that one of the comments was out-of-date.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "9d3f9705d8b386ccf006c106967c700141e5d049", "tree": "9edfe2653741fa0f49ffef15bd66f5a522dcd025", "parents": [ "3b96b78136d04ddb7e39d86577cad75acb25237a" ], "author": { "name": "Andrew Certain", "email": "certain@amazon.com", "time": "Wed Nov 07 23:50:07 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Nov 30 21:10:00 2012 +0100" }, "message": "bgpd: add replace-as modifier for BGP neighbor\n\nAdded replace-as modifier for BGP neighbors when using\nlocal-as. If the replace-as modifier is specified, only the\nreplacement AS as specified by the local-as modifier is\nprepended to the AS_PATH, not the process\u0027s AS.\n\nIn bgp_attr.c, I decided that\n\nif (peer-\u003echange_local_as) {\n /* If replace-as is specified, we only use the change_local_as when\n advertising routes. */\n if( ! CHECK_FLAG (peer-\u003eflags, PEER_FLAG_LOCAL_AS_REPLACE_AS) ) {\n aspath \u003d aspath_add_seq (aspath, peer-\u003elocal_as);\n }\n aspath \u003d aspath_add_seq (aspath, peer-\u003echange_local_as);\n} else {\n aspath \u003d aspath_add_seq (aspath, peer-\u003elocal_as);\n}\n\nwas clearer than the alternative that didn\u0027t duplicate the prepending of the\nprocess\u0027s AS:\n\n/* First, append the process local AS unless we have an alternate local_as\n * and we\u0027re replacing it (as opposed to just prepending it). */\nif (! (peer-\u003echange_local_as\n \u0026\u0026 CHECK_FLAG (peer-\u003eflags, PEER_FLAG_LOCAL_AS_REPLACE_AS) ) ) {\n aspath \u003d aspath_add_seq (aspath, peer-\u003elocal_as);\n}\n\nif (peer-\u003echange_local_as)\n aspath \u003d aspath_add_seq (aspath, peer-\u003echange_local_as);\n}\n\nBut I could be convinced otherwise.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "837d16ccbe0fca413f8927da6a34b1e97ccada8a", "tree": "7aed5a517b619c03d11bf567f6a14cda6f8f5efe", "parents": [ "655071f44aab42e89bcece3a93da456fdd0d913a" ], "author": { "name": "Balaji.G", "email": "balajig81@gmail.com", "time": "Wed Sep 26 14:09:10 2012 +0530" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu Oct 25 10:15:59 2012 -0700" }, "message": "*: use array_size() helper macro\n\nUse the array_size() helper macro. Replaces several instances of local\nmacros with the same definition.\n\nReviewed-by: Scott Feldman \u003csfeldma@cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "558d1fec11749d3257e32561d45b5c1ec0622cf4", "tree": "4570b1643db6446dc9f14f9c0bf7fd64a3325117", "parents": [ "489d005a9ad94675f40dc7bceff6176cfad36d45" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:05 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:50 2012 +0200" }, "message": "bgpd: reduce struct attr_extra allocations/freeing\n\nTry to use on stack structs for temporary uses.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "b9f1dca10f9a9bf853a9999a117c8cdeec5b7b69", "tree": "b6382403ba177cb56f0ca6054db1ce32428fd7f2", "parents": [ "1a2fd7078f943e2207ee0f1b0dafdcd2d9c81925" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:01 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: use on stack struct attr_extra in bgp_attr_unintern()\n\n Reduce memory heap fragmentation and pressure on the memory allocator.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "1a2fd7078f943e2207ee0f1b0dafdcd2d9c81925", "tree": "da0852c5c4019c6c1893dec384e9f20df26cea29", "parents": [ "938ef3a22535292dd36c250e5329f97d977e51df" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:53:00 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: cleanup bgp_attr_unintern()\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "938ef3a22535292dd36c250e5329f97d977e51df", "tree": "a854c21dd840e7558a482bf4812b857583da3591", "parents": [ "7fb0cd82c26492004a106bec7ca4afdf4684fabb" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:59 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: use on stack struct attr_extra on bgp_attr_aggregate_intern()\n\nReduce memory heap fragmentation and pressure on the memory allocator.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "7fb0cd82c26492004a106bec7ca4afdf4684fabb", "tree": "1f901bbc121337b9c421eb48d7bcc413ad140753", "parents": [ "e16a413313cf985ae2b8d2f1a9e8fd0ab6f5b9fc" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:58 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: reduce attrhash_make_key() indirections\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "e16a413313cf985ae2b8d2f1a9e8fd0ab6f5b9fc", "tree": "e6810289e60312da431a8f992903275d952d0e6b", "parents": [ "8ff56318a8bd188cfcc1cdab689c46c326b50d38" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:57 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:49 2012 +0200" }, "message": "bgpd: remove some useless initializations\n\n* bgp_attr.c: (bgp_attr_default_intern) bgp_attr_default_set() already\n initializes the memory. Fixes a struct attr_extra leak.\n* bgp_route.c: Remove useless on stack struct initializations.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6d85b15bbb2fd3c263d5d4b402c88ff348af877b", "tree": "c8be5e782f4425840ee93e167eb8d7c1ed3f4e4c", "parents": [ "14542f3edaa43113880e8bb69612c553f02bdf22" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:54 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:10 2012 +0200" }, "message": "bgpd: remove calls to peer_sort() from fast-path\n\n peer_sort() it\u0027s called so much as to be annoying. In the assumption\nthat the \u0027sort\u0027 of the peer doesn\u0027t change during an established session,\nI have changed all calls to peer_sort() in the \u0027fast-path\u0027 to only check\nthe \u0027sort\u0027. All the calls from the vty and such still recalculate the sort\nand store it in the peer.\n\n There\u0027s a lot of other calls to peer_sort() that could be changed but some\nmaube tricky, someone more knowledgeable may try to reduce them.\n\n This hits peer_sort() from 5th out of the stadium^H^H list on a full\ninternet table loading profiling session.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "8794e8d229dc9fe29ea31424883433d4880ef408", "tree": "6ecfaad3044ad522eb1fc1e7aba989552eeec816", "parents": [ "7621f336e2f346edee43227f0b1ef93fe769720b" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Feb 13 13:53:07 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed May 02 11:16:11 2012 +0100" }, "message": "bgpd: Fix regression in args consolidation, total should be inited from args\n\n* bgp_attr.c: (bgp_attr_unknown) total should be initialised from the args.\n" }, { "commit": "fa5831e85ae9ba7008fb4b4e2d4c7561ae5cb697", "tree": "5653d8127ad212e6d251fb078afef50fc262353b", "parents": [ "fa61e16ddebe10a71d98bcd2eba0f630071ea4a7" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:54:04 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:54:04 2012 +0100" }, "message": "bgpd: bgp_attr_flags_diagnose shouldn\u0027t assert\n\n* bgpd/bgp_attr.c: (bgp_attr_flags_diagnose) debug code for error-handling\n paths probably shouldn\u0027t assert, instead it should just log that there\n was no problem.\n" }, { "commit": "fa61e16ddebe10a71d98bcd2eba0f630071ea4a7", "tree": "bc301257fdb4dbac4aedf1e17ffa3e6c00a77612", "parents": [ "683f2b86d89fa356d3d1f7a54b0c269baa38b836" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Mar 25 21:31:47 2012 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:48:38 2012 +0100" }, "message": "bgpd: attr_parse call to attr_malformed should deal with PROCEED error case\n\n* bgpd/bgp_attr.c: (bgp_attr_parse) the invalid flag check call to\n bgp_attr_malformed is pretty useless if it doesn\u0027t actually allow\n for the PROCEED non-error case.\n" }, { "commit": "683f2b86d89fa356d3d1f7a54b0c269baa38b836", "tree": "0788f6ea3f9079d3c1d775c49cd4cd881e44d204", "parents": [ "bd471fea4ec965c71d6c2201745995092fbc36f6" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Mar 23 14:58:45 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 27 11:48:35 2012 +0100" }, "message": "bgpd: Fix silly mistake in bgp_attr_flag_invalid\n\n* bgp_attr.c: (bgp_attr_flag_invalid) flags is meant to be masked\n off with the mask variable...\n" }, { "commit": "bd471fea4ec965c71d6c2201745995092fbc36f6", "tree": "1d07d21b35101724d98107d47f4cd214800b4489", "parents": [ "81c3e5006e5d29e305cbc0ab482617d7e570e8c0" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Mar 15 11:30:00 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Mar 25 21:33:51 2012 +0100" }, "message": "bgpd: malformed attribute error that can still proceed should fixup getp\n\n* bgp_attr.c: (bgp_attr_malformed) When a malformed attribute error can be\n ignored, and BGP message processing may still proceed, the stream getp\n should be adjusted to the end of the attribute - the caller may not have\n consumed all the attribute. Problem noted by Martin Winter in bug 678.\n\n Also, rename the \u0027startp\u0027 local to \u0027notify_datap\u0027, for clarity.\n" }, { "commit": "835315bfb49bff2b2fb354f2075c6d6693c2a151", "tree": "b9cc49ef796bcb1e3836ff670da930765815acfa", "parents": [ "3ecab4c8549574d09f8d8366098939a8ad3da6c4" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jan 18 12:28:30 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Feb 28 18:35:45 2012 +0000" }, "message": "bgpd: Move up flag-check calls, parcel up attr-parser args, and other cleanups\n\n* bgp_attr.h: (struct bgp_attr_parser_args) Attribute parsing context,\n containing common arguments.\n* bgp_attr.c: (general) Move the bgp_attr_flag_invalid flag-check calls up,\n out of each individual attr parser function, to be done once in attr_parse.\n\n Similarly move the calculation of the \u0027total\u0027 attribute length field up\n to attr_parse.\n\n Bundle together common arguments to attr-parsing functions and helpers\n into (struct bgp_attr_parser_args), so it can be passed by reference down\n the stack \u0026 also de-clutter the argument lists \u0026 make it easier to\n add/modify the context for attr-parsing - add local const aliases to avoid\n modifying body of code too much. This also should help avoid cut \u0026 paste\n errors, where calls to helpers with hard-coded attribute types are pasted\n to other functions but the code isn\u0027t changed.\n\n (bgp_attr_flags_diagnose) as above.\n (bgp_attr_flag_invalid) as above.\n (bgp_attr_{origin,aspath,as4_path,nexthop,med,local_pref,atomic}) as above.\n (bgp_attr_{aggregator,as4_aggregator,community,originator_id}) as above\n (bgp_attr_{cluster_list,ext_communities},bgp_mp_{un,}reach_parse) as above\n (bgp_attr_unknown) as above.\n\n (bgp_attr_malformed) as above. Also, startp and length have to be\n special-cased, because whether or not to send attribute data depends\n on the particular error - a separate length argument, distinct from\n args-\u003elength, indicates whether or not the attribute data should be sent\n in the NOTIFY.\n (bgp_attr_aspath_check) Call to bgp_attr_malformed is wrong here, there is\n no attribute parsing context - e.g. the \u0027flag\u0027 argument is unlikely to be\n right, remove it. Explicitly handle the error instead.\n (bgp_attr_munge_as4_attrs) Flag argument is pointless.\n\n As the comment notes, the check here is pointless as AS_PATH presence\n already checked elsewhere.\n\n (bgp_attr_parse) Do bgp_attr_flag_invalid call here.\n Use (struct bgp_attr_parser_args) for args to attr parser functions.\n Remove out-of-context \u0027flag\u0027 argument to as4 checking functions.\n" }, { "commit": "3ecab4c8549574d09f8d8366098939a8ad3da6c4", "tree": "7b8281980887ef0c57485be0ca6f382c054762cd", "parents": [ "b5043aabb03567b46a16463d88a8afce2acda35e" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jan 17 13:31:33 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Feb 28 18:35:45 2012 +0000" }, "message": "bgpd: consolidate attribute flag checks\n\n* bgpd/bgp_attr.c: (attr_flags_values []) array of required flags for\n attributes, EXTLEN \u0026 PARTIAL masked off as \"dont care\" as appropriate.\n (bgp_attr_flag_invalid) check if flags may be invalid, according to\n the above table \u0026 RFC rules.\n (bgp_attr_*) Use bgp_attr_flag_invalid.\n (bgp_attr_as4_aggregator) ditto, also take startp argument for the\n NOTIFY data.\n (bgp_attr_parse) pass startp to bgp_attr_as4_aggregator\n" }, { "commit": "f31d6927b2df4340bf9ff1cc9f20d52e168a3766", "tree": "638f95d929b07067f5cac70f21d40a4b94e1f8f9", "parents": [ "83a9a2213a73aeb9796b69327c87e89e2d3327ed" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:17:42 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:21:55 2012 +0000" }, "message": "bgpd: Fix incorrect attribute type code in call to bgp_attr_malformed\n" }, { "commit": "83a9a2213a73aeb9796b69327c87e89e2d3327ed", "tree": "ed0ef43739f593a3163309a128b179d66ceec4d8", "parents": [ "9ed79b53eb89b8a663eb368ef5f7d47701f231df" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:15:03 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 14:15:03 2012 +0000" }, "message": "bgpd: Improve flag error messages in bgp_attr_aspath\n\n* bgpd/bgp_attr.c: (bgp_attr_aspath) error message could be misleading,\n clearly log what flag was incorrect.\n\n (Problem noted in \"bgpd: fix error message in bgp_attr_aspath()\" in\n Quagga-RE)\n" }, { "commit": "afcb767922509c4d998f1c567e350b9809c148ab", "tree": "ce9f742f0471377337e36235dee73a39e17cb7b0", "parents": [ "d8bcd9e9c6a1801b52b166fa3873eb468ac3c5cb" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Oct 23 22:32:44 2011 +0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jan 08 12:57:35 2012 +0000" }, "message": "bgpd: rewrite attr flag error logging\n\n* bgp_attr.c\n * attr_flag_str: new message list\n * bgp_attr_flags_diagnose(): new function, implements previously added\n error logging in a generic way\n * bgp_attr_origin(): use bgp_attr_flags_diagnose()\n * bgp_attr_nexthop(): ditto\n * bgp_attr_med(): ditto\n * bgp_attr_local_pref(): ditto\n * bgp_attr_atomic(): ditto\n * bgp_attr_originator_id(): ditto\n * bgp_attr_cluster_list(): ditto\n * bgp_mp_reach_parse(): ditto\n * bgp_mp_unreach_parse(): ditto\n" }, { "commit": "9206f9ecd5526778bf449bbb12f056d681d3b040", "tree": "cd11853fe47a30bb2a28838f6ad8f8d49300b4fa", "parents": [ "b48cebbba0dc01ad7d1fbd7cbcc39a11e1ae972d" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Sun Dec 18 19:43:40 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sun Dec 18 20:21:21 2011 +0400" }, "message": "fix set never used warnings\n\n(This patch was modified to leave calls to stream_getl() in place, they\nare necessary for the stream\u0027s internal pointer to advance to the\ncorrect position. -- Denis)\n\nSigned-off-by: Denis Ovsienko \u003cinfrastation@yandex.ru\u003e\n\nFix gcc warnings about varables that are set but never used.\n\n* bgpd/bgp_attr.c\n * cluster_unintern(): ret\n * transit_unintern(): ret\n * bgp_attr_default_intern(): attre\n * bgp_mp_reach_parse(): rd_high, rd_low\n* bgpd/bgp_route.c\n * bgp_announce_check_rsclient(): bgp\n* bgpd/bgp_zebra.c\n * zebra_read_ipv4(): ifindex\n * zebra_read_ipv6(): ifindex\n* bgpd/bgpd.c\n * bgp_config_write_peer(): filter\n* lib/distribute.c\n * distribute_list_all(): dist\n * distribute_list(): dist\n * distribute_list_prefix_all(): dist\n * distribute_list_prefix(): dist\n* lib/if_rmap.c\n * if_rmap(): if_rmap\n* lib/vty.c\n * vty_accept(): vty\n* lib/zclient.c\n * zclient_read(): ret\n* zebra/irdp_interface.c\n * if_group(): zi\n* zebra/rt_netlink.c\n * kernel_read(): ret, sock\n" }, { "commit": "ce0af6ff5a4f200035ed4134da72a67f49a21dd6", "tree": "1f085a210596f3f5875030c92ba3252933102149", "parents": [ "1ffe5e794c3cd4a2ef84cac937d377de89b721f8" ], "author": { "name": "Oleg A. Arkhangelsky", "email": "sysoleg@yandex.ru", "time": "Sat Dec 03 15:18:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Dec 03 15:18:19 2011 +0400" }, "message": "bgpd: fix memory leak for extra attributes\n\nthis fixes commit b881c7074bb698aeb1b099175b325734fc6e44d2\n" }, { "commit": "267551879e57a5c590f9e12b3a7d6985b28b3dac", "tree": "aeb0f826f3ea541de99d0988794f1454ab3b9e35", "parents": [ "b4cd2421518be7e18046e974e25b9bf4cf769bd2" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 26 19:34:30 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 26 19:38:49 2011 +0400" }, "message": "bgpd: fix 2 more cases of length error reporting\n\n* bgp_attr.c (bgp_attr_originator_id, bgp_attr_cluster_list): provide\n required arguments to bgp_attr_malformed()\n" }, { "commit": "b4cd2421518be7e18046e974e25b9bf4cf769bd2", "tree": "43a94afcebc8b878040f771de5f0e542bb6bc440", "parents": [ "bbb04bf3bb03be27fbf17b6b3ee903b168201cf0" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 22 22:32:26 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 22 22:32:26 2011 +0400" }, "message": "bgpd: check AGGREGATOR attr flags (BZ#678)\n\n* bgp_attr.c\n * bgp_attr_aggregator(): check Optional/Transitive flag bits\n" }, { "commit": "bbb04bf3bb03be27fbf17b6b3ee903b168201cf0", "tree": "8db00c5a6db16254146e064bfb350f536cc90e02", "parents": [ "abc384f85b622471ef5ba6c86acc540856da05cf" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Oct 18 14:20:04 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 19 17:28:01 2011 +0400" }, "message": "bgpd: fix more regressions in attr flag checks\n\nCommit 05a4936b713b9882171d0f7fb20b8439df23939e fixed some of the\nattributes involved, but not all. This commit should do it.\n\n* bgp_attr.c\n * bgp_attr_originator_id()\n * bgp_attr_cluster_list()\n * bgp_mp_reach_parse()\n * bgp_mp_unreach_parse()\n" }, { "commit": "abc384f85b622471ef5ba6c86acc540856da05cf", "tree": "5bb225c251c3667b12e7b5cb08dd1455dde5b072", "parents": [ "565b828dc00cafd477dd69ce15f0f551ece67710" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Oct 18 13:55:07 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Oct 18 13:55:07 2011 +0400" }, "message": "bgpd: use bgp_attr_malformed()\n\nSome of the recent attribute flags/length checks copied from QRE use\nbgp_notify_send_with_data() directly, but master branch assumes\nusing bgp_attr_malformed().\n\n* bgp_attr.c\n * bgp_attr_med()\n * bgp_attr_local_pref()\n * bgp_attr_atomic()\n * bgp_attr_originator_id()\n * bgp_attr_cluster_list()\n * bgp_mp_reach_parse()\n * bgp_mp_unreach_parse()\n" }, { "commit": "565b828dc00cafd477dd69ce15f0f551ece67710", "tree": "e1d5c6c38f89b6d022339df14c9b5224de7c0ca9", "parents": [ "f8627ff1ef7642c8ee4758b1f046ef0d166dfbec" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 21:08:33 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:07:02 2011 +0400" }, "message": "bgpd: add flag checks for MP_(UN)REACH_NLRI\n\n* bgp_attr.[ch]\n * bgp_mp_reach_parse(): add extra arguments and a uniform flag\n check block\n * bgp_mp_unreach_parse(): idem\n * bgp_attr_parse(): provide extra arguments\n* bgp_mp_attr_test.c\n * parse_test(): justify respective calls\n" }, { "commit": "f8627ff1ef7642c8ee4758b1f046ef0d166dfbec", "tree": "60fa75de6532991858f718aebfcabc19a745f081", "parents": [ "0b83044b91d7ea50824cfd803d77213b9ff38ed9" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 16:52:20 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:03:56 2011 +0400" }, "message": "bgpd: fix spelling of CLUSTER_LIST\n" }, { "commit": "0b83044b91d7ea50824cfd803d77213b9ff38ed9", "tree": "a18f7841fa039c1236ef5ea4770c0f0a5b81d3b1", "parents": [ "d595b566bca1de8b026c469a31ae50f2aee11781" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 15:12:17 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:03:31 2011 +0400" }, "message": "bgpd: check CLUSTER_LIST attribute flags\n\n* bgp_attr.c\n * bgp_attr_cluster_list(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra arguments\n" }, { "commit": "d595b566bca1de8b026c469a31ae50f2aee11781", "tree": "1572e36687c8666c8f0c8519addc94f9d2c886af", "parents": [ "566b36ebf903fd873c974ba34c19097d8fb48ce4" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 15:08:54 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:02:55 2011 +0400" }, "message": "bgpd: check ORIGINATOR_ID attribute flags\n\n* bgp_attr.c\n * bgp_attr_originator_id(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra arguments\n" }, { "commit": "a5b228b3792937c93b589938a2545b9311b7938e", "tree": "59c22c60531b0fe2a4ceeb0d8cc1070af1312a9d", "parents": [ "21cc76941abc60b5b5ece0a71ace0b69d6f4572c" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 12 13:54:21 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Oct 12 13:59:09 2011 +0400" }, "message": "bgpd: fix regression in improved attr flag checks\n\nCommit 2febf323411c1aed9d7694898f852ce2ef36a7e5 assumed every flag\nbit except optional/transitive/partial unset, which at times could\nnot be true for \"extended length\" bit.\n\n* bgp_attr.c\n * bgp_attr_origin(): exclude BGP_ATTR_FLAG_EXTLEN from comparison\n * bgp_attr_nexthop(): idem\n * bgp_attr_med(): idem\n * bgp_attr_local_pref(): idem\n * bgp_attr_atomic(): idem\n" }, { "commit": "a624cae2b210a0e81c80c473f86b73e2be169962", "tree": "b229e5943b651405d5b2277ecb5fbcdc1a747354", "parents": [ "b84b62dfb6ee9daf46c9e4c2c372b179f33be44c" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 08 13:54:48 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Oct 08 14:18:00 2011 +0400" }, "message": "bgpd: improve attr length error handling (BZ#679)\n\n* bgp_attr.c\n * bgp_attr_parse(): provide extra argument to bgp_attr_aggregator()\n * bgp_attr_local_pref(): use bgp_notify_send_with_data()\n * bgp_attr_atomic(): idem\n * bgp_attr_aggregator(): idem\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "b84b62dfb6ee9daf46c9e4c2c372b179f33be44c", "tree": "052307acd804e98d224bc4d3246f16c9d02fbad9", "parents": [ "2d42e68aa032ed2f11471aee444935918d35c8bb" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 15:47:25 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 14:11:13 2011 +0400" }, "message": "bgpd: improve attr flags checks\n\nDo not check each of the Optional/Transitive/Partial attribute\nflag bits, when their only valid combination is known in advance,\nbut still perform bit-deep error message logging. This change\nassumes unused (low-order) 4 bits of the flag octet cleared.\n\n* bgp_attr.c\n * bgp_attr_origin(): rewrite check\n * bgp_attr_nexthop(): idem\n * bgp_attr_med(): idem\n * bgp_attr_local_pref(): idem\n * bgp_attr_atomic(): idem\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "2d42e68aa032ed2f11471aee444935918d35c8bb", "tree": "a58e0b96bdb43fb6ed66a94afc0d44b737ca4c89", "parents": [ "214bcaa13e092d9fff8f233e62ba28ca7eefbc43" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 15:35:39 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 10:32:02 2011 +0400" }, "message": "bgpd: ignore 4 bits of attribute flags byte\n" }, { "commit": "214bcaa13e092d9fff8f233e62ba28ca7eefbc43", "tree": "eb429544fd7d6727f35cd3fc24b6426a6d577eb3", "parents": [ "bc3443ebf032b5fcc9e0ccb94641e4e899cd17d8" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 24 13:20:43 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 10:30:36 2011 +0400" }, "message": "bgpd: add missing \"partial\" flag checks (BZ#676)\n\nORIGIN handling function used to have \"partial\" bit check and recent\ncommits added it for NEXT_HOP, MULTI_EXIT_DISC and ATOMIC_AGGREGATE\ncases. This commit adds \"partial\" check for AS_PATH and LOCAL_PREF\ncases, which should leave attributes 1 through 6 inclusive completely\ncovered with attribute flags checks.\n\n* bgp_attr.c\n * bgp_attr_origin(): use bit-by-bit checks for better diagnostics\n * bgp_attr_aspath(): add flag check\n * bgp_attr_local_pref(): idem\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "bc3443ebf032b5fcc9e0ccb94641e4e899cd17d8", "tree": "06d6c8b912958c989ba59e45349e17a3f8d973ac", "parents": [ "0a28130d35bbba47faf47bf9451ba0eb195fcbb7" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 22 12:48:14 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Sep 30 01:24:35 2011 +0400" }, "message": "bgpd: improve NEXT_HOP attribute checks (BZ#680)\n\n* lib/prefix.h\n * IPV4_CLASS_DE(): new helper macro\n* bgp_attr.c\n * bgp_attr_nexthop(): add check for \"partial\" bit, refresh flag error\n reporting, explain meaning of RFC4271 section 6.3 and implement it\n\nConflicts:\n\n\tbgpd/bgp_attr.c\n" }, { "commit": "42e6d745d105018a9469dabad65bd4cf942dcf3c", "tree": "9e653fe2e44d2e3f8510fcb8451931e3b6153ebc", "parents": [ "beb1ca03bfe707d6d1fcad21fcbaa63af49c82f8" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Sep 29 22:14:11 2011 +0400" }, "message": "bgpd: more SAFI fixes\n\n(with resolved conflict in bgpd/bgp_packet.c)\n\nTwo macros resolving to the same integer constant broke a case block and\na more thorough merge of BGP_SAFI_VPNV4 and BGP_SAFI_VPNV6 was\nperformed.\n\n* bgpd.h: MPLS-labeled VPN SAFI is AFI-independent, switch to single\n* macro\n* bgp_capability_test.c: update test data\n* bgp_mp_attr_test.c: idem\n* bgp_route.c: (bgp_maximum_prefix_overflow, bgp_table_stats_vty) update\n macro and check conditions (where appropriate)\n* bgp_packet.c: (bgp_route_refresh_send, bgp_capability_send,\n bgp_update_receive, bgp_route_refresh_receive): idem\n* bgp_open.c: (bgp_capability_vty_out, bgp_afi_safi_valid_indices,\n bgp_open_capability_orf, bgp_open_capability): idem\n* bgp_attr.c: (bgp_mp_reach_parse, bgp_packet_attribute,\n bgp_packet_withdraw): idem\n" }, { "commit": "9eba2ada189597fcb39c806bbbed414fecf20623", "tree": "59a59ae323a245579c24880d90332070538304aa", "parents": [ "2cfadf09a810e3b660a47a1eb898d0d7c8813c08" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 20 14:43:50 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:21:27 2011 +0400" }, "message": "bgpd: check ATOMIC_AGGREGATE attr flags (BZ#678)\n\n* bgp_attr.c\n * bgp_attr_atomic(): accept extra argument, add checks for\n \"optional\", \"transitive\" and \"partial\" bits, log each error\n condition independently\n * bgp_attr_parse(): provide extra argument\n" }, { "commit": "2cfadf09a810e3b660a47a1eb898d0d7c8813c08", "tree": "135d9df7af95fed3ffaaa380a22c4a93897f5263", "parents": [ "0ea968d21f194b3960a73aa47a5b06f160632907" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 20 10:54:25 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:19:44 2011 +0400" }, "message": "bgpd: check MULTI_EXIT_DISC attr flags (BZ#677)\n\n* bgp_attr.c\n * bgp_attr_med(): add checks for \"optional\", \"transitive\" and\n \"partial\" bits, log each error condition independently\n" }, { "commit": "0ea968d21f194b3960a73aa47a5b06f160632907", "tree": "61f7a046e2a1124f55d8ce9134984371cfd64ab1", "parents": [ "1212dc1961e81d5ef6e576b854e979ea29284f51" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Sep 19 16:30:47 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:15:56 2011 +0400" }, "message": "bgpd: check LOCAL_PREF attribute flags (BZ#674)\n\n* bgp_attr.c\n * bgp_attr_local_pref(): accept extra argument, add checks for\n \"optional\" and \"transitive\" bits, log each error condition\n independently\n * bgp_attr_parse(): provide extra argument\n" }, { "commit": "d68ab1009f42c5ed62f7c6b0b5700f5f0469a35b", "tree": "155fac87e799841406a0785115a0e0fa4c5a0709", "parents": [ "5fdaa04e635fdef7deca9bdfe1be4b60ec90add6" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Tue Jul 12 20:09:18 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:05:30 2011 +0400" }, "message": "bgpd: consistent log msg format (BZ#565)\n" }, { "commit": "036a6e6cf63a1046ab260d090719b305069288eb", "tree": "638b920464ce82b188e32013f768d6f5d7b1a6dd", "parents": [ "8dd1a8daae0b15065d54c46f82d44d21aa7a2320", "b881c7074bb698aeb1b099175b325734fc6e44d2" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jul 29 18:16:25 2011 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jul 29 18:16:25 2011 +0100" }, "message": "Merge branch \u0027attr-errors\u0027\n\nContains BGP fixes:\n\n- set extcommunity crash: tihs patch tries to make the refcounting more robust\n but does not fully solve the problem, sadly.\n- BGP attribute error handling: Little testing.\n" }, { "commit": "31d0f1b3c64903d56a47caebf887067d222c7cd6", "tree": "7a7d90f0517bc2816fc0279f79b5d7a9ab195095", "parents": [ "f5a4827db60545309d0ee378b85acac56cf7837a" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 29 14:18:49 2011 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 29 14:18:49 2011 +0100" }, "message": "bgpd: Fix merge error in jhash commit\n\n* bgp_attr.c: (attrhash_key_make) 98e30f should have changed jhash2 to jhash.\n\n These kinds of merge errors would be reduced and life would be easier if\n people would submit fully-formed fixes that could be chucked directly into\n git-am.\n" }, { "commit": "98e30f5db6dea65a5d6a176065cd0b60eb7bb001", "tree": "3ce8f796dd5f6607a77f1971fd540fcbf2193e3c", "parents": [ "d71ea65270408a45e4bec036671ec73b24b994b4" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Mar 22 16:14:57 2011 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Mar 22 16:18:44 2011 +0000" }, "message": "bgpd: attribute jhash call should use a standard interface to in6_addr data\n\n* bgp_attr.c; (attrhash_key_make) s6_addr is only member of in6_addr\n guaranteed to be available - s6_addr32 isn\u0027t. Fix to be more portable, and\n thus allow compilation on BSD again.\n" }, { "commit": "b881c7074bb698aeb1b099175b325734fc6e44d2", "tree": "70b4816a083166bbf00c1f85f19a67df0c0a5948", "parents": [ "c112af27ed8f158ecece0d73ce2016c166076c00" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 23 16:35:42 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Implement revised error handling for partial optional/trans. attributes\n\n* BGP error handling generally boils down to \"reset session\". This was fine\n when all BGP speakers pretty much understood all BGP messages. However\n the increasing deployment of new attribute types has shown this approach\n to cause problems, in particular where a new attribute type is \"tunneled\"\n over some speakers which do not understand it, and then arrives at a speaker\n which does but considers it malformed (e.g. corruption along the way, or\n because of early implementation bugs/interop issues).\n\n To mitigate this drafts before the IDR (likely to be adopted) propose to\n treat errors in partial (i.e. not understood by neighbour), optional\n transitive attributes, when received from eBGP peers, as withdrawing only\n the NLRIs in the affected UPDATE, rather than causing the entire session\n to be reset. See:\n\n http://tools.ietf.org/html/draft-scudder-idr-optional-transitive\n\n* bgp_aspath.c: (assegments_parse) Replace the \"NULL means valid, 0-length\n OR an error\" return value with an error code - instead taking\n pointer to result structure as arg.\n (aspath_parse) adjust to suit previous change, but here NULL really\n does mean error in the external interface.\n* bgp_attr.h (bgp_attr_parse) use an explictly typed and enumerated\n value to indicate return result.\n (bgp_attr_unintern_sub) cleans up just the members of an attr, but not the\n attr itself, for benefit of those who use a stack-local attr.\n* bgp_attr.c: (bgp_attr_unintern_sub) split out from bgp_attr_unintern\n (bgp_attr_unintern) as previous.\n (bgp_attr_malformed) helper function to centralise decisions on how to\n handle errors in attributes.\n (bgp_attr_{aspathlimit,origin,etc..}) Use bgp_attr_malformed.\n (bgp_attr_aspathlimit) Subcode for error specifc to this attr should be\n BGP_NOTIFY_UPDATE_OPT_ATTR_ERR.\n (bgp_attr_as4_path) be more rigorous about checks, ala bgp_attr_as_path.\n (bgp_attr_parse) Adjust to deal with the additional error level that\n bgp_attr_ parsers can raise, and also similarly return appropriate\n error back up to (bgp_update_receive). Try to avoid leaking as4_path.\n* bgp_packet.c: (bgp_update_receive) Adjust to deal with BGP_ATTR_PARSE_WITHDRAW\n error level from bgp_attr_parse, which should lead to a withdraw, by\n making the attribute parameter in call to (bgp_nlri_parse) conditional\n on the error, so the update case morphs also into a withdraw.\n Use bgp_attr_unintern_sub from above, instead of doing this itself.\n Fix error case returns which were not calling bgp_attr_unintern_sub\n and probably leaking memory.\n* tests/aspath_test.c: Fix to work for null return with bad segments\n" }, { "commit": "c8f3fe3063cb9ff193b13011cfbda3e605395340", "tree": "42713ac0369f0ef372c657ded091b00dbe6a019b", "parents": [ "0c46638122f10019a12ae9668aec91691cf2e017" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Dec 05 20:28:02 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Remove AS Path limit/TTL functionality\n\n* draft-ietf-idr-as-pathlimit doesn\u0027t seem to have gone anywhere, and its\n author does not think it will make progress in IDR. Remove all support\n introduced for it, but leave stubs for the commands to avoid breaking\n any configurations.\n\n Basically reverts cecab5e9725792e60a5e4b473e238a14cd85815d.\n" }, { "commit": "f6f434b2822c453f898552537180a812538bd19e", "tree": "81f5de3c1eeb6679635e7363396c08b807b04ad9", "parents": [ "50ef565e4e689ba653b9709be4d28a01f6cca885" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 23 21:28:03 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Try fix extcommunity resource allocation probs, particularly with \u0027set extcom..\u0027\n\n* Extended communities has some kind of resource allocation problem which\n causes a double-free if the \u0027set extcommunity ...\u0027 command is used.\n Try fix by properly interning extcommunities.\n\n Also, more generally, make unintern functions take a double pointer\n so they can NULL out callers references - a usefully defensive programming\n pattern for functions which make refs invalid.\n\n Sadly, this patch doesn\u0027t fix the problem entirely - crashes still\n occur on session clear.\n\n* bgp_ecommunity.h: (ecommunity_{free,unintern}) take double pointer\n args.\n* bgp_community.h: (community_unintern) ditto\n* bgp_attr.h: (bgp_attr_intern) ditto\n* bgp_aspath.h: (bgp_aspath.h) ditto\n* (general) update all callers of above\n* bgp_routemap.c: (route_set_ecommunity_{rt,soo}) intern the new extcom added\n to the attr, and unintern any old one.\n (route_set_ecommunity_{rt,soo}_compile) intern the extcom to be used\n for the route-map set.\n (route_set_ecommunity_*_free) unintern to match, instead of free\n (route_set_ecommunity_soo) Do as _rt does and don\u0027t just leak\n any pre-existing community, add to it (is additive right though?)\n" }, { "commit": "ab005298526f4b14126cae1a6461ad3d700af29c", "tree": "8b27b97dc351ae1c89c943750e8ad53d4781de44", "parents": [ "c8f3fe3063cb9ff193b13011cfbda3e605395340" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sat Nov 27 22:48:34 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Rollback some of the changes made for invalid AS_PATH segment fix\n\nSome of the changes made in commit cddb8112b80fa9867156c637d63e6e79eeac67bb\ndon\u0027t work particularly well for other changes that need to be made to\naddress BGP attribute error handling problems. In particular, returning\na pointer from complex attribute data parsing functions will not suffice\nto express the require range of return status conditions.\n\n* bgp_aspath.c: (assegments_parse) Rollback to a more minimal set of\n changes to fix the original problem.\n (aspath_parse) Slightly needless pushing around of code, and taking\n 2 parameters to say whether ot use 2 or 4 byte encoding seems unnecessary.\n* bgp_attr.c: (bgp_attr_as{,4}path) Rollback, in preparation for BGP\n attribute error handling update.\n" }, { "commit": "0c46638122f10019a12ae9668aec91691cf2e017", "tree": "1302073e844ff46061ebb938bcd218ed9fbb96bf", "parents": [ "8f228de7b3f9d6f641c75b27ac7ac6e5862cf804" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Dec 05 17:17:26 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:50:56 2011 +0000" }, "message": "bgpd/security: CVE-2010-1674 Fix crash due to extended-community parser error\n\n* bgp_attr.c: (bgp_attr_ext_communities) Certain extended-community attrs\n can leave attr-\u003eflag indicating ext-community is present, even though no\n extended-community object has been attached to the attr structure. Thus a\n null-pointer dereference can occur later.\n (bgp_attr_community) No bug fixed here, but tidy up flow so it has same\n form as previous.\n\n Problem and fix thanks to anonymous reporter.\n" }, { "commit": "c8e7b8959051bf525183bdbff605e54b4b532e2c", "tree": "af9af45c64164f7e7ee9aec5575837624e23df65", "parents": [ "6392aa83c4f895ebbd23817c68d9b0da0de2e0f8" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Fri Aug 27 14:12:54 2010 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:30:54 2011 +0000" }, "message": "bgpd: use Jenkins hash for BGP transit, cluster and attr hashes\n\n* bgp_attr.c: I observed while doing some debugging that even for simple\n tests there was a lot of hash collisions for BGP attributes. Switch to\n using Jhash rather than additive hashing. Probably overkill, but the\n function is fast and available.\n\n ({attrhash,cluster,transit}_hask_key_make) convert to Jenkins hash,\n instead of additive hash.\n" }, { "commit": "4c9641ba4df276080c670e03f65b1d442660a50f", "tree": "15085df8068d8a3864224937eaa407c0484ff57f", "parents": [ "11d3fe9b9a327b3218a76b2b9001ace50c08de8c" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Thu Jul 22 13:20:55 2010 -0400" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Wed Oct 06 12:33:05 2010 -0400" }, "message": "bgpd, lib: adopt afi_t and safi_t in several places\n\n* bgpd/bgp_attr.c, bgpd/bgp_open.h, bgpd/bgp_route.c, lib/prefix.c,\n lib/prefix.h: Various integer types were being used where, if we\n had strict type checking, afi_t and safi_t would be required.\n\nSigned-off-by: G.Balaji \u003cbalajig81@gmail.com\u003e\n(cherry picked from commit c8af35ffa2dc79ff7d7ff00b1b61f1f50a100ab6)\n" }, { "commit": "cddb8112b80fa9867156c637d63e6e79eeac67bb", "tree": "c8d8b4cb9d0ba1c2a7681c6da580874cf5a2b48e", "parents": [ "d64379e8f3c0636df53ed08d5b2f1946cfedd0e3" ], "author": { "name": "Chris Hall", "email": "chris.hall@highwayman.com", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "message": "bgpd: fix handling of AS path data\n\n* bgpd/bgp_aspath.c\n * assegments_parse(): add handling of AS4_PATH input, update bounds\n checks, add check for AS segment type\n * aspath_parse(): add handling of AS4_PATH input, expect\n assegments_parse() to do length checking\n * aspath_empty(): update for the new function prototype\n* bgpd/bgp_aspath.h: ditto\n* tests/aspath_test.c: ditto\n* bgpd/bgp_attr.c\n * bgp_attr_aspath(): add handling of AS4_PATH input, update flags\n checks, change returned type\n * bgp_attr_as4_path(): discard, superseded by bgp_attr_aspath()\n * bgp_attr_parse(): update respectively\n" }, { "commit": "66bed4f4f0235c1eb6edb0a2f6bd4aaf47e5a7f8", "tree": "17488e5dc6eb4cc575f2aa006bfd87ec9c815222", "parents": [ "3de4277ba9b25ff03710d7c004bf708accffd5c7" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Tue Jul 28 11:26:14 2009 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:14 2009 +0100" }, "message": "bgpd: Workaround for invalid MBGP next hop\n\n* bgp_attr.c: (bgp_mp_reach_parse) There are some interoperability issues\n for MBGP (particularly IPv4 multicast NLRI) between different\n implementations. In order to get some next hops to install correctly in\n the BGP tables, it appears to be necessary to copy the multiprotocol next\n hop into the base next hop field. This is related to differences in RFC\n 2283 and RFC 2858.\n" }, { "commit": "ca87e1d37b3c30648e9bacb476a3c89729512f6d", "tree": "d0911b72e7d4c3c94c88a65233ee8a7fa8a4c950", "parents": [ "30d205909c5a81cc306b161c16abff0fd7f566a7" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:28:35 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 14:49:33 2009 +0100" }, "message": "bgpd: Implement BGP confederation error handling (RFC5065, Par. 5)\n\nThis patch implements BGP confederation error handling in Quagga as described\nin RFC5065, paragraph 5.\n\n* bgp_aspath.c: (aspath_confed_check, aspath_left_confed_check) new functions\n* bgp_attr.c: (bgp_attr_aspath_check) apply previous and NOTIFY if there\u0027s\n a problem.\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "9bddac4bd50034c713940ad77cebfbb7f3cd123a", "tree": "2d41a091918fd6d4ca433493a7c9ec9d50eaf343", "parents": [ "fda1d3e033f98c7e34ccdaead27e8df39af12a85" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 09:59:51 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd/cleanup] BGP make attribute variables local\n\nMessage lists can be read-only, and hash tables are local to this\ncode.\n" }, { "commit": "66e5cd87194ae6fdd51061a91b4698bc0a652f6b", "tree": "659d31f9a7dfb8d9ad9a51f37ff0853054a45399", "parents": [ "cedd7f2fa6823bca9ddcfb062f97ed83b11a80dd" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Feb 09 10:14:16 2009 -0800" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:09:03 2009 +0100" }, "message": "[cleanup] functions taking no args should be declared with void args\n\nUse Ansi-C prototypes rather than old K\u0026R method of declaring\nfunction without arguments\n" }, { "commit": "393deb9bd663361e6b110d579a8b1d4c22667068", "tree": "e93ebf2f57bf92ff7a9cd045764b3cdbb99a07e5", "parents": [ "3453a7122c1d585ad789ed0f63deb90cc5e89fae" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Aug 18 14:13:29 2008 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:07:49 2009 +0100" }, "message": "[cleanup] Convert XMALLOC/memset to XCALLOC\n\nSimple conversion of XMALLOC/memset to XCALLOC\n" }, { "commit": "aea339f72807c34a7916d8614e030069815e144c", "tree": "7b0ab93dcfec82736f05ac39106096360e4ceeb5", "parents": [ "c540835eaf0cb59921969537d8e94cc83bb717f5" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "message": "[bgpd] AS4 bugfix by Chris Caputo \u003cccaputo@alt.net\u003e\n\n* bgpd/bgp_aspath.c: (aspath_make_str_count) \"assert (len \u003c str_size)\" was\n getting hit under certain 4-byte ASN conditions. New realloc strategy.\n* bgpd/bgp_aspath.c: (aspath_key_make) const warning fix.\n\n\"%d\" -\u003e \"%u\" 4-byte ASN corrections. Prevent negative number when ASN is\nabove 2^31.\n" }, { "commit": "30a2231a4881f53deca61ef7a62b225a43dab4c5", "tree": "f26dff922a4f85d302fa67bbd9a120108db41c44", "parents": [ "f5612dd382d9c0f4089b08ec164c25a8082d9f89" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Aug 15 14:05:22 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:59 2008 +0100" }, "message": "[warnings] Fix various SOS warnings\n\n2008-08-15 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* */*: Fix various problems flagged by Sun Studio compiler.\n\t - \u0027\u003cqualifier\u003e \u003cstorage\u003e\u0027 obsolescent in declarations\n\t - empty statements (\u0027;\u0027 after ALIAS definitions)\n\t - implicit declarations (e.g printstack in lib/log.c)\n\t - \"\\%\" in printf string instead of \"%%\"\n\t - loops that return on the first iteration (legitimately, but\n \t compiler can\u0027t really know), e.g. bgp_routemap.c\n \t - internal declarations which mask prototypes.\n" }, { "commit": "ffe11cfb0a808ae514193438616dfabc512b4cf6", "tree": "94452dba2c1a49d6e6a0782c6513acb36823cefc", "parents": [ "9fd4958a4eef88c536e4a5aeefce302e10ee8ee6" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Thu Aug 14 16:25:25 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:58 2008 +0100" }, "message": "[lib] hash compare function arguments ought to be const qualified\n\n2008-08-14 Stephen Hemminger \u003cstephen.hemminger@vyatta.com\u003e\n\n\t* lib/hash.h: (struct hash) Hash comparator callback really\n\t ought to treat storage behind arguments as constant - a compare\n\t function with side-effects would be evil.\n\t* */*.c: Adjust comparator functions similarly, thus fixing at least\n\t a few compiler warnings about const qualifier being dropped.\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "851a1a5c146b346d8b8f58fe3924baa5c208f865", "tree": "38817ea92885b4274ca63ad2fc502da7a92c058d", "parents": [ "0df7c91f048f2116610d6bdfce3ab6cad1981802" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 19:56:56 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 19:56:56 2008 +0000" }, "message": "[bgpd] fix a couple of trivial compiler warnings\n\n2008-07-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_community.c: (community_str2com) assigns defaults to local\n\t vars\n\t* bgp_attr.c: (bgp_attr_parse) match format specifier to arg\n\t* bgp_table.{c,h}: (bgp_table_top) can take a * to a const, quelling\n\t warning in bgp_route.c\n" }, { "commit": "032928091c558d3b0940be079049009f47652711", "tree": "81bd1c2ddfbf41f380bfd38370e42d3c646f5e08", "parents": [ "343f720b345dd377bdf4f53e3b02e0c2898f3f0b" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:37:10 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:37:10 2008 +0000" }, "message": "[bgpd] minor changes to bgp_mp_reach_parse\n\n2008-06-07 Paul Jakma \u003cpaul@jakma.org\u003e\n\n\t* bgp_attr.{c,h}: (bgp_mp_{un,}reach_parse) export, for unit tests.\n\t* bgp_attr.c: (bgp_mp_reach_parse) Add logging. Tighten length test\n\t to bounds check against the attribute length rather than the\n\t stream length..\n" }, { "commit": "a15cfd16fcdec39588ce2f780671ba7c6de0b919", "tree": "ccd6a9a654bfe0a7ae376d5e268d2749be06e6fa", "parents": [ "0e7c124f870d4c95ff3edbde1a766717c696da7c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Jun 01 14:29:03 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Jun 01 14:29:03 2008 +0000" }, "message": "[bgpd] bug #419: partial aspath-limit incorrectly causes session reset\n\n2008-06-01 jfletche@gmail.com\n\n\t* bgp_attr.c: (bgp_attr_aspathlimit) fix silly bug in flags check\n\t that was causing BGP to drop sessions if it received a\n\t aspath-limit with partial set. Fixes bug #419.\n" }, { "commit": "693b67b2b20510e0faee87a0950595832ce71054", "tree": "bb7e728238fdf0a6e0d827afdad37ffb3d0279e1", "parents": [ "ce6ab03a273beb903731621153722511910ebbe5" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 13 03:31:24 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 13 03:31:24 2008 +0000" }, "message": "[bgpd] remove unnecessary 0 entries from struct message\u0027s\n\n2008-03-13 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (various) Remove 0 entries from struct message\u0027s, unneeded due to\n\t recent improvements in mes_lookup/LOOKUP.\n" }, { "commit": "370b64a2ad38e43b4bed028960481bbf4192becd", "tree": "ebecb7f934a7058d582e52b5c64a21eb676ec994", "parents": [ "a7f93f3e060fdb2dc7bf5ff4ed4563d4b689bc6c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "message": "[bgpd] Fix number of DoS security issues, restricted to configured peers.\n\n2007-12-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Fix series of vulnerabilities reported by \"Mu Security\n\t Research Team\", where bgpd can be made to crash by sending\n\t malformed packets - requires that bgpd be configured with a\n\t session to the peer.\n\t* bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only\n\t set the attribute flag indicating AS4_PATH if we actually managed\n\t to parse one.\n\t (bgp_attr_munge_as4_attrs) Assert was too general, it is possible\n\t to receive AS4_AGGREGATOR before AGGREGATOR.\n\t (bgp_attr_parse) Check that we have actually received the extra\n\t byte of header for Extended-Length attributes.\n\t* bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.\n\t* bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,\n\t incorrect -2 left in place from a development version of as4-path\n\t patch.\n\t* bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter\n\t needs to be properly sanity checked.\n\t* tests/bgp_capability_test.c: Test for empty capabilities.\n" }, { "commit": "0b2aa3a0a8b095bdef1eddda117d173af75dede2", "tree": "29201cb2beec187409e842b4078ed8a8047d3f11", "parents": [ "7593fddfa1558d086e3142ad96cf2790007f5d84" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "message": "[bgpd] Merge AS4 support\n\n2007-10-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* NEWS: Note that MRT dumps are now version 2\n\t* (general) Merge in Juergen Kammer\u0027s AS4 patch.\n\n2007-09-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_aspath.c: (assegment_normalise) remove duplicates from\n\t from sets.\n\t (aspath_reconcile_as4) disregard a broken part of the RFC around\n\t error handling in path reconciliation.\n\t* aspath_test.c: Test dupe-weeding from sets.\n\t Test that reconciliation merges AS_PATH and AS4_PATH where\n\t former is shorter than latter.\n\n2007-09-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* aspath_test.c: Test AS4_PATH reconcilation where length\n\t of AS_PATH and AS4_PATH is same.\n\n2007-09-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (peek_for_as4_capability) Fix to work.\n\t* bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.\n\t* tests/bgp_capability_test.c: (general) Extend tests to validate\n\t peek_for_as4_capability.\n\t Add test of full OPEN Option block, with multiple capabilities,\n\t both as a series of Option, and a single option.\n\t Add some crap to beginning of stream, to prevent code depending\n\t on getp \u003d\u003d 0.\n\n2007-09-18 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (bgp_capability_as4) debug printf inline with others.\n\t (peek_for_as4_capability) There\u0027s no need to signal failure, as\n\t failure is better dealt with through full capability parser -\n\t just return the AS4, simpler.\n\t* bgp_packet.c: (bgp_open_receive) Update to match\n\t peek_for_as4_capability change.\n\t Allow use of BGP_AS_TRANS by 2b speakers.\n\t Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.\n\t (bgp_capability_msg_parse) missing argument to debug print\n\t (bgp_capability_receive) missing return values.\n\t* tests/bgp_capability_test.c: (parse_test) update for changes to\n\t peek_for_as4_capability\n\n2007-07-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Remove 2-byte size macros, just make existing macros take\n\t argument to indicate which size to use.\n\t Adjust all users - typically they want \u00271\u0027.\n\t* bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any\n\t as4\u0027s in a path.\n\t (aspath_put) Return the number of bytes actually written, to\n\t fix the bug Juergen noted: Splitting of segments will change\n\t the number of bytes written from that already written to the\n\t AS_PATH header.\n\t (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP\n\t is still defined as 2b.\n\t (aspath_aggregate) fix latent bug.\n\t (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation\n\t function.\n\t (aspath_key_make) Hash the AS_PATH string, rather than\n\t just taking the addition of assegment ASes as the hash value,\n\t hopefully sligthly more collision resistant.\n\t (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes\n\t together with the OLD 2-byte forms, code Juergen\n\t had in bgp_attr_parse but re-organised a bit.\n\t (bgp_attr_parse) Bunch of code from Juergen moves\n\t to previous function.\n\t (bgp_packet_attribute) Compact significantly by\n\t just /always/ using extended-length attr header.\n\t Fix bug Juergen noted, by using aspath_put\u0027s\n\t (new) returned size value for the attr header rather\n\t than the (guesstimate) of aspath_size() - the two could\n\t differ when aspath_put had to split large segments, unlikely\n\t this bug was ever hit in the \u0027wild\u0027.\n\t (bgp_dump_routes_attr) Always use extended-len and\n\t use aspath_put return for header length. Output 4b ASN\n\t for AS_PATH and AGGREGATOR.\n\t* bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix\n\t hash callback declarations to match prototypes.\n\t (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,\n\t complete rewrite of Juergen\u0027s changes (no asdot support)\n\t* bgp_open.c: (bgp_capability_as4) New, does what it says\n\t on the tin.\n\t (peek_for_as4_capability) Rewritten to use streams and\n\t bgp_capability_as4.\n\t* bgp_packet.c: (bgp_open_send) minor edit\n\t checked (in the abstract at least) with Juergen.\n\t Changes are to be more accepting, e.g, allow AS_TRANS on\n\t a 2-byte session.\n\t* (general) Update all commands to use CMD_AS_RANGE.\n\t* bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..\n\t Remove stuff replicated by VTY_GET_LONG\n\t (bgp_clear_vty) Return bgp_clear directly to vty.\n\t* tests/aspath_test.c: Exercise 32bit parsing. Test reconcile\n\t function.\n\t* tests/ecommunity_test.c: New, test AS4 ecommunity changes,\n\t positive test only at this time, error cases not tested yet.\n\n2007-07-25 Juergen Kammer \u003cj.kammer@eurodata.de\u003e\n\n\t* (general) AS4 support.\n\t* bgpd.h: as_t changes to 4-bytes.\n\t* bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.\n\t* bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE\n\t added for 2-byte.\n\t Add AS16 versions of length calc macros.\n\t (aspath_count_numas) New, count number of ASes.\n\t (aspath_has_as4) New, return 1 if there are any as4\u0027s in a\n\t path.\n\t (assegments_parse) Interpret assegment as 4 or 2 byte,\n\t according to how the caller instructs us, with a new\n\t argument.\n\t (aspath_parse) Add use32bit argument to pass to\n\t assegments_parse. Adjust all its callers to pass 1, unless\n\t otherwise noted.\n\t (assegment_data_put) Adjust to be able to write 2 or 4 byte\n\t AS, according to new use32bit argument.\n\t (aspath_put) Adjust to write 2 or 4.\n\t (aspath_gettoken) Use a long for passed in asno.\n\t* bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and\n\t BGP_ATTR_AS4_AGGREGATOR.\n\t (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as\n\t determined by received-capability flag.\n\t (bgp_attr_aspath_check) New, code previously in attr_aspath\n\t but moved to new func so it can be run after NEW_AS_PATH\n\t reconciliation.\n\t (bgp_attr_as4_path) New, handle NEW_AS_PATH.\n\t (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.\n\t (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.\n\t (bgp_attr_parse) Add handoffs to previous parsers for the two\n\t new AS4 NEW_ attributes.\n\t Various checks added for NEW/OLD reconciliation.\n\t (bgp_packet_attribute) Support 2/4 for AS_PATH and\n\t AGGREGATOR, detect when NEW_ attrs need to be sent.\n\t* bgp_debug.{c,h}: Add \u0027debug bgp as4\u0027.\n\t* bgp_dump.c: MRTv2 support, unconditionally enabled, which\n\t supports AS4. Based on patches from Erik (RIPE?).\n\t* bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4\n\t support.\n\t* bgp_open.c: (peek_for_as4_capability) New, peek for AS4\n\t capability prior to full capability parsing, so we know which\n\t ASN to use for struct peer lookup.\n\t (bgp_open_capability) Always send AS4 capability.\n\t* bgp_packet.c: (bgp_open_send) AS4 handling for AS field\n\t (bgp_open_receive) Peek for AS4 capability first, and figure\n\t out which AS to believe.\n\t* bgp_vty.c: (bgp_show_peer) Print AS4 cap\n\t* tests/aspath_test.c: Support asn32 changes, call aspath_parse\n\t with 16 bit.\n\t* vtysh/extract.pl: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/extract.pl.in: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/vtysh.c: AS4 compatibility for router bgp ASNUMBER\n" }, { "commit": "b2ceea18074ab8cca894051a3fbc30c312e3acc6", "tree": "3dfc9d1572582ed26cedad37768be9a57a67f5a8", "parents": [ "882968e0a2fe65db5aff29149c87f6d292a1cd2d" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Sep 07 14:24:55 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Sep 07 14:24:55 2007 +0000" }, "message": "[bgpd] low-impact DoS: crash on malformed community with debug set\n\n2007-09-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) bgpd can be made crash by remote peers if debug\n\t bgp updates is set, due to NULL pointer dereference.\n\t Reported by \"Mu Security Research Team\",\n\t \u003csecurity@musecurity.com\u003e.\n\t* bgp_attr.c: (bgp_attr_community) If community length is 0,\n\t don\u0027t set the community-present attribute bit, just return\n\t early.\n\t* bgp_debug.c: (community_str,community_com2str) Check com\n\t pointer before dereferencing.\n" }, { "commit": "9eda90ce8094683a5315007fbd0f9249a284f36f", "tree": "1d861050148c03dc4c37a1266c4567b24e9e6da1", "parents": [ "6d134fb4defecb16591adbf4acb020acd165a75a" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Aug 30 13:36:17 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Aug 30 13:36:17 2007 +0000" }, "message": "[bgpd] bug #398 Bogus free on out route-map, and assert() with rsclients\n\n2007-08-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_announce_check) Fix bug #398, slight\n\t modification of Vladimir Ivanov\u0027s suggested fix - to keep\n\t memory alloc conditional.\n\t (bgp_process_announce_selected) Don\u0027t take struct attr as\n\t argument, none of the callers need it and it needlessly\n\t distances allocation from use.\n\t Free the extended attr, the attr itself is on the stack.\n\t Fix bad indentation.\n\t* bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,\n\t and adjust conditional to test attr-\u003eextra, diagnosis by\n\t Vladimir Ivanov in bug #398.\n\n2007-08-27 Vladimir Ivanov \u003cwawa@yandex-team.ru\u003e\n\n\t* bgp_route.c: (bgp_announce_check_rsclient) copy of\n\t ri-\u003eattr is no longer deep enough, due to addition of\n\t attr-\u003eextra. It should use bgp_attr_dup, as\n\t bgp_announce_check() does.\n" }, { "commit": "41367172d812354c05b11818346f0d49c2245aef", "tree": "eb8f83ec0e93cb5a1d8470afd5c79ce55bc853da", "parents": [ "6d58272b4cf96f0daa846210dd2104877900f921" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "message": "[bgpd] Add support for AS_PATHLIMIT / draft-ietf-idr-as-pathlimit\n\n2007-07-31 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Support for draft-ietf-idr-as-pathlimit-03.\n\t* bgp_attr.h: (struct attr) Add pathlimit struct\n bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.\n (attrhash_key_make) tally pathlimit too\n (attrhash_cmp) cmp pathlimit attr\n (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.\n (bgp_attr_parse) ditto\n (bgp_packet_attribute) Write out AS_PATHLIMIT when set\n (bgp_dump_routes_attr) ditto\n * bgp_route.h: (struct bgp_static) Add TTL field\n * bgp_route.c: (bgp_announce_check) Drop paths that are over\n their hop-count TTL before sending via EBGP.\n Mangle ASN in pathlimit for confeds/private as best we can.\n (bgp_static_update_{rsclient,main}) Add any configure pathlimit\n information.\n (bgp_pathlimit_update_parents) New, update atomic-aggr setting for\n parents of an aspathlimit\u0027ed static.\n (bgp_static_set) Add TTL argument, for all the \u0027bgp network\u0027\n commands.\n Call previous for TTL changed statics.\n (bgp_static_unset) Call pathlimit_update_parents.\n (various bgp network commands) Add \u0027pathlimit \u003c0-255\u003e\u0027 qualifier\n to all the various forms, bar route-map - which can set ttl\n itself.\n * bgp_routemap.c: (general) Add support for \u0027set pathlimit ttl\u0027 and\n \u0027match pathlimit as\u0027.\n * doc/bgpd.texi: Document \u0027network ... pathlimit \u003cttl\u003e\u0027\n" }, { "commit": "fb982c25aa771b7c7425a3c3cce0a2cda0a715de", "tree": "74aa4dc86b04365d90a1030682796421b0eff011", "parents": [ "5921ef9aae3b5d6ff8663298f649fb9d76594acd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "message": "[bgpd] Trim memory usage of BGP routes\n\n2007-05-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: (struct info) Move less frequently used\n\t fields to a lazily allocated struct info_extra.\n\t Export bgp_info_extra_get\n\t* bgp_route.c: (bgp_info_extra_new) allocate extra\n\t (bgp_info_extra_free) Free damp info and the info_extra.\n\t (bgp_info_extra_get) Retrieve the info_extra of a struct\n\t info, allocating as required.\n\t (generally) adjust to use info-\u003eextra\n\t* bgp_damp.c: (generally) use bgp_info_extra_get to access\n\t dampinfo\n\t* bgp_attr.h: Move rarely allocated attributes from struct attr\n\t to a struct attr_extra, for a substantial saving in size of\n\t struct attr.\n\t* bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.\n\t (bgp_attr_extra_get) Get the attr_extra for a given struct\n\t attr, allocating it if needs be.\n\t (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.\n\t (generally) adjust to know about attr-\u003eextra.\n\t* bgp_debug.c: (bgp_dump_attr) ditto\n\t* bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.\n\t* bgp_nexthop.c: (generally) adjust to know about attr-\u003eextra\n\t and info-\u003eextra.\n\t* bgp_{packet,routemap,snmp,zebra}.c: ditto\n\t* lib/memtypes.c: Add MTYPE_ATTR_EXTRA and MTYPE_BGP_ROUTE_EXTRA\n" }, { "commit": "03e214c87bf4537576d2c7e9b2d812d1b0da2f56", "tree": "46f53f23bc77af0c8e6835853fbc355c3c342ddf", "parents": [ "923de654c8d251d6714a6f9da2e93c236e935042" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:31:07 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:31:07 2007 +0000" }, "message": "[bgpd] Use defines for default weight\n\n2007-04-22 Sebastien Tandel \u003csebastien@tandel.be\u003e\n\n\t* bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.\n\t* bgp_attr.c : (bgp_attr_default_intern) now uses\n\t bgp_attr_default_set instead of duplicating the same code.\n\t (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by\n\t IPV6_MAX_BYTELEN.\n" }, { "commit": "923de654c8d251d6714a6f9da2e93c236e935042", "tree": "473cc25308810340efb82724101bd428af352958", "parents": [ "e8eb8340c14f53194786b766992f61cc0abf7a8e" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "message": "[bgpd] Fix warnings: hash callbacks should match hash API declarations\n\n2007-04-22 Sebastien Tandel \u003csebastien@tandel.be\u003e\n\n\t* bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)\n\t conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with\n\t void * arguments as defined by the API.\n\t* bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.\n\t Defines _hash_[alloc|key|cmp] with void * arguments as defined by\n\t the API.\n\t* bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,\n\t cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,\n\t transit_hash_cmp, attrhash_key_make, attrhash_cmp,\n\t bgp_attr_hash_alloc) conforms to quagga hash API. Defines\n\t _hash_[alloc|key|cmp] with void * arguments as defined by the API.\n" }, { "commit": "6e4ab12f1504caa95edc7702a82f118d0de15a0a", "tree": "50b6784229f92d404e5d6509848c135395743f2f", "parents": [ "16d2e2410d6e8cf53fac05b956f3e7ee53bc7234" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:36:48 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:36:48 2007 +0000" }, "message": "[bgpd] Bug #354: Take care to keep reads of MP_(UN)REACH_NLRI in bounds\n\n2007-04-08 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and\n\t MP_UNREACH_NLRI does not take sufficient care to ensure reads\n\t from stream buffer stay in-bounds. Hence bgpd may attempt to read\n\t beyond end of stream, if given a crafted packet. As it uses the\n\t stream access methods to do so, this will typically result in\n\t assert() being hit in stream.c. Where code is compiled without\n\t assert() enabled, result is unknown.\n\t (struct message attr_str) should be static.\n\t (bgp_mp_reach_parse) Carefully check length remaining in stream\n\t against amount desired to read from stream, prior to each read,\n\t particularly where lengths are conditional on data obtained from\n\t stream - using STREAM_READABLE.\n\t Remove code to parse SNPA-number, it\u0027s a defunct field and changed\n\t to a fixed size in latest BGP MP update RFC - log warning if\n\t SNPA-number is not 0.\n\t (bgp_mp_unreach_parse) Check withdraw_length carefully against\n\t STREAM_READABLE.\n\t (bgp_attr_parse) If attribute-parser function returns error, log\n\t warning.\n\t Log attribute type on mismatch.\n" }, { "commit": "34c3f81b542c7f91fa04a43f7d0a8a4482f22d4d", "tree": "58f05fdafbc1c2036b9ccdf9de01d77f503e510e", "parents": [ "5fc60519ede0d34688832e353c35bf1832a4330d" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:25:37 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:25:37 2006 +0000" }, "message": "[bgpd] Remove dead code in ORIGINATOR_ID packet forming code\n\n2006-05-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity\n\t CID #1\n" }, { "commit": "a3b6ea56a0add7d0972a66d96e1fbcf5461eecdb", "tree": "a7bb8a005ab41ce30c43dd0fc2fab487c0e5f613", "parents": [ "5f03f141eced8bad4971fcc6ec7d7a538c227d8c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 07:52:12 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 07:52:12 2006 +0000" }, "message": "[bgpd] bug #210: Enable crucial VPNv4 code which was disabled\n\n2006-05-04 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) VPNv4 fixes. Certain VPNv4 code was not enabled.\n\t See bug #210.\n\t* bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be\n\t u_char really.\n\t* bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some\n\t VPNv4 code which inexplicably was ifdef\u0027d out. comments from\n\t a tester on IRC suggest this fixes bug #210.\n" }, { "commit": "cbdfbaa51b600c7b217968b99a9b5a8fbf04bec4", "tree": "bb8ce6ac1da775d34796315b1c5ac82e477bbd13", "parents": [ "478ccfd61bd61fd6925c84811c2c0e893a38a38b" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:20:48 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:20:48 2006 +0000" }, "message": "[bgpd] rearrange some structs for less padding, stats for table/attrs.\n\n2006-03-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_attr.h: (struct attr) rearrange fields to avoid\n\t wasted padding between them as much as possible.\n\t (attr_count,attr_unknown_count) export new functions to\n\t return number of counts of cached attributes.\n\t* bgp_attr.c: (attr_count,attr_unknown_count) new functions to\n\t return number of counts of cached attributes.\n\t* bgp_route.h: (struct bgp_info) rearrange fields to avoid\n\t wasted padding.\n\t* bgp_table.h: (struct bgp_table) Add a count field, of number\n\t of nodes in the table.\n\t (struct bgp_node) rearrange fields to avoid\n\t wasted padding between them, though I don\u0027t think there\n\t was any in this case.\n\t* bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.\n\t (bgp_table_count) new function to access the table count.\n" }, { "commit": "e8e1946edf6ba87ef53832cdceccc39d7f0c3f26", "tree": "fcdaf92bf4129a8a58825bd21ae841a6b3b2bda8", "parents": [ "779adb0147cfff1a831b08853976342ad2110fcd" ], "author": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "message": "[compiler] miscellaneous trivial compiler warning fixes\n\n2006-01-19 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n * (general) various miscellaneous compiler warning fixes.\n Remove redundant break statements from switch clauses\n which return.\n return from main, not exit, cause it annoys SOS.\n Remove stray semi-colons which cause empty-statement\n warnings.\n\t* zebra/main.c: (sighup) remove private declaration of external\n\t function.\n" }, { "commit": "fe69a505f7be4357bf8523e3bbdced9c95590f3a", "tree": "6d2450016eb19f30b153b2439d06ade68d1b8f12", "parents": [ "1f8ae70b7b86d132b95a18f0c824deb248987afc" ], "author": { "name": "paul", "email": "paul", "time": "Sat Sep 10 16:55:02 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Sep 10 16:55:02 2005 +0000" }, "message": "2005-09-10 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Makefile.am: bgpd shouldn\u0027t list libgp\u0027s sources as its own.\n\t Use LDADD.\n\t* bgp_aspath.h:\n\t (struct assegment) New struct, abstract representation of a\n\t list of AS_PATH segments and the contained ASNs.\n\t (struct aspath) Remove the raw-data related\n\t fields, reference the abstract struct assegment instead.\n\t Remove several other computed fields, it\u0027s just a\n\t headache to maintain them and they\u0027re cheap to compute from\n\t struct assegment.\n\t (aspath_parse) parse a stream, not a pointer to raw data.\n\t (aspath_count_{hops,confeds,size}) helpers to access\n\t information formerly directly contained in struct aspath.\n\t (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants\n\t to be able to output hex representation of raw data.\n\t* bgp_aspath.c: (general) partial-rewrite. Store aspath data\n\t as an abstract singly-linked list of abstract segments,\n rather than storing the raw data, and parsing it each and\n\t every time. Remove several count/size fields which are cheap\n\t to compute from the abstract segment structure.\n\t (global) Include stream.h, needed for aspath_parse, and\n\t others. Couple of helper macros added.\n\t (struct assegment_header) Just the header, and only the\n\t header.\n\t (assegment_data_{new,free}) convenience functions for\n\t AS_SEG_DATA allocation, the dynamic, per-segment array of\n\t ASNs.\n\t (assegment_{new,free,free_all,dup,dup_all}) convenience\n\t functions for creating struct assegments. The _all forms will\n\t follow the entire chain of segments from the given segment.\n\t (assegment_prepend_asns) new function, prepend an ASN N times\n\t to segment.\n \t (assegment_append_asns) Append a list (array) of ASNs to\n\t segment.\n\t (int_cmp) convenience function for the aspath hash.\n\t (assegment_normalise) new function. Normalise the given\n\t segment chain to meet expectations of Quagga, and to\n\t eliminate differing raw representations of the same paths.\n\t Merge \u0027runs\u0027 of SEQUENCEs into one segment as our internal\n\t segment is not limited by the protocol AS_PATH segment\n\t length. Sort ASNs in SETs.\n\t (aspath_new) Take void argument to quell warnings. Use the\n\t assegment convenience functions.\n\t (assegment_count_{asns,confeds,hops}) new functions to\n\t compute at runtime values previously held in struct aspath.\n\t (aspath_size) ditto.\n\t (aspath_make_str_count) rewritten to stringify new\n\t representation, and to be slightly easier to understand\n\t hopefully.\n\t (aspath_str_update) convenience function, update the aspath\n\t str. Should investigate removing maintained string from\n\t struct aspath, just run-time compute it, as per other fields.\n\t It\u0027s just a maintenance headache, would save noticeable\n\t amount of RAM with possibly not much extra run-time cost.\n\t (aspath_dup) use the assegment dup functions.\n\t (aspath_hash_alloc) Take void * argument to satisfy gcc. Use\n\t the proper helper functions to dup data.\n\t (assegments_parse) new function. parse raw AS_PATH data into\n\t struct assegments. Normalise and return the head of the list.\n\t (aspath_parse) Parse a stream, not pointer to raw data and\n\t use assegments_parse to do it.\n\t (assegment_data_put) Write out a single segment data in protocol\n\t form to stream.\n\t (assegment_header_put) ditto but for segment header.\n\t (aspath_put) new function. As per previous but for an entire\n\t struct aspath.\n\t (aspath_snmp_pathseg) wrapper around aspath_put for\n\t bgp_snmp.c. Uses a static buffer sadly.\n\t (aspath_aggregate_as_set_add) rewritten to use assegments.\n\t (aspath_aggregate) ditto\n\t (aspath_{firstas,loop,private_as}_check) ditto\n\t (aspath_{merge,prepend,add_one_as}) ditto\n\t (aspath_cmp_left{_confed}) ditto\n\t (aspath_delete_confed_seq) ditto, plus fixed to properly\n\t delete all leading confed segments.\n\t (aspath_as_add) Just use assegment_append_asns.\n\t (aspath_segment_add) updated to use assegments.\n\t (enum as_token) Add values for confeds\n\t (aspath_gettoken) Add support for confeds\n\t (aspath_str2aspath) ditto\n\t (aspath_key_make) updated to use as_segments. Also, add\n\t segment type into the hash value as appropriate.\n\t (aspath_cmp) updated to use as_segments.\n\t (aspath_print) don\u0027t segfault on NULL argument.\n\t* bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream\n\t now. No need for manual forwarding of stream.\n\t (bgp_packet_attribute) empty aspath is now denoted by NULL\n\t segment field, length is gone.\n\t Use aspath_size() to determine size.\n\t (bgp_attr_init) Fix declaration, explicitely specify void\n\t arg.\n\t (bgp_dump_routes_attr) Use aspath_size() to determine size.\n\t* bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.\n\t (bgp_rib_withdraw) remove unused variable. Use\n\t aspath_count_hops.\n\t* bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use\n\t aspath_snmp_pathseg to get the representation.\n" }, { "commit": "94f2b3923e9663d0355a829f22e4e31cf68ee7b8", "tree": "59c0291a76b1c97fbb089abb479307f19cdfd4c1", "parents": [ "7cad40007b9714dba65065916ea68577f9d3d6dd" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) The great bgpd extern and static\u0027ification.\n\t* bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code\n\t (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison\n\t warnings.\n\t* bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these\n\t used by various files which had their own private declarations,\n\t in the case of mplsvpn - incorrect.\n" }, { "commit": "9985f83ce7102f64b15f744b60320f8d14a8a5ff", "tree": "344629bdc2b4a7d53b8d7ca1705c9be2ca282d18", "parents": [ "083ee9d9cdbf72a452b9af96e62d0625ea712cd9" ], "author": { "name": "paul", "email": "paul", "time": "Wed Feb 09 15:51:56 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Feb 09 15:51:56 2005 +0000" }, "message": "2005-02-09 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) Update code to match stream.h changes.\n\t stream_get_putp effectively replaced with stream_get_endp.\n\t stream_forward renamed to stream_forward_getp.\n\t stream_forward_endp introduced to replace some previous\n\t setting/manual twiddling of putp by daemons.\n\t* lib/stream.h: Remove putp. Update reference to putp with endp.\n\t Add stream_forward_endp, which daemons were doing manually.\n\t Rename stream_forward to stream_forward_getp.\n\t lib/stream.c: Remove/update references to putp.\n\t introduce stream_forward_endp.\n" }, { "commit": "3d515fd9af9f126667a9c2da9c2f40c4c37c28df", "tree": "c107224556ed7678d7a5afc42c19742948cda477", "parents": [ "0a486e5fcb1b8dac7d8b4cf6ed93e82b8b72fed6" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 21:30:04 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 21:30:04 2005 +0000" }, "message": "\t* bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old\n\t draft - ie. \"neighbor version 4-\" commands. Preserve dummy \"neighbor\n\t version\" command as deprecated.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "f418446bb767d79438e2df689c5bf9563c54b317", "tree": "a1c7322c8b54e46a09bf2f402537277fff59c1c3", "parents": [ "6a52d0d155fc8b892e30cdb5e3fbe4c2779bd4cd" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:13:16 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:13:16 2005 +0000" }, "message": " * bgp_nexthop.c: Improve debug.\n * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()\n function.\n * bgp_packet.c: MP AFI_IP update and withdraw parsing.\n * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()\n is better place to log about peer status change than bgp_event().\n Log in bgp_connect_success().\n * bgp_vty.c: Fix typo in comment.\n * bgp_attr.c: Better log about unknown attribute.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "c29fdba771810c70d78d87127d3a479e0f72b60e", "tree": "75361d6969db5f8796596ccb7dbcae1d6769523e", "parents": [ "d1db06faa82a331fb6729064290ecbc61a969b88" ], "author": { "name": "gdt", "email": "gdt", "time": "Thu Dec 09 14:46:46 2004 +0000" }, "committer": { "name": "gdt", "email": "gdt", "time": "Thu Dec 09 14:46:46 2004 +0000" }, "message": "Add comments with warnings obtained on NetBSD/i386. Both are due to\nsize_t being used for streams. Perhaps cast to unsigned long before\nprintf? Surely that\u0027s big enough even if size_t could be larger in\ntheory.\n\n(no changelog, since only comment changes)\n" }, { "commit": "557865c28e34e9172477e9fab025e7888f62dad7", "tree": "151705cd67bda4e7f838856abbe34c96acaf5376", "parents": [ "c610681284be58ec2e39867379bdf2ca3047f464" ], "author": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 19:59:11 2004 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 19:59:11 2004 +0000" }, "message": "2004-12-08 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* *.c: Change level of debug messages to LOG_DEBUG.\n" }, { "commit": "a2b1ecd29f8bd4b01d5287ff862e156b2ffc30b3", "tree": "6c4947a0e49537be984ca482b5b4f32b3763d2bc", "parents": [ "64511f394a90602a31cbe1660be426c16439322c" ], "author": { "name": "paul", "email": "paul", "time": "Sun Oct 31 18:58:09 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sun Oct 31 18:58:09 2004 +0000" }, "message": "2004-10-31 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* {bgpd,bgp_attr}.c: size_t printf format should be ld.\n" } ], "next": "fee0f4c629412f422fc9a857e097ef335c2c576c" }