)]}' { "log": [ { "commit": "e81537d3be9f95d333d658329e5d69e6188b53c0", "tree": "5f91b0f1d2a0dae1671c788c7d7804b16adcd4cd", "parents": [ "87f011e5297ab9d3c599916800aab1198613071e" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jul 14 12:36:19 2011 +0400" }, "message": "bgpd: more SAFI fixes\n\nTwo macros resolving to the same integer constant broke a case block and\na more thorough merge of BGP_SAFI_VPNV4 and BGP_SAFI_VPNV6 was\nperformed.\n\n* bgpd.h: MPLS-labeled VPN SAFI is AFI-independent, switch to single\n* macro\n* bgp_capability_test.c: update test data\n* bgp_mp_attr_test.c: idem\n* bgp_route.c: (bgp_maximum_prefix_overflow, bgp_table_stats_vty) update\n macro and check conditions (where appropriate)\n* bgp_packet.c: (bgp_route_refresh_send, bgp_capability_send,\n bgp_update_receive, bgp_route_refresh_receive): idem\n* bgp_open.c: (bgp_capability_vty_out, bgp_afi_safi_valid_indices,\n bgp_open_capability_orf, bgp_open_capability): idem\n* bgp_attr.c: (bgp_mp_reach_parse, bgp_packet_attribute,\n bgp_packet_withdraw): idem\n" }, { "commit": "ea15b20a7cb8e41e61c48e36a554c576ed6f2f91", "tree": "311dd5818509e860ef1917c550859f5503bfc1d8", "parents": [ "82a963a1b8d9066f5e3e24e98b65398d32a73876" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Tue Jul 12 20:09:18 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Jul 12 20:09:18 2011 +0400" }, "message": "bgpd: consistent log msg format (BZ#565)\n" }, { "commit": "e70e575a8cb1edcab2eedade04bb4ac31938bddf", "tree": "5a72f6c9d4f7a50ea2b40229b8b04adece6f67b0", "parents": [ "fc09716b81e67f2d06dc92ff7bcb1efdf18c4eec" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 05 00:41:59 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Jul 05 00:41:59 2011 +0400" }, "message": "bgpd: Remove AS Path limit/TTL functionality\n\n* draft-ietf-idr-as-pathlimit doesn\u0027t seem to have gone anywhere, and its\n author does not think it will make progress in IDR. Remove all support\n introduced for it, but leave stubs for the commands to avoid breaking\n any configurations.\n\n Basically reverts cecab5e9725792e60a5e4b473e238a14cd85815d.\n(cherry picked from commit c8f3fe3063cb9ff193b13011cfbda3e605395340)\n\nConflicts:\n\n\tbgpd/bgp_attr.c (caused by c8e7b895, resolved)\n" }, { "commit": "fc09716b81e67f2d06dc92ff7bcb1efdf18c4eec", "tree": "0685e19912029d28e8a0731091419e836423f24c", "parents": [ "f668053f1453d64296db6807101450ad749ba730" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Dec 05 17:17:26 2010 +0000" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Jul 04 21:02:00 2011 +0400" }, "message": "bgpd/security: CVE-2010-1674 Fix crash due to extended-community parser error\n\n* bgp_attr.c: (bgp_attr_ext_communities) Certain extended-community attrs\n can leave attr-\u003eflag indicating ext-community is present, even though no\n extended-community object has been attached to the attr structure. Thus a\n null-pointer dereference can occur later.\n (bgp_attr_community) No bug fixed here, but tidy up flow so it has same\n form as previous.\n\n Problem and fix thanks to anonymous reporter.\n(cherry picked from commit 0c46638122f10019a12ae9668aec91691cf2e017)\n" }, { "commit": "4c9641ba4df276080c670e03f65b1d442660a50f", "tree": "15085df8068d8a3864224937eaa407c0484ff57f", "parents": [ "11d3fe9b9a327b3218a76b2b9001ace50c08de8c" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Thu Jul 22 13:20:55 2010 -0400" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Wed Oct 06 12:33:05 2010 -0400" }, "message": "bgpd, lib: adopt afi_t and safi_t in several places\n\n* bgpd/bgp_attr.c, bgpd/bgp_open.h, bgpd/bgp_route.c, lib/prefix.c,\n lib/prefix.h: Various integer types were being used where, if we\n had strict type checking, afi_t and safi_t would be required.\n\nSigned-off-by: G.Balaji \u003cbalajig81@gmail.com\u003e\n(cherry picked from commit c8af35ffa2dc79ff7d7ff00b1b61f1f50a100ab6)\n" }, { "commit": "cddb8112b80fa9867156c637d63e6e79eeac67bb", "tree": "c8d8b4cb9d0ba1c2a7681c6da580874cf5a2b48e", "parents": [ "d64379e8f3c0636df53ed08d5b2f1946cfedd0e3" ], "author": { "name": "Chris Hall", "email": "chris.hall@highwayman.com", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Aug 09 22:31:37 2010 +0400" }, "message": "bgpd: fix handling of AS path data\n\n* bgpd/bgp_aspath.c\n * assegments_parse(): add handling of AS4_PATH input, update bounds\n checks, add check for AS segment type\n * aspath_parse(): add handling of AS4_PATH input, expect\n assegments_parse() to do length checking\n * aspath_empty(): update for the new function prototype\n* bgpd/bgp_aspath.h: ditto\n* tests/aspath_test.c: ditto\n* bgpd/bgp_attr.c\n * bgp_attr_aspath(): add handling of AS4_PATH input, update flags\n checks, change returned type\n * bgp_attr_as4_path(): discard, superseded by bgp_attr_aspath()\n * bgp_attr_parse(): update respectively\n" }, { "commit": "66bed4f4f0235c1eb6edb0a2f6bd4aaf47e5a7f8", "tree": "17488e5dc6eb4cc575f2aa006bfd87ec9c815222", "parents": [ "3de4277ba9b25ff03710d7c004bf708accffd5c7" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Tue Jul 28 11:26:14 2009 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:14 2009 +0100" }, "message": "bgpd: Workaround for invalid MBGP next hop\n\n* bgp_attr.c: (bgp_mp_reach_parse) There are some interoperability issues\n for MBGP (particularly IPv4 multicast NLRI) between different\n implementations. In order to get some next hops to install correctly in\n the BGP tables, it appears to be necessary to copy the multiprotocol next\n hop into the base next hop field. This is related to differences in RFC\n 2283 and RFC 2858.\n" }, { "commit": "ca87e1d37b3c30648e9bacb476a3c89729512f6d", "tree": "d0911b72e7d4c3c94c88a65233ee8a7fa8a4c950", "parents": [ "30d205909c5a81cc306b161c16abff0fd7f566a7" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:28:35 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 14:49:33 2009 +0100" }, "message": "bgpd: Implement BGP confederation error handling (RFC5065, Par. 5)\n\nThis patch implements BGP confederation error handling in Quagga as described\nin RFC5065, paragraph 5.\n\n* bgp_aspath.c: (aspath_confed_check, aspath_left_confed_check) new functions\n* bgp_attr.c: (bgp_attr_aspath_check) apply previous and NOTIFY if there\u0027s\n a problem.\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "9bddac4bd50034c713940ad77cebfbb7f3cd123a", "tree": "2d41a091918fd6d4ca433493a7c9ec9d50eaf343", "parents": [ "fda1d3e033f98c7e34ccdaead27e8df39af12a85" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Fri May 15 09:59:51 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 18 20:18:28 2009 +0100" }, "message": "[bgpd/cleanup] BGP make attribute variables local\n\nMessage lists can be read-only, and hash tables are local to this\ncode.\n" }, { "commit": "66e5cd87194ae6fdd51061a91b4698bc0a652f6b", "tree": "659d31f9a7dfb8d9ad9a51f37ff0853054a45399", "parents": [ "cedd7f2fa6823bca9ddcfb062f97ed83b11a80dd" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Feb 09 10:14:16 2009 -0800" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:09:03 2009 +0100" }, "message": "[cleanup] functions taking no args should be declared with void args\n\nUse Ansi-C prototypes rather than old K\u0026R method of declaring\nfunction without arguments\n" }, { "commit": "393deb9bd663361e6b110d579a8b1d4c22667068", "tree": "e93ebf2f57bf92ff7a9cd045764b3cdbb99a07e5", "parents": [ "3453a7122c1d585ad789ed0f63deb90cc5e89fae" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Aug 18 14:13:29 2008 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:07:49 2009 +0100" }, "message": "[cleanup] Convert XMALLOC/memset to XCALLOC\n\nSimple conversion of XMALLOC/memset to XCALLOC\n" }, { "commit": "aea339f72807c34a7916d8614e030069815e144c", "tree": "7b0ab93dcfec82736f05ac39106096360e4ceeb5", "parents": [ "c540835eaf0cb59921969537d8e94cc83bb717f5" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "message": "[bgpd] AS4 bugfix by Chris Caputo \u003cccaputo@alt.net\u003e\n\n* bgpd/bgp_aspath.c: (aspath_make_str_count) \"assert (len \u003c str_size)\" was\n getting hit under certain 4-byte ASN conditions. New realloc strategy.\n* bgpd/bgp_aspath.c: (aspath_key_make) const warning fix.\n\n\"%d\" -\u003e \"%u\" 4-byte ASN corrections. Prevent negative number when ASN is\nabove 2^31.\n" }, { "commit": "30a2231a4881f53deca61ef7a62b225a43dab4c5", "tree": "f26dff922a4f85d302fa67bbd9a120108db41c44", "parents": [ "f5612dd382d9c0f4089b08ec164c25a8082d9f89" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Aug 15 14:05:22 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:59 2008 +0100" }, "message": "[warnings] Fix various SOS warnings\n\n2008-08-15 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* */*: Fix various problems flagged by Sun Studio compiler.\n\t - \u0027\u003cqualifier\u003e \u003cstorage\u003e\u0027 obsolescent in declarations\n\t - empty statements (\u0027;\u0027 after ALIAS definitions)\n\t - implicit declarations (e.g printstack in lib/log.c)\n\t - \"\\%\" in printf string instead of \"%%\"\n\t - loops that return on the first iteration (legitimately, but\n \t compiler can\u0027t really know), e.g. bgp_routemap.c\n \t - internal declarations which mask prototypes.\n" }, { "commit": "ffe11cfb0a808ae514193438616dfabc512b4cf6", "tree": "94452dba2c1a49d6e6a0782c6513acb36823cefc", "parents": [ "9fd4958a4eef88c536e4a5aeefce302e10ee8ee6" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Thu Aug 14 16:25:25 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:58 2008 +0100" }, "message": "[lib] hash compare function arguments ought to be const qualified\n\n2008-08-14 Stephen Hemminger \u003cstephen.hemminger@vyatta.com\u003e\n\n\t* lib/hash.h: (struct hash) Hash comparator callback really\n\t ought to treat storage behind arguments as constant - a compare\n\t function with side-effects would be evil.\n\t* */*.c: Adjust comparator functions similarly, thus fixing at least\n\t a few compiler warnings about const qualifier being dropped.\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "851a1a5c146b346d8b8f58fe3924baa5c208f865", "tree": "38817ea92885b4274ca63ad2fc502da7a92c058d", "parents": [ "0df7c91f048f2116610d6bdfce3ab6cad1981802" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 19:56:56 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Jul 22 19:56:56 2008 +0000" }, "message": "[bgpd] fix a couple of trivial compiler warnings\n\n2008-07-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_community.c: (community_str2com) assigns defaults to local\n\t vars\n\t* bgp_attr.c: (bgp_attr_parse) match format specifier to arg\n\t* bgp_table.{c,h}: (bgp_table_top) can take a * to a const, quelling\n\t warning in bgp_route.c\n" }, { "commit": "032928091c558d3b0940be079049009f47652711", "tree": "81bd1c2ddfbf41f380bfd38370e42d3c646f5e08", "parents": [ "343f720b345dd377bdf4f53e3b02e0c2898f3f0b" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:37:10 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:37:10 2008 +0000" }, "message": "[bgpd] minor changes to bgp_mp_reach_parse\n\n2008-06-07 Paul Jakma \u003cpaul@jakma.org\u003e\n\n\t* bgp_attr.{c,h}: (bgp_mp_{un,}reach_parse) export, for unit tests.\n\t* bgp_attr.c: (bgp_mp_reach_parse) Add logging. Tighten length test\n\t to bounds check against the attribute length rather than the\n\t stream length..\n" }, { "commit": "a15cfd16fcdec39588ce2f780671ba7c6de0b919", "tree": "ccd6a9a654bfe0a7ae376d5e268d2749be06e6fa", "parents": [ "0e7c124f870d4c95ff3edbde1a766717c696da7c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Jun 01 14:29:03 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Jun 01 14:29:03 2008 +0000" }, "message": "[bgpd] bug #419: partial aspath-limit incorrectly causes session reset\n\n2008-06-01 jfletche@gmail.com\n\n\t* bgp_attr.c: (bgp_attr_aspathlimit) fix silly bug in flags check\n\t that was causing BGP to drop sessions if it received a\n\t aspath-limit with partial set. Fixes bug #419.\n" }, { "commit": "693b67b2b20510e0faee87a0950595832ce71054", "tree": "bb7e728238fdf0a6e0d827afdad37ffb3d0279e1", "parents": [ "ce6ab03a273beb903731621153722511910ebbe5" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 13 03:31:24 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 13 03:31:24 2008 +0000" }, "message": "[bgpd] remove unnecessary 0 entries from struct message\u0027s\n\n2008-03-13 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (various) Remove 0 entries from struct message\u0027s, unneeded due to\n\t recent improvements in mes_lookup/LOOKUP.\n" }, { "commit": "370b64a2ad38e43b4bed028960481bbf4192becd", "tree": "ebecb7f934a7058d582e52b5c64a21eb676ec994", "parents": [ "a7f93f3e060fdb2dc7bf5ff4ed4563d4b689bc6c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "message": "[bgpd] Fix number of DoS security issues, restricted to configured peers.\n\n2007-12-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Fix series of vulnerabilities reported by \"Mu Security\n\t Research Team\", where bgpd can be made to crash by sending\n\t malformed packets - requires that bgpd be configured with a\n\t session to the peer.\n\t* bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only\n\t set the attribute flag indicating AS4_PATH if we actually managed\n\t to parse one.\n\t (bgp_attr_munge_as4_attrs) Assert was too general, it is possible\n\t to receive AS4_AGGREGATOR before AGGREGATOR.\n\t (bgp_attr_parse) Check that we have actually received the extra\n\t byte of header for Extended-Length attributes.\n\t* bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.\n\t* bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,\n\t incorrect -2 left in place from a development version of as4-path\n\t patch.\n\t* bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter\n\t needs to be properly sanity checked.\n\t* tests/bgp_capability_test.c: Test for empty capabilities.\n" }, { "commit": "0b2aa3a0a8b095bdef1eddda117d173af75dede2", "tree": "29201cb2beec187409e842b4078ed8a8047d3f11", "parents": [ "7593fddfa1558d086e3142ad96cf2790007f5d84" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "message": "[bgpd] Merge AS4 support\n\n2007-10-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* NEWS: Note that MRT dumps are now version 2\n\t* (general) Merge in Juergen Kammer\u0027s AS4 patch.\n\n2007-09-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_aspath.c: (assegment_normalise) remove duplicates from\n\t from sets.\n\t (aspath_reconcile_as4) disregard a broken part of the RFC around\n\t error handling in path reconciliation.\n\t* aspath_test.c: Test dupe-weeding from sets.\n\t Test that reconciliation merges AS_PATH and AS4_PATH where\n\t former is shorter than latter.\n\n2007-09-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* aspath_test.c: Test AS4_PATH reconcilation where length\n\t of AS_PATH and AS4_PATH is same.\n\n2007-09-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (peek_for_as4_capability) Fix to work.\n\t* bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.\n\t* tests/bgp_capability_test.c: (general) Extend tests to validate\n\t peek_for_as4_capability.\n\t Add test of full OPEN Option block, with multiple capabilities,\n\t both as a series of Option, and a single option.\n\t Add some crap to beginning of stream, to prevent code depending\n\t on getp \u003d\u003d 0.\n\n2007-09-18 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (bgp_capability_as4) debug printf inline with others.\n\t (peek_for_as4_capability) There\u0027s no need to signal failure, as\n\t failure is better dealt with through full capability parser -\n\t just return the AS4, simpler.\n\t* bgp_packet.c: (bgp_open_receive) Update to match\n\t peek_for_as4_capability change.\n\t Allow use of BGP_AS_TRANS by 2b speakers.\n\t Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.\n\t (bgp_capability_msg_parse) missing argument to debug print\n\t (bgp_capability_receive) missing return values.\n\t* tests/bgp_capability_test.c: (parse_test) update for changes to\n\t peek_for_as4_capability\n\n2007-07-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Remove 2-byte size macros, just make existing macros take\n\t argument to indicate which size to use.\n\t Adjust all users - typically they want \u00271\u0027.\n\t* bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any\n\t as4\u0027s in a path.\n\t (aspath_put) Return the number of bytes actually written, to\n\t fix the bug Juergen noted: Splitting of segments will change\n\t the number of bytes written from that already written to the\n\t AS_PATH header.\n\t (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP\n\t is still defined as 2b.\n\t (aspath_aggregate) fix latent bug.\n\t (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation\n\t function.\n\t (aspath_key_make) Hash the AS_PATH string, rather than\n\t just taking the addition of assegment ASes as the hash value,\n\t hopefully sligthly more collision resistant.\n\t (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes\n\t together with the OLD 2-byte forms, code Juergen\n\t had in bgp_attr_parse but re-organised a bit.\n\t (bgp_attr_parse) Bunch of code from Juergen moves\n\t to previous function.\n\t (bgp_packet_attribute) Compact significantly by\n\t just /always/ using extended-length attr header.\n\t Fix bug Juergen noted, by using aspath_put\u0027s\n\t (new) returned size value for the attr header rather\n\t than the (guesstimate) of aspath_size() - the two could\n\t differ when aspath_put had to split large segments, unlikely\n\t this bug was ever hit in the \u0027wild\u0027.\n\t (bgp_dump_routes_attr) Always use extended-len and\n\t use aspath_put return for header length. Output 4b ASN\n\t for AS_PATH and AGGREGATOR.\n\t* bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix\n\t hash callback declarations to match prototypes.\n\t (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,\n\t complete rewrite of Juergen\u0027s changes (no asdot support)\n\t* bgp_open.c: (bgp_capability_as4) New, does what it says\n\t on the tin.\n\t (peek_for_as4_capability) Rewritten to use streams and\n\t bgp_capability_as4.\n\t* bgp_packet.c: (bgp_open_send) minor edit\n\t checked (in the abstract at least) with Juergen.\n\t Changes are to be more accepting, e.g, allow AS_TRANS on\n\t a 2-byte session.\n\t* (general) Update all commands to use CMD_AS_RANGE.\n\t* bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..\n\t Remove stuff replicated by VTY_GET_LONG\n\t (bgp_clear_vty) Return bgp_clear directly to vty.\n\t* tests/aspath_test.c: Exercise 32bit parsing. Test reconcile\n\t function.\n\t* tests/ecommunity_test.c: New, test AS4 ecommunity changes,\n\t positive test only at this time, error cases not tested yet.\n\n2007-07-25 Juergen Kammer \u003cj.kammer@eurodata.de\u003e\n\n\t* (general) AS4 support.\n\t* bgpd.h: as_t changes to 4-bytes.\n\t* bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.\n\t* bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE\n\t added for 2-byte.\n\t Add AS16 versions of length calc macros.\n\t (aspath_count_numas) New, count number of ASes.\n\t (aspath_has_as4) New, return 1 if there are any as4\u0027s in a\n\t path.\n\t (assegments_parse) Interpret assegment as 4 or 2 byte,\n\t according to how the caller instructs us, with a new\n\t argument.\n\t (aspath_parse) Add use32bit argument to pass to\n\t assegments_parse. Adjust all its callers to pass 1, unless\n\t otherwise noted.\n\t (assegment_data_put) Adjust to be able to write 2 or 4 byte\n\t AS, according to new use32bit argument.\n\t (aspath_put) Adjust to write 2 or 4.\n\t (aspath_gettoken) Use a long for passed in asno.\n\t* bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and\n\t BGP_ATTR_AS4_AGGREGATOR.\n\t (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as\n\t determined by received-capability flag.\n\t (bgp_attr_aspath_check) New, code previously in attr_aspath\n\t but moved to new func so it can be run after NEW_AS_PATH\n\t reconciliation.\n\t (bgp_attr_as4_path) New, handle NEW_AS_PATH.\n\t (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.\n\t (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.\n\t (bgp_attr_parse) Add handoffs to previous parsers for the two\n\t new AS4 NEW_ attributes.\n\t Various checks added for NEW/OLD reconciliation.\n\t (bgp_packet_attribute) Support 2/4 for AS_PATH and\n\t AGGREGATOR, detect when NEW_ attrs need to be sent.\n\t* bgp_debug.{c,h}: Add \u0027debug bgp as4\u0027.\n\t* bgp_dump.c: MRTv2 support, unconditionally enabled, which\n\t supports AS4. Based on patches from Erik (RIPE?).\n\t* bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4\n\t support.\n\t* bgp_open.c: (peek_for_as4_capability) New, peek for AS4\n\t capability prior to full capability parsing, so we know which\n\t ASN to use for struct peer lookup.\n\t (bgp_open_capability) Always send AS4 capability.\n\t* bgp_packet.c: (bgp_open_send) AS4 handling for AS field\n\t (bgp_open_receive) Peek for AS4 capability first, and figure\n\t out which AS to believe.\n\t* bgp_vty.c: (bgp_show_peer) Print AS4 cap\n\t* tests/aspath_test.c: Support asn32 changes, call aspath_parse\n\t with 16 bit.\n\t* vtysh/extract.pl: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/extract.pl.in: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/vtysh.c: AS4 compatibility for router bgp ASNUMBER\n" }, { "commit": "b2ceea18074ab8cca894051a3fbc30c312e3acc6", "tree": "3dfc9d1572582ed26cedad37768be9a57a67f5a8", "parents": [ "882968e0a2fe65db5aff29149c87f6d292a1cd2d" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Sep 07 14:24:55 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Sep 07 14:24:55 2007 +0000" }, "message": "[bgpd] low-impact DoS: crash on malformed community with debug set\n\n2007-09-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) bgpd can be made crash by remote peers if debug\n\t bgp updates is set, due to NULL pointer dereference.\n\t Reported by \"Mu Security Research Team\",\n\t \u003csecurity@musecurity.com\u003e.\n\t* bgp_attr.c: (bgp_attr_community) If community length is 0,\n\t don\u0027t set the community-present attribute bit, just return\n\t early.\n\t* bgp_debug.c: (community_str,community_com2str) Check com\n\t pointer before dereferencing.\n" }, { "commit": "9eda90ce8094683a5315007fbd0f9249a284f36f", "tree": "1d861050148c03dc4c37a1266c4567b24e9e6da1", "parents": [ "6d134fb4defecb16591adbf4acb020acd165a75a" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Aug 30 13:36:17 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Aug 30 13:36:17 2007 +0000" }, "message": "[bgpd] bug #398 Bogus free on out route-map, and assert() with rsclients\n\n2007-08-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.c: (bgp_announce_check) Fix bug #398, slight\n\t modification of Vladimir Ivanov\u0027s suggested fix - to keep\n\t memory alloc conditional.\n\t (bgp_process_announce_selected) Don\u0027t take struct attr as\n\t argument, none of the callers need it and it needlessly\n\t distances allocation from use.\n\t Free the extended attr, the attr itself is on the stack.\n\t Fix bad indentation.\n\t* bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,\n\t and adjust conditional to test attr-\u003eextra, diagnosis by\n\t Vladimir Ivanov in bug #398.\n\n2007-08-27 Vladimir Ivanov \u003cwawa@yandex-team.ru\u003e\n\n\t* bgp_route.c: (bgp_announce_check_rsclient) copy of\n\t ri-\u003eattr is no longer deep enough, due to addition of\n\t attr-\u003eextra. It should use bgp_attr_dup, as\n\t bgp_announce_check() does.\n" }, { "commit": "41367172d812354c05b11818346f0d49c2245aef", "tree": "eb8f83ec0e93cb5a1d8470afd5c79ce55bc853da", "parents": [ "6d58272b4cf96f0daa846210dd2104877900f921" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "message": "[bgpd] Add support for AS_PATHLIMIT / draft-ietf-idr-as-pathlimit\n\n2007-07-31 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Support for draft-ietf-idr-as-pathlimit-03.\n\t* bgp_attr.h: (struct attr) Add pathlimit struct\n bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.\n (attrhash_key_make) tally pathlimit too\n (attrhash_cmp) cmp pathlimit attr\n (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.\n (bgp_attr_parse) ditto\n (bgp_packet_attribute) Write out AS_PATHLIMIT when set\n (bgp_dump_routes_attr) ditto\n * bgp_route.h: (struct bgp_static) Add TTL field\n * bgp_route.c: (bgp_announce_check) Drop paths that are over\n their hop-count TTL before sending via EBGP.\n Mangle ASN in pathlimit for confeds/private as best we can.\n (bgp_static_update_{rsclient,main}) Add any configure pathlimit\n information.\n (bgp_pathlimit_update_parents) New, update atomic-aggr setting for\n parents of an aspathlimit\u0027ed static.\n (bgp_static_set) Add TTL argument, for all the \u0027bgp network\u0027\n commands.\n Call previous for TTL changed statics.\n (bgp_static_unset) Call pathlimit_update_parents.\n (various bgp network commands) Add \u0027pathlimit \u003c0-255\u003e\u0027 qualifier\n to all the various forms, bar route-map - which can set ttl\n itself.\n * bgp_routemap.c: (general) Add support for \u0027set pathlimit ttl\u0027 and\n \u0027match pathlimit as\u0027.\n * doc/bgpd.texi: Document \u0027network ... pathlimit \u003cttl\u003e\u0027\n" }, { "commit": "fb982c25aa771b7c7425a3c3cce0a2cda0a715de", "tree": "74aa4dc86b04365d90a1030682796421b0eff011", "parents": [ "5921ef9aae3b5d6ff8663298f649fb9d76594acd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "message": "[bgpd] Trim memory usage of BGP routes\n\n2007-05-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: (struct info) Move less frequently used\n\t fields to a lazily allocated struct info_extra.\n\t Export bgp_info_extra_get\n\t* bgp_route.c: (bgp_info_extra_new) allocate extra\n\t (bgp_info_extra_free) Free damp info and the info_extra.\n\t (bgp_info_extra_get) Retrieve the info_extra of a struct\n\t info, allocating as required.\n\t (generally) adjust to use info-\u003eextra\n\t* bgp_damp.c: (generally) use bgp_info_extra_get to access\n\t dampinfo\n\t* bgp_attr.h: Move rarely allocated attributes from struct attr\n\t to a struct attr_extra, for a substantial saving in size of\n\t struct attr.\n\t* bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.\n\t (bgp_attr_extra_get) Get the attr_extra for a given struct\n\t attr, allocating it if needs be.\n\t (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.\n\t (generally) adjust to know about attr-\u003eextra.\n\t* bgp_debug.c: (bgp_dump_attr) ditto\n\t* bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.\n\t* bgp_nexthop.c: (generally) adjust to know about attr-\u003eextra\n\t and info-\u003eextra.\n\t* bgp_{packet,routemap,snmp,zebra}.c: ditto\n\t* lib/memtypes.c: Add MTYPE_ATTR_EXTRA and MTYPE_BGP_ROUTE_EXTRA\n" }, { "commit": "03e214c87bf4537576d2c7e9b2d812d1b0da2f56", "tree": "46f53f23bc77af0c8e6835853fbc355c3c342ddf", "parents": [ "923de654c8d251d6714a6f9da2e93c236e935042" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:31:07 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:31:07 2007 +0000" }, "message": "[bgpd] Use defines for default weight\n\n2007-04-22 Sebastien Tandel \u003csebastien@tandel.be\u003e\n\n\t* bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.\n\t* bgp_attr.c : (bgp_attr_default_intern) now uses\n\t bgp_attr_default_set instead of duplicating the same code.\n\t (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by\n\t IPV6_MAX_BYTELEN.\n" }, { "commit": "923de654c8d251d6714a6f9da2e93c236e935042", "tree": "473cc25308810340efb82724101bd428af352958", "parents": [ "e8eb8340c14f53194786b766992f61cc0abf7a8e" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "message": "[bgpd] Fix warnings: hash callbacks should match hash API declarations\n\n2007-04-22 Sebastien Tandel \u003csebastien@tandel.be\u003e\n\n\t* bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)\n\t conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with\n\t void * arguments as defined by the API.\n\t* bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.\n\t Defines _hash_[alloc|key|cmp] with void * arguments as defined by\n\t the API.\n\t* bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,\n\t cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,\n\t transit_hash_cmp, attrhash_key_make, attrhash_cmp,\n\t bgp_attr_hash_alloc) conforms to quagga hash API. Defines\n\t _hash_[alloc|key|cmp] with void * arguments as defined by the API.\n" }, { "commit": "6e4ab12f1504caa95edc7702a82f118d0de15a0a", "tree": "50b6784229f92d404e5d6509848c135395743f2f", "parents": [ "16d2e2410d6e8cf53fac05b956f3e7ee53bc7234" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:36:48 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Apr 10 19:36:48 2007 +0000" }, "message": "[bgpd] Bug #354: Take care to keep reads of MP_(UN)REACH_NLRI in bounds\n\n2007-04-08 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and\n\t MP_UNREACH_NLRI does not take sufficient care to ensure reads\n\t from stream buffer stay in-bounds. Hence bgpd may attempt to read\n\t beyond end of stream, if given a crafted packet. As it uses the\n\t stream access methods to do so, this will typically result in\n\t assert() being hit in stream.c. Where code is compiled without\n\t assert() enabled, result is unknown.\n\t (struct message attr_str) should be static.\n\t (bgp_mp_reach_parse) Carefully check length remaining in stream\n\t against amount desired to read from stream, prior to each read,\n\t particularly where lengths are conditional on data obtained from\n\t stream - using STREAM_READABLE.\n\t Remove code to parse SNPA-number, it\u0027s a defunct field and changed\n\t to a fixed size in latest BGP MP update RFC - log warning if\n\t SNPA-number is not 0.\n\t (bgp_mp_unreach_parse) Check withdraw_length carefully against\n\t STREAM_READABLE.\n\t (bgp_attr_parse) If attribute-parser function returns error, log\n\t warning.\n\t Log attribute type on mismatch.\n" }, { "commit": "34c3f81b542c7f91fa04a43f7d0a8a4482f22d4d", "tree": "58f05fdafbc1c2036b9ccdf9de01d77f503e510e", "parents": [ "5fc60519ede0d34688832e353c35bf1832a4330d" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:25:37 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 12 23:25:37 2006 +0000" }, "message": "[bgpd] Remove dead code in ORIGINATOR_ID packet forming code\n\n2006-05-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity\n\t CID #1\n" }, { "commit": "a3b6ea56a0add7d0972a66d96e1fbcf5461eecdb", "tree": "a7bb8a005ab41ce30c43dd0fc2fab487c0e5f613", "parents": [ "5f03f141eced8bad4971fcc6ec7d7a538c227d8c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 07:52:12 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 07:52:12 2006 +0000" }, "message": "[bgpd] bug #210: Enable crucial VPNv4 code which was disabled\n\n2006-05-04 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) VPNv4 fixes. Certain VPNv4 code was not enabled.\n\t See bug #210.\n\t* bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be\n\t u_char really.\n\t* bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some\n\t VPNv4 code which inexplicably was ifdef\u0027d out. comments from\n\t a tester on IRC suggest this fixes bug #210.\n" }, { "commit": "cbdfbaa51b600c7b217968b99a9b5a8fbf04bec4", "tree": "bb8ce6ac1da775d34796315b1c5ac82e477bbd13", "parents": [ "478ccfd61bd61fd6925c84811c2c0e893a38a38b" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:20:48 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:20:48 2006 +0000" }, "message": "[bgpd] rearrange some structs for less padding, stats for table/attrs.\n\n2006-03-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_attr.h: (struct attr) rearrange fields to avoid\n\t wasted padding between them as much as possible.\n\t (attr_count,attr_unknown_count) export new functions to\n\t return number of counts of cached attributes.\n\t* bgp_attr.c: (attr_count,attr_unknown_count) new functions to\n\t return number of counts of cached attributes.\n\t* bgp_route.h: (struct bgp_info) rearrange fields to avoid\n\t wasted padding.\n\t* bgp_table.h: (struct bgp_table) Add a count field, of number\n\t of nodes in the table.\n\t (struct bgp_node) rearrange fields to avoid\n\t wasted padding between them, though I don\u0027t think there\n\t was any in this case.\n\t* bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.\n\t (bgp_table_count) new function to access the table count.\n" }, { "commit": "e8e1946edf6ba87ef53832cdceccc39d7f0c3f26", "tree": "fcdaf92bf4129a8a58825bd21ae841a6b3b2bda8", "parents": [ "779adb0147cfff1a831b08853976342ad2110fcd" ], "author": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "message": "[compiler] miscellaneous trivial compiler warning fixes\n\n2006-01-19 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n * (general) various miscellaneous compiler warning fixes.\n Remove redundant break statements from switch clauses\n which return.\n return from main, not exit, cause it annoys SOS.\n Remove stray semi-colons which cause empty-statement\n warnings.\n\t* zebra/main.c: (sighup) remove private declaration of external\n\t function.\n" }, { "commit": "fe69a505f7be4357bf8523e3bbdced9c95590f3a", "tree": "6d2450016eb19f30b153b2439d06ade68d1b8f12", "parents": [ "1f8ae70b7b86d132b95a18f0c824deb248987afc" ], "author": { "name": "paul", "email": "paul", "time": "Sat Sep 10 16:55:02 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Sep 10 16:55:02 2005 +0000" }, "message": "2005-09-10 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Makefile.am: bgpd shouldn\u0027t list libgp\u0027s sources as its own.\n\t Use LDADD.\n\t* bgp_aspath.h:\n\t (struct assegment) New struct, abstract representation of a\n\t list of AS_PATH segments and the contained ASNs.\n\t (struct aspath) Remove the raw-data related\n\t fields, reference the abstract struct assegment instead.\n\t Remove several other computed fields, it\u0027s just a\n\t headache to maintain them and they\u0027re cheap to compute from\n\t struct assegment.\n\t (aspath_parse) parse a stream, not a pointer to raw data.\n\t (aspath_count_{hops,confeds,size}) helpers to access\n\t information formerly directly contained in struct aspath.\n\t (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants\n\t to be able to output hex representation of raw data.\n\t* bgp_aspath.c: (general) partial-rewrite. Store aspath data\n\t as an abstract singly-linked list of abstract segments,\n rather than storing the raw data, and parsing it each and\n\t every time. Remove several count/size fields which are cheap\n\t to compute from the abstract segment structure.\n\t (global) Include stream.h, needed for aspath_parse, and\n\t others. Couple of helper macros added.\n\t (struct assegment_header) Just the header, and only the\n\t header.\n\t (assegment_data_{new,free}) convenience functions for\n\t AS_SEG_DATA allocation, the dynamic, per-segment array of\n\t ASNs.\n\t (assegment_{new,free,free_all,dup,dup_all}) convenience\n\t functions for creating struct assegments. The _all forms will\n\t follow the entire chain of segments from the given segment.\n\t (assegment_prepend_asns) new function, prepend an ASN N times\n\t to segment.\n \t (assegment_append_asns) Append a list (array) of ASNs to\n\t segment.\n\t (int_cmp) convenience function for the aspath hash.\n\t (assegment_normalise) new function. Normalise the given\n\t segment chain to meet expectations of Quagga, and to\n\t eliminate differing raw representations of the same paths.\n\t Merge \u0027runs\u0027 of SEQUENCEs into one segment as our internal\n\t segment is not limited by the protocol AS_PATH segment\n\t length. Sort ASNs in SETs.\n\t (aspath_new) Take void argument to quell warnings. Use the\n\t assegment convenience functions.\n\t (assegment_count_{asns,confeds,hops}) new functions to\n\t compute at runtime values previously held in struct aspath.\n\t (aspath_size) ditto.\n\t (aspath_make_str_count) rewritten to stringify new\n\t representation, and to be slightly easier to understand\n\t hopefully.\n\t (aspath_str_update) convenience function, update the aspath\n\t str. Should investigate removing maintained string from\n\t struct aspath, just run-time compute it, as per other fields.\n\t It\u0027s just a maintenance headache, would save noticeable\n\t amount of RAM with possibly not much extra run-time cost.\n\t (aspath_dup) use the assegment dup functions.\n\t (aspath_hash_alloc) Take void * argument to satisfy gcc. Use\n\t the proper helper functions to dup data.\n\t (assegments_parse) new function. parse raw AS_PATH data into\n\t struct assegments. Normalise and return the head of the list.\n\t (aspath_parse) Parse a stream, not pointer to raw data and\n\t use assegments_parse to do it.\n\t (assegment_data_put) Write out a single segment data in protocol\n\t form to stream.\n\t (assegment_header_put) ditto but for segment header.\n\t (aspath_put) new function. As per previous but for an entire\n\t struct aspath.\n\t (aspath_snmp_pathseg) wrapper around aspath_put for\n\t bgp_snmp.c. Uses a static buffer sadly.\n\t (aspath_aggregate_as_set_add) rewritten to use assegments.\n\t (aspath_aggregate) ditto\n\t (aspath_{firstas,loop,private_as}_check) ditto\n\t (aspath_{merge,prepend,add_one_as}) ditto\n\t (aspath_cmp_left{_confed}) ditto\n\t (aspath_delete_confed_seq) ditto, plus fixed to properly\n\t delete all leading confed segments.\n\t (aspath_as_add) Just use assegment_append_asns.\n\t (aspath_segment_add) updated to use assegments.\n\t (enum as_token) Add values for confeds\n\t (aspath_gettoken) Add support for confeds\n\t (aspath_str2aspath) ditto\n\t (aspath_key_make) updated to use as_segments. Also, add\n\t segment type into the hash value as appropriate.\n\t (aspath_cmp) updated to use as_segments.\n\t (aspath_print) don\u0027t segfault on NULL argument.\n\t* bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream\n\t now. No need for manual forwarding of stream.\n\t (bgp_packet_attribute) empty aspath is now denoted by NULL\n\t segment field, length is gone.\n\t Use aspath_size() to determine size.\n\t (bgp_attr_init) Fix declaration, explicitely specify void\n\t arg.\n\t (bgp_dump_routes_attr) Use aspath_size() to determine size.\n\t* bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.\n\t (bgp_rib_withdraw) remove unused variable. Use\n\t aspath_count_hops.\n\t* bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use\n\t aspath_snmp_pathseg to get the representation.\n" }, { "commit": "94f2b3923e9663d0355a829f22e4e31cf68ee7b8", "tree": "59c0291a76b1c97fbb089abb479307f19cdfd4c1", "parents": [ "7cad40007b9714dba65065916ea68577f9d3d6dd" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) The great bgpd extern and static\u0027ification.\n\t* bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code\n\t (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison\n\t warnings.\n\t* bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these\n\t used by various files which had their own private declarations,\n\t in the case of mplsvpn - incorrect.\n" }, { "commit": "9985f83ce7102f64b15f744b60320f8d14a8a5ff", "tree": "344629bdc2b4a7d53b8d7ca1705c9be2ca282d18", "parents": [ "083ee9d9cdbf72a452b9af96e62d0625ea712cd9" ], "author": { "name": "paul", "email": "paul", "time": "Wed Feb 09 15:51:56 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Feb 09 15:51:56 2005 +0000" }, "message": "2005-02-09 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) Update code to match stream.h changes.\n\t stream_get_putp effectively replaced with stream_get_endp.\n\t stream_forward renamed to stream_forward_getp.\n\t stream_forward_endp introduced to replace some previous\n\t setting/manual twiddling of putp by daemons.\n\t* lib/stream.h: Remove putp. Update reference to putp with endp.\n\t Add stream_forward_endp, which daemons were doing manually.\n\t Rename stream_forward to stream_forward_getp.\n\t lib/stream.c: Remove/update references to putp.\n\t introduce stream_forward_endp.\n" }, { "commit": "3d515fd9af9f126667a9c2da9c2f40c4c37c28df", "tree": "c107224556ed7678d7a5afc42c19742948cda477", "parents": [ "0a486e5fcb1b8dac7d8b4cf6ed93e82b8b72fed6" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 21:30:04 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 21:30:04 2005 +0000" }, "message": "\t* bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old\n\t draft - ie. \"neighbor version 4-\" commands. Preserve dummy \"neighbor\n\t version\" command as deprecated.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "f418446bb767d79438e2df689c5bf9563c54b317", "tree": "a1c7322c8b54e46a09bf2f402537277fff59c1c3", "parents": [ "6a52d0d155fc8b892e30cdb5e3fbe4c2779bd4cd" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:13:16 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:13:16 2005 +0000" }, "message": " * bgp_nexthop.c: Improve debug.\n * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()\n function.\n * bgp_packet.c: MP AFI_IP update and withdraw parsing.\n * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()\n is better place to log about peer status change than bgp_event().\n Log in bgp_connect_success().\n * bgp_vty.c: Fix typo in comment.\n * bgp_attr.c: Better log about unknown attribute.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "c29fdba771810c70d78d87127d3a479e0f72b60e", "tree": "75361d6969db5f8796596ccb7dbcae1d6769523e", "parents": [ "d1db06faa82a331fb6729064290ecbc61a969b88" ], "author": { "name": "gdt", "email": "gdt", "time": "Thu Dec 09 14:46:46 2004 +0000" }, "committer": { "name": "gdt", "email": "gdt", "time": "Thu Dec 09 14:46:46 2004 +0000" }, "message": "Add comments with warnings obtained on NetBSD/i386. Both are due to\nsize_t being used for streams. Perhaps cast to unsigned long before\nprintf? Surely that\u0027s big enough even if size_t could be larger in\ntheory.\n\n(no changelog, since only comment changes)\n" }, { "commit": "557865c28e34e9172477e9fab025e7888f62dad7", "tree": "151705cd67bda4e7f838856abbe34c96acaf5376", "parents": [ "c610681284be58ec2e39867379bdf2ca3047f464" ], "author": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 19:59:11 2004 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Wed Dec 08 19:59:11 2004 +0000" }, "message": "2004-12-08 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* *.c: Change level of debug messages to LOG_DEBUG.\n" }, { "commit": "a2b1ecd29f8bd4b01d5287ff862e156b2ffc30b3", "tree": "6c4947a0e49537be984ca482b5b4f32b3763d2bc", "parents": [ "64511f394a90602a31cbe1660be426c16439322c" ], "author": { "name": "paul", "email": "paul", "time": "Sun Oct 31 18:58:09 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sun Oct 31 18:58:09 2004 +0000" }, "message": "2004-10-31 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* {bgpd,bgp_attr}.c: size_t printf format should be ld.\n" }, { "commit": "fee0f4c629412f422fc9a857e097ef335c2c576c", "tree": "14703e303ea2cecaee7728d9ee27075b0590a679", "parents": [ "0e82d0e1204e45ecce773a7e19f7d64140f7a66a" ], "author": { "name": "paul", "email": "paul", "time": "Mon Sep 13 05:12:46 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Sep 13 05:12:46 2004 +0000" }, "message": "2004-09-13 Jose Luis Rubio \u003cjrubio@dit.upm.es\u003e\n (at Technical University of Madrid as part of Euro6ix Project)\n\n Enhanced Route Server functionality and Route-Maps:\n\n * bgpd/bgpd.h: Modified \u0027struct peer\u0027 and \u0027struct bgp_filter\u0027 to\n support rs-clients. A \u0027struct bgp_table *rib\u0027 has been added to the\n first (to mantain a separated RIB for each rs-client) and two new\n route-maps have been added to the last (for import/export policies).\n Added the following #defines: RMAP_{IN|OUT|IMPORT|EXPORT|MAX},\n PEER_RMAP_TYPE_{IMPORT|EXPORT} and BGP_CLEAR_SOFT_RSCLIENT.\n\n * bgpd/bgpd.c: Modified the functions that create/delete/etc peers in\n order to consider the new fields included in \u0027struct peer\u0027 for\n supporting rs-clients, i.e. the import/export route-maps and the\n \u0027struct bgp_table\u0027.\n\n * bgpd/bgp_route.{ch}: Modified several functions related with\n receiving/sending announces in order to support the new Route Server\n capabilities.\n Function \u0027bgp_process\u0027 has been reorganized, creating an auxiliar\n function for best path selection (\u0027bgp_best_selection\u0027).\n Modified \u0027bgp_show\u0027 and \u0027bgp_show_route\u0027 for displaying information\n about any RIB (and not only the main bgp RIB).\n Added commands for displaying information about RS-clients RIBs:\n \u0027show bgp rsclient (A.B.C.D|X:X::X:X)\u0027, \u0027show bgp rsclient\n (A.B.C.D|X:X::X:X) X:X::X:X/M\u0027, etc\n\n * bgpd/bgp_table.{ch}: The structure \u0027struct bgp_table\u0027 now has two\n new fields: type (which can take the values BGP_TABLE_{MAIN|RSCLIENT})\n and \u0027void *owner\u0027 which points to \u0027struct bgp\u0027 or \u0027struct peer\u0027 which\n owns the table.\n When creating a new bgp_table by default \u0027type\u003dBGP_TABLE_MAIN\u0027 is set.\n\n * bgpd/bgp_vty.c: The commands \u0027neighbor ... route-server-client\u0027 and\n \u0027no neighbor ... route-server-client\u0027 now not only set/unset the flag\n PEER_FLAG_RSERVER_CLIENT, but they create/destroy the \u0027struct\n bgp_table\u0027 of the peer. Special actions are taken for peer_groups.\n Command \u0027neighbor ... route-map WORD (in|out)\u0027 now also supports two\n new kinds of route-map: \u0027import\u0027 and \u0027export\u0027.\n Added commands \u0027clear bgp * rsclient\u0027, etc. These commands allow a new\n kind of soft_reconfig which affects only the RIB of the specified\n RS-client.\n Added commands \u0027show bgp rsclient summary\u0027, etc which display a\n summary of the rs-clients configured for the corresponding address\n family.\n\n * bgpd/bgp_routemap.c: A new match statement is available,\n \u0027match peer (A.B.C.D|X:X::X:X)\u0027. This statement can only be used in\n import/export route-maps, and it matches when the peer who announces\n (when used in an import route-map) or is going to receive (when used\n in an export route-map) the route is the same than the one specified\n in the statement.\n For peer-groups the statement matches if the specified peer is member\n of the peer-group.\n A special version of the command, \u0027match peer local\u0027, matches with\n routes originated by the Route Server (defined with \u0027network ...\u0027,\n redistributed routes and default-originate).\n\n * lib/routemap.{ch}: Added a new clause \u0027call NAME\u0027 for use in\n route-maps. It jumps into the specified route-map and when it returns\n the first route-map ends if the called RM returns DENY_MATCH, or\n continues in other case.\n" }, { "commit": "5228ad27e2f3abe0ebb69f66607aedc048b94a13", "tree": "a65817a03150dbfeb56a1eaceab526f31be1cc1d", "parents": [ "c2bfbcc38428b53e856617e1da8bbe9f8d2ee2fa" ], "author": { "name": "paul", "email": "paul", "time": "Fri Jun 04 17:58:18 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Jun 04 17:58:18 2004 +0000" }, "message": "2004-06-04 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * type mismatch fixes\n" }, { "commit": "4372df71e191fcf6a6f9616fad80d11cd131c82d", "tree": "dd01502f61566bb57fd75e1c4a388181140f2f1d", "parents": [ "e0701b7955b883c5437269a382e1afc76ee71e5c" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu May 20 10:20:02 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu May 20 10:20:02 2004 +0000" }, "message": "Merge bgpd changeset 1184 from Zebra repository by Rivo Nurges.\n" }, { "commit": "a384592fda7cec702f8d3201f51b636d6fe1be9b", "tree": "20b24811f3f89351fc92b41fa0293c7d77963088", "parents": [ "9834cd0f43bc45f04303b0f742faacf3bc5eac45" ], "author": { "name": "paul", "email": "paul", "time": "Sat Oct 18 01:30:50 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Oct 18 01:30:50 2003 +0000" }, "message": "2003-10-18 Lorenzo Colitti \u003clorenzo@ripe.net\u003e\n\n2003-10-18 Lorenzo Colitti \u003clorenzo@ripe.net\u003e\n\n * bgpd/bgp_attr.c: (bgp_dump_routes_attr) Dont dump IPv4 nexthop\n\t for IP. Dump MP_NLRI attr with IPv6 next-hop for AF_INET6 address\n family prefixes. Accept prefix as argument.\n * bgpd/bgp_attr.c: modify bgp_dump_routes_attr declaration.\n * bgpd/bgp_dump.c: (bgp_dump_routes_entry) Modify calls to\n bgp_dump_routes_attr.\n (bgp_dump_common) Go by the family of the peering socket, not\n configured address family when dumping peering information.\n Add HAVE_IPV6 conditionals, eg missing from previous bgp interval\n patch.\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }