)]}' { "log": [ { "commit": "835315bfb49bff2b2fb354f2075c6d6693c2a151", "tree": "b9cc49ef796bcb1e3836ff670da930765815acfa", "parents": [ "3ecab4c8549574d09f8d8366098939a8ad3da6c4" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Jan 18 12:28:30 2012 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Feb 28 18:35:45 2012 +0000" }, "message": "bgpd: Move up flag-check calls, parcel up attr-parser args, and other cleanups\n\n* bgp_attr.h: (struct bgp_attr_parser_args) Attribute parsing context,\n containing common arguments.\n* bgp_attr.c: (general) Move the bgp_attr_flag_invalid flag-check calls up,\n out of each individual attr parser function, to be done once in attr_parse.\n\n Similarly move the calculation of the \u0027total\u0027 attribute length field up\n to attr_parse.\n\n Bundle together common arguments to attr-parsing functions and helpers\n into (struct bgp_attr_parser_args), so it can be passed by reference down\n the stack \u0026 also de-clutter the argument lists \u0026 make it easier to\n add/modify the context for attr-parsing - add local const aliases to avoid\n modifying body of code too much. This also should help avoid cut \u0026 paste\n errors, where calls to helpers with hard-coded attribute types are pasted\n to other functions but the code isn\u0027t changed.\n\n (bgp_attr_flags_diagnose) as above.\n (bgp_attr_flag_invalid) as above.\n (bgp_attr_{origin,aspath,as4_path,nexthop,med,local_pref,atomic}) as above.\n (bgp_attr_{aggregator,as4_aggregator,community,originator_id}) as above\n (bgp_attr_{cluster_list,ext_communities},bgp_mp_{un,}reach_parse) as above\n (bgp_attr_unknown) as above.\n\n (bgp_attr_malformed) as above. Also, startp and length have to be\n special-cased, because whether or not to send attribute data depends\n on the particular error - a separate length argument, distinct from\n args-\u003elength, indicates whether or not the attribute data should be sent\n in the NOTIFY.\n (bgp_attr_aspath_check) Call to bgp_attr_malformed is wrong here, there is\n no attribute parsing context - e.g. the \u0027flag\u0027 argument is unlikely to be\n right, remove it. Explicitly handle the error instead.\n (bgp_attr_munge_as4_attrs) Flag argument is pointless.\n\n As the comment notes, the check here is pointless as AS_PATH presence\n already checked elsewhere.\n\n (bgp_attr_parse) Do bgp_attr_flag_invalid call here.\n Use (struct bgp_attr_parser_args) for args to attr parser functions.\n Remove out-of-context \u0027flag\u0027 argument to as4 checking functions.\n" }, { "commit": "565b828dc00cafd477dd69ce15f0f551ece67710", "tree": "e1d5c6c38f89b6d022339df14c9b5224de7c0ca9", "parents": [ "f8627ff1ef7642c8ee4758b1f046ef0d166dfbec" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 10 21:08:33 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Oct 17 19:07:02 2011 +0400" }, "message": "bgpd: add flag checks for MP_(UN)REACH_NLRI\n\n* bgp_attr.[ch]\n * bgp_mp_reach_parse(): add extra arguments and a uniform flag\n check block\n * bgp_mp_unreach_parse(): idem\n * bgp_attr_parse(): provide extra arguments\n* bgp_mp_attr_test.c\n * parse_test(): justify respective calls\n" }, { "commit": "b881c7074bb698aeb1b099175b325734fc6e44d2", "tree": "70b4816a083166bbf00c1f85f19a67df0c0a5948", "parents": [ "c112af27ed8f158ecece0d73ce2016c166076c00" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 23 16:35:42 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Implement revised error handling for partial optional/trans. attributes\n\n* BGP error handling generally boils down to \"reset session\". This was fine\n when all BGP speakers pretty much understood all BGP messages. However\n the increasing deployment of new attribute types has shown this approach\n to cause problems, in particular where a new attribute type is \"tunneled\"\n over some speakers which do not understand it, and then arrives at a speaker\n which does but considers it malformed (e.g. corruption along the way, or\n because of early implementation bugs/interop issues).\n\n To mitigate this drafts before the IDR (likely to be adopted) propose to\n treat errors in partial (i.e. not understood by neighbour), optional\n transitive attributes, when received from eBGP peers, as withdrawing only\n the NLRIs in the affected UPDATE, rather than causing the entire session\n to be reset. See:\n\n http://tools.ietf.org/html/draft-scudder-idr-optional-transitive\n\n* bgp_aspath.c: (assegments_parse) Replace the \"NULL means valid, 0-length\n OR an error\" return value with an error code - instead taking\n pointer to result structure as arg.\n (aspath_parse) adjust to suit previous change, but here NULL really\n does mean error in the external interface.\n* bgp_attr.h (bgp_attr_parse) use an explictly typed and enumerated\n value to indicate return result.\n (bgp_attr_unintern_sub) cleans up just the members of an attr, but not the\n attr itself, for benefit of those who use a stack-local attr.\n* bgp_attr.c: (bgp_attr_unintern_sub) split out from bgp_attr_unintern\n (bgp_attr_unintern) as previous.\n (bgp_attr_malformed) helper function to centralise decisions on how to\n handle errors in attributes.\n (bgp_attr_{aspathlimit,origin,etc..}) Use bgp_attr_malformed.\n (bgp_attr_aspathlimit) Subcode for error specifc to this attr should be\n BGP_NOTIFY_UPDATE_OPT_ATTR_ERR.\n (bgp_attr_as4_path) be more rigorous about checks, ala bgp_attr_as_path.\n (bgp_attr_parse) Adjust to deal with the additional error level that\n bgp_attr_ parsers can raise, and also similarly return appropriate\n error back up to (bgp_update_receive). Try to avoid leaking as4_path.\n* bgp_packet.c: (bgp_update_receive) Adjust to deal with BGP_ATTR_PARSE_WITHDRAW\n error level from bgp_attr_parse, which should lead to a withdraw, by\n making the attribute parameter in call to (bgp_nlri_parse) conditional\n on the error, so the update case morphs also into a withdraw.\n Use bgp_attr_unintern_sub from above, instead of doing this itself.\n Fix error case returns which were not calling bgp_attr_unintern_sub\n and probably leaking memory.\n* tests/aspath_test.c: Fix to work for null return with bad segments\n" }, { "commit": "f6f434b2822c453f898552537180a812538bd19e", "tree": "81f5de3c1eeb6679635e7363396c08b807b04ad9", "parents": [ "50ef565e4e689ba653b9709be4d28a01f6cca885" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Nov 23 21:28:03 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Try fix extcommunity resource allocation probs, particularly with \u0027set extcom..\u0027\n\n* Extended communities has some kind of resource allocation problem which\n causes a double-free if the \u0027set extcommunity ...\u0027 command is used.\n Try fix by properly interning extcommunities.\n\n Also, more generally, make unintern functions take a double pointer\n so they can NULL out callers references - a usefully defensive programming\n pattern for functions which make refs invalid.\n\n Sadly, this patch doesn\u0027t fix the problem entirely - crashes still\n occur on session clear.\n\n* bgp_ecommunity.h: (ecommunity_{free,unintern}) take double pointer\n args.\n* bgp_community.h: (community_unintern) ditto\n* bgp_attr.h: (bgp_attr_intern) ditto\n* bgp_aspath.h: (bgp_aspath.h) ditto\n* (general) update all callers of above\n* bgp_routemap.c: (route_set_ecommunity_{rt,soo}) intern the new extcom added\n to the attr, and unintern any old one.\n (route_set_ecommunity_{rt,soo}_compile) intern the extcom to be used\n for the route-map set.\n (route_set_ecommunity_*_free) unintern to match, instead of free\n (route_set_ecommunity_soo) Do as _rt does and don\u0027t just leak\n any pre-existing community, add to it (is additive right though?)\n" }, { "commit": "c8f3fe3063cb9ff193b13011cfbda3e605395340", "tree": "42713ac0369f0ef372c657ded091b00dbe6a019b", "parents": [ "0c46638122f10019a12ae9668aec91691cf2e017" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Dec 05 20:28:02 2010 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 13:51:14 2011 +0000" }, "message": "bgpd: Remove AS Path limit/TTL functionality\n\n* draft-ietf-idr-as-pathlimit doesn\u0027t seem to have gone anywhere, and its\n author does not think it will make progress in IDR. Remove all support\n introduced for it, but leave stubs for the commands to avoid breaking\n any configurations.\n\n Basically reverts cecab5e9725792e60a5e4b473e238a14cd85815d.\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "ffe11cfb0a808ae514193438616dfabc512b4cf6", "tree": "94452dba2c1a49d6e6a0782c6513acb36823cefc", "parents": [ "9fd4958a4eef88c536e4a5aeefce302e10ee8ee6" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Thu Aug 14 16:25:25 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:58 2008 +0100" }, "message": "[lib] hash compare function arguments ought to be const qualified\n\n2008-08-14 Stephen Hemminger \u003cstephen.hemminger@vyatta.com\u003e\n\n\t* lib/hash.h: (struct hash) Hash comparator callback really\n\t ought to treat storage behind arguments as constant - a compare\n\t function with side-effects would be evil.\n\t* */*.c: Adjust comparator functions similarly, thus fixing at least\n\t a few compiler warnings about const qualifier being dropped.\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "032928091c558d3b0940be079049009f47652711", "tree": "81bd1c2ddfbf41f380bfd38370e42d3c646f5e08", "parents": [ "343f720b345dd377bdf4f53e3b02e0c2898f3f0b" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:37:10 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Jun 07 20:37:10 2008 +0000" }, "message": "[bgpd] minor changes to bgp_mp_reach_parse\n\n2008-06-07 Paul Jakma \u003cpaul@jakma.org\u003e\n\n\t* bgp_attr.{c,h}: (bgp_mp_{un,}reach_parse) export, for unit tests.\n\t* bgp_attr.c: (bgp_mp_reach_parse) Add logging. Tighten length test\n\t to bounds check against the attribute length rather than the\n\t stream length..\n" }, { "commit": "370b64a2ad38e43b4bed028960481bbf4192becd", "tree": "ebecb7f934a7058d582e52b5c64a21eb676ec994", "parents": [ "a7f93f3e060fdb2dc7bf5ff4ed4563d4b689bc6c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Dec 22 16:49:52 2007 +0000" }, "message": "[bgpd] Fix number of DoS security issues, restricted to configured peers.\n\n2007-12-22 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Fix series of vulnerabilities reported by \"Mu Security\n\t Research Team\", where bgpd can be made to crash by sending\n\t malformed packets - requires that bgpd be configured with a\n\t session to the peer.\n\t* bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only\n\t set the attribute flag indicating AS4_PATH if we actually managed\n\t to parse one.\n\t (bgp_attr_munge_as4_attrs) Assert was too general, it is possible\n\t to receive AS4_AGGREGATOR before AGGREGATOR.\n\t (bgp_attr_parse) Check that we have actually received the extra\n\t byte of header for Extended-Length attributes.\n\t* bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.\n\t* bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,\n\t incorrect -2 left in place from a development version of as4-path\n\t patch.\n\t* bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter\n\t needs to be properly sanity checked.\n\t* tests/bgp_capability_test.c: Test for empty capabilities.\n" }, { "commit": "41367172d812354c05b11818346f0d49c2245aef", "tree": "eb8f83ec0e93cb5a1d8470afd5c79ce55bc853da", "parents": [ "6d58272b4cf96f0daa846210dd2104877900f921" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:24:51 2007 +0000" }, "message": "[bgpd] Add support for AS_PATHLIMIT / draft-ietf-idr-as-pathlimit\n\n2007-07-31 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Support for draft-ietf-idr-as-pathlimit-03.\n\t* bgp_attr.h: (struct attr) Add pathlimit struct\n bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.\n (attrhash_key_make) tally pathlimit too\n (attrhash_cmp) cmp pathlimit attr\n (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.\n (bgp_attr_parse) ditto\n (bgp_packet_attribute) Write out AS_PATHLIMIT when set\n (bgp_dump_routes_attr) ditto\n * bgp_route.h: (struct bgp_static) Add TTL field\n * bgp_route.c: (bgp_announce_check) Drop paths that are over\n their hop-count TTL before sending via EBGP.\n Mangle ASN in pathlimit for confeds/private as best we can.\n (bgp_static_update_{rsclient,main}) Add any configure pathlimit\n information.\n (bgp_pathlimit_update_parents) New, update atomic-aggr setting for\n parents of an aspathlimit\u0027ed static.\n (bgp_static_set) Add TTL argument, for all the \u0027bgp network\u0027\n commands.\n Call previous for TTL changed statics.\n (bgp_static_unset) Call pathlimit_update_parents.\n (various bgp network commands) Add \u0027pathlimit \u003c0-255\u003e\u0027 qualifier\n to all the various forms, bar route-map - which can set ttl\n itself.\n * bgp_routemap.c: (general) Add support for \u0027set pathlimit ttl\u0027 and\n \u0027match pathlimit as\u0027.\n * doc/bgpd.texi: Document \u0027network ... pathlimit \u003cttl\u003e\u0027\n" }, { "commit": "fb982c25aa771b7c7425a3c3cce0a2cda0a715de", "tree": "74aa4dc86b04365d90a1030682796421b0eff011", "parents": [ "5921ef9aae3b5d6ff8663298f649fb9d76594acd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "message": "[bgpd] Trim memory usage of BGP routes\n\n2007-05-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: (struct info) Move less frequently used\n\t fields to a lazily allocated struct info_extra.\n\t Export bgp_info_extra_get\n\t* bgp_route.c: (bgp_info_extra_new) allocate extra\n\t (bgp_info_extra_free) Free damp info and the info_extra.\n\t (bgp_info_extra_get) Retrieve the info_extra of a struct\n\t info, allocating as required.\n\t (generally) adjust to use info-\u003eextra\n\t* bgp_damp.c: (generally) use bgp_info_extra_get to access\n\t dampinfo\n\t* bgp_attr.h: Move rarely allocated attributes from struct attr\n\t to a struct attr_extra, for a substantial saving in size of\n\t struct attr.\n\t* bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.\n\t (bgp_attr_extra_get) Get the attr_extra for a given struct\n\t attr, allocating it if needs be.\n\t (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.\n\t (generally) adjust to know about attr-\u003eextra.\n\t* bgp_debug.c: (bgp_dump_attr) ditto\n\t* bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.\n\t* bgp_nexthop.c: (generally) adjust to know about attr-\u003eextra\n\t and info-\u003eextra.\n\t* bgp_{packet,routemap,snmp,zebra}.c: ditto\n\t* lib/memtypes.c: Add MTYPE_ATTR_EXTRA and MTYPE_BGP_ROUTE_EXTRA\n" }, { "commit": "03e214c87bf4537576d2c7e9b2d812d1b0da2f56", "tree": "46f53f23bc77af0c8e6835853fbc355c3c342ddf", "parents": [ "923de654c8d251d6714a6f9da2e93c236e935042" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:31:07 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:31:07 2007 +0000" }, "message": "[bgpd] Use defines for default weight\n\n2007-04-22 Sebastien Tandel \u003csebastien@tandel.be\u003e\n\n\t* bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.\n\t* bgp_attr.c : (bgp_attr_default_intern) now uses\n\t bgp_attr_default_set instead of duplicating the same code.\n\t (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by\n\t IPV6_MAX_BYTELEN.\n" }, { "commit": "923de654c8d251d6714a6f9da2e93c236e935042", "tree": "473cc25308810340efb82724101bd428af352958", "parents": [ "e8eb8340c14f53194786b766992f61cc0abf7a8e" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 29 18:25:17 2007 +0000" }, "message": "[bgpd] Fix warnings: hash callbacks should match hash API declarations\n\n2007-04-22 Sebastien Tandel \u003csebastien@tandel.be\u003e\n\n\t* bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)\n\t conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with\n\t void * arguments as defined by the API.\n\t* bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.\n\t Defines _hash_[alloc|key|cmp] with void * arguments as defined by\n\t the API.\n\t* bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,\n\t cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,\n\t transit_hash_cmp, attrhash_key_make, attrhash_cmp,\n\t bgp_attr_hash_alloc) conforms to quagga hash API. Defines\n\t _hash_[alloc|key|cmp] with void * arguments as defined by the API.\n" }, { "commit": "a3b6ea56a0add7d0972a66d96e1fbcf5461eecdb", "tree": "a7bb8a005ab41ce30c43dd0fc2fab487c0e5f613", "parents": [ "5f03f141eced8bad4971fcc6ec7d7a538c227d8c" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 07:52:12 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu May 04 07:52:12 2006 +0000" }, "message": "[bgpd] bug #210: Enable crucial VPNv4 code which was disabled\n\n2006-05-04 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) VPNv4 fixes. Certain VPNv4 code was not enabled.\n\t See bug #210.\n\t* bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be\n\t u_char really.\n\t* bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some\n\t VPNv4 code which inexplicably was ifdef\u0027d out. comments from\n\t a tester on IRC suggest this fixes bug #210.\n" }, { "commit": "cbdfbaa51b600c7b217968b99a9b5a8fbf04bec4", "tree": "bb8ce6ac1da775d34796315b1c5ac82e477bbd13", "parents": [ "478ccfd61bd61fd6925c84811c2c0e893a38a38b" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:20:48 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 13:20:48 2006 +0000" }, "message": "[bgpd] rearrange some structs for less padding, stats for table/attrs.\n\n2006-03-12 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_attr.h: (struct attr) rearrange fields to avoid\n\t wasted padding between them as much as possible.\n\t (attr_count,attr_unknown_count) export new functions to\n\t return number of counts of cached attributes.\n\t* bgp_attr.c: (attr_count,attr_unknown_count) new functions to\n\t return number of counts of cached attributes.\n\t* bgp_route.h: (struct bgp_info) rearrange fields to avoid\n\t wasted padding.\n\t* bgp_table.h: (struct bgp_table) Add a count field, of number\n\t of nodes in the table.\n\t (struct bgp_node) rearrange fields to avoid\n\t wasted padding between them, though I don\u0027t think there\n\t was any in this case.\n\t* bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.\n\t (bgp_table_count) new function to access the table count.\n" }, { "commit": "94f2b3923e9663d0355a829f22e4e31cf68ee7b8", "tree": "59c0291a76b1c97fbb089abb479307f19cdfd4c1", "parents": [ "7cad40007b9714dba65065916ea68577f9d3d6dd" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) The great bgpd extern and static\u0027ification.\n\t* bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code\n\t (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison\n\t warnings.\n\t* bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these\n\t used by various files which had their own private declarations,\n\t in the case of mplsvpn - incorrect.\n" }, { "commit": "00d252cb5ff21ecc537ab40385316b41622a95e2", "tree": "c0132f4be53d8ae251ecb1dd8c39816f8734d08f", "parents": [ "269d74fdc39a612da8f627bf97628c68d25a16ab" ], "author": { "name": "paul", "email": "paul", "time": "Mon May 23 14:19:54 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon May 23 14:19:54 2005 +0000" }, "message": "2005-05-23 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* bgp_fsm.h: Add extern qualifier to exported functions\n\t* bgp_nexthop.c: add static to nexthop specific globals\n\t* *.h: Add guard defines\n" }, { "commit": "5228ad27e2f3abe0ebb69f66607aedc048b94a13", "tree": "a65817a03150dbfeb56a1eaceab526f31be1cc1d", "parents": [ "c2bfbcc38428b53e856617e1da8bbe9f8d2ee2fa" ], "author": { "name": "paul", "email": "paul", "time": "Fri Jun 04 17:58:18 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Jun 04 17:58:18 2004 +0000" }, "message": "2004-06-04 Paul Jakma \u003cpaul@dishone.st\u003e\n\n * type mismatch fixes\n" }, { "commit": "a384592fda7cec702f8d3201f51b636d6fe1be9b", "tree": "20b24811f3f89351fc92b41fa0293c7d77963088", "parents": [ "9834cd0f43bc45f04303b0f742faacf3bc5eac45" ], "author": { "name": "paul", "email": "paul", "time": "Sat Oct 18 01:30:50 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Oct 18 01:30:50 2003 +0000" }, "message": "2003-10-18 Lorenzo Colitti \u003clorenzo@ripe.net\u003e\n\n2003-10-18 Lorenzo Colitti \u003clorenzo@ripe.net\u003e\n\n * bgpd/bgp_attr.c: (bgp_dump_routes_attr) Dont dump IPv4 nexthop\n\t for IP. Dump MP_NLRI attr with IPv6 next-hop for AF_INET6 address\n family prefixes. Accept prefix as argument.\n * bgpd/bgp_attr.c: modify bgp_dump_routes_attr declaration.\n * bgpd/bgp_dump.c: (bgp_dump_routes_entry) Modify calls to\n bgp_dump_routes_attr.\n (bgp_dump_common) Go by the family of the peering socket, not\n configured address family when dumping peering information.\n Add HAVE_IPV6 conditionals, eg missing from previous bgp interval\n patch.\n" }, { "commit": "3b424979f54c6b128d1ee8a7c33d072d321f2f0c", "tree": "c3c684d2e1576610d3a0cedefa3bab23610c8d61", "parents": [ "7ddf1d6eaf5a339d13661469212ac33f77e808fc" ], "author": { "name": "paul", "email": "paul", "time": "Mon Oct 13 09:47:32 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Oct 13 09:47:32 2003 +0000" }, "message": "2003-10-13 Jay Fenlason \u003cfenlason@redhat.com\u003e\n\n\t* lib/zebra.h: define UINT32_MAX for those systems which do not\n\t provide it.\n\t* bgp_attr.h: define BGP_MED_MAX.\n\t* bgp_route.c: update defines/constants to BGP_MED_MAX.\n\t* bgp_routemap.c: ditto. clean up route_match_metric_compile\n\t slightly to avoid unneccesary XMALLOC.\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }