)]}' { "log": [ { "commit": "2b09e2117e676986a5574a52a1a6823727361388", "tree": "e57fcf544fb8ef510576d516f35dafdd800b9633", "parents": [ "b65c639a2ef9e07d93c8f9433c97b2270a65a6a0" ], "author": { "name": "Ivan Moskalyov", "email": "ether0@mail.ru", "time": "Thu Mar 11 17:14:35 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Mar 11 17:14:35 2010 +0300" }, "message": "doc: fixed spelling in bgpd.texi\n" }, { "commit": "b65c639a2ef9e07d93c8f9433c97b2270a65a6a0", "tree": "4ece5effcac2f883dae228391edec53210f52e28", "parents": [ "438589e31fe38943247f3011388b819346e473fe" ], "author": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Wed Mar 10 14:03:54 2010 -0500" }, "committer": { "name": "Greg Troxel", "email": "gdt@ir.bbn.com", "time": "Wed Mar 10 14:03:54 2010 -0500" }, "message": "build: Add QuaggaId to README.NetBSD\n" }, { "commit": "438589e31fe38943247f3011388b819346e473fe", "tree": "1b8ac0f7b60ffc2eacca91625bb4242a0bbbfced", "parents": [ "dca6c883ea6219460efbe3dadde4b8b9cb12c845" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Mar 09 13:53:20 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Mar 09 13:53:20 2010 +0300" }, "message": "release: 0.99.16\n\n* configure.ac: bump up version number\n" }, { "commit": "dca6c883ea6219460efbe3dadde4b8b9cb12c845", "tree": "71352e214bd59277a50a43779bb2cbafbace6cc3", "parents": [ "3f3dc2bd5f8cbde24cb581ed0aed0e372bfd556c" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Jan 27 12:38:16 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jan 27 12:38:16 2010 +0300" }, "message": "lib: undo the last PIE commit\n\nStephen:\nA recent change breaks build Quagga on Debian Lenny with amd64 (but not\ni386). Not sure whether this is cause by ld, gcc, or libtool; but\nwhatever it just won\u0027t work for a large number of users.\n\nMathias:\nI would guess it\u0027s a problem of libtool because it adds \"-fPIC -DPIC\" to\nthe compiler flags but doesn\u0027t remove -fPIE. That wouldn\u0027t be a problem\nif the compiler would ignore the -fPIE in favor to the latter -fPIC, but\nobviously it does not. [...] Those objects were actually compiled with\n-fPIC but also -fPIE which seems to confuse gcc.\n" }, { "commit": "3f3dc2bd5f8cbde24cb581ed0aed0e372bfd556c", "tree": "7754c556419e6315fed189a4d7a88f33a3558852", "parents": [ "65957886bfd0dd9d95360d8b015781fc82cc09be" ], "author": { "name": "Mathias Krause", "email": "Mathias.Krause@secunet.com", "time": "Wed Jan 20 17:39:13 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jan 20 17:39:13 2010 +0300" }, "message": "lib: fix PIE build flags\n\nBecause the final executables are built as position independent\nexecutables (PIE) -- when configure has detected compiler supported for\nPIE -- the objects in the library archive must be built in that way,\ntoo. Otherwise the runtime linker has to do unneccesary relocation for\neach start of the program. Even worse, the programs won\u0027t even be able\nto start on a (hardened) kernel that doesn\u0027t allow those relocations to\nhappen by preventing making the .text segment writable (PaX\u0027s MPROTECT\nfeature comes to mind). The attached patch fixes this issue by adding\nthe appropriate flags to the Makefile.am.\n" }, { "commit": "65957886bfd0dd9d95360d8b015781fc82cc09be", "tree": "71352e214bd59277a50a43779bb2cbafbace6cc3", "parents": [ "2cd754de60210748e61069fed2c9d4086d24c21e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Jan 15 16:22:10 2010 +0300" }, "message": "bgp: use monotonic clock for time of day\n\nBGP uses time() to get system time of day; but that value\nfluctuates with time adjustments from NTP. This can cause premature\nflapping of peer sessions and other failures.\n\nUse the system monotonic clock supported by Quagga thread library\nto avoid issue.\n\nSee: http://bugzilla.vyatta.com/show_bug.cgi?id\u003d4467\n\n* bgpd/bgp_fsm.c\n * bgp_uptime_reset(): dismiss function\n* bgpd/bgpd.c\n * bgp_clock(): new function\n* bgpd/bgp_damp.c\n * bgp_reuse_timer(): employ bgp_clock() instead of time(NULL)\n * bgp_damp_withdraw(): idem\n * bgp_damp_update(): idem\n * bgp_damp_scan(): idem\n * bgp_damp_info_vty(): idem\n * bgp_damp_reuse_time_vty(): idem\n* bgpd/bgp_fsm.c\n * bgp_routeadv_timer(): idem\n * bgp_stop(): idem\n * bgp_establish(): idem\n* bgpd/bgp_packet.c\n * bgp_update_receive(): idem\n* bgpd/bgp_route.c\n * bgp_update_rsclient(): idem\n * bgp_update_main(): idem\n * bgp_static_update_rsclient(): idem\n * bgp_static_update_main(): idem\n * bgp_static_update_vpnv4(): idem\n * bgp_aggregate_route(): idem\n * bgp_aggregate_add(): idem\n * bgp_redistribute_add(): idem\n* bgpd/bgp_snmp.c\n * bgpPeerTable(): idem\n * bgpTrapEstablished(): idem\n * bgpTrapBackwardTransition(): idem\n* bgpd/bgpd.c\n * peer_create(): idem\n * peer_uptime(): idem\n * bgp_master_init(): idem\n" }, { "commit": "2cd754de60210748e61069fed2c9d4086d24c21e", "tree": "1f9ef18fb413e0d786623eb857eea894a9900ff9", "parents": [ "efbbcaf1aea686d118019514dcde92b13c92b0fc" ], "author": { "name": "Paul Jakma", "email": "paul@jakma.org", "time": "Thu Jan 14 16:26:12 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jan 14 16:26:12 2010 +0300" }, "message": "ospfd: Fix debug messages that were masked by DISCARD_LSA\n\n* ospf_packet.c: (ospf_ls_upd) DISCARD_LSA continues, and so should be\nafter debug messages, not before them.\n" }, { "commit": "efbbcaf1aea686d118019514dcde92b13c92b0fc", "tree": "97965a22204c265ac061f40ea9e461e88c3cd2ea", "parents": [ "0917f7e7c5920b70295c44bd8aad537bc3ee8581" ], "author": { "name": "Paul Jakma", "email": "paul@jakma.org", "time": "Thu Jan 14 16:19:40 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Jan 14 16:19:40 2010 +0300" }, "message": "ospfd: remove unneeded memset from a very hot function\n\n* ospf_lsdb.c: (lsdb_prefix_set) memset is unneeded, as all fields are\ninitialised explicitly, and this function can be in the top-3 of a\nprofile when there are a lot of LSAs.\n" }, { "commit": "0917f7e7c5920b70295c44bd8aad537bc3ee8581", "tree": "d55fa58af8937c2373d532223cf9a7c35df95c64", "parents": [ "b6516829595ed4fc47af955de8bda9ef5be14ffd" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Wed Jan 13 20:10:56 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Jan 13 20:10:56 2010 +0300" }, "message": "lib: fix memory logging\n\n* lib/memory.h\n * mtype_zcalloc(): correct function prototype\n * XFREE(): make both definitions consistent in setting\n the pointer to NULL after freeing the memory\n\nThese changes will only have an effect if MEMORY_LOG is defined\n(it is not by default).\n" }, { "commit": "b6516829595ed4fc47af955de8bda9ef5be14ffd", "tree": "842806138758343d41598fded61943de51c4c363", "parents": [ "2d362d1099f346202cb628665ff4ae563b2594f5" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Mon Dec 21 18:50:43 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Dec 21 18:50:43 2009 +0300" }, "message": "zebra: change router-id selection algo\n\nThe router-id table looks like is supposed to be sorted in current\nquagga code, but the nodes are not added with the sorting\nfunction.\n\nThe sorting function is host byte order dependent.\nThe values need to converted before comparison.\n\nFixing this causes Zebra to choose the largest IP address\nas router-id, rather than the last address. This probably will\nsurprise some users. The other option would be to just remove the\ncomparison function and keep the existing LIFO behavior.\n\nLastly, simple subtraction works well for comparing.\n\n* zebra/router-id.c\n * router_id_add_address(): employ listnode_add_sort()\n * router_id_cmp(): employ ntohl(), then compare integers\n" }, { "commit": "2d362d1099f346202cb628665ff4ae563b2594f5", "tree": "5e8101d4ace5f4ef4e51c1cdc277c0f9652728d0", "parents": [ "da88ea82acd70adf3bab641b2300ee24319da422" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Mon Dec 21 12:54:58 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Dec 21 13:03:51 2009 +0300" }, "message": "lib: make some structures constant\n\n* isisd/isis_pdu.c\n * maskbit: this pre-initialized array is not modified\n* lib/prefix.c\n * maskbit: idem\n* lib/command.c\n * facility_map: idem\n * itoa64: idem\n * default_motd: make local var static\n * facility_name(): update local var accordingly\n * facility_match(): idem\n" }, { "commit": "da88ea82acd70adf3bab641b2300ee24319da422", "tree": "81151de47e55067c4b7d9cd718c0e6c8ab07aa50", "parents": [ "2c2397059d4d4177ed4636c08aa476a138425dc8" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 17 13:14:28 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 17 13:14:28 2009 +0300" }, "message": "bgpd: code cleanup\n\n* bgpd/bgp_aspath.c\n * ashash: only used in one file, make static\n * aspath_count_numas(): dead code, sayonara\n* bgpd/bgpd.c\n * peer_nsf_stop(): only used in one file, make static\n* bgpd/bgp_packet.h\n * bgp_capability_receive(): add missing prototype for a\n global function\n" }, { "commit": "2c2397059d4d4177ed4636c08aa476a138425dc8", "tree": "c32e11332baa9b1ff9efed4f8b363f9118bdc964", "parents": [ "e580216e1ba2db506d1942e382852d07973a5fad" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 19:16:05 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 19:16:05 2009 +0300" }, "message": "ripd: fix compiler warnings\n\n* ripd/rip_interface.c\n * rip_request_neighbor(): comment out, unused\n * rip_request_neighbor_all(): idem\n * rip_interface_up(): Cast flags otherwise compiler complains\n about %lld not matching uint64_t on 64 bit x86. Print in hex\n since flags are bit field.\n * rip_interface_add(): idem\n * rip_interface_delete(): idem\n* ripd/rip_zebra.c\n * rip_redistribute_set(): comment out, unused\n* ripd/ripd.h\n * rip_redistribute_check(): move prototype here so compiler\n can check function against prototype\n* ripd/ripd.c\n * rip_update_default_metric(): comment out, unused\n" }, { "commit": "e580216e1ba2db506d1942e382852d07973a5fad", "tree": "1932075db93d8989bcbd7b76c0603a00f5bb4647", "parents": [ "813f6a0064e76fdc8d509ddfbd4d3870d7027850" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 16:18:41 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 16:18:41 2009 +0300" }, "message": "ospf6d: remove dead code\n\n* ospf6d/ospf6_interface.c\n * loopind(): sayonara\n* ospf6d/ospf6_top.c\n * ospf6_delete(): comment out, it might be useful if real shutdown is\n added\n" }, { "commit": "813f6a0064e76fdc8d509ddfbd4d3870d7027850", "tree": "eed75fc5da5c0a4dd5dcd20bc8c7c2523b6fd32d", "parents": [ "5eb9d11bf6bbe99ce47f929a14ac03351f21fe27" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 16:13:09 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 16:13:09 2009 +0300" }, "message": "ospf6d: fix warnings from recent prefix bit commit\n\n* lib/prefix.h\n * prefix6_bit(): add IPv6 wrapper for prefix_bit()\n* ospf6d/ospf6_lsdb.c\n * ospf6_lsdb_type_router_head(): employ prefix6_bit()\n * ospf6_lsdb_type_head(): idem\n" }, { "commit": "5eb9d11bf6bbe99ce47f929a14ac03351f21fe27", "tree": "79e72d2cace42a33b7c742c10319808b7837a36b", "parents": [ "ab0f61552622084a13ede59adefc4c54b5513d7b" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 15:52:33 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 15:52:33 2009 +0300" }, "message": "ripngd: compiler warnings cleanup\n\n* ripngd/ripng_interface.c\n * ripng_check_max_mtu(): unused, sayonara\n * ripng_interface_down(): cast flag arguments to logging function\n * ripng_interface_add(): idem\n * ripng_interface_delete(): idem\n* ripngd/ripngd.c\n * ripng_recv_packet(): avoid aliasing warning dereferencing pointer\n" }, { "commit": "ab0f61552622084a13ede59adefc4c54b5513d7b", "tree": "d85ca70e55f064fd3a24072cf0f9a5fbbcdd5181", "parents": [ "9e4ca89c3678431560a8259c75f8b5874d83d351" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 14:22:44 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 14:22:44 2009 +0300" }, "message": "zebra: deal with irdp compile warnings\n\n* zebra/irdp.h\n * irdp_send_thread(): move prototype to common header file\n * irdp_advert_off(): idem\n * process_solicit(): idem\n * irdp_read_raw(): idem\n * send_packet(): idem\n* zebra/irdp_interface.c\n * inet_2a(): move function to where it is used\n * in_cksum(): lib/checksum.h already provides prototype\n * irdp_send_thread(): prototype moved away\n * inet_2a(): idem\n * irdp_advert_off(): idem\n * b1, b2, b3, b4: get rid of global buffers for inet_2a()\n * if_group(): add local buffer for inet_2a()\n * if_add_group(): idem\n * if_drop_group(): idem\n * irdp_config_write(): idem\n * Adv_new(): make static\n* zebra/irdp_main.c\n * irdp_read_raw(): prototype moved away\n * send_packet(): idem\n * in_cksum(): lib/checksum.h already provides prototype\n * inet_2a(): function moved to irdp_interface.c\n* zebra/irdp_packet.c\n * b1, b2, b3, b4: get rid of global buffers for inet_2a()\n * in_cksum(): lib/checksum.h already provides prototype\n * process_solicit(): prototype moved away\n * irdp_read_raw(): fix uninitialized variable\n" }, { "commit": "9e4ca89c3678431560a8259c75f8b5874d83d351", "tree": "178ca0de4c6fe5ecba90b51c5fb29c3e0b720cdb", "parents": [ "cc2dd9280c4456586080d1cf4537d26c02fa9a36" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 10 11:57:05 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 10 11:57:05 2009 +0300" }, "message": "bgpd: compile warnings cleanup\n\n* bgpd/bgp_fsm.c\n * bgp_clearing_completed(): only used in one file, can be static\n* bgpd/bgp_packet.c\n * afi2str(): sayonara\n * safi2str(): sayonara\n* bgpd/bgp_route.c\n * bgp_distance_reset(): sayonara\n* bgpd/bgp_zebra.c\n * bgp_ifindex_by_nexthop(): sayonara\n" }, { "commit": "cc2dd9280c4456586080d1cf4537d26c02fa9a36", "tree": "a7573e32187b87015f2a8efc6cbd9b8b7ef7057c", "parents": [ "1352ef32d70dcc102074814de63b5d08e591dd2d" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Dec 09 17:54:49 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 09 17:54:49 2009 +0300" }, "message": "zebra: cleanup RIB meta queue code\n\n* zebra/zebra_rib.c\n * rib_queue_add(): indent comments and simplify debug code\n * rib_queue_init(): remove unneeded assert() calls and\n extra return statements\n" }, { "commit": "1352ef32d70dcc102074814de63b5d08e591dd2d", "tree": "a0a4a40bf9a7726914f76cfa3a108529c7cc59df", "parents": [ "3949a60c350fea947d2701e2fe709b174ae7af16" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Dec 09 14:43:17 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 09 14:43:17 2009 +0300" }, "message": "lib: move check_bit into prefix common code\n\nMake one version of check prefix bit, and put it inline\nwith proper prototype. This gets rid of some macro\u0027s and also some\nassert() that can never happen on a non-broken compiler.\n\n* bgpd/bgp_table.c\n * CHECK_BIT(): sayonara\n * check_bit(): sayonara\n * SET_LINK(): sayonara\n * set_link(): make use of prefix_bit() instead of check_bit()\n * bgp_node_match(): idem\n * bgp_node_lookup(): idem\n * bgp_node_get(): idem\n* lib/prefix.h\n * prefix_bit(): new inline version of check_bit()\n* lib/table.c\n * CHECK_BIT(): sayonara\n * check_bit(): sayonara\n * SET_LINK(): sayonara\n * set_link(): make use of prefix_bit() instead of check_bit()\n * route_node_match(): idem\n * route_node_lookup(): idem\n * route_node_get(): idem\n* ospf6d/ospf6_lsdb.c\n * CHECK_BIT(): sayonara\n * ospf6_lsdb_lookup_next(): make use of prefix_bit() instead of\n CHECK_BIT()\n * ospf6_lsdb_type_router_head(): idem\n * ospf6_lsdb_type_head(): idem\n* ospf6d/ospf6_route.c\n * CHECK_BIT(): sayonara\n * ospf6_route_match_head() make use of prefix_bit() instead of\n * CHECK_BIT()\n" }, { "commit": "3949a60c350fea947d2701e2fe709b174ae7af16", "tree": "f9df272afc80a1835c4d5ab10ac7460e8499566b", "parents": [ "b0b709ab6656ba07f12fe0d256912dcabba19017" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Wed Dec 09 14:13:27 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 09 14:13:27 2009 +0300" }, "message": "lib: fix warning on little endian\n\n* md5.c\n * md5_calc(): If building on little endian then X\n will be \u0027const uint32_t\u0027 which causes compiler\n warning in code that never gets used. Just move\n the endif to make sure code is not checked.\n" }, { "commit": "b0b709ab6656ba07f12fe0d256912dcabba19017", "tree": "2633ce43d4256af90e9a85d2f866b911418b7cf8", "parents": [ "0342b76cfbfde2b6f45c4614e674d53987b1e9fa" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Dec 08 13:26:14 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 08 13:26:14 2009 +0300" }, "message": "zebra: fix more warnings in rtadv\n\n* zebra/rtadv.c\n * rtadv_free(): remove unused function\n * rtadv_recv_packet(): break up cast/dereference to avoid\n compiler type pun warning\n * rtadv_read(): initialize ifindex, because compiler can\u0027t\n figure out that it is okay\n" }, { "commit": "0342b76cfbfde2b6f45c4614e674d53987b1e9fa", "tree": "f126f00d400a7cac5dcbf0a0c948b855b03d5781", "parents": [ "d02c56cdf0c2e01a986417ed973dd7a2a5368ac1", "ffac19c58ee636274cd3972b584e37cd9a3331de" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 08 13:15:12 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 08 13:15:12 2009 +0300" }, "message": "Merge branch \u0027master\u0027 of ssh://code.quagga.net/var/lib/git/quagga\n" }, { "commit": "d02c56cdf0c2e01a986417ed973dd7a2a5368ac1", "tree": "59e92e74fefdddd8fd01b0fff98749922652b061", "parents": [ "0d6388abc7a5da2a20a4854c400c8e176127e480" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Dec 08 13:14:27 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 08 13:14:27 2009 +0300" }, "message": "zebra: fix more compiler warnings\n\n* zebra/zebra_rib.c\n * nexthop_active_update(): make local int vars unsigned\n * nexthop_active_check(): return unsigned for consistency\n * rib_dump(): cast time in printf format\n * vrf_free(): remove unused function\n * vrf_lookup_by_name(): idem\n * rib_if_up(): idem\n * rib_if_down(): idem\n" }, { "commit": "ffac19c58ee636274cd3972b584e37cd9a3331de", "tree": "ab21740846d246fd817dae578f5e4d83731e4cd6", "parents": [ "38cc00cd823fe945c7748de18c3e8932d98dd8f8" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Dec 08 12:27:02 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 08 12:27:02 2009 +0300" }, "message": "zebra: remove unused function to fix warning\n\n* zebra/interface.c\n * if_supported_family(): sayonara\n" }, { "commit": "38cc00cd823fe945c7748de18c3e8932d98dd8f8", "tree": "51f79a6ff37f8858b569f55f27480c4b47eb2aac", "parents": [ "0d6388abc7a5da2a20a4854c400c8e176127e480" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Dec 08 12:00:50 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 08 12:00:50 2009 +0300" }, "message": "lib: make match functions take const args\n\n* table.c: general type safety and compiler help:\n * maskbit[]: become const\n * route_node_match(): take const args\n * route_node_match_ipv4(): idem\n * route_node_match_ipv6(): idem\n * check_bit(): idem, plus adjust local vars typing\n" }, { "commit": "0d6388abc7a5da2a20a4854c400c8e176127e480", "tree": "effe14c7fc1e958b6082685026a1c3ad92b2451a", "parents": [ "78e6cd98dd88393d0863388caf37dae45435db7a" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Dec 07 19:19:13 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Dec 07 19:19:13 2009 +0300" }, "message": "lib: remove unused function: route_dump_node()\n" }, { "commit": "78e6cd98dd88393d0863388caf37dae45435db7a", "tree": "3c1e57265ea8f54055eb67b3ceb147da90920e0d", "parents": [ "64bf3ab7291cc5c39c5add0dc1a7de447914248b" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Mon Dec 07 16:41:14 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Dec 07 16:41:14 2009 +0300" }, "message": "lib: log source of vty connections (bug #566)\n\nheasley: I\u0027ve used this for a while to track usage.\n" }, { "commit": "64bf3ab7291cc5c39c5add0dc1a7de447914248b", "tree": "d5ae874814083d89815e6c521b42d0f3eaaec69c", "parents": [ "2eb445e1c22e36d07e2dbfd302ff438c4190b9fe" ], "author": { "name": "Ondrej Zajicek", "email": "santiago@crfreenet.org", "time": "Mon Dec 07 12:33:20 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Mon Dec 07 12:33:20 2009 +0300" }, "message": "ospf6d: review LSA sequence number comparison\n\nIt seems that there is a bug in ospf6d in ospf6_lsa_compare(): If LSA A\nhas sequence number smaller than 0x80000000 and LSA B has sequence\nnumber larger than 0x80000000, ospf6_lsa_compare() returns that B is\nmore recent than A, although RFC says that sequence numbers should be\ncompared as signed numbers (0x8000001 smallest and 0x7FFFFFFF largest).\n\nIn ospfd, the function ospf_lsa_more_recent() has it right.\n\nThe problem appears when Quagga is used together with OSPFv3 in\ndevelopment version of BIRD daemon ( http://bird.network.cz/ ),\nwhich creates LSAs with maximum sequence number (0x7FFFFFFF)\nas a part of flushing/premature aging LSA from OSPF area.\n\nBecause both daemons has different idea of which LSA instance\nis more recent, it would lead to LSA storm.\n" }, { "commit": "2eb445e1c22e36d07e2dbfd302ff438c4190b9fe", "tree": "82372e9d6fc630758fcf265cbdfdf3b826699cbd", "parents": [ "e6f148e6e06a37a65afb322eca6a3298b8ade8d2" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Dec 04 17:32:54 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Fri Dec 04 17:32:54 2009 +0300" }, "message": "bgpd: work around warning in assegments_parse()\n" }, { "commit": "e6f148e6e06a37a65afb322eca6a3298b8ade8d2", "tree": "5d3869cd936e5f9af5ee281518316037790513ef", "parents": [ "4a4bba04c7398069a6d43fa8ccf0d15bad5faaa2" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Thu Dec 03 21:43:11 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 21:46:00 2009 +0300" }, "message": "zebra: handle RTF_CLONING removal from FreeBSD 8.0\n\nThe RTF_CLONING flag has been removed in FreeBSD 8.0 with arp-v2 (see\nhttp://svn.freebsd.org/viewvc/base/stable/8/UPDATING?view\u003dmarkup),\nsince it no longer has any meaning. This patch checks if RTF_CLONING\nexists before using it.\n" }, { "commit": "4a4bba04c7398069a6d43fa8ccf0d15bad5faaa2", "tree": "1d216265f03b2f7eadb7d5b158f1edc960833c1b", "parents": [ "a0f63a4c7d7a6404fd43d139809202a693ae42e9" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Thu Dec 03 21:24:36 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 21:24:36 2009 +0300" }, "message": "isisd: fix --enable-isis-topology for 64-bit Linux\n" }, { "commit": "a0f63a4c7d7a6404fd43d139809202a693ae42e9", "tree": "1af7685743107d08861f089de25df0196b10e441", "parents": [ "362573e5642b29ffeef5000351adc2d6ed6dfca3" ], "author": { "name": "heasley", "email": "heas@shrubbery.net", "time": "Thu Dec 03 21:14:16 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 21:14:16 2009 +0300" }, "message": "zebra: fix argument reference in strncpy() call for BSD\n" }, { "commit": "362573e5642b29ffeef5000351adc2d6ed6dfca3", "tree": "2b1c84f9498563959f43b54335ab8a07c4e7e6c2", "parents": [ "cdb9950482e1180b4a2b6ba05d171bdf2649c84c" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Thu Dec 03 20:44:35 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 20:44:35 2009 +0300" }, "message": "isisd: fix BPF ioctl() calls, treat \"true\" and \"false\" as reserved\n\nAvoid a potential conflict with the C99 defines \u0027true\u0027 and \u0027false\u0027\nfound in \u003cstdbool.h\u003e by choosing better variable names.\n\nAlso fix the calls to these ioctls, as described in \u003cnet/bpf.h\u003e\nin FreeBSD, NetBSD, and OpenBSD:\n\n* BIOCGBLEN, BIOCIMMEDIATE, BIOCSSEESENT (the parameter should be\nof type \u0027u_int\u0027)\n\n* BIOCPROMISC (there should be no parameters)\n" }, { "commit": "cdb9950482e1180b4a2b6ba05d171bdf2649c84c", "tree": "cc1e1e04f6adadf006428272c5f23ef4abbefa64", "parents": [ "8b6a15b2821e687177cef3ff057e1c4ec76df888" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Thu Dec 03 20:22:47 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 20:22:47 2009 +0300" }, "message": "configure: fix spelling\n" }, { "commit": "8b6a15b2821e687177cef3ff057e1c4ec76df888", "tree": "cd271d0dcf5233226ded94dfbd96b687428b196a", "parents": [ "3408afe2acf34729730a7dc1efdd587c561b6f59" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 03 19:25:04 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 19:25:04 2009 +0300" }, "message": "ospfd: VTY strings cleanup\n\nSeveral bits of text can be local or are unused.\n" }, { "commit": "3408afe2acf34729730a7dc1efdd587c561b6f59", "tree": "65ac57e811f0d5f6ce6fce6d4c78c6cd1bc33e79", "parents": [ "917e29954e652518326dbbdb90325a978ef69535" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 03 19:18:26 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 19:18:26 2009 +0300" }, "message": "ospfd: comment out unused function\n" }, { "commit": "917e29954e652518326dbbdb90325a978ef69535", "tree": "e3fe0929ed348060db1023ba500a9b33b58de275", "parents": [ "a50c107e3fbdaaea78a12a868a3865fd25136ad2" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Dec 03 19:07:00 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 19:07:00 2009 +0300" }, "message": "ospfd: make local functions static\n\nThis code is only used one place and can be made local.\nGcc is smart enough to inline local functions if it wants to.\n\nThe function also has a big chunk of compatiablity code that\nis no longer used; since quagga is now in a version control system\nthe source does not need to be used as a historical reference.\n" }, { "commit": "a50c107e3fbdaaea78a12a868a3865fd25136ad2", "tree": "cdc78feecf243768780ef784608f68386d41fef0", "parents": [ "80b2a9418f0ee70318c677778d63f860f0f397c3" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Thu Dec 03 15:34:39 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 15:34:39 2009 +0300" }, "message": "zebra: fix RIB debug message for IPv6\n\nApply changes from commit f304cb48f0d7d0ff8f36e7aca8293141a9fa9e60\nto rib_queue_add.\n\nAlso includes spelling fixes.\n" }, { "commit": "80b2a9418f0ee70318c677778d63f860f0f397c3", "tree": "d8d6c3190b68a51e1058459709416b1b8c0c93dd", "parents": [ "16c1c4872b29bb22c0ff77bd1ef1018c63ca25fa" ], "author": { "name": "Tom Goff", "email": "thomas.goff@boeing.com", "time": "Thu Dec 03 14:53:15 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Thu Dec 03 14:53:15 2009 +0300" }, "message": "zebra: make declaration const in rtm_flag_dump()\n\n* kernel_socket.c: (rtm_flag_dump) Use a const message pointer to be\nin sync with commit ce0db9cb11c0bc2e7f89a7d042e50afa495556b4.\n" }, { "commit": "16c1c4872b29bb22c0ff77bd1ef1018c63ca25fa", "tree": "06813f6d1b703649757f3eedf829e7afddfe5c42", "parents": [ "9964fcfc2282c8f3468b3b7355c5dea3089f0f14" ], "author": { "name": "Tom Goff", "email": "thomas.goff@boeing.com", "time": "Tue Dec 01 21:12:38 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 01 21:12:38 2009 +0300" }, "message": "ospf6d: fix LSA locking in ospf6_new_ls_id()\n\n* ospf6_lsdb.c: (ospf6_new_ls_id) Unlock the current LSA when breaking\nout of the ospf6_lsdb_*_head() / ospf6_lsdb_*_next() loop early. No\nexplicit unlocking is needed when all LSAs are looped through\nbecause ospf6_lsdb_*_next() manages everything in that case.\n" }, { "commit": "9964fcfc2282c8f3468b3b7355c5dea3089f0f14", "tree": "872e983e1e05b9544b5689408df1041046082d37", "parents": [ "827341b797f602f4cd7932a777f819b530521b05" ], "author": { "name": "Dmitry Tejblum", "email": "tejblum@yandex-team.ru", "time": "Thu Nov 05 16:50:36 2009 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Nov 05 16:50:36 2009 +0300" }, "message": "configure: fix HAVE_CLOCK_MONOTONIC spelling\n" }, { "commit": "827341b797f602f4cd7932a777f819b530521b05", "tree": "e1eb4c1f91c11f56cdc7daa41fc2082b64a522bf", "parents": [ "50adf7832004191cdaf5a908bd9a9c0b2373e993" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Mon Sep 28 19:34:59 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Mon Sep 28 19:34:59 2009 +0400" }, "message": "[ospfd] enable more OSPF cost command aliases\n\nThe following syntax forms were not historically supported\nby Quagga, although IOS accepted them w/o a problem:\n\nno ip ospf cost \u003c1-65535\u003e\nno ospf cost \u003c1-65535\u003e\nno ip ospf cost \u003c1-65535\u003e A.B.C.D\nno ospf cost \u003c1-65535\u003e A.B.C.D\n\nFrom now on Quagga also supports these variants.\n" }, { "commit": "50adf7832004191cdaf5a908bd9a9c0b2373e993", "tree": "726d32636baa6c718e3fdab5a48ffae870c7b048", "parents": [ "3849ce4e25281d11537ebd0db5e2fa2a7c356b33" ], "author": { "name": "David Ward", "email": "david.ward@ll.mit.edu", "time": "Mon Aug 31 10:42:06 2009 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 01 19:03:01 2009 +0100" }, "message": "zebra: Fix router advertisements for non-Ethernet link layer addresses\n\n* rtadv.c: round up when calculating the link-layer address option length;\n add padding to the option if needed to end on an octet boundary\n" }, { "commit": "3849ce4e25281d11537ebd0db5e2fa2a7c356b33", "tree": "db31182d611dcc325a007755cbc091bc0789d212", "parents": [ "aabbb1ae358a3fd9af011cddc1a67dfa0b3df2d2" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 19:16:31 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 19:16:31 2009 +0100" }, "message": "release: 0.99.15\n\n* configure.ac: Bump to 0.99.15\n" }, { "commit": "aabbb1ae358a3fd9af011cddc1a67dfa0b3df2d2", "tree": "04ce8d205c0242f93037873f92e8a6f8dc24927a", "parents": [ "d1c21cabdbeeb4d12049f39579c602686eb94927" ], "author": { "name": "Tom Henderson", "email": "tomh@tomh.org", "time": "Fri Aug 28 15:10:00 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 15:10:00 2009 +0100" }, "message": "ospf6d: bug #529, fix endianness problem in earlier commit \n\n* ospf6_lsa.c: (ospf6_lsa_age_current) arithmetical compares make no sense\n in non-host order..\n\n" }, { "commit": "d1c21cabdbeeb4d12049f39579c602686eb94927", "tree": "aaaee477b15999c34175c80f6b3b1e99d2887150", "parents": [ "c4cf095e95ae66c1a7b87bca95e61e50fec746ee" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Aug 25 10:18:15 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 14:53:42 2009 +0100" }, "message": "bgpd: fix md5 set on listen sockets\n\n* bgp_network.c: (bgp_md5_set) Missing piece from earlier listener change\n did not get ported from Vyatta code into upstream. The list\n listener_sockets changed from (int *) to (struct bgp_listener *).\n" }, { "commit": "c4cf095e95ae66c1a7b87bca95e61e50fec746ee", "tree": "368c8688e2bbe6cdffa46c28d4480c1496449f48", "parents": [ "fab7f89dcfe77cf06806e7f8a33314d3b4857a69" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sat Aug 08 20:41:39 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 14:51:49 2009 +0100" }, "message": "lib/trivial: str2prefix checks return of inet_pton in fragile way\n\n* prefix.c: (str2prefix_ipv6) inet_pton succesful return is presumed to be\n 1, rather than the \"not zero\" the man page describes - seemed fragile.\n" }, { "commit": "fab7f89dcfe77cf06806e7f8a33314d3b4857a69", "tree": "8679d4cf30957577bc48425bbf7a99994cf93ce8", "parents": [ "302d53f791031c15590f59944313381dfb4200c6" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 06 12:12:12 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 14:51:37 2009 +0100" }, "message": "zebra: Add an example config file for testzebra\n\n* testrib.conf: Example config file for testzebra\n" }, { "commit": "302d53f791031c15590f59944313381dfb4200c6", "tree": "dbadd21327e5445860193e1511863f2fa11b6185", "parents": [ "3e4ee9591aa2d84f01ae478afd273ac55add0a1c" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 06 11:48:48 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 14:51:27 2009 +0100" }, "message": "zebra: test_main.c should be a bit more helpful about its usage\n\n* test_main.c: If required arguments are missing, say that.\n" }, { "commit": "3e4ee9591aa2d84f01ae478afd273ac55add0a1c", "tree": "dda1a647bc59031728ac28733feec89d8a38a8b2", "parents": [ "27f5dc8120e1c6902e29d86cf0d77b82cf3848c0" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 06 12:08:50 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 14:51:18 2009 +0100" }, "message": "lib: if_lookup_by_name should be more robust to null argument\n\n* if.c: (if_lookup_by_name) shouldn\u0027t crash just cause we got a NULL name\n" }, { "commit": "27f5dc8120e1c6902e29d86cf0d77b82cf3848c0", "tree": "a9058ac54bf22840409d52aa761fa215cc7abb31", "parents": [ "5d8de93a84b2afc4202d3284eb9e57672e2551b3" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Sat Aug 22 14:57:54 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 13:03:49 2009 +0100" }, "message": "ospfd: Make sure priority is respected.\n\n* ospf_ism.c (ospf_dr_eligible_routers) should test for priority \u003e 0 instead\n of !\u003d 0 as ospf_nbr_new () initially sets prio to -1\n" }, { "commit": "5d8de93a84b2afc4202d3284eb9e57672e2551b3", "tree": "9a17c616907cd000efc46873994464409c575099", "parents": [ "065de90380c88d9fcc116627f714bed9984c2723" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Fri Aug 07 13:48:15 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 28 12:29:38 2009 +0100" }, "message": "ospfd: Tighten up the connected check for redistribution\n\n* ospf_zebra.c: (ospf_distribute_check_connected) check to make filter out\n routes matching connected routes was matching against OSPF networks, which\n can be far more general than the actual connected interfaces. Fix.\n" }, { "commit": "065de90380c88d9fcc116627f714bed9984c2723", "tree": "79061a2699e0dc3e87c218b3b57c2f0577d5a69a", "parents": [ "5bd5881838c22e075c3d0c245a8952a55e9dca38" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Fri Aug 07 11:13:49 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 13 10:21:13 2009 +0100" }, "message": "all: check return value from daemon() call\n\n* */*main.c: (main) Current versions of Gcc warn if the return value for\n daemon() is not checked. So add a simple test and exit on failure.\n\n" }, { "commit": "5bd5881838c22e075c3d0c245a8952a55e9dca38", "tree": "b0f011eef51409e492ef107aace3fefca4530f77", "parents": [ "62bed38d2f2c7317b5c97285d9fb935c5fe681e1" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Aug 06 21:05:47 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 13 10:19:24 2009 +0100" }, "message": "bgp: missing pieces from listener patch\n\n* bgp_network.c: (bgp_accept) The code in current git will crash as part of\n the revised listener code is missing. The new listener thread code passes\n a pointer to a bgp_listener structure, not the bgp pointer. The old code\n always got a NULL for bgp pointer, so that is now hard coded.\n" }, { "commit": "62bed38d2f2c7317b5c97285d9fb935c5fe681e1", "tree": "8fd4189ed9927b258cfc2fdbb20fcd48cbd08e9b", "parents": [ "3106a03215f5f09c2c0d427fa706fff52ef3cb37" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Aug 06 21:07:23 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 13 09:59:58 2009 +0100" }, "message": "bgp: compiler warning fix\n\n* bgp_filter.h: Gcc complains the function prototype is not correct because\n the function argument is using old K\u0026R style.\n" }, { "commit": "3106a03215f5f09c2c0d427fa706fff52ef3cb37", "tree": "378e2b80de22275e91157fd0b9db5248b5681eea", "parents": [ "5996e0df2eb325445114517209cd24f37d91774a" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Aug 06 12:58:05 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Aug 13 09:58:46 2009 +0100" }, "message": "ospfd: fix performance problem with redistribute delete\n\nDoing redistribute delete with full BGP table was taking\n30 minutes, this drops it down to less than a second.\n\n* ospf_lsa.c: (ospf_lsa_maxage) When flushing lots of entries the\n performance is terrible because it looks up each LSA entry through\n ospf_lsa_maxage_exist before deleting causing O(N^2) performance. Use a\n new OSPF_LSA_MAXAGE flag instead of scan - and maintain it.\n (ospf_lsa_maxage_exist) removed\n (ospf_lsa_maxage_delete) maintain OSPF_LSA_MAXAGE flag\n" }, { "commit": "5996e0df2eb325445114517209cd24f37d91774a", "tree": "56bee1d2ab48d4b7a5e163747b54d7537f4df9a3", "parents": [ "11637435b2d74702296b0522500d03b0395554a2" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Jul 27 12:42:35 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Aug 11 17:33:27 2009 +0100" }, "message": "ospfd: Make sure route table is recalculated.\n\nIn some cases ospfd does not recalc the route table. This\nhappens when ospfd receives an old LSA which will trigger\nrecalc but the this recalc will fail because all interfaces\nisn\u0027t up yet. Next LSA that is originated matches the old one\nso no recalc will be performed. This problem has been observed\nwhen there are only 2 ppp I/Fs in an area, both go down at the\nsame time, then they come up again with a few seconds apart.\n\n* ospf_lsa.c: (ospf_{router,network}_lsa_install) avoid a needless scheduling\n of SPF.\n (ospf_lsa_different) fix bug in LSA comparison that would lead to the\n described failure to schedule SPF.\n" }, { "commit": "11637435b2d74702296b0522500d03b0395554a2", "tree": "c9e5fd2cc9188f7a0702eebc7f6a24c3d4dc495d", "parents": [ "9d878775ff5c05afea522b60f014b88822d19e1b" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Aug 11 12:25:42 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Aug 11 12:25:42 2009 +0100" }, "message": "ospfd: Make \"Packet ... received on wrong link\" conditional on debug\n\n* ospf_packet.c: make this message conditional on \u0027debug ospf event\u0027, as it\n be easily triggered with, e.g., multiple subnets sharing same physical\n network. E.g, see bug #532.\n" }, { "commit": "9d878775ff5c05afea522b60f014b88822d19e1b", "tree": "f1c7c45de602e2ac7ccd2c3c309e6568beff3af7", "parents": [ "5372510d109d87b94d6094d095dd4e0e02eaf32a" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Aug 05 16:25:16 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Aug 05 16:25:16 2009 +0100" }, "message": "bgpd: Fix mistakes in applying \u0027allow inbound connections to non-default view\u0027\n\n* bgpd.c: (peer_lookup_with_open) Bodged application of previous patch\n meant the second loop around bgp-\u003epeer wasn\u0027t included in the loop\n around bm-\u003ebgp as it was supposed to be. Fix..\n" }, { "commit": "5372510d109d87b94d6094d095dd4e0e02eaf32a", "tree": "9c112ea23db64e3d2f2978e8c7df575cbd3a14a3", "parents": [ "4ca15d4a658dca9663b7dea2475edfe6814ef847" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Aug 03 16:34:16 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Aug 03 16:52:38 2009 +0100" }, "message": "ospfd: neuter some compiler warnings\n\n* ospf_lsa.c: (link_info_set) Use %zd for size_t - C99 is old enough now.\n Lots of similar warnings all over the code.\n (ospf_lsa_translated_nssa_compare) Unused func - delete.\n" }, { "commit": "4ca15d4a658dca9663b7dea2475edfe6814ef847", "tree": "a756f68b118cf641f8f91966e771345d4a177b76", "parents": [ "a8ba847ff96b41e06770d4987b15707890ed5807" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Aug 03 15:16:41 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Aug 03 16:52:38 2009 +0100" }, "message": "ospfd: update some comments\n\n* ospf_{spf,lsa}.c: remove out of date comment; add comment on some\n non-obvious code; Make note of a possible scaling problem.\n" }, { "commit": "a8ba847ff96b41e06770d4987b15707890ed5807", "tree": "07864eb958853e5ad7b2616c9b7bc5259a8ae503", "parents": [ "bd5403778b0d96258730050e4526c7c72903e60b" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Jul 27 12:42:34 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Aug 03 16:52:30 2009 +0100" }, "message": "ospfd: Change struct ospf_path *oi to ifindex.\n\n* global: In struct ospf_path, change struct ospf_interface *oi to int\n ifindex. It is unsafe to reference *oi as an ospf interface can be\n deleted under your feet. Use a weak reference instead.\n" }, { "commit": "bd5403778b0d96258730050e4526c7c72903e60b", "tree": "bcd21a0f78175f0693857bc7eaadef30d8b3c4a6", "parents": [ "4a5f432fa07f33da5ad05d18e4ba81d57b44af8e" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Jul 27 12:42:31 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 16:18:30 2009 +0100" }, "message": "ospfd: Discriminate better when selecting links between vertices in SPF\n\n* ospf_spf.c: (ospf_get_next_link) One must check the vertex type, Router or\n Network, to select type link to match against. Link type 1 has neighbour\n router ID in link_id and link type 2 has IP address of DR. Since router\n id may have same value as an existing IP address one risks matching a\n router ID against a DR.\n" }, { "commit": "4a5f432fa07f33da5ad05d18e4ba81d57b44af8e", "tree": "d8728f36ff64a1ba39d83de6aabfd3d4dc661447", "parents": [ "66bed4f4f0235c1eb6edb0a2f6bd4aaf47e5a7f8" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:24 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:24 2009 +0100" }, "message": "[bgpd] delete erroneous extra brace..\n" }, { "commit": "66bed4f4f0235c1eb6edb0a2f6bd4aaf47e5a7f8", "tree": "17488e5dc6eb4cc575f2aa006bfd87ec9c815222", "parents": [ "3de4277ba9b25ff03710d7c004bf708accffd5c7" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Tue Jul 28 11:26:14 2009 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:55:14 2009 +0100" }, "message": "bgpd: Workaround for invalid MBGP next hop\n\n* bgp_attr.c: (bgp_mp_reach_parse) There are some interoperability issues\n for MBGP (particularly IPv4 multicast NLRI) between different\n implementations. In order to get some next hops to install correctly in\n the BGP tables, it appears to be necessary to copy the multiprotocol next\n hop into the base next hop field. This is related to differences in RFC\n 2283 and RFC 2858.\n" }, { "commit": "3de4277ba9b25ff03710d7c004bf708accffd5c7", "tree": "df5d9125635c6101cf6e1224f5b8b1af25fe91e4", "parents": [ "05cf46badbad99b76c4e974c7306c14494d1000e" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 16:04:35 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 30 15:51:45 2009 +0100" }, "message": "[doc] Update HACKING\n\n* HACKING: Update to reflect git stripping []\u0027s, and to allow for more\n discretion to avoid redundancy in commit messages.\n" }, { "commit": "05cf46badbad99b76c4e974c7306c14494d1000e", "tree": "dd1fd18afc3d7ef6f92281c1c6fb0bc8ebd6a58b", "parents": [ "f0f63841582ed97362619a53fb711747f09d961b" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Jul 27 12:42:30 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:47:43 2009 +0100" }, "message": "ospfd: Make ospf_if_lookup_recv_if() find the right unnumbered i/f\n\nThis function will return the interface for the first matching\nremote address for PtP i/f\u0027s. That won\u0027t work for multiple\nunnumbered i/f\u0027s as these may all have the same address.\n\nPass in the struct interface pointer, ifp, to find the\ncorrect set of oi\u0027s to search in. This also reduces the\nsize of the search list, making it faster.\n\n* ospfd/ospf_interface.c: Add struct interface * param to\n ospf_if_lookup_recv_if() to select the right list to search in.\n* ospfd/ospf_interface.h: ditto.\n* ospfd/ospf_packet.c: Pass new ifp argument to ospf_if_lookup_recv_if()\n" }, { "commit": "f0f63841582ed97362619a53fb711747f09d961b", "tree": "bb663103d3b25064143685a4f3f40cd008b3cc0f", "parents": [ "2158ad2359a370dd349f4543a2d5d535bb5a8770" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Jul 27 12:42:29 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:40:47 2009 +0100" }, "message": "ospfd: export ospf_if_table_lookup() and use it in ospf_network_run_interface()\n\nMakes it possible to run OSPF on multiple PtP interfaces\nwith the same remote address.\n\n* ospfd/ospf_interface.c: Export ospf_if_table_lookup().\n* ospfd/ospf_interface.h: ditto.\n* ospfd/ospfd.c: (ospf_network_run_interface) Use ospf_if_table_lookup() to\n determine whether OSPF is already configured for a subnet and interface.\n\n" }, { "commit": "2158ad2359a370dd349f4543a2d5d535bb5a8770", "tree": "afaf6922eecc2f155016e229d516b4e2487c7dbe", "parents": [ "fc4dc59d08589a887ac33a70d946eb7905541f5f" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:10:55 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:10:55 2009 +0100" }, "message": "bgpd/trivial: Fix indentation in previous\n" }, { "commit": "fc4dc59d08589a887ac33a70d946eb7905541f5f", "tree": "b142a18a28ebf915757aafe6bf5a139ec0f112bb", "parents": [ "3117b5c47df044f8b2197fff60641075394fdce5" ], "author": { "name": "Steve Hill", "email": "quagga@cheesy.sackheads.org", "time": "Tue Jul 28 17:54:35 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 18:06:39 2009 +0100" }, "message": "bgpd: Allow inbound connections to non-default view\n\n* bgpd.c: (peer_lookup) Search through all BGP instances for matches, not just\n the default instance, if no specific instance is given.\n (peer_lookup_with_open) same.\n" }, { "commit": "3117b5c47df044f8b2197fff60641075394fdce5", "tree": "0a25f9376ab96e21d9e161f9c9e156fbd5641d53", "parents": [ "cb9e0ceec988a059dd2269ebc54722c01afb7cca" ], "author": { "name": "Steve Hill", "email": "quagga@cheesy.sackheads.org", "time": "Tue Jul 28 17:50:00 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 17:50:00 2009 +0100" }, "message": "bgpd: fd leak in bgpd\n\n* bgp_fsm.c: I have found an fd leak in bgpd that is caused by the \u0027new\u0027\n Clearing state. I\u0027ve been seeing it from hold timer failures, but it can\n also be triggered by other things.\n\n When Hold_Timer_expired fires in Established state, a notify is sent and\n BGP_Stop event queued. The fsm then transitions into Clearing state.\n That is the problem; When the BGP_Stop event is serviced, the state table\n says to ignore it while in Clearing. Thus bgp_stop is not called and the\n fd leaks. Previously the peer would be in Idle state, which correctly\n handles the BGP_Stop event.\n\n Fix by making bgp_stop safe to call from Clearing state, without losing\n ClearingCompleted events, and then ensuring it is called prior to\n transition from Clearing-\u003eIdle.\n" }, { "commit": "cb9e0ceec988a059dd2269ebc54722c01afb7cca", "tree": "c558e706ffca27dd4568f729a48b6f8c83a64c9a", "parents": [ "9afabaf048af74a370dfc71411b6963641f713b2" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Apr 20 00:31:57 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 16:24:19 2009 +0100" }, "message": "[zebra] Fix crash in test_zebra\n\n* kernel_null.c: we\u0027re pretending to add an address, so\n set IFC_REAL. If this isn\u0027t done, calling into the \u0027got address\n from kernel\u0027 half of zebra will implicitly-withdraw the ifc, which\n could cause a crash in test_zebra.c.\n" }, { "commit": "9afabaf048af74a370dfc71411b6963641f713b2", "tree": "81bea7f7655fe04d6e9c7d2b053dabae9e2ce242", "parents": [ "736d440845c8c0cfdb56b86254887bab5fc7f3f5", "97be79f9d38b07214d5ad9b437e1a852c594a985" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 16:06:45 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 16:06:45 2009 +0100" }, "message": "Merge remote branch \u0027origin/master\u0027\n" }, { "commit": "736d440845c8c0cfdb56b86254887bab5fc7f3f5", "tree": "e1b7f27c18b03494509e9b9ef0a694b726630418", "parents": [ "ca87e1d37b3c30648e9bacb476a3c89729512f6d" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:59:10 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 15:02:07 2009 +0100" }, "message": "bgpd: Delete AS_CONFED_SEQUENCE when prepending an AS_SEQUENCE type segment\n\nAS_CONFED_SEQUENCE segment should always be deleted when prepending\n(e.g. with a route-map) an AS_SEQUENCE segment to an AS path. Otherwise,\nAS_CONFED_SEQUENCE will not be deleted later when updating EBGP peers (since\nit is not the leftmost segment) and will leak outside the confederation.\n" }, { "commit": "ca87e1d37b3c30648e9bacb476a3c89729512f6d", "tree": "d0911b72e7d4c3c94c88a65233ee8a7fa8a4c950", "parents": [ "30d205909c5a81cc306b161c16abff0fd7f566a7" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:28:35 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 14:49:33 2009 +0100" }, "message": "bgpd: Implement BGP confederation error handling (RFC5065, Par. 5)\n\nThis patch implements BGP confederation error handling in Quagga as described\nin RFC5065, paragraph 5.\n\n* bgp_aspath.c: (aspath_confed_check, aspath_left_confed_check) new functions\n* bgp_attr.c: (bgp_attr_aspath_check) apply previous and NOTIFY if there\u0027s\n a problem.\n" }, { "commit": "30d205909c5a81cc306b161c16abff0fd7f566a7", "tree": "6f7532a4336cf601bbeab07d2669639a05409dfd", "parents": [ "d023aec49f70156d2ed894a8fba65bcfa221ff02" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Jul 28 11:58:51 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 11:58:51 2009 +0100" }, "message": "[global] interface flags format warnings\n\n*/*: ifp-\u003eflags is 64 bit unsigned which can not be handled by %l on 32\n bit architectures - requires %ll and the appropriate cast.\n" }, { "commit": "d023aec49f70156d2ed894a8fba65bcfa221ff02", "tree": "00ab5d69481c212b6ed2f350c5a5c7f430ef9208", "parents": [ "03621955d8ab0ea30024bd8fc83afda8e48db712" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Jul 21 16:27:21 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 10:04:38 2009 +0100" }, "message": "bgpd: start listener on first instance\n\nStart BGP listener only after first instance is started. This helps the\nsecurity if BGP is not used but daemon is started. It also addresses some\nissues like MD5 not working on listener unless IPV6 configured (because\nlistener was not in list); as well as compiler warnings.\n\n* bgp_network.c: (bgp_listener) listen socket creation consolidated here\n (bgp_socket) Use bgp_listener\n* bgpd.c: (bgp_get) call bgp_socket on creation of first struct bgp.\n (bgp_init) remove bgp_socket call.\n* memtypes.c: Add MTYPE_BGP_LISTENER\n" }, { "commit": "03621955d8ab0ea30024bd8fc83afda8e48db712", "tree": "0df6f032806430fdd7d70b5317779d146e9d6f58", "parents": [ "78b31d5cf511c400d7f09158a3d8863f1bf63c2a" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Jul 21 16:27:20 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 28 10:04:38 2009 +0100" }, "message": "bgpd: peer action table static/const\n\nbgpd.c: (various tables) only used in one place and are immutable.\n" }, { "commit": "78b31d5cf511c400d7f09158a3d8863f1bf63c2a", "tree": "b47a513278c23f7034c5ffa885facc1963d3a52a", "parents": [ "9a1a331d63ae9db1912a1edb48c5c176454562f8" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Tue Jul 21 16:27:26 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jul 27 12:37:26 2009 +0100" }, "message": "ripd: set IP TOS for control socket\n\n* ripd.c: (rip_create_socket) RIP packets should go out with Type Of Service\n (DSCP) set to Internet control (like OSPF and BGP).\n" }, { "commit": "9a1a331d63ae9db1912a1edb48c5c176454562f8", "tree": "d6da5f9ce7e6760f59a7fda7ceeb89877a3148c5", "parents": [ "5b40b1b57e1fad1caf579e032adf4e111128e486" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jul 27 12:27:55 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jul 27 12:27:55 2009 +0100" }, "message": "[bgpd] Restore ability of \u0027neighbor ... update-source\u0027 to take interface name\n\n* bgp_vty.c: (BGP_UPDATE_SOURCE_STR) Restore ability to accept arbitrary\n interface names for the \u0027neighbor ... update-source\u0027 command - shouldn\u0027t\n have been deleted.\n (BGP_UPDATE_SOURCE_STR) Add help for same.\n" }, { "commit": "97be79f9d38b07214d5ad9b437e1a852c594a985", "tree": "dbc8513b7f58c4f603ea1eed87efe9dbf4d7897e", "parents": [ "5b40b1b57e1fad1caf579e032adf4e111128e486" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Fri Jul 24 20:45:31 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Fri Jul 24 20:45:31 2009 +0400" }, "message": "[zebra] do not touch socket before pidfile locking\n\nMove zserv socket creation code into zebra_zserv_socket_init() and\ncall it only after pidfile lock has been acquired exclusively. This\nkeeps subsequent zebra daemons from deleting the working socket of\nan already running process (bug #403).\n" }, { "commit": "5b40b1b57e1fad1caf579e032adf4e111128e486", "tree": "87cc68288b5ba178ba0e25fea64f17e8d4b2658c", "parents": [ "998274cd7c559bd04d7b7f6e615ad120af915d86" ], "author": { "name": "Thijs Kinkhorst", "email": "thijs@debian.org", "time": "Tue Jul 21 19:24:29 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Tue Jul 21 19:24:29 2009 +0400" }, "message": "[doc] zebra.8 via Christian Hammers (#531)\n\nThe man page for zebra(8) mentions as port number to connect to 2602,\nbut it\u0027s acutally 2601 (as shown in /etc/services). 2602 belongs to ripd.\nAttached patch fixes this typo.\n" }, { "commit": "998274cd7c559bd04d7b7f6e615ad120af915d86", "tree": "6869195b82a9349165a32d6c80c7960984cb2a92", "parents": [ "638b70ba9893705bb3268aa00c25b8cb0e060b32" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 15:21:20 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 15:21:20 2009 +0100" }, "message": "[build] Bump release to 0.99.14\n" }, { "commit": "638b70ba9893705bb3268aa00c25b8cb0e060b32", "tree": "51eaabdcfba4bfd4b5aa54c7a1b20298c9e2fc2a", "parents": [ "a294365797da8b72e51507cbf92dbc6940e5103b" ], "author": { "name": "Vasilis Tsiligiannis", "email": "b_tsiligiannis@silverton.gr", "time": "Mon Jul 20 01:25:16 2009 +0300" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:44:41 2009 +0100" }, "message": "[bgp] Fix nexthop reachability check on confederations\n\n* bgp_route.c: (bgp_update_main) Nexthop reachability should be checked for\n confederations too in case a prefix is received from more than one\n confederation peers.\n" }, { "commit": "a294365797da8b72e51507cbf92dbc6940e5103b", "tree": "618569bcf8a1a5d4f7a0a8192692c5d3e27bbb02", "parents": [ "e8eb000e15e2bbe63467d7c056f2b21b72ba7bd6" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:02:04 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 14:02:04 2009 +0100" }, "message": "[bgpd] fix typo made by paul in previous commit\n" }, { "commit": "e8eb000e15e2bbe63467d7c056f2b21b72ba7bd6", "tree": "3e21cb6d66b0e1b8caaacc687ad30b83607d33a3", "parents": [ "e7cc3b383e5e9190aa7784554c605a3a661ebe2b" ], "author": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Tue Feb 17 12:14:23 2009 +0200" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 13:15:32 2009 +0100" }, "message": "[bgpd] Avoid zombie accepted peer entries\n\nCurrently, when accepting the connection, it can be left as zombie, when the\npeer just initiates a connection, but never sends data (and the TCP\nconnection end packets are lost). This happens because for accepted\nconnections a temporary new peer entry is created until OPEN message is\nexchanged, and this temporary peer entry does not get the hold time\nparameter set at all.\n\n* bgp_network.c: (bgp_accept) Set hold time and keepalive values for ACCEPT\n peers.\n" }, { "commit": "e7cc3b383e5e9190aa7784554c605a3a661ebe2b", "tree": "3f7b254d2e47805d4a39c43bd0c6f459e512732a", "parents": [ "67b9467f6cad5097a3e4c6e49348be4d6c17a5bb" ], "author": { "name": "Nick Hilliard", "email": "nick@inex.ie", "time": "Tue Mar 17 22:14:25 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 11:34:27 2009 +0100" }, "message": "[bgpd] Small buffer overrun in bgp_clear_node_queue_init\n\n* bgp_route.c: (bgp_clear_node_queue_init) fix buffer\n overrun.\n" }, { "commit": "67b9467f6cad5097a3e4c6e49348be4d6c17a5bb", "tree": "a4c14d2d2ad51f367c3e2a511942e8945bc22a16", "parents": [ "228da42898c4f7bd72d9c1ee4135108e8d40d860" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 04:02:26 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jul 21 10:13:11 2009 +0100" }, "message": "[zebra] Silence noisy process_subq\n\nzebra_rib.c: process_subq(): #ifdef out debug code.\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "54a15182e05ca757db3bb90a4135e9f8fd3c84f2", "tree": "1d29ccce46cb362ae3b2b28b2a46a3dc017d5bf1", "parents": [ "62c9f504bdd4b09df6cf677e96367f3b31ef9dea" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:42:34 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 17:36:59 2009 +0100" }, "message": "[bgpd] Fix compiler warnings related to MD5\n\nThis patch fixes:\n\nbgp_network.c: In function \u0027bgp_md5_set\u0027:\nbgp_network.c:107: warning: cast from pointer to integer of different size\nbgp_network.c: In function \u0027bgp_socket\u0027:\nbgp_network.c:447: warning: cast to pointer from integer of different size\n" }, { "commit": "62c9f504bdd4b09df6cf677e96367f3b31ef9dea", "tree": "25804d84010397a352b384d10d5cfab1d41ff42e", "parents": [ "fd35b948dbb35674cd9ded431f94b59aeced40cc" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 17:33:21 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 17:33:21 2009 +0100" }, "message": "[build] fix default CFLAGS and squish warning\n\n* configure.ac: Move down the AC_SYS_LARGEFILE test - it was setting CFLAGS\n and so disabling the default CFLAGS setting section.\n Squish warning by adding AC_CONFIG_MACRO_DIR on the reccommendation of\n autoreconf.\n" }, { "commit": "fd35b948dbb35674cd9ded431f94b59aeced40cc", "tree": "c236a99b492b19943916e0c117b0a2461333b422", "parents": [ "3fa3f957e70f594cc2c1cac03644ddf48554c178" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 16 19:27:32 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jul 17 11:19:46 2009 +0100" }, "message": "[bgpd] Bug #533: Fix crash with copy/pasted commands, inc \u0027no bgp ...\u0027\n\n* bgpd.c: Removal of (struct bgp *) from the master list was being left to\n bgp_free time. This meant there was a window of time between bgp_delete\n and refcounts hitting 0 (e.g. routes to be processed) where bgp_lookup\u0027s\n could return a deleted (struct bgp *).\n\n (bgp_delete) This is the logical place where a (struct bgp *) should lose\n its visibility, so move the deletion from the bgp-master list to here,\n from bgp_free.\n\n Many thanks to Fritz Reichmann for his thorough debugging of the problem\n and testing of fixes and Chris Caputo for his further analysis.\n" }, { "commit": "3fa3f957e70f594cc2c1cac03644ddf48554c178", "tree": "86e63fd609afab8fc297e557b03cd4993f981ab2", "parents": [ "9b4ef258a9d9c5f1052afe0e19ebaef9f6740fa2" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Sat Jul 11 21:27:51 2009 -0700" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 16 18:13:00 2009 +0100" }, "message": "[lib] Fix IPv6 normalisation\n\n* lib/sockunion.c: (sockunion_normalise_mapped) The code to normalize\n address was not copying port value - probably reason why IPV4 in IPV6\n never worked right.\n" }, { "commit": "9b4ef258a9d9c5f1052afe0e19ebaef9f6740fa2", "tree": "7deb3abfbddadc9c15300c1a6702549e918db5dc", "parents": [ "41b2373cece77f0cc9a06fba076c99a7be653593" ], "author": { "name": "Tom Henderson", "email": "tomh@tomh.org", "time": "Thu Jul 16 17:20:37 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jul 16 17:20:37 2009 +0100" }, "message": "[ospf6d] Fix regression in monotonic time patch - LSA max-aging broke\n\n* ospf6_lsa.c: (ospf6_lsa_premature_aging) set age to MAX_AGE - don\u0027t\n rely on 0 magically meaning same.\n (ospf6_lsa_age_current) handle MAXAGE.\n" }, { "commit": "41b2373cece77f0cc9a06fba076c99a7be653593", "tree": "bed11b842b7a33e78e8c5012bf624946aeaf1edc", "parents": [ "bd2462425205a681d75e04c94a94bf4cea5da58b" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 30 16:12:49 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Jun 30 16:12:49 2009 +0100" }, "message": "[lib/cleanup] Use a typedef for the thread type\n\n* lib/thread.{c,h}: As per subject. This will avoid head-scratching for next\n person who adds a thread-type and gets strange breakage.\n" }, { "commit": "bd2462425205a681d75e04c94a94bf4cea5da58b", "tree": "326c2dde485eded444cde3db284aeb7a348892bf", "parents": [ "650f76c2e1b0b12e1c46fdd3be22c5f505245d83" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Jan 05 17:44:46 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 26 16:12:19 2009 +0100" }, "message": "[ospfd] Do not use stale Network/Router LSAs\n\nShould a self originated Network/Router LSA with higher\nLS seq. nr. be received we should flood and install it in\nthe LSDB but we cannot use it for our internal calculations\nas it is stale.\nReorginate an new LSA to replace the stale one as soon\nas possible.\n" }, { "commit": "650f76c2e1b0b12e1c46fdd3be22c5f505245d83", "tree": "43322ab134a9e79ee65ca0300f2106f690b5c925", "parents": [ "439c52f19007badffc6707673121f5a76784e728" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 25 18:06:31 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 26 16:12:19 2009 +0100" }, "message": "[bgpd] Log a debug/update warning if filters are configured but don\u0027t exist\n\n* bgp_route.c: (bgp_{input,output}_filter) Log a debug warning if a route is\n received or sent and a filter name is configured for a prefix, as or\n distribute list but none is found - guaranteed configuration mistake.\n" }, { "commit": "439c52f19007badffc6707673121f5a76784e728", "tree": "2e16cabd2f63de4bfd5eddc24c08b1e1a593f95b", "parents": [ "77a1c4e05ca5a7d7bf07456758f7c934ee867884" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Mon Dec 01 16:25:06 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 25 15:36:39 2009 +0100" }, "message": "Add test for Internet checksum.\n\nAdd 2 impl. of the Internet Checksum. One new optimized nad\none form RFC 1071. Turns out that the current Quagga in_cksum()\nis buggy. On Big Endian routers it miscalculates odd sized buffers.\n" }, { "commit": "77a1c4e05ca5a7d7bf07456758f7c934ee867884", "tree": "47553373b16dd033a0866624dd54b8b851cbdb09", "parents": [ "cbcd9bfc503f08b99f5360b1aae3a5362d25a665" ], "author": { "name": "Joakim Tjernlund", "email": "Joakim.Tjernlund@transmode.se", "time": "Sun Feb 01 11:12:11 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Jun 25 15:36:08 2009 +0100" }, "message": "[ospfd] compare ifIndex too when matching paths\n\nospf_path_lookup(), ospf_route_match_same() and\nospf_ase_route_match_same() needs to\ncompare if the interface matches too.\n" } ], "next": "cbcd9bfc503f08b99f5360b1aae3a5362d25a665" }