)]}' { "log": [ { "commit": "d5e86adf440c26ce1d5558eac3ebda50c506f079", "tree": "c2cfbfc6991e98f5d9c1d74fd2f1a63b63949d9f", "parents": [ "569c0f0188168b79044cc8fcba4639585a3be661" ], "author": { "name": "paul", "email": "paul", "time": "Wed Mar 12 05:40:11 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Mar 12 05:40:11 2003 +0000" }, "message": "Fix memory leak in \u0027show thread cpu\u0027 command.\n" }, { "commit": "ccf3557b9b8b141e76ba0dc57ad9cf3de249674e", "tree": "d63e62051a6b222e1fbecc28fecb55e10b615afe", "parents": [ "89b2cd20a3475655456edf47d77ef0b1dbd9cfd8" ], "author": { "name": "paul", "email": "paul", "time": "Sat Mar 01 11:42:20 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Mar 01 11:42:20 2003 +0000" }, "message": "Sync to Zebra.org 20030301\n" }, { "commit": "4955a0ba4311918f55daf2235df812a99c46ae7c", "tree": "ee48fd62044f3e104886cae65ebafa67bf93fd82", "parents": [ "17b78d38e438bb25d27aa00554ad948a792850aa" ], "author": { "name": "paul", "email": "paul", "time": "Mon Feb 17 23:54:05 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Feb 17 23:54:05 2003 +0000" }, "message": "Revert to zebra.org automake files\n" }, { "commit": "619efcb3d51edf5d144293d08cbc3777655310e4", "tree": "66f692c752ef1e8cc0ec5faa0dd125dc711ca570", "parents": [ "78edbf8f4d3281e579551931ce1876f6d51f79c9" ], "author": { "name": "paul", "email": "paul", "time": "Thu Feb 13 22:03:04 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Feb 13 22:03:04 2003 +0000" }, "message": "Update auto* build files\n" }, { "commit": "9ab6812d1dd27813f3ae01624312edc21c1a0bb6", "tree": "0e74ebe8d75aa0217233de3045240579933395eb", "parents": [ "eda031f6f3558239da5ceb196312ff71aa74fef1" ], "author": { "name": "paul", "email": "paul", "time": "Sat Jan 18 01:16:20 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Jan 18 01:16:20 2003 +0000" }, "message": "This patch adds Yon\u0027s CLI \u0027walk back up tree\u0027 patch. Following are email\ndescribing original patch and a shorter email describing changes to an\nupdated patch, the one which is applied:\n\nFrom havanna_moon@gmx.net Sat Jan 18 00:37:13 2003\nDate: Mon, 9 Dec 2002 05:32:58 +0100 (CET)\nFrom: Yon Uriarte \u003chavanna_moon@gmx.net\u003e\nTo: \"the list(tm) Zebra\" \u003czebra@zebra.org\u003e\nSubject: [zebra 16671] [PATCH] CLI extensions.\n\nHi,\n\n this patch adds 2 improvements to the CLI (lib/command.c):\n\n#1) When in subconfig mode (router XXX, interface XXX, ...) commands that\nfail for that node are tried on the main CONFIG_NODE. This is great for\nconfiguring interfaces or changing the sub-config mode quickly, without\nthe need to type \u0027exit\u0027 between commands:\n\nospfd(config)# int eth1\nospfd(config-if)# ip ospf cost 9\nospfd(config-if)# ip ospf prio 101\nospfd(config-if)# router ospf\nospfd(config-router)# network 1.1.1.0/24 area 51\nospfd(config-router)# int eth2\nospfd(config-if)# ip ospf authentication message-digest\nospfd(config-if)# ^Z\nospfd#\n\n Is this IOS-like or does IOS try to walk up the tree of config sub-modes\ninstead of directly trying the command on CONFIG_NODE?\n\nCAVEATS: \"?\" and \"TAB\" don\u0027t work. IIRC IOS doesnt show that help\nneither.\n\nNON-CAVEATS: This wont break much, as config_from_file() already does\ntry a failed command on the parent node of the actual vty-\u003enode. If\nchanging the code to walk the node tree instead of directly trying\nthe command on the ENABLE_NODE the same semantics would be in use\nand no future bugs could creep in.\n\n#2) When in config or subconfig mode use the \"do \" prefix to execute\ncommans of the ENABLE_NODE. \"?\" and \"TAB\" work. The space after the\n\"do\" is needed:\n\nospfd(config-router)# do\u003c?\u003e\n% There is no matched command.\nospfd(config-router)# do \u003c?\u003e\n clear Reset functions\n configure Configuration from vty interface\n copy Copy configuration\n debug Debugging functions (see also \u0027undebug\u0027)\n disable Turn off privileged mode command\n end End current mode and change to enable mode.\n exit Exit current mode and down to previous mode\n help Description of the interactive help system\n list Print command list\n no Negate a command or set its defaults\n quit Exit current mode and down to previous mode\n show Show running system information\n terminal Set terminal line parameters\n who Display who is on vty\n write Write running configuration to memory, network, or terminal\nospfd(config-router)# do sho\u003cTAB\u003e\nospfd(config-router)# do show me\u003cTAB\u003e\nospfd(config-router)# do show memory r\u003cTAB\u003e\nospfd(config-router)# do show memory rip\nRIP structure : 0\nRIP route info : 0\nRIP interface : 0\nRIP peer : 0\nRIP offset list : 0\nRIP distance : 0\nospfd(config-router)# ^Z\nospfd#\n\n\nCAVEATS: I don\u0027t have access to an IOS with this feature, so I implemented\nit from the comments on this mailing list (in fact my personal motivation\nwas to implement feature #1, which I missed on zebra. But #2 sounded like\na nice one to have, and xemacs was already parked on command.c ...).\nIs this IOS-like or are there differences?\n\n I will happily change this patch to mimick IOS or the mailing-list\nconsensus on CLI-usability.\n\nregards,\n yon\n\nFrom havanna_moon@gmx.net Sat Jan 18 01:13:11 2003\nDate: Sat, 11 Jan 2003 23:36:51 +0100 (CET)\nFrom: Yon Uriarte \u003chavanna_moon@gmx.net\u003e\nTo: zebra@zebra.org\nSubject: [zebra 17218] Re: [PATCH] CLI extensions.\n\nHi,\n\n[redacted]\n\n\u003e I prefer the IOS way for the node \"up walking\".\n\n This patch should walk the tree upwards:\n\nbgpd(config)# router bgp 1\nbgpd(config-router)# address-family ipv4 multicast\nbgpd(config-router-af)# access-list 1 remark hola que tal\nbgpd(config)#\n\n I cant test all combinations, so I cant rule out some bugs. I\u0027d love to\nget (long and explicit) bug reports.\n\n\n[redacted]\n" }, { "commit": "eda031f6f3558239da5ceb196312ff71aa74fef1", "tree": "1c8719ab3e5cbd02166a4e8cc666cf50bdcd09aa", "parents": [ "d7ccae28299c5f56cb65135b59e17a68c6b16cd3" ], "author": { "name": "paul", "email": "paul", "time": "Sat Jan 18 00:39:19 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Jan 18 00:39:19 2003 +0000" }, "message": "Finish off merge off CLI extensions, see below for description. Merge should\nbe off:\n\nFrom havanna_moon@gmx.net Sat Jan 18 00:37:13 2003\nDate: Mon, 9 Dec 2002 05:32:58 +0100 (CET)\nFrom: Yon Uriarte \u003chavanna_moon@gmx.net\u003e\nTo: \"the list(tm) Zebra\" \u003czebra@zebra.org\u003e\nSubject: [zebra 16671] [PATCH] CLI extensions.\n\nHi,\n\n this patch adds 2 improvements to the CLI (lib/command.c):\n\n#1) When in subconfig mode (router XXX, interface XXX, ...) commands that\nfail for that node are tried on the main CONFIG_NODE. This is great for\nconfiguring interfaces or changing the sub-config mode quickly, without\nthe need to type \u0027exit\u0027 between commands:\n\nospfd(config)# int eth1\nospfd(config-if)# ip ospf cost 9\nospfd(config-if)# ip ospf prio 101\nospfd(config-if)# router ospf\nospfd(config-router)# network 1.1.1.0/24 area 51\nospfd(config-router)# int eth2\nospfd(config-if)# ip ospf authentication message-digest\nospfd(config-if)# ^Z\nospfd#\n\n Is this IOS-like or does IOS try to walk up the tree of config sub-modes\ninstead of directly trying the command on CONFIG_NODE?\n\nCAVEATS: \"?\" and \"TAB\" don\u0027t work. IIRC IOS doesnt show that help\nneither.\n\nNON-CAVEATS: This wont break much, as config_from_file() already does\ntry a failed command on the parent node of the actual vty-\u003enode. If\nchanging the code to walk the node tree instead of directly trying\nthe command on the ENABLE_NODE the same semantics would be in use\nand no future bugs could creep in.\n\n#2) When in config or subconfig mode use the \"do \" prefix to execute\ncommans of the ENABLE_NODE. \"?\" and \"TAB\" work. The space after the\n\"do\" is needed:\n\nospfd(config-router)# do\u003c?\u003e\n% There is no matched command.\nospfd(config-router)# do \u003c?\u003e\n clear Reset functions\n configure Configuration from vty interface\n copy Copy configuration\n debug Debugging functions (see also \u0027undebug\u0027)\n disable Turn off privileged mode command\n end End current mode and change to enable mode.\n exit Exit current mode and down to previous mode\n help Description of the interactive help system\n list Print command list\n no Negate a command or set its defaults\n quit Exit current mode and down to previous mode\n show Show running system information\n terminal Set terminal line parameters\n who Display who is on vty\n write Write running configuration to memory, network, or terminal\nospfd(config-router)# do sho\u003cTAB\u003e\nospfd(config-router)# do show me\u003cTAB\u003e\nospfd(config-router)# do show memory r\u003cTAB\u003e\nospfd(config-router)# do show memory rip\nRIP structure : 0\nRIP route info : 0\nRIP interface : 0\nRIP peer : 0\nRIP offset list : 0\nRIP distance : 0\nospfd(config-router)# ^Z\nospfd#\n\n\nCAVEATS: I don\u0027t have access to an IOS with this feature, so I implemented\nit from the comments on this mailing list (in fact my personal motivation\nwas to implement feature #1, which I missed on zebra. But #2 sounded like\na nice one to have, and xemacs was already parked on command.c ...).\nIs this IOS-like or are there differences?\n\n I will happily change this patch to mimick IOS or the mailing-list\nconsensus on CLI-usability.\n\nregards,\n yon\n" }, { "commit": "e04ab74d17b4f3456bd3eeefe2043584431b4ea2", "tree": "154168b7aeb6b4e2fbc1fd04e5f2c96870120272", "parents": [ "a895901b3c4e6a061f56be90f5fe9bc78e6e5c2f" ], "author": { "name": "paul", "email": "paul", "time": "Fri Jan 17 23:47:00 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Jan 17 23:47:00 2003 +0000" }, "message": "From havanna_moon@gmx.net Fri Jan 17 23:37:49 2003\nDate: Sat, 11 Jan 2003 23:26:28 +0100 (CET)\nFrom: Yon Uriarte \u003chavanna_moon@gmx.net\u003e\nTo: \"the list(tm) Zebra\" \u003czebra@zebra.org\u003e\nSubject: [zebra 17217] [PATCH] show thread CPU\n\nHi,\n\n a little patch from the \u0027stupid preprocessor tricks\u0027 collection to record\nthread statistics.\n\nUsage: \"show thread cpu [r][w][t][e][x]\"\n\nOutput Fields: self explaining I hope. Type is one of RWTEX for:\n Read, Write (fd threads), Timer, Event, Execute.\n\n Overhead vs. vanilla zebra: almost nothing. Vanilla CVS zebra already\ncollects thread run times.\n\n\n Caveats: Under linux getrusage has a granularity of 10ms, which is almost\nuseless in this case. Run ./configure, edit config.h and comment out\n\"#define HAVE_RUSAGE\", this way it will use getimeofday which has a much\nbetter granularity. IMHO this is better, as cooperative threads are\neffectively running during all that wall time (dont care if CPU\nutilization was 3% or 99% during the time the thread was running (an\neffective rusage combined with getimeofday could give that info)).\n\n Maybe someone can give tips for other platforms on API granularity.\n\n\nTODO: change some of the calls to thread_add_$KIND to\nfuncname_thread_add_$KIND with a meaningfull funcname, so users will get a\nbetter idea of what\u0027s going on.\n\nF.ex. (AFAIK):\nospf_spf_calculate_timer -\u003e \"Routes Step 1, areas SPF\"\nospf_ase_calculate_timer -\u003e \"Routes Step 2, externals\"\n\n\n\n Could this be added to the unofficial patch collection?\n\nCould someone with BGP keepalive problems run their bgpd with this patch\nand post the results?\n\n\nTIA, HTH, HAND, regards\n yon\n\n\nExample output:\n--------------------------------\nospfd# show thread cpu\n Runtime(ms) Invoked Avg uSecs Max uSecs Type Thread\n 14.829 31 478 585 T ospf_ase_calculate_timer\n 82.132 9838 8 291 EX ospf_nsm_event\n 0.029 1 29 29 E ospf_default_originate_timer\n 0.254 9 28 34 T ospf_db_desc_timer\n 0.026 7 3 11 T ospf_wait_timer\n 669.015 523 1279 490696 R vty_read\n 4.415 45 98 173 TE ospf_network_lsa_refresh_timer\n 15.026 31 484 588 T ospf_spf_calculate_timer\n 29.478 1593 18 122 E ospf_ls_upd_send_queue_event\n 0.173 1 173 173 T vty_timeout\n 4.173 242 17 58 E ospf_ls_ack_send_event\n 637.767 121223 5 55 T ospf_ls_ack_timer\n 39.373 244 161 2691 R zclient_read\n 12.169 98 124 726 EX ospf_ism_event\n 0.226 2 113 125 R vty_accept\n 537.776 14256 37 3813 W ospf_write\n 4.967 41 121 250 T ospf_router_lsa_timer\n 0.672 1 672 672 E zclient_connect\n 7.901 1658 4 26 T ospf_ls_req_timer\n 0.459 2 229 266 E ospf_external_lsa_originate_timer\n 3.203 60 53 305 T ospf_maxage_lsa_remover\n 108.341 9772 11 65 T ospf_ls_upd_timer\n 33.302 525 63 8628 W vty_flush\n 0.101 1 101 101 T ospf_router_lsa_update_timer\n 0.016 1 16 16 T ospf_router_id_update_timer\n 26.970 407 66 176 T ospf_lsa_maxage_walker\n 381.949 12244 31 69 T ospf_hello_timer\n 0.114 22 5 14 T ospf_inactivity_timer\n 34.290 1223 28 310 T ospf_lsa_refresh_walker\n 470.645 6592 71 665 R ospf_read\n 3119.791 180693 17 490696 RWTEX TOTAL\nospfd#\n\nbgpd# sh t c TeX\n Runtime(ms) Invoked Avg uSecs Max uSecs Type Thread\n 21.504 476 45 71 T bgp_keepalive_timer\n 17.784 1157 15 131 T bgp_reuse_timer\n 29.080 193 150 249 T bgp_scan\n 23.606 995 23 420 E bgp_event\n 317.734 28572 11 69 T bgp_routeadv_timer\n 0.084 1 84 84 E zlookup_connect\n 0.526 1 526 526 E zclient_connect\n 1.348 13 103 147 T bgp_start_timer\n 19.443 142 136 420 T bgp_connect_timer\n 16.032 772 20 27 T bgp_import\n 447.141 32322 13 526 TEX TOTAL\nbgpd#\nbgpd# show thread cpu rw\n Runtime(ms) Invoked Avg uSecs Max uSecs Type Thread\n 155.043 7 22149 150659 R bgp_accept\n 129.638 180 720 53844 R vty_read\n 1.734 56 30 129 R zclient_read\n 0.255 2 127 148 R vty_accept\n 58.483 983 59 340 R bgp_read\n 171.495 29190 5 245 W bgp_write\n 13.884 181 76 2542 W vty_flush\n 530.532 30599 17 150659 RW TOTAL\nbgpd#\n--------------------------------\n" }, { "commit": "f2c806522030d4964b4ca649637a7901751d8496", "tree": "0a33c81dbbf280beb2193144b5b39b703f3ca102", "parents": [ "b92938a7364d220f2ca6d77a5722433159520e02" ], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:44:27 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:44:27 2002 +0000" }, "message": " Kevin C Miller \u003ckevinm@andrew.cmu.edu\u003e\n[zebra 16681] OSPF NSSA Patches\n" }, { "commit": "b92938a7364d220f2ca6d77a5722433159520e02", "tree": "084c9f07af5ad9bccf6559b6ed40650027c1a06e", "parents": [ "ab836aab45bb6bea37da3584bb051fc56f1ca827" ], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:20:42 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:20:42 2002 +0000" }, "message": "Yon Uriarte \u003chavanna_moon@gmx.net\u003e\n[zebra 16671] [PATCH] CLI extensions.\n" }, { "commit": "00df0c1e80811f3cf5eca0b28e720bf1bcc84a53", "tree": "d03bbabe82d8526b1f5472d38a59ed24f9c8c42b", "parents": [ "8bd9c714365883e405af7c7c4257e404a1053469" ], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:07:36 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:07:36 2002 +0000" }, "message": "[zebra 14631] Generic PtP and RFC3021 interface addressing support\n" }, { "commit": "2e3b2e474ed5ba04744b167132a84f9954485af4", "tree": "cc07fb34a1bf21ead5cc3ad69e4a9dfde2b43b0e", "parents": [ "7afa08da2d3690baee1739da400775f8543f5863" ], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:03:13 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 21:03:13 2002 +0000" }, "message": "zebra link state detection support\n" }, { "commit": "727d104b15d6293d7223e7830f2e37ae98022cac", "tree": "9ab7e7fecd699f30abc63a5f4612fa9f592db098", "parents": [ "4fc01e67edf1763c9812438effe1d4b1c8b9897b" ], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:50:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:50:29 2002 +0000" }, "message": "Added RIPv1 patch - bug fixes and improved/more interoperable classful\nsubnet handling\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }