)]}' { "log": [ { "commit": "eed3c48d3a7d2dae2cae2f2f250deffb843754a6", "tree": "07b2252438225065024d4a534eddf0e86c9b87a4", "parents": [ "ef008d2f8dc8f7160d8a3d24a15f2fad79ef3242" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Mar 03 08:51:53 2015 +0100" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue Apr 21 10:17:31 2015 +0200" }, "message": "*: use void * for printing pointers\n\nOn higher warning levels, compilers expect %p printf arguments to be\nvoid *. Since format string / argument warnings can be useful\notherwise, let\u0027s get rid of this noise by sprinkling casts to void *\nover printf calls.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "cb4fc59c8a0f9df81109d38acbeaab5627e361f5", "tree": "a82f0bd7bf0d1fd11cdcd52d2dfa7562a64dabcb", "parents": [ "143637198e333f0c822766b38f9d8cfe75c04e21" ], "author": { "name": "Milan Kocian", "email": "milon@wq.cz", "time": "Mon Dec 01 12:48:25 2014 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Feb 06 21:53:53 2015 +0100" }, "message": "bgpd: fix negative values in output\n\nNegative value in output of ecommunities (and as numbers)\nseems odd :-). This patch fixes it. And add minor formating\nmodification, better for big as numbers.\n\nSigned-off-by: Milan Kocian \u003cmilon@wq.cz\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "7aa9dcef80b2ce50ecaa77653d87c8b84e009c49", "tree": "bd4a8d881336a1551146725d7ae06b3e68553e4d", "parents": [ "010ebbbca6396f272cc2d50d147dd922dda68213" ], "author": { "name": "Paul Jakma", "email": "paul@opensourcerouting.org", "time": "Fri Sep 19 14:42:23 2014 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Sep 23 16:32:34 2014 +0100" }, "message": "Fix most compiler warnings in default GCC build.\n\nFix lots of warnings. Some const and type-pun breaks strict-aliasing\nwarnings left but much reduced.\n\n* bgp_advertise.h: (struct bgp_advertise_fifo) is functionally identical to\n (struct fifo), so just use that. Makes it clearer the beginning of\n (struct bgp_advertise) is compatible with with (struct fifo), which seems\n to be enough for gcc.\n Add a BGP_ADV_FIFO_HEAD macro to contain the right cast to try shut up\n type-punning breaks strict aliasing warnings.\n* bgp_packet.c: Use BGP_ADV_FIFO_HEAD.\n (bgp_route_refresh_receive) fix an interesting logic error in\n (!ok || (ret !\u003d BLAH)) where ret is only well-defined if ok.\n* bgp_vty.c: Peer commands should use bgp_vty_return to set their return.\n* jhash.{c,h}: Can take const on * args without adding issues \u0026 fix warnings.\n* libospf.h: LSA sequence numbers use the unsigned range of values, and\n constants need to be set to unsigned, or it causes warnings in ospf6d.\n* md5.h: signedness of caddr_t is implementation specific, change to an\n explicit (uint_8 *), fix sign/unsigned comparison warnings.\n* vty.c: (vty_log_fixed) const on level is well-intentioned, but not going\n to fly given iov_base.\n* workqueue.c: ALL_LIST_ELEMENTS_RO tests for null pointer, which is always\n true for address of static variable. Correct but pointless warning in\n this case, but use a 2nd pointer to shut it up.\n* ospf6_route.h: Add a comment about the use of (struct prefix) to stuff 2\n different 32 bit IDs into in (struct ospf6_route), and the resulting\n type-pun strict-alias breakage warnings this causes. Need to use 2\n different fields to fix that warning?\n\ngeneral:\n\n* remove unused variables, other than a few cases where they serve a\n sufficiently useful documentary purpose (e.g. for code that needs\n fixing), or they\u0027re required dummies. In those cases, try mark them as\n unused.\n* Remove dead code that can\u0027t be reached.\n* Quite a few \u0027no ...\u0027 forms of vty commands take arguments, but do not\n check the argument matches the command being negated. E.g., should\n \u0027distance X \u003cprefix\u003e\u0027 succeed if previously \u0027distance Y \u003cprefix\u003e\u0027 was set?\n Or should it be required that the distance match the previously configured\n distance for the prefix?\n Ultimately, probably better to be strict about this. However, changing\n from slack to strict might expose problems in command aliases and tools.\n* Fix uninitialised use of variables.\n* Fix sign/unsigned comparison warnings by making signedness of types consistent.\n* Mark functions as static where their use is restricted to the same compilation\n unit.\n* Add required headers\n* Move constants defined in headers into code.\n* remove dead, unused functions that have no debug purpose.\n" }, { "commit": "9e7a53c179f6897128b24435452b5d3d0f8c715a", "tree": "80a5cc6e9e6dc411587764d865a2bf5f489000ba", "parents": [ "2aa640bd78b64821bde9a53ecdd1e96e91b20ae4" ], "author": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Thu Apr 24 10:22:37 2014 +0300" }, "committer": { "name": "Timo Teräs", "email": "timo.teras@iki.fi", "time": "Wed Jun 25 21:20:20 2014 +0300" }, "message": "bgpd: implement \"next-hop-self all\"\n\nAs specified in:\nhttp://www.cisco.com/c/en/us/td/docs/ios-xml/ios/iproute_bgp/command/irg-cr-book/bgp-m1.html#wp4972925610\n\nThis allows overriding next-hop for ibgp learned routes on an\nRR for reflected routes.\n\nEspecially useful for using iBGP in DMVPN setups. See:\nhttp://blog.ipspace.net/2014/04/changes-in-ibgp-next-hop-processing.html\n\nSigned-off-by: Timo Teräs \u003ctimo.teras@iki.fi\u003e\n" }, { "commit": "6b0655a25194c7c0331154edaa6124cf783e5e5e", "tree": "c0c7d479f2684531249668210da27a60322ba395", "parents": [ "fdb913aedb5a9807ad60715e8badb4f25d57acea" ], "author": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:53:35 2014 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Wed Jun 04 06:58:02 2014 +0200" }, "message": "*: nuke ^L (page feed)\n\nQuagga sources have inherited a slew of Page Feed (^L, \\xC) characters\nfrom ancient history. Among other things, these break patchwork\u0027s\nXML-RPC API because \\xC is not a valid character in XML documents.\n\nNuke them from high orbit.\n\nPatches can be adapted simply by:\n\tsed -e \u0027s%^L%%\u0027 -i filename.patch\n(you can type page feeds in some environments with Ctrl-V Ctrl-L)\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "5d804b439a4138c77f81de30c64f923e2b5c1340", "tree": "b63e3dc3a266d42311392e57c37e2b0a9855ff0b", "parents": [ "5f9adb5d26d3af31b00c02084468e9f92b461b01" ], "author": { "name": "Pradosh Mohapatra", "email": "pmohapat@cumulusnetworks.com", "time": "Thu Sep 12 03:37:07 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Mon May 19 23:25:46 2014 +0200" }, "message": "bgpd: support TTL-security with iBGP\n\nTraditionally, ttl-security feature has been associated with EBGP\nsessions as those identify directly connected external peers. The\nGTSM RFC (rfc 5082) does not make any restrictions on type of\npeering. In fact, it is beneficial to support ttl-security for both\nEBGP and IBGP sessions. Specifically, in data centers, there are\ndirectly connected IBGP peerings that will benefit from the protection\nttl-security provides.\n\nSigned-off-by: Dinesh G Dutt \u003cddutt@cumulusnetworks.com\u003e\nReviewed-by: Pradosh Mohapatra \u003cpmohapat@cumulusnetworks.com\u003e\n[DL: function refactoring split out into previous 2 patches. changes:\n - bgp_set_socket_ttl(): ret type int -\u003e void\n - is_ebgp_multihop_configured(): stripped peer \u003d\u003d NULL check\n - comments/whitespace]\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "2fdd455cfd1f758b7aa2e6c8e3d185098b93908c", "tree": "3b2d28c7b389228cc6c1e3809660c4f7f22c3f18", "parents": [ "d92a2f39b46f1990052d2db046b47edf7bb21ebb" ], "author": { "name": "Pradosh Mohapatra", "email": "pmohapat@cumulusnetworks.com", "time": "Sat Sep 07 07:02:36 2013 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Thu May 15 19:15:22 2014 +0200" }, "message": "bgpd: add \u0027bgp bestpath as-path multipath-relax\u0027\n\nCompute multipath in BGP based on AS_PATH hop count match. If the knob\nis turned on, it is not required to have an exact match of AS_PATHs\n(provided other multipath conditions are met, of course).\n\nSigned-off-by: Pradosh Mohapatra \u003cpmohapat at cumulusnetworks.com\u003e\nReviewed-by: Dinesh G Dutt \u003cddutt at cumulusnetworks.com\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "9d3f9705d8b386ccf006c106967c700141e5d049", "tree": "9edfe2653741fa0f49ffef15bd66f5a522dcd025", "parents": [ "3b96b78136d04ddb7e39d86577cad75acb25237a" ], "author": { "name": "Andrew Certain", "email": "certain@amazon.com", "time": "Wed Nov 07 23:50:07 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Fri Nov 30 21:10:00 2012 +0100" }, "message": "bgpd: add replace-as modifier for BGP neighbor\n\nAdded replace-as modifier for BGP neighbors when using\nlocal-as. If the replace-as modifier is specified, only the\nreplacement AS as specified by the local-as modifier is\nprepended to the AS_PATH, not the process\u0027s AS.\n\nIn bgp_attr.c, I decided that\n\nif (peer-\u003echange_local_as) {\n /* If replace-as is specified, we only use the change_local_as when\n advertising routes. */\n if( ! CHECK_FLAG (peer-\u003eflags, PEER_FLAG_LOCAL_AS_REPLACE_AS) ) {\n aspath \u003d aspath_add_seq (aspath, peer-\u003elocal_as);\n }\n aspath \u003d aspath_add_seq (aspath, peer-\u003echange_local_as);\n} else {\n aspath \u003d aspath_add_seq (aspath, peer-\u003elocal_as);\n}\n\nwas clearer than the alternative that didn\u0027t duplicate the prepending of the\nprocess\u0027s AS:\n\n/* First, append the process local AS unless we have an alternate local_as\n * and we\u0027re replacing it (as opposed to just prepending it). */\nif (! (peer-\u003echange_local_as\n \u0026\u0026 CHECK_FLAG (peer-\u003eflags, PEER_FLAG_LOCAL_AS_REPLACE_AS) ) ) {\n aspath \u003d aspath_add_seq (aspath, peer-\u003elocal_as);\n}\n\nif (peer-\u003echange_local_as)\n aspath \u003d aspath_add_seq (aspath, peer-\u003echange_local_as);\n}\n\nBut I could be convinced otherwise.\n\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "6d85b15bbb2fd3c263d5d4b402c88ff348af877b", "tree": "c8be5e782f4425840ee93e167eb8d7c1ed3f4e4c", "parents": [ "14542f3edaa43113880e8bb69612c553f02bdf22" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Mon May 07 16:52:54 2012 +0000" }, "committer": { "name": "David Lamparter", "email": "equinox@opensourcerouting.org", "time": "Tue May 22 20:25:10 2012 +0200" }, "message": "bgpd: remove calls to peer_sort() from fast-path\n\n peer_sort() it\u0027s called so much as to be annoying. In the assumption\nthat the \u0027sort\u0027 of the peer doesn\u0027t change during an established session,\nI have changed all calls to peer_sort() in the \u0027fast-path\u0027 to only check\nthe \u0027sort\u0027. All the calls from the vty and such still recalculate the sort\nand store it in the peer.\n\n There\u0027s a lot of other calls to peer_sort() that could be changed but some\nmaube tricky, someone more knowledgeable may try to reduce them.\n\n This hits peer_sort() from 5th out of the stadium^H^H list on a full\ninternet table loading profiling session.\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@opensourcerouting.org\u003e\n" }, { "commit": "c63b83fe8d1addecc949258479b8d54180c4da60", "tree": "fbc58da3014db1cf74a2f8a91a33fe941968815d", "parents": [ "d227617a972bb20a974be68bea5032e692a0970f" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Tue Apr 10 16:57:24 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:27 2012 +0200" }, "message": "bgpd: Fix memory leak of some \"show ip bgp neighbor\" commands\n\nsockunion_str2su() use is prone to memory leaks. Remove it\u0027s use all over\nthe code.\n\nAt least these commands leaked a sockunion union:\n - show ip bgp vpnv4 ... routes\n - show ip bgp ... received prefix-filter\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "ddc943dec3c017583f81cce388c7d453293156c7", "tree": "a36d2bca91b1f3a7545a135b3bafccc40d0ca47b", "parents": [ "8794e8d229dc9fe29ea31424883433d4880ef408" ], "author": { "name": "Jorge Boncompte [DTI2]", "email": "jorge@dti2.net", "time": "Fri Apr 13 13:46:07 2012 +0200" }, "committer": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed May 02 17:03:21 2012 +0200" }, "message": "bgpd, zebra: Fix format for some metric outputs\n\nMetrics are unsigned values.\n\n * bgpd/bgp_{debug,route,vty}.c,\n * zebra/zebra_vty.c: replace %d with %u for metrics \u0026 distances\n\nSigned-off-by: Jorge Boncompte [DTI2] \u003cjorge@dti2.net\u003e\n[reworded commit message]\nSigned-off-by: David Lamparter \u003cequinox@diac24.net\u003e\n" }, { "commit": "3cf6c2b4e43f44a977d218c96c26250654ae333e", "tree": "e017cde2015fbf3ef6c250327428d7c6152aa8f7", "parents": [ "01d7ff0a2166a422c56bd26f04fc22832a9e690b", "e96b312150d8e376c1ef463793d1929eca3618d5" ], "author": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Mon Apr 09 00:25:15 2012 -0700" }, "committer": { "name": "Avneesh Sachdev", "email": "avneesh@opensourcerouting.org", "time": "Mon Apr 09 00:25:15 2012 -0700" }, "message": "Merge branch \u0027quagga\u0027 into google-bgp-multipath\n\nConflicts:\n\tbgpd/bgp_route.c\n" }, { "commit": "e0ca5fde7be5b5ce90dae78c2477e8245aecb8e9", "tree": "0e0b32ddbed4a84a3b2de9dd7217165cb81f52fa", "parents": [ "ebf08631cad8a420fc6bfb7c45af5496dc11023e" ], "author": { "name": "David Lamparter", "email": "equinox@diac24.net", "time": "Wed Sep 16 01:52:42 2009 +0200" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 19:13:17 2011 +0400" }, "message": "lib: put route_types.txt to real use\n\nthis replaces most occurences of routing protocol lists by preprocessor\ndefines from route_types.h. the latter is autogenerated from\nroute_types.txt by a perl script (previously awk). adding a routing\nprotocol now is mostly a matter of changing route_types.txt and log.c.\n\nConflicts:\n\n\tlib/route_types.awk\n" }, { "commit": "bde12e3fd5e498a266e813a5751c1b2d21e46ca5", "tree": "3a3a77cc2321925f3d00d192b994a4440da129a0", "parents": [ "42a7debf3c76b8001ce820e104a29d2f693c7cb7" ], "author": { "name": "Ulrich Weber", "email": "ulrich.weber@sophos.com", "time": "Wed Nov 16 19:32:12 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Dec 13 14:25:25 2011 +0400" }, "message": "bgp: use VTY_GET_INTEGER_RANGE() in bgp_clear()\n\nSecond patch replaces \"VTY_GET_LONG (\"AS\", as_ul, arg);\"\nby \"VTY_GET_INTEGER_RANGE (\"AS\", as, arg, 1, BGP_AS4_MAX);\"\nas done in all other code, which parses AS numbers.\n" }, { "commit": "e6ec1c3648cf3304c1a36341487659aadb9dce95", "tree": "de881144ddce2cdf272a36b0c8e94030b4379b90", "parents": [ "7ccf5e59c13773097dd551b8a7384b99b7f46927" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Sat Sep 10 21:50:53 2011 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Tue Sep 27 21:43:15 2011 +0400" }, "message": "bgpd: spelling\n" }, { "commit": "165b5fff9dde5536d9cb1f850b36c17bf5654f0f", "tree": "b02e2b71e2142348bce920f5c4a7ef5bd4708f3e", "parents": [ "8ced4e82e6f417b13f4bfc09018fc51fd31058e2" ], "author": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:43:22 2011 -0700" }, "committer": { "name": "Josh Bailey", "email": "joshb@google.com", "time": "Wed Jul 20 20:43:22 2011 -0700" }, "message": "bgpd: Add new configuration cli for eBGP and iBGP multipath.\nThere is support to configure this for each (AFI,SAFI), but\ncurrently this configuration is only present for IPv4 unicast:\n\n maximum-paths [ibgp] \u003c1-255\u003e\n no maximum-paths [ibgp] [\u003c1-255\u003e]\n\n* bgpd/Makefile.am\n * Add bgp_mpath.h and bgp_mpath.c to build\n* bgpd/bgp_mpath.h\n * New file for bgp multipath declarations\n * define BGP_DEFAULT_MAXPATHS\n* bgpd/bgp_mpath.c\n * bgp_maximum_paths_set(): Configure maximum paths for the given\n afi, safi and bgp instance\n * bgp_maximum_paths_unset(): Return maximum paths configuration to\n the default setting for the given afi, safi and bgp instance\n* bgpd/bgp_vty.c\n * Define command strings for above CLI\n * bgp_config_write_maxpaths(): Outputs configuration for the given\n afi, safi and bgp instance\n * Install command elements for IPv4 unicast\n* bgpd/bgp_zebra.h\n * bgp_config_write_maxpaths(): External declaration\n* bgpd/bgpd.c\n * bgp_create(): Initialize bgp instance to default maximum paths setting\n * bgp_config_write_family(): Output maximum paths configuration\n for the given address family\n * bgp_config_write(): Output maximum paths configuration for\n IPv4 unicast address family\n* bgpd/bgpd.h\n * struct bgp: Add storage for maximum paths configuration for\n each afi, safi\n" }, { "commit": "f5a4827db60545309d0ee378b85acac56cf7837a", "tree": "a28de765a209f772d1b95b78a357ddf17318844a", "parents": [ "d876bdf4a84f40ac3f9bec8d5040858b3725db3e" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Mar 24 17:30:21 2011 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 28 11:27:41 2011 +0100" }, "message": "bgpd: refine the setting up of GTSM\n\n* bgpd.h: Add error code for setting GTSM on iBGP\n* bgpd.c: (peer_ttl_security_hops_set) use previous error code and signal\n incompatibility of GTSM+iBGP to vty.\n Consider the session state when setting GTSM, and reset Open/Active peers\n to let them pick up new TTL from start.\n" }, { "commit": "89b6d1f8e2759cc38bc768067abe3a296d93f454", "tree": "ebf4d27f1d93558bba8d0bf6f1022182f7066404", "parents": [ "fa411a212b55bba650d68fd0456686f3e47b7395" ], "author": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Thu Mar 24 10:51:59 2011 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Mar 24 10:51:59 2011 +0000" }, "message": "bgpd: Cleanups \u0026 fixes for minttl / GTSM\n\n* bgp_vty.c: (peer_ebgp_multihop_{un,}set_vty) tail-call cleanup.\n ({no_,}neighbor_ttl_security) ditto.\n* bgpd.c: (peer_ttl_security_hops_set) Peer group checks and TTL set only\n need to be done on transition.\n* sockunion.c: (sockopt_minttl) remove always-on debug and improve readability.\n" }, { "commit": "fa411a212b55bba650d68fd0456686f3e47b7395", "tree": "4d7ef846c2cbc154631a5901747b3384854d497c", "parents": [ "db07ad7358cb5e26358326332629ffb658f5747a" ], "author": { "name": "Nick Hilliard", "email": "nick@inex.ie", "time": "Wed Mar 23 15:33:17 2011 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Wed Mar 23 15:33:17 2011 +0000" }, "message": "bgpd: RFC 5082 Generalized TTL Security Mechanism support\n\n* bgpd: Add support for RFC 5082 GTSM, which allows the TTL field to be used\n to verify that incoming packets have been sent from neighbours no more\n than X IP hops away. In other words, this allows packets that were sent from\n further away (i.e. not by the neighbour with known distance, and so possibly\n a miscreant) to be filtered out.\n* lib/sockunion.{c,h}: (sockopt_minttl) new function, to set a minimum TTL\n using the IP_MINTTL socket opt.\n* bgpd.h: (BGP_ERR_NO_EBGP_MULTIHOP_WITH_TTLHACK) define for command\n error for minttl.\n (struct peer) add a config variable, to store the configured minttl.\n (peer_ttl_security_hops_{set,unset}) configuration handlers\n* bgpd.c: (peer_group_get) init gtsm_hops\n (peer_ebgp_multihop_{un,}set) check for conflicts with GTSM. Multihop and\n GTSM can\u0027t both be active for a peer at the same time.\n (peer_ttl_security_hops_set) set minttl, taking care to avoid conflicts with\n ebgp_multihop.\n (bgp_config_write_peer) write out minttl as \"neighbor .. ttl-security hops X\".\n* bgp_vty.c: (bgp_vty_return) message for\n BGP_ERR_NO_EBGP_MULTIHOP_WITH_TTLHACK\n (peer_ebgp_multihop_{un,}set_vty)\n* bgp_network.c: (bgp_accept) set minttl on accepted sockets if appropriate.\n (bgp_connect) ditto for outbound.\n" }, { "commit": "95cbbd2ace2f88019a7a54e67b4b12aaeda177f7", "tree": "b3a43ef5d9da20802df0dba9c72814354eb84267", "parents": [ "d8509631b47aba867c59eb463bb346d7ae5b91c7" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Fri Jul 23 14:43:04 2010 -0400" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Mar 21 17:30:52 2011 +0000" }, "message": "bgpd: New show commands for improved view and address family support\n\nMany show commands do not have support for multiple views and do not\ntreat different address families uniformly. The following changes add\na number of commands with support for views and rationalized treatment\nof IPv4 v IPv6 and unicast v multicast (such as in JUNOS, IOS XR and\nmore recent versions of IOS).\n\n* bgp_route.c: (bgp_show_community) Inserted a new second argument (the\n name of the view) and the code to look up that name in the BGP structure.\n The NULL argument in the call to bgp_show (indicating the default view)\n was replaced by the specified view. The existing calls to\n bgp_show_community had a NULL second argument inserted to make clear\n that they refer to the default view.\n\n (top level) Added new functions via the DEFUN and/or ALIAS macros (and\n the associated command table entries) to add the commands\n\n show bgp ipv4 (unicast|multicast)\n show bgp ipv4 (unicast|multicast) A.B.C.D\n show bgp ipv4 (unicast|multicast) A.B.C.D/M\n show bgp ipv6 (unicast|multicast)\n show bgp ipv6 (unicast|multicast) X:X::X:X\n show bgp ipv6 (unicast|multicast) X:X::X:X/M\n\n These show either the full BGP table or the specified route or\n prefix for the given address family.\n\n show bgp view WORD (ipv4|ipv6) (unicast|multicast) community\n show bgp view WORD (ipv4|ipv6) (unicast|multicast) community \\\n (AA:NN|local-AS|no-advertise|no-export){1,4}\n\n For the specified view and address family, these show entries\n matching any community or the specified communit(y)(ies).\n\n show bgp view WORD (ipv4|ipv6) (unicast|multicast) neighbors \\\n (A.B.C.D|X:X::X:X) (advertised-routes|received-routes)\n\n For the specified view and address family, show the routes\n advertised to or received from the given BGP neighbor.\n\n show bgp [view WORD] ipv4 (unicast|multicast) \\\n rsclient (A.B.C.D|X:X::X:X)\n show bgp [view WORD] ipv4 (unicast|multicast) \\\n rsclient (A.B.C.D|X:X::X:X) A.B.C.D\n show bgp [view WORD] ipv4 (unicast|multicast) \\\n rsclient (A.B.C.D|X:X::X:X) A.B.C.D/M\n show bgp [view WORD] ipv6 (unicast|multicast) \\\n rsclient (A.B.C.D|X:X::X:X)\n show bgp [view WORD] ipv6 (unicast|multicast) \\\n rsclient (A.B.C.D|X:X::X:X) X:X::X:X\n show bgp [view WORD] ipv6 (unicast|multicast) \\\n rsclient (A.B.C.D|X:X::X:X) X:X::X:X/M\n\n For the specifed (optional) view and address family, show either\n the full BGP table or the specified route or prefix for the given\n route server client peer.\n\n* bgp_vty.c: (top level) Added new functions via the DEFUN and/or ALIAS\n macros (and the associated command table entries) to add the commands\n\n show bgp [view WORD] (ipv4|ipv6) (unicast|multicast) summary\n show bgp [view WORD] (ipv4|ipv6) (unicast|multicast) rsclient summary\n\n For the specified (optional) view and address family, display\n either the normal summary table for BGP peers, or the route server\n client table showing the import and export policies.\n" }, { "commit": "b729294c8c5c6f2af8ddf6cfbea2374b6faabe9d", "tree": "a259da6db36b4174f35a638a9db10b2508d2b62c", "parents": [ "5195e17f8b49dc720252526a21afd7840240137b" ], "author": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 08 18:51:37 2010 +0300" }, "committer": { "name": "Denis Ovsienko", "email": "infrastation@yandex.ru", "time": "Wed Dec 08 18:51:37 2010 +0300" }, "message": "bgpd: fix community-list error message spelling\n\n* bgp_vty.c: (community_list_perror, show_ip_community_list_arg,\n show_ip_extcommunity_list_arg) fix spelling\n" }, { "commit": "9a1a331d63ae9db1912a1edb48c5c176454562f8", "tree": "d6da5f9ce7e6760f59a7fda7ceeb89877a3148c5", "parents": [ "5b40b1b57e1fad1caf579e032adf4e111128e486" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jul 27 12:27:55 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jul 27 12:27:55 2009 +0100" }, "message": "[bgpd] Restore ability of \u0027neighbor ... update-source\u0027 to take interface name\n\n* bgp_vty.c: (BGP_UPDATE_SOURCE_STR) Restore ability to accept arbitrary\n interface names for the \u0027neighbor ... update-source\u0027 command - shouldn\u0027t\n have been deleted.\n (BGP_UPDATE_SOURCE_STR) Add help for same.\n" }, { "commit": "228da42898c4f7bd72d9c1ee4135108e8d40d860", "tree": "a780ed018bfeb97c174958f188c770c74a48bad9", "parents": [ "54a15182e05ca757db3bb90a4135e9f8fd3c84f2" ], "author": { "name": "Chris Caputo", "email": "ccaputo@alt.net", "time": "Sat Jul 18 05:44:03 2009 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Jul 19 18:28:08 2009 +0100" }, "message": "[bgpd] Stability fixes including bugs 397, 492\n\nI\u0027ve spent the last several weeks working on stability fixes to bgpd.\nThese patches fix all of the numerous crashes, assertion failures, memory\nleaks and memory stomping I could find. Valgrind was used extensively.\n\nAdded new function bgp_exit() to help catch problems. If \"debug bgp\" is\nconfigured and bgpd exits with status of 0, statistics on remaining\nlib/memory.c allocations are printed to stderr. It is my hope that other\ndevelopers will use this to stay on top of memory issues.\n\nExample questionable exit:\n\n bgpd: memstats: Current memory utilization in module LIB:\n bgpd: memstats: Link List : 6\n bgpd: memstats: Link Node : 5\n bgpd: memstats: Hash : 8\n bgpd: memstats: Hash Bucket : 2\n bgpd: memstats: Hash Index : 8\n bgpd: memstats: Work queue : 3\n bgpd: memstats: Work queue item : 2\n bgpd: memstats: Work queue name string : 3\n bgpd: memstats: Current memory utilization in module BGP:\n bgpd: memstats: BGP instance : 1\n bgpd: memstats: BGP peer : 1\n bgpd: memstats: BGP peer hostname : 1\n bgpd: memstats: BGP attribute : 1\n bgpd: memstats: BGP extra attributes : 1\n bgpd: memstats: BGP aspath : 1\n bgpd: memstats: BGP aspath str : 1\n bgpd: memstats: BGP table : 24\n bgpd: memstats: BGP node : 1\n bgpd: memstats: BGP route : 1\n bgpd: memstats: BGP synchronise : 8\n bgpd: memstats: BGP Process queue : 1\n bgpd: memstats: BGP node clear queue : 1\n bgpd: memstats: NOTE: If configuration exists, utilization may be expected.\n\nExample clean exit:\n\n bgpd: memstats: No remaining tracked memory utilization.\n\nThis patch fixes bug #397: \"Invalid free in bgp_announce_check()\".\n\nThis patch fixes bug #492: \"SIGBUS in bgpd/bgp_route.c:\nbgp_clear_route_node()\".\n\nMy apologies for not separating out these changes into individual patches.\nThe complexity of doing so boggled what is left of my brain. I hope this\nis all still useful to the community.\n\nThis code has been production tested, in non-route-server-client mode, on\na linux 32-bit box and a 64-bit box.\n\nRelease/reset functions, used by bgp_exit(), added to:\n\n bgpd/bgp_attr.c,h\n bgpd/bgp_community.c,h\n bgpd/bgp_dump.c,h\n bgpd/bgp_ecommunity.c,h\n bgpd/bgp_filter.c,h\n bgpd/bgp_nexthop.c,h\n bgpd/bgp_route.c,h\n lib/routemap.c,h\n\nFile by file analysis:\n\n* bgpd/bgp_aspath.c: Prevent re-use of ashash after it is released.\n\n* bgpd/bgp_attr.c: #if removed uncalled cluster_dup().\n\n* bgpd/bgp_clist.c,h: Allow community_list_terminate() to be called from\n bgp_exit().\n\n* bgpd/bgp_filter.c: Fix aslist-\u003ename use without allocation check, and\n also fix memory leak.\n\n* bgpd/bgp_main.c: Created bgp_exit() exit routine. This function frees\n allocations made as part of bgpd initialization and, to some extent,\n configuration. If \"debug bgp\" is configured, memory stats are printed\n as described above.\n\n* bgpd/bgp_nexthop.c: zclient_new() already allocates stream for\n ibuf/obuf, so bgp_scan_init() shouldn\u0027t do it too. Also, made it so\n zlookup is global so bgp_exit() can use it.\n\n* bgpd/bgp_packet.c: bgp_capability_msg_parse() call to bgp_clear_route()\n adjusted to use new BGP_CLEAR_ROUTE_NORMAL flag.\n\n* bgpd/bgp_route.h: Correct reference counter \"lock\" to be signed.\n bgp_clear_route() now accepts a bgp_clear_route_type of either\n BGP_CLEAR_ROUTE_NORMAL or BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n* bgpd/bgp_route.c:\n - bgp_process_rsclient(): attr was being zero\u0027ed and then\n bgp_attr_extra_free() was being called with it, even though it was\n never filled with valid data.\n\n - bgp_process_rsclient(): Make sure rsclient-\u003egroup is not NULL before\n use.\n\n - bgp_processq_del(): Add call to bgp_table_unlock().\n\n - bgp_process(): Add call to bgp_table_lock().\n\n - bgp_update_rsclient(): memset clearing of new_attr not needed since\n declarationw with \"\u003d { 0 }\" does it. memset was already commented\n out.\n\n - bgp_update_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_withdraw_rsclient(): Fix screwed up misleading indentation.\n\n - bgp_clear_route_node(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_node_queue_del(): Add call to bgp_table_unlock() and also\n free struct bgp_clear_node_queue used for work item.\n\n - bgp_clear_node_complete(): Do peer_unlock() after BGP_EVENT_ADD() in\n case peer is released by peer_unlock() call.\n\n - bgp_clear_route_table(): Support BGP_CLEAR_ROUTE_MY_RSCLIENT. Use\n struct bgp_clear_node_queue to supply data to worker. Add call to\n bgp_table_lock().\n\n - bgp_clear_route(): Add support for BGP_CLEAR_ROUTE_NORMAL or\n BGP_CLEAR_ROUTE_MY_RSCLIENT.\n\n - bgp_clear_route_all(): Use BGP_CLEAR_ROUTE_NORMAL.\n\n Bug 397 fixes:\n\n - bgp_default_originate()\n - bgp_announce_table()\n\n* bgpd/bgp_table.h:\n - struct bgp_table: Added reference count. Changed type of owner to be\n \"struct peer *\" rather than \"void *\".\n\n - struct bgp_node: Correct reference counter \"lock\" to be signed.\n\n* bgpd/bgp_table.c:\n - Added bgp_table reference counting.\n\n - bgp_table_free(): Fixed cleanup code. Call peer_unlock() on owner if\n set.\n\n - bgp_unlock_node(): Added assertion.\n\n - bgp_node_get(): Added call to bgp_lock_node() to code path that it was\n missing from.\n\n* bgpd/bgp_vty.c:\n - peer_rsclient_set_vty(): Call peer_lock() as part of peer assignment\n to owner. Handle failure gracefully.\n\n - peer_rsclient_unset_vty(): Add call to bgp_clear_route() with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n* bgpd/bgp_zebra.c: Made it so zclient is global so bgp_exit() can use it.\n\n* bgpd/bgpd.c:\n - peer_lock(): Allow to be called when status is \"Deleted\".\n\n - peer_deactivate(): Supply BGP_CLEAR_ROUTE_NORMAL purpose to\n bgp_clear_route() call.\n\n - peer_delete(): Common variable listnode pn. Fix bug in which rsclient\n was only dealt with if not part of a peer group. Call\n bgp_clear_route() for rsclient, if appropriate, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - peer_group_get(): Use XSTRDUP() instead of strdup() for conf-\u003ehost.\n\n - peer_group_bind(): Call bgp_clear_route() for rsclient, and do so with\n BGP_CLEAR_ROUTE_MY_RSCLIENT purpose.\n\n - bgp_create(): Use XSTRDUP() instead of strdup() for peer_self-\u003ehost.\n\n - bgp_delete(): Delete peers before groups, rather than after. And then\n rather than deleting rsclients, verify that there are none at this\n point.\n\n - bgp_unlock(): Add assertion.\n\n - bgp_free(): Call bgp_table_finish() rather than doing XFREE() itself.\n\n* lib/command.c,h: Compiler warning fixes. Add cmd_terminate(). Fixed\n massive leak in install_element() in which cmd_make_descvec() was being\n called more than once for the same cmd-\u003estrvec/string/doc.\n\n* lib/log.c: Make closezlog() check fp before calling fclose().\n\n* lib/memory.c: Catch when alloc count goes negative by using signed\n counts. Correct #endif comment. Add log_memstats_stderr().\n\n* lib/memory.h: Add log_memstats_stderr().\n\n* lib/thread.c: thread-\u003efuncname was being accessed in thread_call() after\n it had been freed. Rearranged things so that thread_call() frees\n funcname. Also made it so thread_master_free() cleans up cpu_record.\n\n* lib/vty.c,h: Use global command_cr. Add vty_terminate().\n\n* lib/zclient.c,h: Re-enable zclient_free().\n" }, { "commit": "f7e0db80693aea7f5fd3d8d4f00e97347c8d0ba5", "tree": "b920d5309513724158ea477ae2c8b33190287e53", "parents": [ "c514adc61d56c3fb6fe5119a7b4b55c79a9c065d" ], "author": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jun 22 11:30:47 2009 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Mon Jun 22 11:30:47 2009 +0100" }, "message": "[bgpd] Fix \u0027update-source\u0027 command: It doesn\u0027t accept interface names\n\n* bgp_vty.c: BGP_UPDATE_SOURCE_STR define should only specify IP addresses,\n the underlying mechanisms won\u0027t do anything useful with interface names.\n Fix bug #527.\n" }, { "commit": "7fc626de5f618133ad2a478d13defa3a110b89ea", "tree": "432ff0e4672eabc2ec6b0dcffc22dcc0aee532c8", "parents": [ "66e5cd87194ae6fdd51061a91b4698bc0a652f6b" ], "author": { "name": "Stephen Hemminger", "email": "stephen.hemminger@vyatta.com", "time": "Mon Dec 01 11:10:34 2008 -0800" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Jun 12 17:10:29 2009 +0100" }, "message": "[cleanup] Make command nodes static\n\nThe cmd_nodes used to configure vty, can mostly be static so\n(basic data hiding 101).\n" }, { "commit": "aea339f72807c34a7916d8614e030069815e144c", "tree": "7b0ab93dcfec82736f05ac39106096360e4ceeb5", "parents": [ "c540835eaf0cb59921969537d8e94cc83bb717f5" ], "author": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "committer": { "name": "Denis Ovsienko", "email": "pilot@etcnet.org", "time": "Thu Apr 30 17:16:22 2009 +0400" }, "message": "[bgpd] AS4 bugfix by Chris Caputo \u003cccaputo@alt.net\u003e\n\n* bgpd/bgp_aspath.c: (aspath_make_str_count) \"assert (len \u003c str_size)\" was\n getting hit under certain 4-byte ASN conditions. New realloc strategy.\n* bgpd/bgp_aspath.c: (aspath_key_make) const warning fix.\n\n\"%d\" -\u003e \"%u\" 4-byte ASN corrections. Prevent negative number when ASN is\nabove 2^31.\n" }, { "commit": "e0081f70ede76bc7a3db53eaab3e45ba657cc4d3", "tree": "27e143772053a699d10671832e3c7d989ee85392", "parents": [ "5d4b8cf2faba9f5386810a7c70837e5b7fae3572" ], "author": { "name": "Michael Lambert", "email": "lambert@psc.edu", "time": "Sun Nov 16 20:12:04 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sun Nov 16 20:12:04 2008 +0000" }, "message": "[bgpd] Add \u0027show bgp views\u0027 command\n\n* bgp_vty.c: (show_bgp_views_cmd) new command to list all defined\n views.\n (with small edits by Paul Jakma)\n\nSigned-off-by: Paul Jakma \u003cpaul@quagga.net\u003e\n" }, { "commit": "ef16c8a2abd39b14fed45665eda5c293b93ee54b", "tree": "3e8a386296fcc36ec3ffef6ebbf38da36c7cfdcf", "parents": [ "b3bc68e5a4eecd85138463ae5742c2ccaa1db4bb", "62687ff1cd3d4460cdbd4b0fbf1e3298fe277ad2" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 04 13:52:38 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Thu Sep 04 13:52:38 2008 +0100" }, "message": "Merge branch \u0027restricted-mode\u0027\n" }, { "commit": "6556d8a04079eb54d1805df3bef3e66ff1267d02", "tree": "35b35c8f7fbad9e6622ab8adfd9f5d71e2cfc541", "parents": [ "b38309a4ee831a440ef78f8a27db584f2f8e8276" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Aug 26 14:33:28 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Tue Aug 26 14:33:28 2008 +0100" }, "message": "Revert \"[bgpd] Add \u0027bgp open-accept\u0027 option, to send OPEN immediately on accepted conns\"\n\nRevert commit d664ae1182c29b74b409bc8594b7bd0575e91ce9. An experimental\npatch which violates RFC4271 quite badly, but managed to accidently sneak\nits way in.\n" }, { "commit": "62687ff1cd3d4460cdbd4b0fbf1e3298fe277ad2", "tree": "6bea5c1cf07d9d702c95fabe356fcec418b91398", "parents": [ "b38309a4ee831a440ef78f8a27db584f2f8e8276" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sat Aug 23 14:27:06 2008 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Sat Aug 23 14:27:06 2008 +0100" }, "message": "[vty] Add support for a \u0027restricted mode\u0027 with anonymous vty connections\n\n\t* lib/command.h: Add a RESTRICTED_NODE, intended for use with\n\t anonymous, \u0027no login\u0027 vtys, to provide a subset of \u0027view\u0027 mode\n\t commands.\n\t* lib/command.c: Add RESTRICTED_NODE bits, nothing special, just\n\t following VIEW_NODE.\n\t* lib/vty.c: (vty_auth) enable authentication should fall back to\n\t restricted/view node as appropriate.\n\t (vty_create) init vty\u0027s to restricted/view node as appropriate,\n\t for the \u0027no login\u0027 case.\n\t (vty_{no_,}restricted_mode_cmd) config commands to enable\n\t \u0027anonymous restricted\u0027 in vty configuration.\n\t (vty_config_write) \u0027anonymous restricted\u0027 config.\n\t (vty_init) Install some commands to restricted mode, and the\n\t \u0027anonymous restricted\u0027 config commands into VTY_NODE.\n\t* bgpd/*.c: Install some of the safe(r) BGP commands into\n\t \u0027restricted mode\u0027, i.e. lookup commands of non-sensitive data.\n\t Useful with looking-glass route-servers.\n" }, { "commit": "d664ae1182c29b74b409bc8594b7bd0575e91ce9", "tree": "dd7c7edf880483e1deade4e0c26e3844cd78a79e", "parents": [ "e30db001530a39b827cc4f073033e35d9ca22662" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri Aug 31 14:27:37 2007 +0100" }, "committer": { "name": "Paul Jakma", "email": "paul@quagga.net", "time": "Fri Aug 22 19:52:12 2008 +0100" }, "message": "[bgpd] Add \u0027bgp open-accept\u0027 option, to send OPEN immediately on accepted conns\n\n2007-08-31 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Add \u0027bgp open-accept\u0027 option, to allow bgpd to send OPEN\n\t on accepted connections, i.e. to not wait till after\n\t collision-detect to send OPEN, which appears to be allowed in\n\t RFC4271. This may help speed up establishing sessions, or help\n\t avoid FSM problems with sessions to certain peers. Not enabled by\n\t default though.\n" }, { "commit": "0df7c91f048f2116610d6bdfce3ab6cad1981802", "tree": "18390aa845054b757fae86dde49b907ee7f14908", "parents": [ "f04b0e6bb8c1339243717b156880d7e24c84c951" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Jul 21 21:02:49 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Jul 21 21:02:49 2008 +0000" }, "message": "[bgpd] TCP-MD5: password vty configuration and initial Linux support\n\n2008-07-21 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_packet.c: (bgp_open_receive) fix warning in a zlog call\n\t* bgp_vty.c: (bgp_vty_return) add return code\n\t* bgpd.c: (bgp_master_init) setup the socket list.\n\t* bgp_network.c: Remove the dual IPv4/6 socket thing for now, which\n\t was implemented by Michael, until such time as its clear its\n\t required for Linux (see sockopt comments). IPv6 support, including\n\t IPv4 sessions on AF_INET6 sockets, therefore is broken, and the\n\t \u0027-l 0.0.0.0\u0027 arguments would need to be given to bgpd to make\n\t things work here.\n\n2008-07-21 Michael H. Warfield \u003cmhw@wittsend.com\u003e\n YOSHIFUJI Hideaki \u003cyoshfuji@linux-ipv6.org\u003e\n\t Tomohiko Kusuda \u003ckusuda@inetcore.com\u003e\n Leigh Brown \u003cleigh@solinno.co.uk\u003e\n\n\t* bgp_network.c: (bgp_md5_set_one) shim between libzebra tcp-md5\n\t sockopt and bgpd.\n\t (bgp_md5_set_socket) Helper for bgp_connect\n\t (bgp_md5_set) setup TCP-MD5SIG for the given peer.\n\t (bgp_connect) call out to bgp_md5_set_socket for the outgoing\n\t connect socket.\n\t (bgp_socket) save references to the listen sockets, needed if\n\t TCP-MD5SIG is applied later or changed.\n\t* bgp_vty.c: (*neighbor_password_cmd) New \u0027neighbor ... password\u0027\n\t commands.\n\t* bgpd.c: (peer_{new,delete) manage TCP-MD5 password\n\t (peer_group2peer_config_copy) inherit TCP-MD5 password\n\t (peer_password_{un,}set) orchestrate the whole add/remove of TCP-MD5\n\t passwords: applying checks, stopping peers, and trying to return\n\t errors to UI, etc.\n\t (bgp_config_write_peer) save password.\n\t Fix missing newline in writeout of neighbor ... port.\n\n2008-07-21 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* sockunion.c: ifdef out various places that converted\n\t v4mapped sockets to pure v4. Doesn\u0027t seem necessary at all,\n\t presumably a workaround for now historical inet_ntop bugs (?)\n\n2008-07-21 Michael H. Warfield \u003cmhw@wittsend.com\u003e\n YOSHIFUJI Hideaki \u003cyoshfuji@linux-ipv6.org\u003e\n\n\t* sockopt.{c,h}: (sockopt_tcp_signature) Add TCP-MD5SIG support.\n" }, { "commit": "320da874d75acb7d0cb69c531ee6255e63fe0336", "tree": "063cceec70b3d71ef65a957956088f06d6b5bbe5", "parents": [ "b608d5b5ac469d47072aedd573e5d3475f4d9cf4" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 02 13:40:33 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 02 13:40:33 2008 +0000" }, "message": "[vty] CMD_AS_RANGE accidently quoted and so not expanded in vty\n\n2008-07-02 MIYAJIMA Mitsuharu \u003cmiyajima.mitsuharu@anchor.jp\u003e\n\n\t* *.c: CMD_AS_RANGE was being used inside command strings, and thus\n\t not being expanded, fix by dequoting.\n" }, { "commit": "b608d5b5ac469d47072aedd573e5d3475f4d9cf4", "tree": "a6e130a1dee11accfbffffd154c592d49e4312dc", "parents": [ "0b3f3d47b21ddf175bfdd549ba33fbcd34801244" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 02 02:12:07 2008 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Wed Jul 02 02:12:07 2008 +0000" }, "message": "[bgpd] Fix double-free crash in bgp_table_finish, seen with rs-client\n\n2008-07-02 Stephen Hemminger \u003cstephen.hemminger@vyatta.com\u003e\n\n\t* bgp_table.{c,h}: (bgp_table_finish) Take a double pointer and\n\t scrub pointer in caller, so fixing double-free crashes seen\n\t with route-server-client configuration.\n\t* *.c: Adjust all callers of bgp_table_finish\n\n2008-07-02 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_table.{c,h}: (bgp_node_delete, bgp_table_free) shouldn\u0027t be\n\t exported.\n" }, { "commit": "0b2aa3a0a8b095bdef1eddda117d173af75dede2", "tree": "29201cb2beec187409e842b4078ed8a8047d3f11", "parents": [ "7593fddfa1558d086e3142ad96cf2790007f5d84" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Sun Oct 14 22:32:21 2007 +0000" }, "message": "[bgpd] Merge AS4 support\n\n2007-10-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* NEWS: Note that MRT dumps are now version 2\n\t* (general) Merge in Juergen Kammer\u0027s AS4 patch.\n\n2007-09-27 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_aspath.c: (assegment_normalise) remove duplicates from\n\t from sets.\n\t (aspath_reconcile_as4) disregard a broken part of the RFC around\n\t error handling in path reconciliation.\n\t* aspath_test.c: Test dupe-weeding from sets.\n\t Test that reconciliation merges AS_PATH and AS4_PATH where\n\t former is shorter than latter.\n\n2007-09-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* aspath_test.c: Test AS4_PATH reconcilation where length\n\t of AS_PATH and AS4_PATH is same.\n\n2007-09-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (peek_for_as4_capability) Fix to work.\n\t* bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.\n\t* tests/bgp_capability_test.c: (general) Extend tests to validate\n\t peek_for_as4_capability.\n\t Add test of full OPEN Option block, with multiple capabilities,\n\t both as a series of Option, and a single option.\n\t Add some crap to beginning of stream, to prevent code depending\n\t on getp \u003d\u003d 0.\n\n2007-09-18 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_open.c: (bgp_capability_as4) debug printf inline with others.\n\t (peek_for_as4_capability) There\u0027s no need to signal failure, as\n\t failure is better dealt with through full capability parser -\n\t just return the AS4, simpler.\n\t* bgp_packet.c: (bgp_open_receive) Update to match\n\t peek_for_as4_capability change.\n\t Allow use of BGP_AS_TRANS by 2b speakers.\n\t Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.\n\t (bgp_capability_msg_parse) missing argument to debug print\n\t (bgp_capability_receive) missing return values.\n\t* tests/bgp_capability_test.c: (parse_test) update for changes to\n\t peek_for_as4_capability\n\n2007-07-25 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* Remove 2-byte size macros, just make existing macros take\n\t argument to indicate which size to use.\n\t Adjust all users - typically they want \u00271\u0027.\n\t* bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any\n\t as4\u0027s in a path.\n\t (aspath_put) Return the number of bytes actually written, to\n\t fix the bug Juergen noted: Splitting of segments will change\n\t the number of bytes written from that already written to the\n\t AS_PATH header.\n\t (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP\n\t is still defined as 2b.\n\t (aspath_aggregate) fix latent bug.\n\t (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation\n\t function.\n\t (aspath_key_make) Hash the AS_PATH string, rather than\n\t just taking the addition of assegment ASes as the hash value,\n\t hopefully sligthly more collision resistant.\n\t (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes\n\t together with the OLD 2-byte forms, code Juergen\n\t had in bgp_attr_parse but re-organised a bit.\n\t (bgp_attr_parse) Bunch of code from Juergen moves\n\t to previous function.\n\t (bgp_packet_attribute) Compact significantly by\n\t just /always/ using extended-length attr header.\n\t Fix bug Juergen noted, by using aspath_put\u0027s\n\t (new) returned size value for the attr header rather\n\t than the (guesstimate) of aspath_size() - the two could\n\t differ when aspath_put had to split large segments, unlikely\n\t this bug was ever hit in the \u0027wild\u0027.\n\t (bgp_dump_routes_attr) Always use extended-len and\n\t use aspath_put return for header length. Output 4b ASN\n\t for AS_PATH and AGGREGATOR.\n\t* bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix\n\t hash callback declarations to match prototypes.\n\t (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,\n\t complete rewrite of Juergen\u0027s changes (no asdot support)\n\t* bgp_open.c: (bgp_capability_as4) New, does what it says\n\t on the tin.\n\t (peek_for_as4_capability) Rewritten to use streams and\n\t bgp_capability_as4.\n\t* bgp_packet.c: (bgp_open_send) minor edit\n\t checked (in the abstract at least) with Juergen.\n\t Changes are to be more accepting, e.g, allow AS_TRANS on\n\t a 2-byte session.\n\t* (general) Update all commands to use CMD_AS_RANGE.\n\t* bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..\n\t Remove stuff replicated by VTY_GET_LONG\n\t (bgp_clear_vty) Return bgp_clear directly to vty.\n\t* tests/aspath_test.c: Exercise 32bit parsing. Test reconcile\n\t function.\n\t* tests/ecommunity_test.c: New, test AS4 ecommunity changes,\n\t positive test only at this time, error cases not tested yet.\n\n2007-07-25 Juergen Kammer \u003cj.kammer@eurodata.de\u003e\n\n\t* (general) AS4 support.\n\t* bgpd.h: as_t changes to 4-bytes.\n\t* bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.\n\t* bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE\n\t added for 2-byte.\n\t Add AS16 versions of length calc macros.\n\t (aspath_count_numas) New, count number of ASes.\n\t (aspath_has_as4) New, return 1 if there are any as4\u0027s in a\n\t path.\n\t (assegments_parse) Interpret assegment as 4 or 2 byte,\n\t according to how the caller instructs us, with a new\n\t argument.\n\t (aspath_parse) Add use32bit argument to pass to\n\t assegments_parse. Adjust all its callers to pass 1, unless\n\t otherwise noted.\n\t (assegment_data_put) Adjust to be able to write 2 or 4 byte\n\t AS, according to new use32bit argument.\n\t (aspath_put) Adjust to write 2 or 4.\n\t (aspath_gettoken) Use a long for passed in asno.\n\t* bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and\n\t BGP_ATTR_AS4_AGGREGATOR.\n\t (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as\n\t determined by received-capability flag.\n\t (bgp_attr_aspath_check) New, code previously in attr_aspath\n\t but moved to new func so it can be run after NEW_AS_PATH\n\t reconciliation.\n\t (bgp_attr_as4_path) New, handle NEW_AS_PATH.\n\t (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.\n\t (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.\n\t (bgp_attr_parse) Add handoffs to previous parsers for the two\n\t new AS4 NEW_ attributes.\n\t Various checks added for NEW/OLD reconciliation.\n\t (bgp_packet_attribute) Support 2/4 for AS_PATH and\n\t AGGREGATOR, detect when NEW_ attrs need to be sent.\n\t* bgp_debug.{c,h}: Add \u0027debug bgp as4\u0027.\n\t* bgp_dump.c: MRTv2 support, unconditionally enabled, which\n\t supports AS4. Based on patches from Erik (RIPE?).\n\t* bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4\n\t support.\n\t* bgp_open.c: (peek_for_as4_capability) New, peek for AS4\n\t capability prior to full capability parsing, so we know which\n\t ASN to use for struct peer lookup.\n\t (bgp_open_capability) Always send AS4 capability.\n\t* bgp_packet.c: (bgp_open_send) AS4 handling for AS field\n\t (bgp_open_receive) Peek for AS4 capability first, and figure\n\t out which AS to believe.\n\t* bgp_vty.c: (bgp_show_peer) Print AS4 cap\n\t* tests/aspath_test.c: Support asn32 changes, call aspath_parse\n\t with 16 bit.\n\t* vtysh/extract.pl: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/extract.pl.in: AS4 compatibility for router bgp ASNUMBER\n\t* vtysh/vtysh.c: AS4 compatibility for router bgp ASNUMBER\n" }, { "commit": "6d58272b4cf96f0daa846210dd2104877900f921", "tree": "a97f2c9c797bd96b298aa64f03ed69115d63e78b", "parents": [ "dfdb8f18c008e7ad306588c86b12fbef337427ca" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:21:45 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Mon Aug 06 15:21:45 2007 +0000" }, "message": "[bgpd] cleanup, compact and consolidate capability parsing code\n\n2007-07-26 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Clean up and compact capability parsing slightly.\n\t Consolidate validation of length and logging of generic TLV, and\n\t memcpy of capability data, thus removing such from cap specifc\n\t code (not always present or correct).\n\t* bgp_open.h: Add structures for the generic capability TLV header\n\t and for the data formats of the various specific capabilities we\n\t support. Hence remove the badly named, or else misdefined, struct\n\t capability.\n\t* bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.\n\t Do the length checks *before* memcpy()\u0027ing based on that length\n\t (stored capability - should have been validated anyway on input,\n\t but..).\n\t (bgp_afi_safi_valid_indices) new function to validate (afi,safi)\n\t which is about to be used as index into arrays, consolidates\n\t several instances of same, at least one of which appeared to be\n\t incomplete..\n\t (bgp_capability_mp) Much condensed.\n\t (bgp_capability_orf_entry) New, process one ORF entry\n\t (bgp_capability_orf) Condensed. Fixed to process all ORF entries.\n\t (bgp_capability_restart) Condensed, and fixed to use a\n\t cap-specific type, rather than abusing capability_mp.\n\t (struct message capcode_str) added to aid generic logging.\n\t (size_t cap_minsizes[]) added to aid generic validation of\n\t capability length field.\n\t (bgp_capability_parse) Generic logging and validation of TLV\n\t consolidated here. Code compacted as much as possible.\n\t* bgp_packet.c: (bgp_open_receive) Capability parsers now use\n\t streams, so no more need here to manually fudge the input stream\n\t getp.\n\t (bgp_capability_msg_parse) use struct capability_mp_data. Validate\n\t lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.\n\t (bgp_capability_receive) Exported for use by test harness.\n\t* bgp_vty.c: (bgp_show_summary) fix conversion warning\n\t (bgp_show_peer) ditto\n\t* bgp_debug.h: Fix storage \u0027extern\u0027 after type \u0027const\u0027.\n * lib/log.c: (mes_lookup) warning about code not being in\n same-number array slot should be debug, not warning. E.g. BGP\n has several discontigious number spaces, allocating from\n different parts of a space is not uncommon (e.g. IANA\n assigned versus vendor-assigned code points in some number\n space).\n" }, { "commit": "fb982c25aa771b7c7425a3c3cce0a2cda0a715de", "tree": "74aa4dc86b04365d90a1030682796421b0eff011", "parents": [ "5921ef9aae3b5d6ff8663298f649fb9d76594acd" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Fri May 04 20:15:47 2007 +0000" }, "message": "[bgpd] Trim memory usage of BGP routes\n\n2007-05-03 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_route.h: (struct info) Move less frequently used\n\t fields to a lazily allocated struct info_extra.\n\t Export bgp_info_extra_get\n\t* bgp_route.c: (bgp_info_extra_new) allocate extra\n\t (bgp_info_extra_free) Free damp info and the info_extra.\n\t (bgp_info_extra_get) Retrieve the info_extra of a struct\n\t info, allocating as required.\n\t (generally) adjust to use info-\u003eextra\n\t* bgp_damp.c: (generally) use bgp_info_extra_get to access\n\t dampinfo\n\t* bgp_attr.h: Move rarely allocated attributes from struct attr\n\t to a struct attr_extra, for a substantial saving in size of\n\t struct attr.\n\t* bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.\n\t (bgp_attr_extra_get) Get the attr_extra for a given struct\n\t attr, allocating it if needs be.\n\t (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.\n\t (generally) adjust to know about attr-\u003eextra.\n\t* bgp_debug.c: (bgp_dump_attr) ditto\n\t* bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.\n\t* bgp_nexthop.c: (generally) adjust to know about attr-\u003eextra\n\t and info-\u003eextra.\n\t* bgp_{packet,routemap,snmp,zebra}.c: ditto\n\t* lib/memtypes.c: Add MTYPE_ATTR_EXTRA and MTYPE_BGP_ROUTE_EXTRA\n" }, { "commit": "ca058a30b1ea57f83871ab4cf1c9a91ea4064d52", "tree": "ab38ab59bad607c9b41a093cb8b35bec766f30b3", "parents": [ "2815e61ffbbf9c362896f3912d925cf78e125ee1" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 02:58:49 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Sep 14 02:58:49 2006 +0000" }, "message": "[bgpd] Fix 0.99 shutdown regression, introduce Clearing and Deleted states\n\n2006-09-14 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (general) Fix some niggly issues around \u0027shutdown\u0027 and clearing\n\t by adding a Clearing FSM wait-state and a hidden \u0027Deleted\u0027\n\t FSM state, to allow deleted peers to \u0027cool off\u0027 and hit 0\n\t references. This introduces a slow memory leak of struct peer,\n\t however that\u0027s more a testament to the fragility of the\n\t reference counting than a bug in this patch, cleanup of\n\t reference counting to fix this is to follow.\n\t* bgpd.h: Add Clearing, Deleted states and Clearing_Completed\n\t and event.\n\t* bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and\n\t Deleted.\n\t* bgp_fsm.h: Don\u0027t allow timer/event threads to set anything\n\t for Deleted peers.\n\t* bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted\n\t needs to stop everything.\n\t (bgp_stop) Remove explicit fsm_change_status call, the\n\t general framework handles the transition.\n\t (bgp_start) Log a warning if a start is attempted on a peer\n\t that should stay down, trying to start a peer.\n\t (struct .. FSM) Add Clearing_Completed\n\t events, has little influence except when in state\n\t Clearing to signal wait-state can end.\n\t Add Clearing and Deleted states, former is a wait-state,\n\t latter is a placeholder state to allow peers to disappear\n\t quietly once refcounts settle.\n\t (bgp_event) Try reduce verbosity of FSM state-change debug,\n\t changes to same state are not interesting (Established-\u003eEstablished)\n\t Allow NULL action functions in FSM.\n\t* bgp_packet.c: (bgp_write) Use FSM events, rather than trying\n\t to twiddle directly with FSM state behind the back of FSM.\n\t (bgp_write_notify) ditto.\n\t (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else\n\t this patch crashes, now it leaks instead.\n\t* bgp_route.c: (bgp_clear_node_complete) Clearing_Completed\n\t event, to end clearing.\n\t (bgp_clear_route) See extensive comments.\n\t* bgpd.c: (peer_free) should only be called while in Deleted,\n\t peer refcounting controls when peer_free is called.\n\t bgp_sync_delete should be here, not in peer_delete.\n\t (peer_delete) Initiate delete.\n\t Transition to Deleted state manually.\n\t When removing peer from indices that provide visibility of it,\n\t take great care to be idempotent wrt the reference counting\n\t of struct peer through those indices.\n\t Use bgp_timer_set, rather than replicating.\n\t Call to bgp_sync_delete isn\u0027t appropriate here, sync can be\n\t referenced while shutting down and finishing deletion.\n\t (peer_group_bind) Take care to be idempotent wrt list references\n\t indexing peers.\n" }, { "commit": "369688c0c7a325e889e841afc2d59430baf079a2", "tree": "55c5e916f607609fc0e242ca874ff14758cc5f44", "parents": [ "825cd49ead7a9222f93b37f65030f5ff325cd4ab" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue May 23 22:27:55 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue May 23 22:27:55 2006 +0000" }, "message": "[bgpd] expand vty help for neighbor ... update-source\n\n2006-05-23 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion\n\t to make it clear it takes both address and ifname.\n" }, { "commit": "4bf6a3621c828ea9f2c62298b525a2c1a191a45e", "tree": "88d950315b8ef20ce1e12e4166c3eb6b10d989dd", "parents": [ "5304cb52f47a646554241b3bc1d1dab9ccaea73d" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 14:05:23 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Thu Mar 30 14:05:23 2006 +0000" }, "message": "[bgpd] Add \u0027show bgp memory\u0027 for stats on fixed-size allocations in bgpd\n\n2006-03-19 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd/bgp_vty.c: Add includes to get several structs we want\n\t to provide usage statistics on.\n\t (show_bgp_memory_cmd) Show memory usage stats for various\n\t notable fixed size objects. Using mtype_stats_alloc and\n\t mtype_memstr recently added to memory.c.\n\t (bgp_show_summary) Report some additional stats specific to\n\t the given BGP instance and/or AFI/SAFI such as table counts,\n\t peers, rsclients and peer-groups.\n\t (bgp_vty_init) Install show_bgp_memory_cmd.\n" }, { "commit": "6a419733c5fba17b246b5cce4af73828f8c346ef", "tree": "f62342579f0adce713aa9d599bfe2fa20a987456", "parents": [ "64e580a72deaa268e46559516663808503f347ec" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Feb 21 01:14:13 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Feb 21 01:14:13 2006 +0000" }, "message": "[bgpd] Add Clrng description to bgp summary state.\n\n2006-02-21 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_vty.c: (bgp_show_summary) Add a \u0027Clrng\u0027 sub-description\n\t to state of peer while it\u0027s suppressed due to clearing.\n" }, { "commit": "64e580a72deaa268e46559516663808503f347ec", "tree": "7b11b71858334f07a72d3885e00f63dd5c8efcf7", "parents": [ "e24f0638e6fc7256580c185a631cbe5549bf7db3" ], "author": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Feb 21 01:09:01 2006 +0000" }, "committer": { "name": "Paul Jakma", "email": "paul.jakma@sun.com", "time": "Tue Feb 21 01:09:01 2006 +0000" }, "message": "[bgpd] Record afi/safi in bgp_table. Serialise peer clear with FSM.\n\n2006-02-21 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd.h: move the clear_node_queue to be peer specific.\n\t Add a new peer status flag, PEER_STATUS_CLEARING.\n\t* bgp_table.h: (struct bgp_table) Add fields to record afi,\n safi of the table.\n (bgp_table_init) Take afi and safi to create table for.\n * bgp_table.c: (bgp_table_init) record the afi and safi.\n * bgp_nexthop.c: Update all calls to bgp_table_init.\n * bgp_vty.c: ditto.\n * bgpd.c: ditto.\n * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is\n\t clearing.\n * bgp_route.c: (general) Update all bgp_table_init calls.\n (bgp_process_{rsclient,main}) clear_node is serialised\n via PEER_STATUS_CLEARING and fsm now.\n (struct bgp_clear_node_queue) can be removed. struct bgp_node\n can be the queue item data directly, as struct peer can be\n kept in the new wq global user data and afi/safi can be\n retrieved via bgp_node -\u003e bgp_table.\n (bgp_clear_route_node) fix to get peer via wq-\u003espec.data,\n afi/safi via bgp_node-\u003ebgp_table.\n (bgp_clear_node_queue_del) no more item data to delete, only\n unlock the bgp_node.\n (bgp_clear_node_complete) only need to unset CLEARING flag\n and unlock struct peer.\n (bgp_clear_node_queue_init) queue attaches to struct peer\n now. record peer name as queue name.\n (bgp_clear_route_table) If queue transitions to active,\n serialise clearing by setting PEER_STATUS_CLEARING rather\n than plugging process queue, and lock peer while queue\n active.\n Update to pass only bgp_node as per-queue-item specific data.\n" }, { "commit": "e8e1946edf6ba87ef53832cdceccc39d7f0c3f26", "tree": "fcdaf92bf4129a8a58825bd21ae841a6b3b2bda8", "parents": [ "779adb0147cfff1a831b08853976342ad2110fcd" ], "author": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Jan 19 20:16:55 2006 +0000" }, "message": "[compiler] miscellaneous trivial compiler warning fixes\n\n2006-01-19 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n * (general) various miscellaneous compiler warning fixes.\n Remove redundant break statements from switch clauses\n which return.\n return from main, not exit, cause it annoys SOS.\n Remove stray semi-colons which cause empty-statement\n warnings.\n\t* zebra/main.c: (sighup) remove private declaration of external\n\t function.\n" }, { "commit": "f52d13cb2e8e7197934d5f241f88647f9b9d78b8", "tree": "b0aa01befc07f57ed47e83ac7dfb383284c49d26", "parents": [ "c05612b9a702d0f49c379c92deb6daab55372aea" ], "author": { "name": "ajs", "email": "ajs", "time": "Sat Oct 01 17:38:06 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Sat Oct 01 17:38:06 2005 +0000" }, "message": "2005-10-01 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* zebra.h: Declare new functions zebra_route_string() and\n\t zebra_route_char().\n\t* log.c: (zroute_lookup,zebra_route_string,zebra_route_char) New\n\t functions to map zebra route numbers to strings.\n\t* zebra_vty.c: (route_type_str) Remove obsolete function: use new\n\t library function zebra_route_string() instead. Note that there\n\t are a few differences: for IPv6 routes, we now get \"ripng\" and\n\t \"ospf6\" instead of the old behavior (\"rip\" and \"ospf\").\n\t (route_type_char) Remove obsolete function: ues new library function\n\t zebra_route_char() instead. Note that there is one difference:\n\t the old function returned \u0027S\u0027 for a ZEBRA_ROUTE_SYSTEM route,\n\t whereas the new one returns \u0027X\u0027.\n\t (vty_show_ip_route_detail,vty_show_ipv6_route_detail) Replace\n\t route_type_str() with zebra_route_string().\n\t (vty_show_ip_route,vty_show_ipv6_route) Replace route_type_char()\n\t with zebra_route_char().\n\t* bgp_vty.c: (bgp_config_write_redistribute) Use new library function\n\t zebra_route_string instead of a local hard-coded table.\n\t* ospf6_asbr.c: Remove local hard-coded tables zroute_name and\n\t zroute_abname. Change the ZROUTE_NAME macro to use new library\n\t function zebra_route_string(). Remove the ZROUTE_ABNAME macro.\n\t (ospf6_asbr_external_route_show): Replace ZROUTE_ABNAME() with\n\t a call to zebra_route_char(), and be sure to fix the format string,\n\t since we now have a char instead of a char *.\n\t* ospf6_zebra.c: Remove local hard-coded tables zebra_route_name and\n\t zebra_route_abname. Note that the zebra_route_name[] table\n\t contained mixed-case strings, whereas the zebra_route_string()\n\t function returns lower-case strings.\n\t (ospf6_zebra_read_ipv6): Change debug message to use new library\n\t function zebra_route_string() instead of zebra_route_name[].\n\t (show_zebra): Use new library function zebra_route_string() instead\n\t of zebra_route_name[].\n\t* ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.\n\t (ospf_redist_string) New function implemented using new library\n\t function zebra_route_string(). Note that there are a few differences\n\t in the output that will result: the new function returns strings\n\t that are lower-case, whereas the old table was mixed case. Also,\n\t the old table mapped ZEBRA_ROUTE_OSPF6 to \"OSPFv3\", whereas the\n\t new function returns \"ospf6\".\n\t* ospfd.h: Remove extern struct message ospf_redistributed_proto[],\n\t and add extern const char *ospf_redist_string(u_int route_type)\n\t instead.\n\t* ospf_asbr.c: (ospf_external_info_add) In two messages, use\n\t ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).\n\t* ospf_vty.c: Remove local hard-coded table distribute_str.\n\t (config_write_ospf_redistribute,config_write_ospf_distribute): Use\n\t new library function zebra_route_string() instead of distribute_str[].\n\t* ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,\n\t ospf_redistribute_default_set,ospf_redistribute_check)\n\t In debug messages, use ospf_redist_string() instead of\n\t LOOKUP(ospf_redistributed_proto).\n\t* rip_zebra.c: (config_write_rip_redistribute): Remove local hard-coded\n\t table str[]. Replace str[] with calls to new library function\n\t zebra_route_string().\n\t* ripd.c: Remove local hard-coded table route_info[].\n\t (show_ip_rip) Replace uses of str[] with calls to new library\n\t functions zebra_route_char and zebra_route_string.\n\t* ripng_zebra.c: (ripng_redistribute_write) Remove local hard-coded\n\t table str[]. Replace str[i] with new library function\n\t zebra_route_string(i).\n\t* ripngd.c: Remove local hard-coded table route_info[].\n\t (show_ipv6_ripng) Use new library function zebra_route_char() instead\n\t of table route_info[].\n" }, { "commit": "1f8ae70b7b86d132b95a18f0c824deb248987afc", "tree": "4d50ffd23b5e1e63a442e59c66c16227d06c4d33", "parents": [ "e7cd37bf334c6a4c0a3db6a0cfeb97674f820503" ], "author": { "name": "paul", "email": "paul", "time": "Fri Sep 09 23:49:49 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Sep 09 23:49:49 2005 +0000" }, "message": "2005-09-10 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static\n\t function declarations shouldn\u0027t be inside functions.\n\t* bgp_dump.c: (bgp_dump_interval_add) ditto.\n" }, { "commit": "25ffbdc1d72682dea1f5254d7c12e400215e0f1e", "tree": "f0a1c3a7fd8b384e71c49a27b4c3c7508ee7b163", "parents": [ "1e83659026e5b9c5876273c83e86fd229dd98c88" ], "author": { "name": "paul", "email": "paul", "time": "Mon Aug 22 22:42:08 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Aug 22 22:42:08 2005 +0000" }, "message": "2005-08-22 Hugo Santos \u003chsantos@av.it.pt\u003e\n\n\t* bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI\n\t commands and BGP_IPV6M_NODE.\n" }, { "commit": "94f2b3923e9663d0355a829f22e4e31cf68ee7b8", "tree": "59c0291a76b1c97fbb089abb479307f19cdfd4c1", "parents": [ "7cad40007b9714dba65065916ea68577f9d3d6dd" ], "author": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Tue Jun 28 12:44:16 2005 +0000" }, "message": "2005-06-28 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global) The great bgpd extern and static\u0027ification.\n\t* bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code\n\t (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison\n\t warnings.\n\t* bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these\n\t used by various files which had their own private declarations,\n\t in the case of mplsvpn - incorrect.\n" }, { "commit": "200df115ea0ba6f54151d60fe5e9a7f6948de7c3", "tree": "2aedc0af80d2e805cdf2cefd50432423d2871216", "parents": [ "b31b813671d96ea9e96801508442a90f0ef503fa" ], "author": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Jun 01 11:17:05 2005 +0000" }, "message": "2005-06-01 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* bgpd/(general) refcount struct peer and bgp_info, hence allowing us\n\t add work_queues for bgp_process.\n\t* bgpd/bgp_route.h: (struct bgp_info) Add \u0027lock\u0027 field for refcount.\n\t Add bgp_info_{lock,unlock} helper functions.\n\t Add bgp_info_{add,delete} helpers, to remove need for\n\t users managing locking/freeing of bgp_info and bgp_node\u0027s.\n\t* bgpd/bgp_table.h: (struct bgp_node) Add a flags field, and\n\t BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of\n\t nodes.\n\t* bgpd/bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock\n\t peer reference as appropriate.\n\t* bgpd/bgp_damp.c: Remove its internal prototypes for\n\t bgp_info_delete/free. Just use bgp_info_delete.\n\t* bgpd/bgpd.h: (struct bgp_master) Add work_queue pointers.\n\t (struct peer) Add reference count \u0027lock\u0027\n\t (peer_lock,peer_unlock) New helpers to take/release reference\n\t on struct peer.\n\t* bgpd/bgp_advertise.c: (general) Add peer and bgp_info refcounting\n\t and balance how references are taken and released.\n\t (bgp_advertise_free) release bgp_info reference, if appropriate\n\t (bgp_adj_out_free) unlock peer\n\t (bgp_advertise_clean) leave the adv references alone, or else\n\t call bgp_advertise_free cant unlock them.\n\t (bgp_adj_out_set) lock the peer on new adj\u0027s, leave the reference\n\t alone otherwise. lock the new bgp_info reference.\n\t (bgp_adj_in_set) lock the peer reference\n\t (bgp_adj_in_remove) and unlock it here\n\t (bgp_sync_delete) make hash_free on peer conditional, just in\n\t case.\n\t* bgpd/bgp_fsm.c: (general) document that the timers depend on\n\t bgp_event to release a peer reference.\n\t (bgp_fsm_change_status) moved up the file, unchanged.\n\t (bgp_stop) Decrement peer lock as many times as cancel_event\n\t canceled - shouldnt be needed but just in case.\n\t stream_fifo_clean of obuf made conditional, just in case.\n\t (bgp_event) always unlock the peer, regardless of return value\n\t of bgp_fsm_change_status.\n\t* bgpd/bgp_packet.c: (general) change several bgp_stop\u0027s to BGP_EVENT\u0027s.\n\t (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs\n\t along with a comment on it.\n\t* bgpd/bgp_route.c: (general) Add refcounting of bgp_info, cleanup\n\t some of the resource management around bgp_info. Refcount peer.\n\t Add workqueues for bgp_process and clear_table.\n\t (bgp_info_new) make static\n\t (bgp_info_free) Ditto, and unlock the peer reference.\n\t (bgp_info_lock,bgp_info_unlock) new exported functions\n\t (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,\n\t taking care of reference counts.\n\t (bgp_info_delete) do the opposite of bgp_info_add.\n\t (bgp_process_rsclient) Converted into a work_queue work function.\n\t (bgp_process_main) ditto.\n\t (bgp_processq_del) process work queue item deconstructor\n\t (bgp_process_queue_init) process work queue init\n\t (bgp_process) call init function if required, set up queue item\n\t and add to queue, rather than calling process functions directly.\n\t (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts\n\t (bgp_rib_withdraw) ditto\n\t (bgp_update_rsclient) let bgp_info_add manage refcounts\n\t (bgp_update_main) ditto\n\t (bgp_clear_route_node) clear_node_queue work function, does\n\t per-node aspects of what bgp_clear_route_table did previously\n\t (bgp_clear_node_queue_del) clear_node_queue item delete function\n\t (bgp_clear_node_complete) clear_node_queue completion function,\n\t it unplugs the process queues, which have to be blocked while\n\t clear_node_queue is being processed to prevent a race.\n\t (bgp_clear_node_queue_init) init function for clear_node_queue\n\t work queues\n\t (bgp_clear_route_table) Sets up items onto a workqueue now, rather\n\t than clearing each node directly. Plugs both process queues to\n\t avoid potential race.\n\t (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage\n\t bgp_info refcounts.\n\t (bgp_static_update_rsclient) ditto\n\t (bgp_static_update_main) ditto\n\t (bgp_static_update_vpnv4) ditto, remove unneeded cast.\n\t (bgp_static_withdraw) see bgp_static_withdraw_rsclient\n\t (bgp_static_withdraw_vpnv4) ditto\n\t (bgp_aggregate_{route,add,delete}) ditto\n\t (bgp_redistribute_{add,delete,withdraw}) ditto\n\t* bgpd/bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer\n\t reference\n\t (peer_rsclient_unset_vty) ditto, but unlock same reference\n\t* bgpd/bgpd.c: (peer_free) handle frees of info to be kept for lifetime\n\t of struct peer.\n\t (peer_lock,peer_unlock) peer refcount helpers\n\t (peer_new) add initial refcounts\n\t (peer_create,peer_create_accept) lock peer as appropriate\n\t (peer_delete) unlock as appropriate, move out some free\u0027s to\n\t peer_free.\n\t (peer_group_bind,peer_group_unbind) peer refcounting as\n\t appropriate.\n\t (bgp_create) check CALLOC return value.\n\t (bgp_terminate) free workqueues too.\n\t* lib/memtypes.c: Add MTYPE_BGP_PROCESS_QUEUE and\n\t MTYPE_BGP_CLEAR_NODE_QUEUE\n" }, { "commit": "a8a80d532f3248567b6926b5dbd12509eadd6b43", "tree": "b3b42ef7f78c62fb0c1edddd7c0272950883c14c", "parents": [ "67bf16c0f8179af05bcff04d19226866a8b7e806" ], "author": { "name": "hasso", "email": "hasso", "time": "Sat Apr 09 13:07:47 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sat Apr 09 13:07:47 2005 +0000" }, "message": "\t* bgp_vty.c: Make \"exit-address-family\" work in IPv4 unicast address\n\t family node.\n\n\t[backport candidate]\n" }, { "commit": "6811845b67999861388cf00d3ca0ee8471d29876", "tree": "1f7f08f171164b1a75b66a45093ccb44217dff12", "parents": [ "4a8164e5b310094315e2c50d73aeea489766a48a" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri Apr 08 15:40:36 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri Apr 08 15:40:36 2005 +0000" }, "message": "\t* bgpd.texi: Document new \"bgp bestpath as-path confed\" command.\n\t* bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable\n\t the length of confederation path segments to be included during the\n\t as-path length check in the best path decision.\n" }, { "commit": "1eb8ef2584833f18fb674e127d59cb5a7f771482", "tree": "f5b09d4781de9a9b08839fefb6530e64d2d2ec31", "parents": [ "5920990fecba7e2430af3cfaa8bcbaed40d0ba1a" ], "author": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Thu Apr 07 07:30:20 2005 +0000" }, "message": "2005-04-07 Paul Jakma \u003cpaul.jakma@sun.com\u003e\n\n\t* (global): Fix up list loops to match changes in lib/linklist,\n\t and some basic auditing of usage.\n\t* configure.ac: define QUAGGA_NO_DEPRECATED_INTERFACES\n\t* HACKING: Add notes about deprecating interfaces and commands.\n\t* lib/linklist.h: Add usage comments.\n\t Rename getdata macro to listgetdata.\n\t Rename nextnode to listnextnode and fix its odd behaviour to be\n\t less dangerous.\n\t Make listgetdata macro assert node is not null, NULL list entries\n should be bug condition.\n ALL_LIST_ELEMENTS, new macro, forward-referencing macro for use\n with for loop, Suggested by Jim Carlson of Sun.\n Add ALL_LIST_ELEMENTS_RO for cases which obviously do not need the\n \"safety\" of previous macro.\n\t LISTNODE_ADD and DELETE macros renamed to ATTACH, DETACH, to\n\t distinguish from the similarly named functions, and reflect their\n\t effect better.\n\t Add a QUAGGA_NO_DEPRECATED_INTERFACES define guarded section\n\t with the old defines which were modified above,\n\t for backwards compatibility - guarded to prevent Quagga using it..\n\t* lib/linklist.c: fix up for linklist.h changes.\n\t* ospf6d/ospf6_abr.c: (ospf6_abr_examin_brouter) change to a single\n\t scan of the area list, rather than scanning all areas first for\n\t INTER_ROUTER and then again for INTER_NETWORK. According to\n\t 16.2, the scan should be area specific anyway, and further\n\t ospf6d does not seem to implement 16.3 anyway.\n" }, { "commit": "dd4c593fb88b7c6cf5f27aa8a8286644743ed58a", "tree": "962cd10bb5bf92a42285f3bb88cbb3ef3f33f595", "parents": [ "c1643bb7d7de6c030a61983be8e0925160a9e427" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 17:15:34 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 17:15:34 2005 +0000" }, "message": "\t* bgp_vty.c: Deprecate \"neighbor transparent-as\" and \"neighbor\n\t transparent-nexthop\" commands.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "fee6e4e4547783b915838f6868d6cd694f6cee21", "tree": "2fb39322113433ab2d5e42042c1b9e397779b6c1", "parents": [ "6ffd2079596c232856dda0d56fddd9610e8d61fe" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 16:29:31 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 16:29:31 2005 +0000" }, "message": "\t* bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:\n\t community-list cleanup.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "6ffd2079596c232856dda0d56fddd9610e8d61fe", "tree": "d5c4906cbfb4af98a8c73be667a9ab2369a6c64b", "parents": [ "93406d87e68a0e9cf5ce0240461395cd59c143b6" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:50:11 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:50:11 2005 +0000" }, "message": "\t* bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: \"enforce-multihop\"\n\t -\u003e \"disable-connected-check\".\n\n\t[merge from GNU Zebra]\n" }, { "commit": "93406d87e68a0e9cf5ce0240461395cd59c143b6", "tree": "b1cb2bae2eca7c5206565f73169cf43bf8cf892d", "parents": [ "c9502438e822199370fe87100c725e1092e943c1" ], "author": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:40:33 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Wed Feb 02 14:40:33 2005 +0000" }, "message": "\t* bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,\n\t bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. \"bgp\n\t graceful-restart\" commands added. Show numbers of individual\n\t messages in \"show ip bgp neighbor\" command. Final pieces of graceful\n\t restart.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "c9502438e822199370fe87100c725e1092e943c1", "tree": "bfeb6babd5d0ba6037ab2aa3a544b2d855e4e8d9", "parents": [ "3d515fd9af9f126667a9c2da9c2f40c4c37c28df" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 22:01:48 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 22:01:48 2005 +0000" }, "message": "\t* bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove \"no neighbor\n\t capability route-refresh\" commands. Route refresh capability is sent\n\t anyway now. Preserve dummy deprecated commands.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "3d515fd9af9f126667a9c2da9c2f40c4c37c28df", "tree": "c107224556ed7678d7a5afc42c19742948cda477", "parents": [ "0a486e5fcb1b8dac7d8b4cf6ed93e82b8b72fed6" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 21:30:04 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 21:30:04 2005 +0000" }, "message": "\t* bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old\n\t draft - ie. \"neighbor version 4-\" commands. Preserve dummy \"neighbor\n\t version\" command as deprecated.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "0a486e5fcb1b8dac7d8b4cf6ed93e82b8b72fed6", "tree": "f63429ed7767e227457cb48196d82f12e4fcaad6", "parents": [ "f418446bb767d79438e2df689c5bf9563c54b317" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:57:17 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:57:17 2005 +0000" }, "message": "\t* bgpd.[ch], bgp_vty.c, bgp_route.c: \"Restart session after\n\t maximum-prefix limit\" feature support.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "f418446bb767d79438e2df689c5bf9563c54b317", "tree": "a1c7322c8b54e46a09bf2f402537277fff59c1c3", "parents": [ "6a52d0d155fc8b892e30cdb5e3fbe4c2779bd4cd" ], "author": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:13:16 2005 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Tue Feb 01 20:13:16 2005 +0000" }, "message": " * bgp_nexthop.c: Improve debug.\n * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()\n function.\n * bgp_packet.c: MP AFI_IP update and withdraw parsing.\n * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()\n is better place to log about peer status change than bgp_event().\n Log in bgp_connect_success().\n * bgp_vty.c: Fix typo in comment.\n * bgp_attr.c: Better log about unknown attribute.\n\n\t[merge from GNU Zebra]\n" }, { "commit": "3b8b1855038afde448993e5a56955e9b7a4d99c2", "tree": "5378ad7cc9d2fdb42558044833036e347ca1277e", "parents": [ "4460e7a4cf3dadcd9f06e4b519ba7be2cc936c0a" ], "author": { "name": "ajs", "email": "ajs", "time": "Sat Jan 29 18:19:13 2005 +0000" }, "committer": { "name": "ajs", "email": "ajs", "time": "Sat Jan 29 18:19:13 2005 +0000" }, "message": "2005-01-29 Andrew J. Schorr \u003cajschorr@alumni.princeton.edu\u003e\n\n\t* buffer.h: Fix comment on buffer_getstr to reflect that it now\n\t uses XMALLOC.\n\t* buffer.c: (buffer_getstr) Use XMALLOC(MTYPE_TMP) instead of malloc.\n\t* filter.c: (access_list_remark,ipv6_access_list_remark) Use\n\t argv_concat instead of buffer_getstr.\n\t* if.c: (interface_desc) Use argv_concat instead of buffer_getstr.\n\t* plist.c: (ip_prefix_list_description,ipv6_prefix_list_description)\n\t Use argv_concat instead of buffer_getstr.\n\t* bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead\n\t of buffer_getstr.\n\t* bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string\n\t returned by buffer_getstr.\n\t (bgp_show_community) Must use XFREE instead of free on string\n\t returned by buffer_getstr.\n\t* bgp_routemap.c: (set_community) Must use XFREE instead of free\n\t on string returned by buffer_getstr.\n\t* bgp_vty.c: (neighbor_description) Use argv_concat instead of\n\t buffer_getstr.\n" }, { "commit": "fd79ac918b8feaacebe9719adaac97dffb69137a", "tree": "d0665eb68e60da9d6e364414cdb61830f19f33d3", "parents": [ "39db97e4e02eae08a1e18528367b6e9b07eb6a93" ], "author": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:06:08 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Oct 13 05:06:08 2004 +0000" }, "message": "2004-10-13 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* (global) more const\u0027ification and fixups of types to clean up code.\n\t* bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,\n should use something like the VTY_GET_INTEGER macro, but without\n the vty_out bits..\n * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE\n (no_set_aggregator_as) ditto.\n * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is\n returned, add comments about troublesome return value.\n" }, { "commit": "18a6dce6f83dd20caf1f36c8e840868ff0bf6dbd", "tree": "ff832cbf6fe2b239bde06268820587bec671ae6d", "parents": [ "a49c0ff6771975eeb1bd7da923a9dc830200cf65" ], "author": { "name": "hasso", "email": "hasso", "time": "Sun Oct 03 18:18:34 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sun Oct 03 18:18:34 2004 +0000" }, "message": "Common router id.\n" }, { "commit": "c9e52be3f4d98943b67fbbe5d9a7ccd823b88326", "tree": "d4045a946af3be8bbdc303162778e8c44057e2f9", "parents": [ "e473b032b860444b9656cee1654b0120f77b52b1" ], "author": { "name": "hasso", "email": "hasso", "time": "Sun Sep 26 16:09:34 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sun Sep 26 16:09:34 2004 +0000" }, "message": "Compiler warnings fixes.\n" }, { "commit": "fee0f4c629412f422fc9a857e097ef335c2c576c", "tree": "14703e303ea2cecaee7728d9ee27075b0590a679", "parents": [ "0e82d0e1204e45ecce773a7e19f7d64140f7a66a" ], "author": { "name": "paul", "email": "paul", "time": "Mon Sep 13 05:12:46 2004 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Mon Sep 13 05:12:46 2004 +0000" }, "message": "2004-09-13 Jose Luis Rubio \u003cjrubio@dit.upm.es\u003e\n (at Technical University of Madrid as part of Euro6ix Project)\n\n Enhanced Route Server functionality and Route-Maps:\n\n * bgpd/bgpd.h: Modified \u0027struct peer\u0027 and \u0027struct bgp_filter\u0027 to\n support rs-clients. A \u0027struct bgp_table *rib\u0027 has been added to the\n first (to mantain a separated RIB for each rs-client) and two new\n route-maps have been added to the last (for import/export policies).\n Added the following #defines: RMAP_{IN|OUT|IMPORT|EXPORT|MAX},\n PEER_RMAP_TYPE_{IMPORT|EXPORT} and BGP_CLEAR_SOFT_RSCLIENT.\n\n * bgpd/bgpd.c: Modified the functions that create/delete/etc peers in\n order to consider the new fields included in \u0027struct peer\u0027 for\n supporting rs-clients, i.e. the import/export route-maps and the\n \u0027struct bgp_table\u0027.\n\n * bgpd/bgp_route.{ch}: Modified several functions related with\n receiving/sending announces in order to support the new Route Server\n capabilities.\n Function \u0027bgp_process\u0027 has been reorganized, creating an auxiliar\n function for best path selection (\u0027bgp_best_selection\u0027).\n Modified \u0027bgp_show\u0027 and \u0027bgp_show_route\u0027 for displaying information\n about any RIB (and not only the main bgp RIB).\n Added commands for displaying information about RS-clients RIBs:\n \u0027show bgp rsclient (A.B.C.D|X:X::X:X)\u0027, \u0027show bgp rsclient\n (A.B.C.D|X:X::X:X) X:X::X:X/M\u0027, etc\n\n * bgpd/bgp_table.{ch}: The structure \u0027struct bgp_table\u0027 now has two\n new fields: type (which can take the values BGP_TABLE_{MAIN|RSCLIENT})\n and \u0027void *owner\u0027 which points to \u0027struct bgp\u0027 or \u0027struct peer\u0027 which\n owns the table.\n When creating a new bgp_table by default \u0027type\u003dBGP_TABLE_MAIN\u0027 is set.\n\n * bgpd/bgp_vty.c: The commands \u0027neighbor ... route-server-client\u0027 and\n \u0027no neighbor ... route-server-client\u0027 now not only set/unset the flag\n PEER_FLAG_RSERVER_CLIENT, but they create/destroy the \u0027struct\n bgp_table\u0027 of the peer. Special actions are taken for peer_groups.\n Command \u0027neighbor ... route-map WORD (in|out)\u0027 now also supports two\n new kinds of route-map: \u0027import\u0027 and \u0027export\u0027.\n Added commands \u0027clear bgp * rsclient\u0027, etc. These commands allow a new\n kind of soft_reconfig which affects only the RIB of the specified\n RS-client.\n Added commands \u0027show bgp rsclient summary\u0027, etc which display a\n summary of the rs-clients configured for the corresponding address\n family.\n\n * bgpd/bgp_routemap.c: A new match statement is available,\n \u0027match peer (A.B.C.D|X:X::X:X)\u0027. This statement can only be used in\n import/export route-maps, and it matches when the peer who announces\n (when used in an import route-map) or is going to receive (when used\n in an export route-map) the route is the same than the one specified\n in the statement.\n For peer-groups the statement matches if the specified peer is member\n of the peer-group.\n A special version of the command, \u0027match peer local\u0027, matches with\n routes originated by the Route Server (defined with \u0027network ...\u0027,\n redistributed routes and default-originate).\n\n * lib/routemap.{ch}: Added a new clause \u0027call NAME\u0027 for use in\n route-maps. It jumps into the specified route-map and when it returns\n the first route-map ends if the called RM returns DENY_MATCH, or\n continues in other case.\n" }, { "commit": "538621f2f80ced838048fa7402e57face3b224a5", "tree": "1193f5948da15db665aa6d4a43027c466c0614b4", "parents": [ "3950fda506e4db58a0ccc50156cf70f97da95bc3" ], "author": { "name": "hasso", "email": "hasso", "time": "Fri May 21 09:31:30 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Fri May 21 09:31:30 2004 +0000" }, "message": "Merge graceful restart capability display and some small fixes from Zebra\nrepository by Rivo Nurges.\n" }, { "commit": "e0701b7955b883c5437269a382e1afc76ee71e5c", "tree": "d00034c1b7f369fc8214d401b7a44ef586d73e15", "parents": [ "62843e433d8f85bce381edc6202c4af6c5cec31b" ], "author": { "name": "hasso", "email": "hasso", "time": "Thu May 20 09:19:34 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Thu May 20 09:19:34 2004 +0000" }, "message": "Merge bgpd changeset 1176 from Zebra repository by Rivo Nurges.\n" }, { "commit": "66e31693289d956f59758155faf86cab88853bae", "tree": "ecb9a5e77473abf776b9c97c661eef4be30abf34", "parents": [ "42ed9da7b646ce4b05ffafcae805a3018fb6f164" ], "author": { "name": "hasso", "email": "hasso", "time": "Sat Mar 20 19:33:06 2004 +0000" }, "committer": { "name": "hasso", "email": "hasso", "time": "Sat Mar 20 19:33:06 2004 +0000" }, "message": "*** empty log message ***\n" }, { "commit": "bb46e94fcccd9ede513bef8d8e22fe5fafdfbd10", "tree": "be7cb5015905c9fac8be0a9e3ba786dbd5d43e94", "parents": [ "a652604cbfcc87884a00b12beb4e63b1eb10bcea" ], "author": { "name": "paul", "email": "paul", "time": "Fri Oct 24 19:02:03 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Oct 24 19:02:03 2003 +0000" }, "message": "2003-10-24 Jose Luis Rubio Guivernau \u003cjrubio@dit.upm.es\u003e\n\n * Better \u0027show bgp\u0027 support for views (eg ipv6), see [quagga-dev 238]\n * bgpd/bgp_route.c: (bgp_show) Take a struct bgp argument instead of\n view string.\n (bgp_show_neighbor_route) Take a struct peer argument instead of\n ip string.\n (peer_adj_routes) ditto\n (show_adj_routes) ditto\n (peer_lookup_in_view) new function to return appropriate struct\n peer for a given view string.\n (misc) Fixup all calls to above to reflect new calling arguments,\n and use peer_lookup_in_view as needed. Additional commands\n installed to use expanded functionality above, existing commands\n modified to suit as well.\n * bgpd/bgp_vty.c: 2 new aliases.\n" }, { "commit": "848973c71e75424d07c2cd52ba991aae1b9df12a", "tree": "0a46f5b0fea868dd2003a475d860108b14786fe1", "parents": [ "e8f2984c00d406781eff42db7afcdae5d5a6a366" ], "author": { "name": "paul", "email": "paul", "time": "Wed Aug 13 00:32:49 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Wed Aug 13 00:32:49 2003 +0000" }, "message": "2003-08-13 kunihiro \u003ckunihiro@zebra.org\u003e\n\n\t* bgpd/bgp{_fsm.c,_vty.c,d.c,d.h}: Add support for \"bgp\n log-neighbor-changes\" command.\n" }, { "commit": "a58545bba183d4ce88b285ceb57f8d9c6d119768", "tree": "b2f8137f1e287968a49b037164c1b33b0e26efef", "parents": [ "d4a53d583c56462864b2fce08b1cf94493c041ab" ], "author": { "name": "paul", "email": "paul", "time": "Sat Jul 12 21:43:01 2003 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Sat Jul 12 21:43:01 2003 +0000" }, "message": "2003-07-12 Paul Jakma \u003cpaul@dishone.st\u003e\n\n\t* bgp_vty.c: install the neighbor_set_peer_group_cmd,\n\t neighbor_soft_reconfiguration_cmd and neighbor_unsuppress_map_cmd\n\t family of commands into the VPNv4 address family config node.\n" }, { "commit": "718e3744195351130f4ce7dbe0613f4b3e23df93", "tree": "bac2ad39971cd43f31241ef123bd4e470f695ac9", "parents": [], "author": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "committer": { "name": "paul", "email": "paul", "time": "Fri Dec 13 20:15:29 2002 +0000" }, "message": "Initial revision\n" } ] }