)]}'
{
  "commit": "6d4742bef722e6fab45fb6eb22ed2c7b7570a2e6",
  "tree": "5f448656a3f81e684df289e42cc3bd051850e17f",
  "parents": [
    "91b9e8547a7c5697d5d7481f9476778077024019"
  ],
  "author": {
    "name": "Paul Jakma",
    "email": "paul.jakma@hpe.com",
    "time": "Wed Nov 25 17:14:37 2015 +0000"
  },
  "committer": {
    "name": "Paul Jakma",
    "email": "paul.jakma@hpe.com",
    "time": "Thu Feb 18 15:54:45 2016 +0000"
  },
  "message": "bgpd: make bgp_info_cmp and multiple-path decision logic more regular\n\n* bgp_route.c: (bgp_info_cmp) This function is supposed to return a\n  preference between the given paths, and does so as binary either or.  When\n  mpath was added, the binary return value was left as is and instead an out\n  parameter \u0027paths_eq\u0027 was added to indicate the mpath-equality case.  It\u0027s\n  a bit odd, as is the resulting logic in the caller.\n\n  Regularise things again by making the function return a strcmp like\n  trinary return value of -1,0,1.  Get rid of the mpath specific arguments,\n  but pass in afi/safi as part of the general context - that plus the\n  (struct bgp *) is enough to access configuration.\n\n  Update the return values.\n\n  The mpath check was testing the IGP metric for equality, even though\n  previous to the mpath changes (and consistent with the behaviour of all\n  the other tests bar the end), equality results in continuing through to\n  the next comparison. Just go back to the previous way - each test finds a\n  preference to return, or continues on to let further tests have a go.\n\n  (bgp_best_selection) Get rid of the (struct bgp_maxpaths_cfg *) arg, we\n  can\u0027t add state for every optional feature to the argument list - they\n  have to look it up as needed. Do pass through the very general afi/safi\n  context though (saves several lookups through the route_node).\n\n  Adjust for the new trinary bgp_info_cmp return value and updated args.\n  Do the mpath clearing/accumulation in one place, in each loop.\n\n  Call to bgp_info_mpath_update similarly gets updated, as there\u0027s no cfg to\n  pass.\n\n  (bgp_process_{rsclient,main}) match bgp_best_selection changes.\n* bgp_mpath.c: (bgp_mpath_is_configured_sort) Helper for whether mpath is\n  enabled by peer sort.\n  (bgp_mpath_is_configured) ditto, generally.\n  (bgp_info_mpath_update) caller no longer has the cfg to pass in, look it\n  up.\n* bgp_mpath.h: Export the above and Match .c changes.\n\nRequires commit:\n \"bgpd: bgp_scan shouldn\u0027t queue up route_nodes with no routes for processing\"\n\nSigned-off-by: Donald Sharp \u003csharpd@cumulusnetworks.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "7999d16b6636b5c100d0de4e09e2f607e8d222a6",
      "old_mode": 33188,
      "old_path": "bgpd/bgp_mpath.c",
      "new_id": "98b75b67d32d588cfcc841e233ba0536179d4aec",
      "new_mode": 33188,
      "new_path": "bgpd/bgp_mpath.c"
    },
    {
      "type": "modify",
      "old_id": "37b9ac8b7e217fc50673a661a9a3e1c6722af080",
      "old_mode": 33188,
      "old_path": "bgpd/bgp_mpath.h",
      "new_id": "2a84d5e1e21bb86888b37162b4d9840bc1603ce5",
      "new_mode": 33188,
      "new_path": "bgpd/bgp_mpath.h"
    },
    {
      "type": "modify",
      "old_id": "e0e14eca712154b7859adb55f87a31fc7bf828ef",
      "old_mode": 33188,
      "old_path": "bgpd/bgp_route.c",
      "new_id": "8aa6daa8ed9e6ad70b38992de9b3f850b7fe4ddf",
      "new_mode": 33188,
      "new_path": "bgpd/bgp_route.c"
    },
    {
      "type": "modify",
      "old_id": "ed54d9c11f6f9d67cc68ceb55218ab9e49f68048",
      "old_mode": 33188,
      "old_path": "tests/bgp_mpath_test.c",
      "new_id": "dbbf0dd664eabce050ca25f06b67d5b3d28a8747",
      "new_mode": 33188,
      "new_path": "tests/bgp_mpath_test.c"
    }
  ]
}