[VOL-5100] - periodic-voltha-test-bbsim

[VOL-5101] - voltha testing and kind command version

vars/installKind.groovy
=======================
  o Display command version for logging and to sanity check kind binary.
  o This script was created last year, using groovy + jenkins closures
    in call block to support native syntax like: installKail() { debug:true }.
    Encountered problems earlier, if they persist will revert to using
    normal script method with positional arguments.

jjb/pipeline/voltha/master/bbsim-tests.groovy
=============================================
  o Replaced hardcoded branch != master with isReleaseBranch(name).
  o Remove '|| true' command masking error status.
  o Try out pgrep/pkill commands to simplify usage.
  o Removed '|| true' from gzip/log concatenation commands.
  o Changed vst_venv/ to .venv/ -- newer viritual env directory name.
  o Invoke 'make venv-activate-script' near each python script call
    makefile target dependencies work properly.  Command always
    available and will only install once.
  o Replace "pkill kail || true" with "pgrep --count > 0 && pkill kail".
    The latter syntax will display command errors and will fail a job
    outright when the kail command refuses to terminate.

Change-Id: I6f6628347322486afe820a92f3a3bd3ce5bc6d4d
diff --git a/vars/installKind.groovy b/vars/installKind.groovy
index e22281b..e7cc57a 100644
--- a/vars/installKind.groovy
+++ b/vars/installKind.groovy
@@ -47,7 +47,8 @@
 }
 
 dir="$WORKSPACE/bin"
-if [ ! -f "$dir/kind" ]; then
+cmd="$dir/kind"
+if [ ! -f "$cmd" ]; then
     mkdir -p "$dir"
     pushd "$dir" || error "pushd $dir failed"
     curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.11.0/kind-linux-amd64
@@ -55,6 +56,10 @@
     popd         || error "popd $dir failed"
 fi
 
+## Sanity check installed binary
+echo
+echo "Kind command verison: $("$cmd" --version)"
+
 return
 """)
     println("** ${iam}: LEAVE")